- 18 Jul, 2016 40 commits
-
-
fdoray authored
Why? The fact that there's a MessageLoop on the thread is an unnecessary implementation detail. When browser threads are migrated to base/task_scheduler, tasks will no longer have access to a MessageLoop. These changes were generated manually. BUG=616447 Review-Url: https://codereview.chromium.org/2130443002 Cr-Commit-Position: refs/heads/master@{#406006}
-
alexmos authored
This was introduced in r135340 in an attempt to fix a crash in issue 125969, which it ended up not fixing, but nobody reverted it afterward. It doesn't appear to be necessary. BUG=466297 Review-Url: https://codereview.chromium.org/2145353004 Cr-Commit-Position: refs/heads/master@{#406005}
-
picksi authored
Reland of -enable GPU Rasterization for content with any author defined viewport. (patchset #1 id:1 of https://codereview.chromium.org/2155193002/ ) Reason for revert: CL falsely blamed for red layout test. Relanding it. Original issue's description: > Revert of -enable GPU Rasterization for content with any author defined viewport. (patchset #1 id:1 of https://codereview.chromium.org/2154193002/ ) > > Reason for revert: > Relanding this has potentially caused a layout test to fail (https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/8452). The build sheriff has asked me to revert it. > > Adding aelias & vmiura so they can do a more refined revert on their return from vacation. > > Original issue's description: > > Reland of -enable GPU Rasterization for content with any author defined viewport. (patchset #1 id:1 of https://codereview.chromium.org/2156553002/ ) > > > > Reason for revert: > > Reverting change now that we have collected data from telemetry. > > > > Original issue's description: > > > Revert of Re-enable GPU Rasterization for content with any author defined viewport. (patchset #2 id:20001 of https://codereview.chromium.org/2097413003/ ) > > > > > > Reason for revert: > > > This has caused an unexpectedly large regression in overall PSS (about 5MB, graph here: https://chromeperf.appspot.com/report?sid=0b072725c25637efb0d3a44383da1e24e42bbb3740a00505e4040af2173423b0&start_rev=402061&end_rev=402790). > > > The owners are both OOO and this is blocking Android release. This has already been reverted in the release branch but our infrastructure cannot gather data from the branch to confirm that the revert has had the intended result. > > > > > > This revert will allow us to confirm that this CL was the cause of the regression. Once confirmed (or otherwise) via telemetry dashboards this revert will be re-reverted. > > > > > > Original issue's description: > > > > Re-enable GPU Rasterization for content with any author defined viewport. > > > > > > > > BUG=591179 > > > > > > > > Committed: https://crrev.com/a017b667a53b3ee5f8bc630be98c37ebf53a2339 > > > > Cr-Commit-Position: refs/heads/master@{#402702} > > > > > > TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org > > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > > BUG=591179 > > > > > > Committed: https://crrev.com/10a77702aa0490dfaaa6e354151b24b738474fb4 > > > Cr-Commit-Position: refs/heads/master@{#405750} > > > > TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org,primiano@chromium.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=591179 > > > > Committed: https://crrev.com/5f19720ded2369857bee408ab48e11e7b5d28f7b > > Cr-Commit-Position: refs/heads/master@{#405974} > > TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org,primiano@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=591179 > > Committed: https://crrev.com/1ce44d25cbafd74f034c30ddfd4b0f3caed9978d > Cr-Commit-Position: refs/heads/master@{#405983} TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org,primiano@chromium.org,alexclarke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=591179 Review-Url: https://codereview.chromium.org/2161663002 Cr-Commit-Position: refs/heads/master@{#406004}
-
rdevlin.cronin authored
version_info::Channel is a component, so we can include it in //extensions and clean up a bunch of messy back-and-forth with //chrome. BUG=626774 TBR=jam@chromium.org (chrome_content_client include path change) Review-Url: https://codereview.chromium.org/2141703003 Cr-Commit-Position: refs/heads/master@{#406003}
-
dtapuska authored
Calculate the number of event listener invocations that we didn't actually end up allowing preventDefault to actually execute. The denominator in this metric is the total number of invocations that we force passive on. BUG=625675 Review-Url: https://codereview.chromium.org/2137483003 Cr-Commit-Position: refs/heads/master@{#406002}
-
dgn authored
Registering a KeepAlive during shtudown is forbidden and hits a CHECK, so we should avoid starting some operations that do it. This CL adds checks to avoid such situations: - push notifications received from GCM while shutting down will be dropped early instead of causing a crash and being dropped anyway. - Extension functions using chrome_details validate before running that the browser process is not shutting down. BUG=625646 Review-Url: https://codereview.chromium.org/2118473002 Cr-Commit-Position: refs/heads/master@{#406001}
-
carlosk authored
Just a couple of improvements to MixedContentChecker: - Remove uneeded check for data protocol: it's already included in the protocols checked in SecurityOrigin::isSecure. - Improved check for localhost by name to be more complete. BUG=607878,624275 Review-Url: https://codereview.chromium.org/2151473002 Cr-Commit-Position: refs/heads/master@{#406000}
-
gogerald authored
The flag was removed after generating the full FRE sequence to avoid regenerating the sequence if the activity restarts because of device configuration changes. BUG=626993 Review-Url: https://codereview.chromium.org/2145393004 Cr-Commit-Position: refs/heads/master@{#405999}
-
ulan authored
This patch renames browsing_*.wpr to memory_system_health_*.wpr so that all references in memory_system_health_*.json start with the same prefix 'memory_system_health'. For more context see https://codereview.chromium.org/2144073004/#msg21 BUG=589726 Review-Url: https://codereview.chromium.org/2161583003 Cr-Commit-Position: refs/heads/master@{#405998}
-
nicolaso authored
This a a partial, somewhat naive, fix for a bug where CJK names were split the same way as western names. CJK names have the family name (surname) first, and don't usually have a space in-between the two parts. For a complete fix, we might need to improve Japanese name detection, when there is no space between the two names. It's unclear how often users actually enter their name without spaces in a form field. We might also want to fix the opposite use-case: when the user enters their first & last name in separate fields, we should infer their full name in the right order (with ordering based on the script used). BUG=89111 Review-Url: https://codereview.chromium.org/2132103002 Cr-Commit-Position: refs/heads/master@{#405997}
-
zqzhang authored
This is a test patch that fixes a memory leak caused by the reference between HTMLMediaElement and ElementVisibilityObserver. The previous patch breaks the reference cycle but seems doesn't fix the leak. Using WeakPersistent is a workaround, but seems does not fix the leak entirely. Keeping https://crbug.com/627539 open to keep track of the remaining leaks. BUG=628367,627539 Review-Url: https://codereview.chromium.org/2151243002 Cr-Commit-Position: refs/heads/master@{#405996}
-
chrome://versionjbroman authored
The former is misleading; Chromium hasn't used WebKit for over three years. The Blink version no longer adds more information. Since the repository merge, the Blink version number is a constant 537.36 and its revision always matches the Chromium revision. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2125473002 Cr-Commit-Position: refs/heads/master@{#405995}
-
grt authored
BUG=none R=gab@chromium.org Review-Url: https://codereview.chromium.org/2158813002 Cr-Commit-Position: refs/heads/master@{#405994}
-
davidben authored
https://boringssl.googlesource.com/boringssl/+log/10f97f3bfcecc3fbe8e9f02e7c426f7e340f7f54..8d315d70563b49868469c57199aa5d69c7c818dd BUG=none Review-Url: https://codereview.chromium.org/2156973002 Cr-Commit-Position: refs/heads/master@{#405993}
-
jkrcal authored
When in need of changing variation parameters in unittests, one has to dig unneccessarily deep into the inner workings of variations::. This CL adds a simple class to use in unittests. Simplifying existing unittest code is a matter of further CLs. BUG=629013 Review-Url: https://codereview.chromium.org/2145963002 Cr-Commit-Position: refs/heads/master@{#405992}
-
wuchengli authored
This issue happens when a resolution change happens right after a reset. First the client requests a reset. The image processor is still processing some buffers and they will be ignored when returning to V4L2VideoAccelerator. Then a resolution change occurs and V4L2VDA stops the output queue. The image processor returns a buffer and V4L2VDA queues it back. Since the queue is stopped, STREAMON will be called to start the queue. Finally REQBUFS will fail during resolution change because the queue is not stopped. The fix is we should not queue the buffer returned from image proessor if a resolution change is in progress. BUG=chrome-os-partner:55347 TEST=Seek when playing switch_1080p_720p.mp4 on oak. The video is from gs://chromiumos-test-assets-public/Shaka-Dash. Review-Url: https://codereview.chromium.org/2156003002 Cr-Commit-Position: refs/heads/master@{#405991}
-
dnicoara authored
If a display power change request arrives before the previous one finishes or if a previous power change request failed the state becomes inconsistent and future requests are optimized out. BUG=627795 TEST=New unittest in display_unittests and manually checked on Samus Review-Url: https://codereview.chromium.org/2154743003 Cr-Commit-Position: refs/heads/master@{#405990}
-
wuchengli authored
This reverts commit d3e00ac3. ChromeOS would crash at boot and could not reach login screen with commit d3e00a. BUG=chromium:593461 TBR=dpranke@chromium.org TBR=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2155183002 Cr-Commit-Position: refs/heads/master@{#405989}
-
grt authored
Revert of New PaintController under-invalidation checking (patchset #7 id:120001 of https://codereview.chromium.org/2114653003/ ) Reason for revert: NOTREACHED being hit in checkUnderInvalidation on WebKit Win7 (dbg); see https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/6481. Original issue's description: > New PaintController under-invalidation checking > > This is a follow-up of https://codereview.chromium.org/2107103002/ > which broke the original under-invalidation checking in > PaintController. > > BUG=596983,510908 > > Committed: https://crrev.com/63b12484f2c59ba177a21aba09b8a4edd38e6ea1 > Cr-Commit-Position: refs/heads/master@{#405805} TBR=chrishtr@chromium.org,pdr@chromium.org,wangxianzhu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=596983,510908 Review-Url: https://codereview.chromium.org/2156053002 Cr-Commit-Position: refs/heads/master@{#405988}
-
jgruber authored
BUG=624285 Review-Url: https://codereview.chromium.org/2147213003 Cr-Commit-Position: refs/heads/master@{#405987}
-
pkalinnikov authored
Add template type parameter to KMP, fuzzy and URL pattern matching tools. The introduced IntType parameter denotes the type of the failure function elements. Use uint8_t to store failure functions of URL patterns in the FlatBuffer. BUG=609747 Review-Url: https://codereview.chromium.org/2153743002 Cr-Commit-Position: refs/heads/master@{#405986}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/946f9cc0..db420127 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2156943002 Cr-Commit-Position: refs/heads/master@{#405985}
-
siggi authored
BUG=550886 Review-Url: https://codereview.chromium.org/2143693003 Cr-Commit-Position: refs/heads/master@{#405984}
-
picksi authored
Revert of -enable GPU Rasterization for content with any author defined viewport. (patchset #1 id:1 of https://codereview.chromium.org/2154193002/ ) Reason for revert: Relanding this has potentially caused a layout test to fail (https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/8452). The build sheriff has asked me to revert it. Adding aelias & vmiura so they can do a more refined revert on their return from vacation. Original issue's description: > Reland of -enable GPU Rasterization for content with any author defined viewport. (patchset #1 id:1 of https://codereview.chromium.org/2156553002/ ) > > Reason for revert: > Reverting change now that we have collected data from telemetry. > > Original issue's description: > > Revert of Re-enable GPU Rasterization for content with any author defined viewport. (patchset #2 id:20001 of https://codereview.chromium.org/2097413003/ ) > > > > Reason for revert: > > This has caused an unexpectedly large regression in overall PSS (about 5MB, graph here: https://chromeperf.appspot.com/report?sid=0b072725c25637efb0d3a44383da1e24e42bbb3740a00505e4040af2173423b0&start_rev=402061&end_rev=402790). > > The owners are both OOO and this is blocking Android release. This has already been reverted in the release branch but our infrastructure cannot gather data from the branch to confirm that the revert has had the intended result. > > > > This revert will allow us to confirm that this CL was the cause of the regression. Once confirmed (or otherwise) via telemetry dashboards this revert will be re-reverted. > > > > Original issue's description: > > > Re-enable GPU Rasterization for content with any author defined viewport. > > > > > > BUG=591179 > > > > > > Committed: https://crrev.com/a017b667a53b3ee5f8bc630be98c37ebf53a2339 > > > Cr-Commit-Position: refs/heads/master@{#402702} > > > > TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=591179 > > > > Committed: https://crrev.com/10a77702aa0490dfaaa6e354151b24b738474fb4 > > Cr-Commit-Position: refs/heads/master@{#405750} > > TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org,primiano@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=591179 > > Committed: https://crrev.com/5f19720ded2369857bee408ab48e11e7b5d28f7b > Cr-Commit-Position: refs/heads/master@{#405974} TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org,primiano@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=591179 Review-Url: https://codereview.chromium.org/2155193002 Cr-Commit-Position: refs/heads/master@{#405983}
-
droger authored
webp_transcode is now only used from ios/chrome/browser. BUG=627509 TBR=jam Review-Url: https://codereview.chromium.org/2146833002 Cr-Commit-Position: refs/heads/master@{#405982}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8ae70d714551..d2b666834a28 $ git log 8ae70d714..d2b666834 --date=short --no-merges --format='%ad %ae %s' BUG=627166 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2157923002 Cr-Commit-Position: refs/heads/master@{#405981}
-
tapted authored
r141724 added code to the toolkit-views content settings bubble to disable the radio buttons on a content settings popup if the setting was controlled by enterprise policy, but this never made it to Cocoa. Fix Cocoa by calling setEnabled on the NSMatrix of radio buttons. Pass the value ContentSettingBubbleModel::BubbleContent::radio_group_enabled. Screenshot at http://crbug.com/509249#c30 BUG=509249, 98029 Review-Url: https://codereview.chromium.org/2153393002 Cr-Commit-Position: refs/heads/master@{#405980}
-
msramek authored
This was extracted from https://codereview.chromium.org/2025683003/ where it will be needed for ChromeContentBrowserClient tests. BUG=607897 Review-Url: https://codereview.chromium.org/2161583002 Cr-Commit-Position: refs/heads/master@{#405979}
-
valentin.ilie authored
Enhance chrome.app.window API with the possibility of creating a window that will show up separately in the shelf, tied to its own icon. Added a new property, showInShelf, to CreateWindowOptions. Default value for the property is false. Based on https://codereview.chromium.org/1811523002Co-Authored-By:
Paul Sapunaru <paul.sapunaru@intel.com> Co-Authored-By:
Andra Paraschiv <andra.paraschiv@intel.com> BUG=610299 TEST=interactive_ui_tests Implement a simple extension that creates windows with the property set to true. Observe that the newly created windows are added as separate icons in the shelf. Review-Url: https://codereview.chromium.org/1914993002 Cr-Commit-Position: refs/heads/master@{#405978}
-
lizeb authored
Revert of Calculate correct cull rect for SVG inline text boxes. (patchset #4 id:60001 of https://codereview.chromium.org/2151323004/ ) Reason for revert: Broke WebKit Android (Nexus4). BUG=629023,627233 Original issue's description: > Calculate correct cull rect for SVG inline text boxes. > > Cull rects were larger than needed when text was selected. > > Identified while investigating test failure of: > > svg/text/text-selection-align-06-b.svg > > as part of http://crrev.com/2073563002 for crbug.com/616600, though > fixing these did not actually fix any issues for that patch or bug. > > Reland of http://crrev.com/2137753002 with updated test to > approximate expected rects to allow for minor font metrics differences > across platforms. Notably, previous patch failed on Android Nexus 4 > due to 1 - 2 pixel deltas. > > BUG=627233 > TBR=pdr > > Committed: https://crrev.com/344d1d48097756a754766c75b9c49c756f85d20e > Cr-Commit-Position: refs/heads/master@{#405920} TBR=pdr@google.com,wkorman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2161573002 Cr-Commit-Position: refs/heads/master@{#405977}
-
johnme authored
https://codereview.chromium.org/2133673002 added a new PushSubscriptionOptions interface, but forgot to mark it as not exposed in WebView (since the Push API is not supported there). Hence that patch broke WebViewLayoutTest#testWebViewIncludedStableInterfaces. This patch fixes that. BUG=626627,629049 TBR=lizeb@chromium.org,timvolodine@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2159713002 Cr-Commit-Position: refs/heads/master@{#405976}
-
harkness authored
currently plugged into the BackgroundBudgetService, but will be in future work. It will be able to store objects that fit the Budget protobuf type, which has pieces of budget that have been allocated, an expiration time for those pieces, and how much (if any) in debt a service worker is. BUG=617971 Review-Url: https://codereview.chromium.org/2107173002 Cr-Commit-Position: refs/heads/master@{#405975}
-
picksi authored
Reland of -enable GPU Rasterization for content with any author defined viewport. (patchset #1 id:1 of https://codereview.chromium.org/2156553002/ ) Reason for revert: Reverting change now that we have collected data from telemetry. Original issue's description: > Revert of Re-enable GPU Rasterization for content with any author defined viewport. (patchset #2 id:20001 of https://codereview.chromium.org/2097413003/ ) > > Reason for revert: > This has caused an unexpectedly large regression in overall PSS (about 5MB, graph here: https://chromeperf.appspot.com/report?sid=0b072725c25637efb0d3a44383da1e24e42bbb3740a00505e4040af2173423b0&start_rev=402061&end_rev=402790). > The owners are both OOO and this is blocking Android release. This has already been reverted in the release branch but our infrastructure cannot gather data from the branch to confirm that the revert has had the intended result. > > This revert will allow us to confirm that this CL was the cause of the regression. Once confirmed (or otherwise) via telemetry dashboards this revert will be re-reverted. > > Original issue's description: > > Re-enable GPU Rasterization for content with any author defined viewport. > > > > BUG=591179 > > > > Committed: https://crrev.com/a017b667a53b3ee5f8bc630be98c37ebf53a2339 > > Cr-Commit-Position: refs/heads/master@{#402702} > > TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=591179 > > Committed: https://crrev.com/10a77702aa0490dfaaa6e354151b24b738474fb4 > Cr-Commit-Position: refs/heads/master@{#405750} TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org,primiano@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=591179 Review-Url: https://codereview.chromium.org/2154193002 Cr-Commit-Position: refs/heads/master@{#405974}
-
mkwst authored
At https://github.com/w3c/webappsec-secure-contexts/issues/28, we're discussing whether or not we can tighten the notion of "secure context" to exclude sandboxed documents by default. This patch adds counters to determine how marginal the breakage would be. BUG=534788 TBR=isherman@chromium.org Review-Url: https://codereview.chromium.org/2160533002 Cr-Commit-Position: refs/heads/master@{#405973}
-
vkuzkokov authored
BUG=627109 Review-Url: https://codereview.chromium.org/2126203002 Cr-Commit-Position: refs/heads/master@{#405972}
-
lizeb authored
Revert of Credit card editor for PaymentRequest UI. (patchset #5 id:490001 of https://codereview.chromium.org/2116583002/ ) Reason for revert: Broke Android Tests (dbg). BUG=629011,624924 Original issue's description: > Credit card editor for PaymentRequest UI. > > When user taps on an incomplete autofill credit card or [+ ADD CARD] > button, the card editor launches. > > For server cards, the editor shows uneditable card information and lets > the user set the billing address. > > For local cards, the editor shows the following fields. > > 1) A list of icons for supported card types. > > 2) The card number input with Luhn validation and formatting. Required > field. > > 3) The name on card input. Required field. > > 4) The month and year dropdowns. January of this year by default for new > cards. > > 5) The billing address dropdown with only complete addresses on disk and > an option to add a new address. Required field. > > 6) A checkbox for saving the new card on disk. Checked by default, > so it behaves similar to autofill settings. > > BUG=624924 > > Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea > Cr-Commit-Position: refs/heads/master@{#405876} TBR=mathp@chromium.org,dfalcantara@chromium.org,estade@chromium.org,rouslan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2158783002 Cr-Commit-Position: refs/heads/master@{#405971}
-
sdefresne authored
It is technically possible to build a fat binary that works on both simulator and device, thus the use_ios_simulator value depends on the cpu from the current toolchain (aka current_cpu) and not the cpu from the default toolchain (aka target_cpu). BUG=625875 Review-Url: https://codereview.chromium.org/2150433003 Cr-Commit-Position: refs/heads/master@{#405970}
-
sdefresne authored
For a fat build, the "ios_framework_bundle" and "framework_bundle" are a bit different for the non-default toolchain. The main target is a shared library (instead of a bundle) and the "+link" target depends on the "+link" target of the default toolchain (because it is a fat binary framework so it make sense to link against that one). The fat shared library is created using "lipo" to concatenate all the thin shared libraries together. BUG=603180 Review-Url: https://codereview.chromium.org/2135323002 Cr-Commit-Position: refs/heads/master@{#405969}
-
markusheintz authored
Revert of [Payments] Add ability to bold parts of addresses (patchset #4 id:60001 of https://codereview.chromium.org/2135573004/ ) Reason for revert: Android Test builder is failing since https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35304 see https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35304/steps/chrome_public_test_apk/logs/stdio This may be one of two CLs that could have caused this (the other is https://codereview.chromium.org/2116583002). Since the two CLs have some files in common I'll start reverting this one first. Original issue's description: > [Payments] Add ability to bold parts of addresses > > * Add the ability to bold parts of a label. > > * Add the ability to show a tertiary label in the PaymentOption, which > will later be used for phone number display. > > * The phone number is passed in to the PaymentOption using the new constructor > via the AutofillAddress class. > > See crbug.com/626833 for screenshots. > > BUG=603635,626833 > > Committed: https://crrev.com/92f4c6ac21b2578ab3938c5bd3eb0f793621164f > Cr-Commit-Position: refs/heads/master@{#405900} TBR=rouslan@chromium.org,mathp@chromium.org,dfalcantara@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=603635,626833 Review-Url: https://codereview.chromium.org/2158763002 Cr-Commit-Position: refs/heads/master@{#405968}
-
jgruber authored
This ensures that either an exception is thrown, or a promise is rejected, never both. BUG=628526 Review-Url: https://codereview.chromium.org/2156583002 Cr-Commit-Position: refs/heads/master@{#405967}
-