GitLab

AppListButton tracks per-display [target] visibility.
(sets a new flag on Shown/Dismissed callbacks)

Check widget/button state, not global shell state.
Ignore dismissed app-list windows that are animating closed.

Fix a ShelfLayoutManager test to actually catch this.

BUG=654661
TEST=Shelf stays visible when the app-list is hidden.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2534953006
Cr-Commit-Position: refs/heads/master@{#435554}

Display configuration takes some time on real devices. Add in a 200ms
delay from when Configure() is called to when the callback is triggered
so off device timing is similar to on device timing.

BUG=none

Review-Url: https://codereview.chromium.org/2527263002
Cr-Commit-Position: refs/heads/master@{#435553}

This disables the 'focus and keyboard nav' test and re-enables
the rest of HistoryListTest.

BUG=669227

Review-Url: https://codereview.chromium.org/2545603003
Cr-Commit-Position: refs/heads/master@{#435552}

In download_to_file mode of resource loading, the resource handler needs
to call ResourceDispatcherHostImpl::RegisterDownloadedTempFile when the
file is created, and needs to call UnregisterDownloadedTempFile after the
client handles the file. Otherwise, the file is deleted before the client
uses it.
However, MojoAsyncResourceHandler doesn't call them, and that causes
layout test failure around XHR with responseType = 'blob'. This CL fixes
that by adding the RDTF and UDTF pair, and refactors similar code in
AsyncResourceHandler to share the same lifetime management of the
downloaded file in ResourceDispatcherHostImpl.

BUG=603396, 659917

Review-Url: https://codereview.chromium.org/2503813002
Cr-Commit-Position: refs/heads/master@{#435551}

In this cl, we are trying to add the logcat of each instrumentation
test into the corresponding test result object, so that when we are
checking the result of each test case, we would be able to see the
corresponding logcat for that test case at the same time.

The reason of reland is to fix the issue where environmental variables are not set.

BUG=631213

Review-Url: https://codereview.chromium.org/2545653002
Cr-Commit-Position: refs/heads/master@{#435550}

Added initial_keyword flag to CSSProperties.in, which specifies the
initial value for keyword-only properties generated in ComputedStyle.

BUG=628043

Review-Url: https://codereview.chromium.org/2538493005
Cr-Commit-Position: refs/heads/master@{#435549}

Cr-Commit-Position: refs/heads/master@{#435548}

This CL hooks up the toolbar forward and backward buttons in grouped mode to
change the search timeframe for week and month queries.

BUG=589357
TBR=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2481693002
Cr-Commit-Position: refs/heads/master@{#435547}

This patch switches to a create-or-update pattern for paint property
updates of the local border box. This is a 6% improvement on
large-table-collapsed-border-change-with-text [1].

[1] tools/perf/run_benchmark blink_perf.paint --browser=content-shell-release --pageset-repeat=5 --extra-browser-args=--enable-slimming-paint-v2

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2538273002
Cr-Commit-Position: refs/heads/master@{#435546}

1) Make the menu panel have a width of 352px, same as the system menu.
2) Move up title row label 5px.

BUG=663199
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2540103003
Cr-Commit-Position: refs/heads/master@{#435545}

Map each URLRequest originating from a frame to its DataUseRecorder.
Create a new DataUseRecorder for each URLRequest from Chrome services.
Move DataUseRecorders from pending navigation map to render frame
map when navigation commits.

BUG=663532

Review-Url: https://codereview.chromium.org/2534023002
Cr-Commit-Position: refs/heads/master@{#435544}

This changes the spacing between cards from 20px to 16px.

BUG=670049
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2538333002
Cr-Commit-Position: refs/heads/master@{#435543}

Patch crrev.com/2534383002 introduced flexbox layout for suggestion items.
However, it should also be more accurate with item flexing, which gets
messed up in some rare cases.

This patch wraps suggestion text in its own span so that it shrinks
properly.

BUG=669323
R=dgozman

Review-Url: https://codereview.chromium.org/2535393004
Cr-Commit-Position: refs/heads/master@{#435542}

Added ordering warnings back for CSSValueKeywords.in, since the order
in this file must match the order in CSSParserFastPaths until the fast
paths file is generated.

BUG=665272

Review-Url: https://codereview.chromium.org/2537393002
Cr-Commit-Position: refs/heads/master@{#435541}

https://skia.googlesource.com/skia.git/+log/3a7492fc04d8..f447deea6289

$ git log 3a7492fc0..f447deea6 --date=short --no-merges --format='%ad %ae %s'
2016-11-29 mtklein support medium and high quality
2016-11-30 halcanary SkEncodeImage: no more link-time registration

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@google.com

Review-Url: https://codereview.chromium.org/2538083004
Cr-Commit-Position: refs/heads/master@{#435540}

Now callers directly specify what type of pointer they want IDMap to
hold using the template parameter.

Part 1 is at https://codereview.chromium.org/2480293004/

BUG=647091

TBR=dbeam (for chrome/browser/ui/webui/options/certificate_manager_handler.cc)
TBR=jam (for all other non-base/ changes)

Review-Url: https://codereview.chromium.org/2496653002
Cr-Commit-Position: refs/heads/master@{#435539}

The message parameter source_tab_id is no longer used; remove it. By
extension, also remove the opener_tab_id_ property from
ExtensionMessagePorts.

BUG=667584

Review-Url: https://codereview.chromium.org/2540533002
Cr-Commit-Position: refs/heads/master@{#435538}

Move the ChromeExtensionTestNotificationObserver and
ExtensionTestNotificationObserver classes into the extensions namespace.

BUG=None
TBR=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2539623002
Cr-Commit-Position: refs/heads/master@{#435537}

BUG=chromium:663372
R=stip@chromium.org

Review URL: https://codereview.chromium.org/2540743004 .

Cr-Commit-Position: refs/heads/master@{#435536}

This roll includes:
  - [inspector_protocol] always use weak pointer in DispatcherImpl::{command.name} [1]

[1] https://codereview.chromium.org/2545613002/

BUG=chromium:668358
TBR=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2538043003
Cr-Commit-Position: refs/heads/master@{#435535}

There are some Chrome services that unconditionally try to call ARC
code, and the latter will print stuff to the log if it's not enabled or
avilable (yet). This change ensures that we only attempt to contact ARC
when it is actually ready for the most chatty services: net and process.

BUG=654038
TEST=Opted out of ARC, did not see any logs

Review-Url: https://codereview.chromium.org/2541843003
Cr-Commit-Position: refs/heads/master@{#435534}

This picks up various fixes noted by scottmg@chromium.org,
thakis@chromium.org, and Twitter user @florpelier, as well as a few
more things I wanted to clean up.

R=scottmg@chromium.org, thakis@chromium.org, sdy@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2543503004
Cr-Commit-Position: refs/heads/master@{#435533}

Two updates are proposed for clang scripts:
An optional parameter is added to run_tool.py called (tool-param) that is directly passed to the tool that is run.
An optional parameter is added to generate_win_compdb.py to specify the build directory. Its default value is out/Debug so that it won't change the previous behavior.

BUG=670072

Review-Url: https://codereview.chromium.org/2542563002
Cr-Commit-Position: refs/heads/master@{#435532}

This is a follow-up to http://crrev.com/2514253002.

BUG=660580

Review-Url: https://codereview.chromium.org/2524653003
Cr-Commit-Position: refs/heads/master@{#435531}

This patch renames ImageDecodeController to ImageDecodeCache, along
with software and gpu implementations.

R=enne@chromium.org, ericrk@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2541183002
Cr-Commit-Position: refs/heads/master@{#435530}

BUG=660445

Review-Url: https://codereview.chromium.org/2523783002
Cr-Commit-Position: refs/heads/master@{#435529}

Have all overloads of webcrypto::AlgorithmImplementation::DeserializeKeyForClone check the params type.

Presently neither this nor the calling code checks that the algorithm ID
and key params type correspond correctly. This code already knows what
the expected value is, so it seems a reasonable place to check.

BUG=669649

Review-Url: https://codereview.chromium.org/2544533002
Cr-Commit-Position: refs/heads/master@{#435528}

BUG=chromium:669526

Review-Url: https://codereview.chromium.org/2534243002
Cr-Commit-Position: refs/heads/master@{#435527}

Review-Url: https://codereview.chromium.org/2536323003
Cr-Commit-Position: refs/heads/master@{#435526}

In certain cases, it is important to be able to specify different command line arguments to chrome at the time the test is being run rather than what is in code. For example, running against a different proxy than is in the code.
This CL turns on the handling for this functionality and fixes a few bugs with it.

BUG=669956

Review-Url: https://codereview.chromium.org/2538773004
Cr-Commit-Position: refs/heads/master@{#435525}

Command line option '--gtest_also_run_disabled_tests' already exists in
test_runner.py, should build the logic in local_device_gtest_run.py in
order to run disabled tests.

This CL also unify '--gtest_repeat' for instrumentation test options.

BUG=669632

Review-Url: https://codereview.chromium.org/2544603002
Cr-Commit-Position: refs/heads/master@{#435524}

BUG=542537

Review-Url: https://codereview.chromium.org/2542793002
Cr-Commit-Position: refs/heads/master@{#435523}

We need paint property tree for slimmingPaintInvalidation.

BUG=646176

Review-Url: https://codereview.chromium.org/2540353002
Cr-Commit-Position: refs/heads/master@{#435522}

BUG=663217

Review-Url: https://codereview.chromium.org/2509143002
Cr-Commit-Position: refs/heads/master@{#435521}

BUG=669698

Review-Url: https://codereview.chromium.org/2536373006
Cr-Commit-Position: refs/heads/master@{#435520}

Originally landed in r432129 and r434618. Reverting so we can merge
the revert to M56, then will re-land and keep tweaking on trunk.

BUG=662501,667439
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=oshima,sadrul,michaelpg

Review-Url: https://codereview.chromium.org/2535723008
Cr-Commit-Position: refs/heads/master@{#435519}

BUG=

Review-Url: https://codereview.chromium.org/2470283002
Cr-Commit-Position: refs/heads/master@{#435518}

This test is failing on all bots. Disable for now to turn the bots green
again.

BUG=670069
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
TBR=sullivan,yukishiino

Review-Url: https://codereview.chromium.org/2543783002
Cr-Commit-Position: refs/heads/master@{#435517}

chromium-style enforces a private or protected destructor for classes
that derive from RefCounted<> which in turn makes it necessary to add a
friend declaration for RefCounted<>.

BUG=none

Review-Url: https://codereview.chromium.org/2533243002
Cr-Commit-Position: refs/heads/master@{#435516}

Currently, exposing a JavaScript API change as an origin trial requires
manual code changes to V8 bindings. The necessary binding changes were
missing when Long Task Observer was integrated with the origin trials
framework.

This CL adds the missing call to the generated method:
V8Window::installLongTaskObserver()

BUG=667795

Review-Url: https://codereview.chromium.org/2533793003
Cr-Commit-Position: refs/heads/master@{#435515}