- 31 Mar, 2020 40 commits
-
-
Mila Green authored
With this CL we are properly dialing the XPC connection and sending messages. This also fixes the issues with the StateChangeCallback being sent over XPC. Bug: 1055876 Change-Id: I81077476e49be486620ae4e2eb8cba022c3ae4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124933 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754971}
-
Mirko Bonadei authored
No behavior change is expected, this CL only goal is to have one .gni file in absl in order to maintain it more easily. Bug: None Change-Id: I2694a1689755395a855cca94c49152477e5017f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128077Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#754970}
-
Xiaocheng Hu authored
This patch is analogous to the WebKit patch for a common issue: https://trac.webkit.org/changeset/254800/webkit When sanitizing the clipboard markup in a dummy document, we disable scripting, and parse <noscript> in the script-disabled mode. Then we parse the sanitized markup in script-enabled mode when inserting it into the real document. This allows an XSS attack. This patch introduces a new flag to page settings that allows it to parse with the scripting flag enabled, while still disabling script execution. It also renames the |HTMLParserOptions::script_enabled| flag to |scripting_flag| to improve clarity and match the term in the HTML spec (https://html.spec.whatwg.org/#scripting-flag). Bug: 1065761 Change-Id: Ia4bd67a991b354eebd2cbfef6d3291230ddc1f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128839Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#754969}
-
Mario Sanchez Prada authored
This fix normalizes the current situation where we have these files: wpt/css/css-flexbox/flexbox-overflow-auto-001.html wpt/css/css-flexbox/flexbox-overflow-auto-002.html wpt/css/css-flexbox/overflow-auto-001.html wpt/css/css-flexbox/overflow-auto-002.html wpt/css/css-flexbox/overflow-auto-003.html wpt/css/css-flexbox/overflow-auto-004.html ...into a more consistent file naming scheme for this type of tests: wpt/css/css-flexbox/overflow-auto-001.html wpt/css/css-flexbox/overflow-auto-002.html wpt/css/css-flexbox/overflow-auto-003.html wpt/css/css-flexbox/overflow-auto-004.html wpt/css/css-flexbox/overflow-auto-005.html wpt/css/css-flexbox/overflow-auto-006.html Bug: 1063749 Change-Id: I5d73bb4d54ee536a8a1894428cb557ea1be95f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129531 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#754968}
-
Stephen McGruer authored
'assert_throws' has been deprecated in WPT, replaced by JS and DOM-specific variants. http/tests/mojo should use the JS variant, but that requires mojo.test.InputError to be a real Error subclass. Bug: 1051932 Change-Id: Icdc16cc69a856f3cfb65c0e6686f91d5bcf0eae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125949Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#754967}
-
Lei Zhang authored
As well as the associated entries in XTB files. Change-Id: I0ef1e01db82ed873557c67ca1908e8efcc04e5e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839633 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#754966}
-
Dan Harrington authored
Change-Id: I1faa3b68726e1798c08d2d29b2fb8a2c81e23d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128469Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#754965}
-
Thiemo Nagel authored
Adjusting Managed Guest Session (MGS) permission warning flags according to consensus between commercial and privacy teams. Due to privacy concerns, removing whitelisting for permissions that provide direct access to user data. Further, to reduce scope, removing unnecessarry whitelisting for permissions of the following categories: * private/internal * lacking public documentation * non-stable channel or otherwise experimental or deprecated * inapplicable to MGS, e.g. kiosk-specific permissions Bug: 1015378 Change-Id: Id677c8639d94cc1b6478d5bf9b469648d202ce04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124266 Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#754964}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9120bcae6c53..dbb23ec3589f git log 9120bcae6c53..dbb23ec3589f --date=short --first-parent --format='%ad %ae %s' 2020-03-31 ancheng.qiao@arm.com Vulkan: Remove swiftshader mipmap3d test skip Created with: gclient setdep -r src/third_party/angle@dbb23ec3589f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I47ca81d948f5ee957ed5cf99267f864ed2553053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754963}
-
Matt Jones authored
This patch adds a flag to the ToolbarManager to check whether the scrim was actually shown since the timing of the show request can vary. Bug: 1065480 Change-Id: I254d1425c58bfe05ae97a609097a2e75b6908933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129847Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#754962}
-
Samuel Huang authored
This CL gets some simple fixes out of the while, found while prototyping support for multiple input files. Bug: 900259, 1040645 Change-Id: Ifc7ba4395108b356d754e13d468af7e6ca8f4cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129785 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#754961}
-
Dominic Farolino authored
This CL disables image lazy loading for images in frames in which scripting is disabled. The HTML Standard mandates that image lazy loading be disabled in these cases, as a privacy-protection measure. See [1]. [1]: https://html.spec.whatwg.org/multipage/images.html#will-lazy-load-image-steps R=kinuko@chromium.org, sclittle@chromium.org Bug: 1005881 Change-Id: Ib675b46ee1d9bb10119172893547cb80b0308ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127415 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#754960}
-
Nohemi Fernandez authored
Moves all logging into the user sign-in workflow and improves existing tests for add account. Bug: 971989 Change-Id: Id6804607c81eed23ade30863d9741f4302341052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116177 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#754959}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bc44331c334d..937cfa8b7e10 git log bc44331c334d..937cfa8b7e10 --date=short --first-parent --format='%ad %ae %s' 2020-03-31 fmayer@google.com Merge "Check for build type, not debuggable, for extra guardrails test." 2020-03-31 treehugger-gerrit@google.com Merge "tp: fix import of systrace files with trailing newlines" Created with: gclient setdep -r src/third_party/perfetto@937cfa8b7e10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3af340fdc2985df0e545d359149117de2c2d19ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129849Reviewed-by:
-
Wenyu Fu authored
MainSettings.java have bit less test coverage over some of the preferences, for example, the HomepageSettings at this moment. Adding MainSettingsFragmentTest is aiming for more test coverage for the list of preferences on the settings screen. Bug: 1052060, 1066362 Change-Id: Ib51c133f2a73f4ec85cc185c4101833bc3fa0b58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124729 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#754957}
-
danakj authored
Move kRunWebTests up to shell_switches.h as it is a switch to control content shell, causing it to inject web test code. Introduce DEPS rule to disallow content/shell/ to use content/shell/common/web_test content/shell/renderer/web_test Allow content/shell/test_runner to still access these, as it is part of web test code. Allow content/shell/app/shell_main_delegate.cc to access content/shell/renderer/web_test/ content/shell/browser/web_test/ in order to inject web test behaviour into the application at run-time. R=nasko@chromium.org Bug: 866140 Change-Id: I3c0ca417b537506f6d7fad55c4a1bb5e495d94c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122462 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, creating a Payment Request for "https://play.google.com/billing" would attempt to find installed or JIT installable service worker payment handlers. This patch removes "https://play.google.com/billing" from the list of payment methods for which service worker payment handlers should be looked up. After this patch, Chrome does not attempt to download manifests for the Google Play Billing payment method. Bug: 1062372 Change-Id: Ie16e1d0bcd5480677240a8551c8072258a266572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108849 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#754955}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9e1f2e47..143da7b3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I82239cd0d315712e585a4542f48131a658967f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129806Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754954}
-
Maciej Pawlowski authored
BookmarkHTMLWriter now notifies its observer also in case of an export failure. This allows the test to gracefully fail in case a write to disk fails, rather than time out, waiting for a success notification that never arrives. Bug: 1064545 Change-Id: Iaf6e0b835e822b1d62283ad3ec60dceefbc3ef10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119858Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maciej Pawlowski <mpawlowski@opera.com> Cr-Commit-Position: refs/heads/master@{#754953}
-
Mark Cogan authored
In order to remove explicit dependencies on the BVC, this CL takes the initial step of using the |viewController| property in BrowserInterface instead of |bvc| wherever possible. It also uses the Browser's command dispatcher (through HandlerForProtocol or a static cast) instead of the BVC's |dispatcher| property. Remaining uses of the BVC property of browserInterface after this CL are limited to (a) SceneController, and (b) BVC-specific public API, which will be factored away in future CLs. As related cleanup, the settings nav controller delegate property is renamed from "dispatcherForSettings" to "handlerForSettings". Change-Id: I1a10e7b1655f22f6559249597a6f4f467ed9ed87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124668Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#754952}
-
Jian Li authored
This is the bridge class that lets Android code access native code for feed related functionalities. Bug: 1044139 Change-Id: I59b5857c81b6fb256d6db74db3b4f8860b926fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127729Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
-
Scott Violet authored
BUG=1066263 TEST=none, doc only change Change-Id: Id0ea73c1588601cf9fd29f68c62b14a3d28c75fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128977 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#754950}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/65d3ad953957..469046c09657 git log 65d3ad953957..469046c09657 --date=short --first-parent --format='%ad %ae %s' 2020-03-31 bsalomon@google.com Revert "Revert "Remove GrCaps::isFormatTexturableAndUploadable"" Created with: gclient setdep -r src/third_party/skia@469046c09657 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: I68c6b38e919677269e1beee5973faa8afa09dd97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129784Reviewed-by:
-
Mohsen Izadi authored
Existing LatencyInfo-based event latency metrics measure the time between event creation timestamp and gpu-swap-end. To be able to verify new event latency metrics against them, we need add similar metrics for new EventLatency metrics. This is only added for scroll events as LatencyInfo-based metrics only exist for scroll events. Bug: 1057193 Change-Id: I73169330a4ffb0e4b5fd9506960a5737624867bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129215Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#754948}
-
Gabriel Charette authored
R=altimin@chromium.org Bug: 1002654 Change-Id: Iaa1c7911326bb0280766b2df045f5401b1f5110c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849127 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754947}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d2aa8f97f109..4b425aeef9cd git log d2aa8f97f109..4b425aeef9cd --date=short --first-parent --format='%ad %ae %s' 2020-03-31 peah@webrtc.org AEC3: Correct peak index at filter size reductions Created with: gclient setdep -r src/third_party/webrtc@4b425aeef9cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1061933 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0105a85497772230ef18b6c440c1ea08eb78af4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129779Reviewed-by:
-
Anatoliy Potapchuk authored
This CL updates the app launch screen, additionally surfacing app origin. This help users be aware of the app that is being launched. Bug: 1046260 Change-Id: Ibc525ddb50ba233dd6da1986a228e8b216719c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127686 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754945}
-
Becca Hughes authored
For Media History we have a sessions table that records media sessions that we can resume. At the moment we are only interested in video with audio. This adds a MediaAudioVideoState enum that contains data about whether a media session is audio only or has both audio and video. For web sessions, this will follow the routed frame since that is where the metadata we are using for media history is coming from. BUG=1041662 Change-Id: I75d93e339de8e221d8798ee2508aacda0f120b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036772Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#754944}
-
Benoit Lize authored
Blink doesn't have direct access to the filesystem, by design of its sandbox. As a consequence, all disk accesses must be brokered by a privileged process, typically the browser. However, there are cases where file access should be managed by the renderer. For instance, when synchronous access is required from the renderer process. To that end, we add a DiskDataAllocator, handling read/writes to disk that are fully managed from the renderer process, and multiplexed onto a single file descriptor. The single file descriptor model is selected to avoid bumping into file descriptor limits, and to reduce performance and space overhead in cases where many small pieces of data are written. The intended client for this allocator is ParkableString, see the linked bug for details. Concretely: 1. The browser process creates a writable file, and passes it to the renderer over mojo 2. The renderer can service reads and writes using this single file descriptor. It is the browser process' responsibility to make sure the file is properly deleted once the renderer dies. From the client perspective, reading and writing are synchronous operations. However writing must be done from a single background sequence. Space allocation in the file is done using a "exact, then worst" fit policy. This policy may be adjusted in the future. Bug: 1029320 Change-Id: Ie65bfd82dc0e702b4427d4e69858ab2ae4f4c06b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107538 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#754943}
-
Chris Dalton authored
Change-Id: I7e655df88153484783b2df5123054dc751307b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128453Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Chris Dalton <csmartdalton@chromium.org> Cr-Commit-Position: refs/heads/master@{#754942}
-
Avi Drissman authored
System-provided objects that implement MTLDevice should derive from NSObject. It would be silly if they didn't, given that the MTLDevice protocol inherits from the NSObject protocol. However, if for some reason this turns out to no longer be true in some future macOS, crash early so that it's obvious what's wrong. Bug: 1065146 Tbr: ccameron@chromium.org Change-Id: I9c59d57c9a4e18ad1b6860971bfb27a731eb9140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129031Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#754941}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2dbeb5da18b1..68cc95ec121c git log 2dbeb5da18b1..68cc95ec121c --date=short --first-parent --format='%ad %ae %s' 2020-03-31 tvanderlippe@chromium.org Remove support for front_end fallback in unittests Created with: gclient setdep -r src/third_party/devtools-frontend/src@68cc95ec121c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7b3311d2dd3bf70e83b397bd24800ce57f36f46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129846Reviewed-by:
-
Hailey Wang authored
Track PageNodes that are in to_load/initiated_load/loading states. Used to restrict maximum simultaneous load in future cl. Bug: 1059341 Change-Id: I76f02d2620fd2fb22c34358453750b20503bc921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118177 Commit-Queue: Hailey Wang <haileywang@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#754939}
-
Devlin Cronin authored
It was never used. Bug: None Change-Id: Ice77e73468d18ee795c9cf7152a88c3e27bf825e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129048Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754938}
-
Dominique Fauteux-Chapleau authored
TBR=tiborg@chromium.org Bug: 1066459 Change-Id: I02debf69279f12752a92c16c98b5b3ce57a36726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128712Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#754937}
-
David Tseng authored
- fixes one regression where the form controls list shortcut command no longer works - found root cause of panel test flakes. The panel does not immediately get focus, especially on slower builds, so we need to wait for focus prior to performing panel construction and menu bar/menu item focusing - added additional test as well as fixing / rebaselining current tests - simplified logic that sets the active item for node menus on ChromeVox's current range (see test) - simplify places where we set active item; caused a lot of focus events to be sent unnecessarily Fixed: 990229, 795840 RELNOTES: makes Search+Ctrl+F work again in ChromeVox (show form controls list) Change-Id: I7ed10a70b524da48b4d55f2a4e086dae09a9629d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124246 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#754936}
-
Sebastien Lalancette authored
Added code to add the generate QR code activity to the activity service controller behind its feature flag. Also added a simple unit test. Bug: 1064990 Change-Id: Ib386f3bb8fa85d27094197b2febbc1a4c1d66a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127891 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#754935}
-
Alex Ilin authored
At the end of the remote consent flow, Gaia returns Chrome a gaia id of an account chosen by the user. This change makes Chrome reuse this account for the next getAuthToken() calls for the same extension. For now, accounts are stored in memory with a TODO to migrate them to the user preferences. Bug: 1026237 Change-Id: Ibe52424b7131fbe44324ecb7b1a0e54d04cdf747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119520 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#754934}
-
Ulan Degenbaev authored
This reverts commit 2933aeba. Reason for revert: try enabling issue to see if the bug is still there. Original change's description: > [go/perfbot-sheriff] Disable v8 cnn story. > > NOTRY=true > R=ulan@chromium.org > TBR=ulan@chromium.org > > Bug: 1062438 > Change-Id: If81aed43750d93d5c61b02e22c8e40b9f2acec81 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108060 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751165} TBR=ulan@chromium.org,crouleau@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1062438 Change-Id: I6e6d19145fc535393499f2c54087f9a46a74cc6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128512Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#754933}
-
Sadrul Habib Chowdhury authored
CompositorFrameReportingController::stage_history_ is never used, so it is removed. BUG=none R=behdadb@chromium.org Change-Id: I27a40a306c7a55d871900ec4fbcc64196ffbc454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129236 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#754932}
-
