- 03 Nov, 2019 11 commits
-
-
byoungkwon ko authored
There are unreachable case state that it returns when it meets first switch-case. So we need to delete and combine them for unreachable case. Bug: 1020475 Change-Id: I014190e3b7373d86da08912eacdc509d3ccc2cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894667 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#712024}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8580510f117a..dda199292eed git log 8580510f117a..dda199292eed --date=short --no-merges --format='%ad %ae %s' 2019-11-03 sanikak@chromium.org auto_updater: LocalTransfer class readability updates Created with: gclient setdep -r src/third_party/chromite@dda199292eed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iaf19b0a2a9a3b503dd0ebf29281e946556b13e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896895Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712023}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/95f5806e9830..b68a279ce188 git log 95f5806e9830..b68a279ce188 --date=short --no-merges --format='%ad %ae %s' 2019-11-03 jmadill@chromium.org Capture/Replay: Capture GetFloatv params. 2019-11-03 jmadill@chromium.org Capture/Replay: Only convert GLES 2 GLenums to string. Created with: gclient setdep -r src/third_party/angle@b68a279ce188 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I7b10598a13edc9b0cb87e04a66b30c5fe4af6256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896366Reviewed-by:
-
David Grogan authored
Just code health, no behavior change. Bug: 845235 Change-Id: I1202f1c37751537e8112c33f3b1228647407b6dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895748Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#712021}
-
Greg Thompson authored
open. This CL takes a few extra steps to ensure that pending tasks are run during teardown so that open files can be closed. R=pwnall@chromium.org base: :ScopedTempDir cannot delete its contents while files are Bug: 546640 Change-Id: Id1a6db0b2a50140c6b77b39c21c243cb60658a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895338 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#712020}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I5341c282ce967ec81a75df6f516dfeee7fb17256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896855Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712019}
-
Peter Kasting authored
Bug: 1020399 TBR: asvitkine Change-Id: Ib85e84b08d8a39d860b9e87d1eb0f2b1a991fa23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894758Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#712018}
-
Emily Stark authored
LoginTabHelper had some complex logic for handling HTTP 401/407 responses that serve empty response bodies (which needed special handling because they show up as double-commits from the browser process's perspective). This double-commit issue no longer happens because we now commit a blank page underneath the auth prompt, whereas previously we were committing whatever the server sent. Bug: 963307 Change-Id: Ie0e83f1c52bc2d6ed17f8eb3506f87ad3a1700c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891761 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#712017}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I858688d5973aa770e11c21a6f727d11116e1f3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896384Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d8af36ad. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 9be931cb "[WPT/common/security-features] Refactor navigable tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I70ae0c97bae7060d2ca4961634db6fffd7096b74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895403Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712015}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/422ebad20adb..95f5806e9830 git log 422ebad20adb..95f5806e9830 --date=short --no-merges --format='%ad %ae %s' 2019-11-02 jmadill@chromium.org Delete stale unused proc table functions. Created with: gclient setdep -r src/third_party/angle@95f5806e9830 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I2a1a45f0c5ca0379f78f957ce2976359c3daa9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896382Reviewed-by:
-
- 02 Nov, 2019 29 commits
-
-
Xianzhu Wang authored
It specifies the name of the flag-specific expectation file under web_tests/FlagExpectations and the baseline directory under web_tests/flag-specific, in the following format: { "name": "short-name", "args": ["--arg1", "--arg2"] } When at least --additional-driver-flag=--arg1 and --additional-driver-flag=--arg2 are in run_web_tests.py command line, or --flag-specific=short-name is in the command line, we will find web_tests/FlagExpectations/short-name for the additional expectation file and web_tests/flag-specific/short-name for the additional baseline directory. Bug: 1019501 Change-Id: Idf0621abc89efc18cd17f9a9612074aa9d7de298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894069 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#712013}
-
Jan Wilken Dörrie authored
This change prepares //sandbox/win for the upcoming base::string16 switch to std::u16string by replacing existing base::string16 and base::char16 usages with std::wstring and wchar_t. Furthermore, it introduces explicit conversions to and from base::string16 at API boundaries where necessary. Bug: 911896 Change-Id: I96ae433a94d133d16c10b15d6db650eafeaece04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816409 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#712012}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I9131a6f768e1309a46c8eb04cb4787b0cd4cbd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895801Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712011}
-
Xianzhu Wang authored
It didn't work by itself. It was just a redundant information of whether the scrollbar theme supports solid color scrollbars. Change-Id: Ib5f59fbc30ef8ef83a2e0b9b36729214ca68ce2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894433 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#712010}
-
Koji Ishii authored
Following bot results are included. 117 119 120 121 122 125 128 129 130 131 136 140 154 279 lines were removed and 123 lines were deflaked by consecutive results since 120. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I6316b0627dd493b2f5e5e66d8943426c5b0ec10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893591Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#712009}
-
Xianzhu Wang authored
https://chromium-review.googlesource.com/c/chromium/src/+/1866913 removed usage of ScrollbarThemeMock from web tests. This CL removes usage of it from unit tests, and removes ScrollbarThemeMock. It also removes the additional level of mock theme in blink, and refactors scrollbar themes and their settings to avoid misuse of scrollbars. See https://chromium-review.googlesource.com/c/chromium/src/+/1866913 for the new rule of testing scrollbars that now also apply to unit tests. Change-Id: Ibd0566fea55c6b89c767cffa311df00e235d2478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879650 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#712008}
-
Jeremy Roman authored
This reduces Android APK size by approximately 45 kB. This generated code is stamped out tens of thousands of times and so generating this common code only once yields significant savings when the compiler is optimizing for size. The description is also changed to be a C-style string, which saves some size (computing and passing the string length at compile time), which is incorrect (since it's passed to base::StringPrintf under the assumption that it's null-terminated) and inefficient (storing and passing this takes binary and runtime space, but this is not used by StringPrintf). Change-Id: Ib83005f1f0e32720de6732b78b1d258b5dd6a8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896458 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#712007}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic31ed5a6adb1641d3f5b2b3fa1071de44c60d96a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896308Reviewed-by:
-
chrome://sandboxAlex Gough authored
Bug: 997273 Change-Id: I998893ad03b3cf4e32e56f7c771033a0113ace17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885452 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#712005}
-
Yoshifumi Inoue authored
This patch changes |NGBoxFragmentPainter::PaintTextItem()| to paint text if |IsVisibleToPaint()|. This is follow-up of the patch[1] uses opposite condition. [1] http://crrev.com/c/1892981 [FragmentItem] Fix DCHECK in PaintTextItem Bug: 982194 Change-Id: Id2e229169fabae9c00c42197e0fab9a4b9382c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892982 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
chrome://sandboxchrome://chrome-urlsAlex Gough authored
Bug: 997273 Change-Id: Ie3f3768c15610b2253b561f495cb49af8931bc75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885513Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#712003}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/0c74f23ba9..cc75dee3ba TBR=bmeurer@chromium.org Change-Id: I98b7223d087de7e755344309c4390f9d233277bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893874Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#712002}
-
Leon Han authored
Previously, TNF_UNKNOWN records were read and represented as 'opaque' type records, and writing TNF_UNKNOWN records was not supported. As part of effort to make web nfc more of a low level API, we have the spec change https://github.com/w3c/web-nfc/pull/373 that defines an explicit mapping for TNF_UNKNOWN <---> 'unknown' type NDEFRecord This CL introduces the new 'unknown' type and supports reading/writing them accordingly. BUG=520391 Change-Id: I384256d35b665c740edb9bef221d3319bf7df063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886114 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#712001}
-
Koji Ishii authored
This patch fixes a DCHECK fialure in |PaintTextItem|. In |NGInlineLayoutAlgorithm|, all text runs have parent boxes and that checking styles of text runs can be omitted. But in the paint phase, painters need to check styles of all text runs because inline boxes can be culled. Bug: 982194 Change-Id: Id4af4889fa4fc3c82640e8fa3877f9b65fb643bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892981Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#712000}
-
Yoshifumi Inoue authored
This patch changes |NGInlineCursor::GetLayoutBlockFlow()| to work with line scoped cursor for preparation of the patch[1]. Before this patch, |NGPaintFragment| version of |GetLayoutBlockFlow()| crashes when root paint fragment is line box, because we can't use |NGPhysicalFragment:: GetLayoutObject()| returns null for |NGPhysicalLineBoxFragment|. [1] http://crrev.com/c/1888242 Utilize NGInlineCursor for inline box traversal Bug: 982194 Change-Id: I427627de885469712f3d526fccf297d4e94d6fe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896478 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Makes the IDL compiler processes runtime_enabled_features.json5 and makes Exposure aware of context-dependent and context- independent runtime enabled features. Bug: 839389 Change-Id: I2d46730f22866f6f677a96dbd7a72644253e4692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892973 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#711998}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I596bcd391c3d8466ffa2d4b93b1de8db3f2b1c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896381Reviewed-by:
-
Greg Thompson authored
ScopedTempDir must outlive any files held open within it. R=pkasting@chromium.org Bug: 546640 Change-Id: I6b933846cc2578c6526aea8c11b251a26929846b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895655 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
This CL converts ServiceManagerPtr and port depending files to adapt to new mojo types. Bug: 955171, 978694 Change-Id: I8391cdf9995d2395776e115baeaa2d6315fc1183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893592Reviewed-by:
-
Yoshifumi Inoue authored
This patch gets rid of redundant function ComputeLocalRect() in "ng_paint_fragment.cc" introduced by CL[1] by replacing to |NGInlineCursor| version[2] for improving code health. [1] http://crrev.com/c/1832843 Paint selection with NGFragmentItem, Oct 11 [2] http://crrev.com/c/1880890 Make LayoutText::GetTextBoxInfo() to use NGInlineCursor, Oct 25 Bug: 982194 Change-Id: I9fdaadb0818d61b3aa2f4ac60482feec45886efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896476 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 80-3931.2-1572259441-benchmark-80.0.3951.3-r1 to 80-3931.2-1572259441-benchmark-80.0.3954.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I310eddfbb64b8319018ff998617f7c2c0333e12e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896193Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b3cc49df..53ede12e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iff8b5755c2a531511ff9fcc59b0e6825823e0b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895800Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711992}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e05bb7d9638b..9a18bfc96038 Created with: gclient setdep -r src-internal@9a18bfc96038 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: Iea03758b8a4c78edc34955fcf15b142ffc0c2288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896415Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711991}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=gbiv@chromium.org Change-Id: I39e0ee34b11e84c7713ea02660fdf867fd2d425e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895753Reviewed-by:
-
Chen-Yu Tsai authored
Chromium coding style dictates that one should not use auto to deduce a raw pointer. ChromeOS builds are unaffected, but attempts to build media/gpu/v4l2 for desktop Linux will result in an error from the style check plugin: ../../media/gpu/v4l2/v4l2_device.cc:377:3: error: [chromium-style] auto variable type must not deduce to a raw pointer type. const auto& planes = v4l2_buffer_.m.planes; ^~~~~~~~~~~ auto* const This is part of ongoing work to make V4L2 usable on desktop Linux. It is currently untestable without a lot of other changes. The type of `plane` before and after the change are the same, found using the non-implemented template method [1] which shows the actual type in the compile error. In the meantime it doesn't break ChromeOS builds either. [1] https://stackoverflow.com/a/38820784 Test: build media_unittests simplechrome (chromeos-amd64-generic-rel) Change-Id: I5d760babc92ff101d8b75aa208cd875259b6e556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895311Reviewed-by:Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Kuang-che Wu <kcwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711989}
-
Ian Kilpatrick authored
This fixes the painting of table-cell backgrounds to paint in the appropriate rect. As the position of the table cells aren't sub-pixel aware (yet) we were painting the background with the incorrect size, resulting in a the table background bleeding through. I suspect TablesNG won't have this issue (and won't need to use this alternate constructor) as their position should be sub-pixel aware. Bug: 988015 Change-Id: I4135070608f958a71aa7a843c4e11904323125bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896049 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711988}
-
Miyoung Shin authored
This CL converts MediaDrmStorage{Ptr, Request} in android_webview, chrome, chromecast components and media to the new Mojo type. Bug: 955171 Change-Id: I3a8eb5bd33128659fd09804368e96afb08ce03c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871695 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Bo <boliu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711987}
-
Leon Han authored
This CL updates the definition of the union type NDEFMessageSource: (DOMString or ArrayBuffer or NDEFMessageInit) ==> (DOMString or BufferSource or NDEFMessageInit) BUG=520391 Change-Id: I603616047814c56744eed94efd7f3579079b0875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886351Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#711986}
-
Justin Cohen authored
Due to some security workarounds inside ios/web, sometimes a restored webState may mark new navigations as renderer initiated instead of browser initiated. This is somewhat an edge case, but it will manifest as the omnibox not updated until the new webState commits. As these navigations are uncommitted, and make the omnibox (or NTP) look strange, simply drop them. See crbug.com/1010765 for the relevant security bug. Bug: 1020497 Change-Id: I3fbc80bf1671654989f38b92a874e20631ff6ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894470 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#711985}
-
