- 28 Sep, 2017 40 commits
-
-
Bernhard Bauer authored
Bug: 764083 Change-Id: Ib73b7405c39e480ca22e2a32fcbbf308300a2f37 Reviewed-on: https://chromium-review.googlesource.com/690375Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#505058}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=mattm@chromium.org Bug: 666525 Change-Id: I85916b4a88e15fb8a079b557c4fd8451eed8a5cd Reviewed-on: https://chromium-review.googlesource.com/689022 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#505057}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Bug: 666525 Change-Id: Ie2ee9465ee7a8cca62b65d0852333ab9680ba6e3 Reviewed-on: https://chromium-review.googlesource.com/689020 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505056}
-
gaschler authored
Adds a class ContextualSuggestion that replaces all uses of RemoteSuggestion in the ContextualContentSuggestionsService. Contextual suggestions do not fit well into RemoteSuggestion because they do not have categories, and their behavior is expected to diverge further in future. Also, caching non-copyable RemoteSuggestion would be inconvenient. Bug: 749988 Change-Id: I71b7a4630efcb6c8e1a69dd8cbb670b6d9fb72ed Reviewed-on: https://chromium-review.googlesource.com/689996 Commit-Queue: Andre Gaschler <gaschler@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#505055}
-
tzik authored
RefPtr<>::Get() is being renamed to get() for a preparation of the unification of RefPtr and scoped_refptr. This CL updates calles of Get() in core/ to use get(). Bug: 763844 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0393de185243f16e79d3dee967424752e62a04be Reviewed-on: https://chromium-review.googlesource.com/690135Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#505054}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=ryansturm@chromium.org Bug: 666525 Change-Id: Idf794d844071cc6a515b8366f0ebcf39c1f4c7e8 Reviewed-on: https://chromium-review.googlesource.com/689030Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505053}
-
bsheedy authored
Fixes a rare case of flakiness where testExitFullscreenAfterExitingVrFromCinemaMode was failing due to fullscreen not being exited instantaneously upon VR exit. Bug: Change-Id: Ia018676f5e1691805653d1313d4db41c34c9d00c Reviewed-on: https://chromium-review.googlesource.com/688300Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#505052}
-
Ken Rockot authored
Allocation padding was added to the global port map to avoid being stomped on by a UAF somewhere on Chrome for Android. The culprit has likely been found and a fix is imminent. See bug 673417 for details. BUG=740044,725605 TBR=jcivelli@chromium.org Change-Id: I934c0e7a6a84a7eb21a74d122f446e14275babbf Reviewed-on: https://chromium-review.googlesource.com/688492Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#505051}
-
Iulia Harasim authored
This CL adds a handful of tests for the personalized signin promos in Bookmarks. The tests verify whether: - The promo can be manually dismissed / the promo gets automatically dismissed after the impression limit has been reached. - The signin buttons fire the right intents when clicked. It also updates the API of AccountSigninActivity and replaces some anonymous classes in SigninAndSyncView with lambdas. Bug: 737743 Change-Id: I45d7dfd246f98e1a2ca4e3bf79616274c858d256 Reviewed-on: https://chromium-review.googlesource.com/686755 Commit-Queue: Iulia Harasim <iuliah@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#505050}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=xiyuan@chromium.org Bug: 666525 Change-Id: I10358379bca0403dc8a3d27fbfd02a632cce65d3 Reviewed-on: https://chromium-review.googlesource.com/689104Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505049}
-
Mostyn Bramley-Moore authored
Formerly known as Opera TV. TBR=jochen@chromium.org Change-Id: I22ffe796c455e75cba9e0624727ea6499097ac83 Reviewed-on: https://chromium-review.googlesource.com/689514Reviewed-by:
Mostyn Bramley-Moore <mostynb@opera.com> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#505048}
-
Ella Ge authored
In this cl, we throw error in EventSender::AddTouchPoint to prevent touch_point_.size() exceed kTouchesLengthCap. Bug: 764921 Change-Id: Ifbb8db421f1a523e91a845284656b17d6269bb40 Reviewed-on: https://chromium-review.googlesource.com/687809Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#505047}
-
Xianzhu Wang authored
1. Skip virtual/new-remote-playback-pipeline/ which is under development. 2. Remove baselines for paint/invalidation/video-[un]mute-repaint.html and expect failures. The video implementation is being changed and we can't catch up with it. TBR=pdr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3f5cf22ddb879d77bfc78c86227b4ae06fa5d25d Reviewed-on: https://chromium-review.googlesource.com/690323Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#505046}
-
John Chen authored
Add media trace events needed to calculate buffering time, dropped frame count, and seek time in media perf benchmarks. Bug: 700160 Change-Id: I340fe3763a73fe3a77e6a04d0d8761811ae6838e Reviewed-on: https://chromium-review.googlesource.com/674166 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#505045}
-
Xida Chen authored
TBR=chongz@chromium.org NOTRY=true Bug: 652536 Change-Id: Ib64364b32cbaeafa9423f87d4a6ed776f4fdbe44 Reviewed-on: https://chromium-review.googlesource.com/690439Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505044}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5738043d. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2515 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: I5fe3217aabe3bc3d3804d4253d142c16cc3b03c7 Reviewed-on: https://chromium-review.googlesource.com/690218 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#505043}
-
Xida Chen authored
It has been flaky. I will let this CL go through CQ to make sure there is no build failure TBR=dgn@chromium.org Bug: 769738 Change-Id: I495c98457d6139d6c46577d30d101b1ca4c4aa29 Reviewed-on: https://chromium-review.googlesource.com/690320Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505042}
-
Gauthier Ambard authored
The NTP view cannot use the safeAreaInsets property directly as it is snapshotted before being inserted in the view hierarchy, and the safe area is only available for views in the view hierarchy. This CL introduces a property mirroring the safe area once the view is in the view hierarchy. But it is also set up with the value used in the first frame, allowing the snapshot to be done as if the view was in the view hierarchy. Bug: 767869 Change-Id: I605566105862e9f4c557736ec65df5f8ab1fc76b Reviewed-on: https://chromium-review.googlesource.com/681942 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/heads/master@{#505041}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=msw@chromium.org Bug: 666525 Change-Id: I310eea6b9f3dba136c2d46df235d9ce51b47b7a6 Reviewed-on: https://chromium-review.googlesource.com/689100Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505040}
-
Marc-Antoine Courteau authored
These were not being updated when a different row was tapped. Bug: Change-Id: Ib87d09ed55a4997c83a806146729861da6e64809 Reviewed-on: https://chromium-review.googlesource.com/687823Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Cr-Commit-Position: refs/heads/master@{#505039}
-
Xiyuan Xia authored
Bug: 753543 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4894763b0fb9817a879fcc8150522abd452a9910 Reviewed-on: https://chromium-review.googlesource.com/688655Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#505038}
-
Mathieu Perreault authored
Functionality neutral refactor for an upcoming change. I started pulling on AddressNormalizer and a lot of stuff came with it :| * AddressNormalizer and friends move to Autofill code. * GetCountryCodeWithFallback moves to autofill_data_util * Phone number utils move from Payment Request code to Autofill Bug: 767931 Test: components_unittests Change-Id: I57b4b7863bc2f12408ab388694b349029607fe5e Reviewed-on: https://chromium-review.googlesource.com/688581Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#505037}
-
Alexandr Ilin authored
This CL simplifies the learning part of the LoadingPredictor when URL-based learning is disabled by skipping a history DB lookup as well as skipping the update of ResourcePrefetchPredictor.DatabaseReadiness, which also would entail a history DB lookup. Bug: 699080 Change-Id: I46c2bf4482c291fa2ed5c64546b45118cb7b233b Reviewed-on: https://chromium-review.googlesource.com/686761 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#505036}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=rsesek@chromium.org Bug: 666525 Change-Id: Iad735e1eddf2b56ec42f58a7c700628f7ef31df1 Reviewed-on: https://chromium-review.googlesource.com/689141Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505035}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/072c7102f4c9..36dcd7f25d1f $ git log 072c7102f..36dcd7f25 --date=short --no-merges --format='%ad %ae %s' 2017-09-27 brianosman Enable caching of path mask textures by default Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Id909d28731130a3fb0c602c412b5e8e74db156f0 Reviewed-on: https://chromium-review.googlesource.com/690316Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#505034}
-
Mohammad Refaat authored
* Converts SystemCookieStore to Async * Add Async functions to NSHTTPSystemCookieStore and keep the synchronous functions. * Move creation time management to systemCookieStore. * Update cookie_store_ios_presistent_unittest & cookie_store_ios_unittests to account for SystemCookieStore changes * (As CookieStoreIOS is using systemCookieStore internally). Another CL is in progress to add WKSystemCookieStore & unit_tests for systemCookieStore (to handle async methods) with template for both NSHTTP & WK systemCookieStore. Bug: 759229, 759227, 767948 Change-Id: I1c24c82540f4781a0bec77ebfa4a861ca7433391 Reviewed-on: https://chromium-review.googlesource.com/675804 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#505033}
-
Jorge Lucangeli Obes authored
https://chromium-review.googlesource.com/c/chromium/src/+/641992, the fix for crbug.com/752185, causes the following layout tests: * fast/workers/worker-exception-during-navigation.html * fast/workers/worker-multi-startup.html * http/tests/workers/terminate-during-sync-operation-file.html * http/tests/workers/terminate-during-sync-operation-filesystem.html * virtual/mojo-loading/http/tests/workers/terminate-during-sync-operation-file.html * virtual/mojo-loading/http/tests/workers/terminate-during-sync-operation-filesystem.html to hit per-process memory limits on Linux. Fix by reducing the number of workers created in the tests from 30 to 20. See https://bugs.chromium.org/p/chromium/issues/detail?id=752185#c61 for an explanation. BUG=752185 TEST=Layout tests pass with related change. Change-Id: Ic0ebaaaad01ce05be5ca88214172d6141f57c2f0 Reviewed-on: https://chromium-review.googlesource.com/685718 Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#505032}
-
Luna Lu authored
Bug: 760110 Change-Id: I7c8e70af3cb5b58939a762d577b5374c54638aed Reviewed-on: https://chromium-review.googlesource.com/687574Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#505031}
-
Miriam Gershenson authored
Some of the DNS histograms are not useful anymore. A lot of them have no data but were never marked as obsolete. This CL deletes the ones I don't intend to replace with anything. Rearranging of the remaining metrics to be more useful will come in a future CL. Bug: 769320 Change-Id: Ia45aaa5034371aa7780145ea991f624b52dd3b1a Reviewed-on: https://chromium-review.googlesource.com/673264Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#505030}
-
Adithya Srinivasan authored
Uses the AtomicString(Vector<UChar>) constructor for Attribute values. This is to remove an unnecessary memory allocation and conversion of attribute values to String (using Value8BitIfNecessary). The allocation is unnecessary for cases where the value is already present in AtomicStringTable. This CL also changes lookupHTMLTag to directly return an AtomicString, instead of converting it to a StringImpl and then back to an AtomicString. Bug: Change-Id: I756f99cd57ebc20828d4a0430ba34f1018c730a4 Reviewed-on: https://chromium-review.googlesource.com/685512Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#505029}
-
tzik authored
RefPtr<>::Get() is being renamed to get() for a preparation of the unification of RefPtr and scoped_refptr. This CL updates calles of Get() in platform/ to use get(). Bug: 763844 Change-Id: I6884ea0a5bee8c1500c8a6de037c917a719ffc98 Reviewed-on: https://chromium-review.googlesource.com/690355Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#505028}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=miu@chromium.org Bug: 666525 Change-Id: I518a4c7af8783cde82ca6b98796367e4530d94e0 Reviewed-on: https://chromium-review.googlesource.com/689016Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505027}
-
Ran Ji authored
Add a UMA to track whether user has WebAPK display notification permission enabled when a WebAPK receives a notification Bug: 685806 Change-Id: I237947c44b8539e84384312b591be39d3759c4ed Reviewed-on: https://chromium-review.googlesource.com/667002Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Ran Ji <ranj@chromium.org> Cr-Commit-Position: refs/heads/master@{#505026}
-
Sigurdur Asgeirsson authored
This is a reland of 06d64c00 Original change's description: > Make SECURITY_DCHECK play with Albatross. > > In Albatross builds, DCHECKs can be compiled in, but non-fatal. See > https://docs.google.com/a/chromium.org/document/d/1QY4IbbJ8X6G-6-cMheEkP_mT7ZNPCuUJIW2sr_mEiH4 > > Bug: 596231 > Change-Id: I84198f1d3f4122ac7a5bd8a90ed5ea96286b9022 > Reviewed-on: https://chromium-review.googlesource.com/685498 > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504638} Bug: 596231 Change-Id: I2c1223ba264dbdb06e814b92b84adfe9c3c619b7 Reviewed-on: https://chromium-review.googlesource.com/687874Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#505025}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=wjmaclean@chromium.org Bug: 666525 Change-Id: I703d25575a1fbd487c5703633e652afea83cee4d Reviewed-on: https://chromium-review.googlesource.com/688897Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505024}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=cmumford@chromium.org Bug: 666525 Change-Id: I74f82c441f22fa1809d8d8262fe5c71881843729 Reviewed-on: https://chromium-review.googlesource.com/689137Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505023}
-
Jared Saul authored
Bug: Change-Id: I72f6e575a30a9d3a9fef4d52cb0ca988270e5f70 Reviewed-on: https://chromium-review.googlesource.com/688820Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#505022}
-
Miriam Gershenson authored
To prepare for running a new experiment on Android, the AsyncDns field trial needs a command line flag and a chrome://flags entry. Migrating it to the new FeatureList API was the easiest way to do that. Also deprecate the old pref source histograms. Bug: 768874 Change-Id: I7858ffdc1b18a01701c75c3fca7d0269f8ed4455 Reviewed-on: https://chromium-review.googlesource.com/685036 Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#505021}
-
Xida Chen authored
This reverts commit b6a0794d. Reason for revert: <INSERT REASONING HERE> Causing build error: https://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder%20%28dbg%29/builds/103347 Original change's description: > Disable TileGridLayoutTest#testModernTileGridAppearance_Two > > TBR=dgn@chromium.org > NOTRY=true > > Bug: 769738 > Change-Id: Ied6cdecac72229353f3c41ca769b6d872ea7a2ea > Reviewed-on: https://chromium-review.googlesource.com/690238 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505016} TBR=dgn@chromium.org,xidachen@chromium.org Change-Id: I546039abb34116b5897a9ffaf1f9134229d5659b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 769738 Reviewed-on: https://chromium-review.googlesource.com/690674Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505020}
-
Elodie Banel authored
The omnibox is hidden when launching the app, but shown again if the startup params are set to focus omnibox. This causes a visual flicker. Passing around this argument makes it possible to not hide the omnibox in the first place if it will be focused. Bug: 754119 Change-Id: I4a4e4f759c2be2bbdaa028ec7c34e49745848189 Reviewed-on: https://chromium-review.googlesource.com/687774 Commit-Queue: Elodie Banel <lod@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505019}
-