- 17 Mar, 2015 40 commits
-
-
mlerman authored
BUG=463611 Review URL: https://codereview.chromium.org/1014843003 Cr-Commit-Position: refs/heads/master@{#320981}
-
bnc authored
Make HttpServerProperties::GetAlternateProtocol return AlternativeService, and rename it to GetAlternativeService. Rename its parameter, as well as parameters of other alternate protocol or alternative service related functions, from server to origin. Update all clients of GetAlternateProtocol. Also rename anonymous namespace HasAlternateProtocol to HasAlternativeService in tests. BUG=392576 Review URL: https://codereview.chromium.org/1017453008 Cr-Commit-Position: refs/heads/master@{#320980}
-
xhwang authored
- Request permission in ProxyDecryptor. - Check (instead of request) permission in BrowserCdmManager. BUG=446263,455271 TEST=Manually tested on Android. Review URL: https://codereview.chromium.org/1013913002 Cr-Commit-Position: refs/heads/master@{#320979}
-
wtc authored
Define gypi_skia_gpu and gypi_skia_pdf only if they will be used. R=alokp@chromium.org,reed@google.com BUG=none Review URL: https://codereview.chromium.org/1008603002 Cr-Commit-Position: refs/heads/master@{#320978}
-
tapted authored
These are used, e.g., for the Bookmark -> Edit... dialogs on Cocoa and Views. This gets WidgetTestInteractive.*Window*ModalWindowDestroyedActivationTest passing. WidgetTestInteractive.*System*ModalWindowReleasesCapture is disabled in this CL. System modal windows are not needed on Mac. Currently the implementation on MacViews assumes all modal dialogs are shown using a sheet. On Cocoa, this is not always true for WebContents-Modal dialogs (e.g. cookies and site data), but it is true for some WebContents-Modal dialogs (e.g. certificate information). A follow-up will add logic to ensure WebContents-Modal dialogs are handled appropriately, and have good test coverage. After this all tests pass on the current mac trybot configuration with toolkit_views=1. BUG=403679 Review URL: https://codereview.chromium.org/993253002 Cr-Commit-Position: refs/heads/master@{#320977}
-
dcastagna authored
GLSL precision qualifiers have no effect in OpenGL. On Mac the precision qualifiers cause the shader not to compile. BUG= Review URL: https://codereview.chromium.org/1011503002 Cr-Commit-Position: refs/heads/master@{#320976}
-
huangs authored
This CL makes Apple Touch Icon URLs will be parsed in Blink and passed to FaviconTabHelper::DidUpdateFaviconURL(). This used to be enabled for Android only. On desktop the URLs are parsed, but ignored (so storage into Favicon DB and no image fetching yet). BUG=467712 Review URL: https://codereview.chromium.org/1007563004 Cr-Commit-Position: refs/heads/master@{#320975}
-
hshi authored
This allows ui::Layer to take scale factor into consideration when updating the cc::NinePatchLayer. BUG=466950 R=danakj@chromium.org R=oshima@chromium.org TBR=sky@chromium.org TEST=verify on HiDPI display as well as HiDPI + LowDPI extended mode that shadows are correct. Review URL: https://codereview.chromium.org/1002393002 Cr-Commit-Position: refs/heads/master@{#320974}
-
wittman authored
Uses the enhanced bookmarks Finch experiment as the only mechanism for enabling enhanced bookmarks in Chrome. With this change we no longer need the EnhancedBookmarks.SyncExperimentState UMA histogram since we can now get all the relevant metrics via Finch. BUG=467040 Review URL: https://codereview.chromium.org/1009673002 Cr-Commit-Position: refs/heads/master@{#320973}
-
xdai authored
If the current wallpaper was set by a third party application, we should disable surprise me feature, otherwise the wallpaper will still be changed periodically. Also fix the issue that wallpaper picker application can't load the local resource: chrome://resources/css/text_defaults.css. BUG=466709 TEST=Manually tested Review URL: https://codereview.chromium.org/1004263002 Cr-Commit-Position: refs/heads/master@{#320972}
-
kalman authored
Previously extensions::Dispatcher was responsible for creating ScriptContexts then Adding them to its ScriptContextSet. Now, ScriptContextSet creates them itself. This prepares the Extension system for later changing to lazily or asynchronously creating ScriptContexts. BUG=466373 R=rockot@chromium.org Review URL: https://codereview.chromium.org/995283004 Cr-Commit-Position: refs/heads/master@{#320971}
-
ddorwin authored
Pre-ICS Android is not supported. Review URL: https://codereview.chromium.org/1016553003 Cr-Commit-Position: refs/heads/master@{#320970}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/706d98e..9d2049d CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=egdaniel@google.com Review URL: https://codereview.chromium.org/1013123003 Cr-Commit-Position: refs/heads/master@{#320969}
-
benwells authored
This flag now does not bypass the checks for whether the app has been added to the homescreen or not. BUG=467374 Review URL: https://codereview.chromium.org/1011963003 Cr-Commit-Position: refs/heads/master@{#320968}
-
erikwright authored
In component builds the single invocation from child_process_logging_win is sufficient (as there is only a single copy of base). BUG=460512 Review URL: https://codereview.chromium.org/1008523002 Cr-Commit-Position: refs/heads/master@{#320967}
-
erikwright authored
BUG=460512 Review URL: https://codereview.chromium.org/1017453002 Cr-Commit-Position: refs/heads/master@{#320966}
-
reveman authored
Avoid IPC from ChildDiscardableSharedMemoryManager dtor in case the channel has been closed at destruction time. BUG=467958 TEST=content_browsertests --gtest_filter=ChildDiscardableSharedMemoryManagerBrowserTest.* Review URL: https://codereview.chromium.org/1012163002 Cr-Commit-Position: refs/heads/master@{#320965}
-
wfh authored
BUG=467806 Review URL: https://codereview.chromium.org/1004623005 Cr-Commit-Position: refs/heads/master@{#320964}
-
newt authored
This allows jinja2 templates to reference other templates by path name, e.g. to extend them or include them. BUG=467069 Review URL: https://codereview.chromium.org/1002313002 Cr-Commit-Position: refs/heads/master@{#320963}
-
spang authored
Revert of [Ozone] Fix Vaapi unittest builds (patchset #1 id:1 of https://codereview.chromium.org/1014623003/) Reason for revert: Breaks CrOS !ozone build. Original issue's description: > [Ozone] Fix Vaapi unittest builds > > BUG=none > > Committed: https://crrev.com/638dcf8ea48510475248361caeca547c4541b950 > Cr-Commit-Position: refs/heads/master@{#320758} TBR=dnicoara@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/1012213002 Cr-Commit-Position: refs/heads/master@{#320962}
-
michaelpg authored
R=michaelpg@chromium.org, dzhioev@chromium.org Review URL: https://codereview.chromium.org/1011993002 Cr-Commit-Position: refs/heads/master@{#320961}
-
estade authored
R=dfalcantara@chromium.org BUG=466421 Review URL: https://codereview.chromium.org/1006483004 Cr-Commit-Position: refs/heads/master@{#320960}
-
engedy authored
BUG=437865 Review URL: https://codereview.chromium.org/999073002 Cr-Commit-Position: refs/heads/master@{#320959}
-
jrummell authored
BUG=448219 TEST=new test passes Review URL: https://codereview.chromium.org/1002193005 Cr-Commit-Position: refs/heads/master@{#320958}
-
rmcilroy authored
Fix IndexedDBBrowserTest.ConnectionsClosedOnTabClose to ensure that the first tab holds a reference to the DB after it does setVersion to ensure that if a GC happens before the second tab is loaded, the second tab still get's blocked from doing it's version update. Previously if a GC happened at this time then the test would hang as the second tab would set it's title immediately to "setVersion(3) complete" bypassing the "setVersion(3) blocked" title. This was failing when long idle times were enabled because the long idle times caused more GC when the tab went idle. BUG=467655 Review URL: https://codereview.chromium.org/1012153002 Cr-Commit-Position: refs/heads/master@{#320957}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/cdeca44..706d98e CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=egdaniel@google.com Review URL: https://codereview.chromium.org/1017593004 Cr-Commit-Position: refs/heads/master@{#320956}
-
earthdok authored
Revert of Do not allow asan_symbolize.py to fall back to addr2line/atos. (patchset #1 id:1 of https://codereview.chromium.org/983083004/) Reason for revert: Turns out the fall back to addr2line happens routinely. We need to fix that before proceeding with this change. Original issue's description: > Do not allow asan_symbolize.py to fall back to addr2line/atos. > > For performance reasons we want to stick to llvm-symbolizer. > This also rolls the third-party asan_symbolize.py to r231492. > > BUG=415179 > TBR=glider@chromium.org > NOTRY=true > > Committed: https://crrev.com/2ee9a8ae1e39433fc8df07c27256963715747bbb > Cr-Commit-Position: refs/heads/master@{#319460} TBR=glider@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=415179 Review URL: https://codereview.chromium.org/1017793002 Cr-Commit-Position: refs/heads/master@{#320955}
-
droger authored
This method is required in order to upstream CookieStoreIOS. CookieStoreIOS can periodically synchronize the iOS system cookie store (NSHTTPCookieStorage) to CookieMonster. It is not possible to simply delete all the cookies and re-add the new version of the cookies, because this can lead to cookie loss if the application crashes right after deleting all cookies. For this reason, this CL introduces a new SetAllCookies method that computes the exact difference between the exiting cookies and the new cookies, and does only the minimum of operations needed. Review URL: https://codereview.chromium.org/1000103002 Cr-Commit-Position: refs/heads/master@{#320954}
-
robert.bradford authored
This refactoring would allow the creation of capturing devices without having a DesktopMediaID. This change pulls the DesktopVideoCaptureMachine class out from DesktopCaptureDeviceAura and renames it to AuraWindowCaptureMachine. The class is also refactored to take the target window (rather than a DesktopMediaID) after construction through a SetWindow method. BUG=425060 TEST=Using Chrome Cast beta extension and capture both screen and window and observe that the capture works correctly and that histogram values are updated. Review URL: https://codereview.chromium.org/974513002 Cr-Commit-Position: refs/heads/master@{#320953}
-
xunjieli authored
The documentation for NESTABLE_ASYNC events is not quite right. It does not say that we use "id" to match events, and it is not accurate about the parsing rule for unmatched events. This CL makes changes to the comments, so it will be clearer to future users of the API. Review URL: https://codereview.chromium.org/1016753003 Cr-Commit-Position: refs/heads/master@{#320952}
-
mseaborn authored
This pulls in the following Native Client changes: cdbbbe0: (jfb@chromium.org) PNaCl: Update compiler-rt revision in pnacl/COMPONENT_REVISIONS 67685d6: (kschimpf@google.com) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS a47cbb5: (jfb@chromium.org) Update revision for PNaCl 00ba720: (stichnot@chromium.org) Enable ccache in the cmake builds of LLVM and libcxx. d3dc925: (sbc@chromium.org) pnacl/driver: Allow -whole-archive as well as --whole-archive 7eefe5f: (jfb@chromium.org) Test overflow builtins. 84b4c32: (jfb@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS 92ab4d5: (jfb@chromium.org) Revert of PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS (patchset #1 id:1 of https://codereview.chromium.org/1008693005/) 8f963fb: (jfb@chromium.org) Revert of Revert of PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS (patchset #1 id:1 of https://codereview.chromium.org/1002423002/) a1aac24: (bradnelson@google.com) Return zero for segment registers accessed via the debug stub f418b37: (jfb@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/71515be08f1b0993ad0cd96f991266169a3a003e..f418b37b22393d82c08d28ce1c151bed933d2c9b BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build Review URL: https://codereview.chromium.org/1011183002 Cr-Commit-Position: refs/heads/master@{#320951}
-
dbeam authored
R=hcarmona@chromium.org BUG=467513 Review URL: https://codereview.chromium.org/1018543005 Cr-Commit-Position: refs/heads/master@{#320950}
-
fserb authored
BUG=461032 Review URL: https://codereview.chromium.org/996313002 Cr-Commit-Position: refs/heads/master@{#320949}
-
grt authored
This change gives consumers of ZipReader a way to have the current entry streamed to them via a Delegate interface. It also: - Reduces duplication in the ExtractCurrentEntry* functions. - Uses the heap rather than the stack for intermediate buffers. - Changes ExtractCurrentEntryToFd to ExtractCurrentEntryToFile, making it cross-platform in the process. BUG=462584 Review URL: https://codereview.chromium.org/1014653002 Cr-Commit-Position: refs/heads/master@{#320948}
-
caseq authored
... provided categories that cause layer tree snapshots to be traced are enabled. We need this so that we can show owner nodes for layers that were not updated on the main thread side for a while. BUG= Review URL: https://codereview.chromium.org/924973003 Cr-Commit-Position: refs/heads/master@{#320947}
-
dmazzoni authored
The web speech synthesis API was correctly passing through an utterance's rate, pitch, and volume to native TTS, but not to extension-based speech. This fixes the bug, and I filed another bug to clean up the redundancy that led to this bug being there. BUG=376280 Review URL: https://codereview.chromium.org/969913002 Cr-Commit-Position: refs/heads/master@{#320946}
-
mmeade authored
Adding an example multi-machine test for Chromoting. This example starts a test controller machine which then starts a dedicated task machine to run the browser_tests_launcher on. The output is then streamed back to the test controller to be logged and the output (pass or fail) is mirrored on the test controller. This is a simple example of how to write and run multi-machine tests using the Legion framework. BUG=467620 Review URL: https://codereview.chromium.org/1012883002 Cr-Commit-Position: refs/heads/master@{#320945}
-
engedy authored
BUG=437865 Review URL: https://codereview.chromium.org/1018613002 Cr-Commit-Position: refs/heads/master@{#320944}
-
mukai authored
The current focus rectangle logic is wrong -- it's always drawn outside of local bounds, which is not drawn actually. The expected behavior is to draw the focus rectangle around the actual text. BUG=467510 R=sky@chromium.org TEST=the new test case covers Review URL: https://codereview.chromium.org/1018463004 Cr-Commit-Position: refs/heads/master@{#320943}
-
zmo authored
BUG=456004 TEST=gpu_unittests, about:gpu page R=kbr@chromium.org Review URL: https://codereview.chromium.org/1018463002 Cr-Commit-Position: refs/heads/master@{#320942}
-