- 27 Feb, 2019 26 commits
-
-
Daniel Murphy authored
There are still a large number of renderer hangs from GetAll. Since the other possible hang call sites have been marked [Sync], this means that the loading of the storage area map is the final obvious area where this hang could be occurring. mek@ and I found a number of possible optimization spots where a map is known to be empty during the GetAll (or Fork) calls, and in these cases the code can avoid hitting disk. Hopefully this captures many common cases and can help the code hit disk less. https://docs.google.com/document/d/1Pw8W74-7NCHpxrtglVHqFZpLV_p2JFwdMNqo03kx2l8/edit has the discussion notes. R=mek@chromium.org Bug: 897581 Change-Id: I92de5848ebf17e2ab4fd5cd85610922858e629a8 Reviewed-on: https://chromium-review.googlesource.com/c/1488178 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#635790}
-
Tsuyoshi Horo authored
Bug: 910516 Change-Id: Idea34833925b9aeead30c00fc0ae409a505c2846 Reviewed-on: https://chromium-review.googlesource.com/c/1488488Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635789}
-
Noel Gordon authored
Wrap raw image data in a PiexStreamReader, and process it via Piex, to extract the preview and thumbnail image properties. Caller (JS on the same web page) owns the data. All this code needs to do is provide the offset and length of the image preview or thumbnail, as well its EXIF color space and orientation information, and callback these results in a JS object. The result includes the camera maker and model, and preview and thumbnail image format/width/height properties, for testing purposes [1]. Add fake DEPS to node_modules/piex to silence bogus presubmit error on uploading this patch. Update Wasm Makefile for new piex.cpp code. Build products we care about are the a.out.{js,wasm}. Build sizes look good running: % ls -sh a.out* 36K a.out.js 60K a.out.wasm [1] Note the upstream Piex code is fuzzed, and has a large test suite. Our test approach can be much simpler therefore, as we'll soon see. Tbr: slangley Bug: 935285 Change-Id: I406dc08c908027782390e793bf6c7765bf0afa39 Reviewed-on: https://chromium-review.googlesource.com/c/1488474 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#635788}
-
Lei Zhang authored
Do not bother with the extra effort of trying to detect the case of the user going into annotation mode and then not making any edits. Just assume they likely will to keep the state machine simpler. BUG=936094 Change-Id: I82a793e39f7175c5bffdb3c93630f9b085385dca Reviewed-on: https://chromium-review.googlesource.com/c/1490397Reviewed-by:
dstockwell <dstockwell@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#635787}
-
Etienne Bergeron authored
The trace event is setting an args on from a char[]. R=oysteine@chromium.org TBR=drott@chromium.org Change-Id: I8fd6f9acc1db4328698d75109ccce4f0bed59fa4 Reviewed-on: https://chromium-review.googlesource.com/c/1489639Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#635786}
-
Xiaocheng Hu authored
Bug: 936129 Tbr: wanderview@chromium.org NoTry: True Change-Id: Ifcfd654ab9a40fdbd6792779601ebcc4a3b1c4bd Reviewed-on: https://chromium-review.googlesource.com/c/1490743Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635785}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4efdb5120090..ac0f524bb103 git log 4efdb5120090..ac0f524bb103 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 thestig@chromium.org Optimize FindSubWordLength(). 2019-02-26 thestig@chromium.org Avoid some WideString construction inside FX_ParseDateUsingFormat(). 2019-02-26 thestig@chromium.org Save results from FPDF_GetFieldAttr() calls. 2019-02-26 thestig@chromium.org Add constants for form field types. 2019-02-26 thestig@chromium.org Add constants for common form field dictionary entries. 2019-02-26 thestig@chromium.org Simplify CheckForUnsupportedAnnot() internals. Created with: gclient setdep -r src/third_party/pdfium@ac0f524bb103 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:935241,chromium:935241 TBR=dsinclair@chromium.org Change-Id: Ic3b21fbfc95ebcdbe9089dae9b7a8a401ad2f81e Reviewed-on: https://chromium-review.googlesource.com/c/1490372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635784}
-
Yuwei Huang authored
This version fixes an integer overflow bug in 32bit architecture, which causes out-of-bound memory read. Bug: 934128 Change-Id: I1a63f8949e0e67aa4998609ffe07846a36105051 Reviewed-on: https://chromium-review.googlesource.com/c/1490471Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#635783}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f12d67517903..4dbb96dfaa04 git log f12d67517903..4dbb96dfaa04 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader fe3d4978886b..8adf1fcd08d0 (2 commits) 2019-02-26 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 024f271ae0c7..fe3d4978886b (1 commits) 2019-02-26 brianosman@google.com Particles: remove non-stable random, add better enum reflection Created with: gclient setdep -r src/third_party/skia@4dbb96dfaa04 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I684d53946620eed63815fe82769f97ad250096de Reviewed-on: https://chromium-review.googlesource.com/c/1490371Reviewed-by:
-
Sky Malice authored
This reverts commit 18d4c919. Reason for revert: getUpdateConsumer() would initialize some part of the Feed that needed to be initialized. An uninitialized Feed drops requests on the floor. This caused refresh requests to be ignored. Original change's description: > [Feed] Call simple triggerRefresh method. > > Bug: 933395 > Change-Id: I2b76b43f15c695449c6af30db0992b386fd02222 > Reviewed-on: https://chromium-review.googlesource.com/c/1476827 > Commit-Queue: Sky Malice <skym@chromium.org> > Reviewed-by: Gang Wu <gangwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#633351} TBR=gangwu@chromium.org,skym@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 933395 Change-Id: Id047d0ac979ab3b36dd1e6c7c74d5b3f37c54cf9 Reviewed-on: https://chromium-review.googlesource.com/c/1490492Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#635781}
-
Alexei Filippov authored
BUG=884147 Change-Id: Ib68bc3e2be3d8361f085c8c1fc484658c47e4a15 Reviewed-on: https://chromium-review.googlesource.com/c/1489634Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#635780}
-
Daniel Murphy authored
Maps that are being forked from are not being held open until the fork operation is complete, which is probably causing the GetAll hanges in the attached bug. This idea came from mek@ out of the discussion here: https://docs.google.com/document/d/1Pw8W74-7NCHpxrtglVHqFZpLV_p2JFwdMNqo03kx2l8/edit#heading=h.lwd5sacdhs8q R=mek@chromium.org Bug: 897581 Change-Id: I700bbc580b0f4360354b87b4b9a8cfb3cb4bd6ee Reviewed-on: https://chromium-review.googlesource.com/c/1489897 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/958d88e26d2e..be28670fe2bf git log 958d88e26d2e..be28670fe2bf --date=short --no-merges --format='%ad %ae %s' 2019-02-26 vadimsh@chromium.org [cipd] Rebuild all Go binaries with Go 1.12. Created with: gclient setdep -r src/third_party/depot_tools@be28670fe2bf The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:936067 TBR=agable@chromium.org Change-Id: Ifa552946ab3bca0ffd8d93c9d8966662a4edddde Reviewed-on: https://chromium-review.googlesource.com/c/1490097Reviewed-by:
-
Hirokazu Honda authored
VideoDecoder client, before it calls VD::Initialize, decodes EOS buffer (i.e. VDA::Flush()) first and waits until the EOS buffer is decoed (i.e. VDA::NotifyFlushDone()). Therefore, VdaVideoDecoder doesn't have to call VDA::Flush() in the beginning of reinitialization. This removes the unnnecessary VDA::Flush() call. Bug: 929565 Test: no video corruption on some issued sites on grunt and eve Change-Id: I4e842996896378f0d6f03fc5942833944e3afcaf Reviewed-on: https://chromium-review.googlesource.com/c/1487758Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635777}
-
Eric Stevenson authored
This reverts commit a2c39735. Reason for revert: https://crbug.com/935964 Original change's description: > Android: Fix fat lib toolchain in Trichrome. > > Missed in https://crrev.com/c/1481019. Only causes errors when > resource whitelisting is enabled. > > Tbr: agrieve@chromium.org > Bug: 935088 > Change-Id: Ide099850512681bc6494995310e6c63ac7441365 > Reviewed-on: https://chromium-review.googlesource.com/c/1485232 > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634979} TBR=agrieve@chromium.org,estevenson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 935088, 935964 Change-Id: Ica482153d538741a0b65828dde0e84e28416283d Reviewed-on: https://chromium-review.googlesource.com/c/1490515Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#635776}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/44fde444..d28f8754 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9df01e967a4ec520f9b944e0475e406ee0eacf18 Reviewed-on: https://chromium-review.googlesource.com/c/1490214Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635775}
-
Marcin Wiącek authored
This is a reland of d9d05e18 (https://chromium-review.googlesource.com/c/chromium/src/+/1142764) with fix created by donnd@google.com for bug described inside https://chromium-review.googlesource.com/c/chromium/src/+/1488575 Original change's description: > Migrate PanelState from enum to @IntDef + remove one Map > > @IntDef/@StringDef annotation are preferred way for declaring > set of String/int values > > 1. they need less space in APK than enum, see > https://developer.android.com/topic/performance/reduce-apk-size#remove-enums > 2. they give more control over allowed values than "static final" values > > Main goal of patch is writing PanelState enum in the form common with other Chrome @IntDef: > > 1. with @IntDef first, @Retention second > and related @interface third > 2. with values inside @interface > 3. with NUM_ENTRIES declaring number of entries > 4. with comment about numbering from 0 without gaps > 5. with @Retention(RetentionPolicy.SOURCE) > 6. without "static final" in the @interface > > There is additionally removed one unnecessary Map. > > BUG=919666 > > Change-Id: I8149a0800bd5c0bb205028d230edadc83016ebb9 > Reviewed-on: https://chromium-review.googlesource.com/c/1142764 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Donn Denman <donnd@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635196} TBR=agrieve@chromium.org,dtrainor@chromium.org Bug: 919666, 935923 Change-Id: I6bceed612d667d47a9a7205c057d6b04b16c3bb0 Reviewed-on: https://chromium-review.googlesource.com/c/1489732 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#635774}
-
Xiaocheng Hu authored
Tbr: ricea@chromium.org NoTry: True Bug: 936108 Change-Id: I2bb162f307480a9af8de15729462f29e54535a6b Reviewed-on: https://chromium-review.googlesource.com/c/1490507Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/002ef361cabc..32b0f6739fa5 git log 002ef361cabc..32b0f6739fa5 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 stevenperron@google.com Use correct option in spvTextToBinary. (#2416) 2019-02-26 stevenperron@google.com Handle back edges better in dead branch elim. (#2417) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@32b0f6739fa5 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I26056b6ef3fcb97281656b4e22fa2517edcf2971 Reviewed-on: https://chromium-review.googlesource.com/c/1490096Reviewed-by:
-
Brad Hall authored
Bug: 790139 Change-Id: Ia6bda22ca94937dcc2a22f9ec6e23f1222fe217b Reviewed-on: https://chromium-review.googlesource.com/c/1474679 Commit-Queue: Brad Hall <bradhall@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#635771}
-
Amos Lim authored
Move On*Event(Stub) functions from EmbeddedWorkerTestHelper to FakeServiceWorker. Bug: 934665 Change-Id: I44bd5b26ebf0a3672c785fb2433a46a2f1a451a3 Reviewed-on: https://chromium-review.googlesource.com/c/1484406 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Auto-Submit: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#635770}
-
siashah authored
- Add a text view to display masked card details - Add error message for showing error on invalid expiration date - Move validation logic from CardUnmaskPrompt to AutofillUiUtils - Fix the width and the padding of expiration date and month input texts Current Demo Initial dialog -> https://screenshot.googleplex.com/46v8wXw33hA Dialog with error message -> https://screenshot.googleplex.com/xPha3pv3PuM Bug: 926316 Change-Id: Ia6e01b3910be4dd75c13a8d050c0286e331c91af Reviewed-on: https://chromium-review.googlesource.com/c/1471501Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#635769}
-
Julie Jeongeun Kim authored
This CL moves input_host.mojom and input_messages.mojom to public/mojom/input in order to organize mojom files at mojom folder. Bug: 919393 TBR=dcheng@chromium.org Change-Id: Ic260ba051088e77fdd115876a6bf5a0fa0db8935 Reviewed-on: https://chromium-review.googlesource.com/c/1478322Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#635768}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/793add9a8d60..3ee6a6225e33 git log 793add9a8d60..3ee6a6225e33 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 evanhernandez@chromium.org purge_gs: Move deps to contrib. Created with: gclient setdep -r src/third_party/chromite@3ee6a6225e33 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I305e5e2b0ad9f0f1ec8b6495d5c35a531595f889 Reviewed-on: https://chromium-review.googlesource.com/c/1490093Reviewed-by:
-
Caitlin Fischer authored
Logging will now only occur when one of the two cards being compared is a masked card and the two cards' last four digits match. Previously, logging was occuring regardless of whether or not the last four digits matched. Change-Id: I1a0d9d44df52cf9b6853dbaab041d05a1585e230 Reviewed-on: https://chromium-review.googlesource.com/c/1486431Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
-
Juan Antonio Navarro Perez authored
Start with a simple file adding pointers for further documentation of `run_benchmark` command. Follow up CLs can add on top by documenting other scripts in this directory. Bug: 922030 Change-Id: Ife3e22246746c416abf70ca0b0e92c2b51e2819d Reviewed-on: https://chromium-review.googlesource.com/c/1489231Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#635765}
-
- 26 Feb, 2019 14 commits
-
-
Austin Eng authored
This sets up the WebGPUImplementation to extend the right interfaces so we can later serialize commands into transfer buffers and receive the return command stream from the WebGPUDecoder. Bug: 877147 Change-Id: If707ad59de03f3e5a8f46423adc0249a22fb78a4 Reviewed-on: https://chromium-review.googlesource.com/c/1481614Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#635764}
-
Xiaocheng Hu authored
[Sheriff] Disable org.chromium.chrome.browser.autofill.AutofillPopupTest#testClickAutofillPopupSuggestion Tbr: rouslan@chromium.org NoTry: True Bug: 936183 Change-Id: I3003f32ee02103ab33b2b8fa0006e7df08245028 Reviewed-on: https://chromium-review.googlesource.com/c/1490501Reviewed-by:
-
mrefaat authored
This reverts commit 8605ee1f. Reason for revert: Broke chromium build, details in crbug.com/936211 Original change's description: > Enable -Wextra-semi in iOS builds. > > Bug: 926235 > Change-Id: I1c9f46a30392258e553a51d1033fde4d41e04210 > Reviewed-on: https://chromium-review.googlesource.com/c/1489180 > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635612} TBR=thakis@chromium.org,sdefresne@chromium.org Change-Id: I7bd6ed7e9758c6b5b82d2408e4f79fc9d9993bac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 926235 Reviewed-on: https://chromium-review.googlesource.com/c/1490443 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#635762}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c08497af77b7..a502bde5ced6 git log c08497af77b7..a502bde5ced6 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 rsavitski@google.com heapprofd client: shared sampler & client lifetime tracking Created with: gclient setdep -r src/third_party/perfetto@a502bde5ced6 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:120468745 TBR=perfetto-bugs@google.com Change-Id: I0ec0581e1c05c7eaaa40661a741f2629711f5f47 Reviewed-on: https://chromium-review.googlesource.com/c/1490094Reviewed-by:
-
Nick Diego Yamane authored
Currently, XkbKeyboardLayoutEngine::DifficultKeyboardCode performs unnecessary re-computation of XKB masks for Shift and AltGr modifiers when trying to decode key codes. This change proposes an optimization consisting on pre-computing and caching those masks only once, when the keymap is set, then saving some cpu cycles when decoding difficult keysyms/chars. R=spang@chromium.org Bug: 896640 Change-Id: Ifad7511f94312777d057930caf37b5c96ffbbad8 Reviewed-on: https://chromium-review.googlesource.com/c/1489951Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#635760}
-
Tim Song authored
A recent refactor changed the default ink drop logic, which caused a regression in ToggleButton: https://chromium-review.googlesource.com/c/chromium/src/+/1367186 All InkDropViewHosts now get a InkDropMask (default is a rounded rect). This change breaks the ToggleView as it effectively gets clipped to the view bounds. BUG=921485 Change-Id: I2fb1d5f1bb4981945fc93160fc75de9e533e1794 Reviewed-on: https://chromium-review.googlesource.com/c/1487079 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#635759}
-
Koji Ishii authored
This patch changes `text-overflow: ellipsis` to create the truncated ShapeResultView from ShapeResultView without creating intermediate ShapeResult, using the mechanism added in r633612 (CL:1477141). This saves memory by not creating actual sub RunInfo. This change also fixes an issue in offset computation in ShapeResultView::ForEachGraphemeClusters. This is discovered by this change because before this change, RunInfoPart always points to the full range of RunInfo. Some utility functions to compute character index are added. I hope they can be better structured to abstract differences between ShapeResult and ShapeResultView, but doing so is deferred to future patches as I understand it better. Bug: 636993 Change-Id: Ib2e501829051ca44f7aaccac4856ffce5618ba23 Reviewed-on: https://chromium-review.googlesource.com/c/1478319 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#635758}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fe3d4978886b..54c4772e855c git log fe3d4978886b..54c4772e855c --date=short --no-merges --format='%ad %ae %s' 2019-02-26 chrisforbes@google.com Fix point rendering 2019-02-26 chrisforbes@google.com OpAccessChain: Remove pointer walking inside loop 2019-02-26 sugoi@google.com Replace uses of sw::Surface with vk::ImageView in the Renderer Created with: gclient setdep -r src/third_party/swiftshader@54c4772e855c The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/124177079,chromium:b/124388146 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I167e11a1440bde632f5ec4bfc52d7ee2ff8e8ed8 Reviewed-on: https://chromium-review.googlesource.com/c/1490092Reviewed-by:
-
Liquan(Max) Gu authored
Currently FCP++ is hooking to pre-paint tree walk for the image nodes, Instead, it should hook to the paint stage. Text nodes have finished this change in https://chromium-review.googlesource.com/c/chromium/src/+/1470732. Now we should do the same for the image nodes. Specifically, the painters that the ImagePaintDetector hooks to include: * BoxPainter * SVGImagePainter * ImagePainter Bug: 924301 Change-Id: Id1c05bc38b7967908b78b26b74d1e8f2e8376aac Reviewed-on: https://chromium-review.googlesource.com/c/1477348 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#635756}
-
Yusuf Ozuysal authored
1) Add back button support :) - Adds a OverviewModeController that also gives the owner the APIs to show and hide the Overview. - Adds an internal implementation in ChromeTabbedActivity that will hold on to an overridable Controller and use that for all signaling. Every component gets the Container class and never changes it. - Extend the API for RecyclerView to support not animating hide and show - Have GridMediator implement controller and the Coordinator hand that off with a public API when needed. - Have the TabbedActivity explicitly own the Grid component and override the Controller. - Replace all calls related with Controller using LayoutManager with related Controller calls. 2) Makes sure the grid always shows the current tab when shown. 3) Disables swiping from toolbar to show the StackLayout and ToolbarSwipeLayout. (I will try to see if there is a path to enabling ToolbarSwipeLayout without adding a ton, but for now this is the most "elegant solution") BUG=934564 Change-Id: Ic778d2e2c158ba5e089f22d829f321f42e0e7684 Reviewed-on: https://chromium-review.googlesource.com/c/1484734 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
-
John Chen authored
ChromeDriver uses object caches for use while calling JavaScript functions. The data structure was designed to allow a separate cache for each shadow DOM, but that feature was never used, and objects in shadow DOMs have always been stored in the main page cache. This CL removes unused code, and resolves differences between test expectancies and actual code behavior. It prepares for future changes to make the object cache standard compliant. Bug: chromedriver:1461 Change-Id: I10fcd94a7fd2359cc43fe6bc7241d36647e9d744 Reviewed-on: https://chromium-review.googlesource.com/c/1485011 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
-
Marcin Wiącek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Patch is updating BitrateAdjuster to @IntDef with form common with other Chrome @IntDef: 1. with @IntDef first, @Retention second and related @interface third 2. with values inside @interface 3. with @Retention(RetentionPolicy.SOURCE) 4. without "static final" in the @interface BUG=919666 Change-Id: Id80ae65a9a57c4d4a47ce8b14db120d493eb4ace Reviewed-on: https://chromium-review.googlesource.com/c/1488092Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#635753}
-
Xiaocheng Hu authored
This reverts commit ae50f0f0. Reason for revert: Suspect of causing failure of PageLoadMetricsBrowserTest.InputEventsForClick https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%207%20Tests%20x64%20%281%29/49373 Original change's description: > Unify input delay computations for UMA, UKM, and EventTiming > > This CL moves the input delay computations for UKM to further down the > pipeline to where they are computed for EventTiming. After this CL, the > same types of events are logged by both UMA/UKM and EventTiming. The > WebViewTest is fixed so that the artificial events move further enough > down the pipeline. The tests checking for pointerCancels are no longer > applicable since these only applied to the UMA/UKM computations, per > issue 924278. > > By unifying input delay computation, this CL also fixes frame > attribution for the UMA/UKM input delays: PageWidgetDelegate does not > know the target frame (before, it would tell the root that an event has > occurred even if it occurred in an iframe. > > Bug: 897656, 925130 > Change-Id: I27dba1cbb82ad780d21166a5469001e266612a78 > Reviewed-on: https://chromium-review.googlesource.com/c/1476070 > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635687} TBR=tdresser@chromium.org,dtapuska@chromium.org,holte@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,npm@chromium.org Change-Id: Ibeaa1eb0cd197fee80383a9c7ce5beb63964a713 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897656, 925130, 936200 Reviewed-on: https://chromium-review.googlesource.com/c/1490401Reviewed-by:
-
Aga Wronska authored
Error state is shown after unsuccessful access code validation and cleared when user changes input (deletes or updates input field content). Backspace behavior was updated accordingly. Pressing backspace when input field has text deletes the text but does not move focus to the previous field. Pressing backspace on empty input field moves focus to the previous field. Bug: 911326 Test: ParentAccessViewTest Change-Id: I2860c0d02dee6f7aba95fcdaaa3271b98a25c07c Reviewed-on: https://chromium-review.googlesource.com/c/1477878 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#635751}
-
