- 02 Mar, 2020 40 commits
-
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. TBR=zork@chromium.org Bug: 1026641 Change-Id: I0d5281aa9d38d020299fe80e923f20f6f2fabc8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078429Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#745948}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0e841118..fee07500 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6a3c22cbf233c67eb785f01bfa7cbcb6a9c88637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083052Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745947}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. TBR=ajwong@chromium.org Bug: 1026641 Change-Id: Ie944b9fe2a5cbb5f561a21096a005ec9e8031c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078422Reviewed-by:
-
Gabriel Charette authored
This reverts commit d961adca. Reason for reland: Added mac fix not covered by CQ Original change's description: > Revert "Migrate off base::ThreadPool()-as-a-trait in /chrome/browser/apps" > > This reverts commit a8436a80. > > Reason for revert: This looks highly related to flakiness failure of MusicManagerPrivateTest.DeviceIdValueReturned on Mac builders. Let me revert this specualtively. > > Original change's description: > > Migrate off base::ThreadPool()-as-a-trait in /chrome/browser/apps > > > > This CL is a logical no-op. > > > > It manually covers the use cases the script > > (https://crbug.com/1026641#c22) didn't cover in > > https://chromium-review.googlesource.com/c/chromium/src/+/2026350. > > > > A few of the affected files were also migrated to > > content::GetUIThreadTaskRunner() whenever surrounding code consistency > > was at stake (but the bulk of that migration is staged to happen after > > this one so this wasn't a priority in this batch). > > > > Most files intentionally kept base/task/post_task.h as an include. It is > > still required because of a cyclical dependency during the migration > > preventing base/task/thread_pool.h from implicitly providing > > base/task/task_traits.h to its users (callers that explicitly store > > TaskTraits and include task_traits.h don't have this problem). The > > post_task.h include will be cleaned up in a later phase. > > > > This CL was uploaded by git cl split. > > > > R=dominickn@chromium.org > > > > Bug: 1026641 > > Change-Id: I459605163ef0c2a48b8e6e803721c5a16dd80ef6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078658 > > Commit-Queue: Gabriel Charette <gab@chromium.org> > > Auto-Submit: Gabriel Charette <gab@chromium.org> > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#745669} > > TBR=gab@chromium.org,dominickn@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1026641, 1057502 > Change-Id: I166a8cacd4225787ca752577d8f1af3abb9fe117 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081716 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Makoto Shimazu <shimazu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745831} TBR=gab@chromium.org,shimazu@chromium.org,dominickn@chromium.org Change-Id: Ie00efe8334727d9bef9fba78791c5fecf4ac51a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026641, 1057502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081516 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Mathias Bynens authored
DevTools front-end CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2082372 Bug: chromium:1057042 Change-Id: I1d866fb00bb36fd6307ec53beaafe1090a28b304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083147 Commit-Queue: Mathias Bynens <mathias@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#745944}
-
Armando Miraglia authored
The metric extended might still be needed for further analysis in launching APM in audio service. Fixed: 1055410 Change-Id: I09c6a80f8be3a8f3c148df62778bc9c2b18e3bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073877 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#745943}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. TBR=zhenw@chromium.org Bug: 1026641 Change-Id: Ie10e43eb49833e02e9dd9dd2b92a9ff1e51f22e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078780Reviewed-by:
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. TBR=ningxin.hu@intel.com Bug: 1026641 Change-Id: Ib31ef9cae55f5c6451e047b0fcf22346d080fecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079083Reviewed-by:
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=cpu@chromium.org Bug: 1026641 Change-Id: Icee9955f9fe86928864a99002d1b0702b767c550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078417 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#745940}
-
Thomas Tellier authored
Bug: 993653 Change-Id: I3b3721327cdea7f5c3beeebfd526d710baeac58e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080485Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#745939}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=chrisha@chromium.org Bug: 1026641 Change-Id: Id0f9ca05ab79a7fa3689b3e51d3f4ecd58e3f746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079086Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#745938}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. TBR=jennyz@chromium.org Bug: 1026641 Change-Id: I5d7c2a7b9598c8f724d48bfe865eca7ef674ace7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078419Reviewed-by:
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=thakis@chromium.org Bug: 1026641 Change-Id: I9d397e1ed2bc10e3e2c34e6c2e3b9a01d808417a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078778 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#745936}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. TBR=zork@chromium.org Bug: 1026641 Change-Id: Iafe58f29c0498309daa27c6df138b99437ac0c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079084Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/986680240f81..b7a3291dd131 git log 986680240f81..b7a3291dd131 --date=short --first-parent --format='%ad %ae %s' 2020-03-02 borenet@google.com [infra] Update infra dep 2020-03-02 borenet@google.com [recipes] Compute DM flags in gen_tasks 2020-03-02 borenet@google.com [recipes] Move DM flags to a separate file Created with: gclient setdep -r src/third_party/skia@b7a3291dd131 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: If5eb1243c542a2a5a1fbb2f7e14295cb3022e852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083216Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745934}
-
Mohamed Amir Yosef authored
Before this patch: "Hide suggestions" entry was always added when there are non-empty suggestions. When the user selects a suggestion, a new entry is added to "Clear form". And there is always an entry to "Manage addresses...". As a result, when the user select an entry, there are 3 extra entries added. After this patch: "Hide suggestions" is only shown if the user didn't interact with the suggestions. If the user selects one suggestion, this indicates the suggestions are actually useful. If the user clears the form, they will be presented with "Hide suggestions" again. i.e. the "Hide suggestions" and "Clear form" are alternating but they never appear together in the suggestions list. As a result, we at most have 2 extra entries added. Bug: 1030649 Change-Id: Icf4e81f141db8018fbbf7029dec0472d70db9153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083172Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#745933}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c6a65c886648..61f74d91f823 git log c6a65c886648..61f74d91f823 --date=short --first-parent --format='%ad %ae %s' 2020-03-02 hta@webrtc.org Reland "Expose can_trickle_ice_candidates on PeerConnection" 2020-03-02 hta@webrtc.org Revert "Expose can_trickle_ice_candidates on PeerConnection" 2020-03-02 marinaciocea@webrtc.org Insert frame transformer between Depacketizer and Decoder. Created with: gclient setdep -r src/third_party/webrtc@61f74d91f823 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:708484 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic43e0c31a4e3acfadb59c5863a0e99056f9bbf87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083215Reviewed-by:
-
Andy Paicu authored
As we expect new people to join the permissions team, I've written a short overview of the site settings screens in Android to help people start up when working with these. Change-Id: I176a5cf7a8ff29dc1b28b8c3f82062bb0e5db8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077437 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#745931}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/90d83a0b66e6..a7b1f947eb0a Created with: gclient setdep -r src-internal@a7b1f947eb0a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I583349bb0707f43e3d4ede60d97aec9d2281f41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083211Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745930}
-
David Staessens authored
Each video used by the video_decode_accelerator_tests and the upcoming video_encode_accelerator_tests has an accompanying metadata file describing the video's properties. The CL makes the "md5_checksums" and "thumbnail_checksums" fields optional. They were already optional in that empty lists where allowed, but this CL makes them completely optional as they don't make sense for all tests (e.g. validation will never be used for performance tests). TEST=./video_decode_accelerator_tests on hana BUG=1045825 Change-Id: Id2f80655517180c6021694b0d9080550256ccbdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073418 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#745929}
-
Sami Kyostila authored
NOTRY=true TBR=sullivan@chromium.org Bug: 1039801 Change-Id: I12515ffaba3afe73243f956a53fbbc3d60a34e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082376 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#745928}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5a58091e4d1a..b60935270c47 git log 5a58091e4d1a..b60935270c47 --date=short --first-parent --format='%ad %ae %s' 2020-03-02 szuend@chromium.org [utilities] Use Set instead of Array for TargetManager._targets 2020-03-02 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-02 szuend@chromium.org Prepare CallStackSidebarPane.js for asynchronous live locations 2020-03-02 jacktfranklin@chromium.org Move UIString.ts tests into Ninja build Created with: gclient setdep -r src/third_party/devtools-frontend/src@b60935270c47 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1032016,chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4e97ecd8778b2b2536b74838fc7787ca43da9c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083213Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bad7fce371da..fc12e7fd7eb8 git log bad7fce371da..fc12e7fd7eb8 --date=short --first-parent --format='%ad %ae %s' 2020-03-02 ilkos@google.com Merge "Cleanup startup: remove CPU ratio" Created with: gclient setdep -r src/third_party/perfetto@fc12e7fd7eb8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7bb71afd9d643df072948340a351d0ba174de6b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083212Reviewed-by:
-
Oriol Brufau authored
When referencing a line name appearing both inside and after an auto repeat(), the code used to just take the minim of: - The absolute index of the line inside the auto repeat(), i.e. the local index relative to the auto repeat() plus the insertion point of the auto repeat(). - The index of the line outside the auto repeat(), without expanding repeated tracks. This was correct if the line outside the auto repeat() preceded it. Otherwise it was wrong due to not taking repeated tracks into account. For example, with grid-template-columns: 1px repeat(auto-fill, 2px 3px [a]) [a]; the absolute index of the line inside the auto repeat() is 2 + 1 = 3. And the absolute index of the line outside the auto repeat() is 1 + 2*n. However, the used index wasn't including repeated tracks so it was 2. Therefore, the minimum was 2 but should have been 3. BUG=966090 TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-003.html Change-Id: I1777a64d7e7d39350a327185dcd13f82493adfdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071019 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#745925}
-
Swapnil authored
TYPE_UPLOAD_APP_INSTALL_REPORT is no longer used by CloudPolicyClient as we use RealTimeReportingJobConfiguration for App Install Reporting now. It should be deprecated. Bug: 1051897 Change-Id: I62342737039cb6ac56c84f8303a4951d343d1427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056807 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#745924}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: I6581822689118b554107689e3cbca29b16d240df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080427Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Colin Blundell authored
This is a test version of UrlUtilities.java that mocks out the native methods. This move follows the move of the production class. There is no internal usage of this class, so this CL does not need to be a 3-sided patch. Bug: 1031465 Change-Id: I01bc79f3dd326cc675419e09c58ad45f5b78076a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083093Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#745922}
-
Fabian Sommer authored
Delete dead code which was only used in the old UI for SecurityTokenRequests. This includes the Back button in LoginPinView. Bug: 1001288 Change-Id: I3b6379597ede5c95bb445e63321db192cfdc2557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080472Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Auto-Submit: Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#745921}
-
Colin Blundell authored
This class was deprecated in https://chromium-review.googlesource.com/c/chromium/src/+/2077681, and the internal repo has now been converted. I verified that no commits have been made to this file since the above CL. Bug: 1031465 Change-Id: I7b5b6d494325eade1faa28315a1d3f2fd55433ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080425Reviewed-by:
-
Armando Miraglia authored
The metric extended might still be needed for further analysis in launching APM in audio service. Fixed: 1055394 Change-Id: Ib5f1faeed4994cc6e82e01eaaf0f2895b51e4e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073718 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
-
Tamer Tas authored
This CL fixes the metric names for Google Docs browsing story. R=ulan@chromium.org Bug: 1044682 Change-Id: I581656841be934faeb8dcbdfe5399d3e6d8d51cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078616 Auto-Submit: Tamer Tas <tmrts@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#745918}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/367dbff98555..986680240f81 git log 367dbff98555..986680240f81 --date=short --first-parent --format='%ad %ae %s' 2020-03-02 borenet@google.com [recipes] Make dm_flags not depend on api Created with: gclient setdep -r src/third_party/skia@986680240f81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: Ib6a3051518321323135144d6a9ee718530cf535d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082887Reviewed-by:
-
Sigurd Schneider authored
This CL adds specific error reason reporting for resources that get blocked due to COEP errors. Blocking either occurs in a URLLoader or in a NavigationRequest. The error is plumbed to the DevTools front-end, which should help developers identify and fix COEP issues. Note that this CL does not address CORB blocked fetches, so DevTools will report a plain failure if those get blocked. Bug: chromium:1051473 Change-Id: Idad0d1669d0f45a7116419e1935feb0bb9973e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070409Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#745916}
-
Yuki Shiino authored
Adds a missing header include to core/testing/type_convertion.h. Bug: 839389 Change-Id: I610c1bf60d6b7c3ac0898383b37bb5c232fcb3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082223Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#745915}
-
chrome://autofill-internalsChristoph Schwering authored
BUG=1055269 Change-Id: If0df46d9629213d8f5d93f0d0defb7267106a113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080245 Commit-Queue: Christoph Schwering <schwering@google.com> Auto-Submit: Christoph Schwering <schwering@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b867043d772f..5a58091e4d1a git log b867043d772f..5a58091e4d1a --date=short --first-parent --format='%ad %ae %s' 2020-03-02 rajasekar89be@gmail.com Select main thread in memory tab by default 2020-03-02 szuend@chromium.org Move String#trimURL from String prototype to a utility function 2020-03-02 szuend@chromium.org [utilities] Replace Array with Set in ResizerWidget 2020-03-02 szuend@chromium.org [utilities] Replace Array with Set for pending animations 2020-03-02 szuend@chromium.org Move String#isWhitespace from the String prototype to a utiltiy function Created with: gclient setdep -r src/third_party/devtools-frontend/src@5a58091e4d1a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id4efbc9ca2aeee5286db9d0b2b8dbf0d5057f3d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082885Reviewed-by:
-
Jamie Madill authored
This will allow for ANGLE to split a slow and flaky test into small sub-tets. See issue for more details. Bug: angleproject:4449 Tbr: kbr@chromium.org Change-Id: Ic8ca089f34d3fec18078da8182e2353b8f941c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082352Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#745912}
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates Sync Settings classes. Since settings is considered as always running on regular mode, it is safe to use regular profile even called in incognito mode for initialization of HelpAndFeedback activity and checking whether profile is child profile. Therefore, it is safe to leave behavior as-is today and no need to make change on code behavior to act differently for each profile. Note: This change is only code clean-up, does not change any behavior. Change-Id: I130ae3c5daedaf29ef412234c1d04594d1ea9093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072179Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#745911}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/042a952b5a58..90d83a0b66e6 Created with: gclient setdep -r src-internal@90d83a0b66e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1045256 Tbr: jbudorick@google.com Change-Id: I8ae8a6f910312328d5f0209b6c1adafc5c425e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082884Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I53d0eec5b8ea83045d06a5e78b098025f17665dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082886Reviewed-by:
-
