- 17 May, 2019 40 commits
-
-
David Bokan authored
This reverts commit 07da8ba6. Reason for revert: Causing issues in 962784 and 951901 Original change's description: > Reland "Recreate DirectManipulationHelper when every LRWHH UpdateParent" > > This is a reland of 61450bbc > > Original change's description: > > Recreate DirectManipulationHelper when every LRWHH UpdateParent > > > > Compositor and window event target is associated with window's parent. We call > > LRWHH UpdateParent when window's parent update, includes window's parent > > actually update and window initialize. Recreate DirectManipulationHelper on > > every window's parent update helps keep DirectManipulationHelper lifecycle > > tracking simpler. We also make CompositorAnimationObserver owned by > > DirectManipulationHelper. > > > > With this changes, we start the DirectManipulation event polling when > > DirectManipulationHelper created and stop when it destroyed. The issue should be > > fix since event polling start no more depends on DM_POINTERHITTEST. > > > > > > This also includes 2 refactoring changes: > > > > 1. Move CompositorAnimationObserver into DirectManipulationHelper. > > 2. Call ZoomToRect to reset viewport of DirectManipulation when viewport is > > actually transformed in RUNNING - READAY sequence. > > > > Bug: 914914 > > Change-Id: I0a63f9a407e0231d631e64f2b22a9975471f2fd9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547049 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#649342} > > TBR=sky@chromium.org > > Bug: 914914 > Change-Id: Ic0c8aa84d21fe7a88fd9d3552dbd5ffdb6adcc4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562582 > Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> > Reviewed-by: Jianpeng Chao <chaopeng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649682} TBR=sky@chromium.org,chaopeng@chromium.org Bug: 914914,951293,951901,956579 Change-Id: I4252717e2f708643b1d6b3f8305c32142a1a2735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618008Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#660964}
-
Kyle Milka authored
Update the default background tile to use the correct icon. Screencast: http://go/scrcast/NTA1MjYwODk1NzkwNjk0NHw5MDBlYzU5YS1mMg Bug: 937570 Change-Id: Ib1aa03cb0fab2e681774424492511d239f62dd7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618001Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#660963}
-
Sam Maier authored
This change enables binary resources (instead of the deprecated legacy mode) for Robolectric. Also, this CL fixes a number of tests which are broken by this change. Updated some robolectric Android jars to enable usage of this newer feature. TBR=Last 2 files are just updating from J to K Bug: 963624, 635199 Change-Id: If99f8850baa5de9d8ec8eaf2c58b2c0b16be0658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611875 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#660962}
-
Yuwei Huang authored
This is a reland of 7432ef1a It fixes the issue of remoting_support_host_messages.proto using host_info.proto without depending on it. Original change's description: > [remoting][IT2ME] Register support host over remoting API > > This CL adds a RemotingRegisterSupportHostRequest that registers an > IT2ME host using the new remoting API. This will be used for the > ChromeOS enterprise use case but the website will still use the old > XMPP-based registration request until it is updated to support that. > > Bug: 962765 > Change-Id: Ifcf2eb6eaba76db6386ae27f86f20e06088383f0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611023 > Commit-Queue: Yuwei Huang <yuweih@chromium.org> > Reviewed-by: Joe Downing <joedow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660738} Bug: 962765 Change-Id: Ia5e6bf1263ad7f2e4f353c9fc0e0c13d73bb8be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617100 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#660961}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/819795047c32..fdbb15913346 git log 819795047c32..fdbb15913346 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 evanhernandez@chromium.org api: Regenerate binhost proto 2019-05-17 mikenichols@chromium.org upload_symbols: Refactor duplicate to utilize batch api Created with: gclient setdep -r src/third_party/chromite@fdbb15913346 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I9156b72e613f3ddaa0cd94a079bf3eca83e44e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616736Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660960}
-
Xianzhu Wang authored
Change-Id: I13a4bbd5f919a744ac4fecc0a48651e95a9138b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612358 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#660959}
-
Timothy Loh authored
This CL updates the Plugin VM strings used in the settings page, fixes some errors in the descriptions and marks them as translatable. Bug: 950431 Change-Id: I45252e977860abfcbdab22649a1141eee8a49bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614727 Auto-Submit: Timothy Loh <timloh@chromium.org> Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#660958}
-
Pavel Shmakov authored
Support the api added here: https://android-review.googlesource.com/c/platform/frameworks/support/+/958733 Since CustomTabActivity is recreated when system setting is changed, it's enough to pick correct scheme parameters when activity is launched and new instance of CustomTabIntentDataProvider is created. Bug: 960453 Change-Id: I975682a8f6dd57a5ab6fa0bc12dc769e80631bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599591 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#660957}
-
David Maunder authored
Bug: 961356 Change-Id: Ibc00f936ffe9978e8599e132dfdf7f1a1a70c2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612662 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#660956}
-
John Budorick authored
Bug: 790202 Change-Id: Icb8d353adb84747d5791c7a38e3ef211690cf712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614025Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#660955}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c6e50309dcbd..bbaaf61f1d99 Created with: gclient setdep -r src-internal@bbaaf61f1d99 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: I92ebb34e7beb1fe32a7f3aa6c9a0002bfc604100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616730Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660954}
-
Mounir Lamouri authored
This is also delaying resolving the promise to make sure the order stays the same. Bug: 960657 Change-Id: I92095affb8223dd60346796eec1b6cd7d3f0efc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617552Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#660953}
-
Ken Rockot authored
This is a replacement for the global content_browser service instance. Necessary because some random services (like pdf_compositor) connect directly to content_browser by name. There are multiple instances of content_browser -- the global one, and one per Browser Context -- and it is impossible in general for the Service Manager to correctly resolve these connection requests to the global instance. It only works today because of a combination of luck and subtle Service Manager complexity which is about to be deleted. Furthermore, the work done and interfaces exposed by the global instance vs the per-BrowserContext instances are almost entirely non-overlapping, so they are functionally different services already anyway. For now content_system's service manifest programmatically mirrors the content_browser manifest (plus overlays), without its packaged services. All non-renderer clients which connected to content_browser before are updated in this CL to connect to content_system instead, and content_system is designated as a singleton service to ensure the Service Manager can always properly route to it. This is a precursor to removing the content_packaged_services service, as well as removing packaged services from content_browser and generally simplifying service registration across the system. Bug: 961869, 895615 Change-Id: I9b022f1600ff25e72795e9f63d9b9b978079f80f TBR: avi@chromium.org TBR: blundell@chromium.org TBR: boliu@chromium.org TBR: halliwell@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606764Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#660952}
-
Esmael El-Moslimany authored
Bug: 960564 Change-Id: Ica6b02cfca8e95e5e41871153359fe36f33c0599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613372 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
-
Tanya Gupta authored
This JNI layer is needed for the SendTabToSelfInfobarController to listen for model changes and show an infobar accordingly. This required refactoring the code that converted the native SendTabToSelfEntry to the Java version. Change-Id: I2b63c2bfbfa66ac70a2fd320ae7d9652b1ff996b Bug: 949233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611223Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#660950}
-
John Williams authored
CastDialogSinkButton::RequestFocus is called recursively, resulting in a DCHECK failure. As a workaround, this function now detects when it is called recursively and aborts prematurely. Change-Id: I4847f862868ef9c15ed0ca6cd54cb36cc559a901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488581 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#660949}
-
Joey Arhar authored
Currently in the websocket message viewer, sent text messages have a green background, received text messages have a white background, and binary messages are yellow on yellow. This patch removes all of these interesting colors and replaces them with data grid striping to look more like the other datagrids in devtools. Screenshots: http://crbug.com/963949#c2 Bug: 963949 Change-Id: I0403a8c67a36e5ad0bd006d59e60fc02d371d7ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614036Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#660948}
-
Eric Roman authored
Bug: 962523 Change-Id: Ie88be0e1cd3d132e1124aded16cdcec0bd65c2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613936Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#660947}
-
Tommy C. Li authored
We have completed this experiment, so we don't need this code anymore. This removes those 8 flags and the associated UI code. Bug: 936079 Change-Id: Id120d5619807d413bd0cfea1ad702b87d72b6505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616151 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#660946}
-
David Bokan authored
This is causing crashes in debug builds. Comment out for now so that it allows running with DCHECKs enabled while we investigate. Bug: 944706 Change-Id: I4ff0d604dc52c8893898195c6843e95d91b5598a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617881 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#660945}
-
Eric Roman authored
Bug: 959020 Change-Id: I04e0b4e79266a04f6cafcd823ebc4a659be1cae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616143 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#660944}
-
Adam Langley authored
Sites can specify a timeout for a Webauthn operation but Blink enforces sanity bounds on the value. This change alters those bounds from [1..60] seconds to [10..600] seconds. A one second timeout is unreasonable: it'll cause the UI dialog to appear and then disappear one second later; probably too fast for the user to read. Also, a 60 second upper bound seems too harsh: if a site wants to allow a longer timeout, why not? I'm sure I've spent more than 60 seconds going downstairs to find a security key on occasion. Change-Id: Ia9d677d0b7249059529112b4ee0b69bd870d751a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617644 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#660943}
-
Caroline Rising authored
This is used to see if the tab strip has focus for showing tab hover cards during keyboard navigation. This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/1612220 Bug: 963537 Change-Id: I8d684255c42007012f599b8a13d6a0fda76665d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613927Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#660942}
-
Bailey Berro authored
This change introduces a notification that is displayed when a user plugs in a USB printer that is saved to their profile, notifying the user that the printer has been plugged in. Bug: 951139 Change-Id: I679e8d19f5bacc94e96a10588c792e307259d7f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594802Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#660941}
-
Sam Maier authored
Just rolling to stay current. Brings in some more binary size improvements. Change-Id: If7fdcaace3cd96339c1304155f264f7c3d7361ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617132 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0e405d1ac6ad..d7e41546c030 git log 0e405d1ac6ad..d7e41546c030 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@d7e41546c030 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I236990499c937469c40fe3e96d090c0971c5bbd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616733Reviewed-by:
-
Yann Dago authored
- Managed browser: http://screen/XZ1boVPgvaQ - Unmanaged browser: http://screen/RK8VnbwyaRJ - crOS account managed: http://screen/TzGFSeG2LSX - crOS account and device managed: http://screen/OJB4e57XwdP - crOS account and device managed different domains: http://screen/5B0NGV9BF6X - crOS unmanaged: http://screen/d3QiBwZ3rMk Bug: 958182 Change-Id: Ice67ddd4b1dbd07d563565fa2170d23442c7500f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595074Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#660938}
-
Aran Gilman authored
Not inverting already light text is expected to improve legibility of text overlaying images. It's not yet known what the net impact will be, though, since light text in other contexts may become less legible. To test this feature (i.e. don't invert text in dark mode), add darkModeTextPolicy=1 to the Blink settings flag when opening Chrome. Bug: 963578 Change-Id: I34255ea31afe5acf4f15fb1a2473de91cdda0f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616016 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#660937}
-
Caroline Rising authored
Fix bug where hover cards were showing when exiting the tab during the delay before showing a hover card. Bug: 910739 Change-Id: Ia86099879e19fc1d43a4b3527c9b3cc2f63d872b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617083Reviewed-by:
-
Robert Sesek authored
In the future, macOS executables will be signed with the "runtime" option, which restricts the execution of writable memory. By specifying the MAP_JIT flag to mmap and code signing with the "com.apple.security.cs.allow-jit" entitlement, writable memory can be executed. Neither the runtime option or entitlement are currently specified during signing, but setting the MAP_JIT flag is harmless. The signing options will be specified in follow-up CLs. Bug: 850193 Change-Id: I834a75e65b815d5a9a62ef1e3d00e143b36d2ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613809 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#660935}
-
Lakshman Annadorai authored
Internal bug b/130928904. Record thread types of TaskScheduler* and CompositorTileW* threads using the newly added SCHEDULER_WORKER_THREAD and COMPOSITOR_TILE_WORKER_THREAD thread type enums, respectively. Change-Id: Id363a580a844d08a269b148967072aa9b3aaa268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604208 Commit-Queue: Lakshman Annadorai <lakshmana@chromium.org> Auto-Submit: Lakshman Annadorai <lakshmana@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#660934}
-
rbpotter authored
Bug: 964144 Change-Id: If9b4320e36cff0564dd7a139eceba5844a0c5bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616327Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#660933}
-
Andrew Grieve authored
It's purpose was to turn on splits. Now that they have shipped, there's no need to be able to turn them off. Leaving reference int diagnose_bloat.py (at least for a while) since that script needs to be able to sync back past this change. Change-Id: I9a4cfae043497e811db9fc8509688b8adee0fed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617134 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#660932}
-
Mike Wasserman authored
I somehow missed these (rebasing?) in http://crrev.com/c/1595553 TBR=sky@chromium.org,dcheng@chromium.org Bug: 958215, 958247 Change-Id: I70ce1ec130c44b91b6cc864d41ee82730e293be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617910 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
-
David Bokan authored
In the linked bug, we try scrolling the page using the keyboard. While all the scroll offsets in Blink are correctly updated, we don't see the scrolling occur on the screen. The reason for this is that we don't realize anything has changed and the commit is aborted due to no changes. It turns out we don't update the offset on the VisualViewport's cc::Layer. The reason this doesn't manifest in other contexts is that we usually perform viewport scrolling using touch or wheel events which are handled on the compositor thread. The fix here is to do what we do for PaintLayerScrollableAreas and call UpdateCompositedScrollOffset on the VisualViewport when the offset changes from the main thread. We need to update the cc::Layer's offset since we use a change in this offset to determine that a commit is needed. This is a similar issue to the one fixed in https://crrev.com/dfe90fdc496af64515756ba1b5970d2760b7314d Bug: 956579 Change-Id: Ie9854f3df1b7065bc2d021b131ff6a8998a8f59d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617545Reviewed-by:
-
Kristina Nelson authored
With this CL, if the visible URL (in the URL bar) is changed while a report is being generated for a suspicious site the original (suspicious) URL is reported. Bug: 237908 Change-Id: I8a12ef6bfabb5a865d83846894d01459a9f3860a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614450 Commit-Queue: Kristina Nelson <krstnmnlsn@google.com> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#660929}
-
Sergey Ulanov authored
Previously SysmemBufferCollection could crash if it failed to initialize (e.g. due to Allocator interface missing). Change-Id: I72f83ebe7ad858ab908ad42fb08aeff895327c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614001 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#660928}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f71cccb9dc5..b45ee83cc7c0 git log 4f71cccb9dc5..b45ee83cc7c0 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 mtklein@google.com warmup learning sksl interpreter 2019-05-17 bsalomon@google.com Initial version of rescaling async readback API 2019-05-17 michaelludwig@google.com Refactor complex CTM management for image filters 2019-05-17 jvanverth@google.com Metal: Add check for invalid shader functions 2019-05-17 robertphillips@google.com Switch over to using new direct allocation API in our tests (as much as possible at least) Created with: gclient setdep -r src/third_party/skia@b45ee83cc7c0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:959412 TBR=michaelludwig@google.com Change-Id: I4bd06d7fa57cbf2c6e62a6ad2777f860dde001a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616729Reviewed-by:
-
Jun Mukai authored
Bug: 958467 Test: trybot Change-Id: I31d7f169afddbfcef8af983bb71ca81d6b9a0b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617133Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#660926}
-
Hector Carmona authored
Bug: 951915 Change-Id: I381227e4ea3719e1df8ad5b6bdffd26daacda54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603526 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#660925}
-
