- 18 Mar, 2020 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4c07605f8d55..6798043d95ac git log 4c07605f8d55..6798043d95ac --date=short --first-parent --format='%ad %ae %s' 2020-03-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0fe8f345..1386d9f5 (751074:751294) 2020-03-18 mbonadei@webrtc.org Remove apk-patch-size-estimator from DEPS. 2020-03-18 phoglund@webrtc.org Proper fix to the summary options problem. Created with: gclient setdep -r src/third_party/webrtc@6798043d95ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029452 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2b42b65d9befe8314986605dd427e402cf777a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106141Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751392}
-
Yuki Shiino authored
In third_party/blink/renderer/core/animation/timing.h, there are static inline functions defined, which are harmful from a PoV of namespace contamination. (Static inline functions in *.h are no good in the first place.) Moves IsNull and NullValue into Timing struct, and removes ValueOrUnresolved. Change-Id: I777740c4ce020dc78350fb2b5c9322db10660705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106988Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#751391}
-
chrome://omniboxmanuk authored
This makes it easier to read long URLs or other fields. Change-Id: I33a943a82fe9a3a9a4d2f2f5ef30c8fbb6197bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107691 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#751390}
-
Christopher Cameron authored
Have AppShimTerminationManager call back into AppShimManager::Delegate to determine if app windows are open. This will allow us to remove all includes of platform_apps from app_shim. Bug: 1057195 Change-Id: I04d13efaca5f65fd507c0f949068e2a6d830e2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108003Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#751389}
-
Chris Lu authored
WebStateObserver::PageLoaded triggers this call in LanguageDetectionController, but it can be executed while a preloaded WebState is finished in the background. Then, when that WebState is swapped out as the active WebState, StartLanguageDetection() will never be called in LanguageDetectionController. Thus, the infobar never shows. Adding the call to the init method when the WebState is swapped solves the issue. Fixed: 947482 Change-Id: If6b6a77711039835596374bdc6121ece4642987c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095355 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#751388}
-
Theresa Wellington authored
If the setup fails for some reason, the test server may be null. Check for null so that the test failure reason shows the startup error. BUG=1062642 Change-Id: I2a7710da86f94ae50420f010c4ec74a8070381f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108602Reviewed-by:
Lijin Shen <lazzzis@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#751387}
-
Hui Wang authored
There has a chance that the |SynchronousCompositorProxy| will re-attach the new compositor when the RWHWA was reused, and the |SynchronousCompositorControlHost| will bind failed if the remote has been bound. The browser will hang when send a |BeginFrame| through the new |SynchronousCompositorHost| but the |BeginFrameResponse| was sent to the old host control. Bug:1062576 Change-Id: I0bb953a265a1f1d5b8a445701702c168aa7316f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107333Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#751386}
-
Theresa Wellington authored
BUG=1027790 TBR=boliu@chromium.org Change-Id: I8f30fd474c038bd2eb6a7321bac82517d12f71ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106390Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#751385}
-
Theresa Wellington authored
BUG=1060975 TBR=dmurph@chromium.org Change-Id: I288bacd1a18db0a30e2c2c7b36acd6966c2f02f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106388Reviewed-by:
-
David Bokan authored
There are several places where a gesture might get dropped/filtered in the input router. The lack of tracing here makes it difficult to debug "scrolling doesn't work" issues. Bug: 1048098 Change-Id: I5917d3ceb5cd1b74f7c4ae3097dcb8e2ec009ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106968 Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#751383}
-
Nicholas Verne authored
Bug: 1056268 Change-Id: Ie4cd3dc2769f1cac596d4e7eb75641e4b1563abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107052 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#751382}
-
Koji Ishii authored
This patch refactors painting selection, as a follow up to the mid-ligature support in r750701 <crrev.com/c/2103968>: 1. Avoid calling |SelectionPaintingStyle| and a few other functions that are needed only when there is a selection, if there is no selection. 2. Collect logic to |SelectionPaintState|. 3. Eliminate |have_selection| and put all state variables to |Optional<SelectionPaintState>|. This patch has no behavior changes. Bug: 1025341, 982194 Change-Id: I1cd52d281c1191d19dd93f0657906733f3ea1af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108207Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#751381}
-
Etienne Pierre-doray authored
To avoid flaky failures with slow running tests. Bug: 1046343 Change-Id: Iafb6d15c08fb8c97eaa36d802cee5f993eceacd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107602 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#751380}
-
Mohamed Amir Yosef authored
For butter users, only blacklisting entries from the default stores should be considered. Before this patch: Any blacklist entry from any store will suppress the save prompt. After this patch: For a user in the account mode, only blacklist entries from the account store are considered, and similarly for user in the profile mode. Bug: 1002000 Change-Id: I791ec608e25263cafba2c477a00b0b37009b8081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102543 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#751379}
-
Aya ElAttar authored
This WebUI should be loaded instead on any chrome://* if it's set to be disabled by an admin policy. The html page to be loaded is a basic page, and will be changed upon UI review. Bug: 1061859 Change-Id: I50c72c744458b141fb777cf9758ca970c2638a66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098906 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#751378}
-
Elly Fong-Jones authored
Instead, use BrowserWithTestWindowTest. One wrinkle is that it doesn't seem to work to use BrowserList:: SetLastActive - something that BrowserWithTestWindowTest sets up causes a crash in other profiles code when really changing the last active browser. Instead, to make the test more unit-y, just bypass BrowserList and call the controller directly. Bug: 39725 Change-Id: I3f872c936ea8e81cb4647cc7f25257fde0a4cc63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108626Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#751377}
-
Adam Kallai authored
These tests rely on some traditional internal heap implementation and try to corrupt HEAP_ENTRY structure right before the heap address is returned to user. On Windows ARM64, segment heap is default on, so there is no HEAP_ENTRY anymore. The STATUS_HEAP_CORRUPTION is not reported on WoA, as it is expected on these test cases. For more details, please see the bug. Bug: 1054423 Change-Id: I3f275e2188d362848f64ff6601e376a3a6ffbb82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066731 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#751376}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6d51bf00ea3c..db09d1b2bd79 git log 6d51bf00ea3c..db09d1b2bd79 --date=short --first-parent --format='%ad %ae %s' 2020-03-18 tvanderlippe@chromium.org Typecheck root/ with TypeScript Created with: gclient setdep -r src/third_party/devtools-frontend/src@db09d1b2bd79 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9bb75229eebef8b3f8fa9586261b279daa0c4f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108111Reviewed-by:
-
Matt Menard authored
Change-Id: I686e4176ce3ceeb2e08ab4084c0b70cec7273580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085703 Commit-Queue: Matt Menard <mattme@google.com> Reviewed-by:
-
Kevin Schoedel authored
This is a reland of 4154e5e3 Original change's description: > Fix combining characters for c with acute accent > > The table had ´c map to ç instead of ć, imitating GTK from circa 2008. > This was overlooked in the conversion, and left no way for users to > type ć (used in Polish for example). > > I speculate that GTK was imitating the Windows ‘US International’ layout, > which has that mapping. We have a separate section of the combining table > for the Windows-like ‘US International PC’ that does map ´c map to ç, > but this should not still happen for other layouts. > > Bug: 1061753 > Change-Id: I113b3d6c3fda6b93f7f27296b1a30dae6aa0b668 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102776 > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> > Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750545} Bug: 1061753 Change-Id: Ia12422c864a044266099035c54c75fdb365e7e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105423Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#751373}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d6e1e088f7f1..829a21222fe3 git log d6e1e088f7f1..829a21222fe3 --date=short --first-parent --format='%ad %ae %s' 2020-03-18 morg@google.com Remove unneeded user build targets for VMRVC PFQ 2020-03-18 xixuan@google.com chromite: clean useless TODO under my name. 2020-03-17 gredelston@google.com Unset STRICT_SUDO after calling cbuildbot.main() 2020-03-17 chrome-bot@chromium.org Update config settings by config-updater. 2020-03-17 tcwang@google.com afdo: Stop uploading AFDO profiles with unparsable names. 2020-03-17 morg@google.com Enable eve-arc-r for VMRVC PFQ Created with: gclient setdep -r src/third_party/chromite@829a21222fe3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I2f09475ad62a49aff5ce00ade73398252303ebe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108660Reviewed-by:
-
Stephen Roe authored
This will give more information about test crashes within the Fuchsia VM. Bug: 1055553 Change-Id: I67291708cc4f84a782228725f8641dbacc0951e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090294Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#751371}
-
Aaron Leventhal authored
StringAttribute::kClassName was unused. The only way the class name was exposed was via the HTML attributes. Expose via kClassName and remove from HTML attributes list. Bug: None Change-Id: I9667bd57460271a7310f26f8fee19fe41c234f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105953 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#751370}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b988e0398277..83e138ca962c git log b988e0398277..83e138ca962c --date=short --first-parent --format='%ad %ae %s' 2020-03-18 enga@chromium.org D3D12: Fix usage of CopyResource Created with: gclient setdep -r src/third_party/dawn@83e138ca962c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I1eedfe78678bcde97eebb2036b3d022e7f3d3d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108108Reviewed-by:
-
Ian Kilpatrick authored
Instead of separate MinPreferredLogicalWidth/MaxPreferredLogicalWidth this introduces PreferredLogicalWidths to return the pair. There should be no other behaviour changes. Bug: 845235 Change-Id: I66b3cd1eb8eb5df41966e6ae06944651ac2baa51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097124 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#751368}
-
Yann Dago authored
When validating the url of some tabs, they were not necessarily loaded. We now wait for them to be loaded before checks. Bug: 958893 Change-Id: I17f83ec19c790224fc479632df35769da72b7a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107060 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#751367}
-
Peng Huang authored
VulkanImage::CreateWithExternalMemory() is for creating a VkImage with memory which can be exported and used by foreign API. This method also uses vkGetPhysicalDeviceImageFormatProperties2() to query supported handle types instead of hardcoding in the VulkanImplementation. Bug: 848385 Change-Id: Ic8d93798b72e5c7a157c1fa924bcf3f3d15c275c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107704 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#751366}
-
Zhenyao Mo authored
Otherwise, all tests except the first one display an error message. BUG=1026447 TEST=viz_perftests R=backer@chromium.org Change-Id: I4e71979592debbc21e3d8e234318f1f4788b4de4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108226Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#751365}
-
Sam Sebree authored
This change uses the -internal-light-dark-color css property to set correct dark mode styling on the button native controls. Bug: 929098 Change-Id: I15e68cda2a07bb89601c43ef1dc8ce696c75b1ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097318Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#751364}
-
Tanmoy Mollik authored
Add a test to check the signIn method in SigninManagerTest Bug: 1059964 Change-Id: I953d4344fc50b892b793d6045aa7bf77d246141c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095128Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#751363}
-
Elly Fong-Jones authored
Change-Id: Ic5d667ad032cc8c6aca9043ccdc5cb892c0bdff7 Tbr: groby@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101314Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#751362}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2aa80df14528..dc0f1319307e git log 2aa80df14528..dc0f1319307e --date=short --first-parent --format='%ad %ae %s' 2020-03-18 amaiorano@google.com Subzero: fix partially initialized ManagedStatic assert Created with: gclient setdep -r src/third_party/swiftshader@dc0f1319307e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:151653536 Tbr: swiftshader-team+autoroll@google.com Change-Id: I8b8ce125ca885c253c4e612d4ae3b63a6f46db99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108105Reviewed-by:
-
Dan H authored
This reverts commit 57098dce. Reason for revert: Causing test failures: https://bugs.chromium.org/p/chromium/issues/detail?id=1062658 Original change's description: > Better coordinate swipe to home gesture and drag handle nudge > > Manages the drag handle nudge during window drag from shelf to home or > overview (which may end up in a gesture the nudge is describing). > > If the contextual nudge is shown when the window drag starts, the nudge > will not be hidden until the gesture completes (end it will get hidden > when the gesture completes, even if the user does not end up going > home). > > If the contextual nudge is scheduled to be shown when the gesture > starts, the show request will be canceled. > > Adds logic that prevents drag handle nudge from showing up, unless it's > a result of an explicit user action - tapping the drag handle. > > BUG=1058617 > > Change-Id: I96fa2748308143ec42295dbfb472dc564da5bd03 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107135 > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751200} TBR=tbarzic@chromium.org,manucornet@chromium.org,yulunwu@chromium.org Change-Id: I361894e79bf7bb027f690f5a6310874341d51ecf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1058617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108525Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#751360}
-
Justin Miron authored
Current Popup_Page UKM is recorded when the web contents is destroyed, this can lead to recording pop-up settings for source ids different than the pop-up's opener source id. This changelist also adds browsertests for logging of the UKM and makes the ukm for Popup_Page singular as it should be. BUG=1044601 Change-Id: I241a520b61bda691ce61ab4fdbac875f3397ac08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087975 Commit-Queue: Justin Miron <justinmiron@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#751359}
-
Ian Kilpatrick authored
This patch changes ComputeIntrinsicLogicalWidths in two ways: 1) Makes it return by value from changing the type from/to: void ComputeIntrinsicLogicalWidths(LayoutUnit&, LayoutUnit&); MinMaxSizes ComputeIntrinsicLogicalWidths(); 2) Makes ComputeIntrinsicLogicalWidths return the border-box sizes instead of the content-box size. Bug: 845235 Change-Id: If2c2da92fdf7d1173548504dc4785afeb1a2dada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088219 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: -
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/64472dfcc5d1..d390847cf65f Created with: gclient setdep -r src-internal@d390847cf65f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:1024588,chromium:1045456,chromium:1055606,chromium:1058597,chromium:1062473 Tbr: jbudorick@google.com Change-Id: I29cd9a786d7a356beb5aef33ee17d05233bf5951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108104Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751357}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/33e164438ff9..8561f1e80744 git log 33e164438ff9..8561f1e80744 --date=short --first-parent --format='%ad %ae %s' 2020-03-18 lalitm@google.com tp: ingest args from json events Created with: gclient setdep -r src/third_party/perfetto@8561f1e80744 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:132559404 Tbr: perfetto-bugs@google.com Change-Id: I6559dcd5bae7f28737a1aade2463f8b079d4c484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108102Reviewed-by:
-
Francois Beaufort authored
On KitKat, vector drawables are not supported in chromium permissions prompt. This CL fixes this issue by replacing the unique vector drawable for NFC infobar icon to multiples images. Bug: 1061916 Change-Id: Id96e7e1b496f2849b7d3bfdbb1e81db78e9c793f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106164Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#751355}
-
Patrick Monette authored
Change-Id: Ibf60d1dc438745f10853f5a02e0a92778768b91b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106323Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#751354}
-
Omer Katz authored
Tracing to capacity means we don't need to check size_ during tracing anymore. Bug: 986235 Change-Id: Idae046fcbb6a1705c1522d56479d560091415ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107983Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#751353}
-
