GitLab

BUG=623344
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2816713003
Cr-Commit-Position: refs/heads/master@{#476387}

BUG=552633

Review-Url: https://codereview.chromium.org/2916943002
Cr-Commit-Position: refs/heads/master@{#476386}

This reverts commit 3678003e, and also
add a feature flag for Request Mobile Site.

Bug: 727738
Change-Id: Id669e83b548fac668575d5460b6c6f850375fb29
Reviewed-on: https://chromium-review.googlesource.com/519444
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476385}

Backport patch released in v1.1.5
https://git.xiph.org/?p=opus.git;a=commitdiff;h=8d02afe05b80097f5a09361bb75e2950cb3ea6e2

BUG=728233

Review-Url: https://codereview.chromium.org/2918573003
Cr-Commit-Position: refs/heads/master@{#476384}

The window.view width and height attributes exclude any non-overlay
scrollbars. This means that if a scrollbar appears or disappears they'll
change values. According to the spec (and intuition) this should fire a
resize event but it doesn't.

This patch adds the resize event whenever the main frame loses or gains
a non-overlay scrollbar.

Bug: 728658
Change-Id: I32359342e795a1390cbedc95330260f03e0e2066
Reviewed-on: https://chromium-review.googlesource.com/521362Reviewed-by: David Tapuska <dtapuska@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476383}

Tether MessageTransferOperation: Only wait for a response from a host for a certain amount of time before timing out.

BUG=672263

Review-Url: https://codereview.chromium.org/2915713002
Cr-Commit-Position: refs/heads/master@{#476382}

This CL fixes these issues in the host list UX:
1. Fixes the mysterious shadow occasionally showed between host cards.
2. Fixes the constraint of the label's width.
3. Use anchor constraints to minimize position calculations and use leading &
   trailing anchors to better support RTL languages.

BUG=728280

Review-Url: https://codereview.chromium.org/2916003002
Cr-Commit-Position: refs/heads/master@{#476381}

Before, 'Refreshing' shows on long click 'Stop refreshing' menu item.
Now added tooltip 'Stop refreshing' on the menu item.

BUG=725140

Review-Url: https://codereview.chromium.org/2921463002
Cr-Commit-Position: refs/heads/master@{#476380}

This is prep for turning on AppNap as a variation of the
MacAllowBackgroundingProcesses experiment.

BUG=460102

Review-Url: https://codereview.chromium.org/2913883002
Cr-Commit-Position: refs/heads/master@{#476379}

BUG=728713

Review-Url: https://codereview.chromium.org/2915133002
Cr-Commit-Position: refs/heads/master@{#476378}

Passed on Chrome and Safari.

BUG=652439

Review-Url: https://codereview.chromium.org/2919603002
Cr-Commit-Position: refs/heads/master@{#476377}

This CL adds badge icon to WebApkInfo to allow WebAPKs to update badge
icons. Follow-up CLs will propagate this CL to other WebAPK update
components. Eventually shell APK's AndroidManifest.xml would be updated
with the new meta-data introduced by this CL.

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/1ebMBNhqRew/_6hAQKAfBwAJ

BUG=715158

Review-Url: https://codereview.chromium.org/2912403002
Cr-Commit-Position: refs/heads/master@{#476376}

While dragging, the cursor was locked, so CursorClient::SetCursor calls
were collapsed into a single call at the end of the drag. When crossing
displays with different densities, the cursor scale was incorrect until
the window was dropped. This CL removes cursor locking to prevent the
OnCursorDisplayChanged update from being postponed.

BUG=631136
BUG=642894
TEST=caroline: Cursor scale is correct while dragging across displays.

Review-Url: https://codereview.chromium.org/2812663002
Cr-Commit-Position: refs/heads/master@{#476375}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=scottbyer@chromium.org

Review-Url: https://codereview.chromium.org/2914573002
Cr-Commit-Position: refs/heads/master@{#476374}

This CL adds click listeners to account rows in Chrome settings on Android.
Tapping the row opens Android settings for the corresponding account.

BUG=722907

Review-Url: https://codereview.chromium.org/2912933003
Cr-Commit-Position: refs/heads/master@{#476373}

This adds V4LocalDatabaseManager::CheckCsdWhitelistUrl() and tests for
it. A later CL will switch the three callers of MatchCsdWhitelistUrl()
to this new function, and remove the Match method.

BUG=714300

Review-Url: https://codereview.chromium.org/2890293004
Cr-Commit-Position: refs/heads/master@{#476372}

It's possible for the PaymentRequest to be aborted before the show. For
example if CanMakePayment returns false, the merchant can close the
Payment Request.

Bug: 728641
Change-Id: Ie1c770a1f8fdceb6012f6eccf8dad6b286794382
Reviewed-on: https://chromium-review.googlesource.com/521742
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476371}

This adds a function that checks whether or not the process is currently
sandboxed. It uses the underlying sandbox_check() functionality,
which is not yet further exposed.

BUG=689306

Review-Url: https://codereview.chromium.org/2914693002
Cr-Commit-Position: refs/heads/master@{#476370}

I introduced an error in this OWNERS file in https://chromium.googlesource.com/chromium/src/+/6c146620037bf6c1222d5a0255be9a6ef2ce5137

Owners presubmit checks for files in components/resources are failing with an error like:

  File "/usr/local/google/home/skym/chromium/depot_tools/owners.py", line 357, in _add_entry
    ('%s does not refer to an existing file.' % directive[5:]))
owners.SyntaxErrorInOwnersFile: /usr/local/google/home/skym/chromium/linux/src/components/resources/OWNERS:24 syntax error: components/sync/OWNERS does not refer to an existing file.

TBR=jochen
NOPRESUBMIT=true
BUG=

Review-Url: https://codereview.chromium.org/2913993003
Cr-Commit-Position: refs/heads/master@{#476369}

Add Content Suggestion Push feature flag

BUG=728083

Review-Url: https://codereview.chromium.org/2898153004
Cr-Commit-Position: refs/heads/master@{#476368}

This has been on by default for quite a few releases.
It's time to remove the switches.

BUG=426656,625289

Change-Id: I25bf2f3ec3d23cf51df6aeb5a1966a168b8617ad
Reviewed-on: https://chromium-review.googlesource.com/519564Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476367}

Review-Url: https://codereview.chromium.org/2920613003
Cr-Commit-Position: refs/heads/master@{#476366}

BUG=546208

Review-Url: https://codereview.chromium.org/2824523002
Cr-Commit-Position: refs/heads/master@{#476365}

After the recent cleanup of crrev.com/2907563002, the flag
ENABLE_MEMORY_TASK_PROFILER became redundant and now is just
matching 1:1 USE_ALLOCATOR_SHIM. Use that instead.
No intended behavior change.
Also fix mistake of using defined(X) instead
of BUILDFLAG(X).

BUG=550886

Change-Id: I03a840b22861182208f1297a0c3f1152fd985c32
Reviewed-on: https://chromium-review.googlesource.com/520768
Commit-Queue: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476364}

TBR=sdefresne@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2914253002
Cr-Commit-Position: refs/heads/master@{#476363}

Speculative fix for timeouts on linux_android_rel_ng in the
FrameTreeBrowserTest.FrameTreeAfterCrash test.

BUG=727725
TEST=Less flakiness
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2919483003
Cr-Commit-Position: refs/heads/master@{#476362}

This class was part of the "Shiny Modern" Views UI look, but ended
up unused.

BUG=None

Review-Url: https://codereview.chromium.org/2920463002
Cr-Commit-Position: refs/heads/master@{#476361}

- HorizontalPainter
- Painter::CreateVerticalGradient

Bug: none
Change-Id: I4070406a1dc1c557bea2a73faaf8255e2ac45e84
Reviewed-on: https://chromium-review.googlesource.com/518382
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476360}

This metric tracks how many third-party modules could potentially be
matched to an entry in the Apps & Features settings page.

BUG=717696

Review-Url: https://codereview.chromium.org/2854983002
Cr-Commit-Position: refs/heads/master@{#476359}

This CL uses Polymer variable binding to swap out i18n strings rather
than using i18n-content.

BUG=692763
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2886843005
Cr-Commit-Position: refs/heads/master@{#476358}

Missed one in https://codereview.chromium.org/2491613004/ (CQ didn't catch it?)

Caught by findit @ https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRlODQ0YmI1ZjY4NmRiZDNhMDYyYzZhYWY4M2M4YTFkZjE3MWEwOGEM

BUG=587199, 552633
TBR=danakj
NOTRY=True

Review-Url: https://codereview.chromium.org/2921463003
Cr-Commit-Position: refs/heads/master@{#476357}

This CL changes the old i18n-content/i18n-values to the new (faster)
$i18n{}. There should be no functionality changes apparent to the
user.

BUG=692763

Review-Url: https://codereview.chromium.org/2918743002
Cr-Commit-Position: refs/heads/master@{#476356}

Currently the selection action mode is triggered by selection events
(SELECTION_HANDLES_SHOWN). The goal of this CL is to make the mode be triggered
by context menu events. This is beneficial for two reasons:

1) The paste popup menu is already being triggered by context menu events and
we'd like to eventually unify the selection and paste menus.

2) Currently the selection action mode uses state from the IME which can lead to
race conditions causing the menu to show stale information. Using context menu
events fixes this problem because we can pass all relevant state through
|ContextMenuParams|.

In Blink we make range touch selections trigger contextmenu events. This means
that a long-press or double tap that results in a range selection sends a context
menu event. Because of Android O's smart select we also need to know if the
context menu was triggered by moving touch handles or select all so we plumb that
information through to ContextMenuParams.

BUG=627234

Review-Url: https://codereview.chromium.org/2785853002
Cr-Commit-Position: refs/heads/master@{#476355}

Removes curr_bfc_offset_, curr_child_margins_, curr_margin_strut_ in
favour of stack variables.

This clears up the information flow between children, and makes it clear
*which* margin strut, etc is being used for a particular child's
positioning. (E.g. the OOFPositioned child's positioning was difficult
to determine before).

This introduces one regression which I'll investigate separately (static
position is weird with abs-pos legacy children now) - so I've removed the
LayoutNG CQ bot.

BUG=635619

Review-Url: https://codereview.chromium.org/2899413002
Cr-Commit-Position: refs/heads/master@{#476354}

This CL fixes crashes in extended desktop mode caused by incorrect
parenting of the cursor surface, as well as cases where the cursor
was captured with an incorrect transform or hotspot:

  1) The mouse enters a display with a different DSF or UI scale.
  2) The internal display is not the primary display.
  3) The display is rotated.

It also adds a TODO for an accessibility regression.

BUG=631136
BUG=642894
TEST=caroline: Cursor parenting and scaling is correct for each display.
TEST=caroline: Cursor on rotated displays has correct orientation.

Review-Url: https://codereview.chromium.org/2780623002
Cr-Commit-Position: refs/heads/master@{#476353}

This patch moves offline page scheduling for pre-M OSs to
background_task_scheduler component and removes a lot of code
in the process:
* switches offline page handling in ChromeBackgroundService to
  reschedule
* removes ChromeBackgroundserviceWaiter
* removes subclasses of BackgroundScheduler (responsible for
  scheduling on different OS versions)
* Moves useful code from BackgroundOfflinerTask to
  OfflineBackgroundTask
* Simplifies BackgroundSchedulerProcessor (and removes
  namespace for interfaces)
* Updates the tests for classes mentioned above.

BUG=699261

Review-Url: https://codereview.chromium.org/2830843002
Cr-Commit-Position: refs/heads/master@{#476352}

For moving GpuMemoryBuffer resource allocations to worker context, we
need to create image ids on the worker context but destroy them on the
compositor context. Image ids are already unique across contexts on the
client but the service was tracking image ids per decoder. This CL makes
image tracking work across all contexts in a channel by moving image
manager to the gpu channel.

Bug: 514819
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I27f05ba24421fefb8b6e4e7636a3fb9a6f605ef1
Reviewed-on: https://chromium-review.googlesource.com/518548Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476351}

This CL enables Image Capture browser test in Mac and Android; this test
needs a real-ish camera, so it's only part of the webrtc infra, which is
run explicitly in "large bots" [1].

Also git cl format restyled the code a bit.

[1] https://build.chromium.org/p/chromium.webrtc/waterfall


Bug: 656810
Change-Id: Iadc2fa1b4b5b56c3e06288b73e452a40e15b3426
Reviewed-on: https://chromium-review.googlesource.com/521263Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476350}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/861d4a174136..c294424b587e

$ git log 861d4a174..c294424b5 --date=short --no-merges --format='%ad %ae %s'
2017-06-01 perezju [systrace] Use large_output=True when collecting atrace data

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Id9541437d4ef441e5ab4c5f5c58eb677dc134623
Reviewed-on: https://chromium-review.googlesource.com/521422
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476349}

Adds a standalone APK that, when run, simulates a Daydream View NFC tag
scan. This is so that Telemetry can enter the VR browser without making
any modifications to Chrome, e.g. a flag.

Bug: 726906
Change-Id: I37a430c98b08dc41363fdc02b3486193b9e26fa6
Reviewed-on: https://chromium-review.googlesource.com/517682Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476348}