GitLab

https://bugs.webkit.org/show_bug.cgi?id=58867
Part of <rdar://problem/8931717>

Reviewed by Steve Falkenburg.

* UIProcess/API/C/WKContext.cpp:
(WKContextDownloadURLRequest):
Return the result of calling WebContext::download().

* UIProcess/API/C/WKContext.h:
Updated return type of WKContextDownloadURLRequest().

* UIProcess/WebContext.cpp:
(WebKit::WebContext::download):
Return the DownloadProxy returned by createDownloadProxy().
(WebKit::WebContext::createDownloadProxy):
Return the DownloadProxy.

* UIProcess/WebContext.h:
Changed return type of download() and createDownloadProxy().

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
Call the DownloadProxy's downloadID() function to get the ID.

git-svn-id: svn://svn.chromium.org/blink/trunk@84229 bbb929c8-8fbe-4397-9dbb-9b2b20218538

LEFilter change doesn't compile on ARM neon targets
https://bugs.webkit.org/show_bug.cgi?id=58671

Thanks for Charlie Lee to fixing this.

* WebCore.gypi:



git-svn-id: svn://svn.chromium.org/blink/trunk@84228 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed, added new baselines for the GTK port.

        Added missing baselines to GTK after revisions 83998, 84092 and 84180.

        * platform/gtk/fast/blockflow/border-styles-vertical-lr-expected.checksum: Added.
        * platform/gtk/fast/blockflow/border-styles-vertical-lr-expected.png: Added.
        * platform/gtk/fast/blockflow/border-styles-vertical-lr-expected.txt: Added.
        * platform/gtk/fast/blockflow/border-styles-vertical-rl-expected.checksum: Added.
        * platform/gtk/fast/blockflow/border-styles-vertical-rl-expected.png: Added.
        * platform/gtk/fast/blockflow/border-styles-vertical-rl-expected.txt: Added.
        * platform/gtk/fast/borders/border-styles-split-expected.checksum: Added.
        * platform/gtk/fast/borders/border-styles-split-expected.png: Added.
        * platform/gtk/fast/borders/border-styles-split-expected.txt: Added.
        * platform/gtk/fast/borders/mixed-border-styles-expected.checksum: Added.
        * platform/gtk/fast/borders/mixed-border-styles-expected.png: Added.
        * platform/gtk/fast/borders/mixed-border-styles-expected.txt: Added.
        * platform/gtk/fast/borders/mixed-border-styles-radius-expected.checksum: Added.
        * platform/gtk/fast/borders/mixed-border-styles-radius-expected.png: Added.
        * platform/gtk/fast/borders/mixed-border-styles-radius-expected.txt: Added.
        * platform/gtk/fast/borders/mixed-border-styles-radius2-expected.checksum: Added.
        * platform/gtk/fast/borders/mixed-border-styles-radius2-expected.png: Added.
        * platform/gtk/fast/borders/mixed-border-styles-radius2-expected.txt: Added.
        * platform/gtk/fast/borders/webkit-border-radius-expected.checksum: Added.
        * platform/gtk/fast/borders/webkit-border-radius-expected.png: Added.
        * platform/gtk/fast/borders/webkit-border-radius-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@84227 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Attempt to fix the Qt Linux Release Minimal build after changeset 84225
        <http://trac.webkit.org/changeset/84225> (https://bugs.webkit.org/show_bug.cgi?id=52788).

        * dom/EventDispatcher.cpp:
        (WebCore::EventDispatcher::ensureEventAncestors): Add ENABLE(SVG) guards around call
        to Node::svgShadowHost() since this method is only defined when building with SVG enabled.


git-svn-id: svn://svn.chromium.org/blink/trunk@84226 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dimitri Glazkov.

        Makes SVG shadow roots and DOM shadow roots distinct.
        https://bugs.webkit.org/show_bug.cgi?id=52788

        Not a functional change. Covered by existing SVG tests.

        * dom/EventDispatcher.cpp:
        (WebCore::findElementInstance):
        (WebCore::EventDispatcher::adjustToShadowBoundaries):
        (WebCore::EventDispatcher::adjustRelatedTarget):
        (WebCore::EventDispatcher::ensureEventAncestors):
        * dom/Node.cpp:
        (WebCore::Node::setShadowHost):
        (WebCore::Node::svgShadowHost):
        (WebCore::Node::shadowTreeRootNode):
        * dom/Node.h:
        (WebCore::Node::isSVGShadowRoot):
        (WebCore::Node::parentNode):
        (WebCore::Node::parentNodeGuaranteedHostFree):
        * rendering/svg/RenderSVGShadowTreeRootContainer.cpp:
        (WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootContainer):
        (WebCore::RenderSVGShadowTreeRootContainer::updateFromElement):
        * rendering/svg/SVGShadowTreeElements.cpp:
        (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement):
        (WebCore::SVGShadowTreeRootElement::create):
        (WebCore::SVGShadowTreeRootElement::attachElement):
        (WebCore::SVGShadowTreeRootElement::clearSVGShadowHost):
        * rendering/svg/SVGShadowTreeElements.h:
        (WebCore::SVGShadowTreeRootElement::isSVGShadowRoot):
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::title):

git-svn-id: svn://svn.chromium.org/blink/trunk@84225 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Fisher.

        Vendor-prefix requestFileSystem in FileSystem API
        https://bugs.webkit.org/show_bug.cgi?id=58517

        Prefix from:
        - window.requestFileSystem to window.webkitRequestFileSystem
        - window.resolveLocalFileSystemURL to window.webkitResolveLocalFileSystemURL
        - window.Flags to window.WebKitFlags
        - WorkerContext.requestFileSystem to WorkerContext.webkitRequestFileSystem
        - WorkerContext.resolveLocalFileSystemURL to WorkerContext.webkitResolveLocalFileSystemURL
        - WorkerContext.Flags to WorkerContext.WebKitFlags

        * fast/dom/script-tests/prototype-inheritance.js:
        * fast/filesystem/flags-passing-expected.txt:
        * fast/filesystem/resources/async-operations.js:
        * fast/filesystem/resources/directory-entry-to-uri.js:
        * fast/filesystem/resources/file-entry-to-uri-sync.js:
        * fast/filesystem/resources/file-entry-to-uri.js:
        * fast/filesystem/resources/file-from-file-entry-sync.js:
        * fast/filesystem/resources/file-from-file-entry.js:
        * fast/filesystem/resources/file-writer-sync-truncate-extend.js:
        * fast/filesystem/resources/file-writer-sync-write-overlapped.js:
        * fast/filesystem/resources/file-writer-utils.js:
        * fast/filesystem/resources/fs-worker-common.js:
        * fast/filesystem/resources/op-tests-helper.js:
        * fast/filesystem/resources/simple-persistent-sync.js:
        * fast/filesystem/resources/simple-persistent.js:
        * fast/filesystem/resources/simple-temporary-sync.js:
        * fast/filesystem/resources/simple-temporary.js:
        * fast/filesystem/resources/sync-operations.js:
        * fast/filesystem/script-tests/filesystem-reference.js:
        * fast/filesystem/script-tests/flags-passing.js:
        * fast/filesystem/script-tests/read-directory.js:
        * http/tests/filesystem/resolve-uri-expected.txt:
        * http/tests/filesystem/script-tests/resolve-uri.js:
        * http/tests/filesystem/workers/resolve-url-expected.txt:
        * http/tests/filesystem/workers/script-tests/resolve-url-sync.js:
        * platform/chromium/fast/dom/prototype-inheritance-expected.txt:
2011-04-18  Taiju TSUIKI  <develop@tzik.jp>

        Reviewed by Darin Fisher.

        Vendor-prefix requestFileSystem in FileSystem API
        https://bugs.webkit.org/show_bug.cgi?id=58517

        Prefix from:
        - window.requestFileSystem to window.webkitRequestFileSystem
        - window.resolveLocalFileSystemURL to window.webkitResolveLocalFileSystemURL
        - window.Flags to window.WebKitFlags
        - WorkerContext.requestFileSystem to WorkerContext.webkitRequestFileSystem
        - WorkerContext.resolveLocalFileSystemURL to WorkerContext.webkitResolveLocalFileSystemURL
        - WorkerContext.Flags to WorkerContext.WebKitFlags

        * CMakeLists.txt:
        * CodeGenerators.pri:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDirectoryEntryCustom.cpp:
        (WebCore::JSDirectoryEntry::getFile):
        (WebCore::JSDirectoryEntry::getDirectory):
        * bindings/js/JSDirectoryEntrySyncCustom.cpp:
        (WebCore::getFlags):
        (WebCore::JSDirectoryEntrySync::getFile):
        (WebCore::JSDirectoryEntrySync::getDirectory):
        * bindings/v8/custom/V8DirectoryEntryCustom.cpp:
        (WebCore::V8DirectoryEntry::getDirectoryCallback):
        (WebCore::V8DirectoryEntry::getFileCallback):
        * bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:
        (WebCore::getFlags):
        (WebCore::V8DirectoryEntrySync::getDirectoryCallback):
        (WebCore::V8DirectoryEntrySync::getFileCallback):
        * fileapi/DOMFileSystemBase.cpp:
        (WebCore::DOMFileSystemBase::getFile):
        (WebCore::DOMFileSystemBase::getDirectory):
        * fileapi/DOMFileSystemBase.h:
        * fileapi/DirectoryEntry.cpp:
        (WebCore::DirectoryEntry::getFile):
        (WebCore::DirectoryEntry::getDirectory):
        * fileapi/DirectoryEntry.h:
        * fileapi/DirectoryEntry.idl:
        * fileapi/DirectoryEntrySync.cpp:
        (WebCore::DirectoryEntrySync::getFile):
        (WebCore::DirectoryEntrySync::getDirectory):
        * fileapi/DirectoryEntrySync.h:
        * fileapi/DirectoryEntrySync.idl:
        * fileapi/WebKitFlags.h: Renamed from Source/WebCore/fileapi/Flags.h.
        (WebCore::WebKitFlags::create):
        (WebCore::WebKitFlags::isCreate):
        (WebCore::WebKitFlags::setCreate):
        (WebCore::WebKitFlags::isExclusive):
        (WebCore::WebKitFlags::setExclusive):
        (WebCore::WebKitFlags::WebKitFlags):
        * fileapi/WebKitFlags.idl: Renamed from Source/WebCore/fileapi/Flags.idl.
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::webkitRequestFileSystem):
        (WebCore::DOMWindow::webkitResolveLocalFileSystemURL):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::webkitRequestFileSystem):
        (WebCore::WorkerContext::webkitRequestFileSystemSync):
        (WebCore::WorkerContext::webkitResolveLocalFileSystemURL):
        (WebCore::WorkerContext::webkitResolveLocalFileSystemSyncURL):
        * workers/WorkerContext.h:
        * workers/WorkerContext.idl:

git-svn-id: svn://svn.chromium.org/blink/trunk@84224 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        https://bugs.webkit.org/show_bug.cgi?id=58863

        Skip fast/events/fire-mousedown-while-pressing-mouse-button.html which is failing on
        Qt Linux for now. See bug for more details.

        This test was added in changeset 84217 <http://trac.webkit.org/changeset/84217>
        (https://bugs.webkit.org/show_bug.cgi?id=58700).

        * platform/qt/Skipped:


git-svn-id: svn://svn.chromium.org/blink/trunk@84223 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dimitri Glazkov.

        Decouple media controls usage from implementation.
        This allows each port to implement thier own controls in a different
        manner to the default webkit implementation.

        Convert media controls hooks to a client interface
        https://bugs.webkit.org/show_bug.cgi?id=58346

        No new tests as there is no functional change.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::mediaControls):
        (WebCore::HTMLMediaElement::ensureMediaControls):
        (WebCore::HTMLMediaElement::preDispatchEventHandler):
        * html/HTMLMediaElement.h:
        * html/shadow/MediaControlElements.cpp:
        (WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement):
        (WebCore::MediaControlPanelMuteButtonElement::create):
        (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
        (WebCore::MediaControlTimelineElement::create):
        (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
        (WebCore::MediaControlFullscreenButtonElement::create):
        * html/shadow/MediaControlElements.h:
        * html/shadow/MediaControlRootElement.cpp:
        (WebCore::MediaControlRootElement::MediaControlRootElement):
        (WebCore::MediaControls::create):
        * html/shadow/MediaControlRootElement.h:
        * html/shadow/MediaControls.cpp: Added.
        (WebCore::MediaControls::MediaControls):
        * html/shadow/MediaControls.h: Added.
        (WebCore::MediaControls::~MediaControls):

git-svn-id: svn://svn.chromium.org/blink/trunk@84222 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Martin Robinson.

        Update pixel results for tests that draw the selection rectangle.

        * platform/gtk/editing/selection/4402375-expected.checksum:
        * platform/gtk/editing/selection/4402375-expected.png:
        * platform/gtk/editing/selection/image-before-linebreak-expected.checksum:
        * platform/gtk/editing/selection/image-before-linebreak-expected.png:
        * platform/gtk/editing/selection/replaced-boundaries-1-expected.checksum:
        * platform/gtk/editing/selection/replaced-boundaries-1-expected.png:
        * platform/gtk/editing/selection/replaced-boundaries-2-expected.checksum:
        * platform/gtk/editing/selection/replaced-boundaries-2-expected.png:
        * platform/gtk/editing/selection/replaced-boundaries-3-expected.checksum:
        * platform/gtk/editing/selection/replaced-boundaries-3-expected.png:
        * platform/gtk/editing/selection/transformed-selection-rects-expected.checksum:
        * platform/gtk/editing/selection/transformed-selection-rects-expected.png:
        * platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.checksum:
        * platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.png:
        * platform/gtk/svg/text/selection-doubleclick-expected.checksum:
        * platform/gtk/svg/text/selection-doubleclick-expected.png:
        * platform/gtk/svg/text/selection-tripleclick-expected.checksum:
        * platform/gtk/svg/text/selection-tripleclick-expected.png:
        * platform/gtk/svg/text/text-align-01-b-expected.checksum:
        * platform/gtk/svg/text/text-align-01-b-expected.png:
        * platform/gtk/svg/text/text-align-02-b-expected.checksum:
        * platform/gtk/svg/text/text-align-02-b-expected.png:
        * platform/gtk/svg/text/text-align-03-b-expected.checksum:
        * platform/gtk/svg/text/text-align-03-b-expected.png:
        * platform/gtk/svg/text/text-align-04-b-expected.checksum:
        * platform/gtk/svg/text/text-align-04-b-expected.png:
        * platform/gtk/svg/text/text-align-05-b-expected.checksum:
        * platform/gtk/svg/text/text-align-05-b-expected.png:
        * platform/gtk/svg/text/text-align-06-b-expected.checksum:
        * platform/gtk/svg/text/text-align-06-b-expected.png:
        * platform/gtk/svg/text/text-altglyph-01-b-expected.checksum:
        * platform/gtk/svg/text/text-altglyph-01-b-expected.png:
        * platform/gtk/svg/text/text-deco-01-b-expected.checksum:
        * platform/gtk/svg/text/text-deco-01-b-expected.png:
        * platform/gtk/svg/text/text-fonts-01-t-expected.checksum:
        * platform/gtk/svg/text/text-fonts-01-t-expected.png:
        * platform/gtk/svg/text/text-fonts-02-t-expected.checksum:
        * platform/gtk/svg/text/text-fonts-02-t-expected.png:
        * platform/gtk/svg/text/text-intro-05-t-expected.checksum:
        * platform/gtk/svg/text/text-intro-05-t-expected.png:
        * platform/gtk/svg/text/text-path-01-b-expected.checksum:
        * platform/gtk/svg/text/text-path-01-b-expected.png:
        * platform/gtk/svg/text/text-spacing-01-b-expected.checksum:
        * platform/gtk/svg/text/text-spacing-01-b-expected.png:
        * platform/gtk/svg/text/text-text-01-b-expected.checksum:
        * platform/gtk/svg/text/text-text-01-b-expected.png:
        * platform/gtk/svg/text/text-text-03-b-expected.checksum:
        * platform/gtk/svg/text/text-text-03-b-expected.png:
        * platform/gtk/svg/text/text-text-04-t-expected.checksum:
        * platform/gtk/svg/text/text-text-04-t-expected.png:
        * platform/gtk/svg/text/text-text-05-t-expected.checksum:
        * platform/gtk/svg/text/text-text-05-t-expected.png:
        * platform/gtk/svg/text/text-text-06-t-expected.checksum:
        * platform/gtk/svg/text/text-text-06-t-expected.png:
        * platform/gtk/svg/text/text-text-07-t-expected.checksum:
        * platform/gtk/svg/text/text-text-07-t-expected.png:
        * platform/gtk/svg/text/text-text-08-b-expected.checksum:
        * platform/gtk/svg/text/text-text-08-b-expected.png:
        * platform/gtk/svg/text/text-tref-01-b-expected.checksum:
        * platform/gtk/svg/text/text-tref-01-b-expected.png:
        * platform/gtk/svg/text/text-tselect-01-b-expected.checksum:
        * platform/gtk/svg/text/text-tselect-01-b-expected.png:
        * platform/gtk/svg/text/text-tselect-02-f-expected.checksum:
        * platform/gtk/svg/text/text-tselect-02-f-expected.png:
        * platform/gtk/svg/text/text-tspan-01-b-expected.checksum:
        * platform/gtk/svg/text/text-tspan-01-b-expected.png:
        * platform/gtk/svg/text/text-ws-01-t-expected.checksum:
        * platform/gtk/svg/text/text-ws-01-t-expected.png:
        * platform/gtk/svg/text/text-ws-02-t-expected.checksum:
        * platform/gtk/svg/text/text-ws-02-t-expected.png:
        * platform/gtk/svg/text/textPathBoundsBug-expected.checksum:
        * platform/gtk/svg/text/textPathBoundsBug-expected.png:
2011-04-18  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Martin Robinson.

        [GTK] Need support for dumping focus rectangles in pixel results
        https://bugs.webkit.org/show_bug.cgi?id=53647

        Add a support function that returns the rectangle of the current
        selection in frame.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::rectangleForSelection):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-04-18  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Martin Robinson.

        [GTK] Need support for dumping focus rectangles in pixel results
        https://bugs.webkit.org/show_bug.cgi?id=53647

        Dump the selection rect if it has been requested.

        * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
        (createBitmapContextFromWebView):

git-svn-id: svn://svn.chromium.org/blink/trunk@84221 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Mark Rowe.

        WebKit needs to stop importing <AppKit/NSTextChecker.h>
        https://bugs.webkit.org/show_bug.cgi?id=58798
        <rdar://problem/9294938>

        Use public header <AppKit/NSSpellChecker.h> instead.

        * WebCoreSupport/CorrectionPanel.h:
        * WebCoreSupport/CorrectionPanel.mm:
        (correctionIndicatorType):
        (CorrectionPanel::show):
        (CorrectionPanel::dismissInternal):
        (CorrectionPanel::handleAcceptedReplacement):
        * WebCoreSupport/WebEditorClient.mm:
        * WebView/WebView.mm:
2011-04-18  Jia Pu  <jpu@apple.com>

        Reviewed by Mark Rowe.

        WebKit needs to stop importing <AppKit/NSTextChecker.h>
        https://bugs.webkit.org/show_bug.cgi?id=58798
        <rdar://problem/9294938>

        Use public header <AppKit/NSSpellChecker.h> instead.

        * UIProcess/mac/CorrectionPanel.h:
        * UIProcess/mac/CorrectionPanel.mm:
        (correctionIndicatorType):
        (WebKit::CorrectionPanel::show):
        (WebKit::CorrectionPanel::dismissInternal):
        (WebKit::CorrectionPanel::handleAcceptedReplacement):
        * UIProcess/mac/TextCheckerMac.mm:
        * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:

git-svn-id: svn://svn.chromium.org/blink/trunk@84220 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Barth.

        Add incremental decoding to WebP decoder
        https://bugs.webkit.org/show_bug.cgi?id=58851

        No new tests, as it's not possible for the layout test framework to
        force the decoders to decode incrementally.

        * platform/image-decoders/webp/WEBPImageDecoder.cpp:
        (WebCore::WEBPImageDecoder::WEBPImageDecoder):
        (WebCore::WEBPImageDecoder::decode):
        * platform/image-decoders/webp/WEBPImageDecoder.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@84219 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Kenneth Russell.

        remove tests from test_expectations.txt, as they now pass
        https://bugs.webkit.org/show_bug.cgi?id=58813

        * platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@84218 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Roben.

        With PAN_SCROLLING, mousedown events for a mouse button aren't dispatched while
        pressing-and-holding another mouse button
        https://bugs.webkit.org/show_bug.cgi?id=58700

        Fixes an issue where mousedown events weren't dispatched when pressing a mouse button A
        while pressing and holding a mouse button B, where A != B. This issue only affects builds
        that enable PAN_SCROLLING.

        On mouse press with autoscroll in progress (m_autoscrollInProgress == true) we stopped
        the autoscroll timer, invalidated the click, and swallowed the mouse press. Instead, we
        should only stop the autoscroll timer.

        Test: fast/events/fire-mousedown-while-pressing-mouse-button.html

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEvent):
2011-04-18  Daniel Bates  <dbates@rim.com>

        Reviewed by Adam Roben.

        With PAN_SCROLLING, mousedown events for a mouse button aren't dispatched while
        pressing-and-holding another mouse button
        https://bugs.webkit.org/show_bug.cgi?id=58700

        Test to ensure that a mousedown event is fired when pressing a mouse button A
        while pressing and holding a mouse button B, where A != B.

        * fast/events/fire-mousedown-while-pressing-mouse-button-expected.txt: Added.
        * fast/events/fire-mousedown-while-pressing-mouse-button.html: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@84217 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Barth.

        test-webkitpy should run the ActiveWorkItems tests
        https://bugs.webkit.org/show_bug.cgi?id=58859

        Also make the unit tests pass. :)

        * QueueStatusServer/model/activeworkitems.py:
        * QueueStatusServer/model/queue.py:
        * QueueStatusServer/model/workitems.py:

git-svn-id: svn://svn.chromium.org/blink/trunk@84216 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Maciej Stachowiak.

        With overlay scrollbars, textarea resize corner gains borders when the textarea becomes scrollable
        https://bugs.webkit.org/show_bug.cgi?id=58617
        <rdar://problem/9048012>

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintResizer): Check for overlay scrollbars first, and then if the bars were created, before displaying the borders

git-svn-id: svn://svn.chromium.org/blink/trunk@84215 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Maciej Stachowiak.

        Selected item background in list box gets rendered on top of overlay scrollbar knob (58824)
        https://bugs.webkit.org/show_bug.cgi?id=58824
        <rdar://problem/9292680>

        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::paintObject): Moving the stage of painting the scrollbars to the foreground if using overlay scrollbars

git-svn-id: svn://svn.chromium.org/blink/trunk@84214 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Kenneth Russell.

        Don't cast BitmapImageSingleFrameSkia to BitmapImage
        https://bugs.webkit.org/show_bug.cgi?id=58821

        BitmapImageSingleFrameSkia has isBitmap return true, but
        can't be cast to a BitmapImage. Instead of using BitmapImage,
        use isOpaque from SkBitmap to determine if the image has alpha.

        No new tests.

        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        (WebCore::GraphicsContext3D::getImageData):

git-svn-id: svn://svn.chromium.org/blink/trunk@84213 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gavin Barraclough.

        Remove unneeded deprecated methods from MarkStack
        https://bugs.webkit.org/show_bug.cgi?id=58853

        Remove deprecated methods

        * heap/MarkStack.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@84212 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Barth.

        queues.webkit.org should show trailing-days pass counts for queues
        https://bugs.webkit.org/show_bug.cgi?id=58812

        This lets us see if each bot is pulling its own weight or not.
        Before I wrote this patch our suspicious was that one of the
        cq bots was doing most of the work.  Turns out they're actually
        pretty even in their recent pass counts.

        * QueueStatusServer/handlers/queuestatus.py:
        * QueueStatusServer/index.yaml:
        * QueueStatusServer/templates/queuestatus.html:

git-svn-id: svn://svn.chromium.org/blink/trunk@84211 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Seidel.

        new-run-webkit-tests: obsolete old threading code, part 1
        https://bugs.webkit.org/show_bug.cgi?id=58752

        This patch removes support for the 'old-inline' and
        'old-threads' worker models, and deletes the corresponding code.
        Now that the new code is stable, this stuff is no longer
        necessary.

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: Removed.
        * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Removed.
        * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Removed.
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: svn://svn.chromium.org/blink/trunk@84210 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=42194

Skip fullscreen/full-screen-cancel.html (which uses eventSender.keyDown) in the WK2 tests.

* platform/mac-wk2/Skipped:



git-svn-id: svn://svn.chromium.org/blink/trunk@84209 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=58805

Reviewed by Steve Falkenburg.

* storage/StorageTracker.cpp:
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
When cleaning up the StorageTracker.db file, is not enough to call syncDeleteOrigin.
deleteOrigin itself must be called to update the data structures that syncDeleteOrigin
depends on and to prevent clashes between a theoretical web page editing local storage
at the same time this method is called.
(WebCore::StorageTracker::syncDeleteAllOrigins):
If it is not possible to delete the StorageTracker.db file, empty it.
(WebCore::StorageTracker::deleteOriginOnMainThread):
Wrapper for deleteOrigin.
* storage/StorageTracker.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@84208 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Seidel.

        new-run-webkit-tests: add an --additional-drt-flag option
        https://bugs.webkit.org/show_bug.cgi?id=58680

        NRWT has a bunch of command line flags that exist to pass
        custom flags to DRT, especially on chromium. It would be nice
        if there was a generic mechanism to pass through flags so we
        didn't have all the custom ones.

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: svn://svn.chromium.org/blink/trunk@84207 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Sam Weinig.

        WebKit2: WKTR should support WebKit2 full screen APIs
        https://bugs.webkit.org/show_bug.cgi?id=56318

        WKTR does not support the eventSender.keyDown() method, so use mouseDown()
        in those cases that keyDown() does not exist.

        * fullscreen/full-screen-test.js:
        (runWithKeyDown.document.addEventListener):
        (runWithKeyDown):
2011-04-05  Jer Noble  <jer.noble@apple.com>

        Reviewed by Sam Weinig.

        WebKit2: WKTR should support WebKit2 full screen APIs
        https://bugs.webkit.org/show_bug.cgi?id=56318

        Add a new WKBundlePage API for Full Screen events, and move some of the implementation
        of WebFullScreenManager into the new InjectedBundlePageFullScreenClient class, so that
        the default behavior can be overridden by a WKBundlePageFullScreenClient.

        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/FullScreen/WebFullScreenManager.cpp:
        (WebKit::WebFullScreenManager::supportsFullScreen): Moved contents into InjectedBundlePageFullScreenClient.
        (WebKit::WebFullScreenManager::enterFullScreenForElement): Ditto.
        (WebKit::WebFullScreenManager::exitFullScreenForElement): Ditto.
        * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
        (WKBundlePageSetFullScreenClient): Added.
        (WKBundlePageWillEnterFullScreenForElement): Added.
        (WKBundlePageDidEnterFullScreenForElement): Added.
        (WKBundlePageWillExitFullScreenForElement): Added.
        (WKBundlePageDidExitFullScreenForElement): Added.
        * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
        * WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp: Added.
        (WebKit::InjectedBundlePageFullScreenClient::supportsFullScreen): Added.
        (WebKit::InjectedBundlePageFullScreenClient::enterFullScreenForElement): Added.
        (WebKit::InjectedBundlePageFullScreenClient::exitFullScreenForElement): Added.
        * WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h: Added.
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::initializeInjectedBundleFullScreenClient): Added.
        * WebProcess/WebPage/WebPage.h:
        (WebKit::WebPage::injectedBundleFullScreenClient): Added.
2011-04-05  Jer Noble  <jer.noble@apple.com>

        Reviewed by Sam Weinig.

        WebKit2: WKTR should support WebKit2 full screen APIs
        https://bugs.webkit.org/show_bug.cgi?id=56318

        Respond to enterFullScreenForElement() and exitFullScreenForElement(), allowing
        WKTR to test the LayoutTest/fullscreen/ tests.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::InjectedBundlePage): Add support for WKBundlePageFullScreenClient.
        (WTR::InjectedBundlePage::supportsFullScreen): Added.
        (WTR::InjectedBundlePage::enterFullScreenForElement): Added.
        (WTR::InjectedBundlePage::exitFullScreenForElement): Added.
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::resetStateToConsistentValues): Enable the full screen preference.

git-svn-id: svn://svn.chromium.org/blink/trunk@84206 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Tony Chang.

        new-run-webkit-tests: remove chromium-specific relpath hack for --results-directory
        https://bugs.webkit.org/show_bug.cgi?id=58388

        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: svn://svn.chromium.org/blink/trunk@84205 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added back missing #include.

* bindings/js/DOMWrapperWorld.cpp:



git-svn-id: svn://svn.chromium.org/blink/trunk@84204 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=58842
<rdar://problem/8514409>
        
Reviewed by Maciej Stachowiak.

The URL string for the file contains an extra %00 at the end
that causes the network framework to fail to load the file.
        
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::getURL):



git-svn-id: svn://svn.chromium.org/blink/trunk@84203 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Re-add a null check lost in r83081
        https://bugs.webkit.org/show_bug.cgi?id=58846

        * WebProcess/WebPage/mac/WebPageMac.mm:
        (WebKit::WebPage::getSelectedRange):



git-svn-id: svn://svn.chromium.org/blink/trunk@84202 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Clean up tool-tip/status-bar confusion.
        https://bugs.webkit.org/show_bug.cgi?id=58844

        Tool-tips were incorrectly hooked up to the status bar text.
        Chrome::setStatusbarText() now correctly causes the QWKPage::statusBarMessage() signal.

        New API:
        - QWKPage::toolTipChanged(const QString& toolTip) [signal]

        QGraphicsWKView will automatically listen for this and set its own toolTip().

        * UIProcess/API/qt/ClientImpl.cpp:
        (qt_wk_setStatusText):
        * UIProcess/API/qt/ClientImpl.h:
        * UIProcess/API/qt/qgraphicswkview.cpp:
        (QGraphicsWKView::QGraphicsWKView):
        (QGraphicsWKViewPrivate::onToolTipChanged):
        * UIProcess/API/qt/qgraphicswkview.h:
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::toolTipChanged):
        (QWKPage::QWKPage):
        * UIProcess/API/qt/qwkpage.h:


git-svn-id: svn://svn.chromium.org/blink/trunk@84201 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed.

        Re-land r84112. It was rolled out in r84127 but it didn't need
        to be. Only r84111 actually broke things.

        * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: svn://svn.chromium.org/blink/trunk@84200 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Seidel.

        [chromium] expose title direction to webkit client
        https://bugs.webkit.org/show_bug.cgi?id=58823

        *  Tools/DumpRenderTree/chromium/LayoutTestController.cpp:
        *  Tools/DumpRenderTree/chromium/LayoutTestController.h:
        Adapt to new API.  Expose title direction to JS so it can be tested.

        *  Tools/DumpRenderTree/chromium/WebViewHost.cpp:
        *  Tools/DumpRenderTree/chromium/WebViewHost.h:
        Provide new API.
2011-04-18  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] expose title direction to webkit client
        https://bugs.webkit.org/show_bug.cgi?id=58823

        New test that checks the directionality of the title for some
        simple pages.

        * fast/dom/title-directionality-expected.txt: Added.
        * fast/dom/title-directionality.html: Added.
2011-04-18  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] expose title direction to webkit client
        https://bugs.webkit.org/show_bug.cgi?id=58823

        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::didReceiveTitle):
        Add new param to API.

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchDidReceiveTitle):
        Pass new param in API.
2011-04-18  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] expose title direction to webkit client
        https://bugs.webkit.org/show_bug.cgi?id=58823

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::reset):
        * DumpRenderTree/chromium/LayoutTestController.h:
        (LayoutTestController::setTitleTextDirection):
        Add member and setter to let us stash the title direction at load time.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::didReceiveTitle):
        * DumpRenderTree/chromium/WebViewHost.h:
        Adapt to new API; push the title into layoutTestController when we
        receive it.

git-svn-id: svn://svn.chromium.org/blink/trunk@84199 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Discovered and rubber-stamped by Stephanie Lewis.

        Restored some code I accidentally deleted in <http://trac.webkit.org/changeset/83990>

        * bindings/js/DOMWrapperWorld.cpp:
        (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
        (WebCore::DOMWrapperWorld::clearWrappers): Do clear / destroy all our
        window shells when clearing / destroying ourselves. r83990 removed this
        behavior for documents since there are no per-document maps anymore,
        but removing this behavior for window shells too was a typo.



git-svn-id: svn://svn.chromium.org/blink/trunk@84198 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Tony Chang.

        new-run-webkit-tests: don't run more processes than necessary
        https://bugs.webkit.org/show_bug.cgi?id=58751

        Previously NRWT would start up 1 process for each processor on
        the machine by default, which was a waste if we were only
        running a few shards of tests.

        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: svn://svn.chromium.org/blink/trunk@84197 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* QtWebKit.pro: Missing includepath added.

git-svn-id: svn://svn.chromium.org/blink/trunk@84196 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Seidel.

        include links to actual.png files for new pixel tests
        https://bugs.webkit.org/show_bug.cgi?id=58831

        Load image elements to confirm whether the files exist.
        Image elements will load without being appended to the DOM.

        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:

git-svn-id: svn://svn.chromium.org/blink/trunk@84195 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Oliver Hunt.

        Made DOM handle ownership customizable, and customized it for Nodes and NamedAttrMaps
        https://bugs.webkit.org/show_bug.cgi?id=58828

        * WebCore.exp.in: Blah.

        * bindings/js/DOMWrapperWorld.cpp: Moved code related to JSNode ownership
        to JSNodeCustom, where other custom JSNode-related code goes.

        (WebCore::JSDOMWrapperOwner::finalize):
        (WebCore::DOMWrapperWorld::DOMWrapperWorld):
        * bindings/js/DOMWrapperWorld.h:
        (WebCore::JSDOMWrapperOwner::JSDOMWrapperOwner):
        (WebCore::DOMWrapperWorld::defaultWrapperOwner): Renamed DOMObjectHandleOwner
        to JSDOMWrapperOwner, to match the name of JSDOMWrapper.

        * bindings/js/JSArrayBufferViewHelper.h:
        (WebCore::toJSArrayBufferView):
        * bindings/js/JSCSSRuleCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSCSSValueCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSCanvasRenderingContextCustom.cpp:
        (WebCore::toJS): Removed "DOMObject" and "Node" from the names of wrapper-
        related functions, since there is no meaningful distinction between the
        two anymore -- they both use the same extensible interface.
        
        * bindings/js/JSDOMBinding.cpp: Removed some now-unused functions.

        * bindings/js/JSDOMBinding.h:
        (WebCore::getInlineCachedWrapper):
        (WebCore::setInlineCachedWrapper):
        (WebCore::clearInlineCachedWrapper):
        (WebCore::wrapperOwner):
        (WebCore::wrapperContext):
        (WebCore::getCachedWrapper):
        (WebCore::cacheWrapper):
        (WebCore::uncacheWrapper):
        (WebCore::createWrapper):
        (WebCore::wrap): Created a generic, extensible mechanism for creating,
        caching, retrieving, marking, and destroying DOM wrappers. This eliminates
        the difference between DOM object wrappers and DOM node wrappers, and
        lays the groundwork for getting rid of MarkStack::deprecatedAppend usage
        for marking the remainder of our DOM objects.
        
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::history):
        (WebCore::JSDOMWindow::location):
        * bindings/js/JSDataViewCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::location):
        (WebCore::toJS):
        * bindings/js/JSElementCustom.cpp:
        (WebCore::toJSNewlyCreated):
        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSHTMLCollectionCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSImageDataCustom.cpp:
        (WebCore::toJS): Updated for renames mentioned above.

        * bindings/js/JSNamedNodeMapCustom.cpp:
        (WebCore::JSNamedNodeMapOwner::isReachableFromOpaqueRoots):
        (WebCore::JSNamedNodeMapOwner::finalize):
        (WebCore::wrapperOwner):
        (WebCore::wrapperContext):
        (WebCore::JSNamedNodeMap::markChildren):
        (WebCore::toJS): Updated to use our new interface for customizing wrapper
        lifetime management through function overloading without using
        MarkStack::deprecatedAppend.

        * bindings/js/JSNodeCustom.cpp:
        (WebCore::isObservable):
        (WebCore::isReachableFromDOM):
        (WebCore::JSNodeOwner::isReachableFromOpaqueRoots):
        (WebCore::JSNodeOwner::finalize):
        (WebCore::createWrapperInline): Moved node-related code from JSDOMBinding
        to here. Removed special case marking code for JSNamedNodeMap because
        JSNamedNodeMap now knows how to maintain its own lifetime invariants.

        * bindings/js/JSNodeCustom.h:
        (WebCore::wrapperOwner):
        (WebCore::wrapperContext):
        (WebCore::getInlineCachedWrapper):
        (WebCore::setInlineCachedWrapper):
        (WebCore::clearInlineCachedWrapper):
        (WebCore::toJS): Updated to use our new interface for customizing wrapper
        lifetime management through function overloading without using
        MarkStack::deprecatedAppend or special-case code for nodes.
        
        * bindings/js/JSSVGPathSegCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSStyleSheetCustom.cpp:
        (WebCore::toJS): Updated for renames mentioned above.

        * bindings/scripts/CodeGeneratorJS.pm: Fixed up newlines. Updated for
        renames mentioned above.

        * dom/NamedNodeMap.idl: NamedNodeMap needs a custom toJS function now
        because it needs to provide a custom WeakHandleOwner at wrapper creation time.


git-svn-id: svn://svn.chromium.org/blink/trunk@84194 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dan Bernstein.

        sandbox violation for ~/Library/Dictionaries
        https://bugs.webkit.org/show_bug.cgi?id=58841
        <rdar://problem/9294770>

        * WebProcess/com.apple.WebProcess.sb: Add to sandbox profile.
        No obvious harm from allowing this, though it's not 100% clear
        why it's needed.


git-svn-id: svn://svn.chromium.org/blink/trunk@84193 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=58747

Rubber-stamped by Sam Weinig.

Copy the WebCore Localizable.strings file into the output directory.

* WebCore.vcproj/WebCoreGenerated.vcproj:
* WebCore.vcproj/WebCoreGeneratedCairo.vsprops:
* WebCore.vcproj/WebCoreGeneratedCommon.vsprops:
* WebCore.vcproj/copyInspectorFiles.cmd: Removed.
* WebCore.vcproj/copyWebCoreResourceFiles.cmd: Copied from Source/WebCore/WebCore.vcproj/copyInspectorFiles.cmd.



git-svn-id: svn://svn.chromium.org/blink/trunk@84192 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Stop using -[NSString initWithContentsOfFile:]
https://bugs.webkit.org/show_bug.cgi?id=58763

-[NSString initWithContentsOfFile:] was deprecated in 10.4, so we should stop using it.

* WebView/WebView.mm:
(leakMailQuirksUserScriptContents):
(leakOutlookQuirksUserScriptContents):


git-svn-id: svn://svn.chromium.org/blink/trunk@84191 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Roben.

        Off by one initialising repeat callframe
        https://bugs.webkit.org/show_bug.cgi?id=58838
        <rdar://problem/8756810>

        If the end of a callframe made for a repeat call landed on
        a page boundary the following page may not have been committed
        which means that the off by one could lead to a crash.  However
        it could only happen in this case and only on windows which is
        why it was so hard to repro.  Alas given the steps needed to
        reproduce are such that it's not really possible to make a
        testcase.

        This fix makes the code a little less squirrely by not trying
        to avoid the unnecessary initialisation of |this|.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::prepareForRepeatCall):

git-svn-id: svn://svn.chromium.org/blink/trunk@84190 bbb929c8-8fbe-4397-9dbb-9b2b20218538