GitLab

Added fault test cases, unsuccessful HTTP response and
malformed response, to HintsFetcher browsertests according to
the OnePlatform test plan.

Bug: 932707
Change-Id: Ic4d62970e25c12aa8384465d7f56353f85eb9e58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592848
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656936}

To do that, split ComputeSameSite between get and set, and turn the
existing distinction in ComputeSameSite* into a scripts vs. network one.

While doing that, I noticed that the devtools interceptors weren't actually
setting same_site_context when they were handling Set-Cookie, so fixed them.

This matches proposed spec update:

https://github.com/httpwg/http-extensions/commit/49bcb4fddb8a8c294749ec9d81a236cde4df94b0

should bring us closer to Firefox, and should stop causing trouble for
OAuth implementation that use Same-Site cookies (e.g. Microsoft's --- hurray
to their auth folks for deploying it!)

Bug: 958331
Change-Id: Ied64233b6401bab629ca0a9212da520af2c166ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594115
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656935}

There is a bug that the payment sheet UI falls into an infinite spinning
loop when users re-select another item (e.g. shipping address, payer
detail info) since retry() is called.

This problem has been occured since http://crrev.com/c/1512594. In the
patch, the logic was changed so that updateWith() calls were forwarded
to the invoked payment app. The change is very reasonable and important,
but in the case of the autofilll payment app provided by the UA itself,
the change might not be appropriate. Therefore, this CL applies an
exception to the autofill payment app for the logic.

Test:
  chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestRetryTest.java

Manual Test:
  https://w3c-test.org/payment-request/payment-response/onpayerdetailchange-attribute-manual.https.html

Bug: 861704, 941837
Change-Id: Idf5ab1a45795490c7ee0e0e8e313e8f6213b0adf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589680
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656934}

This reverts commit c677e9fc.

Reason for revert: Breaks compile.
https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Builder/18954

Looks like the consts may have to be inside of the conditional block as well.

Original change's description:
> Disable SitePerProcessHitTest* on MSAN.
> 
> They're all flaking at various point on the bots.
> 
> BUG=959924
> TBR=kenrb
> 
> Change-Id: I10926519bcf2f458e30243f0e0b587ae6d99699b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597124
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#656904}

TBR=dalecurtis@chromium.org,kenrb@chromium.org

Change-Id: If496b4da68c5e453bd77172101bc4783be8605e3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 959924
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597631Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656933}

Bruno is now a committer, so let's add him to OWNERS.

Bug: None
Change-Id: I2cabe8ed980396db6dda7b68e663f0ba6da93a61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597019
Auto-Submit: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Lucas Tenório <ltenorio@chromium.org>
Commit-Queue: Bruno Santos <brunoad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656932}

This reverts commit 3f09dd4a.

Reason for revert: Introduces new tests which are failing consistently on Win7 CI bots :(

The last two builds on the Win7 bots have failed:
https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/91141
https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/91142

both in the new `delayloads_unittests` suite.

The failures are verbose, and a bit hard to parse, so I've pasted them in the bug.


Original change's description:
> Remove chrome_elf_import_unittests and add delayloads_unittests
> 
> This change is a follow-up to
> https://chromium-review.googlesource.com/c/chromium/src/+/1551709. It
> removes the chrome_elf_imports_unittests executable and combines the
> tests with the similar tests in the more generic delayloads_unittests
> executable. It also adds delayloads_unittests to the pipeline for
> execution.
> 
> Bug: 948829
> Change-Id: I892dab727817c08687eaadba2a625e4a7fe1f906
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595219
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Patrick Monette <pmonette@chromium.org>
> Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#656893}

TBR=sky@chromium.org,thakis@chromium.org,pmonette@chromium.org,cliffsmo@microsoft.com

Change-Id: Ia75cbf9b5b1924cf75bc7f84ab20416ed70a8c22
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 948829
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596323Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656931}

Enterprise reporting uploads Chrome usage reports for admin to read on
the cloud.
https://support.google.com/chrome/a/answer/9301421?hl=en&ref_topic=9301744

Today, this feature is implemented with a private extension API and an
extension that is owned by Google.

We plan to deprecate the API and extension then move the feature into
Chromium code base. Most of code will be located in
chrome/browser/enterprise_reporting/

Bug: 956237
Change-Id: I292a84eec4fd590d2c9a36cbdfdf84318ecebfdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597318Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656930}

Non-smooth charts are displayed discretely so this updates value in
tooltip to be discrete.

TEST=Locally
BUG=b:122555793

Change-Id: I67b5ef7c96c1da7b33489758f0a780860aff9671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597250Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656929}

They shouldn't be logged because there should be no animations when the
active window is snapped and we enter/exit tablet mode. This also
removes a workaround added to handle the maximized window case. This is
a follow up to [1].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1562717/8..14

Test: ash_unittests TabletModeControllerTest.TabletModeTransitionHistograms*
Bug: 948707
Change-Id: I74b89879d496f31a529e72946400c0aa2bd44319
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595547Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656928}

This is a reland of 9ac1e68e

Original change's description:
> [EventTiming] Round instead of ceil the |duration|
> 
> The purpose of this change is to expose entries whose |duration| is >=
> 100ms.
> 
> Bug: 823744
> Change-Id: Ibb089009ba287769b1365a938cc7564278a86c35
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594818
> Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#656797}

Bug: 823744
Change-Id: Ia7ceffaf7dc84951b74fff507b024a3f895039db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596849Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656927}

This patch stops keeping a copy of style for ellipsis, but to
compute from the containing block.

Because paint-only changes to the style do not re-create
fragments, keeping a copy of style fails to use the updated
styles.

This also reduces a pointer from NGPhysicalTextFragment.

Change-Id: If0ec637d51f4f7f93828ab331f1e911995d23fb4
Bug: 636993
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596791
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656926}

https://swiftshader.googlesource.com/SwiftShader.git/+log/a2457f79559a..e2535df106eb


git log a2457f79559a..e2535df106eb --date=short --no-merges --format='%ad %ae %s'
2019-05-06 capn@google.com Implement 1D array image sampling
2019-05-06 chrisforbes@google.com Wait on query being available, not !active.


Created with:
  gclient setdep -r src/third_party/swiftshader@e2535df106eb

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/129523279
TBR=swiftshader-team+autoroll@chromium.org

Change-Id: Ic503c707277b750aa9e97ca9a6092e48a4bfaf76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597328Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#656925}

Android could rename a download due to another app inserting the
same file name into the media store.
This CL will query android for the new display name when intermediate
file is renamed. And it will be used in Chrome download home later.

BUG=959469

Change-Id: I824db7733f2c9136f56eb5941b6b0a179e008bc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595122
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656924}

We have been experiencing crashes in TemplateURLService, likely due
to a use-after-free.

This CL changes the ObserverList::Unchecked to a normal ObserverList
which is CHECKed for use-after-free.

Hopefully this helps us narrow down the linked crash.

Bug: 899309
Change-Id: I63a8c6f7daa5cc5498cd65672762647fb6694147
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596181Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656923}

This CL adds the possibility to create a NavigationSimulator from a
pending navigation in a subframe. This allows to use NavigationSimulator
to simulate back navigations.

Bug: 728571
Change-Id: I0da3545e102f93de6d72d5c2d5f47a6864ca0b7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581800
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Auto-Submit: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656922}

This moves all the files into place.

BUG=958168
TEST=covered by tests

Change-Id: I1c39799c3e739b1b837a09523f7fe5b5486bcc4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594705
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656921}

https://chromium.googlesource.com/angle/angle.git/+log/c22ef61f3aeb..8ba78da0b324


git log c22ef61f3aeb..8ba78da0b324 --date=short --no-merges --format='%ad %ae %s'
2019-05-06 lsalzman@mozilla.com add support for EXT_blend_func_extended to D3D11
2019-05-06 syoussefi@chromium.org Suppress test hitting Nvidia shield driver bug
2019-05-06 jonahr@google.com Use EnumAdapters to properly detect primary GPU on Win


Created with:
  gclient setdep -r src/third_party/angle@8ba78da0b324

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jonahr@chromium.org

Change-Id: I589c3f919b59aa43045758db079a792068923aaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595663Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#656920}

From the time MimeHAndlerViewAttachHelper::AttachToOuterWebContentsFrame is
called to when the GuestView actually attempts to attach to the outer
WebContents there is an interval where the GuestView::GetEmbedderFrame() might
be destroyed and the attach helper is not notified. In such a case, the
prepared frame will also be nullptr in which case the MHVAH will try to notify
the renderer process and possibly crashes when using GetEmbedderFrame().

This CL (provisionally) fixes the issue by tracking embedder frame's lifetime.

Bug: 959572
Change-Id: I540ce2e3ab0b3de6465c5ad6138659ee5388666f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595356Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656919}

As we no longer intend to ship the window-service, this code is no longer
applicable.

BUG=958121
TEST=covered by tests

Change-Id: I07a4d603bc2f71975055ea14bee430a965c00b8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594655
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656918}

Start collecting Bluetooth adapter availability metrics on Windows,
which had been disabled because of performance problems initializing
the BT settings but that should be resolved as of r656577.

Bug: 907279
Change-Id: I8fff9f658d602d7621b92921cc382ab165368b8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596173
Auto-Submit: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656917}

For some time cryptotoken has forwarded requests to Webauthn by default.
Since this has been stable for a while now, remove the feature flag and
all the code from cryptotoken that dealt with communicating with security
keys directly.

This leaves cryptotoken as a legacy shim for Webauthn and, as such, we
no longer worry about keeping it closure-clean and just delete the
BUILD.gn.

Change-Id: Ic6578f109b2facbc89ea7bc8fc1420870fb7dc6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588752Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656916}

Change-Id: I59e271130c12fdbacac7357dcba8fdb6af542a96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594482Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656915}

They were using UnescapeURLComponent(), which leaves certain characters
that are unsafe to display to the user escaped for display, which
doesn't make sense in the context of creating a URL for internal use.

The two modified calls were of the form GURL(UnescapeURLComponent())
before, so the differences shouldn't have mattered before, anyways.

UnescapeBinaryURLComponent() unescapes all escaped characters passed
to it, including %00. GURL's constructor, however, will then re-escaped
such characters, so this CL shouldn't affect behavior - with one
exception. GURL removes terminal characters it doesn't like, so
GURL(UnescapeBinaryURLComponent("http://foo/%01")) will become
"http://foo/". GURL(UnescapeBinaryURLComponent("http://foo/%01a")),
on the other hand, will remain "http://foo/%01a". This changed behavior
seems not to matter in this context, since the "%" itself should be
escaped when passed through these APIs, anyways. If this is a problem,
though, perhaps we should re-visit GURL's behavior, or implement some
one-off solution for this particular use case.

This CL is part of a project to cleaning up uses of
UnescapeURLComponent(), as it's been used for wildly disparate
purposes, and much of its logic is only suitable for cases where
we want to format a URL for safe display to the user. We want
to make it leave more weird characters escaped, but need to
eliminate usage of it in other contexts before we can do that.

UnescapeBinaryURLComponent() unconditionally unescapes all escaped
characters, and should be used instead in most cases, particulars where
URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS is in use. The primary cases
where it shouldn't be used (without additional checks), are cases where
unescaping path separators or funky characters (like %01) is a problem.
In those places, we should generally fail, instead of partially
unescaping a URL.

Change-Id: I2b95ffd0fd42c26ffb6f84773d8e94457660a3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594822Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656914}

Bug: 864809
Change-Id: Idb14bcb91c258af165f4900647cd870e68a3eb25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595303
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656913}

Bug: none
Change-Id: I98e500892fac4f52a55034598e59f5dd44e8e7bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593866
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656912}

Test: interactive_ui_tests TabletModeTransitionTest.EnterExit
Bug: 953896
Change-Id: Ie2332df2bea2f7d2a63b39d8b390fcf4b28999f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580583
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656911}

This is protect against download Id overflow and use-after-free
issue.

BUG=958533

Change-Id: I2c183493cb09106686df9822b3987bfb95bcf720
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591485Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656910}

This change fixes a bug in which the IA2 ScrollToPoint API does not
scroll to the correct point from inside iframes. Currently when
ScrollToPoint is called on iframe elements, the element is scrolled,
but the final destination is off by the offset of the iframe in the
containing web content.

This change fixes this by using GetBoundsRect (and consequently
RelativeToAbsoluteBounds) to perform the coordinate conversion from
screen coordinates to frame coordinates.

Bug: 955686
Change-Id: I69dfb22c4ebc4a3fc820e36da6805c6185ab0d72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580080
Commit-Queue: Frank Poole <frpoole@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#656909}

See https://crbug.com/947886#c18. This test was fixed
in https://crrev.com/c/1548326

R=dgrogan@chromium.org

Bug: 947886
Change-Id: I1e4f1ae90ea14daea4af99369c77d73beaa9f1e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594062
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656908}

Once scroll prediction is turned on by default, it will become
increasingly difficult to understand the impact that prediction is
having on this metric over time. For example, if the AverageLag metric
regresses it could be due to increased latency or a reduction in
prediction effectivness.

Because of this, we'd like to log a pair of histograms for what the
effect prediction is having on the AverageLag metric.
This information is already available to the AverageLagTracker as the
scroll_delta field on the LatencyInfo. Currently this is used as the
actual position at time=t, but we know that it would have been used
as the rendered offset in the absence of prediction.

I implemented this as two histograms because count-based histograms
don't appear to support negative numbers. Perhaps I'm overlooking
another type of histogram that would be better suited for this.

Bug: 836352

Change-Id: Ief387d0fc087e53cd4137dd95d91bb331b592cc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586104
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656907}

Change-Id: I51720a07f67f69680a7bdbc0faa661378df4bbc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593919
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Auto-Submit: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656906}

This CL allows us to set the SimpleDownloadManagerCoordinator in reduced
mode. So that DownloadService can use the inprogressDownloadManager and
start new downloads while in reduced mode.

BUG=942770

Change-Id: I58d4aa0de22cb7cc0e2315668c12c4b688446d93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592706Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656905}

They're all flaking at various point on the bots.

BUG=959924
TBR=kenrb

Change-Id: I10926519bcf2f458e30243f0e0b587ae6d99699b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597124Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656904}

Logged in the PreviewUserData. UKM coming in the next CL.

Bug: 955472
Change-Id: I2ab1f5530f9ee5cfe76da269e157a3c95361ebd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596172
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656903}

This creates the TouchlessPreferences activity which adds a number
of customizations to the Preferences activity.

Bug: 953905,953903,953897,951591
Change-Id: I7b621ea53ce6b6a1e5452f845c3e832ea8f0f1b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593393
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656902}

BUG=959129
TBR=jrummell

Change-Id: I3ed524bbc5202af4c1f5291cfc49aea40970f6e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597394Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656901}

BUG=959372
TBR=jrummell

Change-Id: Ie171f5c485a054bb65cee573bea3285ed7067135
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597468Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656900}

This API is only used in AndroidWebview which gets it from the RenderView of
a RenderFrame. It makes more sense to get a WebFrameWidget from the
(local root) WebLocalFrame that owns it.

Bug: none
Change-Id: I3f62359893ec7b06dc5512045aa4e16426304dde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596830Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656899}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/982a060f..dc5354a7

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I4c30a66fb8ba08a916c145cbc642e7666758edf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596831Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#656898}

The script still works with Python 2.
There are no intended behaviour changes.

Bug: chromium:941669
Change-Id: Iff075d8214ed60b17e8cd5a1c7f56ba60187675a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596432Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656897}