Commits · f0c16348aeee3d2a8efdd3a50eed9f2f94c991fb · eriksson monteiro / tangled

03 Mar, 2020 15 commits

Roll src/third_party/freetype/src 11975fe9f6ed..6a431038c911 (1 commits) · f0c16348

chromium-autoroll authored Mar 03, 2020

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/11975fe9f6ed..6a431038c911

git log 11975fe9f6ed..6a431038c911 --date=short --first-parent --format='%ad %ae %s'
2020-03-02 moazinkhatri@gmail.com [gzip] Support `gzip' encoded header conditionally.

Created with:
gclient setdep -r src/third_party/freetype/src@6a431038c911

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
Bug: None
Tbr: bungeman@google.com,drott@google.com,thestig@google.com
Change-Id: I6a8ed93422566b44098eb445be33a2bc3437f741
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083218Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746177}

f0c16348

CRAS: make cras_audio_handler an observer of MediaController · aa9124bf

Michael Sun authored Mar 03, 2020

Register cras_audio_handler to be an observer of MediaController in
order to receive update of media session playback status. Parse such
playback status into string and call corresponding AudioClient function
to propagate the information further to DBUS.

BUG=b:147367681
TEST=chromeos_unittests

Change-Id: I122fa0d3aa5f59a5828c0075617271fcf61ede94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076061Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Michael Sun <michaelfsun@google.com>
Cr-Commit-Position: refs/heads/master@{#746176}

aa9124bf

Portals: Remove early return for predecessor not having a committed entry · ff995c3f

Kevin McNee authored Mar 03, 2020

We change this early return to a DCHECK as we are guaranteed to have a
committed navigation entry, since about:blank cannot host a portal.

Bug: 914108
Change-Id: I41f998711b6d7d2ec1163dc9ccbdb5f0edc63969
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082906
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746175}

ff995c3f

mojo: Fix map() Python 3 compatibility · 81ba7a1a

Raul Tambre authored Mar 03, 2020

map() returns a list in Python 2. Python 3 returns an iterator.
Wrapping in a list() results in the same behaviour on both.

Traceback (most recent call last):
File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 569, in <module>
sys.exit(main())
File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 564, in main
return args.func(args, remaining_args)
File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 280, in _Generate
processor._GenerateModule(
File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 225, in _GenerateModule
AddComputedData(module)
File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\generator.py", line 191, in AddComputedData
_AddInterfaceComputedData(interface)
File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\generator.py", line 152, in _AddInterfaceComputedData
method.param_struct = _GetStructFromMethod(method)
File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\generator.py", line 172, in _GetStructFromMethod
_AddStructComputedData(False, struct)
File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\generator.py", line 126, in _AddStructComputedData
struct.packed = pack.PackedStruct(struct)
File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\pack.py", line 141, in __init__
src_fields.append(PackedField(field, index, ordinal))
File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\pack.py", line 86, in __init__
self.size = self.GetSizeForKind(field.kind)
File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\pack.py", line 63, in GetSizeForKind
raise Exception("Undefined type: %s. Did you forget to import the file "
Exception: Undefined type: x:IndexId. Did you forget to import the file containing the definition?

Traceback (most recent call last):
File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 565, in <module>
sys.exit(main())
File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 560, in main
return args.func(args, remaining_args)
File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 276, in _Generate
processor._GenerateModule(
File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 245, in _GenerateModule
generator.GenerateFiles(filtered_args)
File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 491, in GenerateFiles
self.WriteWithComment(self._GenerateModuleSource(),
File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 37, in GeneratorInternal
return ApplyTemplate(args[0], path_to_template, parameters, **kwargs)
File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 31, in ApplyTemplate
return template.render(params)
File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\asyncsupport.py", line 76, in render
return original_render(self, *args, **kwargs)
File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\environment.py", line 1008, in render
return self.environment.handle_exception(exc_info, True)
File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\environment.py", line 780, in handle_exception
reraise(exc_type, exc_value, tb)
File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\_compat.py", line 37, in reraise
raise value.with_traceback(tb)
File "gen\mojo\public\tools\bindings\cpp_templates.zip\tmpl_443233f41d2b3f893c5bf0eb0f069e01da908ebe.py", line 89, in <module>
File "gen\mojo\public\tools\bindings\cpp_templates.zip\tmpl_c45f6ba3b78f1db0b9ac3d8f2287ed476074b615.py", line 15, in <module>
File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 521, in _DefaultValue
expression = self._ExpressionToText(field.default, kind=field.kind)
File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 852, in _ExpressionToText
return self._TranslateConstants(value, kind)
File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 830, in _TranslateConstants
return self._GetNameForKind(token, flatten_nested_kind=True)
File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 530, in _GetNameForKind
return _NameFormatter(kind, self.variant).FormatForCpp(
File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 73, in FormatForCpp
return self.Format(
File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 68, in Format
parts.extend(self._GetName(internal, flatten_nested_kind))
File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 94, in _GetName
name_parts.append(self._token.name)
File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\module.py", line 273, in name
return self.field.name
AttributeError: 'EnumField' object has no attribute 'name'

Bug: 941669
Change-Id: Ia19f39d4134fb063c4407eb20a4f909f693e6f27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081812
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#746174}

81ba7a1a

Use #setChecked in RadioButtonWithDescription#setCheckedWithFocusChange · 31499c74

Wenyu Fu authored Mar 03, 2020

RadioButtonWithDescription#setCheckedWithFocusChange is trying to
unchecked other radio button when this current radio button is checked.
For those flipping-to-unchecked radio buttons, we want to call
#setChecked rather than #setCheckedWithFocusChange to cooperate focus
changes.

Bug: 1048863, 1053747
Change-Id: Ia12f5a613594a283f5289c1516bc5e6dfeef2aae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081524Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746173}

31499c74

Fix crostini context menus crash issue. · d247eaf7

nancy authored Mar 03, 2020

BUG=1057570

Change-Id: Id1575ae9ff546a3f0d3ecb7353f3f4a60fd7c82e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084031Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746172}

d247eaf7

Avoid vector::insert in base::OffsetAdjuster::MergeSequentialAdjustments · 167904e8

Daniel McArdle authored Mar 03, 2020

This CL trades space for time in |MergeSequentialAdjustments|. By
allocating a new |Adjustments| vector, we can avoid calling
|std::vector::insert| in a loop, which costs roughly O(n^2) time. With
the additional vector, we only need to call |std::vector::push_back|,
costing roughly O(n) time in total.

Bug: 1017193
Change-Id: I7beb2c3c0b6a9cb7616a22f4a4355285fd281894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070605Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746171}

167904e8

back gesture contextual nudge: small UI nits. · 39798422

Xiaoqian Dai authored Mar 03, 2020

Bug: 1009005b
Change-Id: I629c8f297758366383922d33e6f646d2ce2fbad2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082023Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746170}

39798422

mojo: Don't open concatenation files as binary · a311cf92

Raul Tambre authored Mar 03, 2020

In Python 3 operations on files opened in binary mode have to be done with bytestrings.
Python 2 doesn't care, so it happens to work.
Don't open the files in binary mode, as they aren't used as such.

Traceback (most recent call last):
  File "../../mojo/public/tools/bindings/concatenate_and_replace_closure_exports.py", line 73, in <module>
    main()
  File "../../mojo/public/tools/bindings/concatenate_and_replace_closure_exports.py", line 70, in main
    exit(0 if ConcatenateAndReplaceExports(args) else 1)
  File "../../mojo/public/tools/bindings/concatenate_and_replace_closure_exports.py", line 58, in ConcatenateAndReplaceExports
    FilterLine(filename, line, target)
  File "../../mojo/public/tools/bindings/concatenate_and_replace_closure_exports.py", line 30, in FilterLine
    if line.startswith("goog.require"):
TypeError: startswith first arg must be bytes or a tuple of bytes, not str

Bug: 941669
Change-Id: Ic373069e87707eb28ca1b3bf60556f066c19c5d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081413
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#746169}

a311cf92

Fix crash in ExtensionPopup::DevToolsAgentHostDetached upon extension unload · c67836e9

Andrey Kosyakov authored Mar 03, 2020

ExtensionPopup::OnExtensionUnloaded() deletes the ExtensionHost,
we destroy the WebContents, this leads to detaching of DevTools
sessions which will be reported to
ExtensionPopup::DevToolsAgentHostDetached where we access host.
Oops.

Bug: 1052057
Change-Id: I34e03582beb61c0308ad35bc973dc5cd4e26a5b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066506
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746168}

c67836e9

Fix right click handling from left click initiated system menu · 34b06d0e

David Bienvenu authored Mar 03, 2020

If you open app window (e.g., chrome://apps,
right click on Youtube, check "open in window", and open it),
then left click just to the right of "Youtube" in the title bar of the app
window, and then right click, a second context menu gets opened.

This CL makes HwndMessageHandler ignore the right click when displaying
a system menu opened with left click.

Bug: 1053460
Change-Id: I0c32cf30995ce6e970c93d40a2e20b7b2f63d3a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071253Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746167}

34b06d0e

Revert "Remove ScriptContext::ScopedFrameDocumentLoader" · b0e76bc7

Dmitry Gozman authored Mar 03, 2020

This reverts commit 2e28f009.

Reason for revert: suspecting to cause crashes, http://crbug.com/1052107

Original change's description:
> Remove ScriptContext::ScopedFrameDocumentLoader
> 
> This scope is used to map Frame to just-about-to-commit DocumentLoader.
> 
> With https://crrev.com/706529, we now call ReadyToCommitNavigation
> after the commit (as opposite to before the commit). Therefore,
> WebLocalFrame::GetDocumentLoader is already the right one and we don't
> need a scoped mapping.
> 
> Bug: 855189
> Change-Id: I95621b00ee4391986f063e56f20d8d7d25b5c532
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046210
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740198}

TBR=dgozman@chromium.org,rdevlin.cronin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 855189
Change-Id: I7021f96e4c6db2a41f048113b369eee7a21b07ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083390Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746166}

b0e76bc7

Add sync status check for real time url lookup with token. · 8a6b25af

Xinghui Lu authored Mar 03, 2020

FullURLLookupWithToken is enabled when:
1 FullURLLookup is enabled.
2 The user is syncing their browsing history.
3 Custom passphrase is disabled.

Bug: 1041912
Change-Id: Ie477512e9cd311d7db8891cc8a0bd7daf0559293
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071385
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746165}

8a6b25af

[StartSurface] Do not create MV tiles if not necessary · 56d1482c

gogerald authored Mar 03, 2020

Bug: 1041047
Change-Id: I43fafa456579ab0c760e278f8972bd82b2bc187a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078555
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746164}

56d1482c

OOR-CORS: Update fieldtrial_testing_config · 3db3ee2c

Takashi Toyoshima authored Mar 03, 2020

Update the file to match actual parameters that was fixed
to distribute parameters correctly.

Bug: 1001450, 1056037
Change-Id: I387be6a82e3ecc96d0c7b4a1c4975f97dde717ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082222
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746163}

3db3ee2c

02 Mar, 2020 25 commits

[omnibox] Implement clipboard suggestion processor · 0dfb95cc

Gang Wu authored Mar 02, 2020

Separate clipboard out of BasicSuggestionProcessor, and create a new
processor for clipboard.

Bug: 1020708
Change-Id: I9008c6263354562ffbc8232b28c839a45c96fe46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051292
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#746162}

0dfb95cc

crostini: cleanup page tests · a52f7e9e

Julian Watson authored Mar 02, 2020

Bug: None
Change-Id: Ifa311c32d0fa2a0d2cb7c13e107e98b7d046aeed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082423Reviewed-by: Julian Watson <juwa@google.com>
Reviewed-by: Nic Hollingum <hollingum@google.com>
Commit-Queue: Nic Hollingum <hollingum@google.com>
Auto-Submit: Julian Watson <juwa@google.com>
Cr-Commit-Position: refs/heads/master@{#746161}

a52f7e9e

Update Omnibox content with selected suggestion only. · 6f807ad1

Tomasz Wiszkowski authored Mar 02, 2020

This CL addresses a bug, where Omnibox content would occasionally get
updated with the inaccurate content when browsing the suggestions
using Keyboard.

Bug: 1054399
Change-Id: Ic00d8e2b6bbf6680de56ca78cfacf4a25d5f8b68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081890Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#746160}

6f807ad1

Remove sxg-with-network-service virtual tests from Blink · 17bbb0fb

Tsuyoshi Horo authored Mar 02, 2020

Bug: 1057538
Change-Id: Ic2b014d80a27a07c866e873e82a236d368ac11e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082738Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746159}

17bbb0fb

Fix for PerformanceClassForURL returning PERFORMANCE_FAST for all links in some situations. · eeb696df

Josh Simmons authored Mar 02, 2020

This would happen when the kPerformanceHintsTreatUnknownAsFast flag was
enabled but the user opted out of Make Browsing Better.

Also fix an issue where we wouldn't reset the value of hint_processed_,
which caused us to never log kHintNotReady after the first load.

Bug: 1040661
Change-Id: I32f0b8ea475d4d23a9af9e074482b9e009980719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078908
Commit-Queue: Josh Simmons <jds@google.com>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746158}

eeb696df

Move enum SurfaceOrigin to ui/gfx and expose to GLSurface · 43dcc185

Kramer Ge authored Mar 02, 2020

The purpose is to indicate where (0,0) is in an output surface. And
replace GLSurface::FlipsVertically() with a descriptive function that
returns surface origin.

It is nicer if enum SurfaceOrigin is shared between ui/gl/ and
components/viz/ so there's no logic for transforming.

There is also an instance to change in
gpu/command_buffer/common/capabilities.h. Future CL will modify it and
IPC definition that uses it.

Bug: 1051970
Change-Id: I33254620feba54a77ad51ff3fd6b82d6962d25bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083571Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746157}

43dcc185

back gesture: close VK first if VK is visible when performing back. · 9b660319

Xiaoqian Dai authored Mar 02, 2020

Bug: 1056939
Change-Id: I70acfadf7ad2468e8055f8150759861b892812b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083756Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746156}

9b660319

[Media Feeds] Store feeds in Media History · 7f6eed59

Becca Hughes authored Mar 02, 2020

Adds a feeds table that will store feeds in
Media History.

BUG=1057765

Change-Id: I68e38fdeb608da9f9279c74ffbed3f7efc5037a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082300Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746155}

7f6eed59

Set time limit for web blocking error page. · cc5f83fa

yilkal authored Mar 02, 2020

This CL ensures that the time limit is shown in the
blocking page.

Bug: 1056471
Change-Id: Ia283881a8f4645f130679a48301d84bcdd32ad69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083398
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746154}

cc5f83fa

Disable testReportAvailableDirectActions. · aa7b4f47

Xing Liu authored Mar 02, 2020

AutofillAssistantDirectActionHandlerTest#testReportAvailableDirectActions
is failing on Android bots, disable it.

TBR=mcarlen@chromium.org

Bug: 1057806
Change-Id: I73c0ad991b42f3a554c376f43b0f3170205e5935
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082224Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746153}

aa7b4f47

android: fix content_browsertests emulator filter file. · b65c45dc

John Budorick authored Mar 02, 2020

Bug: 1056325, 1056878
Change-Id: I374d538d7104f8ea60520a40ea15b9661f7d304c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083753
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746152}

b65c45dc

Set unrecognized values of "scrolling" attribute to kAuto · 874c6cdd

Mason Freed authored Mar 02, 2020

Prior to this CL, unrecognized values of the "scrolling" attribute
would leave the prior value unchanged. That behavior is counter
to the spec [1], and is also confusing to developers, as it
introduces state to the "scrolling" attribute. This CL fixes
that.

[1] https://html.spec.whatwg.org/multipage/rendering.html#the-page

Fixed: 1057454
Change-Id: Ib6b4cd4c6952fe580003dc2577c72db2fe622fae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083595
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746151}

874c6cdd

Disable flaky test GeneratesWhenOverThreshold on Android. · 59742ff9

Xing Liu authored Mar 02, 2020

UserLevelMemoryPressureSignalGeneratorTest.GeneratesWhenOverThreshold
has been flaky for a few days, disable it.

TBR=dcheng@chromium.org

Bug: 1054788
Change-Id: I5c16cdbf17316f6475e43d11d754006d194d970f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083829Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746150}

59742ff9

Make WebRequestProxyingURLLoaderFactory behavior match HTTP redirects. · 7d4a3137

Matt Menke authored Mar 02, 2020

In particular, have it invoke net::RedirectInfo::ComputeRedirectInfo()
when an extension injects a redirect so that site-for-cookies, referrer,
method, and referrer_policy are all calculated correctly, and have
it update NetworkIsolationKey according to the value in
request_.trusted_params->update_network_isolation_key_on_redirect.

Change-Id: Ied1e0d9825b75110143881d6aac806da1f13baab
Fixed: 1053573
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057529
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746149}

7d4a3137

Android: Extend gesturenav/ephemeraltab flag to M85 · 86aeca36

Jinsuk Kim authored Mar 02, 2020

Extends the experiments to M85 so the flag options will be visible.

Change-Id: I4643b2dcc0167af9a6e9ad2d0a85ec7ae1d027f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081715
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746148}

86aeca36

Fix video-raf test flakiness · 5ddf602e

Thomas Guilbert authored Mar 02, 2020

Despite hand coded test values, the difference between
base::TimeTicks::Now() and the Document's origin time can result in times
aligned with a 5 microseconds clock. This is a test failure, because we
don't know whether or not the time values were successfully clamped.

This CL uses the reference monotonic time instead of
base::TimeTicks::Now() when initializing the test values, which
guarantees deterministic results.

Bug: 1057319
Change-Id: I26ee485545a75ba25bc2e9187e78f032fce767e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083737Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746147}

5ddf602e

Fix ASTC HDR WebGL extension. · 0acf80f1

shrekshao authored Mar 02, 2020

Tested on Pixel 3 XL (with HDR support) (validating) and Nexus 5X (without HDR support)(validating/passthrough) with up-to-date WebGL ASTC test.
Not tested with passthrough angle on Pixel 3 XL due to the build config and cmd line settings for passthrough angle
not work properly locally (reported to Geoff). But given that angle exposes the
extension with the same name as OpenGL it should be fine.

Bug: 1049880
Change-Id: Iadc1a78591068927bbed9523131924187f53fe3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080823
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746146}

0acf80f1

Fix flaky test HomepageSettingsFragmentTest#testChangeCustomized · ca38b22f

Wenyu Fu authored Mar 02, 2020

Use criteria helper to wait desire state of UI to reduce flakiness.

Bug: 1056985
Change-Id: I8883722a62120cc4228e2fd5d7c3abc8b3ca071d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080470
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Auto-Submit: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746145}

ca38b22f

[Fuchsia] Stop using ApplicationControllerReceiver. · 1b0ad2b7

Sergey Ulanov authored Mar 02, 2020

ApplicationControllerReceiver protocol is being replaced ApplicationContext.
This CL updates CastRunner to use ApplicationContext instead of
ApplicationControllerReceiver.

Bug: 1028409
Change-Id: I7679ba3238754e994bf9fcc2bec1a30ddcd75389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079808
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746144}

1b0ad2b7

[Image Fetcher] Add data url support · 1f323f2f

Brandon Wylie authored Mar 02, 2020

Bug: 1015174
Change-Id: I356619e74745a31ebd0aef46f64977a025dd099b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078978
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746143}

1f323f2f

Break connections before removing from active_source_handlers_. · 3ac88832

Raymond Toy authored Mar 02, 2020

In DeferredTaskHandler::BreakConnections, we want to remove finished
handlers and break the connection.  when a finished handler is removed
from active_source_handlers_, it might be deleted, but we were still
using that to create the connection.  Instead, break the connection
first and then remove it.

Manually ran test from the bug and it passes with this change.  Without
this, it failed right away.

Bug: 1057593
Change-Id: I3c9346a6842f412100d608876adb268befb80470
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083436
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746142}

3ac88832

Revert "Update Crashpad to 11b8eb10d4ad6ed50ee43d3bb50d13967d638dfa" · 149eba8a

Gang Wu authored Mar 02, 2020

This reverts commit d9deeea6.

Reason for revert: compile error on ios-device build
https://ci.chromium.org/p/chromium/builders/ci/ios-device/150149

Original change's description:
> Update Crashpad to 11b8eb10d4ad6ed50ee43d3bb50d13967d638dfa
> 
> 9ed829054711 Bring up skeleton crashpad_client_ios
> 22701bb0e448 fuchsia: Use zx_system_get_version_string
> f79cba47ba0d [lsan][crashpad] Suppress leak sanitizer on crashpad_test
> 0c20aeabd37a [UBSan] Temporarily disable UBSan for snapshot and minidump
> d632f625a2f2 Fix a Wrange-loop-analysis warning in crashpad
> 8bad6f140e0b [UBSan] Temporarily disable UBSan for gtest and file
> 11b8eb10d4ad Don’t use the disappearing MSVC_PUSH_DISABLE_WARNING()
>              macro
> 
> Change-Id: I5f0ba09aae2fcd1a8b91543f91a94ffe093f16b5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083654
> Commit-Queue: Mark Mentovai <mark@chromium.org>
> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#746133}

TBR=thakis@chromium.org,jperaza@chromium.org,mark@chromium.org

Change-Id: I48cc6cb41ab563964f50fa02cf3a7570c820a059
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083933Reviewed-by: Gang Wu <gangwu@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746141}

149eba8a

add flag to stage virtual change in SkCanvas · cffaf486

Mike Reed authored Mar 02, 2020

Bug: skia:9984
Change-Id: I119ce10adcf14000d2f706f7c947f3c3f1da68a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083599Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746140}

cffaf486

[ChromeDriver] Deprecate launchApp command · cfb653bb

Tricia Crichton authored Mar 02, 2020

Prior to complete removal planned for m84, the LaunchApp command will be
rejected. As a temporary workaround, a new capability is added to give
access to LaunchApp when requested by users.

Bug: chromedriver:1778
Change-Id: I93f9aab5fca4593032b5876ddf2fbb52e50c7335
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080782Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tricia Crichton <triciac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746139}

cfb653bb

Roll silvermont AFDO profile from... · 36909610

chromium-autoroll authored Mar 02, 2020

Roll silvermont AFDO profile from 82-4044.25-1582542147-benchmark-82.0.4072.0-r1 to 82-4044.31-1583145468-benchmark-82.0.4072.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Ibeba5967bda1115a7d3dc80e2aaabbdc64f53340
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083856Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746138}

36909610