- 18 Mar, 2020 40 commits
-
-
Jan Wilken Dörrie authored
This change removes the TOO_MANY_PASSWORDS error case from the password check and deletes relevant logic. The strings will be removed in a follow-up CL to simplify merging. Bug: 1061927 Change-Id: I73574316020de364cc76487191983cea94a54a66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105319Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#751300}
-
Anders Hartvoll Ruud authored
Consider a rule such as: a:visited { background-color: green !important; } If 'background-color' on 'a' is currently undergoing a @keyframes animation, and 'a' is a visited link, the -internal-visited-background- color (i.e. what we paint) must be 'green', but the 'background-color' as seen from JS must be the interpolated color. Since unvisited and visited colors are applied together by the interpolations machinery, we need to work around this manually. Whenever we apply an interpolated color, we check the priority of the -internal- visited- counterpart, and apply that again if its priority is higher. Note that despite CSSCascade being enabled for stable at the moment, this does not (yet) constitute a web-facing change, as the standard property animations are still using their own StyleCascade object (see ApplyAnimatedStandardProperties), and -internal-visited- properties are never added to that cascade. Bug: 1062217, 552085 Change-Id: Ic65b4986d41d7ada62fc5a857fdce8e08077609d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106186 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#751299}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e8ce957aec8c..33e164438ff9 git log e8ce957aec8c..33e164438ff9 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 taylori@google.com perfetto-ui: Color summarized userspace slices Created with: gclient setdep -r src/third_party/perfetto@33e164438ff9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:148446682 Tbr: perfetto-bugs@google.com Change-Id: Ie1cd1f76e5de6429240aefa97b1de1d08dd13cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108074Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751298}
-
Patrick Monette authored
Also remove duplicate header file to fix lint warning. Change-Id: Ia16ff2af7c5bf144365769276a8072863806a46c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106563 Auto-Submit: Patrick Monette <pmonette@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#751297}
-
Mihai Sardarescu authored
Sign-in UI code went through a massive architectural change which seems to have fixed the test. Bug: 962847 Change-Id: I1a37f8000a6792bce5f75a842376a1d30ff129f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106586Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#751296}
-
Yoav Weiss authored
This implements PR #80 [1] and exposes userAgentData in workers. [1] https://github.com/WICG/ua-client-hints/pull/80 Bug: 1062192 Change-Id: I1de6067ab6c00855d7bf820e9646eb4e5a8c5fdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093220 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#751295}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I26c5f7ccf95203ad9eaf1f3caae2d97a721f717f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108580Reviewed-by:
-
Aya ElAttar authored
Bug: 1015378 Change-Id: I8e50b5f2dde2f8b7825f53520ccc87a0383f6e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089844 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
-
Mikhail Khokhlov authored
Now that trace_processor_shell built from Chrome supports windows functions, we can take advantage of them. Bug: b/150125501 Change-Id: I7e6c93b7b570003c1fc97fda7bbb63cbb388b419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107483 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#751292}
-
chromium-autoroll authored
Roll airmont AFDO profile from 82-4079.0-1584355719-benchmark-82.0.4085.8-r1 to 82-4079.0-1584355719-benchmark-82.0.4085.10-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I5fb762137876f246e847fe08b14b81d3fcddb591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108068Reviewed-by:
-
Mark Cogan authored
Major changes: UrlLoadingService -> UrlLoadingBrowserAgent, all call sites updated. TestUrlLoadingService -> FakeUrlLoadingBrowserAgent, to more clearly state what kind of test double it is. UrlLoadingServiceDelegate -> URLLoadingDelegate, to not couple the protocol name to the nature of the delegating object. FakeUrlLoadingBrowserAgent gets an explicit 'InjectForBrowser' to be used instead of 'CreateForBrowser', which hijacks the superclass UserDataKey() so it will be fetched like the normal instance when used. Bug: 1046374 Change-Id: Ie0229f387fef24b791bf70fc2aab91d5fe9e0662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105314 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751290}
-
Andy Paicu authored
This reverts commit ceaafd48. Reason for revert: likely cause of clusterfuzz crash Original change's description: > Launch the `navigate-to` directive > > The directive has been behind a flag for a year and we have received > no [negative] feedback. > > Spec: https://w3c.github.io/webappsec-csp/#directive-navigate-to > > I2S: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/EJ4xF_DwZyk > > Bug: 805886 > Change-Id: I746aed4032149b86a5f9974246e2ec35bf8eb356 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856100 > Reviewed-by: Andy Paicu <andypaicu@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Auto-Submit: Andy Paicu <andypaicu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750183} TBR=mkwst@chromium.org,andypaicu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. TBR=mkwst@chromium.org Bug: 805886 Change-Id: I03090af2eaee38c57084b4f0d8d0307e9d8e72aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107486 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#751289}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 82-4079.0-1584354054-benchmark-82.0.4085.8-r1 to 82-4079.0-1584354054-benchmark-82.0.4085.10-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I88471ed66220b0cb80aa2661faf71326f9715d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108069Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Idc46cbe5ff96905b3ec32e86a6085d28e5d90fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108071Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 82-4044.42-1584352428-benchmark-82.0.4085.8-r1 to 82-4044.42-1584352428-benchmark-82.0.4085.10-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I46e4224b2b4f73cc124420e09a3cc76c289bcafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108067Reviewed-by:
-
David Roger authored
This CL builds the profile menu on ChromeOS and displays it when the avatar button is enabled. Bug: 1041472 Change-Id: Ieb931a6e00960c67d479aa2989449a59186097ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056905 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#751285}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Remove DEFINE_LAYOUT_OBJECT_TYPE_CASTS. 2. Use new downast helpers for blink::LayoutSlider blink::LayoutSVGContainer and blink::LayoutSVGForeignObject Bug: 891908 Change-Id: Ib00d9a773f9c43150d33322a7f29062d8b000119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108308Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#751284}
-
Chris Hall authored
R=thestig,akihiroota Change-Id: I7bf8774a761c41f602c887d1b4b4e92b9acd0f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096406 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#751283}
-
arthursonzogni authored
Disabled tests: ClearBrowsingDataFragmentTest#testImportantSitesDialogNoFiltering ClearBrowsingDataFragmentTest#testDialogAboutOtherFormsOfBrowsingHistory TBR=dullweber@chromium.org Bug: 1062568 Change-Id: Id30acd937fe1864b9dd440f14152d881a42bb81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106592Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#751282}
-
arthursonzogni authored
Recently introduced by: https://chromium-review.googlesource.com/c/chromium/src/+/2031941 TBR=oysteine@chromium.org Bug: 1062581, Change-Id: Iaf49d9191616ade3f082352adc84f32230227d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108541 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Olivier Robin authored
This adds SSOConfig to the bundle. The only difference with the current behavior is that the Chrome.app and EarlGrey application build in out/Official-* will now use the Chromium clientID. They previously used the Chrome stable client ID (which is wrong IMO). Change-Id: I6cd0706c7dc7e50bc238d44a40e6d38cb3ca2ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096643Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751280}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0d195767. With Chromium commits locally applied on WPT: acbe6d96 "Add timeouts for EventWatchers on CSS animation tests" 52436075 "UpgradeInsecureRequest: Add subresource fetch from data: URL workers test" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-text/line-break NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ie50f3678f55b7fa7ce9e0445540a19b9c5b4c530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108056Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751279}
-
Chris Hall authored
R=dmazzoni,akihiroota CC=thestig Change-Id: I2d7f788c6147162406cb549cdeaebf16cdd3f914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096802 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#751278}
-
Anders Hartvoll Ruud authored
The filter was accidentally unused when analyzing interpolations. Everything still worked, because Apply-time filtering was honored. It might be that we actually don't need Analyze-time filtering at all, but we shouldn't remove it until the performance implication of such a change has been investigated. In the meantime, the filter should be respected. Change-Id: Ib04e044ab4725940c17312e80206a75630bb8d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106590Reviewed-by:
-
Shik Chen authored
Bug: 1058325 Test: Open CCA and check there is no error in console. Change-Id: I1a5d944da3d6e2b266112601e436d08ee2ff0f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108245Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#751276}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/be16737b..47d5b94b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8603453c5e219b75513681bdc7b4fded2db342d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108362Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751275}
-
Side Yilmaz authored
Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates NotificationManager class. Note: This change is only code clean-up, does not change any behaviour. Bug: 1041781 Change-Id: I579739c552be2321632ff551898f7416ca976d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102539Reviewed-by:
Travis Skare <skare@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#751274}
-
Rune Lillesveen authored
Making the selection colors and caret interval members non-static members of LayoutThemeDefault in [1] caused regressions for the devtools inspector because GetTheme() returns different objects depending on whether we emulate a mobile device or not, and these values are only updated on the current object returned by LayoutTheme::GetTheme(). Also added a test to avoid this regression in the future. [1] https://crrev.com/67575409937d6cc6d2226f7f5bcea667075e5d7d Bug: 1062214 Change-Id: I06144fb4ff74e204432591498e7cd2e934018819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106070 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#751273}
-
Aya ElAttar authored
Added kFlagDoesNotRequireManagedSessionFullLoginWarning to the permissions which should not trigger the full warning on the login screen of the managed-guest session after discussions with the privacy team. Bug: 1015378 Change-Id: I32926033c6b163e3602dc542b96c57b183023bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089738 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#751272}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/4ef574064e..c6954897f7 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/4ef574064e..c6954897f7 Bug: None Change-Id: Ib31cdd37b84ec17da7d63195f59997df6f0d24d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104047 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#751271}
-
Side Yilmaz authored
Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates NewTabPageView class. Note: This change is only code clean-up, does not change any behaviour. Bug: 1041781 Change-Id: Ib6b7ddc3bed423047c3946445645aba82eeaeab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085372Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#751270}
-
Side Yilmaz authored
Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates Feed test class. Note: This change is only code clean-up, does not change any behaviour. Bug: 1041781 Change-Id: Ic78077bd7de57a853dc330b394c3fe47f253439a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106583Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#751269}
-
sandromaggi authored
-Gets the hash of the account which sent the intent from the parameters. -Checks whether the hash matches the current account logged in in Chrome. -Sends the result to the back-end in the ClientContext. -Removes the hash from the params so that it's not sent to the back-end Bug: b/151211877 Change-Id: I3fd2afda38c16ba821358fb68e1397fb4eb16c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096589 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#751268}
-
Arthur Sonzogni authored
This reverts commit e245bb7a. Reason for revert: several tests are failing: See: https://crbug.com/1062561 https://crbug.com/1062554 Original change's description: > weblayer: fixes strict mode issues for weblayer > > This fixs a number of cases and enables strict mode in tests. Hopefully > that helps prevent any other access from being added. > > The trickier cases are jacoco injects code that accesses the disk, and > LayoutInflater may trigger loading classes, which triggers disk > access. > > BUG=1059770 > TEST=covered by tests now > > Change-Id: I50f81836f838b023fe09fd5f760cb7484edd8d26 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100589 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751028} TBR=sky@chromium.org,boliu@chromium.org Change-Id: I3405b415b69cbb3cb0e417ac38caae608356101b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059770, 1062561, 1062554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107586Reviewed-by:
-
Rainhard Findling authored
* Fixes a syntax error introduced in https://crrev.com/c/2106171 that blocks translation message extraction. Change-Id: I4f9b1999d60a41c03846f01a0ae0db29c2bba701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107547 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Auto-Submit: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#751266}
-
Yuzu Saijo authored
This CL replaces linux-bfcache-debug with linux-bfcache-rel which runs on the Release build, in order to preapare for making the bot run on CQ. Bug: 1042160 Change-Id: I824e86948f195ce41034969069e8b1d4b611c40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100248 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#751265}
-
Istiaque Ahmed authored
ParseJson returns base::Value (stack allocated) where ParseJsonDeprecated returns unique_ptr<base::Value>. This CL replaces those instances of ParseJsonDeprecated where the return value was immediately de-referenced to base::Value. This CL also converts some multiline strings to raw string literals along the way. Bug: 932873 Change-Id: I68b1a16522d4cf96fdcb03123ae4a5dca5684beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095366 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |NGBoxFragmentPainterTest.ScrollHitTestOrder| to use |NGInlineCursor| to handle both |NGFragmentItem| and |NGPaintFragment| for preparation of migrating |NGFragmentItem|. Bug: 982194 Change-Id: Ib3a706aa3e1bc5d81009e22bf1002eb60eea55a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108265 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751263}
-
Wei Lee authored
Since the parameter name conflicts with the name of namespace, it will cause error when generating JS version of the mojo interface. Bug: 1054370 Test: Build successfully and the conflict is gone Change-Id: I8707c5170d104256b5f5caa751be279ccb3b4689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102369Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#751262}
-
Istiaque Ahmed authored
Update callers that were using those deprecated ctors, by passing base::Value directly from them. This CL also removes some ParseJsonDeprecated usage in //extensions. Bug: 1062547, 932873 Change-Id: Ib7609d63b8530845e3458b43d4f73c5448028456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096107 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
