- 11 Dec, 2020 40 commits
-
-
Min Qin authored
This CL fixes a couple issues on counting tile impressions on NTP. 1. NTP calls TileManager::GetTiles() to get both the top and sub tiles. While Omnibox makes two separate calls of GetTiles() and GetTile(). This CL fixes the behavior of NTP to match that of Omnibox, so we can count top level tile impression when GetTiles() is called, and counts subtile impression when GetTile() is called. 2. Clicking the home button will often invoke 2 calls to GetTiles(). One caused by QueryTileSection ctor, one caused by OnLoadUrl() for NTP. We don't actually need to reload tiles if user never clicked on any tiles. In most cases, only the call from ctor is necessary. This CL fixes the issue by checking whether tiles has been clicked before reloading all tiles. BUG=1155919 Change-Id: Ief1f4be957d160119c40fec1da71ae79d6258321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576504 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836218}
-
Peter Kasting authored
Various functions were unconditionally casting non-representable values. Bug: 1124595 Change-Id: I811f44164a7c9f5802287e1d826cf403ff2e08e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585669 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#836217}
-
Orin Jaworski authored
Bug: 1157612 Change-Id: Iebd56655a223360f716c0d075c68fa2572fd1508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585752Reviewed-by:
Angela Yoeurng <yoangela@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#836216}
-
Dominic Mazzoni authored
The ForcedColors feature is fully implemented and on track to ship in M89. That brings Chrome to parity with Edge in how it handles Windows High Contrast mode and it also gives web developers new CSS features to detect and override it where needed. InvertBubbleView was our previous solution - if a user had high contrast mode enabled, we'd show this bubble to direct them to an extension and theme to get a similar effect. Those recommendations are now no longer necessary. Bug: 970285 Change-Id: I0e0e78e489f2a40f1618055b7ebaea660e155e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586367 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#836215}
-
Richard Stotz authored
This CL fixes some minor issues with NativeIO's web platform tests. - The concurrent_io tests obtain a more unified structure to reduce the chance of missing an await. - createFile() is removed from close_async as the exact same function is provided by resources/support.js. Bug: 1157915 Change-Id: I3e33cc8d93e08c31dddc4d844310c92eeba31a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587058 Commit-Queue: Richard Stotz <rstz@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#836214}
-
dpapad authored
Bug: 1132403 Change-Id: I013ec9272dfb73fd0ccc1c205397d561be65c84a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581441 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#836213}
-
Ryan Sturm authored
This is a reland of 583f52a3 See https://chromium-review.googlesource.com/c/chromium/src/+/2585991/2 for underlying MSAN issue unrelated to this CL (just caught by this CL's tests) Original change's description: > Search Prefetch Streaming requests can be cancelled after headers > > The goal of this CL is to allow unneeded requests to be cancelled > when they are unlikely to be navigated to. This is achieved through > a few avenues of change: > > -- When the user navigates to something in omnibox, the URL is reported > to Search Prefetch Service to be able to mark it as likely to be served > (using kCanBeServedAndUserClicked when the request is kCanBeServed). > This occurs before the omnibox is closed and all results are wiped. > -- kCanBeServed are wiped when omnibox closes. > -- Streaming requests will no longer pause the mojo channel, so they can > witness the Complete event to be able to make the request as complete. > -- As part of above, we store the response body in memory instead of > just handing off the data pipe. Data pipes have a 500k data limit, which > search requests typically go over. Net won't send the complete event > until all data is in the pipe. Therefore we store the data and create a > pipe to navigation if needed. > -- Full body implementation now reports kComplete where it used to > report kCanBeServed. > > Bug: 1156325 > Change-Id: Ied70a3eafd896801e263f631cb4d80556e762180 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583112 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835897} Bug: 1156325 Change-Id: Ifeeed421e9124f99a0f6aa27ca08734a1b130878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587263Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#836212}
-
Pranav Batra authored
If packets are rate limited by CUPS proxy, the print request will probably fail. We want this information to always be logged so that we can determine whether or not rate limiting is the cause of the print failure by looking through the log. Bug: 1157699 Change-Id: If1cb5689ca8f645a63ea93a0b4e368d83319e88e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586756Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#836211}
-
Jesse Schettler authored
Update the layout of the elements in the done section to conform to the spec. Spec: https://carbon.googleplex.com/cros-ux/pages/scanning Screenshot: http://shortn/_b4ThkiWjXu Bug: 1059779 Change-Id: If058edfe23fa4ef15fa2e85931d72e4867ba3756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586764Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#836210}
-
Jarryd authored
This change also adds a basic test to verify the action. Bug: 1156349 Change-Id: Ic1f0f331e72029cd8bb95368d525bc27c3e247a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580485 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#836209}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/203ae7e60e20..29339074e443 2020-12-11 ethannicholas@google.com fixed SkSL crash when performing binary operations on invalid types 2020-12-11 johnstiles@google.com Add Metal support for the `findLSB` intrinsic. 2020-12-11 brianosman@google.com SkSLSlide: Fill the entire canvas with the user shader 2020-12-11 ethannicholas@google.com Revert "Reland "Reland "Revert "Initial land of SkSL DSL."""" 2020-12-11 tdenniston@google.com [svg] Minor cleanups 2020-12-11 nifong@google.com Update buildbot repo to deploy debugger changes 2020-12-11 brianosman@google.com Add shadertoy style 'iTime' to SkSLSlide 2020-12-11 johnstiles@google.com Add support for scalar `faceforward` intrinsic in Metal. 2020-12-11 tdenniston@google.com [svg] Add feFlood filter node 2020-12-11 johnstiles@google.com Add Metal support for degrees() and radians() intrinsics. 2020-12-11 johnstiles@google.com Clean up Metal bitcast implementation. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: I7f3e003f22b2bd9d4ed80f3d0bcde2a0197b70bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586032Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836208}
-
Pranav Batra authored
tast.printer.ProxyPinPrintLexmark.no_pin appears to be failing due to throttling. Increase the rate limit to prevent this. Bug: 1157699 Change-Id: I51b4268551bdcee5003be84c161e2a8ff9894df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586757Reviewed-by:
-
Ryan Sturm authored
render_process_assignment_ was uninitialized and can be used in OnHidden before OnCommit happens. We'll move to the optional pattern used in this file. Bug: 1157751 Change-Id: I4c126735ef51b126b93208cc61a1a08802bde802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585991Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/671ca647718c..0a8e6d54fba6 2020-12-11 sidereal@google.com Introduce guest_vm_image config 2020-12-11 batrapranav@chromium.org uprev_lib.py: Do not ignore ebuild version errors 2020-12-10 vapier@chromium.org cros deploy: speed up --unmerge 2020-12-10 mmortensen@google.com DebugSymbolFiles: Add functionality to generate breakpad symbols. 2020-12-10 jbates@chromium.org usergroup_baseline: add crosvm to traced-producer group If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I0bc4adaec54754a1d6492d5087a5d8d077a713b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586907Reviewed-by:
-
Matt Wolenetz authored
This change: 1) Implements WebSourceBufferImpl::AppendChunks(), plumbing the appended chunks through ChunkDemuxer into the stream parser's ProcessChunks(). 2) Implements WebCodecsEncodedChunkStreamParser::ProcessChunks(), emitting cached config when necessary (prior to calling the NewBuffersCB, initially, or if a flush() operation had just happened before the chunks were appended. 3) Aligns as much as possible with existing architecture for similar handling by regular bytestream parsers, for improved reuse and maintainability. 4) Adds a basic end-to-end vp9 video chunk buffering and playback test. Later refinements will add more tests and may improve usability with things like EncodedAudioChunk duration, EncodedVideoChunk decodeTimestamp, and h264 support (where applicable by build flags). BUG=1144908 Change-Id: Ib787d22b0171826fa28bdbb776410e02e25a9cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575501 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#836204}
-
Thomas Lukaszewicz authored
This CL fixes it so the margins from the beginning of the tab search item to the favicon match those from the end of the tab search item to the close button. This CL also hides the close button when the tab search item is not hovered or focused to increase the space available to tab titles and hostnames. Before: https://drive.google.com/file/d/1cmuKp4R_nVc7eAaljtIbFX2g0nwlIzKT/view?usp=sharing After: https://drive.google.com/file/d/1oa0lyapwxIGwtCpbxc61bJdPD03gfdVC/view?usp=sharing Bug: 1128599 Change-Id: I6d49a6982483a87028f2d562884f752b82ea6cf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582629Reviewed-by:
Roman Arora <romanarora@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#836203}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/54c26addfe46..977eeb69af7b 2020-12-11 vmpstr@chromium.org Add content-visibility information for node highlight. 2020-12-11 sigurds@chromium.org Refactor ExpandableApplicationPanelTreeElement If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1147510,chromium:1157484 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibb3b1803836a96ab3228f7ac234b8115a0bb1831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586103Reviewed-by:
-
Matt Wolenetz authored
This change: 1) Implements SourceBuffer::appendEncodedChunks(). This is the first promise-based MSE API. Like async appendBuffer(), once the synchronous prepareAppend steps are complete, an async task is scheduled to complete the chunks' append. Unlike async appendBuffer(), the 'update', 'updateend', 'abort', 'error' events involved in an async chunk append are not enqueued, as the same information is exposed instead in promise rejections. Also, mixing event-notification with promise resolution/rejection is confusing and redundant, and w3ctag guidelines for promise-based APIs need such events originating in a promise's async execution to be dispatched (not just enqueued) prior to promise resolution/rejection occurring. 2) Converts (using new local helpers in SourceBuffer) the chunks directly into the type used in the underlying MSE buffering implementation (StreamParserBuffers in a circular_deque) during the synchronous portion of appendEncodedChunks(). 3) The async chunk task is canceled during contextDestruction; it also is used to gate hasPendingActivity. Essentially, it's a 3rd async operation the SourceBuffer could do (in addition to pre-existing async appendBuffer and async remove). At most one of these three async operations may be pending at a time. This keeps the behavior unsurprising and aligns better w.r.t. previous similar async MSE operations. 4) Adds a new WebSourceBuffer AppendChunks method and a stubbed implementation of it in WebSourceBufferImpl. Later changes will update WSBI::AppendChunks() to send the buffers through ChunkDemuxer to the WebCodecsEncodedChunkStreamParser, and add tests for promise rejection/abort/success scenarios and basic end-to-end buffering and playback of encoded chunks with MSE. Refinements, such as supporting h264 chunk buffering, using non-hardcoded audio chunk duration (from a new optional duration, but required-for-MSE, EncodedAudioChunkInit attribute), and letting the app provide decode timestamp in EncodedVideoChunkInit, may also come later. BUG=1144908 Change-Id: Ieb5d0942e68f48156bee9290dcb99dad2e280e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574534Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d1910cef3a77..f48161bc4b8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alexmos@google.com,eirage@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: alexmos@google.com,eirage@google.com Change-Id: Iff6e88691998d07ccdc53d6b058129957b00e749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586318Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836200}
-
Luke Zielinski authored
TBR=robertma Change-Id: I55fc4259b71e41da2db975917c8e8585cce5f10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587348Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#836199}
-
Olesia Marukhno authored
Announce to screenreaders that a permission has requested if chip UI is used. For prompt UI, the bubble is shown and it takes over the focus. Chip UI is less intrusive so it must be explicitly annouced for screen reader users. To avoid users not hearing the announcement, it would be reannouced after 2 minutes. Chip UI is now one of the panes (users can cycle through panes with F6). This way users can easily access it with keyboard which is very important for screenreader users. Also to make sure that users don't miss pending permission request, added message about having pending permission request to tab announcement. Bug: 1150836 Change-Id: I7118abcf0bed9702cf17d15a9bb59f9a1d8783b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578843 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#836198}
-
Mehran Mahmoudi authored
Change-Id: I7e203ddd04ab61e1f480db09380ec90d7e95ffc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583002 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#836197}
-
Robbie Gibson authored
The major issue here was that the height calculation in horizontal_layout.mm wasn't taking the collection view's contentInsets into account when calculating the sectionInset. This meant that the resulting layout was too large. Specifically, the vertical sectionInsets + contentInset + item height ended up larger than the collection view's height, causing the layout to be incorrect. Fixed: 1155601 Change-Id: Ie9594fec2762239963bc90c41bf07f8caa42bf83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587038Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#836196}
-
Robbie Gibson authored
Before, -setInsetForRemoteTabs wasn't being called because the tab grid was appearing in a different way (through the pan handler). Fixed: 1155610 Change-Id: I1444624c2bf7d6c3c379f083205a520a731cab98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585095Reviewed-by:
-
Eugene But authored
Change-Id: Ie1f5033f6d7b6d70ad2f15bf49ad099155becc49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586027 Commit-Queue: Eugene But <eugenebut@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#836194}
-
Jana Grill authored
Adjust ADB sideloading notification messages to support FlexOrgs by adjusting the domain placeholder names and descriptions to make it easier for the translators to understand the usage of the texts. Additionally replace a call to BrowserPolicyConnectorChromeOS::GetEnterpriseDisplayDomain with a call to BrowserPolicyConnectorChromeOS::GetEnterpriseDomainManager. Bug: b:172685929 Test: None Change-Id: I1cdeff3e45730d2fed41997046734f3a98bf1ee3 Skip-Translation-Screenshots-Check: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584775Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Brian Malcolm <bmalcolm@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#836193}
-
Eugene But authored
Bug: 688063 Change-Id: Ic8f0e62003a309481b07ff6b85e54e7a5e09ed3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586657 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#836192}
-
Leo Lai authored
It should not matter where the fields that fill `TpmStatusinfo`. BUG=b:172748724 TEST=build ok. Change-Id: Ic4dd4374ee25d9fc287ec02088b12cfe10f49035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586503 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#836191}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/0a64a9747555..7a519d34f57a 2020-12-11 capn@google.com Fix resolvable depth difference calculation for triangle near 0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0bfe5ddbb689d707fece6a0a02000de3f92377ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586908Reviewed-by:
-
Scott Violet authored
The use after free would happen if the animation duration was 0. The reason is RotateHidingWindowAnimationObserver would end up being destroyed when the animation was started. This is because if the animation completes immediately, then RotateHidingWindowAnimationObserver deletes itself, and AddLayerAnimationsForRotate tries to use RotateHidingWindowAnimationObserver after scheduling the aniation. The fix is to only create the observer if the animation hasn't completed. I had originally tried to disable animations if the duration is 0, as there is no point in doing any work. Unfortunately this proves quite problematic. In addition to animating, the animations may update other state, such as the bounds. I settled for adding a comment as to being careful in disabling animations. My suspicion is there are likely problems with disabling animations, but that's for another day. BUG=1154677 TEST=covered by tests Change-Id: I9f63d5c65a86c59d5ad82a8805e66a9a51ccc4b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570101 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#836189}
-
Stephan Hartmann authored
Bug: None Change-Id: I89857bb55b18084fb9845e212be58e8819a2b8d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582047 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#836188}
-
Elaine Chien authored
Bug: 1157313 Change-Id: I7a178d3b8dcb87e2e77b4ef74fffb77480200989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585713Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Elaine Chien <elainechien@chromium.org> Cr-Commit-Position: refs/heads/master@{#836187}
-
Hongchan Choi authored
This patch introduces a new server-side setting that enables the real-time priority thread for the RealtimeAudioWorkletThread object. Without the server interaction, the object will fall back to the NORMAL priority. See also: https://critique-ng.corp.google.com/cl/332043086 Bug: 1119403 Change-Id: I1067ccd5a8da4be2fb82450028f5697fbbfcdb59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412221Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#836186}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4abdaef9..c52956d0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I945091d07b4258665a3824df0b495df3eaee1cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586763Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836185}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6bcd4aceef10..ed883bc1d977 2020-12-11 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 287f6f12eff6 to a80511e02109 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: Idc13195351d80bf0869308c2cf83704d7bcc7407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586030Reviewed-by:
-
Fredrik Söderqvist authored
When we get fractional slice values, either directly or by zooming, the source rectangles can end up shifting and distorting the result when the <image> is not a raster image. Compute, and store, Edge::slice as float rather than int to preserve the fractional component of a slice, letting the lower level rendering primitives handle it. Bug: 596075, 1134145 Change-Id: I0669d0af9131c7937b984e47adf00a37991fcefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584805Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#836183}
-
James Cook authored
They print to the logs during normal usage. Changing to comments makes the logs cleaner. Bug: none Change-Id: I7f75ccce2ae60a0abfb54e081d056ab2eda2fdfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587255 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#836182}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d5e21940e048..8b9cff42b376 2020-12-11 johnchen@chromium.org Revert "Switch to vpython version of mock" 2020-12-11 dberris@chromium.org chromeperf: Sync queue configs from prod 2020-12-11 dberris@chromium.org chromeperf: Reduce rate to 500/s as it's a limit 2020-12-10 bsheedy@chromium.org Switch to vpython version of mock If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1156554,chromium:1156832 Tbr: wenbinzhang@google.com Change-Id: Iab9caa603c9e458d84c69dced684663681f4d573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587253Reviewed-by:
-
chrome://sandboxdpapad authored
Also fixing JS type checking errors in sandbox_internals_win.js which is not type caught on the bots as JS type checking is not performed on Win bots. Bug: 1028829 Change-Id: I1dff426272f4793ab23a13d117ac5f0a3a8bf99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587094 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#836180}
-
Fredrik Söderqvist authored
Move NGClipRectForNinePieceImageStrip() to InlineBoxPainterBase (dropping the 'NG' prefix) and switch InlineFlowBoxPainter to using it. Clean up InlineFlowBoxPainter::PaintMask() to use the various member fields from the base class. Also straighten out the mask-box-image painting code a bit. Restructure InlineFlowBoxPainter::GetBorderPaintType() to more closely resemble the NG variant. Change-Id: Ia09be7a2c43b31a12e5538364fa0292a2246b291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585088Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#836179}
-
