- 26 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7874beb5c5a1..306f03788f83 2020-10-26 johnchen@chromium.org [Telemetry] Speculative fix for missing win32gui If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1141914 Tbr: zhanliang@google.com Change-Id: Idbf758dd9a58341279d73cabf19efc5ea9a8dca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499412Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820902}
-
Daniel Rubery authored
SafeBrowsingNetworkContexts is ready to roll out to Beta (see cl/337414650), so add a field trial for it. A few tests fail with the feature enabled, so we add a little code to fix those tests as well. Change-Id: I5254a0b632f5319f50d29756a996e69dcd3acc43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477252Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#820901}
-
Victor Hugo Vianna Silva authored
Bug: 1099615 Change-Id: If712d3e7158ead902a6f93ccf85bcb45372a682c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498591 Commit-Queue: Victor Vianna <victorvianna@google.com> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#820900}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d2a3a5b3b4c3..aaea0d98fb64 2020-10-26 johnstiles@google.com Update `nameVariable` to return the variable name directly. 2020-10-26 brianosman@google.com Slight tweak to SkTHashMap natvis support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I210d3a21b9a2f09684a3b8741adea931130dd3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498874Reviewed-by:
-
Jeroen Dhollander authored
This code path was previously not tested. The binary data for this test is committed in crrev.com/i/3324203. Bug: N/A Change-Id: I27c89cce52effc11accf3b4a03822ad2198c6ec9 Tests: browser_tests --gtest_filter=AssistantBrowserTest.* Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461249 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#820898}
-
Philipp Hancke authored
following the pattern from https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/http/tests/streams/transferable/worker.html Also moves the audio/worker test to the worker file BUG=chromium:1058021 Change-Id: I0a49166208aa5cd68a2660abed1ec5e0c52b9b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499521Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#820897}
-
Daniel Rubery authored
On Windows, when downloading the second or later part of a multipart archive, unrar will attempt to open another file. Due to the modifications we place on unrar to work within the sandbox, we don't open the file, but instead use File::hOpenFile as the handle. This is uninitialized memory, which is passed to GetFileType, causing a crash. This CL initializes hOpenFile to fix this problem and adds a test that would have caught the issue. Fixed: 1135503 Change-Id: I6cc83a5a2b5925900cde7b8b2dc8be64f0620d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490334 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#820896}
-
Rainhard Findling authored
* Workaround for crbug.com/1139806. * Writes the CCT scan completion time into a Chrome pref in case Chrome is open when the scan completes. * Uses this timestamp alongside the one from the registry in the Chrome cleaner child of safety check. Bug: 1087263,1139806 Change-Id: Ia3fda6e87058ba76089ce22e8367f41d8e0b8512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484700Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#820895}
-
Dan Harrington authored
There were two problems with these regexes: 1. it didn't support the syntax without curly braces: -checkdiscard @com.Foo class * 2. it ate newlines, which could break rules Change-Id: I667ec65f2e9c8a06c812d62578e700792cf172a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498828 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#820894}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603713364-eb28cdd9672687229cd838b6373ed78fbaa1ba2f.profdata to chrome-mac-master-1603735176-39200681b7df83b17975b9debf912df318fc5920.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia0e8059d7223b60f02ced18b1632c15ac8797d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499419Reviewed-by:
-
Eugene Zemtsov authored
Change-Id: I6ff42f27427b4ba171b7cb345523f4b1b550a8d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495795Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#820892}
-
Victor Hugo Vianna Silva authored
Let's attempt to re-enable the test. Bug: 1111533 Change-Id: If091b686e3ba64395587ec029dbd82df61559466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498691 Commit-Queue: Victor Vianna <victorvianna@google.com> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/902077f931b9..84938ab95122 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC slightlyoff@google.com,avi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1091475 Tbr: slightlyoff@google.com,avi@google.com Change-Id: I25b1cc8a18a150007184cf87604183510a2934eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499413Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820890}
-
Rainhard Findling authored
Bug: 1087263 Change-Id: I22a823fbe7d247fd5723bebddf4de3bb7ee69c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494765Reviewed-by:
-
Olivier Li authored
This helps track whether the HangWatcher is able to periodically wake up fast enough to watch for hangs. Bug: 1135528 Change-Id: I85d3c4896de35351dc2d68482e48f79b0c55d1ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495275Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#820888}
-
Etienne Bergeron authored
This reverts commit b642822f. This CL is causing a shutdown crash. https://bugs.chromium.org/p/chromium/issues/detail?id=1142247 It will be merged back into next canary with the fix. Original change's description: > Move ISpVoice instance to a worker thread > > This CL is moving the speech synthesizer code to a worker thread. > > The TtsPlatformImpl is using an ISpVoice COM interface to perform > text-to-speech actions. The instance was living on the UI Main > Thread which was using STA Apartment. > > This CL is splitting the logic in two parts. The first part is the > control logic which stay on the UI Thread. The second part is the > synthesizer logic which is running on a worker thread. > > Bug: 869399, 1133813 > Change-Id: I8f8d939950cc39637f87d101ed362123a51e985e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462341 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820340} TBR=dmazzoni@chromium.org,fdoray@chromium.org,etienneb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869399 Bug: 1133813 Change-Id: I6249ad2d5d7938e8aa960bbd8d0798f7396513ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499602Reviewed-by:
-
dpapad authored
The latest version makes it possible to import chai.js with a JS module "import" statement. Also: - Fixing a few occurrences where the latest version would throw errors, as it seems stricter into what can be passed into the assert methods. For example passing a string to chai.assert.isAbove() now throws an error. - Making a small local modification depicted in chromium.patch, necessary to run chai.js in d8, which does not gave a window or global object. Bug: 1133198 Change-Id: I1a1503b3503b0f0dc54d537107714421f1865f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498054Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#820886}
-
Toni Barzic authored
Last (only?) usage was removed in CL:2482042 BUG=1137452 Change-Id: I66c9a940c4fd182a99a322fa47eb3a17b0342a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496187Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#820885}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I1fa0fc8f17e983730dc0c7caa68acd7289e1765e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498873Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#820884}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I4f621af798e237210e7ca9c7a1eb787e475a83ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499407Reviewed-by:
-
Bruce Dawson authored
This change fixes bisect-builds.py so that it runs under Python 3 (while still supporting Python 2). The changes are: - Don't import httplib (unsupported but also unused) - Import urllib.request as urllib on Python 3 - Don't use 16L syntax for 16 - Use input instead of raw_input on Python 3 - Convert integer division results to integer - Use is_alive instead of IsAlive - Use except Exception _as_ e instead of a comma The new code needs to use two conditionals with the rest of the fixes still working fine in Python 2. Bug: 941669 Change-Id: I34cd995225233f3f97008c7e07e0537b4683c48f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498954 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#820882}
-
Dominique Fauteux-Chapleau authored
This is a reland of crrev.com/c/2414550 This should not change deep scanning behaviour with Connectors since OnSecurityEventEnterpriseConnector replaces this policy. Removing this policy completely is safe since it was marked as future and it has only been delivered as a cloud policy. Bug: 1103390 Change-Id: I884f8bc059844918e8ef19b9b1ac37c4313d4363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462391Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#820881}
-
Ella Ge authored
Bug: 1098946 Change-Id: I6bc30df96b54c19b4aa3b0e4572e3501af3be750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497991Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#820880}
-
Alexander Alekseev authored
This CL adds a graph of the scanout time per seconds reported in the PresentationFeedback. Screenshot: https://screenshot.googleplex.com/7wZhCV78vtPskdu.png Bug: 1075612 Change-Id: I16a5320532f35bdc3be4baa6e2bb59bd3db632b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463872 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#820879}
-
Alex Gough authored
Input file here does not need to be written. Bug: 1130762 Change-Id: I4f7d3bc0b583ec3c9afe3105ef3a98eb11551e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488703Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#820878}
-
Arthur Eubanks authored
Change-Id: I733621250e2a873a6e8e68bb332355160e7b082d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490544Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/master@{#820877}
-
Joe Downing authored
I've added 'internal_only' and 'platform_only' features to our policies in this CL. This will fix a problem the admin console team is hitting where our policies are showing up in the console but aren't configurable via cloud policy (or aren't applicable outside of Google). While I was making changes, I also fixed some references to other policy names which were missing the '<ph...' tags. Change-Id: Iac11f832b6e17cee0005eb74989a4818ce3f9b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495709Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Joe Downing <joedow@google.com> Cr-Commit-Position: refs/heads/master@{#820876}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ic949342158fc0428cb133c16a793e9460756050e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498875Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I0f672bfccd35367f493642291b15336be0846ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499408Reviewed-by:
-
Lukasz Anforowicz authored
This CL improves the "global-destructor" filtering rule, that excludes from the CheckedPtr rewrite fields that would have resulted in running a custom destructor for a global-scoped variable. Before this CL, this rule would incorrectly handle the following scenarios: *) Only the first matched field in a struct would be filtered (subsequent fields would not be covered) *) Nesting the affected struct in an array would hide the struct from the rule *) Nesting an affected field in a template would hide the field from the rule. After this CL, the scenarios listed above should work correctly. The CL adds extra test cases to cover these scenarios. Bug: 1069567 Change-Id: I1a14e44f49023335554c1c46f10739b4c210538c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492464Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#820873}
-
Daniel Libby authored
Add a couple of crashers missed in the first batch, add Failure for the handful of focus tests that don't pass with the flag turned on, and optimistically mark any seen Timeouts as Slow to see if the a11y code is moving these tests over the threshold. After iteration a handful of tests look like they somewhat consistently timeout and others do occasionally, so marked as such. This gets the bot to green as the set of failures is reduced enough to allow the with/without patch comparison to take place, but further follow up is needed for the remaining failures. Bug: 1138028 Change-Id: I699906828a7384bd129ed23cb22ccddb86cb4e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484326Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#820872}
-
Bo Liu authored
Keep comment code such as creating SkColorSpace or converting parameters in AwDrawFnImpl. Fixed: 1141685 Change-Id: I0c7191b59fffe413259d7ee308eb2f4610424ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495918 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#820871}
-
Dale Curtis authored
This gives VideoTrackRecorderImpl a WebGraphicsContext3DProvider bound to the encoder thread so frames can be retrieved inline before encoding instead of having to hop to the main thread. Local testing shows this is ~10% faster in terms of unit test run time; ~16s to ~14s. To facilitate this change, the existing worker-thread based context creation used by WebGLRenderingContextBase is extracted into a utility class in "blink/renderer/platform/graphics/". Fixed: 1138712 Change-Id: I137f4f6830ac1c7b0860f6c65584a85b276607a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495867 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Shuran Huang authored
Clear window.name in top-level cross-browsing-context-group navigation. Because in those navigations, window.name loses its use purpose (e.g. postMessage and window lookup) but somehow the value still preserves. It's unlikely anyone is relying on the name being preserved. crrev/c/2276250 collects the metric for how often window.name is accessed in such cases and the UMA data proves the change should be low risk. This change is implemented behind a flag. Bug: 1090128 Change-Id: Ib3fd61b8b50f1452af2717e360da21fd2ecaf92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363389 Commit-Queue: Shuran Huang <shuuran@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
-
Nick Harper authored
Change-Id: I8e1a79c0077f86da02425cf796eebb9fbdc6d9f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459527 Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#820868}
-
Dan Harrington authored
This is in preparation for a test to be added in that location. Bug: 1141619 Change-Id: I5731ff84dcc79d81acb3f877ab47c4c6e2acaffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493125Reviewed-by:
Arthur Wang <wuwang@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#820867}
-
Mugdha Lakhani authored
Per code review feedback here: https://chromium-review.googlesource.com/c/chromium/src/+/2470634/comment/fee3ad23_a4607e7f/ the API was introduced for M88 first. Once the API implementation has been cherry-picked to M87, this change will land, supporting it M87 onwards. Bug: 1136091 Change-Id: I9544c97faf807b5c59e9d4113768804e0fad96d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489999 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#820866}
-
Sky Malice authored
This in product help bubble will only be displayed when the home button still points to the new tab page, and has not been overridden. Bug: 1130751 Change-Id: Ie26bdb34112e5ef94d8c3a6419488699dee937d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449932 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#820865}
-
Sebastien Lalancette authored
Moving the existing utility functions in ios/web to the new common folder along with the other utility functions. Bug: 1136043 Change-Id: I6970bce02c72c9794f6574c22816d5c3608364b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494990Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#820864}
-
Lei Zhang authored
Instead of std::unique_ptr<base::Value>. Bug: 1139221 Change-Id: Ie28bd486e0eed75cdb4287c3efd778aceac32f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496034Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#820863}
-
