- 19 Aug, 2020 40 commits
-
-
Kevin McNee authored
These tests crash under android asan. Tbr: asvitkine@chromium.org Bug: 1102747 Change-Id: If26aff18beacc1108e0617b4ba04d66ac3197709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365152Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#799876}
-
Arthur Eubanks authored
Bug: 1114873 Change-Id: Idc828b72f08583ab336c706c1bd8843e076bf573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357457Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799875}
-
Jeff Yoon authored
ios14-beta-sim upstream is failing b/c of bad xcode value. Change-Id: I1572a773f4ce33d76bb536cbe0c39f88e3340693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365294 Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#799874}
-
Nick Burris authored
Add the header icon and progress bar to the secure payment confirmation dialog. Before this patch, the header icon was a property of the model. Since the model lives in //components, but the icon comes from //chrome, it's awkward for the controller to get the icon from the view just to pass a pointer to the model for the view to dereference later. See patch set 3 for what this looks like. Since the icon is specific to the SecurePaymentConfirmationDialogView implementation anyway, this patch removes the icon from the model and keeps the logic local to the view. Bug: 1110322 Change-Id: I8681bc00c4d48d1b98f3c939f920b5ea44f0ff02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358821 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#799873}
-
Michael Tang authored
Change-Id: Id3868d6e9fd854a0c7fd34868101227dd6adb540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363362 Commit-Queue: Michael Tang <tangm@microsoft.com> Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Mike Reed <reed@google.com> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#799872}
-
Monica Basta authored
Screenshot: https://drive.google.com/file/d/1hJB_rmXQ13zfwdMI-we-LoVPlOy9Fspt/view?usp=sharing Bug: 1115056 Change-Id: I324dfca8105e439aeb1d29c2a7a6130b9cf5af1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362753 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799871}
-
Domenic Denicola authored
As part of this, we fix a bug in send-header-page-script.mjs which was not correctly reading the "send-loaded-message" query parameter. In the less-comprehensive tests that were there previously, the buggy code still worked, but these new tests brought out the problem. Bug: 1042415 Change-Id: Id34c627d1d7fdd41727f3db362ada25a6651498f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364172 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#799870}
-
Adam Langley authored
This change plumbs a NetworkContext for WebSocket creation into the |FidoDiscoveryFactory| when caBLEv2 is enabled. BUG=1002262 Change-Id: I0fabe9642c785669c75516207bf4d8f2f8c147e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340389 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#799869}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a64aed23..afdbedf7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9f7803630d49074644892a4dc5ecd12add7e42a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362635Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799868}
-
Karandeep Bhatia authored
in hacker_case. When the type name is in hacker_case, generate HackerCase as the class name instead of Hacker_case. BUG=1113513 Change-Id: Ie94419b088a8c5de9434a2f6bcb962ca0a1a20cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360508 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799867}
-
Claude van der Merwe authored
Bug: 1117619 Change-Id: Ied3c92682a776d83b27e848b7496151fd2618e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364079 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#799866}
-
Henrique Nakashima authored
Failures are not very informative without the stderr output. For example: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8871613511001211808/+/steps/Generate_dependency_graph_data/0/stdout Bug: 1111056 Change-Id: I50142bd4d2c8fa9ee43dea572359c2c331f91186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363699 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#799865}
-
Mark Yacoub authored
When getting displays, if an update for a Drm Display has an invalid connector, do not create a Display Snapshot for it. This prevents attempts to use displays with invalid connectors. Bug: 1105427 Change-Id: Id3422686b019942e924d3e98172394f6caa23eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362442 Commit-Queue: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#799864}
-
Camille Lamy authored
This CL allows reporting browsing context group switches triggered by redirects and updates the reports sent in this case to the latest version of the spec PR (https://github.com/whatwg/html/pull/5518). Since the status of COOP was becoming hard to track, I moved it to its own class for better encapsulation. Bug: 1059303 Change-Id: Ifafb23073301bd05cd9ce83fdb0b748c28e8a51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352880 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#799863}
-
Zhenyao Mo authored
On Windows, if we call swap chain's Present1 with damage rect info, even the damage rect info indicates full damage, the chance of Chrome's back buffer being promoted into an overlays are much lower. If we want to consistently Chrome's BGRA back buffer to an overlay, we have to always call Present which doesn't take damage rect info, indicating full damage. I measured some common use case, and their percentage of frames being promoted to overlays are as below: - Google Meet (5 person, 2x2): 97.8% - wikipedia: 80.5% - a story sharing site: 77.2% - gmail (reading a few emails and then compose one): 61.3% - Google speadsheet: 78.2% - Google photos: 95.5% If we promote a frame to overlay, then we save an extra copy (DWM doesn't need to copy chrome's back buffer into OS's back buffer). If we fail to promote a frame to overlay and it's partial damage, now we use full damage, so at worst we do an extra copy. So as far as we promote more than 50% frames to overlays, there is performance gains. For use cases where performance is critical, like Google Meet, or when we scroll, we get almost 100% promotion, so we get maximum performance gain. Besides, always use full damage simplifies logic quite a bit. The UMA "GPU.DirectComposition.CompositionMode.MainBuffer" will show us if this is a good decision by collecting overlay promotion percentage from the wild. BUG=1117185 TEST=manual R=sunnyps@chromium.org Change-Id: I12d927f472652f17e146debc83e40d9f40a1b950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363771 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#799862}
-
Daniel Libby authored
With cc-based directly composited images, we previously made a decision to not directly composite images if raster scale and aspect ratio resulted in filling in tiles that end up truncated when scaled back up in the display compositor, based on the shared quad state transform. However, because we don't apply directly composited images in cases where we used to, we can end up using more tile memory. The example page from bug 1111621 has over a hundred 1572 x 861 size image layers, but the image is only 16x16. If we don't directly composite, we run into the upper limits of allowed tile memory, and tiles start disappearing (are dropped) on re-draw. Unfortunately, as raster scale can only be expressed as a single scaler value, there no way to have tile size match the intrinsic image size when the aspect ratio of the layer and image are different (the previous approach was able to do this by encoding x and y scales in the layer transform - however, our detection of directly composited images happens later in the pipeline at a time where we cannot alter the structure of the transform property tree). This change removes the restriction (and the associated DCHECK validating it) when the raster scale is less than 0.1, in favor of applying directly composited images to save memory, over the minor changes in rendering that may result. The difference in rendering is that the last row/column of scaled pixels will only be partially filled, and those pixels will be stretched and clipped at the layer bounds. Bug: 1111621 Change-Id: I15b83a9f33df72f40ece087ade3e82a513aa596e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355831Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#799861}
-
Yu Han authored
Prior to this CL, dark mode tests were coded one by one manually. However, there are already a number of tests that test the appearance of form controls. So we should leverage the existing tests to verify form controls dark mode. This CL adds fast/forms/color-scheme to the dark mode virtual TestSuite. The directory has a good coverage for all form controls. To do so requires modifying existing tests to include the <meta name="color-scheme" content="light dark"> so that they support both light and dark mode. In addition, I went through all the rebaselined expected images and mark the ones that doesn't match dark mode spec in the TestExpectation file, along with a bug number. The failed rebaseline images are not include in this CL. The CL also removes the duplicated tests in the dark-color-scheme directory that have been already tested in the fast/form/color-scheme directory. In the follow on CL, I'll work through these failed cases. Bug: 929098 Change-Id: Ic4e6c30c51051a7e5e009c733da9bbe3c6c98c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353091Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#799860}
-
Karandeep Bhatia authored
Platform app resources should never load in a tab. However currently, it's possible for browser initiated navigations to bypass that restriction on redirects. Fix that by adding an explicit check in ExtensionNavigationThrottle to ensure that navigations to platform app resources only succeed in certain cases. Also, add a regression test. BUG=1110551 Change-Id: If11f7f1f9649c8a3f7960cd51d18ef902ac272d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347086 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#799859}
-
Jianhui Dai authored
Set default bitrate according to video resolution Change-Id: I0f00af6b8900af71c27701c7f91c393f63d36b82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347399Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#799858}
-
Marijn Kruisselbrink authored
Renames self.getOriginPrivateDirector() to navigator.storage.getDirectory(), following the changes in https://github.com/WICG/native-file-system/pull/217. Change-Id: Ie993c24b56ffdf369bb87ed03eb786f458e50ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363567 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#799857}
-
Anastasia Helfinstein authored
Switch Access has been experiencing performance issues on moderate to large webpages. A large portion of this is due to the inefficiencies of its traversal of the automation tree, recalculating the same values sometimes hundreds of times for nodes deep in the tree. This change utilizes techniques from dynamic programming to persist intermediate values for continued use, reducing the asymptotic worst- case run time from exponential in the depth of the node to linear in the number of nodes in the subtree. AX-Relnotes: n/a. Bug: 1109970 Change-Id: I61368292f2e731245e4f733c2883b86293d8a74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360340Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#799856}
-
Harkiran Bolaria authored
Add callback to handle specialized behavior when tasks are posted. To be filled with IPC tracking for cached frames in a subsequent Cl. Bug: 1110344 Change-Id: I7a053747082782a0c2f6c44a7b77aeb6f9694d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316781 Commit-Queue: Harkiran Bolaria <hbolaria@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799855}
-
Eric Lawrence authored
Previously, the loader would unconditionally clear the request's Content-Type header upon any redirect. This would cause the value to be lost upon reloading a page that loaded through a HTTP/307 or HTTP/308 redirect that preserved the POST body. Bug: 860546 Change-Id: Id5af5b03a997b8fa185af7ad3245cec5952b3b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363661Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#799854}
-
Justin DeWitt authored
Bug: 1119485 Change-Id: Ic85c4ae86c8bdc287e724f3bf403a7942aa1c337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364023Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#799853}
-
Nela Kaczmarek authored
This change covers the implementation of AffiliationService, the AffiliationFetcherDelegate interface implementation and unit tests. It prefetches data with a help of AffiliationFetcher and provides an API to get change password urls for requested origin. This change includes only preparing data for prefetch without processing the response. Bug: 1108279 Change-Id: I3f47a3b1f7c0b99726b4107d484387a77b1345b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332604 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#799852}
-
Renato Silva authored
PIN auto submit is only available on Chrome OS and the feature should be in the chromeos namespace. Bug: 1075994 Change-Id: Idd199abb2baf6ac88d10762e22735fe42d46e656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362965 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#799851}
-
Lei Zhang authored
Remove deprecated macro usage and use explicit deletions instead. Also remove some unnecessary includes for base/macros.h. Bug: 1010217 Change-Id: I8d1e4d03e93933262f184b7802de4ef1b94ab1e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363630Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#799850}
-
Leonid Baraz authored
Bug: b:153364303 Change-Id: Idb13d9993a6301cda0ca7514a7c0fc457c7e90a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364060Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#799849}
-
Dylan Cutler authored
Bug: 973801 Change-Id: Ie2de8e36520d28ea0063ab6c54695786eb1de5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353028 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#799848}
-
Brian Malcolm authored
This is intended to replace the NativePrintersBulkWhitelist policy. The old policy will still be used in the absence of the new one for at least a few releases of Chrome. BUG=chromium:1098047 Change-Id: Ib863ff1f2244dcd832826883c0dfa7f167865908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342049 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#799847}
-
Yicheng Li authored
If the submitted password looks like PIN, try authenticate the user with PIN. On failure, submit the password as normal password. This fallback to password auth is because the user may type the PIN into the password textfield (though admittedly this is a less valid use case). This behavior is consistent with ScreenLocker. Bug: b:156258540 Change-Id: I23bf097a35c6458e8f341ae105679d6d42a83c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364756Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#799846}
-
Tomasz Wiszkowski authored
This change allows Search-Ready Omnibox to be shown on SRP effectively removing the need to manually clear the Omnibox field ahead of typing in new search query. Bug: 1118222 Change-Id: Ie36029b38ed54bb63de1db66eef9457dec6d86ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364048 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#799845}
-
Evan Stade authored
Bug: 738196 Change-Id: Ibc6ab965ba80cbc76f7e89230da7c20bf7dc9392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364957Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#799844}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. Bug: 1110266 Change-Id: I5aedb1ceaad41242f4a51d450704027dcb0c046e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352022 Commit-Queue: Sean McAllister <smcallis@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#799843}
-
Michael Bai authored
Record the task delay to see how often the short delay is triggered. Bug: 1114819 Change-Id: Ia1368fd354dea1af196b6f5ff14f7d073b73da9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363557 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#799842}
-
Evan Stade authored
Bug: 1057100 Change-Id: I57cff2406fa4d11420dbbb3e450dc189f5dd97a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364740 Commit-Queue: Evan Stade <estade@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#799841}
-
Yi Chou authored
Add ordinal value in the mojom would increase the compatibility between different builds. Change-Id: I88c455f092035ffd0d9b6164e83babf39957fb61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319088Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: joe Chou <yich@google.com> Cr-Commit-Position: refs/heads/master@{#799840}
-
Chong Gu authored
Adds ~5 mins of runtime and bot time per build. Bug: 1058255 Change-Id: If3bea9834a4c2894fe333d57b19dba68451f8d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364061 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#799839}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008190800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/2mC2HAs3wr9lkv-fO7paccSOBACAv2EXtzFGg-sY7ukC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/162466284,b/163420424 Tbr: help-app@grotations.appspotmail.com Change-Id: Ifded1470451b18602cb561f452fa5368a2037899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362979Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799838}
-
James Hawkins authored
This reverts commit e2c7dc67. This relands the below change after fixes to the underlying components to support unoptimized builds. cr_components/network: Convert NetworkListItem to Polymer 3. Also convert the types in NetworkListTypes as well since they are trivial and NetworkListItem depends on them. Bug: 1045266 Test: NetworkNetworkListItem* Change-Id: Ic607a49efa874fde2bf18459dc9a351db6fd49f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364815Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#799837}
-