- 22 Dec, 2020 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1e69d7961394..c463a784c340 2020-12-22 henrikg@webrtc.org Clarification of RtpPacket constructor in comment. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I17084af412a7ec5ef4cb865b923dc2cc114640dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601192Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838968}
-
Zach Trudo authored
This reverts commit 7447e48c. Reason for revert: Causing issues server side. Original change's description: > Switch all IDs from unsigned to signed. > > The purpose is to eliminate incompatibilities with server side > code - written in Java - which caused overflows when treating > large unsigned numbers as negative signed ones. > > Change in Proto will be reproduced in server code too, but there > is no need to synchronize the two - uint and int in proto are compatible, > as long as the numbers are not outside the limits. > > Bug: b:174509632 > Change-Id: I996177f2580949a00a35ddc9e83ca18fdecc87e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596820 > Reviewed-by: Zach Trudo <zatrudo@google.com> > Commit-Queue: Leonid Baraz <lbaraz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838140} TBR=chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,zatrudo@google.com,lbaraz@chromium.org Bug: b:174509632 Change-Id: I1b890e34566d46ada8dda5b4d2acfeff0979dd6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599925Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#838967}
-
Charlie Hu authored
This CL adds feature SyncXHR to document policy. It will be controlled by both document policy and feature policy during the migration period, i.e. If either policy disabled the feature, the feature will be disabled. Bug: 1146505 Change-Id: I2a2d776da13be9f659bc0369fb5a19a94f5c18ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523440Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#838966}
-
Jinsuk Kim authored
This CL fixes wrong theme color bugs still left in the toolbar. 1) There are situations when WebContents theme color hasn't changed but we still need to check if the overall top UI theme can change. For this, TabThemeColorHelper invokes TabObserver#onDidChangeThemeColor with either the current tab theme or the one from WebContents accordingly. 2) When in tab switcher, location bar model's |mPrimaryColor| should be updated when going back and forth between normal/incognito tab model. Added a new line doing this, since this is not automatically done the after the toolbar theme refactoring. Bug: 1157417, 1157433 Change-Id: Ib648d4ce10f6589eae54742631fc083edf0119f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599678 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#838965}
-
Carlos IL authored
Bug: 1158636 Change-Id: I8d654ac690fbdc2da3212cacdc3e36018e5dede5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590665 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#838964}
-
Nasko Oskov authored
When RenderFrameHostImpl::OnCrossDocumentCommitProcessed was removed in r830950, the only assignment of the navigation_request_ member was removed as well. Given that it is never written, it is unused and can be safely removed. Bug: 1020175 Change-Id: Ie8d0afce182a35df7269915936db90da8adf4b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601179 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#838963}
-
Andrew Grieve authored
This reverts commit 90c1d6e9. Reason for revert: Should not add detectCleartextNetwork() Original change's description: > Android: Disable detectUntaggedSockets StrictMode check. > > We don't tag our sockets, and this caused logspam on start-up. > > Bug: 770792 > Change-Id: I23cc6494a7a3e61bcb8be761c877bf4a0345f921 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600033 > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838953} TBR=agrieve@chromium.org,pkotwicz@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I2e90528bbd41c580e647cb17e65efa4900f900f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 770792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600035Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#838962}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/37a217750180..e1ecd9b7c6ef 2020-12-22 janscheffler@chromium.org [Recorder] Clean up state after recording is done If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I928089812b312859114891d40cbf886a72d90572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601182Reviewed-by:
-
Jacques Newman authored
If the render-side tree was initialized with a root with an id != 1, the first update won't match the tree created on the browser process by CreateEmptyDocument. In this case, the update won't be able to set the right node_id_to_clear to the correct root. This will cause the "new" tree to be treated as an update, and a reparent. To mitigate this, if node_id_to_clear was set and the update's root_id doesn't match the old_root_id, we can assume that the update meant to replace the root. Bug: 1131848 Change-Id: Ia84c5a893a7b4846e0d81255455244171ec1d3d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598724 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#838960}
-
Thomas Lukaszewicz authored
This CL sets the kTabSearch flag to be enabled by default on ChromeOS and leaves it disabled by default on the remaining desktop platforms (Linux, Mac, Windows). This is part of the required launch cleanup for the ChromeOS Tab Search experiment. Launch config CL: https://critique-ng.corp.google.com/cl/347894919 Bug: 1116182 Change-Id: I4de20453851b095a62c099a02c8dcebfb26ca00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596029 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#838959}
-
Nohemi Fernandez authored
Currently, Chrome strictly enforces that the fake Sync server is running to call |ClearSyncServerData|. This may be causing intermittent issues in EarlGrey tests if service startup is in an inconsistent state. This patch makes the test suites more flexible by allowing the inconsistent state, and changing a failure for a no-op case. Bug: 11530874 Change-Id: I4f20dc0c282d1b09ad54d43ab32dd10f54a2d42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600741 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#838958}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e38beddbbf8a..735ac97eb4dc 2020-12-22 fmalita@chromium.org [svg] Relative postioning support for text 2020-12-22 brianosman@google.com SkSL: Add $squareMat and $squareHMat 2020-12-22 johnstiles@google.com Add SkSpan support to the Skia LLDB visualizer. 2020-12-22 brianosman@google.com Add .rte -> .skvm unit test framework 2020-12-22 johnstiles@google.com Test that the inliner uses a temp var for return statements. 2020-12-22 brianosman@google.com Add SkVM output to skslc 2020-12-22 johnstiles@google.com Revert "Add support for range-based for loops to SkTHashSet/Map." 2020-12-22 johnstiles@google.com Add support for range-based for loops to SkTHashSet/Map. 2020-12-22 johnstiles@google.com Fix for fuzzer-discovered crash with swizzles. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: I7704689abb6138a0c9f9b287858d610df6522d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599611Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Id29841fec1482659271c9693c334960dc0a5f583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601222Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838956}
-
danakj authored
Tests that want to talk to the RenderFrame via the mojom interfaces to it should create that RenderFrame by doing a navigation before attempting to use the mojo connections. Otherwise they are talking to nothing, and it will be a null mojo connection once the mojo binding is set up with the CreateFrame or CreateRenderView IPCs. R=nasko@chromium.org TBR=jam Bug: 1158869 Change-Id: I349d21222ae4a6aa79795ba2dc409cb39fc0d2e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600378 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#838955}
-
Mark Yacoub authored
This reverts commit d508d81e. Reason for revert: DRM Window checks if buffer's modifier is bad, but we don't have control over videos/canvas/exo clients. Original change's description: > Reland "Fallback to Linear Modifiers if Preferred Modifiers fail." > > This is a reland of 631cb004 > Original CL has been reverted due to SkiaRenderer not handling recreating buffers. > The fix has been merged (crrev.com/c/2581693), so this should be good to reland again. > > Original change's description: > > Fallback to Linear Modifiers if Preferred Modifiers fail. > > > > Test-Modeset with preferred modifiers. > > If it the test passes, save the preferred modifiers to use for full modeset. > > If it fails, try testing with linear modifiers for every controller. > > Use empty modifiers list if the platform doesn't support preferred modifiers list. > > > > This enables us to launch Intel Rendering Buffer Compression. > > http://go/cros-intelrbc > > > > BUG=979736,1082882 > > > > TEST: RBC enabled on (4K eDP with 4K external) and (4K eDP and 2 external monitors), zork, and nautilus > > Change-Id: I7698d2cc9f13e5293eb0f6579dee775314988037 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567263 > > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > > Commit-Queue: Mark Yacoub <markyacoub@google.com> > > Cr-Commit-Position: refs/heads/master@{#834389} > > Bug: 979736 > Bug: 1082882 > Change-Id: I90a4c93c5318da9ba252d126629c99173895e6f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585813 > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Auto-Submit: Mark Yacoub <markyacoub@google.com> > Cr-Commit-Position: refs/heads/master@{#836824} TBR=dnicoara@chromium.org,dcastagna@chromium.org,markyacoub@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Bug: 1160958 Change-Id: Ie2240a9923d4abf81e61ad37dc305590fd6d6d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599950Reviewed-by:
Mark Yacoub <markyacoub@google.com> Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#838954}
-
Andrew Grieve authored
We don't tag our sockets, and this caused logspam on start-up. Bug: 770792 Change-Id: I23cc6494a7a3e61bcb8be761c877bf4a0345f921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600033Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#838953}
-
Lan Wei authored
html/cross-origin-opener-policy/popup-coop-by-sw-from-coop.https.html is flaky on MAC bots Mac10.15 Tests. TBR=arthursonzogni@chromium.org Bug: 1161244 Change-Id: I38019fbcd9799024fe6c9046e2346681a09cc28e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600030Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#838952}
-
cfredric authored
There's only one callsite of this method, and it initializes an empty vector to use as the out parameter. So, there's no reason not to simply use a regular return value (which is recommended by https://google.github.io/styleguide/cppguide.html#Inputs_and_Outputs). Change-Id: I4da52979ac54b75a38e5a2a7e0ac1ddc965ad312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601196 Auto-Submit: Chris Fredrickson <cfredric@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#838951}
-
Theresa Wellington authored
This test is flaky on test-n-phone. Previously disabled on L-, extending to be disabled on N-. BUG=1160911 TBR=wychen@chromium.org Change-Id: Ieba7ad5ad3e19be68bd4e7d9b5e9058f29457e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601186Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608638224-e418c5410d3b3bca608d3b6e0eb382be2260db19.profdata to chrome-mac-master-1608659974-90bda9b569e2cfcf8d7da1dcfbdd3d98c384729b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3638313e12eb2dd311af8a9e26d52672f7d9158e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599609Reviewed-by:
-
Danan S authored
Previously we were only doing this when running the flow from a local workstation. However, it appears that the "continue" URL parameter on accounts.google.com isn't working. It's not yet clear if this is a recently changed behavior, or if it never worked. In the meantime, this fixes the issue with the flow not being able to complete on the production servers because of the non-functional continue URL parameter. Bug: 1160168 Change-Id: Ide9b02d3eca7061fa86803eaf0a74cf6dbe391ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597074Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#838948}
-
Regan Hsu authored
Instead of displaying the PhoneHub UI in the middle of the screen when shelf position is right/left, it is now displayed on the bottom. Screenshots: Left shelf - https://screenshot.googleplex.com/5LBcDUSEWY5vER6 Right shelf - https://screenshot.googleplex.com/4AboKZpVjH89tMS Bottom shelf - https://screenshot.googleplex.com/iumxiW5ohmL9L7w Fixed: 1159098 Bug: 1106937 Change-Id: Ie715e0f61b46bce469e5aa661e43ac46680d8138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600626Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#838947}
-
Sophie Chang authored
This is a reland of 3132a551 Original change's description: > Fix sequence checker dcheck assumptions for optimization guide filters > > The bloom filter and optimization filter can get destructed on > background thread when a new component comes in after initial load > > Bug: 1160660 > Change-Id: Ia1dd5925d7513391148b677fb3e75b818a9fa190 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600040 > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838729} Bug: 1160660, 1161052 Change-Id: Ib067c2a288b0953653be514f8cf8b414ea5c7d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600375Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#838946}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/41d78ae1003b..85707f7f7524 2020-12-22 syoussefi@chromium.org Vulkan: Pass in SPIR-V transform options in a struct If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Id1fe61ce8bbf657cdae99dc8ee7dc17de17b9519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598144Reviewed-by:
-
Alex Ilin authored
Only one avatar can be chosen at the time. The "radio" aria role clearly conveys to assistive techologies users what's the purpose of avatar buttons. aria-checked attribute indicates which avatar is currently chosen. Bug: 1032074 Change-Id: Ia414fca677213796030e0fee32b700660e640c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599802 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#838944}
-
Lan Wei authored
AppControllerPlatformAppBrowserTest.PlatformAppReopenWithWindows is flaky on MAC bots Mac10.15 Tests. TBR=zmin@chromium.org Bug: 1161270 Change-Id: I8fbdf20aad3843042a43bed03c1c53d35fe00034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600032Reviewed-by:
-
Mark Schillaci authored
This CL is an follow-up to: crrev.com/c/2552897 In this CL we add on to the event suppression logic for events of TYPE_WINDOW_CONTENT_CHANGED type on Android. With this CL we move the logic into web_contents_accessibility_android, and we add unit tests. We include a VisibleForTesting method in WebContentsAccessibilityImpl that allows us to change the suppression threshold as needed. AX-Relnotes: N/A Change-Id: Iba5f332ddc4d0a9889f188d7f2a9583bec144ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575422Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8d43e589947e..6a13cf40462d 2020-12-22 johnchen@chromium.org [devil] Add debugging output after APK install If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1156424 Tbr: wenbinzhang@google.com Change-Id: Ic94ce6fe90f742aaafb67b86db141995ab6fb3de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598149Reviewed-by:
-
Jeremy Roman authored
While here, use QuitClosure as a more concise way of calling RunLoop::Quit. No functional change intended. Bug: 1007635 Change-Id: I25de4378122baa59fdab936b1602656533063106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600025 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#838940}
-
Regan Hsu authored
If the device has no bluetooth_public_address(), phonehub becomes kNotSupportedByPhone. Fixed: 1158592 Bug: 1106937 Change-Id: Ifaf86e3272a6bcbe2b5304cc71759afb1b2c6740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598472Reviewed-by:
-
Mason Freed authored
No functional change here - just put the DOM tests into the DOM build file. Change-Id: I693f91cbba92d13d77046bdbc4a187b5a09e8c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600875Reviewed-by:
Yu Han <yuzhehan@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#838938}
-
Lan Wei authored
This reverts commit 39716b26. Reason for revert: After you landed your CL, bot linux-chromeos-dbg starts to fail from Build 21797. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/21797 Original change's description: > Refactor intent usage in ChromeVox > > This is a purely refactoring change to set up ChromeVox to use all > possible intents. IntentHandler, the newly introduced class, will > cleanly process all intents, along with whatever computed metadata is > needed (e.g. EditableLine). > > R=akihiroota@chromium.org, nektar@chromium.org > > AX-Relnotes: n/a > Test: existing browser_tests --gtest_filter=ChromeVoxEditing*.* > Change-Id: I74d9454794fc6a40075bbf56fb0037b607c2b974 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594240 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Akihiro Ota <akihiroota@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838241} TBR=dtseng@chromium.org,nektar@chromium.org,akihiroota@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I529c305dc792d9adb11d7eb1ac9f226e671fadbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601124Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608638224-d3f9b1db478b88c5a6d481d4f845515a5433a7bc.profdata to chrome-linux-master-1608659974-f24a1edbf2ebfb03ebc2935c99ccb8534f3f4c71.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie2badfa2d442463559372107af44bd00660a405e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599608Reviewed-by:
-
Andrew Grieve authored
Now that android-binary-size trybot measures trichrome, it makes sense to do the same for diagnose_bloat.py. Bug: None Change-Id: Ica8257b06911769b5c0ccc6d057d43620f70c169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601058 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#838935}
-
Alex Ilin authored
Prerequisites: - kNewProfilePicker feature picker is enabled - Force sign-in enterprise policy is enabled This CL fixes two bugs triggered when the add profile button is clicked from the profile menu: 1. Adds missing `break` statements in a switch block in c/b/r/signin/profile_picker/navigation_behavior.js 2. Displays the main profile picker view under the force sign-in dialog Bug: 1156096 Change-Id: I09e32df1414bce750e57011cbf45e40cb08c451d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599811 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#838934}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e6d3eb310017..1e69d7961394 2020-12-22 nisse@webrtc.org Include configured mid and rid when logging AudioSendStream config If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2e3a1a33051970e7d901e4da9d0be9b9a6c89167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598147Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/afcef3ee9043..03d0309255ea 2020-12-22 jiawei.shao@intel.com Vulkan: Fix a typo in SwapChainVk.cpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I4a0180c2bc8fedf1bbdc35e8a0d6ad5b9ef5a6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600458Reviewed-by:
-
Stefan Zager authored
This is a speculative bug fix, based on the hypothesis that allowing lifecycle updates for throttled frames that require IntersectionObserver to proceed through compositing assignments may be the problem. During compositing assignments phase GraphicsLayerUpdater may call ScrollingCoordinator::UpdateCompositorScrollOffset, which may somehow interfere with the ongoing scroll fling. It does not appear to be necessary for lifecycle updates to proceed through compositing assignments in this case. The justification for going through compositing assignment was that up-to-date sticky positioning may be required; but it appears that compositing inputs update (pre-CAP) or pre-paint (CAP) is sufficient for that. Bug: 1158664 Change-Id: I456421fc0886abe254462d5099e446d87290c960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599002Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#838931}
-
Andrew Grieve authored
Bug: None Change-Id: Ia3842ab699f51313a2e9e34654cfeb3f902811f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600027 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Allen Bauer authored
Bug: 1159116 Change-Id: I6a91ae027db7338b3b26c1d8a7af286490d8e748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594176 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#838929}
-
