GitLab

Bug: 941690
Change-Id: I45e8c531f63a7634ed77946032a3dd0fb10680be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595977Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657517}

Task IDs are metadata for tracking navigations and relationships between
navigations. They are stored on a NavigationEntry and the bookkeeping
happens via reading signals via NavigationEntryCommitted.

Bug: 958463
Change-Id: If97ae09ac7743ca37ce81bbe401a95e6eeaff5a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592516Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657516}

This relands commit 65046b8f,
plus an additional change:

Older versions of Bionic seems to use vfork() in their system()
implementations, so just EPERM it instead of crashing with SIGSYS.

Bug: 956644
Change-Id: Ibd84ca0a9c49cad3ba797a2632960f3978111c65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585108
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657515}

OobeScreenExitWaiter is intended to handle the case where the target
screen is the last screen, and oobe UI goes away when the target screen
exits.
To trully support this, the waiter should handle the case where the oobe
UI has already gone away when the waiter is started.

Change-Id: I9e8a56cc7a53560fa6a89748fbe9806d1a6b53d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598480Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657514}

This CL does several positive things:
 - allows us to have changes include non-basic types by removing the
   use of a C union in the Delta class
 - in lieu of std::variant, makes access to each type of change runtime
   type-safe via DCHECK()
 - make all changes single items rather than lists of (implicitly)
   homogeneous deltas

Each delta may affect multiple tabs, but only (currently) in the case
of multiple insert and multiple remove; we also make the fact that
there can be more than one page inserted or removed explicit.

Bug: 958103
Change-Id: If6b4291ab05857830b94d596d664653f128d1368
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576276Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657513}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b58501a3b11b..7978f9cb6d33


Created with:
  gclient setdep -r src-internal@7978f9cb6d33

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=nhiroki@chromium.org,iclelland@chromium.org,dullweber@chromium.org,jrummell@chromium.org

Change-Id: I8ca3b52a67fcc1f1a62dd678126efc08c8641d74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598501Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657512}

This is part 1 of n for cleaning up shared_ptr. The first set of patches
is to remove all functionality from RemoteDeviceRef, so it can
eventually be removed.

The log truncation helper remains for now; that will be solved by the
second CL.

R=khorimoto@chromium.org

Bug: 960538
Change-Id: I7dd5f5137411c2cfaeed8492d03fea06fba5a648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600495Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657511}

Specifically removing:
 - is="custom-style" attributes
 - :unresolved pseudo-selector
 - stopPropagation() calls
 - unnecessary calls to the deprecated Polymer.dom() wrapper API.

Bug: 944281
Change-Id: I38450dfff1c1f5cb5b5ccf238163a90e0f1ad22f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600272
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657510}

Create a separate SourceLanguageComboboxModel to add "Unknown" option to combobox dropdown menu. "Unknown" is selected by default when source language is undetected or unavailable.
Bug: 721600

Change-Id: I55228eea20be7ba1d361f5651400411f4e58d977
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597275
Commit-Queue: Haohao Wang <hhw@google.com>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657509}

https://skia.googlesource.com/skia.git/+log/056944747072..51e15a69ce5b


git log 056944747072..51e15a69ce5b --date=short --no-merges --format='%ad %ae %s'
2019-05-07 bungeman@google.com Use SkTextEncoding enum instead of macros.
2019-05-07 ethannicholas@google.com fixed SkSL interpreter negate op
2019-05-07 robertphillips@google.com Loosen up checks in DDLSkSurfaceFlush
2019-05-07 herb@google.com Cleaup GrTextStrike and GrStrikeCache
2019-05-07 ethannicholas@google.com fixed SkSL interpreter test
2019-05-07 robertphillips@google.com Add test for DDLs and SkSurface::flush
2019-05-07 bungeman@google.com Mac slight hinting to be normal instead of none.
2019-05-07 chinmaygarde@google.com Allow building Skia with Fuchsia SDK enabled buildroots.


Created with:
  gclient setdep -r src/third_party/skia@51e15a69ce5b

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:958055
TBR=robertphillips@chromium.org

Change-Id: I583bd25bc018db0e0d33fca7908196dc9d7263e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599905Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657508}

Refactors the search for the most specific host suffix for a host
from HintCache to HintCacheStore. Allows the store to prioritize
fetched hints at any length of host suffix before component hints.

UMA histogram and browser test for loading/using hints in future CL.

Bug: 932707
Change-Id: I2dd8499d58947cb320c26592338783d30acd13c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594068
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Auto-Submit: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657507}

Change-Id: Idae31e1c71a7082df83194ea315d7897309a7ec1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595126
Auto-Submit: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657506}

No tests are using this code anymore, so it can be removed.

BUG=960503
TEST=test only changes

Change-Id: I88f85436ae8f386562a15a404d042c5360b3a5b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600074Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657505}

R=drubery

Bug: 907280, 954255
Change-Id: I85988c522fdc73ceb52e5480816b24827615cdca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595561Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657504}

Bug: 925584, 893460
Change-Id: If3da3b316d2e60a36895301b45c165dd576a523f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593360
Commit-Queue: Richard Townsend <richard.townsend@arm.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657503}

This change creates four new tests around WebXR gamepad support, by
registering a new controller with the runtime with varying buttons and
setting up state that can be queried on those buttons.
As a result, some refactoring of the existing controller mock was
needed.

The four tests that this adds are:
1) Add a controller without enough data to be considered for an
xr-standard mapping, and ensure that no gamepad is present on the input
source.
2) Add a controller with only the required data to be considered for
xr-standard and validate changes on those buttons.
3) Add a controller with all named/reserved xr-standard buttons and
validate changes on those buttons.
4) Add a controller with an extra button not specified in xr-standard,
but missing some reserved buttons, to ensure that reserved buttons are
reserved.

Bug: 956138
Change-Id: Icdd590bc02d64f773912f845a4861672db1e91fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597637
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657502}

UI surfaces like the Bluetooth pairing dialog are "native OS UI"
and should not follow the browser's page zoom setting. They should
behave like app list, status area, etc. and stay at 100%.

Bug: 955071
Test: added to browser_tests
Change-Id: I016d4fe76ab1e08b453ff1a46e39b79607e4ec8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600392
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657501}

The CL has no intentional behavior changes.

BUG=958404

Change-Id: I8ea619bc47e4ef56cc1b62f713e92bae5ed56b68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597510Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657500}

ThemeService itself references NativeTheme to get some of its colors.
If a control only overrides OnThemeChanged without listening to
OnNativeThemeChanged, it might miss a color update.

This CL makes an additional subtle change:
 - Previously, OnNativeThemeChanged passed as the parameter the
   platform-native NativeTheme (ignoring Incognito) for Windows and
   Mac. This was different from GetNativeTheme() which would return
   NativeThemeDarkAura in this case.
 - Now no parameter is passed, and Views just always use
   GetNativeTheme().
 - I think this is better long term, as the distinction was super
   subtle and likely misused previously.

Bug: 958518
Change-Id: I71528e023be7bed2ae9c1f365b011922b944d8f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592037Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657499}

The action button row should take up a fixed size
when it is collapsed. This prevents the buttons moving
around when the title is different lengths.

BUG=960500

Change-Id: I5e96312e6c01289231c9054c6572dbc501aa293c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600352
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657498}

In the off-thread paint worklet case, the drawing operations are captured
in the DrawImageRectOp::RasterWithFlags. While in the main thread paint
worklet, the drawing operations are in the PaintGeneratedImage::Draw,
this CL makes the operations in the DrawImageRectOp::RasterWithFlags
match the operations in the PaintGeneratedImage::Draw.

This change makes 64 off-thread paint worklet layout tests pass.

Bug: 957459
Change-Id: Ie33b32c9f1a15a2cec3886c66486bae147100015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596176Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657497}

Shows the edge glow effect when further forward navigation is not
possible. There are three cases to consider: native pages, rendered
pages, and tab switcher:

- Native pages: uses android.widget.EdgeEffect (GlowView)
- Rendered pages: uses ui::OverscrollGlow on cc::Layer of WebContents'
  native view
- Tab switcher: also ui::OverscrollGlow on cc::Layer of StackLayout's
  SceneLayer

All the logic is behind a new class NavigationGlow.

Bug: 937946
Change-Id: I7771a23ae861188a40388659baa784111e58140d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583169Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657496}

When hit-testing a scrollbar, ScrollbarController::HandleMouseDown
applies a static_cast on the returned layer. For standard scrollbars,
the layer returned is PaintedScrollbarLayerImpl where as for custom
scrollbars, PictureLayerImpl is returned and everything was getting
casted to ScrollbarLayerImplBase. This would then return true for
the is_scrollbar check and fail later on. The fix here would be to
avoid using static_cast and instead, use LayerImpl::ToScrollbarLayer().

Bug: 960521
Change-Id: I2fd6e7e6d239c7293ad7af3d73875fb758e803fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598843Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#657495}

Change-Id: If8661f2b6266e5aa117d20006e19d4af217697a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594347
Commit-Queue: Nick Harper <nharper@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657494}

Add param to FindBrowserWithTabbedOrAnyType that controls whether
to match the current desktop/workspace. Matching current desktop can
be expensive, so only do it when called from FindTabbedBrowser, which
is used when loading a url in a running instance of Chrome.

Bug: 959356
Change-Id: I9fc165c7df751c807483fc7dac0cb62f13a5802b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597628Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657493}

Exposes the utility functions used for stack copying and adds unit tests.

Bug: 956626
Change-Id: I51f7871c820319469e00acf92a6e1fa6a8b993e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593802
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657492}

The issue referenced in the bug is due to the checkbox sending the
changed event when the space key is pressed. The action menu is closed
and when the space key is released, the action menu button is activated.

Making the cr-checkbox similar to <button> and cr-icon-button by
only handling the space key being released fixes this issue.

Bug: 956497
Change-Id: I9eff478f4b7824d76d35e9c8507ea3d036844ed8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592219
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657491}

This moves UserCloudPolicyManagerTest to use mixin infrastructure to
set up test environment. This significantly reduces the inheritance
chain for these tests (to UserCloudPolicyManagerTest >
MixinBasedInProcessBrowserTest > InProcessBrowserTest), and makes the
test logic more trackable.

BUG=None

Change-Id: I60000a23c3b0d72cbe18fc101b48b96d09c3f603
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597174
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657490}

Move OpenInNewWindow option below in context menu in NTP page

BUG=958568

Change-Id: I8c06789632e4aa492b3b2169e20c5398ae12f561
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599593Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#657489}

This class was introduced for Mus/Mash to synchronize the gesture
state among ash and the client. So far no other users come up,
so simply remove them all would make sense as we are going to
remove mus.

Bug: 959385
Test: build passes
Change-Id: Icd55cd9dd67392c1f2d6c9bfa3aeffab4729860c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598836Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657488}

Use enum class instead of enum for FrameButton
enum class is more type safety.

Bug: 940736
Change-Id: Ia38577965244d65a5f08c76c7ea257343d4c4762
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597511
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657487}

It was just using net::UnescapeURLComponent(), which both has some
behaviors not suitable for this purpose (Like deliberately leaving some
characters we can't safely display to the user, like locks and \x01,
escaped).  Also, net::GetSuggestedFilename() is specifically designed
for this purpose, and has some behaviors that are desireable here
(Like replacing characters that shouldn't appear in file names, and
trimming whitespace).

It turns out that most usages of UnescapeURLComponent() are wrong, and
this CL is part of an effort to fix that.

Bug: 849998
Change-Id: Ib98e178e7f7cc002e49986026a6799b7c581caa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596362
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657486}

https://swiftshader.googlesource.com/SwiftShader.git/+log/c958b17184e6..52a3bba8914f


git log c958b17184e6..52a3bba8914f --date=short --no-merges --format='%ad %ae %s'
2019-05-07 chrisforbes@google.com Add support for Sample image operand in OpImageRead


Created with:
  gclient setdep -r src/third_party/swiftshader@52a3bba8914f

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/131171141
TBR=swiftshader-team+autoroll@chromium.org

Change-Id: I33c7f7fdfd56a8894ca97ae8130580810a650647
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599994Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657485}

Also updates third_party/microsoft_webauthn to a version that supports
credProtect.

Bug: 941120
Change-Id: I8e0fb6fd72bad6927ec7d1121c1a58888fb7ba3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599771
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657484}

If enable surface synchronization is disabled and the frame is
visible then DelegatedFrameHostAndroid::EvictDelegatedFrame()
will only reset content_layer_ to null but not evict the
surface as that causes https://crbug.com/933374.

Trouble is that if the frame is then hidden without any new
content_layer being created the next call to
DelegatedFrameHostAndroid::EvictDelegatedFrame() will do nothing
as content_layer_ is null but the frame is still in the list of
unlocked frames in FrameEvicitionManager causing the next
call to FrameEvictionManager::CullUnlockedFrames that tries to evict
the frame to do nothing and loop forever (or hit a DCHECK if those
are enabled).

Fix this by not doing early exit if content_layer_ is null as this
is not directly connected to if there is a frame to evict.

Bug: 959914
Change-Id: I3f83036d9a5ae2c734dfca720115d1faf4278c87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596571Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Joel Klinghed <the_jk@opera.com>
Cr-Commit-Position: refs/heads/master@{#657483}

An error message is displayed when user requests a factory reset and
the reset fails. The error screen shows a button that returns the user
to the OOBE flow when clicked.

This CL fixes the user action event sent to the C++ handlers. The
previous event we were sending no longer has any handlers.

This CL also modifies existing tests to verify that the event is being
handled.

Change-Id: I2871ba19283325fc7535cd107d3d27719e8a18be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598090Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Tony De Luna <tonydeluna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657482}

The experiment flag will be enabled only on Mac/Windows/Linux.

Summary of changes:
1) Add manage passwords icon only in new container if experiment is
enabled.
2) Change the bubble anchor point to the new container instead of
location bar when experiment is enabled.
3) Add some browser tests to cover experiment flow.

Bug: 932818
Change-Id: Iaf600b56bb1f84b026ea17d43588095b7d38a49e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597471
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657481}

It was using UnescapeURLComponent(), which leaves certain characters
escaped ("%00" through "%1F", and certain UTF-8 sequences which are
unsafe to display in the omnibox, like lock icons and 0-width spaces).
This behavior is generally not useful in most contexts - it's almost
always better to fail on bad input than to use partially unescaped
strings, and the UTF-8 logic isn't useful here.
UnescapeBinaryURLComponent(), on the other hand, unescapes input
unconditionally.

This CL is part of a project to clean up uses of
UnescapeURLComponent(), as it's been used for wildly disparate
purposes, and much of its logic is only suitable for cases where
we want to format a URL for safe display to the user. We want
to make it leave more weird characters escaped, but need to
eliminate usage of it in other contexts before we can do that.

UnescapeBinaryURLComponent() should be used instead in most cases,
particularly where URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS is in use,
as all consumers of that option seem to either be slightly buggy, or
don't actually need to leave any characters unescaped. The primary
cases where switching to UnescapeBinaryURLComponent() may cause
problems (without additional checks), are cases where unescaping
path separators or funky characters (like %01) is a problem. In those
places, we should generally fail instead of partially unescaping a URL.

Bug: 959213
Change-Id: I88cd0aff55c7a5cefd5224d011562810d7c3d150
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598785Reviewed-by: Yue Li <updowndota@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657480}

Ensure destination settings and the preview area monitor for destination
errors that occur in the other element.

Bug: 959779
Change-Id: I944ef8c200375ad4b03a266baa275815f46a57f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598314Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657479}

The new code 99 means libcurl returns an internal error code when
sending HTTP request and could not get an HTTP response code.

BUG=chromium:927039
TEST=None

Change-Id: Iba5d9815e2d1eca849074baf3bdda42416b8431d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566150
Auto-Submit: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Xiaochu Liu <xiaochu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657478}