- 14 Aug, 2018 40 commits
-
-
Sammie Quon authored
Also fix a bug where continue button was still enabled after tabbing to and pressing backspace with the keyboard. Test: manual Bug: 855014, 869641 Change-Id: I0f3e570fc87b1a2e60de112de47558885f5d4847 Reviewed-on: https://chromium-review.googlesource.com/1173139Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#583030}
-
Henrique Grandinetti authored
3 things are done here: - add underscore to private properties of UsageTimeLimitProcessor class; - fix a couple of comments with typos; - rename 'override' property. Override is a reserved word starting on C++11; Bug: 869954 Change-Id: I9d9f5ab133b9a9c639b68b25648beb3c8fbfe119 Reviewed-on: https://chromium-review.googlesource.com/1159041Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com> Cr-Commit-Position: refs/heads/master@{#583029}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6febc356717c..db93180205a6 git log 6febc356717c..db93180205a6 --date=short --no-merges --format='%ad %ae %s' 2018-08-14 manojgupta@google.com chromeos_config: Mark eve as experimental. Created with: gclient setdep -r src/third_party/chromite@db93180205a6 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I60803dea17bcaf7a0637b197bba81ac7c6b16670 Reviewed-on: https://chromium-review.googlesource.com/1174795Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583028}
-
W. James MacLean authored
This CL is experimental, and aims to see if a changing surface id for the root view could be at the heart of the flakey tests reference by the associated bug. One flakey test is re-enabled to provide some initial data. The surface id idea is cherry-picked from kinuko@'s CL at https://chromium-review.googlesource.com/c/chromium/src/+/1126598 . Bug: 833380 Change-Id: I3cda4f5214a5bf19e711f95303a6b65b4ff2410c Reviewed-on: https://chromium-review.googlesource.com/1172723 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#583027}
-
Manu Cornet authored
This fixes an issue where the app list button position wasn't properly calculated, causing the shelf icons to sometimes "bleed" over the app list button. Bug: 805612 Bug: 869649 Change-Id: Id774e15edbde8704789ed77bb36da194060fc3e9 Reviewed-on: https://chromium-review.googlesource.com/1173753Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#583026}
-
Alexei Filippov authored
This speeds up bars drawing by an order of magnitude as all the work is delegated to the GPU. Vertex layout is performed once when model is loaded or when groups are expanded/collapsed. The actual drawing caused by zooming and panning the flamechart just modifies the transformation matrices. Titles and custom decorations are still drawn on the overlay 2D canvas. The WebGL mode is currently put behind an experiment. BUG=874116 Change-Id: I5984db2769d8ed5317b630bd705ab8447baa9358 Reviewed-on: https://chromium-review.googlesource.com/1174861 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#583025}
-
Maks Orlovich authored
Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: If1cebe592b61a84eee86c0daf74c9524128fe4c2 Reviewed-on: https://chromium-review.googlesource.com/1142350 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#583024}
-
Manu Cornet authored
It could happen that the separator would appear after all visible items (after the overflow button when there was one). This prevents that from happening. Bug: 805612 Change-Id: I0a3105a94850a7325c3e642c409ef3603124aa39 Reviewed-on: https://chromium-review.googlesource.com/1173756Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#583023}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/692aeadfe32d..f46d49b52d39 git log 692aeadfe32d..f46d49b52d39 --date=short --no-merges --format='%ad %ae %s' 2018-08-14 thestig@chromium.org Roll third_party/freetype/src/ 578bcf103..96b5e5009 (23 commits) Created with: gclient setdep -r src/third_party/pdfium@f46d49b52d39 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id49480cb1513f91ec83fcf23ad99e93153eca8e2 Reviewed-on: https://chromium-review.googlesource.com/1174794Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583022}
-
James Cook authored
The former is the only subclass of the latter. The other subclass was removed when we switched the --show-taps feature to using the tap_visualizer mojo UI app. Pure clean up, no functional changes. Bug: 873264 Test: ash_unittests, manual test of --ash-touch-hud then Ctrl-Alt-I Change-Id: I5e81f57655a69ee6b4f33e4ed42d27285481a83c Reviewed-on: https://chromium-review.googlesource.com/1173254Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#583021}
-
Martin Kreichgauer authored
This disables platform authenticators (i.e. Touch ID) for makeCredential requests with an unset AuthenticatorAttachment value in AuthenticatorSelectionCriteria. This is done to prevent Touch ID fingerprint prompts for requests that could be handled by external authenticators, as long as Touch ID is not integrated with UI. Filed crbug.com/873710 to track reversal of this change once UI integration is there. Bug: 678128 Change-Id: I7aaffe53dfca7ee14b5a94f9ead2027ab370c35c Reviewed-on: https://chromium-review.googlesource.com/1172912 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#583020}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/32c7d4dfcdca..d19fed1e291d git log 32c7d4dfcdca..d19fed1e291d --date=short --no-merges --format='%ad %ae %s' 2018-08-14 fmalita@chromium.org [skottie] Eliminate some temp SkString allocations 2018-08-14 mtklein@google.com pass sprite opacity to color xform when blitting. Created with: gclient setdep -r src/third_party/skia@d19fed1e291d The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: Ib608389718b76c94782e3415bcc82dc607902e82 Reviewed-on: https://chromium-review.googlesource.com/1174793Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583019}
-
Matt Menke authored
Their configuration is now done through a NetworkContextParams object, other than injecting ProtocolHandlers / URLRequestJobInterceptors, and cert verification. This does change behavior in a few ways: Previously, CookieSettings were only partially applied to isolated URLRequestContexts - settings applied through the NetworkDelegate, like blocking cookies, were applied, but settings applied through the QuotaPolicyCookieStore, like making cookies for some sites session-only, were not. This CL makes both types of settings apply to isolated partitions to avoid having separate NetworkContext APIs to configure each subset of cookie behaviors, which are normally keyed off the same set of settings. Also, isolated URLRequestContexts are more independent of the main profile URLRequestContext than they used to be. They only share a cert verifier, and most of the NetworkDelegate, in addition to global objects (HostResolver, AuthHandlerFactory, NQE, NCN, and NetLog), as opposed to sharing everything but NetworkContext, URLRequestJobFactory, CookieStore, DiskCache, and HttpNetworkSession. BUG=847555 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Id462de6d71029210a7af7a7ac3fa8f3de896d9d8 Reviewed-on: https://chromium-review.googlesource.com/1153630 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#583018}
-
Balazs Engedy authored
Bug: None Change-Id: Ibc16a2c01d1611e44613a0c80b80afb0954183e1 Reviewed-on: https://chromium-review.googlesource.com/1174532 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#583017}
-
Scott Violet authored
Any change to the superclass of these files generally results in having to touch the test subclasses. More often than not the changes are trivial: add a no-op override. This patch opens these files to *. Additionally I'm removing myself from chrome/test. I'm already in chrome/OWNERS and wouldn't mind balancing the load a bit more. BUG=none TEST=none Change-Id: I1d8fe5b1b6d715c4002da4192d9e641cb29271c9 Reviewed-on: https://chromium-review.googlesource.com/1175056Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#583016}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/246471433a96..624fec3ddbea git log 246471433a96..624fec3ddbea --date=short --no-merges --format='%ad %ae %s' 2018-08-14 treehugger-gerrit@google.com Merge "perfetto-ui: Don't position track absolutely" 2018-08-14 treehugger-gerrit@google.com Merge "profiling: refactor RecordReader to decouple it from socket." 2018-08-14 primiano@google.com TraceProcessor: Fast filtering of timestamps in the sched vtable Created with: gclient setdep -r src/third_party/perfetto@624fec3ddbea The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ibd2498f473caeac2287808a31ef91accfd0dc2d0 Reviewed-on: https://chromium-review.googlesource.com/1174796Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583015}
-
Sigurdur Asgeirsson authored
Change-Id: I9ab6cebe8d03cb679981a9d46ec3a04c59ea092f Reviewed-on: https://chromium-review.googlesource.com/1169908 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#583014}
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/6410e18e9190b6b0c71955119fbf3cae1b9eedb7..6b0d82229b2c4ce85b1c3f6d55bda661e07bead2 BUG=none Change-Id: I00eb27e49a13bf358d7554ba92e51fe9020f9371 Reviewed-on: https://chromium-review.googlesource.com/1174937Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#583013}
-
Vlad Tsyrklevich authored
Bug: 864705 Change-Id: I4fbcd32c785dbca8de023d474956d8b1f1a308e4 Reviewed-on: https://chromium-review.googlesource.com/1159682Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#583012}
-
Amos Lim authored
Replace NullString with EmptyString of data atrribute as per spec[1]. [1]: https://dom.spec.whatwg.org/#dom-characterdata-data Remove the null check in setData() because binding-generated code has the null check on data. Bug: 497307 Change-Id: I35ff0e0f864c2bc300f551bef6f25c1908c8a2ac Reviewed-on: https://chromium-review.googlesource.com/1172308 Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#583011}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4fe3de13..5ce57437 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic6188939a9cbae19b9887373430c1bcc7a05ae6c Reviewed-on: https://chromium-review.googlesource.com/1174703Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583010}
-
bsheedy authored
Automates the VR Browser manual test for ensuring that permissions granted to a site in 2D persist through reloads and VR entry. Bug: 861941 Change-Id: I2f2ae07705713a97f8e428ec325e3d5412b37fbb Reviewed-on: https://chromium-review.googlesource.com/1171600Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#583009}
-
Max Rebuschatis authored
Bug: 845293 Change-Id: Ic41d3ac4a1925d6e6c175d00b8ded71f85a6fedc Reviewed-on: https://chromium-review.googlesource.com/1089646 Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#583008}
-
Sam Maier authored
Bug: 843745 Change-Id: I86c008448cc40004c45823f21cb4fff607208ed5 Reviewed-on: https://chromium-review.googlesource.com/1129630 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#583007}
-
Alexey Kozyatinskiy authored
Removed unused methods. R=lushnikov@chromium.org Bug: none Change-Id: I63d14fcbf504d7b39d1758c54df358c1d6bd1630 Reviewed-on: https://chromium-review.googlesource.com/1174857 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#583006}
-
Xianzhu Wang authored
Previously, --reset-results removed the existing platform baseline without recreating one if the fallback baseline doesn't exist. Fix the issue by checking non-exist and non-missing condition before removing the current baseline. Bug: 845781 Change-Id: I7dbe46665d9574b310020c4ffc4041b6235d5570 Reviewed-on: https://chromium-review.googlesource.com/1173483 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#583005}
-
kristipark authored
"Cancel" was calling the form's submit event, which triggered the add link flow. Bug: 874018 Change-Id: Iad822d3884484f5dc0d9f3e6667c9d4c9e0a2728 Reviewed-on: https://chromium-review.googlesource.com/1174908Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#583004}
-
Manas Verma authored
The variable `kTweenType` was re-defined in another class. Renaming it to `kIconLabelBubbleTweenType`, and changed the other constants similarly to avoid future conflicts. Original change introduced here: https://chromium-review.googlesource.com/c/chromium/src/+/1162862 Bug: 855186 Change-Id: I94d3ea5b4732bac586780e441804a3e98bb99bb0 Reviewed-on: https://chromium-review.googlesource.com/1174893 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#583003}
-
Stefan Zager authored
If a RemoteFrameView is inside a throttled LocalFrameView with out-of- date layout, then it's not possible to compute its viewport intersection. In that case, just propagate an empty intersection (which is probably correct, because a throttled frame is presumably off screen). BUG=711468 R=kenrb@chromium.org Change-Id: Ie400c407871aab74561b4e34eefece17aa8c3e27 Reviewed-on: https://chromium-review.googlesource.com/1173345Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#583002}
-
Weilun Shi authored
Minor change on custom link edit input label and text field background color css setting according to GM2 webUI spec. Bug: 873721 Change-Id: I6770ce6eedf4a4e5ec6cb273e34136d30ee17f58 Reviewed-on: https://chromium-review.googlesource.com/1174870Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#583001}
-
Bruce Dawson authored
When launching a process with admin rights we can't duplicate the process handle with dwDesiredAccess == PROCESS_QUERY_INFORMATION. But we don't need to - we just need the same rights we have to the original handle. So we should instead set dwOptions to DUPLICATE_SAME_ACCESS. This is an update to correct the flaw added in crrev.com/c/1155498 Bug: 871522 Change-Id: Ib5e526c1a1dfef07e6bb5e6d4d64e12c2d4c3eed Reviewed-on: https://chromium-review.googlesource.com/1173499Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#583000}
-
Andrei Pascovici authored
Bug: internal b/112284077 Change-Id: I9b30669d0864f5f72369ae76e353200609108e5f Reviewed-on: https://chromium-review.googlesource.com/1167970Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Andrei Pascovici <apascovici@chromium.org> Cr-Commit-Position: refs/heads/master@{#582999}
-
James Cook authored
The keyboard shortcut dialog is a UI mojo app that runs in a separate process and has its own AXTree. The code in AutomationManagerAura that looks up the AXTree ID for a hit test was looking at the wrong views::View to get the value, due to a confusing condition in how views::Widget looks up contents views. Added DCHECKs to make sure this looks up a proper remote AXTree id. Bug: 872421 Test: Turn on select-to-speak, hit Ctrl-Alt-/, click in dialog Change-Id: Id9aba72b1aa73b7677e0dc52d1a427c202db0a78 Reviewed-on: https://chromium-review.googlesource.com/1171261Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#582998}
-
John Budorick authored
Bug: 874109 Change-Id: Id969b6a28a93e2aa595efcabf32666cae95fa46c Reviewed-on: https://chromium-review.googlesource.com/1174964Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#582997}
-
Scott Haseley authored
This reverts commit fd47d8d8. Reason for revert: Collected sufficient initial crash reports. Original change's description: > [scheduler] Replace DCHECK for frozen and visible state with DumpWithoutCrashing > > Changing the DCHECK that checks for the page scheduler being frozen when > the page is visible to DumpWithoutCrashing to collect more crash dump data. > > Bug: 873214 > Change-Id: I0f10ef13b0cf790cb38189273adf1ddc03030fc2 > Reviewed-on: https://chromium-review.googlesource.com/1172709 > Commit-Queue: Scott Haseley <shaseley@google.com> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582713} TBR=altimin@chromium.org,shaseley@google.com Change-Id: If15864678725a3939f5e0e03ddd4bcb97d220dcf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 873214 Reviewed-on: https://chromium-review.googlesource.com/1175011Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Scott Haseley <shaseley@google.com> Cr-Commit-Position: refs/heads/master@{#582996}
-
Paul Jensen authored
These tests are slow and only relvant to tools changes so there is no point in running them all the time. These tests fail on Windows, so this change prevents them from interfereing with large-scale-refactorings done on Windows that don't affect the tools. Bug: 871754 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iccf6042665a027efb181848508128ef435cdd22b Reviewed-on: https://chromium-review.googlesource.com/1172918 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#582995}
-
Wei Guan authored
Currently all available perception results are added to the perception sample as entities. When there are no entities, we dont know if there were no entities detected, or no detections were run at all. BUG=872764 Change-Id: I18d4b0f1a0e285f030e5d6f64a4c62c0dc23ae07 Reviewed-on: https://chromium-review.googlesource.com/1169311Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Wei Guan <weigua@chromium.org> Cr-Commit-Position: refs/heads/master@{#582994}
-
Antonio Gomes authored
This CL is a trivial fixup of https://crrev.com/c/1076947; it deletes some left-over code in ContentVerifier::BindURLLoaderFactoryRequestOnUIThread: |network::mojom::URLLoaderFactoryParamsPtr params|. TBR=rdevlin.cronin@chromium.org Bug=844926 Change-Id: I493c29034ba61b59a99a4c9d2fd0ebd1a5717145 Reviewed-on: https://chromium-review.googlesource.com/1174654Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#582993}
-
Annie Sullivan authored
This is part of a larger project to measure page load times starting at user input. One blocker for this is understanding how the beforeunload dialog might affect this metric. Bug: 750639 Change-Id: I7aef267a52353a6852dd82bad6c6c74a6fb82e51 Reviewed-on: https://chromium-review.googlesource.com/1162673 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#582992}
-
Varun Khaneja authored
PVer3 is the old specification of the protocol to download blacklist updates and query full hashes from the Safe Browsing service. PVer4 replaced this code in crbug.com/543161 Overall changes: * Replaced the use of SafeBrowsingProtocolConfig with V4ProtocolConfig. * Made TestSafeBrowsingService() the base class for a all derivatives of SafeBrowsingService in tests. * Add CanCreateDatabaseManager and CreateDatabaseManager in ServicesDelegate::ServicesCreator to allow tests to create their own DatabaseManager, if they choose to. TBR=tnagel TBR'ing tnagel since the changes in annotations.xml are trivial: just deleting lines for files being deleted. *************** Note to Sheriff *************** If this CL breaks any builds or any tests, please feel free to revert immediately. Reviewers, please review the changes in the following files: rdevlin.cronin: chrome/browser/extensions/ ntfschr: android_webview/browser/aw_safe_browsing_ui_manager.cc davidben: chrome/browser/net/trial_comparison_cert_verifier_unittest.cc, chrome/browser/prerender/prerender_test_utils.cc tnagel: tools/traffic_annotation/summary/annotations.xml qinmin: chrome/browser/download/download_browsertest.cc bbudge: chrome/test/ppapi/ppapi_filechooser_browsertest.cc Bug: 754341 Change-Id: I889dfe42848b8579e26aed0ea92c86b38fdfb87a Reviewed-on: https://chromium-review.googlesource.com/1153969 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#582991}
-