- 13 Apr, 2020 40 commits
-
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I364c818d7dc04e616114f50f8265e3c5a04b3718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147393Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#758509}
-
Yuichiro Hanada authored
ui/keyboard no longer exists. Bug: 1060272 Change-Id: Ie42724fb6b00d44d91ba8050f2a7703eb6f9fe6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143175 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#758508}
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 767015, 1063749 Change-Id: Ibb7d0fd6d18ee498e878033b433684548a85ef17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146534 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#758507}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d468a1619a2f..dabe38f611af git log d468a1619a2f..dabe38f611af --date=short --first-parent --format='%ad %ae %s' 2020-04-13 egdaniel@google.com Add submits after flushes in ProgramsTest. Created with: gclient setdep -r src/third_party/skia@dabe38f611af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I3685b68cae7811c14024680b45e8994ebe678f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147540Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758506}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6034567f9d0a..04ab397e8e8a Created with: gclient setdep -r src-internal@04ab397e8e8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,yutak@google.com,rhalavati@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: xhwang@google.com,yutak@google.com,rhalavati@google.com Change-Id: I7636e8e2d8d06567c37ea3b747512325aa2068a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147538Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758505}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ic6be109302b4c199ddae5726ee7b4f857a0c98e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145740Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I5264649499cc8e9507ca18aa2bf62ccfe0506b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145527Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I502ccd86afdaf871f533417bab9af2677a7f7dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144710Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758502}
-
Philip Rogers authored
This patch makes will-change: filter a compositing reason. The approach is similar to will-change: transform where filter changes do not cause DiffNeedsFullLayoutAndPaintInvalidation (see change in computed_style_diff_functions.json5). LBMO::StyleDidChange is used to invalidate when the will-change property changes. Bug: 960953 Change-Id: I7600c141baf11d1e10fae229a6261926c44923fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145466 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758501}
-
Elly Fong-Jones authored
It's always gfx::Rect() anyway, and the bubble has an anchor view. Bug: 1064663 Change-Id: I94cfcd1c64dbb5bbce7f9990dda75b91186aa56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144772Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#758500}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8128233d3354..8b4d25b6741b git log 8128233d3354..8b4d25b6741b --date=short --first-parent --format='%ad %ae %s' 2020-04-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 2fd41fab58c8..490e39372126 (2 commits) Created with: gclient setdep -r src/third_party/angle@8b4d25b6741b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I18991ec514e8a4ee4b554a39397349bafee9ba98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147152Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/828ceef7d7ff..cef0af8e6c7f git log 828ceef7d7ff..cef0af8e6c7f --date=short --first-parent --format='%ad %ae %s' 2020-04-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@cef0af8e6c7f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaa6eb594bb633f5900eda858f4d8cb249dd3b0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147536Reviewed-by:
-
Reilly Grant authored
As an optimization SerialChooserController and HidChooserController were written to use std::move() to move the select device (or list of devices) out of the list of options. This leaves the list in an inconsistent state (a single null entry) which causes the crash reported in issue 1069057. These classes have been updated to follow the pattern from UsbChooserContext of returning a clone of the selected option instead. Bug: 1069057 Change-Id: I016d12adad2977e49939dfb00044bfd7201767ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145052 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#758497}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4b4efe4d6f1f..d468a1619a2f git log 4b4efe4d6f1f..d468a1619a2f --date=short --first-parent --format='%ad %ae %s' 2020-04-13 reed@google.com [skvm] approx_[asin,acos,atan] Created with: gclient setdep -r src/third_party/skia@d468a1619a2f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I7851ea488a40f0085705214ef848b200c42e4e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147535Reviewed-by:
-
Frédéric Wang authored
This CL improves the stretchy operator shaper code after more testing in MathML layout. The following changes are performed: * Add an OUT Metrics parameter to StretchyOperatorShaper::Shape and improve this function. As discussed in [1], it is expected that LayoutNG algorithms perform both text shaping and measurements, and pass the shape result to the painter classes, so it is not necessary to have a separate GetMetrics method. * Remove GetGlyphStretchSize and ToMetrics helper functions since they are now only used in only one place. * Remove the stretch axis direction parameter from the version of CreateForStretchyMathOperator that outputs a single glyph since MathML only supports horizontal mode and vertical operators still correspond to horizontal text. * Improve code documentation and update tests. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2051923 Bug: 6606 Change-Id: Icc755adf9460ac59b68e0d904c062296700fd3c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144110Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#758495}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4950853060fdf50dd1c2aab9f5a645f04e24a66b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147382Reviewed-by:
-
Maksim Sisov authored
This Cl doesn't bring any functional changes, but just moves the X11 code down to ui/base/x. Bug: 1069469 Change-Id: Idaddec11dfbe88226a190d2ba4b5050ad38eed6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144056 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#758493}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cf2c8e6068c8..8128233d3354 git log cf2c8e6068c8..8128233d3354 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader e6f65d9265e7..9d2fd9c161ab (2 commits) Created with: gclient setdep -r src/third_party/angle@8128233d3354 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I20a734fdc8041427b568293b3ae233d7bc1fe98f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147380Reviewed-by:
-
Miyoung Shin authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames it to negative-flex-margins-crash.html. Bug: 1063749 Change-Id: Ibd2006646b62247ec4b0fd77165b7bb5fc058040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144801Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#758491}
-
Miyoung Shin authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames it to negative-flex-rounding-crash.html. Bug: 1063749 Change-Id: Ia5e1488b0f7681ffebf726300977e406cf58dcb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142877Reviewed-by:
-
Wez authored
This reverts commit 3d6123e3. Reason for revert: Broke official desktop continuous builder, at least for Fuchsia (see https://crbug.com/1070174). Original change's description: > [cipd] Refactor CIPD template > > Currently, a CIPD staging directory is populated by copying specified > `sources` into it, and producing a .yaml manifest which reflects the > copied files. > > This change refactors the template to invoke a pytho script to do the > above instead of in GN, using the `yaml` library to write the file data > in the proper format. > > Also make the license filepath explicitly passed through sources. > > Renames "archive" -> "package" and "manifest" -> "package definition" to > be consistent with CIPD semantics (crbug.com/1042819#c8). > > Finally, have the script emit a depfile for all files tracked by the > .yaml manifest. > > This refactor is desirable, as we want to create CIPD packages with more > complicated rules than simply "copy and include these files" (see > crrev.com/c/1925446, which extends the functionality of the template to > allow for the inclusion of directories). Wriiting yamls with a library > reduces the error-proneness of trying to recreate yaml's format in pure > GN. > > Also, emitting a depfile ensure that we track and rebuild if the CIPD > package is modified. > > Currently the potential danger of this change is limited in scope to > fuchsia, as they are the only users of the template. I've checked > locally that the produced CIPD packages for fuchsia are identical prior > to this change. > > Bug: fuchsia:41443 > Change-Id: If1b27d6a8fbbffdf767aaa4230bf7b527a553170 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135186 > Commit-Queue: Anthony Fandrianto <atyfto@google.com> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758433} TBR=kmarshall@chromium.org,brucedawson@chromium.org,joshuaseaton@google.com,atyfto@google.com Change-Id: I68f850f43ca121c3dfb7f87d0ec68e7f96448d94 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: fuchsia:41443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144183Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#758489}
-
Hiroshige Hayashizaki authored
ImageResource in Blink does not support SRI, but preload scanner assigns integrity metadata for `<link rel="preload">` for all `as` values, not only `stylesheet` and `script`. This triggered a CHECK failure in a scenario like subresource-integrity-partial-image.html WPT: 1. An image load is started, with integrity metadata is set. 2. The partial image is rendered, and decoded size is set. 3. The image is fully loaded. Resource::Finish() is called and SRI check is executed, which triggers CHECK failure. The root cause is that SRI code (and the CHECK condition) doesn't support images, and thus SRI code + images will anyway fail, not necessarily in this particular scenario/CHECK. This is a regression since https://chromium-review.googlesource.com/c/chromium/src/+/1679140 removed a guard condition from third_party/blink/renderer/core/html/parser/html_preload_scanner.cc that prevented preload scanner from setting integrity metadata for non-`as="stylesheet"` `<link rel="preload">`. This CL prevents SRI in images, by resurrected the guard condition, plus allowing `<link rel="preload" as="script">`, and aligning with a corresponding check in third_party/blink/renderer/core/loader/preload_helper.cc. This CL adds a WPT test to confirm the crash no longer occurs. Bug: 1058045 Change-Id: I73b3224c9beef28308fa4c47e8e91b09b3840688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138994Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#758488}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e521cd14da4a..4f3aff5fc2f6 git log e521cd14da4a..4f3aff5fc2f6 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 ukai@google.com Roll out new goma client binary VERSION=197 Created with: gclient setdep -r src/third_party/depot_tools@4f3aff5fc2f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Idaea339637e90966c684a5cd85fabeeead09c6ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147374Reviewed-by:
-
Colin Blundell authored
WebLayer will be integrating //components/translate. This CL decouples TranslateWaiter from //chrome so that I can start to use it in initial browsertests for //weblayer modeled on //chrome's translate_manager_browsertest.cc. Bug: 1025620 Change-Id: I2a903627ce9422feec00b1b9a9e1147abbf9a3b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144179 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#758486}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I420df20fa51681d3bfa3ee0c7ca20adf85681117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143414Reviewed-by:
-
Rushan Suleymanov authored
This reverts commit 2a67f1be. Reason for revert: reland changes after M83 BP. Original change's description: > Revert "[Sync] Remove setting of cache GUID for old clients." > > This reverts commit fab0d10e. > > Reason for revert: this patch contains refactoring of client tag based > model type processor. To prevent too many changes in one release it is > better to reland this patch after M83 will be branched. > > Original change's description: > > [Sync] Remove setting of cache GUID for old clients. > > > > This patch removes old logic of setting cache GUID for old clients which > > had no this field. Clients must have set this field after one and a half > > years. Clients that haven't migrated will remove sync metadata (treat as > > cache guid mismatch) and go through download and merge procedure. > > > > There is one more little change: ConnectIfReady is removed from > > OnPendingDataLoaded because it does nothing and seems to be obsolete. > > > > Bug: 947044 > > Change-Id: I72a441c5ed9bfa2d77a58494aaa2181a1df54d3b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062277 > > Commit-Queue: Rushan Suleymanov <rushans@google.com> > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#752072} > > TBR=mastiz@chromium.org,rushans@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 947044 > Change-Id: I3479fa8d35d851d7852225f5fda69e8ccfb022c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127209 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Rushan Suleymanov <rushans@google.com> > Cr-Commit-Position: refs/heads/master@{#755292} TBR=mastiz@chromium.org,rushans@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 947044 Change-Id: Ie0d81d9a7fec9a711b622bd195e2402210314088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135747 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#758484}
-
Colin Blundell authored
This CL abstracts the bulk of InterceptNavigationDelegateImpl's remaining deps on Tab through InterceptNavigationDelegateClient to support reuse of InterceptNavigationDelegateImpl by WebLayer. The one remaining dep is the observance of Tab via EmptyTabObserver, which is complex enough to warrant its own CL. As part of this CL, we change InterceptNavigationDelegateImpl from obtaining the //chrome-level AuthenticatorNavigationInterceptor via AppHooks#createAuthenticatorNavigationInterceptor() to obtaining the //components-level AuthenticatorNavigationInterceptor via AppHooks#createAuthenticatorNavigationInterceptorV2(). The two methods return the same object in their downstream implementations (an impl that implements both identical interfaces), so this change has no behavioral impact; it is necessary as the //components-level Client interface can refer only to the //components-level AuthenticatorNavigationInterceptor interface. Bug: 1031465 Change-Id: I7e69fadf4fc563e9d2839311d5aabe9856517532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134233 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#758483}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: If002f424b8883857bd0fb3664995b0ca0b10b00d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136988Reviewed-by:
-
chromium-autoroll authored
fuchsia/third_party/aemu/linux-amd64/+log/e-tS4.....kg4AQ... Created with: gclient setdep -r src/third_party/aemu-linux-x64@kg4AQ... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: chonggu@google.com Change-Id: I3754b6bfa73810ad1717a61ed2429440f2c92204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147379Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I88f42b8d68640e0d239adaa6bd09633be1295809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142887Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fd5072e45780..6034567f9d0a Created with: gclient setdep -r src-internal@6034567f9d0a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:995903 Tbr: nhiroki@google.com,reillyg@google.com Change-Id: Ia78763f6bccb2f28e1fbb7a58f2326ab89eb5f78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147372Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6124b5308bbe..828ceef7d7ff git log 6124b5308bbe..828ceef7d7ff --date=short --first-parent --format='%ad %ae %s' 2020-04-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@828ceef7d7ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3855a53b23c179df176ae3e3273d7012c32a4ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146856Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I797b86509c582af8f2c049ce8394eafbca2b242b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143067 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#758477}
-
Minoru Chikamune authored
This CL is originally discussed on this CL below. https://chromium-review.googlesource.com/c/chromium/src/+/2137200/3/third_party/blink/renderer/modules/webtransport/quic_transport.cc#248 Bug: 1049056 Change-Id: If7514d4237641e770adcceef5e857bc4681f1f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141396Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: Id0f53c8eb1063dc22b372194755d2b1a9e3f9025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146405 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I2cfee5b72b46e9aa8e02e21cd38f104ed21d539e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143066 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
Since all access to FontFallbackList needs to go through Font, this patch moves the call site of FontFallbackList::Invalidate() up into Font::EnsureFontFallbackList() to make it simpler. Bug: 441925 Change-Id: I1515ae4f76f528f7f395135c1cf799cff5106f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146062 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch changes |NGPhysicalContainerFragment| constructor to move children from |NGContainerFragmentBuilder|, instead of calling |AddRef|. Children in |NGContainerFragmentBuilder| will not be used after it generated a fragment. We used to move, but changed to copy when the child list was changed to a flexible array in r603306 crrev.com/c/1298207. Change-Id: Iac77022c39835598b2257b24cf80e0f0f34f8a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145734 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#758472}
-
Hiroki Sato authored
This reverts commit a5301433. Reason for revert: betty-pi-arc-pi-android-pfq is continuously failing Bug: 1070126 Original change's description: > Manually roll chromite to pick up localhost vs VM fixes. > > Picks up a single change: > $ git log 97d7f0702..8ef1e6c0 --date=short --first-parent --format='%ad %ae %s' > 2020-04-06 bpastene@chromium.org device: Don't assume '--device=localhost' means VM. > > And updates chromeos/test_runner.py to not specify '--device=localhost' > when running VM tests. > > Bug: 1067800 > Change-Id: Id8af6b2cb1d8a082b71a6ac01cfe9522578a21b4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145762 > Reviewed-by: Erik Chen <erikchen@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758264} TBR=achuith@chromium.org,erikchen@chromium.org,bpastene@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1067800 Change-Id: Ide5832c94b127d0ad360f66954bf2ce101b0933e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146409Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#758471}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/32c61af49cdb..4b4efe4d6f1f git log 32c61af49cdb..4b4efe4d6f1f --date=short --first-parent --format='%ad %ae %s' 2020-04-13 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-04-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c68dfaf3a529..cf2c8e6068c8 (6 commits) 2020-04-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e6f65d9265e7..9d2fd9c161ab (2 commits) Created with: gclient setdep -r src/third_party/skia@4b4efe4d6f1f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: Ib78982c28a5341adc455189054b640399ebecd8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146858Reviewed-by:
-
