GitLab

Right now we have places in Blink that uses
std::vector<std::pair<std::string, CompositorElementId>, which is
exactly the CompositorPaintWorkletInput::PropertyKeys.

This CL makes changes to those places, no behavior change is introduced.

Bug: None
Change-Id: I16b60f258ad54a7ae807d222a2472d9eeedcb67b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768894Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690950}

Test has been failing for over 50 runs.

TBR=alemate@chromium.org

Bug: 998330
Change-Id: Ib9c5446d32b1354011407b2b8597655a40159741
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772930Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690949}

Updates the golden images for the VR browser suggestion hovering pixel
test, as the order of suggestions was recently changed.

TBR=alcooper@chromium.org

Change-Id: I943f62372414470a038e4a16633acb3f75e8cfa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773860Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690948}

This CL adds some metrics to record actions related to the long press
tab switcher menu.

Bug: 993046
Change-Id: Ic0320fbf4dd63646cd098e2b674d193485c1c38b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772278Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#690947}

Including directories full of generated files causes incorrect incremental
builds.

But using data_deps makes it easy to copy just the generated files here,
so just do that instead.

To make sure this does the right thing, I ran

  gn gen out/gn --runtime-deps-list-file=<(echo //chrome/test:browser_tests)

with and without this patch and compared out/gn/browser_tests.runtime_deps.

The diff is

-test_case.html
-test_case.html.mock-http-headers
-test_page.css
-test_page.css.mock-http-headers
-test_url_loader_data/
+corb_eligible_resource.json
+corb_eligible_resource.json.mock-http-headers
+test_case.html
+test_case.html.mock-http-headers
+test_page.css
+test_page.css.mock-http-headers
+test_url_loader_data/hello.txt
-corb_eligible_resource.json
-corb_eligible_resource.json.mock-http-headers
-test_case.html
-test_case.html.mock-http-headers
-test_page.css
-test_page.css.mock-http-headers


Importantly, `test_url_loader_data/` no longer appears. (For some reason,
the non-directories were listed twice previously.)

We now bundle corb_eligible_resource when we weren't previously,
but that seems fine.

I then downloaded an isolate from the command printed on a browser_tests
run on swarming like so:

  tools/swarming_client/isolateserver.py download -I https://isolateserver.appspot.com \
      --namespace default-gzip -s 60fe18ca29dd47b47425717c01e67516cc26d6bf \
      --target foo

and verified that these are in fact all files:

    $ ls foo/out/Release/test_url_loader_data/
    hello.txt

Bug: 912946
Change-Id: I1ad01f8b53a1eb47c5b572ad645b1901305fcbc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769213Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690946}

Bug: 985382
Change-Id: I65181f7b063b05e1a382761786cd9df92d35fe5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754622
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690945}

When the display bounds is changed, the app-list updates its
layout but the searchbox can remain in the original position.
This CL fixes this situation.

The search box happens to change to the correct bounds when in
peeking state, since AppListView::SetState() invokes
UpdateYPositionAndOpacity() and ContentsView updates the search
box position. This is not the case of half/fullscreen-search state.

I do believe the existing code of UpdateYPositionAndOpacity looks
weird since the search box bounds is neither of y-position nor
opacity. Doing the re-calculation in Layout() would look better to
me -- though I keep the existing code as-is in case it matters on
certain operation.

Bug: 998220
Test: new test cases in ash_unittests
Change-Id: I799461069c2168c5e8fc58382812116444dc4430
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773514
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690944}

This number was last updated in 2012.  The numbers here are based on the last
week of Windows stable data, taking the mean across all samples.  Other desktop
platforms have higher means than Windows, so this is still aggressive compared
to what we could do.

The expectation is that this change should reduce the total number of renderer
processes we create, and result in reducing the total renderer memory footprint.

Bug: 22546
Change-Id: I2308759644ed2720e4904052e93b37d6ee8367fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772641
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690943}

This enables fractional scroll offsets which allows non-integer values
in Blink's scrolling data structures.

https://github.com/bokand/RenderingIndependentScrollOffsets/blob/master/README.md

Bug: 414283
Change-Id: I145899dd4a3ae9f3b3c936749fbe0b52cbc9ba3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766355
Auto-Submit: David Bokan <bokan@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690942}

Bug: 998319
Change-Id: I0ea11d3804c065052ab1929ec93ca8336273bf09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772929
Commit-Queue: Julian Watson <juwa@google.com>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Auto-Submit: Julian Watson <juwa@google.com>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690941}

This CL adds lookalike heuristic checking to safety tips. A safety tip
is only triggered when a lookalike domain is identified, but an
interstitial would NOT be triggered. In practice, this means a safety
tip is triggered when:
 - there's an edit distance of 1 to a top or engaged domain, or
 - there's skeleton similarity to a non-top-500 top domain.

 This CL also tidies the logic in lookalikes slightly. Now
 Chrome identifies lookalikes first and as a separate step decides
 whether to display an interstitial. Both functions are used when
 determining whether to trigger a safety tip, so as interstitialling
 logic changes, safety tips will move out of the way appropriately.

 Bug: 984725, 996733

Change-Id: I590f6d707a5347d55fb48e71e1420434b14bccb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771940
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690940}

Subscription-based hittest explainer can be found here:
https://github.com/immersive-web/hit-test/blob/master/hit-testing-explainer.md

This CL omits the asynchronous hit test also mentioned in the above
explainer (XRFrame::requestAsyncHitTestResults) as it's not yet clear how
it should work, see issue:
https://github.com/immersive-web/webxr/issues/506

Bug: 928481
Change-Id: I92c69b58794f2850025ab5ff2e68855b3162646d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546710
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690939}

Per feedback from UX, the proactive suggestions window animation should
be 350ms in duration with a cubic bezier tween.

Bug: b:139199754
Change-Id: I9d5cc06cd441c9cedbe60066a364d09c7b005a4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773840Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#690938}

Prevents activating the grouping border stroke when a user hovers the
main item. This is currently either extensions' puzzle icon or the
avatar icon, neither of which need to communicate which group of icons
they belong to.

Bug: chromium:993105
Change-Id: Iedcb82865517504efb452f00680fe50833a8b9b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773726
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690937}

Removed duplicate variable menuOriginNode
that likely appeared after a merge.

Bug: 982004
Change-Id: I857049cda8387b9e5d40189d1ed9afec49156e63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773213Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: Sophie Yang <sophyang@google.com>
Cr-Commit-Position: refs/heads/master@{#690936}

Add rounded artwork corners as per spec. There
is a screenshot of the implementation in the
bug.

BUG=998314

Change-Id: I8e92628693c64618628d05b064a5a46027fbeee0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772380
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690935}

There have been no scrollbar buttons since 10.7. The code handling
them on the renderer side is long-gone; remove the code from the
browser side.

Do mild other cleanup while we're here.

BUG=997934

Change-Id: Ia217b4de1b0451e3aff738a0e4c3f1db7526b6dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773162
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690934}

Adjusts the offset of the bottom sheet so that it appears as expected
when the omnibox control is not on screen. This CL fixes the issue
by overriding BottomSheetContent.onHideScroll so the browser controls
won't have an effect on NavigationSHeet.

Bug: 996535
Change-Id: I32d5a1a15d5a7275ce0fdba1a86e7dd82a570086
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767283Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690933}

This CL reduces pre-processed size of foo.mojom(-blink)-forward.h
including interfaces or structs significantly. For example,

  file_chooser.mojom-blink-forward.h: 1.66MB => 0.004MB

* mojo/public/cpp/bindings/*_forward.h
  New files.  They contain some forward declarations for
  mojo/public/cpp/bindings/.

* mojo/public/tools/bindings/generators/cpp_templates/module-forward.h.tmpl
  Include only *_forward.h and native_struct.mojom-forward.h.
  native_struct.mojom-forward.h is necessary for [native] structs.

* ipc/message_view.{h,cc}
  Move TakeHandles() implementation to message_view.cc in order to avoid
  instantiation of mojo::StructPtr<> in the header.

* Other files
  Add #includes or forward declarations which were included indirectly
  from mojo headers.


Change-Id: I08ac30fc40cb7af4ce248e8e9b5b1ff4fb55ed68
Bug: 862064
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768608Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690932}

Rounding the corners of the desk mini_views' contents
was apprently forgotten. This CL adds it.

Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=998235#c3

TBR=sammiequon@chromium.org
BUG=998235
TEST=Manually

Change-Id: Ia7a43201dcaeb635fe9182071f7befb4406cca35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773871Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690931}

This'll add a click-able "clang" link to build.chromium.org that'll
take you to ci.chromium.org/p/chromium/g/chromium.clang.

Change-Id: Ic66d522f1d3392ecd66e17f92c5275569b0ec744
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773839
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690930}

This CL has no behavior changes.

Change-Id: I0946a7776862e67d81929e91dcf84dbdf1768172
Bug: 242216
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773018Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690929}

This implementation consults the OptimizationGuideKeyedService to make
decisions for whether an optimization type can be applied for a
navigation.  The code path introduced here will only be used if the
OptimizationGuideKeyedService feature flag is enabled.

Although the internal decision made by the OptimizationGuideKeyedService
incorporates the max ECT trigger for the hint, the ultimate decision for
when to apply based on ECT is still made by Previews code. (i.e. even if
the OGKS says LitePageRedirect can be applied when the ECT is 3G, LPR will
still only apply on 2G and below in this current state)

This also includes browser test changes that ensure that Previews logic is
still maintained in both the original code path and the new one backed
by the OptimizationGuideKeyedService introduced in this CL.

Bug: 969558
Change-Id: I65d4678e0a200950bbb749461252e200f8b44d7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771134Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690928}

https://pdfium.googlesource.com/pdfium.git/+log/ce0eecb10b14..aea4bca2621b

git log ce0eecb10b14..aea4bca2621b --date=short --no-merges --format='%ad %ae %s'
2019-08-27 thestig@chromium.org Prevent another integer overflow in AGG.
2019-08-27 thestig@chromium.org Roll build/ 315a0c669..e7232efeb (1 commit)
2019-08-27 thestig@chromium.org Remove a memset() in CFDE_TextEditEngine::RebuildPieces().
2019-08-27 thestig@chromium.org Reformat listbox_form.in to be more consistent with other .in files.
2019-08-27 thestig@chromium.org Redo a UBSAN fix in AGG.
2019-08-26 thestig@chromium.org Roll third_party/freetype/src/ 7d1d3b9a0..9adc3b35f (1 commit)
2019-08-26 thestig@chromium.org Roll third_party/freetype/src/ 12af46b64..7d1d3b9a0 (3 commits)

Created with:
  gclient setdep -r src/third_party/pdfium@aea4bca2621b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=pdfium-deps-rolls@chromium.org

Bug: chromium:997021
Change-Id: Ieff2f4f2754be5d200e739a456c5d4f91668c8b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769689Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690927}

In a number of cases we want to delay an action until after an animation
completes, e.g. showing a bubble that will be anchored to a view that
will be moving or appearing as part of the animation.

Prerequisite for a number of things we want to do with the new
extensions area and identity chip.

Change-Id: Ifa2ca7d0b993cc545b786ab472d5a5f42b23ce60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773721
Commit-Queue: Dana Fried <dfried@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Auto-Submit: Dana Fried <dfried@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690926}

The refactor of the hints manager unittest and metrics recording is
not strictly required but done in the below CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1762982

This is mostly to reduce the amount of merge conflicts I will get

Bug: 969558
Change-Id: I49d7afc1a977bc2111dedc48fdd5cf5e3c022184
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772476
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690925}

If the soft input keyboard is open and focused on the OTP/code field
when the SMS arrives, the keyboard is dismissed.

Bug: 997025
Change-Id: Ibadd3febb4696ccfd600971538926ed667ce1bd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768995Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690924}

Added comment and set linux-rel as 100% experimental
in the new config group.

Bug: 922150
Change-Id: I67e85580e8a43567d2189ee1cbaf578769065b8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769693
Commit-Queue: Karen Qian <karenqian@google.com>
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690923}

The next steps here will be to allow the AppShimHost to be owned either
by the ProfileState (non-multi-profile-mode) or the AppState (multi-
profile mode).

Bug: 982024
Change-Id: Idbc2de4927895800a79e6300a6dbf24fc3ff652e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771945Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690922}

The test failures were caused by a real bug. For the set-time-dialog
element, the keys of the prevValues_ object are HTML element IDs
("dateInput" and "timeInput"), not "date" and "time". I broke this
when I changed the element IDs during the Material Design conversion
of this dialog in March 2019.

The failures were flaky because we didn't have an explicit test for
reverting the input elements to their previous values. The occasional
failures we say were due to element blur() events during test teardown
that apparently depend on timing.

Fix the bug and add an explicit test for reverting values.

Bug: 996000
Test: browser_tests

Change-Id: Ic0a286858e0563d32351da06536c881e541b1273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773541
Commit-Queue: James Cook <jamescook@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690921}

Adds a temporary sleep to testConsentPersistsLowerLevel and
testConsentPersistsSameLevel to see if it fixes failures on P.

TBR=alcooper@chromium.org

Bug: 998307
Change-Id: I56183327330ad2c027c5c01afecd3e53e6c7c102
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773898Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690920}

Makes the "Close [Chrome]" text blue when it appears on the last page
navigation.

Bug: 979498
Change-Id: I89f63e56b32ac4c6c3e157b5cbcab858081716b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768804Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690919}

In this CL, ScrollArrowView inherits the ShelfButton. It improves the
code readability and also makes Shelf code coherent: in current code
base all of buttons in Shelf are ShelfButtons.

Bug: 973481
Change-Id: I73aab558948b4ef32f79fa6e4ce243e9eba269a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772293Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690918}

In these files, it was being used to clear notification registrations
to fix http://crbug.com/125276

In NetworkStateInformer, it was doing nothing except removing its own
registration.

In SignInScreenController, the referenced UI object is owned, and
therefore can't have been freed, so the precaution was no longer
necessary.

In ExistingUserController, we can replace with a check to
IsSessionStarted before handling NOTIFICATION_AUTH_SUPPLIED. I don't
understand why this code lives in ExistingUserController to begin with,
and there's a TODO/bug to rework the bodge, but this should preserve
behavior.

Bug: 268984
Change-Id: I219b69997e4873ed60695442a757bd8d549dc00a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771614
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690917}

See bug comments 16/17 or comments in the code for description.

The algorithm here is O(n) in at most two passes over the input string, not
counting the StripJavascripSchemas() call.

Bug: 764512
Change-Id: I12123b40fc6c91f10d927fd34b368aa16c0310c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766890
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690916}

Adds logic to compute the contents digest of generated MHTML files, when
requested via the generation input parameters. A new MHTML generation
method is added to WebContents, but it will be merged into the existing
one in a follow up CL.

Also updates tests to verify the correctness of the digest computation.

This is based off a change by mtlieuu@: https://crrev.com/c/1552118

Bug: 915966
Change-Id: I816940a307018255f31d1aea0a66a729cbec77ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754125
Commit-Queue: Angel Alvarez <angelii@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690915}

https://chromium.googlesource.com/angle/angle.git/+log/14a9be448e01..886698bc3fdd

git log 14a9be448e01..886698bc3fdd --date=short --no-merges --format='%ad %ae %s'
2019-08-27 jmadill@chromium.org Vulkan: Style cleanups to TextureVk.
2019-08-27 jmadill@chromium.org Vulkan: Remove command buffer param from initImage.

Created with:
  gclient setdep -r src/third_party/angle@886698bc3fdd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Bug: None
Change-Id: I3d5c608e3a5bbac740483225ee2ad181d6e3836e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772330Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690914}

Anywhere we call getSharedPreferences might be a disk write as the
directory for prefs is created if it doesn't already exist; move the
existing StrictModeContext in AwGeolocationPermissions up to the caller
to also cover where the SharedPreferences object is retrieved, and add
another missing one when the browser context is created.

Bug: 994321
Change-Id: I2e18e156d378910751ee2a530d72180eab012696
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773781Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690913}

"Start activate" in the internet settings UI simply opens a new dialog
with the activation UI. This should not be part of the network config
API.

Bug: 853953
Change-Id: Ia4c72df1aad547991ab775ebf4c158827382da8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769633
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690912}

The required behavior of argparse subparsers changed in Python 3.
Add some code that works in Python 2 & Python 3 to retain the old
behavior.

Bug: 983071
Test: `./pak_util.py` doesn't crash under Python 3
Change-Id: I6820c65e365da662633a2eb4386e4077fedd3174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771983Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690911}