- 30 Apr, 2018 40 commits
-
-
Bo Liu authored
The effective change is that foreground subframes get moderate instead of important binding. Note this is only half of the change that's in the chart at the bottom of this design doc: https://docs.google.com/document/d/1PTI3udZ6TI-R0MlSsl2aflxRcnZ5blnkGGHE5JRI_Z8/edit?usp=sharing Background subframe renderer is not yet lowered to waived. At the same time refactor ChildProcessLauncherHelper.setPriority to be easier to read and understand. Compute the effective importance from all available input, and then update bindings based on the effective importance. BindingManager.increaseRecency is now based on gaining effective "important" importance, which is effectively the same as before for chrome since ChildProcessImportance.IMPORTANT is not used by src/chrome. Bug: 813232 Change-Id: I8969f37edfec8b39b53d3a8ffe740585f3a802a6 Reviewed-on: https://chromium-review.googlesource.com/1033802Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#554797}
-
Takuto Ikuta authored
This CL was uploaded by git cl split. R=jam@chromium.org Bug: 428099 Change-Id: I385a2a8f3bb72ff91b477ee3b29fd0bd3b501fdb Reviewed-on: https://chromium-review.googlesource.com/1032467Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#554796}
-
Bo Liu authored
Use moderate binding instead which has the exact same flags, and also supports refcounting. Bug: 813232 Change-Id: I22a56345a835c5916e6604bfb7cb2fc5cae6ceb5 Reviewed-on: https://chromium-review.googlesource.com/1033799Reviewed-by:
-
Tao Bai authored
Bug: 821606 Change-Id: Ifcb799a450ff1940b673fcd3a23fa6e64a6b382a Reviewed-on: https://chromium-review.googlesource.com/981182Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#554794}
-
codeimpl authored
std::make_unique<Type>(...) and base::WrapUnique<new Type(...)) are equivalent but std::make_unique should be preferred, because it is harder to use unsafely than base::WrapUnique. Ref: https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Prefer-MakeUnique-to-WrapUnique Bug: None Change-Id: I0e13e0fa0088e3f9adcbcbbee341eea04a3f2307 Reviewed-on: https://chromium-review.googlesource.com/1034048Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#554793}
-
Mounir Lamouri authored
This doesn't fix the cause but only the crash because we will need to send this to Beta. A proper fix will require some refactoring. It means that M67 will probably have slightly different data for time to dismiss and time to action. Bug: 835748 Change-Id: Iec87eb0b05f07c54c3c292180a6a59a1aa35666d Reviewed-on: https://chromium-review.googlesource.com/1034742Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#554792}
-
Alexander Hendrich authored
Fixed typo from "free form strings" to "free-form strings" as requested. Bug: b:78365996 Change-Id: I7534888a2bb4993c4e53660c5398782c628ceebe Reviewed-on: https://chromium-review.googlesource.com/1035122 Commit-Queue: Alexander Hendrich <hendrich@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#554791}
-
chaopeng authored
In some cases, ScrollAnimator::WillAnimateToOffset called with run_state_ == RunState::kRunningOnCompositorButNeedsAdjustment. Bug: 825351 Change-Id: I805625d87d469c77564391c83d381eb179c665c8 Reviewed-on: https://chromium-review.googlesource.com/1033015Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554790}
-
Raymond Toy authored
First, don't need to specify the name for the AudioParam when constructing it because we can derive a good name from the type. Except for AudioWorkletNode which has user-defined AudioParam names. So add a method to allow setting the name (but only if the type is AudioWorklet). Second, add another Create method that accepts the context, the type enum, and the default value, letting the rate, mode, and limits default to the most common values of "a-rate", changeable, min and max float values. Bug: 834863 Test: no user-visible changes Change-Id: Ic6895f8f6683cda6bc5aa6b381a1c8a1c6558759 Reviewed-on: https://chromium-review.googlesource.com/1020237 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#554789}
-
Owen Min authored
Change the caption to follow the policy caption pattern. Change-Id: I0746c5a9b83ac2f0483cac6c23ff5682cff35128 Reviewed-on: https://chromium-review.googlesource.com/1033418Reviewed-by:
Marc-André Decoste <mad@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#554788}
-
Charlie Harrison authored
This is obsolete with PlzNavigate. Bug: 789577 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I29cb9c7fa986cf6c564d9dad29c46b10df301be5 Reviewed-on: https://chromium-review.googlesource.com/1031392Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#554787}
-
Christopher Grant authored
If the exit-VR prompt shows while content is editing text, we should hide the keyboard. A side effect of this change is that, when the keyboard disappears, it notifies content that this has happened, and content loses focus. In the case of autofill settings, this means that if the user chooses autofill settings but dismisses the exit-VR prompt to return to their page, that the input field will no longer be focused for edit (and the keyboard won't be showing). In the 2D case, the keyboard is also hidden, but the cursor is still blinking in the field. Therefore, VR is not at parity with 2D, but this feels better than having the keyboard persist through VR modal dialogs. BUG=835483 R=asimjour Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I753ec31273e2473a21ea5cd2c2dddf70c962f71a Reviewed-on: https://chromium-review.googlesource.com/1030873Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#554786}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8550fd41. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16550 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=lukebjerring No-Export: true Change-Id: I242d7b49b84235bf3f2adef8a7226116134736e7 Reviewed-on: https://chromium-review.googlesource.com/1035102 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#554785}
-
Varun Mohan authored
Previously, the Occluded state only applied to Chrome-OS. When the Occluded state was added to Mac, the description of the histogram was not updated. This CL updates the decsription to reflect the current state. Change-Id: Icca3356f55a9402d483ab991c69bdf49089866d7 Reviewed-on: https://chromium-review.googlesource.com/1035063Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Varun Mohan <varunmohan@google.com> Cr-Commit-Position: refs/heads/master@{#554784}
-
Quinten Yearsley authored
These builders were migrated and renamed, and the buildbot builders are now removed. Bug: 790378,790311,790308 Change-Id: If9c58d228613901a16ff591188c9bba780ad9678 Reviewed-on: https://chromium-review.googlesource.com/1033488Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#554783}
-
https://chromium.googlesource.com/angle/angle.git/+log/bb3255b5a507..b90779ebf018 $ git log bb3255b5a..b90779ebf --date=short --no-merges --format='%ad %ae %s' 2018-04-27 jmadill Vulkan: Pass fewer Context pointers around. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Iaa89bd7345b6f6011763b686fb82df0072ade5aa Reviewed-on: https://chromium-review.googlesource.com/1034783 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554782}
-
Elly Fong-Jones authored
Bisecting the linked bug. TBR=jbudorick@chromium.org Bug: 828031 Change-Id: Ia93130623463909ee7898965b782a82bf19a69a1 Reviewed-on: https://chromium-review.googlesource.com/1035104Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#554781}
-
Sergey Aranovskii authored
This CL is consist of two patches: 1. Turn the unload controller tests on for fast unload controller. This patchset (the file unload_browsertest.cc only) returns back the functionality reviewed and merged on https://chromium-review.googlesource.com/c/chromium/src/+/1012118 and reverted on https://chromium-review.googlesource.com/c/chromium/src/+/1022553 2. Fixed crash in the fast unload controller browser tests. The original CL was reverted because of that crash. The reason of the crash is, the callback resets itself. The same issue has already been fixed in the unload controller (CL https://codereview.chromium.org/471763008 ), but not applied to the fast unload controller. This patchset (the file fast_unload_controller.cc only) brings the missed fix. Change-Id: I9d867131897457efad0c96bc7d2fe0ffa2a65729 Reviewed-on: https://chromium-review.googlesource.com/1025714Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#554780}
-
John Abd-El-Malek authored
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ice8a52e161cf99193ed341573e7a5d035c7e1c96 Reviewed-on: https://chromium-review.googlesource.com/1035082Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#554779}
-
https://webrtc.googlesource.com/src.git/+log/f22550175b96..71a720ba160c $ git log f22550175..71a720ba1 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibd6eed4d9606e6737d223bc068e52038cd368981 Reviewed-on: https://chromium-review.googlesource.com/1035084Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554778}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1c736c3e..434bb526 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I088dcd2ad1f8bf40d3a46840425fe800bb8e0f30 Reviewed-on: https://chromium-review.googlesource.com/1035043Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#554777}
-
Majid Valipour authored
Introduce WorkletAnimation::UpdateCompositingState which is resposible to update cc side when necessary (e.g., during start or when there is a change while running). WorkletAnimation now notifies its controller that it has been invalidated once its timing has changed. This ensures it gets a change to update its compositing state on the next commit cycle. While animation is running, the state update is done by canceling and starting the keyframe effect on compositor side. This ensures the animation instance continues to live (with the same id) and thus keep any associated state while also updating its keyframes and timings. Other minor changes: - Use GetEffect() to access the main effect for the animation. - Refactor start logic. Tests: - virtual/threaded/fast/animationworklet/worklet-animation-set-timing.html test timing updates are reflected in cc. - virtual/threaded/fast/animationworklet/worklet-animation-set-keyframes.html test keyframe updates are reflected in cc. Bug: 833846 Change-Id: Icab984331a0584d9bd1eb38d24aef2f657070970 Reviewed-on: https://chromium-review.googlesource.com/1020239 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#554776}
-
David Bokan authored
The focus call in fragment navigation can run arbitrary script which can cause the document to become detached. Thus, we need to check whether we're still attached before continuing. Bug: 837255 Change-Id: I4b35f66e39ace801a59230234264757ba4d6be04 Reviewed-on: https://chromium-review.googlesource.com/1033958Reviewed-by:
-
John Budorick authored
TBR=nednguyen@chromium.org,dpranke@chromium.org Bug: 836447 Change-Id: I9d102995fc94cf4950b44df91595f26709cf7624 Reviewed-on: https://chromium-review.googlesource.com/1034018Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#554774}
-
Mike Wittman authored
Pushing back ContentSettingPatternSource by value results in a copy and assignment, causing an unnecessary clone of the contained Value. This results in a small (5ms) but avoidable cost at startup. Observed in the execution profiles at: https://uma.googleplex.com/p/chrome/callstacks?sid=e6d04c6a58a9d19cff68156c450453bf Change-Id: I8c4bf641414438ea3c365cab12642ea1b1a0062e Reviewed-on: https://chromium-review.googlesource.com/1033832 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#554773}
-
John Chen authored
Re-enable ChromeDriverTest.testShouldHandleNewWindowLoadingProperly on Android. It no logner appears to be flaky. Bug: chromedriver:1478 Change-Id: Ia573dca0799b973b0a09ec16508cc3b667774e11 Reviewed-on: https://chromium-review.googlesource.com/1028365Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#554772}
-
John Budorick authored
Bug: 826895 Change-Id: I36c156e49c9e2a0a590b357fa4695f38838c7397 Reviewed-on: https://chromium-review.googlesource.com/1033538Reviewed-by:
-
Sahel Sharify authored
With browser side fling the fling_controller can tell if the GFC cancels the fling or not. Thus the tap suprression controller doesn't need to wait for the ack of the GFC. Stashing a tap(mouse) down event and dropping or forwarding it later on is not necessary either since on the arrival of these events the tap suppression controller already knows whether the GFC has cancelled an active fling or not. TBR=kinuko@chromium.org Bug: 249063 Change-Id: I89beff953a0c660bd6151864debe507be8c775ed Reviewed-on: https://chromium-review.googlesource.com/1033537 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#554770}
-
https://chromium.googlesource.com/catapult.git/+log/a4814ecb93e6..ad4bc36a64cc $ git log a4814ecb9..ad4bc36a6 --date=short --no-merges --format='%ad %ae %s' 2018-04-30 perezju [Soundwave] Use pandas to_sql to store alerts. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ie580f439d97e4cce6b9952bb958331c50e3a8afc Reviewed-on: https://chromium-review.googlesource.com/1034842Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554769}
-
Vaclav Brozek authored
There is a non-trivial condition with a bitmask at the end of WebFormControlElementToFormField(). This CL adds an explaining comment for it. Bug: 833838 Change-Id: I24001eb091643d7fa0ff4d7bda126d848a8432c7 Reviewed-on: https://chromium-review.googlesource.com/1033672Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#554768}
-
Patrick Noland authored
There are scenarios where we fail to bootstrap the source id from Java. This also means that we fail to setup the page for metrics reporting. If the page is not set up, calls to RecordEventMetrics will crash. Until we understand why the bootstrapping can fail and fix that, this CL will cause us to drop events without a valid source id so that we don't crash. Bug: 832712 Change-Id: I4a01c8cf7a9eaae645960dc17dada8a4b5cdd3fa Reviewed-on: https://chromium-review.googlesource.com/1033959 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#554767}
-
John Chen authored
Adjust when to retry while connecting to DevTools. The retry timeout now starts at 1 second, with exponential backoff, up to 16 seconds. Bug: 826150 Change-Id: Ia8dfdd27ab88ac6f466555a943810242188604d6 Reviewed-on: https://chromium-review.googlesource.com/1034385Reviewed-by:
-
https://skia.googlesource.com/skia.git/+log/58b90f7f1757..82cb619314cf $ git log 58b90f7f1..82cb61931 --date=short --no-merges --format='%ad %ae %s' 2018-04-30 borenet [infra] Calmbench: fix path to nanobench executable 2018-04-27 brianosman Add test to ensure that skcms' sRGB turns into Skia's sRGB color space Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I0e4641826f30a7fb53445297263be2ab3c5144c3 Reviewed-on: https://chromium-review.googlesource.com/1034843Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554765}
-
Jonathon Kereliuk authored
Previously we only supported the old dialect here. This CL only adds the new endpoints and keeps the old. spec: https://w3c.github.io/webdriver/#list-of-endpoints Bug: chromedriver:2406 Change-Id: Ib0c3cc1d71764e833f7c50748472a20598bbeefa Reviewed-on: https://chromium-review.googlesource.com/1034962Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#554764}
-
Fredrik Söderquist authored
Since SVGImage is handled explicitly already, and we pass kDoNotRespectImageOrientation to IntrinsicSize() in these functions, just call Image::Size() directly rather than passing through the ImageResourceContent method. Bug: 773272 Change-Id: I6b7c24f5be425f04cd2f68cbc4612054b635bc2b Reviewed-on: https://chromium-review.googlesource.com/1032745Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#554763}
-
Kevin Bailey authored
When in keyword mode, results will be from that search provider, except for a single WYT search at the bottom. It looks odd to have a different search there, when the user asked for a keyword search. This CL doesn't add the match in that case. Bug: 837395 Change-Id: I1441a6fe07f5d1e7ac5cd3dc16de408df6ad18c9 Reviewed-on: https://chromium-review.googlesource.com/1030613Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#554762}
-
David Bokan authored
Add a rAF before starting the test. My guess is that on slow bots the the gesture starts before the layers are initialized and pushed to the compositor's acive tree so the entire gesture gets ignored. Bug: 836623 Change-Id: I1c54e31b4fb064926d8ad94da4bb8d9751332067 Reviewed-on: https://chromium-review.googlesource.com/1034010Reviewed-by:
-
Justin Donnelly authored
This will bring the iOS suggestion UI to parity with the Android UI. Note that there is evidence that the refinement arrows next to URLs see a significant amount of usage (though not as much as the query refinement arrows). See the bug for more details. Bug: 679083 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I10aad6b630cdc7c598643a2ef35f4bd3d476ec01 Reviewed-on: https://chromium-review.googlesource.com/1033714Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#554760}
-
Emily Stark authored
Previously, we were treating all blob: URLs as nonsecure for the purposes of HTTP-Bad: namely, all blob: URLs would get a security level of HTTP_SHOW_WARNING. Instead, we now use the origin of the blob: URL to determine whether the security level should be HTTP_SHOW_WARNING (for nonsecure origins) or NONE (for secure origins). Bug: 797533 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I5400aaad91b55c3330d01c43bba5056b7351f723 Reviewed-on: https://chromium-review.googlesource.com/1031529 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#554759}
-
Quinten Yearsley authored
Change-Id: I5f4004b03dee29cd8d4bbdd03b597caf916f140d Reviewed-on: https://chromium-review.googlesource.com/1034295Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#554758}
-
