- 11 Nov, 2019 40 commits
-
-
Regan Hsu authored
Centering options should not appear for wallpaper images that are not saved on the user's device. Currently, they do for all images. This CL ensures that the 'center' and 'center cropped' options only appear for wallpaper images that are local to the device. screenshots: local image - https://screenshot.googleplex.com/iJmCUfbRiYK provided by google - https://screenshot.googleplex.com/kuD2X94vTUV Bug: 1022341 Change-Id: Icbf5afceb9dcd6615f9afb7fd0d5e1b8a6f3b982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904868Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714317}
-
Navid Zolghadr authored
Change-Id: I52d65971d0c049e7c7bc8c86a69303d60b26fa0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908718Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714316}
-
Theresa Wellington authored
BUG=1023437 TBR=pkotwicz@chromium.org Change-Id: I55cb5b40474a13a7e026c6c74e50f40d8c7f184c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906900Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#714315}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3573aac4baff..fc903818f301 git log 3573aac4baff..fc903818f301 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 dburger@chromium.org Remove more references to the no longer relevant binhost-pre-cq. 2019-11-11 dburger@chromium.org Paladin build timeout back to 5 hours. Created with: gclient setdep -r src/third_party/chromite@fc903818f301 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4634e310d2b36ae47ff21764859d44b461c19f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909649Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714314}
-
Yutaka Hirano authored
...to remove a finch warning. Bug: 1018081 Change-Id: Idbbe2b9c5eda9051ecac9887bccdf754046caeda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906457 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#714313}
-
Sergey Ulanov authored
shadow-call-stack is enabled by default on Fuchsia now, so we no longer need to enable it explicitly. Bug: 821951 Change-Id: I221bc557bf93dfd5bf7c1659f7f8dfc32129c6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898631 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#714312}
-
Toni Barzic authored
Instead of translating and changing opacity of the whole app list contents view, update the individual pages. This makes expand arrow translation unnecessary (it was causing the arrow to disappear for a moment when transitioning between peeking and full-screen state). Animate the apps container children's opacity separately - previously, the apps grid opacity was reset to match the final state when transitioning between app list view states, and we were relying on contents view animations to set up opacity as expected. This had an unintended consequence of apps grid clearing out when moving to closed state. Additionally, fixes ResetForShow not to reset search box opacity and contents opacity if the view is already animating to kClosed state (so if the app list is animating when the view state changes, the search box and contents opacity position gets animated from the current state instead of snapping to kClosed values first). BUG=1022656,1022655 Change-Id: I06d6521a067d81e159624d269ecc476435e19610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907473 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714311}
-
Lei Zhang authored
Several tests effectively have one-off implementations of GetRootAccessibilityNode(). Replace them. Fix some nits along the way. Change-Id: I966102e33d0d38fcd99291343c49a240a6884d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906302Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#714310}
-
Alex Newcomer authored
Just check that work area updates don't occur unless going to/from tablet mode. Bug: 1019531 Change-Id: Ie823fad80c4617137482ea3755b48490f01c71bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907414 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#714309}
-
James Cook authored
Follow-up to code review comments in: https://chromium-review.googlesource.com/c/chromium/src/+/1904342 Test that disabling the OS sync feature actually disables the sync system and disables the model types. Introduce shared OsSyncTest class because multiple tests will need to enable both the SplitSettingsSync flag and the OS sync feature. Bug: 1013466 Test: sync_integration_tests Change-Id: I503548e11f6118128178d294b4fb60041670ba7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906871 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#714308}
-
Sean Gilhuly authored
X11/X.h has a symbol conflict with dawncpp.h. Add "#undefine Always" to ui/gfx/x/x11.h. There were a few files that included resource_format_utils.h that had this conflict, so now ToDawnFormat() can be safely moved there. Also add a TODO mentioning the naive creation of a dawn::Device. Bug: 1021566 Change-Id: I8be84cac6e3450d6d35d2d182926e016ec2dbacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903623Reviewed-by:
Stephen White <senorblanco@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#714307}
-
Tom Anderson authored
This fixes an issue where display::Display::color_space()::IsValid() would always return false when no ICC profile was set up. This was causing HDR video playback to fallback to SDR even on HDR/WCG monitors. The solution is to obtain the colorspace information from the monitor's EDID. BUG=1021659 R=sky Change-Id: Iea05bc42f05112d6809887abf2b725807632e820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907427Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#714306}
-
Wez authored
Enable creation of the MultiSourceMemoryPressureMonitor under Fuchsia, and create a simple pressure evaluator implementation for WebEngine. Bug: 996028, 996030, 1020698 Change-Id: Ie3022866e1c13079fe629186d605912bcd04c215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897235Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#714305}
-
tby authored
Bug: 1011221 Change-Id: Ifa69d148a1a0e9080589554ccbe4f76817710ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909058Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#714304}
-
Becca Hughes authored
Add owners file for //chrome/browser/media/kaleidoscope which is where the public kaleidoscope code will live. The internal code will be in an internal repo that lives at //chrome/browser/media/kaleidoscope/internal. BUG=1023055 Change-Id: I37308be66f9612fff4fd0a194b5dedcfabd77972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907597Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#714303}
-
Robert Ma authored
https://crrev.com/c/1879970 made some behavioural changes to WebTestResults, which caused rebaseline-cl to skip some tests that should be rebaselined: namely when a testharness.js test without a baseline file (which implies all of its subtests pass) starts to fail. Bug: 1022519 Change-Id: Ie97998e8de6e3570e4aaf4e61a636c4d5a73c690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904340 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#714302}
-
Byoungkwon Ko authored
When new status are added, we should explicitly cater them. So we do not use 'default' of all switch statements that are using base::TerminationStatus. Bug: 1020020 Change-Id: I4819a43de5e1fda92ca252a2e7d162e1bc62698a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899644Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#714301}
-
chrome://media-appTrent Apted authored
chrome://media-app hosts a cross-origin (and unprivileged) <iframe> at chrome://media-app-guest. A few simple errors can be detected in the host, but proper integration testing requires postMessage, which this CL adds to the sandboxed context via test-specific JS code injection enabled in the host browser test harness. A simple test-only protocol is established over the postMessage channel for running querySelector in the sandboxed guest, and returning a string to the host context where the js2gtest is running. Test: MediaAppUIBrowserTest.GuestCanLoad Bug: 996088 Change-Id: Iaded2f1dd85c28e72d695a76916bbbc74aecd47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833374Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
-
Theresa Wellington authored
These tests are intermittently timing out on the 64-bit tester, but appear to be fine everywhere else. BUG=1023426 TBR=wenyufu@google.com Change-Id: Ibfc1f882d6e124b464e28d0f94b05f0248da6b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910302Reviewed-by:
-
Shawn Gallea authored
WebviewService will eventually be deprecated, this allows PlatformViewsService to create webviews. Bug: Internal b/144275588 Test: Build cast_shell Change-Id: I96251d199d7c466e13be5fc05769a1d0c4717beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907076Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#714298}
-
Raphael Kubo da Costa authored
IWYU. This fixes the libstdc++ build after commit df930962 ("De-duplicate multiple implementations of bluetooth address and UUID parsing"): ../../device/bluetooth/public/cpp/bluetooth_uuid.h:87:8: error: no template named 'vector' in namespace 'std' std::vector<uint8_t> GetBytes() const; ~~~~~^ Bug: 957519 Change-Id: I023a57e87cfac39cac2d1db0079458a562391424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910082 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#714297}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/126b6e947f19..1d3b6135c44d Created with: gclient setdep -r src-internal@1d3b6135c44d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1018879,chromium:None Change-Id: Idf8c4ce32198600f4096498800e3f692621529c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910502Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714296}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/26f7dde56c90..64e07f445a10 git log 26f7dde56c90..64e07f445a10 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 mbonadei@webrtc.org Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."" 2019-11-11 mbonadei@webrtc.org Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." Created with: gclient setdep -r src/third_party/webrtc@64e07f445a10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I87d733b0e5fd32b154959626089d5dba8e8ce525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910500Reviewed-by:
-
John Abd-El-Malek authored
Change-Id: I54cea5644a688fbc28dfcfd0e4b5de272eee43d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908064Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#714294}
-
Denis Bessonov authored
When a paint chunk having 0,0-0x0 rect is processed inside an effect, an early return prevents the effect_bounds_stack_.back() update in a ConversionContext::UpdateEffectBounds call. This results in keeping default PaintOp::kUnsetRect in SaveLayerOp::bounds instead of 0,0-0x0 rect. This is probably a reason for a related bug 918240 (see bug thread Comment 4 for details). Application of this patch fixes the lagging print preview. R=fmalita@chromium.org, samans@chromium.org Bug: 918240 Change-Id: I022ae01418e83184421cff7e22566228a2f7c6d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1396958 Commit-Queue: Denis Bessonov <dbessonov@yandex-team.ru> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#714293}
-
Jun Mukai authored
The autotestPrivate API provides the information of a window, but I guess some properties might not be very clear to every developers. I added comments to some of them, I hope some things are a bit clearer without looking into the code. Bug: none Test: none Change-Id: Iee076c45a89b0fdd8382f200cc584b86f3512671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907269Reviewed-by:
Ricardo Quesada <ricardoq@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#714292}
-
Mila Green authored
Specifically, delete the line of code which deletes the test file (and even asserts on that). This is not needed to test the functionality of the networking code and the file will get deleted when the ScopedTempDir gets out of scope. Bug: 1020650 Change-Id: Ib045cbd790c55753362c0e0367c61fd12bc35101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906473 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714291}
-
Manu Cornet authored
Separate suspension of shelf visibility updates and work area updates (the former is needed for desk transitions, the latter is needed for overview transitions). Bug: 1021691, 1017435, 1019531 Change-Id: Ie0bb64d931a06b2157a58afc2b1c8604ccf2d71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898718 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Theresa Wellington authored
BUG=1023429 TBR=yuezhanggg@chromium.org Change-Id: I3b7834debf66efd20034ae53699e26e34509d97f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910419Reviewed-by:
-
Piotr Bialecki authored
Currently, we extensively use VRPose to surface data to blink even for the entities where additional VRPose fields make no sense. In addition, VRPose allows for null position / orientation even though those entities will always have position and orientation known. I have decided against using gfx.mojom.Transform to surface that information since it allows for transforms that perform more than just translation and rotation and we would have to perform additional checks to enforce that no additional components are present. Bug: 1013229 Change-Id: I517a5b33aa905ca3c29e8b742c6767f2b6eb03bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887752 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#714288}
-
Sean Harrison authored
This CL does 3 things: 1) The order of rows in the privacy page is affected, regardless of the value of the "privacySettingsRedesignEnabled" flag. 2) The privacy-page is moved to the "basic", only when the "privacySettingsRedesignEnabled" flag is on. 3) A "more" expansion button is introduced in the privacy-page only when the "privacySettingsRedesignEnabled" flag. Bug: 1014143 Change-Id: I678e81aa3b67acd2ae41eeda355cd3b32a5b4088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872094 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#714287}
-
Yutaka Hirano authored
This is needed to start the experiment on beta. Bug: 1018081 Change-Id: I46aa390c69c9b152d0a217618cfc0b6bb46f4c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906856 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/f2fb48c3b3d7..076c46198fe1 $ git log f2fb48c3b..076c46198 --date=short --no-merges --format='%ad %ae %s' 2019-09-19 absl-team Googletest export 2019-09-27 gennadiycivil Bump llvm version to 4 so brew can work again Created with: roll-dep src/third_party/googletest/src CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official Change-Id: I5deffd4ea07a78bd62f1d18af23407ecb4e37462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909717 Commit-Queue: Staphany Park <staphany@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#714285}
-
Robert Liao authored
CComPtr has been deprecated in Chromium's codebase in favor of Microsoft::WRL::ComPtr. BUG=5027 Change-Id: I3918227f797ba1b5306cdd65a77f56a0a15bfdff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906249 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Stefano Sanfilippo authored
Reintroduce the modifying hook with the new signature. Scripts are executed if both TT and CSP allow them, otherwise throw an EvalError and send reports as side-effects. Non-string, non-trusted values are passed through, and skip any TT default policy. eval(TT) still returns the object if TT enforcement is disabled, for now. This is because unconditional codegen from strings overrides our callback. Bug: 940927 Change-Id: I718694cc050cf071a2ccf9669543628cf568cbdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768427 Commit-Queue: Stefano Sanfilippo <ssanfilippo@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#714283}
-
Eric Roman authored
This reverts commit 11ec6a9b. Reason for revert: The failed screenshot tests were not caused by this change Original change's description: > Revert "Make use of new hex decoding function for extensions color string parser." > > This reverts commit 2de0ccb8. > > Reason for revert: Suspecting cause for screenshot test failure. Seems unlikely but this is the only color related CL in regression range. crbug.com/1023255 > > Original change's description: > > Make use of new hex decoding function for extensions color string parser. > > > > Bug: 1021236 > > Change-Id: I1d1b5180048eb36fa78406a02fc3277cba0dcf63 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904809 > > Commit-Queue: Eric Roman <eroman@chromium.org> > > Commit-Queue: Reilly Grant <reillyg@chromium.org> > > Auto-Submit: Eric Roman <eroman@chromium.org> > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#713942} > > TBR=eroman@chromium.org,reillyg@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1021236 > Change-Id: I474f4e07583f571722e4bacf28ae482c071276a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909669 > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714159} TBR=eroman@chromium.org,reillyg@chromium.org,keishi@chromium.org Change-Id: Ifff4b8df577ad13e2cbffcfe90044caac9b0a888 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1021236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909654Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#714282}
-
Christian Dullweber authored
Bug: 1022562 Change-Id: I4a3bcc4c80a0e72f8df9244e481ff4e98227b1d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910228Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#714281}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/524459562448..3c4707d608f2 git log 524459562448..3c4707d608f2 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 swiftshader.regress@gmail.com Regres: Update test lists @ 414f99e0 2019-11-11 chrisforbes@google.com Relax descriptor set index assert at descriptor point of definition Created with: gclient setdep -r src/third_party/swiftshader@3c4707d608f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140648941 Change-Id: Iea02ca180b93e7964aa2fbc26effefe601fabc96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909638Reviewed-by:
-
Sky Malice authored
Bug: 1019707 Change-Id: Ia138c008fd201263d86f22fbafecb0ccf3406ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891586Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#714279}
-
W. James MacLean authored
Disabling contrib.cluster_telemetry.screenshot_unittest.ScreenshotUnitTest. testScreenshot and external/wpt/webdriver/tests/take_element_screenshot/iframe.py>>test_source_origin to de-jank the linux-trusty-rel bot. TBR=keishi@chromium.org Bug: 1023255 Change-Id: Ie8fbb182ba5d2d3c4df5282db62b72b622a26b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908715 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#714278}
-
