GitLab

https://webrtc.googlesource.com/src.git/+log/4fb12b0caec9..d8b9ed77cf52


git log 4fb12b0caec9..d8b9ed77cf52 --date=short --no-merges --format='%ad %ae %s'
2019-05-08 nisse@webrtc.org Promote RtcEventLogOutputFile to api/
2019-05-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision db92e075..8939017d (656805:657653)
2019-05-08 mbonadei@webrtc.org Do not use absl::flat_hash_map in DefaultVideoQualityAnalyzer.
2019-05-08 eladalon@webrtc.org Fix typo in SupportsEncoderFrameDropping's documentation
2019-05-08 jakobi@webrtc.org Add lifetime concealment stats to NetEqStatsPlotter.
2019-05-08 eladalon@webrtc.org Rename "average_freeze_duration" metric to "freeze_duration_average"
2019-05-08 eladalon@webrtc.org Add missing overrides to QualityTestVideoEncoder
2019-05-08 eladalon@webrtc.org Fix comment over Vp8FrameBufferController::SupportsEncoderFrameDropping
2019-05-08 jsphchn@google.com Add support for ignoring errors encountered while configuring preferred attributes of an audio session.
2019-05-08 nisse@webrtc.org Move some RTP-related observers from common_types.h
2019-05-07 eladalon@webrtc.org Add metrics related to video freezes to VideoAnalyzer
2019-05-07 sprang@webrtc.org Remove packets from RtpPacketHistory if acked via TransportFeedback
2019-05-07 mbonadei@webrtc.org Do not run CheckNoStreamUsageIsAdded on tests.
2019-05-07 mbonadei@webrtc.org DefaultAudioQualityAnalyzer: use bytes_recv instead of packets_recv.
2019-05-07 nisse@webrtc.org Log transport feedback max interval
2019-05-07 titovartem@webrtc.org Add support of specifying concrete codec for video stream
2019-05-07 nisse@webrtc.org Move RtcpPacketTypeCounter and observer to rtcp_statistics.h
2019-05-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2345bf12..db92e075 (656700:656805)
2019-05-06 andersc@webrtc.org Remove bitratePriority from the Obj-C RTCRtpEncodingParameters wrapper.
2019-05-06 asapersson@webrtc.org Add ability to configure quality scaler settings through field trial.
2019-05-06 ilnik@webrtc.org Don't invalidate whole update_rect if buffer conversion didn't change any pixels
2019-05-06 nisse@webrtc.org Add FILE* constructors to RtcEventLogOutputFile
2019-05-06 nisse@webrtc.org Delete windows-specific stop flag in PlatformThread
2019-05-06 mbonadei@webrtc.org Reland "Add Video Bwe stats collection to DefaultVideoQualityAnalyzer."
2019-05-05 hta@webrtc.org Revert "Version 2 "Refactoring DataContentDescription class""
2019-05-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ba5acd25..2345bf12 (656600:656700)
2019-05-05 hta@webrtc.org Version 2 "Refactoring DataContentDescription class"
2019-05-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0225b2f9..ba5acd25 (656458:656600)
2019-05-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b9ad721a..0225b2f9 (656347:656458)
2019-05-03 sprang@webrtc.org RtpPacketHistory: StoreAndCull default on, support ack removals
2019-05-03 peah@webrtc.org Remove deprecated call to UpdateHistogramsOnCallEnd
2019-05-03 peah@webrtc.org Remove the enable flag from AEC2 and AECM
2019-05-03 dklee@google.com Ensure that we always set values for min and max audio bitrate.
2019-05-03 srte@webrtc.org Don't require call to ValidateFieldTrialsStringOrDie for ScopedFieldTrials.
2019-05-03 andersc@webrtc.org Add priority to RTCRtpEncodingParameters.
2019-05-03 perkj@webrtc.org Provide AlrDetector with event log in GoogCC.
2019-05-03 srte@webrtc.org Allows injection of network controller factory in test fixture.
2019-05-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e821123c..b9ad721a (656244:656347)
2019-05-03 ilnik@webrtc.org Remove deprecated interface in I420BufferInterface::GetI420
2019-05-03 henrik.lundin@webrtc.org NetEq: Minor change to print-out format for interruption stats
2019-05-03 ivoc@webrtc.org Expose new audio stats on the API
2019-05-03 srte@webrtc.org Adds debug printing of network estimate.
2019-05-03 srte@webrtc.org Avoids mismatching packets on wraparound in log parser.
2019-05-03 eladalon@webrtc.org Rename configurations_ to vpx_configs_ in LibvpxVp8Encoder
2019-05-03 eladalon@webrtc.org Refactor handling of configuration overrides from Vp8FrameBufferController
2019-05-03 peah@webrtc.org Remove the reporting of histogram data for AEC2
2019-05-03 nisse@webrtc.org Delete deprecated PlatformThread looping
2019-05-03 julien.isorce@chromium.org Check nullity of CGColorSpaceCopyICCProfile's return value
2019-05-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ea179c51..e821123c (656127:656244)
2019-05-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b510663a..ea179c51 (655963:656127)
2019-05-02 srte@webrtc.org Reland "Reland "Improving robustness of feedback matching code in event log parser.""


Created with:
  gclient setdep -r src/third_party/webrtc@d8b9ed77cf52

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:none,chromium:930186,chromium:None,chromium:None,chromium:None,chromium:None,chromium:none,chromium:None,chromium:945468,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ica294935dc913db249608b61b0c6f4e04b5b0cbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601223Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657704}

Bug: 941690
Change-Id: Ic05861d2d813a4104957e0bd355c9e8dcd20f7ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596322Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Pavel Shmakov <pshmakov@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657703}

UnescapeBinaryURLComponent() unconditionally escapes all escaped
characters. It was using UnescapeURLComponent(), which leaves
"%00" though "%1F" escaped, as well as certain UTF-8 characters that
aren't safe to display in the omnibox. Since a GURL is constructed
with the result, it will re-escape all these characters, anyways,
with the exception of when these characters appear at the end of a
URL, in which case GURL will truncate them. Since GURL does this for
spaces, too, and this wasn't a problem before, presumably it's fine
for these more obscure characters, too. The UTF-8 characters that
aren't safe to unescape for display in the omnibox are still valid
UTF-8 characters, and it doesn't make sense to keep them escaped when
they're not for display to the user.

This CL is part of a project to clean up uses of
UnescapeURLComponent(), as it's been used for wildly disparate
purposes, and much of its logic is only suitable for cases where
we want to format a URL for safe display to the user. We want
to make it leave additional weird characters escaped, but need to
eliminate usage of it in other contexts before we can do that.

UnescapeBinaryURLComponent() should be used instead in most cases,
particularly where URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS is in use,
as all consumers of that option seem to either be slightly buggy, or
don't actually need to leave any characters unescaped. The primary
cases where switching to UnescapeBinaryURLComponent() may cause
problems (without additional checks), are cases where unescaping
path separators or funky characters (like %01) is a problem. In those
places, we should generally fail instead of partially unescaping a URL.

Bug: 849998
Change-Id: I6c086765c77d68cb4f164ba7891737fb08925462
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592807
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657702}

Lack thereof caused a compile failure:
  https://ci.chromium.org/p/chromium/builders/ci/win-rel/15603

Bug: 960460
Tbr: rdevlin.cronin@chromium.org
No-Tree-Checks: true
No-Try: true
Change-Id: I122bbabdc2590c4a06b0330ca1aa080e75a295f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600837Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657701}

This reverts commit 255dca91.

Reason for revert: Still breaks pixel2 bots, now due to aapt2 error loading libc++.so.


Original change's description:
> Reland "[Perf] Update Pixel2 FYI perf bot to MonoChrome6432.aab."
> 
> This is a reland of e3d9c6d3
> 
> Original change's description:
> > [Perf] Update Pixel2 FYI perf bot to MonoChrome6432.aab.
> >
> > This will update the Pixel2 bots to use the MonoChrome6432.aab which is a 64bit
> > browser. In making this change a new 'exact_browser' option is added to
> > tester_config in perf_data_generator to allow specifying a particular binary to
> > be run rather than guessing.
> >
> > Reland of: https://chromium-review.googlesource.com/c/chromium/src/+/1511455
> >
> > TBR=crouleau@chromium.org,perezju@chromium.org
> > BUG=934251
> >
> > Change-Id: I21bf7ae8e42f0e4c127748eeecc58a8af34334a1
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587563
> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
> > Auto-Submit: Ross McIlroy <rmcilroy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#654862}
> 
> TBR=crouleau@chromium.org
> TBR=perezju@chromium.org
> 
> Bug: 934251
> Change-Id: I18a8dcb554f52ddff6e1b39d02566faff67c68a3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599614
> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#657640}

TBR=rmcilroy@chromium.org,perezju@chromium.org,crouleau@chromium.org

Change-Id: Idfef7d330bb25e965c5c834b5d4b58ed68eba238
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 934251
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601040Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657700}

It has been using UnescapeURLComponent() instead to unescape file names.
UnescapeURLComponent() leaves various UTF-8 characters that are unsafe
to display in the omnibox, but valid in other contexts escaped, as well
as "%00" through "%1F". In addition, it was being told to keep path
separators escaped. The UTF-8 logic was unnecessary here, and it's
better to fail on unexpected input rather than to partially unescape
it. Switching to UnescapeBinaryURLComponentSafe() gets us both of
these behaviors.

This CL is part of a project to clean up uses of
UnescapeURLComponent(), as it's been used for wildly disparate
purposes, and much of its logic is only suitable for cases where
we want to format a URL for safe display to the user. We want
to make it leave more weird characters escaped, but need to
eliminate usage of it in other contexts before we can do that.

UnescapeBinaryURLComponent() should be used instead in most cases,
particularly where URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS is in use,
as all consumers of that option seem to either be slightly buggy, or
don't actually need to leave any characters unescaped. The primary
cases where switching to UnescapeBinaryURLComponent() may cause
problems (without additional checks), are cases where unescaping
path separators or funky characters (like %01) is a problem. In those
places, we should generally fail instead of partially unescaping a URL.

Bug: 849998
Change-Id: I009667ec4ccf92e49810ece56d5e2f8e9604a096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598321
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657699}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bde98f63..c562f4de

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia1aed0e84f713f90a0f4bdecc607805adea46e77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601116Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657698}

1. Change proto package name to viz.proto.
2. Move FuzzedCompositorFrameBuilder into source file and just expose a
   helper function.
3. Update a few comments.

Bug: 923088
Change-Id: I42a57d223c5206f17c77088bb1e256be37b89f0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596834Reviewed-by: Sean Gilhuly <sgilhuly@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657697}

- Emit trace event when the time is unpaused when Pauser is destroyed.
- Randomise trace_id to avoid collisions with other events.

R=alexclarke@chromium.org
TBR=haraken@chromium.org

Change-Id: I7492cf1975dc6735dda143b981943b73d2f65b13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601033Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657696}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f21a6e5b1ab..746bb12c4652


Created with:
  gclient setdep -r src-internal@746bb12c4652

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=dvadym@chromium.org,noel@chromium.org,jbroman@chromium.org,xialinyan@chromium.org

Change-Id: Icd705981ede418b5cfde739c11adb17975f17a18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601222Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657695}

As the visual left/right caret movement has become un-maintainable,
this patch removes them and replaces them by logical movement.

This patch:
- Exposes line direction utilities from inline_box_traversal.cc to be
  reused by SelectionModifier. These utilities will be moved/refactored
  later for better code structure.
- Changes SelectionModifier to use logical left/right movements for
  character and word granularities.

All other changes are removal of dead code and test expectations
changes.

Bug: 958831
Change-Id: Ic4cf83290beb2521c620167be32b4fa4d716a3c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593632
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657694}

Use BackgroundTaskScheduler for Background Sync everywhere by default.

Status of ramp up:
Currently this feature is enabled at 1% on stable.

Next steps:
1. After this CL is merged, I'll enable it at 100% everywhere via Finch.
2. I'll remove the field trial test config.
3. Remove the feature flag and all code that checks for it + now dead code.

Bug: 924490
Change-Id: Ia4578e283997da0b716ddbfef72222105ec2285f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599528Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657693}

Before this CL:
When the account that Sync uses switches from being secondary to being
primary (i.e. the user opts in to full Sync), then SyncAuthManager
exposes that as a sign-out + sign-in to its client (ProfileSyncService).

After this CL:
In this situation, SyncAuthManager just sends a single
AccountStateChanged notification, and ProfileSyncService handles this
case appropriately by reconfiguring itself.

This seems like it'd be a rare edge case, but it can happen during the
regular Sync setup flow: The account becomes available (i.e. has a valid
refresh token) before it is marked as primary. The consequence was that
Sync would begin to start up (in transport mode), but then immediately
get shut down, just to start up again. One concrete outcome was that
two cache GUIDs got generated, which could muddle up metrics.
After this CL, Sync does not get shut down in between, but just gets
reconfigured.

Bug: 956478
Change-Id: If8396f604fc1430c81b5a86d3f684252cb3f4c2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598805Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657692}

This change relands
chromium-review.googlesource.com/c/chromium/src/+/1595219 but with a fix
for the Win7 test failure. The only difference between this CL and the
original CL is the edits to delayloads_unittests.cc.

This change is a follow-up to
https://chromium-review.googlesource.com/c/chromium/src/+/1551709. It
removes the chrome_elf_imports_unittests executable and combines the
tests with the similar tests in the more generic delayloads_unittests
executable. It also adds delayloads_unittests to the pipeline for
execution.

Bug: 948829
Change-Id: I9713d51f6393c5e134607644672d616a5ea30993
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597222Reviewed-by: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#657691}

Want to use this for official builds.

Bug: 960197
Change-Id: I07e16c1caf375742d4951c315f1c20a2dc38b711
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601294
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657690}

- DCHECK -> CHECK in Bus::AssertOnOriginThread/DBusThread to
  enable thread assertion in release build;
- Add warning log if Bus::SendWithReplyAndBlock takes more
  than 1 seconds;

Bug: 883029
Change-Id: Id630ed56e82a24c88c96820cfc36f5b36c72dd00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594064Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657689}

The motivation is that some projects (e.g. v8) deps in a git mirror of the
build/ directory but don't have tools/win available. This makes the build/
directory not depend on tools/win again.

Bug: 960658
Change-Id: Ibaa9a81862e89ea049299149a5d9aa7e7c4b5850
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600776
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657688}

Speculative fix for histogram recording - int values are not registering
in UMA.  Maybe avoiding the converstion to long will fix.

BUG=960613

Change-Id: Ia639c3a4b16091af6c82c007bfde97ae7653e5d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600640
Auto-Submit: Donn Denman <donnd@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657687}

This reverts commit dc16c8dc.

Reason for revert: Fails on regular ASAN builds because all unreachable objects are poisoned directly after marking.

Original change's description:
> timer: Specialize TaskRunnerTimer for GCed classes
> 
> This allows us getting rid of WillObjectBeLazilySwept which peeks into
> garbage collection internal state.
> 
> Change-Id: I82b38def090c33f1b6e6727ab4b685abb0409ea1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598826
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#657650}

TBR=haraken@chromium.org,mlippautz@chromium.org

Change-Id: I38047dc29ca14158aa891d99c15e218c1fdb7570
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 960775
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599623Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657686}

This reverts commit b4d80c99.

Reason for revert: Pursuing alternate strategy of preserving base::MD5 interface, but replacing its implementation with boringssl.

Original change's description:
> Replace base MD5 impl with boringssl in //net
> 
> This CL also makes several IWYU changes outside of //net. After making the
> changes in //net, these missing includes became compilation errors.
> 
> Bug: 755368
> 
> Change-Id: Ieb18e0ab0dd4478f9ce8285f45ecee21a9c84e0c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570525
> Commit-Queue: Daniel McArdle <dmcardle@chromium.org>
> Reviewed-by: Nathan Parker <nparker@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
> Auto-Submit: Daniel McArdle <dmcardle@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#656167}

TBR=rsleevi@chromium.org,thakis@chromium.org,peter@chromium.org,sammc@chromium.org,nparker@chromium.org,olivierrobin@chromium.org,dmcardle@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 755368
Change-Id: I1486c246381b67052e85c1fbb2d81309b919526c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601193Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Daniel McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657685}

This CL makes VASurface's ReleaseCB |release_cb_| a OnceCallback,
since it doesn't make any sense that a release callback can be
called repeatedly.

Callsites use BindOnce() to bind to a RepeatingCallback for
conveniency, since |va_surface_release_cb_| is bound once on
the main thread with a WeakPtr.

Test: chrome plays video on nocturne, v_d_a_unittests on the same.
Bug: 822346
Change-Id: I7f0bb1658981f89b5b3a7d2bae388cec4b99efd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598496Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657684}

Since users can type arbitrary strings, these lines are reachable and must be
handled.  For now, handle as they were already, e.g. by returning zero.  We may
later decide to do something else, e.g. return nullopt.

This also adds better range-checking, so that e.g. "257" entered for an int8_t
does not become "1".

Bug: none
Change-Id: I4a0185f921c3f40f38439798c52de0ce92f3be30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600650
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657683}

TBR: thestig@chromium.org
Change-Id: I678bae3ca64bde9c8628a44997e507f506a5a140
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601295
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657682}

The current approach is quite confusing and inconsistent. The value
nullptr means too many different things, depending on the situation.

This CL introduces a new, hopefully clearer model, where nullptr always
means invalid at computed-value-time, and base::nullopt means "no entry
found". This means that, if a ComputedStyle has a present entry of
'nullptr' for a given custom property, we do not e.g. fall back to
values from StyleInitialData.

However, if there is no entry (base::nullopt), we look up values from the
root-bucket (see StyleInheritedVariables), and/or StyleInitialData.

A consequence of this approach, is that explicitly applied initial and
inherited values must actually be present on the ComputedStyle; we can not
return to a state of base::nullopt. This is because of the root-bucket
optimization of StyleInheritedVariables, which makes it impossible to
actually erase a value in all cases. (We actually don't have the same
restriction for StyleNonInheritedVariables, but the behavior is the same,
for simplicity).

Another change in this CL, is that StyleInitialData now has the initial
"data" as well as the initial "values". This is again to avoid that
nullptr has different meanings. If we didn't store the initial data,
we could end up with a nullptr for registered properties with an
implicitly initial value. This is incompatible with the "nullptr means
nullptr" idea.

Note that CSSInvalidVariableValue isn't technically needed anymore after
this CL, but since it's going to be useful for the Cascade project (during
the application phase only, not as a persistently stored object), I'd like
to keep it. It has a unit tests, so it's not completely unused.

BUG=947004
R=futhark@chromium.org

Change-Id: I4922f0d36f3d3d4fde6a25e56ef5c14c0c9890f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601135Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657681}

Bug: None
Change-Id: Ie7b3b5a4c7c2649d7bd0c4916ce2696abc0cc70d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595452
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657680}

https://android.googlesource.com/platform/external/perfetto.git/+log/c2849eabed44..254a80307c6e


git log c2849eabed44..254a80307c6e --date=short --no-merges --format='%ad %ae %s'
2019-05-08 lalitm@google.com metrics: fix reading uninitialized memory in metrics platform
2019-05-08 lalitm@google.com Merge "trace_processor: add metrics test infra"


Created with:
  gclient setdep -r src/third_party/perfetto@254a80307c6e

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I63360d9a0206bd50db93d962c7cf44a9c69e05ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601181Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657679}

We were always sizing grid containers with "contain: size" as 0x0.
However this is wrong as discussed on the following GitHub issue:
https://github.com/w3c/csswg-drafts/issues/2804

To do this we add a new method to GridTrackSizingAlgorithmStrategy
called IsComputingSizeContainment() to determine the cases
in which we're computing the size containment dimensions.
That way we can run only the initialization step instead
of the full algorithm to get the expected track sizes
for size containment.

For widths the change is pretty simple
in LayoutGrid::ComputeIntrinsicLogicalWidths().
For heights we don't have a phase to compute the intrinsic size
so apart from the changes in LayoutGrid::UpdateBlockLayout()
we need some extra checks in LayoutBox too.

There is a minor change in test contain-size-grid-002.html,
because after this patch it was not passing yet due to some overflow
that is unrelated to the purpose of the test.

BUG=855261
TEST=external/wpt/css/css-contain/contain-size-grid-002.html
TEST=external/wpt/css/css-contain/contain-size-grid-003.html

Change-Id: I4d0fd417183068518070721afde84efdbfe1fcb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1355923
Commit-Queue: Manuel Rego <rego@igalia.com>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#657678}

https://skia.googlesource.com/skia.git/+log/f90bfd72174b..15c91422339a


git log f90bfd72174b..15c91422339a --date=short --no-merges --format='%ad %ae %s'
2019-05-08 robertphillips@google.com Repro Chrome bug and add Skia-side fix


Created with:
  gclient setdep -r src/third_party/skia@15c91422339a

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:958055
TBR=robertphillips@chromium.org

Change-Id: I0ccbd4e049b68becfaddcdf41efd7c853aa26e8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601180Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657677}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0cb2d605cc4a..5f21a6e5b1ab


Created with:
  gclient setdep -r src-internal@5f21a6e5b1ab

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=dvadym@chromium.org,noel@chromium.org,jbroman@chromium.org,xialinyan@chromium.org

Change-Id: I0209e6f00184270d09cf35513b52c15e0c62598d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601179Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657676}

This is a follow up to r649499. The Update method now matches Save() method.
The replacement logic is now in UpdateReplace().

Bug: 936011,831123
Change-Id: I59d65fe77ef3b386e80ba890e140370d190555c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596456
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657675}

Bug: 938501
Change-Id: Ic04556279c23eb5db8e4435a2f339c98de97b27f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597470Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657674}

Using wpt-import in Chromium 698fa94d.
With Chromium commits locally applied on WPT:
e28269b6 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting."
aff3c8fe "Add tests for crbug.com/363609 and crbug.com/954591"
c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed"
fec827fb "Added wpt tests for overscroll customization."
a554ea37 "Reland "[EventTiming] Round instead of ceil the |duration|""
a06bcc90 "WebXR: Rename requestSession parameter variables to match use"
eeafcaee "[sms] Introduce testing infrastructure and handle some corner cases."
c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet"
08cc019f "[XHR] Use response tainting to calculate CORS-exposed header-name list"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: Ieb183edd8a7c109f2808e1b37611244e288d74b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600731Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657673}

This reverts commit a521561e.

Reason for revert: very likely cause for https://crbug.com/960763

Original change's description:
> macOS V2 GPU Sandbox: Diagnose mach service hang.
> 
> This is a temporary CL to locate and diagnose a mach service acccess
> that is hanging.
> 
> Bug: 871280
> Change-Id: I8ef068baa2f6f4b6eb3dd7a15671dffc399db2dc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599251
> Commit-Queue: Greg Kerr <kerrnel@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Auto-Submit: Greg Kerr <kerrnel@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#657377}

TBR=kerrnel@chromium.org,rsesek@chromium.org

Change-Id: Ie2351b19805c898a2809aad094bc8345f17abc0b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 871280
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600835Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657672}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9e4ae309..bde98f63

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I009d08b8cfa5dc4e109314d91b8fdc745d93b6e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600955Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657671}

Change-Id: Ic63c722103e24d0fff3a612ec1b626b882ed74a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599602Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657670}

Remove the all-in-one CreateSysInfo() targets.

Bug: b/130731732
Change-Id: I83bd36bd625a4a736ff1e25b1bc09555ed34cff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583422
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657669}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ibe1ed18d8f97dd4830d286d8787782e0f450805a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601115Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657668}

https://android.googlesource.com/platform/external/perfetto.git/+log/5f3a01805f61..c2849eabed44


git log 5f3a01805f61..c2849eabed44 --date=short --no-merges --format='%ad %ae %s'
2019-05-08 hjd@google.com Add example camera config


Created with:
  gclient setdep -r src/third_party/perfetto@c2849eabed44

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ieaf467fb99801b34d38fc41319312186b352490b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601174Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657667}

Replace the use of std::map of std container with WTF::HashMap in
image.cc/h and use FloatSize instead of std::pair as HashMap's key.

Bug: 952716
Change-Id: I8476fd4710f71469806c6118e0dcfe37602bfe30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599813Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#657666}

In current implementation, retry() ignores |error| member. So, before
this patch, nothing was displayed on the payment sheet UI even if
retry() is invoked with custom error message.
After this patch, JS authors can display a custom message on the payment
sheet UI via |error| member when invoking retry(). If the |error| member
is empty, UA displays default error message.

This feature is behind a flag:
  chrome://flags/#enable-experimental-web-platform-features

Manual Test:
  wpt/payment-request/payment-response/retry-method-manual.https.html
  wpt/payment-request/PaymentValidationErrors/retry-shows-error-member-manual.https.html

Bug: 861704, 942204
Change-Id: Id23a2924ca1d5c2f32416c7de6210357bf4e6296
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575307
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657665}