- 13 Aug, 2019 40 commits
-
-
Justin Cohen authored
Bug: 992500 Change-Id: I797068fb5d58f5ebb19231d2c77ef1d5cb60b3f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724702Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#686623}
-
Derek Schuff authored
Bug: 701326 Change-Id: If652eb76fabc09cabdd61865cdb409f72c140392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748083Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Derek Schuff <dschuff@chromium.org> Cr-Commit-Position: refs/heads/master@{#686622}
-
Chris Lu authored
The UMA metrics logging for Infobar badges was removed in crrev.com/c/1717651. This change adds it back in BadgeActionDispatcher. A new 'accepted' property is added to the BadgeButton to determine badge state for the metrics. Bug: 976901 Change-Id: Ic81988d59f6695a1b32e1ca0b4e340cc20966d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749602 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#686621}
-
Lan Wei authored
This reverts commit 95343512. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable flag "UpdateHoverAtBeginFrame" > > Blink.MainFrame.StyleAndLayoutRatio metrics has a significant > regression increase, we will disable flag "UpdateHoverAtBeginFrame" for > now in M78 to help identify what is the reason to cause this > regression. > > TBR=bokan@chromium.org > > Change-Id: Ic85d4c142a2a25928c3ec25a61de20649144ef50 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733037 > Reviewed-by: Lan Wei <lanwei@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#684518} TBR=bokan@chromium.org,lanwei@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Id6ad8e351ed45dc60d21984ef49bcbbe45dd5b2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752765Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#686620}
-
James Cook authored
ui.MashLogin and ui.SingleProcessMashLogin don't exist any more. Bug: none Change-Id: I9a0d4650a4d3887cf0592f428a2a3cf81f28b82c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752539 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#686619}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/772d5c6161c5..942e493326d1 git log 772d5c6161c5..942e493326d1 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 simonhatch@chromium.org Pinpoint - Record the estimate along with the timing info. Created with: gclient setdep -r src/third_party/catapult@942e493326d1 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:992523 Change-Id: Iea917a9ff732fa1f5310f635897d7b6b7a1f60f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752902Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686618}
-
Simon Pelchat authored
Some navigations are both forward/back and reload. As far as page_end_reason is concerned, these should be considered as history navigations. Most "true" reloads result in the user loading the same URL again (e.g. pull-to-refresh or preview opt-out button). By contrast, navigations that are both forward/back and reload navigations usually result in loading a different URL. Bug: 991741 Change-Id: Iac70ec0b62f6b9bd228419d127ae338ebb4ff5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743129Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Simon Pelchat <spelchat@chromium.org> Cr-Commit-Position: refs/heads/master@{#686617}
-
Derek Schuff authored
This mirrors the announcement that was sent to native-client-discuss. Bug: 918374 Change-Id: I2e82c60533a2215bdc08ab6668031cba8e94498d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750204Reviewed-by:
Sam Clegg <sbc@chromium.org> Commit-Queue: Derek Schuff <dschuff@chromium.org> Cr-Commit-Position: refs/heads/master@{#686616}
-
Antonio Gomes authored
... when posting tasks. A task posted runs once, so CrossThreadBindRepeating is not strictly correct. This is now possible, after [1]. [1] crrev.com/c/1750043 BUG=964922 R=jbroman@chromium.org Change-Id: Ic3a7cf2fbcd6c07b92efaeab206e45a0cd1e418f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752077 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#686615}
-
Philip Rogers authored
Now that BlinkGenPropertyTrees (BGPT) has launched, we can remove the pre-BGPT code. Bug: 989251 Change-Id: I7c64da9fd5e593436301936abcef3e39198ccbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752244 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#686614}
-
Sunny Sachanandani authored
Bug: 892874 Change-Id: I15a63a95302d8cf55935f1287d4e9b8fb458ada5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747070Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#686613}
-
Brian Sheedy authored
Adds "Linux FYI Release (Intel UHD 630)" to chromium.gpu.fyi, which is identical to "Linux FYI Release (Intel HD 630)" except that it has longer timeouts and triggers tests on a machine with a newer GPU. Bug: 986939 Change-Id: I58a569330390310d9224be3fed86b87a53d2ebed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752291Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#686612}
-
Rose Garcia authored
Put the selection change listener and the clipboard data change listener behind the text editing improvements flag. This makes sure the menu isn't reloading uncessarily when the flag is not used. Bug: 982004 Change-Id: Iafde32d263e41030ba54a6b5ae98bed2c968d8f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746790 Commit-Queue: Rose Garcia <rosalindag@google.com> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#686611}
-
Wez authored
Bug: 991300 Change-Id: I720433a8d9673bf1f08634ac2709f22e18408668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750343 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#686610}
-
Robbie Gibson authored
Before, the color of the tiles wasn't updated in dark mode. Now, both the most visited and the shortcut tiles have their colors updated. The |+backgroundImage| class method can be removed because now, both tiles use the background as a template image. Bug: 991973, 976641 Change-Id: I3db5204ec7684f592e67c6b7fa6ff8944b5ac839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751328Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#686609}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e765f652958c..6bb29da82994 git log e765f652958c..6bb29da82994 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/depot_tools@6bb29da82994 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: None Change-Id: I8b35fa509d1cbc897509622c852ca0bf5e9c4ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752301Reviewed-by:
-
Sorin Jianu authored
TBR=waffles CC=tommycli Bug: 992551 Change-Id: Ie434b71f7eb1541c01e1d08eb899cb9eb69c5799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752868Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#686607}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9fbd0f9b5e9..d550b702ac53 Created with: gclient setdep -r src-internal@d550b702ac53 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None Change-Id: Ic40e4db5230d082c0e7c424b80a4e5d085836beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751770Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686606}
-
Matt Jones authored
This patch removes two concepts from the BottomSheetController: - Full show request: This was relevant when a function to preload content existed. Since that function was removed long ago, the map tracking these requests is no longer useful. Content that needs to pre-load can be done on a per-feature basis outside of BottomSheet code. - Shown for tab: This concept prevented a sheet content from auto- peeking multiple times for a single web page. No features currently use this concept and, if needed, could be implemented on a per- feature basis. Bug: 986310 Change-Id: I7b965cab4434cded6e729290af5413affc110edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745398 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#686605}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5c7d9733468d..565082dac784 git log 5c7d9733468d..565082dac784 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 treehugger-gerrit@google.com Merge "Simplify proto descriptor rules" 2019-08-13 treehugger-gerrit@google.com Merge "Parse chrome log messages in the trace processor" Created with: gclient setdep -r src/third_party/perfetto@565082dac784 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I6b1cc67ade3b23abf3ba1905a88895e471c9c934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752703Reviewed-by:
-
Takumi Fujimoto authored
Fix a bug where a scoped_refptr was incorrectly scoped in an if-block, causing encoding to fail. Bug: 991287 Change-Id: Iebce34a1349c968bc808ac5a225ae33df6845c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748079Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#686603}
-
Kevin Babbitt authored
Address comments left on http://crrev.com/c/1669947 post-land. Bug: 974397 Change-Id: I2f50f9c676d89ed1c20b06913d6607cd0dc41122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750151Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#686602}
-
Sunny Sachanandani authored
1) Present swap chain before exporting back buffer in FinalizeFrame(). 2) Check that drawing buffer is actually using a swap chain instead of just checking the runtime feature flag. Bug: 939657 Change-Id: I235fe95c257c1e9971667e0e41c8d27bc27ad133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745404 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
-
Nina Satragno authored
This patch adds code to explicitly send a wink command to U2F devices whenever an operation requires a test of user presence. This needs to be sent for older devices that will not blink on their own. Bug: 990456 Change-Id: Ia44d0e139f4946742514eb6bf3484d13aa501b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746630 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#686600}
-
David Schinazi authored
This CL mitigates the following HTTP DoS attacks in Chormium: CVE-2019-9512, CVE-2019-9514, CVE-2019-9515. It does so by closing the connection if we try to enqueue an excessive number of frames. Change-Id: Id51cd6d15d22fadae9151bd9567e55d603bc62d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752387 Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#686599}
-
David Benjamin authored
This CL is part of a larger project to remove the LOAD_DO_NOT_* privacy load flags and replace them with the allow_credentials setting. See https://crbug.com/799935 and https://docs.google.com/document/d/1ntn9N7Ce2jozvvpWI0XbzJ7lJdwUjJXK07wp7rxrIN4 for the motivation for this change. Using credential_mode makes it harder to forget LOAD_DO_NOT_SEND_AUTH_DATA along with the two cookie flags. This has two implications: - The request will no longer participate in HTTP auth if the server requests it. HTTP auth credentials identify the user, so private requests should not send them. Note this only affects server auth, not proxy auth. Unless the server your feature speaks to requests HTTP auth, this is a no-op. - The request will be pooled with sockets used for uncredentialed requests, rather than credentialed requests. This is not expected to meaningfully change behavior. If your code requires HTTP authentication, let me know. You may need to allow credentials for your request. Bug: 799935 Change-Id: I64c4c87a16cfb70e1ffbb5abdcc9097c48ef9956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752745 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#686598}
-
Bo Liu authored
Both are per-webview objects. RootFrameSink lives on the viz thread, and responsible for per-webview objects that do not require access to the GPU. This is mostly classes involved for sending begin frames. RootFrameSinkProxy straddles UI and Viz thread and provides access to RootFrameSink. Bug: 805739 Change-Id: I4c7e31882d35eb3f772bd81b62a40a47c279de1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749527 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#686597}
-
Caroline Rising authored
Stable approval has been given for 76 in crbug/962604. Bug: 910739 Change-Id: If66c3c8954794126ff194c3d681c3cc71ec20759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747977 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#686596}
-
Tommy Li authored
This reverts commit cb7925c3. Reason for revert: Seems to be the likely cause of failures starting here: https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/50083 Speculatively reverting. Original change's description: > gl: Disable swiftshader on audio only devices > > Audio only devices have no display and no GPU. Disable swiftshader so we > don't see an error on startup trying to load it. > > Bug: b/139101843 > > Change-Id: Ib15d38a1da17e8a5057390879fd684a8b2b9bd67 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752167 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Michael Spang <spang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686505} TBR=spang@chromium.org,kbr@chromium.org Change-Id: I69eef9416529cfcff37e5f657c855908e453153b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/139101843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752911Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#686595}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5e97d0125fd9..42424bf2eab6 git log 5e97d0125fd9..42424bf2eab6 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 tsepez@chromium.org Remove SystemFontInfoIface::MapFontByUnicode(). 2019-08-13 tsepez@chromium.org Remove knowlege of whether XFA is present from pwl/ window layer 2019-08-13 thestig@chromium.org Do CPDF_CMap loading in the constructors. 2019-08-13 thestig@chromium.org Remove CXFA_Document::HasFlag() and SetFlag(). Created with: gclient setdep -r src/third_party/pdfium@42424bf2eab6 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Icdf518953b0e68a0b12963767fa8ae12de1f1f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752782Reviewed-by:
-
Pavol Marko authored
Starting with M-78, use CertVerifierBuiltin for sign-in/lock profiles unconditionally. This allows easier reasoning about the state when implementing features that rely on the CertVerifierBuiltin to be enabled on the sign-in screen. Bug: 939344 Test: browser_tests --gtest_filter=*ProfileNetworkContext* Change-Id: I5d53b1b534370592fbd57d9bbbbc830962f32388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750004 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#686593}
-
Sophie Chang authored
This makes it easier to join the browser tests to test both the original and OptimizationGuideKeyedService code paths Bug: 969558 Change-Id: I93c7a733c187b18c33cecce9a5c6c82ebd9f4996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752762Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#686592}
-
Martin Kreichgauer authored
TBR=dbeam@chromium.org Change-Id: I348816d4cbc717b3aae9ca18612fa2a1f67ffa55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752558Reviewed-by:
-
Min Qin authored
When download is paused, watching the mojo data pipe for data ready callback is not needed. As the callback will trigger an early return and do nothing. We can register the callback later when download is resumed. BUG=927530 Change-Id: Ifc225241978cb34991846ffb4a6a40166e5fc953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748122Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#686590}
-
Sean Gilhuly authored
Add new baseline images for the flag --enable-gpu-rasterization that are used by these SkiaRenderer variants: GL, GL Swiftshader, Vulkan, and Vulkan Swiftshader. Add a new FlagExpectations file for skia_renderer_gl_blink_web_tests for the tests that are failing on Skia GL. Bug: 954328 Change-Id: I289cccb773513ab3199b624cb0af63f06556c2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747983Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#686589}
-
Pavol Marko authored
Support generating policy sources from policy_templates.json without version restrictions. This is useful for testing where we may want to set policies that are not yet supported or are not supported anymore. python components/policy/tools/generate_policy_source.py \ --policy-templates-file=components/policy/resources/policy_templates.json \ --target-platform=chromeos --chrome-version-file=chrome/VERSION \ --policy-constants-source=test.cc and python components/policy/tools/generate_policy_source.py \ --policy-templates-file=components/policy/resources/policy_templates.json \ --target-platform=chromeos --all-chrome-versions \ --policy-constants-source=test2.cc then diff test.cc test2.cc Bug: 976424 Test: Run Change-Id: I3d0b7a0676ba771aec06ff7df0465e3b9539fd62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686668 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by: -
Francois Doray authored
Currently, LocalFrame::DidFreeze performs these steps: 1. Obtain the DocumentResourceCoordinator. 2. Dispatch the beforeunload event. 3. Invoke SetHasNonEmptyBeforeUnload on the DocumentResourceCoordinator. However, it is believed* that dispatching the beforeunload event can invalidate the DocumentResourceCoordinator (by shutting down the document), which causes an invalid access at step 3. With this CL, the latest DocumentResourceCoordinator is obtained just before calling SetHasNonEmptyBeforeUnload. *Ideally, a Blink expert could confirm if that's a reasonable assumption. Bug: 991380 Change-Id: Ie542b34a67900d427fbdc720f0d362522eba5da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749531Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#686587}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/83ed3059..4b08436c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8816e6f616029743bc7c2bb5a677bb404fdd4e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752630Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686586}
-
Sebastien Marchand authored
Bug: 966059 Change-Id: I9afc2ed7c722166f6dbcd96c412387fab97d32ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752743 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#686585}
-
Gabriel Marin authored
MetricCollector is split into MetricProvider and MetricCollector. MetricProvider runs on the UI thread and owns a MetricCollector instance. External classes interact only with the MetricProvider. MetricProvider creates a dedicated sequence for running the collector. It forwards callbacks received on the main thread to the collector via PostTask. MetricCollector runs on the dedicated sequence. It posts a callback that is provided at creation time, on the main thread each time a profile is generated. PerfCollector required minimal updating, but there was some churn in the unit tests. HeapCollector was updated to execute the heap profile parsing asynchronously on the thread pool, since it is a potentially blocking operation. Its behavior was also modified to not collect a profile if an incognito window is open, as opposed to disabling and then enabling heap sampling while an incognito window is open. This is in line with how the PerfCollector and memlog work. BUG=b:134761848 TEST=Unit tests pass under tsan. Change-Id: Iaa9550bd7ff4fc03651737023cffe1893b322d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654270Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#686584}
-
