- 26 Feb, 2020 40 commits
-
-
Jérôme Lebel authored
Adding a EG test to make sure the import data view controller is fully presented before to interrupt the sign-in. The sign-in might be interrupted while the view is not yet presented or while being animated. Change-Id: Ic61ea3beb846810645ef5f19d7d130cd39f01353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072041Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#744575}
-
Colin Blundell authored
The one place that Tab is referenced in ExternalNavigationDelegate it is not actually used. Remove it from this interface in order to aid in ExternalNavigationDelegate's componentization for sharing with WebLayer. Bug: 1031465 Change-Id: Ib744f050ea358fdb956f4d41a871fbe488156a3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072239 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#744574}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/57083a22..54f0b120 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2e3dcd102409fbef7461667d8d4694db9f043b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071959Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744573}
-
Jared Saul authored
Change-Id: I2d9270eb4278464b0e1e721d6cb55c0ce503e299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073152 Auto-Submit: Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#744572}
-
Jiawei Shao authored
This patch uses uint64_t as the type of request_adapter_serial and device_client_id (former name is request_device_serial) instead of uint32_t to reduce the possibility of integer overflow. This patch also removes two unnecessary header files in webgpu_decoder_impl.cc. BUG=chromium:996713 Change-Id: I7f84be41b321d6a8403afe4d2a770aebd8d7544d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071509 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#744571}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d7ceab616977..17f4e8b9da14 git log d7ceab616977..17f4e8b9da14 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 abennetts@google.com Push repo filter down into Commit.FromDep, thus ensuring _FindMidpoints is also filtered. Created with: gclient setdep -r src/third_party/catapult@17f4e8b9da14 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1045197 Tbr: sadrul@google.com Change-Id: I26e5fe00ab23b869308028c3f64600086fbfc766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073597Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744570}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96d61942e67f..7f5e3c7e43c7 git log 96d61942e67f..7f5e3c7e43c7 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 reed@google.com Reland "Skip rewriting headers that reference SkM44.h until we can remove the private copy of it" 2020-02-26 reed@google.com Revert "Skip rewriting headers that reference SkM44.h until we can remove the private copy of it" 2020-02-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-02-26 reed@google.com rm unneeded header, see include/public 2020-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 2ea72065..04383ff2 (360 commits) Created with: gclient setdep -r src/third_party/skia@7f5e3c7e43c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: Ib9ec8f8103fd6cdb6532c72b860034a2371cc75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072115Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744569}
-
Sergey Ulanov authored
Added a new FuchsiaMediaResourceProvider mojo interface that merges FuchsiaCdmProvider and FuchsiaAudioConsumerProvider. In the future the new interface will be extend to provide access to other media resources, particularly AudioCapturer FIDL protocol. Bug: 1047390 Change-Id: I1d502746911a51909a8b4920d600110abcc1e33a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066277 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#744568}
-
Ken MacKay authored
It doesn't get built by Chromium CQ :( Change-Id: Icda0b43cf2f571efa915e0d0963ccf0328a33360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072626 Auto-Submit: Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#744567}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a1ceb87b4b8d..4a9ec2ef6f2a git log a1ceb87b4b8d..4a9ec2ef6f2a --date=short --first-parent --format='%ad %ae %s' 2020-02-26 robliao@chromium.org Revert "Always use commit_id.py to generate commit.h" Created with: gclient setdep -r src/third_party/angle@4a9ec2ef6f2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1055991 Tbr: geofflang@google.com Change-Id: Id76bc0d86df1fafb9eec31816a4875c903efc811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072112Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744566}
-
Yutaka Hirano authored
Instead of network::mojom::CrossOriginEmbedderPolicyValue, give network::CrossOriginEmbedderPolicy to the CORP check so that we can add the reporting functionality in the future. Bug: 1052764 Change-Id: I5340ace49b5e2905ab162065e1f2dc6f89248600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071337 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#744565}
-
Chinglin Yu authored
Bug: 904785 Change-Id: I147c74a49750137259ce3d2fc31cd235d742b86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043415 Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#744564}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0895a2fe7b5c..98a160373b23 Created with: gclient setdep -r src-internal@98a160373b23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I434752525a6709d32718856597734dabfc7a0b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072959 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744563}
-
Tarun Bansal authored
Bug: 913424 Change-Id: I9b1b592836d06fd20d2766f3e6cc672ad463f5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071906Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#744562}
-
Maggie Cai authored
Currently when we defer navigation, it will try to find apps, and if there is no preferred app, it will try to show the bubble and resume the navigation. However when there is no app found, the navigation will be trapped in start navigation, defer navigation and resume navigation all the time. This CL fixes this issue by adding checks when there is no app found. BUG=853604 Change-Id: Id4215e6b0885da7ab37da9b81f75409ad915af7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072481Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#744561}
-
Shivam Balikondwar authored
When using Chromium on Wayland, the cursor doesn't become invisible whenever user enters fullscreen mode while watching any videos (Eg. Youtube). This patch fixes that feature. Bug: 895743 Change-Id: Ic66c5342f63c374586855691ba395f33d4a49446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060431Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#744560}
-
Timothy Loh authored
This CL removes the exception which allows Plugin VM in dev mode, so users will now have to have the appropriate policies set up before they will see Plugin VM. Bug: b/150257462 Change-Id: Ib73436e093dbab9e2ba64479a0327799bcca8405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072524 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#744559}
-
David Staessens authored
This CL cleans up a lot of unused include statements in various test files. TEST=./video_encode_accelerator_unittest on nocturne BUG=1045825 Change-Id: I53f531f113dc8e7f9f587ecc732b15366e321a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035826 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#744558}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f0a13d04c233..96d61942e67f git log f0a13d04c233..96d61942e67f --date=short --first-parent --format='%ad %ae %s' 2020-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e162b023f539..da659b374113 (4 commits) Created with: gclient setdep -r src/third_party/skia@96d61942e67f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: Ic203271183c96699bf66f302bed364c3a0ed2e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072110Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744557}
-
Yutaka Hirano authored
...due to flakiness. Bug: 1056031 Change-Id: Ib9de60c8106120130cb744eebdeeb05a0f837627 Tbr: karandeepb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072979Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#744556}
-
Robert Flack authored
In order to allow easily finding the PID of the renderer which loaded a target site, log a message when starting and committing the provisional load of a URL. Then as an example, you can run: rr record out/Debug/content_shell --log-level=0 <url> And find the log messages: [<pid>:<thread>:<time>:INFO:render_frame_impl.cc(<line>)] Starting provisional load: <url> With this information you can then debug the correct renderer process by running: rr replay -f <pid> This saves developers needing to guess which process is the renderer they are interested in. Bug: 730065 Change-Id: I4a190afaeea07fbd1b4ec8a2145bbbd2ef0266e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072122 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#744555}
-
Sammie Quon authored
This will reduce the amount of repaint/relayouts during animation. The transform animation should look decent for most animations. The first use case will be the AppsGridView. The API is unchanged, the only difference will be the visual effect. Test: manual checked only painting on animation end Bug: 1051492 Change-Id: I786375af1ab166ede01246dfa360edfc01da1d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055982 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#744554}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d2a4624b6380..03a8e2e30f01 git log d2a4624b6380..03a8e2e30f01 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@03a8e2e30f01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2fbae05a81a89315e956896040c7e0af462cd7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072111Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744553}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1a9b81fd3fd4fb5a03ba8641966bc548c355e05a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072109Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744552}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d2b5e7801939..d7ceab616977 git log d2b5e7801939..d7ceab616977 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 dberris@chromium.org Pinpoint: Enable push-on-green Created with: gclient setdep -r src/third_party/catapult@d7ceab616977 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1040775 Tbr: sadrul@google.com Change-Id: I9d632fc6145bb6f82f70e4f6658b95c9ccd31dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072108Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744551}
-
Rachel Carpenter authored
This can handle requests for the feedback dialog to be opened. As part of this, refactoring out a base test class can inject scripts into the untrusted context for help_app to reuse from media_app. Bug: 1012578,b/149709102 Change-Id: I827bb48d31d2b21abaf6576f5b7bdab38fa45998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066421Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@google.com> Cr-Commit-Position: refs/heads/master@{#744550}
-
nancy authored
AppUninstallDialogView replaced the Crostini uninstall dialog. https://cs.chromium.org/chromium/src/chrome/browser/ui/views/apps/app_uninstall_dialog_view.h?l=44 Remove Crostini uninstall dialog to prepare for "Uninstall" dialog language consistency. Because some variables might be used by Crostini uninstall dialog. BUG=1010303 Change-Id: I55a739fb1008e33a7b23ef6fc0966645843f6436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072684Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744549}
-
David Staessens authored
The video_decode_accelerator_unittest target was replaced by the video_decode_accelerator_tests target some time ago, but the video_decode_accelerator_unittest_helpers files are still named after these tests. This CL renames the test helper files to video_test_helpers. This name was chosen rather than "video_decode_test_helpers", as the test helpers file is rather small so we might as well combine it with any encode helpers we want to add later. TEST=./video_decode_accelerator_tests on nocturne BUG=1045825 Change-Id: Icaff368158526d9cdfd03d68681623d98c64ece4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026557 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#744548}
-
Mike Dougherty authored
The result object returned by |WKWebView evaluateJavaScript completionHandler:| may have an unexpected type. The check to determine if the windowID has been injected should not crash if the result object has an unexpected type. Fixed: 1050940 Change-Id: I326d474e461286ed02b90191ab2868d15afe957d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073059 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#744547}
-
Ken MacKay authored
This CL adds the ability for additional audio decoding to be added as a dynamically-loaded library. The default location for the library is /system/chrome/lib/libexternal_decoder.so, but it can be changed via the --external-audio-decoder-lib-path command-line arg. The dynamic library must export the correct functions as described in external_audio_decoder.h. At runtime, for any audio codec that ExternalAudioDecoder_IsSupportedConfig() returns true, an external audio decoder will be used (the internal decoder will be bypassed completely even if it would also support decoding that codec). See the documentation in external_audio_decoder.h for more details. Bug: internal b/148685511 Change-Id: I58afbe5a24d1b0cb4751621c75316abd5b2bb97b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072163 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#744546}
-
Eugene But authored
This histogram is useful for monitoring session restoration performance. Also add justincohen to histogram owners list as prompted by Tricium. Bug: 1053000 Change-Id: I4713418914aed531c69ae2b333a31149131e2e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073117 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#744545}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/82fae3cc60b5..d2a4624b6380 git log 82fae3cc60b5..d2a4624b6380 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@d2a4624b6380 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I20025c637412d9623af7b25de201dacf1864e9ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072106Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744544}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/227d51085733..2a9042f8a77b git log 227d51085733..2a9042f8a77b --date=short --first-parent --format='%ad %ae %s' 2020-02-26 yekuang@google.com Roll out new goma client binary VERSION=192 Created with: gclient setdep -r src/third_party/depot_tools@2a9042f8a77b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I40858a410765e10e6928b9051792815526746411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072104Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744543}
-
Donn Denman authored
Removes features from flag-metadata.json that have already been cleaned up and removed. We forgot to do this as part of the cleanup process for those features. Change-Id: Ie41aa1706901c1ab9a6a95be5910d2da662dc2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070970 Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#744542}
-
Jared Saul authored
These two histograms still provide useful information on settings page interactions and first-time sync-implicit (Butter) interactions. Fixed: 1052922 Change-Id: I4a7cc2d567e6670d8de5c7baeb2b4a374664a8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071743 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#744541}
-
David Staessens authored
This CL adds support for raw video streams to the video test helper code. Rather than specifying a codec profile in the json metadata file, a pixel format can be specified for raw videos. TEST=./video_decode_accelerator_tests on nocturne BUG=1045825 Change-Id: I88c9779b10f63d94bebf8491ea76c78dc658e35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026773 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#744540}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ic9d30edc8fd4c8b5bd03539768ae2f621261b9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072623Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744539}
-
Ben Goldberger authored
Bug: 1054674 Change-Id: Iad90852687154cd7085716c2fa0126261d43eaf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067929 Commit-Queue: Ben Goldberger <benwgold@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#744538}
-
Chinglin Yu authored
This fixes a crash in running browser_tests with feature BrowserJankinessProfiling enabled on linux-chromeos-dbg. The crash happens when the task posted to the monitor thread to run JankMonitor::DestroyOnMonitorThread(), as the last step of shutdown path, gets destroyed without running when the UI thread executor shuts down. This destroys (on the UI thread) the JankMonitor along with its running timer, which caused DCHECK() failure because the timer is destroyed on the wrong sequence. Fix the crash by shutting down and destroying the timer early in the shutdown path so that the monitor thread has the chance to stop the timer. Bug: 904785 Test: Updated unit tests. PreCQ passed. Change-Id: Ic46161ac4b6d7d1f796a2dd488fa6df857dfca26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049926 Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#744537}
-
Abhijeet Kandalkar authored
This CL has goal to use new downcast helper for blink::BeforeUnloadEvent and blink::WheelEvent. Bug: 891908 Change-Id: I6fe2c353a5740de40ef89d69c17b3b44f47a962e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019426Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#744536}
-