- 02 May, 2018 40 commits
-
-
Conley Owens authored
This change removes the Physical Web UrlManager and the native hooks associated with UrlManager. BUG=826540 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie0215e48c8ab1a0fac8a852c338c7f87955b603d Reviewed-on: https://chromium-review.googlesource.com/1038062Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#555462}
-
Peng Huang authored
Bug: 776877 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I06ced286b0eeb8289e40f668577b08e35b282600 Reviewed-on: https://chromium-review.googlesource.com/1038223 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555461}
-
Sammie Quon authored
By default the back button will tell focus to go on the tray associated with the detail view. This is usually the view that activated the detail view, except in the case of the volume view whos child headphone button activates the detail view. Add functionality for a tray item to choose which item to restore focus too. The default will be the tray item itself. The first and only user will be the volume tray. Test: manual Bug: 803013 Change-Id: If053cd6f152679b79a98b85570a3cf3f97ed5e8f Reviewed-on: https://chromium-review.googlesource.com/1038884Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#555460}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1e3401a0..d48a883d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I655bbe96a1819e901cb16c2ffbe53efba1271740 Reviewed-on: https://chromium-review.googlesource.com/1040046Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#555459}
-
Charlie Harrison authored
These metrics are not being used. Bug: None Change-Id: I4007b8dd3b19666965a61f059f78aaccc4854628 Reviewed-on: https://chromium-review.googlesource.com/1038905Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#555458}
-
Peter E Conn authored
Save successful verification results as an Android Preference. If verification attempts fail because of network conditions, fall back to these results. Bug: 814755 Change-Id: I7617340a40908d4b08972efda096a5636e7e07f6 Reviewed-on: https://chromium-review.googlesource.com/1019149 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#555457}
-
Dmitry Skiba authored
StartupTimeBomb does nothing on Android (see crrev.com/672973002), and ShutdownWatcherHelper is useless because on Android Chrome never shuts down cleanly (it's killed by the OS). This CL ifdefs out usages of StartupTimeBomb and ShutdownWatcherHelper on Android. Bug: 366699 Change-Id: I192bb86c794ef2423a7c32ef70c4a4eea35a64c0 Reviewed-on: https://chromium-review.googlesource.com/1028480 Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#555456}
-
Rune Lillesveen authored
Updating the font on paint required mutable access to the ComputedStyle member of LayoutObject. Instead, update the font when style is computed or when the text is modified. Note that we still need a mutable style from the parent, but that is trivial to fix once all other mutable access to LayoutObject's ComputedStyle is gone. Bug: 813068 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id9bb1eb3a89cf20a36d91a5182323d8f450e9f55 Reviewed-on: https://chromium-review.googlesource.com/1033748Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#555455}
-
Amirhossein Simjour authored
Now that VR supports html <select>, we should send scroll events to dialogs. Bug: 836292 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I45d44af2069e21bedd0662d3f26ab6c89ff82288 Reviewed-on: https://chromium-review.googlesource.com/1028584 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#555454}
-
glevin authored
As per crbug.com/788022 Comments 1,6: - Consolidate 2 paragraphs into one - Fix padding between content area and buttons - Update "Don't show" checkbox text - Move "Don't show" checkbox from button to content area - Remove X (Close) button from upper right Bug: 788022 Test: Try to open second (multi) profile, view Multiprofile warning dialog, marvel at the unbearable Harmoniousness of it all. Change-Id: I1bb57e06b11c66e9b3cb3f3f4149ec8edcd35af5 Reviewed-on: https://chromium-review.googlesource.com/1015786Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Greg Levin <glevin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555453}
-
Daniel Nicoara authored
Need to have the GL context current before deleting the buffers. Since the context was destoryed before the buffers due to declaration ordering in the class definition, the context was lost before the buffers were destroyed. Also rename the overlay array to signify that it is an array. Fixed presubmit warning to use base::size over arraysize. BUG=NONE TEST=Ran ozone_demo and verified no GL errors are seen on console. Change-Id: I8e8da2918fe7c1f2cb5cf16bcebddfd453b315b3 Reviewed-on: https://chromium-review.googlesource.com/1039988Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#555452}
-
Katie D authored
This will allow a button in the shelf to request Select-to-Speak state changes and to be updated when Select-to-Speak updates its own state. This builds off of https://chromium-review.googlesource.com/c/chromium/src/+/1030901 and the full working proof of concept can be seen at https://chromium-review.googlesource.com/c/chromium/src/+/1031550. Still TODO: Add the button, and update the SelectToSpeakEventHandler to start processing touch events or mouse when the button was clicked rather than just when the search key was held down. This change also adds tests for toggling Select-to-Speak on and off in accessibility_manager, as those tests were missing. Bug: 753018 Change-Id: I93bb77dc23bdfa855e991e31d67dc4e3b8271036 Reviewed-on: https://chromium-review.googlesource.com/1036198 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#555451}
-
Mustaq Ahmed authored
Also add a web-platform-test for this change, which is already supported by Firefox. Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/-2AyrUFwXvY/Q_wCUmKSAgAJ Spec change PR: https://github.com/whatwg/html/pull/3659 Bug: 836401 Change-Id: Ia710190857211684ce5ce7d4ff835b874f658b29 Reviewed-on: https://chromium-review.googlesource.com/1039265Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#555450}
-
Michael Lippautz authored
Includes incremental garbage collection infrastructure in regular builds. Does not enable incremental marking at runtime! This CL may cause throughput regressions and is an attempt to collect a broad range of potential performance issues. Bug: chromium:757440 Change-Id: Ie7b75f8d96f9230400beed1a3258e45e0ca742ed Reviewed-on: https://chromium-review.googlesource.com/980753 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#555449}
-
Koji Ishii authored
Following bot results are included. 5 lines were removed and 5 lines were deflaked by consecutive results since 5098. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I210dc6127b151a14d93308981c19336de6981477 Reviewed-on: https://chromium-review.googlesource.com/1040065 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#555448}
-
Patrick Monette authored
Change-Id: I72ae36f24a7930b70ac9fa098f5cf1b20cb5d9bb Reviewed-on: https://chromium-review.googlesource.com/986981 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#555447}
-
Dave Tapuska authored
Replace OnScreenKeyboardDisplayManager on Windows with the InputMethodKeyboardController class. Do this so that there is no longer a singleton but InputMethodKeyboardControllers are associated with the InputMethodWinBase object. This is needed for a later change that uses InputPane which listens to changes to the associated window handle. Using a singleton causes a bunch of confusion with classes that need to be associated with a HWND. BUG=817501 Change-Id: I4fe8471c5eb84aa707136477c83b07cbf1acf7bb Reviewed-on: https://chromium-review.googlesource.com/978841 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#555446}
-
Evan Stade authored
This allows chrome/ to use those utilities on the proto returned by PowerManagerClient. BUG=756095 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib3a7f3143ec82ea871ca70dd8fe6d7270c00d9f0 Reviewed-on: https://chromium-review.googlesource.com/1013271Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#555445}
-
Sergey Poromov authored
While the original domain name remains unchanged after domain rename, the new name is provided as "displayDomain" and should be shown in UI. BUG=b/67784447 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7e083f31ca2492fd6c32d401a024e4da4b54794e Reviewed-on: https://chromium-review.googlesource.com/1038503 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555444}
-
Ran Ji authored
Reland "Load resources.pak earlier in service manager main" This is a reland of 13dfb327 Original change's description: > Load resources.pak earlier in service manager main > > We need to use the content in resources.pak in service manager, but at > that time resource bundle has not been initialized. Create data pack to > load resources.pak and append the data pack to resource bundle during the > initialization. > > Move path FILE_RESOURCES_PACK from chrome_paths.h to ui_base_paths.cc. > > Bug: 729596, 815230 > Change-Id: Iec3a9409cbd9c10775afb72944e66e26650f1181 > Reviewed-on: https://chromium-review.googlesource.com/962679 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Xi Han <hanxi@chromium.org> > Commit-Queue: Ran Ji <ranj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554500} Bug: 729596, 815230 Change-Id: Id963d1e64c70a22a29e94d8186ea0d4bcb1455fd TBR=sky@chromium.org, yfriedman@chromium.org, rockot@chromium.org Change-Id: Id963d1e64c70a22a29e94d8186ea0d4bcb1455fd Reviewed-on: https://chromium-review.googlesource.com/1034133 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#555443}
-
https://chromium.googlesource.com/angle/angle.git/+log/9aef81c7cec0..d8ffd75616c1 $ git log 9aef81c7c..d8ffd7561 --date=short --no-merges --format='%ad %ae %s' 2018-05-01 cwallez SystemInfo.h: add some documentation Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I6ea4b68bbc3246d09a577d854109f53dbe617241 Reviewed-on: https://chromium-review.googlesource.com/1039771 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555442}
-
Christopher Grant authored
Also, tweak the overall width to match the current spec. BUG=838939 R=tiborg Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I4727da0c669b6b59add3ce96e3b0b1276c4050e6 Reviewed-on: https://chromium-review.googlesource.com/1039873Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#555441}
-
Sergey Volk authored
Bug: b/78193551 Test: played some videos and checked video stream resolution Change-Id: I79f7400675f91a424e7bf9b449f5acb10bf41e8b Reviewed-on: https://chromium-review.googlesource.com/1036731 Commit-Queue: Sergey Volk <servolk@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#555440}
-
Saman Sami authored
Currently we only use video capture API for screencasting when VizDisplayCompositor is enabled. Also use video capture API when UseVideoCaptureApiForDevToolsSnapshots is enabled. Bug: 813929 Change-Id: Ia3018eed1eda785a260227f89024d20b13da1a97 Reviewed-on: https://chromium-review.googlesource.com/1035616Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#555439}
-
Ken Rockot authored
Explicitly reference README.md in links to other docs. Without this, the destination page includes a directory index preceding the actual README.md contents which can be confusing especially for directories with lots of files. TBR=dcheng@chromium.org TBR=jcivelli@chromium.org Bug: None Change-Id: I81222dde7fe60d4af53abb7c720cd451f02f0c60 Reviewed-on: https://chromium-review.googlesource.com/1040108 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#555438}
-
John Budorick authored
Bug: 731426,826895 Change-Id: Ice68f17dae6cb0bacc923fc1a5c2d3dd130584d5 Reviewed-on: https://chromium-review.googlesource.com/1038807Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#555437}
-
Fady Samuel authored
The renderer has an existing mechanism for repaint: ViewMsg_Repaint that is separate from ViewMsg_SynchronizeVisualProperties and needlessly complicates code. This CL uses browser-side LocalSurfaceId allocation to repaint. LocalSurfaceId allocation triggers a commit and draw now even if the LocalSurfaceId itself does not get used by cc (because surface synchronization is off): https://chromium-review.googlesource.com/c/chromium/src/+/1028727 In a subsequent CL, the old repaint code path will be deleted. Change-Id: I73cbc2f537974ad51a353ac86f33ef691fc99c4f Bug: 672962 TBR: piman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1037911 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#555436}
-
Varun Khaneja authored
global.cpp was removed in crrev.com/c/984113 because it uses `pragma hdrstop`. This CL removes that directive when building Chromium. Bug: 750327 Change-Id: I8d6af052bc6c9a9c10a6b824fd499b548c7714a6 Reviewed-on: https://chromium-review.googlesource.com/1037917Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#555435}
-
Mounir Lamouri authored
Fixes the crash. Original change's description: > Media Controls: remove window event listener and listen to event on popup. > > This is moving the logic to hide the popups to the popup element class. > It will hide when the popup no longer has focus, when the window is > resized or scrolled. It slightly improves memory usage by only creating > the event listener object on demand. > > Bug: 833461 > Change-Id: I979f0882108fcd89fdf84b2612437209b080eb95 > Reviewed-on: https://chromium-review.googlesource.com/1023345 > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555083} TBR=mlamouri@chromium.org Change-Id: Id5fa81b6370dcb49d6ae7b0c958e07a4e0c23a4a Reviewed-on: https://chromium-review.googlesource.com/1039587 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#555434}
-
Egor Pasko authored
Bug: 760498 Change-Id: I937c5a123bbd4d3d5844f9e2916fd0a7dcfd1e81 Reviewed-on: https://chromium-review.googlesource.com/1039590Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#555433}
-
Artur Khachatryan authored
Enabling tests for Android Chromium build bot on Waterfall. The following tests from ChromeDriverTest class are enabled: testTouchDoubleTapElement, testTouchLongPressElement, testTouchSingleTapElement, These tests were failing for older Chrome browsers running on Android devices and in the most recent builds tests are passing, so we are enabling these tests. Bug: chromedriver:2388 Change-Id: I270cca8631f97ad7820b1f416578ccc8656562f1 Reviewed-on: https://chromium-review.googlesource.com/1022510 Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555432}
-
yoshiki iguchi authored
This crash is caused because it refers the control buttons view which may be null. This CL adds a null-check. Also this refactors related code with IsCloseButtonFocused and RequestFocusOnCloseButton. These methods do same thing among child classes so that no need to be virtaul. Bug: 836523 Test: none Change-Id: I2f10d77b0772cc3bca51048473352daed5317589 Reviewed-on: https://chromium-review.googlesource.com/1037064Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#555431}
-
Biao She authored
Bug: 837647 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9c07ca3bfe5df595b9973b6ab0b18d3e629cd6eb Reviewed-on: https://chromium-review.googlesource.com/1035208 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#555430}
-
Pavel Feldman authored
Change-Id: I193440a6de9252e239d91a1028e02be141d5f32b Reviewed-on: https://chromium-review.googlesource.com/1038690 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#555429}
-
spqchan authored
The button actions container logic was recently refactored so that the padding is now baked inside the extension icon view bounds: https://chromium-review.googlesource.com/c/chromium/src/+/961722 This caused the extension icons to be chopped because it conflicts with the existing code that sets the vertical padding and height in the browser action container. This causes icon to have an incorrect y offset. This CL fixes the issue by removing the browser action container's padding logic, since that is now done by the extension icon view. Bug: 825157 Change-Id: I43a4ca55fba1af0aba9ead7279a74819ba04f0d9 Reviewed-on: https://chromium-review.googlesource.com/1037764Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555428}
-
Qiang Xu authored
changes: This CL makes ArcAppContextMenu showing Android app shortcuts in app list context menu. TODO list: - Add ArcLauncherContextMenu integration for shelf item. - Add LaunchAppShortcut support. - Add UMA for measuring query & decode time. - Add context menu metrics. - UI adjustments when specs come. video demo: go/appshortcuts-demo-1 Bug: 803291 Test: device test with android side change Change-Id: I30f06d609eebc91c8d493af5bdb64360cdde002a Reviewed-on: https://chromium-review.googlesource.com/1029412 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#555427}
-
Adithya Srinivasan authored
Bug: 781655 Change-Id: Ic009ba42a61d3e419d6e4ac449bc6656fdf37321 Reviewed-on: https://chromium-review.googlesource.com/1015785Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#555426}
-
Bernhard Bauer authored
Bug: 829323 Change-Id: I65a6b2631f10a72e2fcb3b4ebe420237a54590d2 Reviewed-on: https://chromium-review.googlesource.com/1039806Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#555425}
-
Max Moroz authored
Bug: 834781 Change-Id: I6b21d7313c22e02e0454b36f2977ec11c1f8cfe0 Reviewed-on: https://chromium-review.googlesource.com/1038149 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555424}
-
Rayan Kanso authored
Design doc: https://docs.google.com/document/d/1zk6WSUb063I_07ct1EP8krOsDKXai1v4nJchvpQeAio/ TBR=avi@chromium.org Bug: 826257 Change-Id: If883c9380a79cad8922ef3a21f2daa4cc73778a6 Reviewed-on: https://chromium-review.googlesource.com/1021516 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#555423}
-