- 03 Nov, 2018 40 commits
-
-
Wez authored
WatchFileDescriptor(WATCH_READ) should result in OnFileCanReadWithoutBlocking() if the descriptor is at end-of-stream when it is invoked, to wake the caller to detect that by attempting to read and receiving zero bytes. Bug: 898938, 706592, 884299 Change-Id: I77662fe77eb8fb988089640a75a60d470770b78f Reviewed-on: https://chromium-review.googlesource.com/c/1316672 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605154}
-
Qingsi Wang authored
MdnsResponderInterface is introduced in WebRTC to handle the hostname generation and resolution of ICE host candidates when concealing their local IP addresses. For WebRTC in Chromium, we implement it as a client of the service provided by network::mojom::MdnsResponder. Bug: 878465 Change-Id: Id7b79694deba0ef308e51f83d6134062ddcb3985 Reviewed-on: https://chromium-review.googlesource.com/c/1206002 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#605153}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/570b99d69e5b..9f8459473cdf git log 570b99d69e5b..9f8459473cdf --date=short --no-merges --format='%ad %ae %s' 2018-11-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6ba22ee13768..37297a4f1440 (3 commits) 2018-11-03 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@9f8459473cdf The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I80bef10706d7daf52535cccb332ee87deaf7d07b Reviewed-on: https://chromium-review.googlesource.com/c/1316859Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605152}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a98da076b9e5..7e0b0c498a5c git log a98da076b9e5..7e0b0c498a5c --date=short --no-merges --format='%ad %ae %s' 2018-11-03 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-03 ehmaldonado@chromium.org git-cl: Add tests for metrics collection. Created with: gclient setdep -r src/third_party/depot_tools@7e0b0c498a5c The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:897394 TBR=agable@chromium.org Change-Id: I015df12f8d81089c8a2f3371b68f8e117428b9c7 Reviewed-on: https://chromium-review.googlesource.com/c/1316856Reviewed-by:
-
Devlin Cronin authored
For extensions that only request access to specific sites (e.g., an extension that only requests access to google.com and example.com), display a toggle-able list in the chrome://extensions page rather than a free-form entry field. The ability to grant all requested sites still exists via a "main" toggle, and disabling this allows the user to toggle individual sites. This logic is contained in the new HostPermissionsToggleList custom element. This is a usability improvement over the free-form entry, since with free-form entry it's not immediately obvious what the possible options are. Free-form entry is still used for extensions that request all sites (or all-sites like patterns, such as https://*.com), since (almost) any site entered is valid. Update and add tests for the same. Bug: 891803 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I99112966d323c403603d5f21c28ae33be8e506f0 Reviewed-on: https://chromium-review.googlesource.com/c/1284696 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#605150}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ecb0098989c1..c7000ce0e554 git log ecb0098989c1..c7000ce0e554 --date=short --no-merges --format='%ad %ae %s' 2018-11-03 treehugger-gerrit@google.com Merge "profiling: Fix bug with mem/maps fd initialization." Created with: gclient setdep -r src/third_party/perfetto@c7000ce0e554 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iab2a4f784d090e509017b085c2bfc08f7da75827 Reviewed-on: https://chromium-review.googlesource.com/c/1316857Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2039ee7dced5..671341ac6669 git log 2039ee7dced5..671341ac6669 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 35f88255..b58a0334 (604980:605082) 2018-11-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e842ab5f..35f88255 (604874:604980) Created with: gclient setdep -r src/third_party/webrtc@671341ac6669 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I252562d720c8167df189accd64d5c6004d15841a Reviewed-on: https://chromium-review.googlesource.com/c/1316853Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/535c96c5642a..fea094c83229 Created with: gclient setdep -r src-internal@fea094c83229 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie76f4d2565a2fc845ef7789e80e9312c0ca330b1 Reviewed-on: https://chromium-review.googlesource.com/c/1316858Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605147}
-
Vikas Soni authored
Add VulkanContextProvider to RasterDecoderContextState which is needed to get VkDevice in shareable image. Refactor RasterDecoderContextState class to have seperate constructors for Vulkan and GL. Bug: 891060 Change-Id: I0ca7e657d33fdcfa62ab6465f7023a914610b7ce Reviewed-on: https://chromium-review.googlesource.com/c/1312194 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#605146}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c02ed04700f7..8c035b35abf8 git log c02ed04700f7..8c035b35abf8 --date=short --no-merges --format='%ad %ae %s' 2018-11-03 mattm@chromium.org netlog_viewer: Remove external resource loading, vulcanize for appspot. 2018-11-02 mattm@chromium.org netlog_viewer: fix top-bar-view id conflict 2018-11-02 mattm@chromium.org netlog_viewer: load polyfills so it continues to work after upcoming deprecations 2018-11-02 mattm@chromium.org netlog_viewer: remove unused styles Created with: gclient setdep -r src/third_party/catapult@8c035b35abf8 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:892459,chromium:892466,chromium:892466 TBR=sullivan@chromium.org Change-Id: Iecf0b62b7de0626dbc3bf6c8bd27a219495720be Reviewed-on: https://chromium-review.googlesource.com/c/1316851Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1edff303fddb..570b99d69e5b git log 1edff303fddb..570b99d69e5b --date=short --no-merges --format='%ad %ae %s' 2018-11-03 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-03 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-03 reed@google.com remove references to align Created with: gclient setdep -r src/third_party/skia@570b99d69e5b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I08a728d3d8008c5d8d04b5c6af7bf8add5f7cf5c Reviewed-on: https://chromium-review.googlesource.com/c/1316855Reviewed-by:
-
Avi Drissman authored
BUG=none Change-Id: I1eab7375b20ceaa47f36dd73b4468b389fd66949 Reviewed-on: https://chromium-review.googlesource.com/c/1316307Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605143}
-
Asanka Herath authored
Bug: None Change-Id: Ibe0e4bd1fb1264bc15fb323273566e72e5b273b2 Reviewed-on: https://chromium-review.googlesource.com/c/1315958Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#605142}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Iaebda88bc01f412a4a7138654facbd5251b4c5ae Reviewed-on: https://chromium-review.googlesource.com/c/1316751Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#605141}
-
Mike Wittman authored
TBR=nhiroki@chromium.org, nasko@chromium.org Bug: 901489, 901317 Change-Id: Ifeb2e93e78c8eb0b7db73a5c66cd7a10bd15b0e8 Reviewed-on: https://chromium-review.googlesource.com/c/1316549Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605140}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1590fcc4d3ee..37297a4f1440 git log 1590fcc4d3ee..37297a4f1440 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 ynovikov@chromium.org Don't build VulkanCommandBufferPerfTest on Linux Created with: gclient setdep -r src/third_party/angle@37297a4f1440 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I4a0d38135e7231ffd3c2e4d011031e31092e3ac5 Reviewed-on: https://chromium-review.googlesource.com/c/1316849Reviewed-by:
-
Reilly Grant authored
This change expands the set of events which trigger the WebUSB and Web Bluetooth chooser dialogs to automatically close to include when a RenderFrameHost is swapped out as happens on cross-origin navigation. In this situation the dialog would already close when the RFH object was eventually deleted. This change makes sure it happens as part of committing the navigation. Bug: 898645 Change-Id: Ie35ec356687ca12d9d5ec3ee7c9d7efcb09f7f84 Reviewed-on: https://chromium-review.googlesource.com/c/1315932 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#605138}
-
Lukasz Anforowicz authored
Why remove DoesSiteRequireDedicatedProcess ========================================== This CL removes ShellContentBrowserClient::DoesSiteRequireDedicatedProcess. We plan to remove 2 other overrides of this ContentBrowserClient method in other CLs. We want to remove this ContentBrowserClient method altogether, because 1) it is currently the only reason SiteInstanceImpl::DetermineProcessLockURL needs to take BrowserContext* as an argument (and therefore is problematic on threads other than UI thread) 2) the method was initially introduced to support --isolate-extensions which has been obsolete since shipping --site-per-process in M67. Removal mechanics ================= It seems that NavigationControllerOopifBrowserTest test never relied on switches::kIsolateSitesForTesting. In particular, I can't find any references to ".is" in https://codereview.chromium.org/1505343002/patch/100001/110001 IsolateIcelandFrameTreeBrowserTest can switch from using switches::kIsolateSitesForTesting to using switches::kIsolateOrigins. Bug: 898281 Change-Id: Idc8e45361e791ff30b9391666c55cf10159e793a Reviewed-on: https://chromium-review.googlesource.com/c/1307876 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#605137}
-
file://.../*.svgzChris Mumford authored
Chrome supports loading gzipped SVG files from the file scheme which was unsupported with the network service implementation. Note: The non-network service implementation of *.svgz loading is currently broken on Linux, but works on Windows and macOS. This change works on both platforms. Bug: 857117 Change-Id: Id90deba4761ea67d4ac7bef681051ea9326e113b Reviewed-on: https://chromium-review.googlesource.com/c/1268960 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#605136}
-
Xi Cheng authored
Change-Id: I837334681a63e4d174e6bc2a9da67ef8db139db3 Reviewed-on: https://chromium-review.googlesource.com/c/1316099Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#605135}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c9e75f29605..535c96c5642a Created with: gclient setdep -r src-internal@535c96c5642a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2bab0946388f183eecf34741cfdb3905c9bc38cd Reviewed-on: https://chromium-review.googlesource.com/c/1316848Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/19502fd6..3ad9cf63 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibed999ac4b342fde632a86bf09d13cc6c06992d5 Reviewed-on: https://chromium-review.googlesource.com/c/1316829Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605133}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fec80c41355c..a98da076b9e5 git log fec80c41355c..a98da076b9e5 --date=short --no-merges --format='%ad %ae %s' 2018-11-03 mbinette@google.com Add CELab gclient config Created with: gclient setdep -r src/third_party/depot_tools@a98da076b9e5 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I1da4f7cc06f1f3b3c7eb543a44823e80fac3b101 Reviewed-on: https://chromium-review.googlesource.com/c/1316847Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d6db27cfd2f7..1edff303fddb git log d6db27cfd2f7..1edff303fddb --date=short --no-merges --format='%ad %ae %s' 2018-11-02 reed@google.com SkPaint::Align is dead 2018-11-02 herb@google.com Remove one field of unique data from SkGlyphCacheBuilder 2018-11-02 brianosman@google.com Remove one more unused macro 2018-11-02 benjaminwagner@google.com [Infra] Switch to latest Win10 in Skolo. 2018-11-02 herb@google.com Make special SkRunFont ctor in SkPaint private again 2018-11-02 brianosman@google.com Simplify bitmappremul GM a bit, remove more SkColorData 4444 macros 2018-11-02 herb@google.com Make glyph runs const in the glyph run list. 2018-11-02 jvanverth@google.com Add SK_API to SkYUVASizeInfo def 2018-11-02 mtklein@google.com remove SkUnpremultiplyRow() 2018-11-02 mtklein@google.com DeMorgan's blend-on-black logic 2018-11-02 brianosman@google.com Leverage readPixels to simplify PDF bitmap output 2018-11-02 herb@google.com Remove mutablePaint from glyphRuns 2018-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 caeb1e895d7b..6ba22ee13768 (3 commits) 2018-11-02 mtklein@google.com implement most SkImageEncoderFns with skcms 2018-11-02 brianosman@google.com Remove colorType switches in SkBitmap and SkBitmapDevice 2018-11-02 mtklein@google.com make big-endian very opt-in 2018-11-02 brianosman@google.com Remove SkUnPreMultiply::UnPreMultiplyPreservingByteOrder 2018-11-02 mtklein@google.com transform_scanline_888x is transform_scanline_RGBX Created with: gclient setdep -r src/third_party/skia@1edff303fddb The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I195f1a9f5e006f510c77be502066692da84b2376 Reviewed-on: https://chromium-review.googlesource.com/c/1316348Reviewed-by:
-
Vikas Soni authored
Remove VulkanContextProvider from viz common build target and create a new target. This is required so that the files which needs to only use VulkanContextProvider can depend on this new target rather than depending on whole viz common. Bug: 891060 Change-Id: Iddff176837a43f029b6466c4b31fedb508d1fb79 Reviewed-on: https://chromium-review.googlesource.com/c/1313114Reviewed-by:
-
Dale Curtis authored
libaom has fixed all the framebuffer issues, so we should now be able to use these. All tests pass and YouTube videos look good. Seems only a minor memory savings ~2mb on a 480p clip. This also resolves an issue with clipping of 64-bit timestamps passed in as a void* (which might be 32-bit on some platforms). BUG=867613,900302 TEST=existing tests all still pass. Change-Id: I83af8ecd867e13741f27f5225316b62f31981562 Reviewed-on: https://chromium-review.googlesource.com/c/1316408 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#605129}
-
Andreas Butler authored
Fixing minor nits with IndexedDBFactory databases() WPTs as suggested by jsbell@ over email -assert_object_equals is deprecated and shouldn't be used. Prefer to test the results explicitly, even though it's more code. -all of the test cases use 1 for the version - we should have tests for databases at other versions. -the assertion messages should have the form ".... should be ...", describing what is being asserted, rather than attempting to diagnose the problem (it's easier to verify that the assertions match the spec that way) -there are a handful of lines missing semicolons -the trailing done() should not be needed for .any.js tests Bug: 899085 Change-Id: Ie8831c26fabe0e043ccba8238925ac7f520d1d69 Reviewed-on: https://chromium-review.googlesource.com/c/1313275Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Andreas Butler <andreasbutler@google.com> Cr-Commit-Position: refs/heads/master@{#605128}
-
Antoine Labour authored
Calling code (CommandBufferStub via GpuChannel) doesn't check that the GMB handle type corresponds to the correct platform-specific handle (indeed it doesn't have a way to). So check in the GpuMemoryBufferFactory* classes and fail if the handle type is invalid. Bug: 870116 Change-Id: I78b574439350bee3dccda569e53eae7f74c7d0a7 Reviewed-on: https://chromium-review.googlesource.com/c/1316168Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605127}
-
Asanka Herath authored
Bug: None Change-Id: I881f20202ff1efaa2655173366f4f9ae5b86cdad Reviewed-on: https://chromium-review.googlesource.com/c/1300777Reviewed-by:
-
Sergey Ulanov authored
Now renderer will try to use FuchsiaVideoDecoder on Fuchsia before falling back to SW decoders. Also moved FuchsiaVideoDecoder implementation from //media/gpu to //media/filters since it will be used in the renderer process. Bug: 876519 Change-Id: Iad682c2dbcf4b100406891d722e818435d04bfda Reviewed-on: https://chromium-review.googlesource.com/c/1300686Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605125}
-
Ted Meyer authored
Newer hardware supports, and encrypted media requires D3D11VideoContext1 usage, while older hardware might only have support for D3D11VideoContext. We should support both of these seamlessly. There are also other levels of video context, and this should make it easy to add support should we ever require that. This should hopefully help mitigate some crashes we are seeing on older hardware. Bug: 897785 Change-Id: I46c913ba64036c2bc6ef655026f1cd90d0ab4684 Reviewed-on: https://chromium-review.googlesource.com/c/1298636 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#605124}
-
Erik Luo authored
Focused Objects in Console will now have tabIndex -1 instead of 0. Bug: 865674 Change-Id: I382576e1b5ec5ca0bc1c62b8ff0d998c73b18474 Reviewed-on: https://chromium-review.googlesource.com/c/1275266 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#605123}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0367d1a1fb0a..2039ee7dced5 git log 0367d1a1fb0a..2039ee7dced5 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 qingsi@webrtc.org Revert "Delete rtc::Pathname" 2018-11-02 mellem@webrtc.org Implement data channel methods in LoopbackMediaTransport. Created with: gclient setdep -r src/third_party/webrtc@2039ee7dced5 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic5554c169351a5515d258d12f129a5c7f9e81d20 Reviewed-on: https://chromium-review.googlesource.com/c/1315811Reviewed-by:
-
Siddhartha authored
1. Gets the register context from signal handler and sets all registers correctly before using libunwind. This avoids crashes if registers are used for unwinding frames. 2. Removes the need for unwinding signal handler function since we get the context of the stopped function directly. BUG=859260,888434 Change-Id: Ib337f20c19e25e2f82e61b08f8e9ed4ac1195fde Reviewed-on: https://chromium-review.googlesource.com/c/1307055 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
-
Daniel Rubery authored
This unit test currently waits for the timeout on network requests to occur before it verifies the proper request was sent. This CL adds a fake response so that the test runs quickly. Bug: 899898 Change-Id: I9e35086647cc80344488abb3319a538e90785eb9 Reviewed-on: https://chromium-review.googlesource.com/c/1316411Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#605120}
-
Mitsuru Oshima authored
Updating to the same value can cause shelf state update. Check the value before setting. This is to merge 71. I'll change the impl side for 72. Bug: 895744 Test: manual. see bug for repro step. Change-Id: I9aad35098fc120dbfae365ddb79faf6af0069881 Reviewed-on: https://chromium-review.googlesource.com/c/1316590Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#605119}
-
Gyuyoung Kim authored
This CL introduces the following command-line switches: - max-appcache-disk-cache-size-mb - limits the size of the HTTP disk cache used by AppCache for all origins - max-appcache-origin-cache-size-mb - limits the per-origin AppCache quota when no QuotaManager is present The CL is heavily based on the following reverted commits: 1. https://crrev.com/c/974804 - Set the maximum cache size per an origin in the command line for application cache 2. https://crrev.com/c/979877 - Pass the maximium disk cache size of appcache in the command line to appcache thread Bug: 824619, 895825 Change-Id: I4fb424fa740ef9875d0584def4e9390aef366916 Reviewed-on: https://chromium-review.googlesource.com/c/1282685Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#605118}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/468ff3e5a030..c02ed04700f7 git log 468ff3e5a030..c02ed04700f7 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 dpranke@chromium.org Reformat typ expectation parser code to match the surrounding style. 2018-11-02 dpranke@chromium.org Copy existing expectations parser into typ. Created with: gclient setdep -r src/third_party/catapult@c02ed04700f7 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:835690,chromium:835690 TBR=sullivan@chromium.org Change-Id: Ica23fbe593b0950a5e061374af37497b7bc9e782 Reviewed-on: https://chromium-review.googlesource.com/c/1316548Reviewed-by:
-
Morten Stenshorne authored
At least when using mock scrollbars from web tests (and maybe there are real use cases too?), NeedsScrollbarReconstruction() will return true after layout, which will make us remove the current scrollbars. Legacy layout will re-lay out and eventually end up with updating the scrollbar rectangles. NG cannot re-lay out from PaintLayerScrollableArea::UpdateAfterLayout() like legacy does, but we do need to update the scrollbar rectangles anyway. NG has its own scrollbar size change detection mechanism, but in this particular case, the scrollbars would have the exact same size with the default skin and with the mock scrollbars, so no change would be detected, and there'd be no re-layout, and no call to UpdateScrollDimensions(). Without this fix, scrollbars/rtl/overflow-scroll-rtl.html would fail with https://chromium-review.googlesource.com/c/chromium/src/+/1297367 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I15e159e0c26ab9fe8469ae8ad2c0af0dabe7417b Reviewed-on: https://chromium-review.googlesource.com/c/1309741Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#605116}
-
Roberto Carrillo authored
R=liaoyuke,stgao,jbudorick Change-Id: I1b9568f37d7ab6813095c1078fc8380fce231723 Reviewed-on: https://chromium-review.googlesource.com/c/1316654Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#605115}
-
