GitLab

UI Devtools use overlay model to support element highlight. However,
in remote debugging configuration, the highlight is handled by
screencast module which is not supported in current UI Devtools.
This CL fixes this by using local debugging on local sessions.

BUG=749778

Change-Id: Idc81ff27e05d5b95e72748873b933b1ecdb80ad2
Reviewed-on: https://chromium-review.googlesource.com/c/1262960Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597200}

Worklet animation supports invalidation of its compositing state.

This patch makes this invalidation process a no-op for animations that are
running on main (i.e., |compositor_animation_| is null). This means we no longer
try to read/modify the non-existent |compositor_animation_| which was causing
the crash.

Note that in some situations, even for currently main thread animaiton, we may
actually want to create and start the |compositor_animation_| but this is a
separate issue that can be fixed as a follow up.

The added DCHECK uncovered a bug where we were attaching the worklet animation
to early even if play was failing. This is also fixed.

Bug: 887659, 889330
Change-Id: I4a89de6632e053f68beafb810355c25e4bfba0e3
Reviewed-on: https://chromium-review.googlesource.com/c/1249387
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597199}

This way it can also be used by the new Previews UI

Bug: 871839
Change-Id: Iecba63729da87fc6f30cc0f0cceaebf85adc4729
Reviewed-on: https://chromium-review.googlesource.com/c/1265062
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597198}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/263549ba0d66..4e9584b32dfe


Created with:
  gclient setdep -r src-internal@4e9584b32dfe

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I85fee9a3d742f47597ade47e850eb1d993769238
Reviewed-on: https://chromium-review.googlesource.com/c/1265037Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#597197}

This CL takes a section of code used to show the full URL for Steady
State Elisions and moves it from the Views UI code to the
OmniboxEditModel.

This is in preparation for it to be used for Query in Omnibox. It also
adds a little bit of specific test coverage for this code.

Bug: 874592
Change-Id: I354c17a91751f930bd94d0ce9e02ef3f2846d15f
Reviewed-on: https://chromium-review.googlesource.com/c/1262655
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597196}

https://webrtc.googlesource.com/src.git/+log/a1134509c91d..96a0f6191781


git log a1134509c91d..96a0f6191781 --date=short --no-merges --format='%ad %ae %s'
2018-10-05 oprypin@webrtc.org Revert "[cleanup] Remove useless includes."
2018-10-05 sprang@webrtc.org Turning off a stream should results in target bitrate 0 signal
2018-10-05 yvesg@webrtc.org [cleanup] Remove useless includes.


Created with:
  gclient setdep -r src/third_party/webrtc@96a0f6191781

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ib706f62da1f7169d1aea11c1617c76ea2278fe12
Reviewed-on: https://chromium-review.googlesource.com/c/1264629Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#597195}

Crash reports indicate that checksums are valid even though the bucket
boundary values are tested to be incorrect. Try to determine if it is
memory corruption or bad calculations.

Bug: 836238
Change-Id: Ie89df5fef5093e9dd8c45fe9ff26a0430838769e
Reviewed-on: https://chromium-review.googlesource.com/c/1264036Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597194}

Net tests broke because test process' /data directories are now isolated
and can't be used for sharing data out-of-process. The net test launcher
depends on the old behavior for deploying configuration files to test
code.

This CL designates a special path "/data/shared" into which shared
files will be placed. The shared directory will be mounted at
"/test-shared" in the test process' namespace.

The net test launcher & test code are modified to use the new paths.

TBR=mmenke@chromium.org

Bug: 891732
Change-Id: Id94bffe05a3b140ed60e42507cdc8d238677f202
Reviewed-on: https://chromium-review.googlesource.com/c/1259829
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597193}

Previously, when the user has a disabled PDF plugin (or no PDF plugin)
and the website has an IFRAMEed PDF, when Click to Open PDF was enabled,
we would inject a fake <object> tag into the IFRAME to force a PDF
plugin placeholder to appear.

This approach is problematic with CSP, as CSP may forbid OBJECT tags
from loading in IFRAMEs.

This CL instead injects the placeholder HTML directly into the IFRAME.

In the IFRAME case, the button is now a plain link, which should allow
the user to click it and download the PDF even if CSP forbids <object>
tags or JavaScript.

It still may trigger a CSP warning if IFRAME is prohibited from running
JavaScript, but that only hurts keyboard-accessibility, and doesn't
prevent the mainstream use case from working.

This CL also prevents the <object> tag from auto-opening the PDF after
download, which was probably a mistake, since that overrides the user
configurable "Always open with system viewer" option.

Bug: 887752, 879149, 878871
Change-Id: I900c08331d2cfc96ea7cd1cd46ea594445b0920b
Reviewed-on: https://chromium-review.googlesource.com/c/1246956Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597192}

Add an ArcMediaSession bridge that will send an
AudioFocusManager mojo pointer to Android. This
will allow us to access the media session service
in Chrome from Android and in the future allow us
to delegate audio focus requests.

BUG=883958

Change-Id: I5a00e93ce1a1e4608d3f934522188b6252906cd2
Reviewed-on: https://chromium-review.googlesource.com/c/1225607Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597191}

R=abdulsyed@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I00a5e946eff9d7eeba32bfe0a45a7fd6fc804827
Reviewed-on: https://chromium-review.googlesource.com/c/1265157Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597190}

Bug: 892666
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Change-Id: Ic9a5cedb520d339b458c2208a6dbb6e57be4cc34
Reviewed-on: https://chromium-review.googlesource.com/c/1264898Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597189}

These test the basic proxy usage and headers. We can add more tests
here if necessary to help track what's not working with network
service.

Bug: 721403
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I09c0181ee4cdac97b4c532630f274f2418858d5d
Reviewed-on: https://chromium-review.googlesource.com/c/1263038Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597188}

The benchmark was not completely removed in crrev/c/1143595.

Bug: 769809
Change-Id: I131b226b7388d97eb380943275b6b16c222d2260
Reviewed-on: https://chromium-review.googlesource.com/c/1257669Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597187}

This CL fixes a bug after [1].  The issue was setting "window_mapped_in_client_
= false" after XIconfiyWindow().  Despite the ICCCM spec requiring the state
transition "Iconic -> Normal - The client should map the window" [2], the window
is not actually placed in an unmapped state.  Instead, the _NET_WM_STATE_HIDDEN
property is set.

[1] https://chromium.googlesource.com/chromium/src/+/02370c73936726c387f74cfbd5796f1667ae8a65
[2] ftp://www.x.org/pub/current/doc/xorg-docs/icccm/icccm.html

BUG=891376
R=sky

Change-Id: Ibfcc66a54249bad8926d23cd4eabf1e6979f7d07
Reviewed-on: https://chromium-review.googlesource.com/c/1263431Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597186}

content::PreconnectUrl() is about to be removed and AuthPrewarmer is the last
caller. This CL makes AuthPrewarmer to use NetworkContext::PreconnectSockets()
for prewarming a connection to the signin server.

Bug: 875238
Change-Id: I0865d6d9566b13f71ee0ac59e8a583bc7c401099
Reviewed-on: https://chromium-review.googlesource.com/c/1261717
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597185}

This reverts commit 01602d56.

Reason for revert: /O1 is not the clang-cl equivalent of -O1 

Original change's description:
> [libFuzzer][Windows] Enable optimize_for_fuzzing
> 
> Bug: 890639
> Change-Id: Icb2be76982816119a30925fa92121445b5ca5141
> Reviewed-on: https://chromium-review.googlesource.com/c/1253023
> Reviewed-by: Max Moroz <mmoroz@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Commit-Queue: Jonathan Metzman <metzman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596757}

TBR=thakis@chromium.org,scottmg@chromium.org,mmoroz@chromium.org,metzman@chromium.org

Change-Id: Ic407400440a3e6c58940b77708ab5334736242bb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 890639
Reviewed-on: https://chromium-review.googlesource.com/c/1264680Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597184}

DCHECK(committed_error_page_info_->auto_reload_triggered) was failing.
This is possible because when assigning a new value to
committed_error_page_info_, the auto load timer can still be active.

R=jianli

Bug: 881208
Change-Id: I361df3e17bef122f143331107a76d04487b32fea
Reviewed-on: https://chromium-review.googlesource.com/c/1240872Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Commit-Queue: Dan H <harringtond@google.com>
Cr-Commit-Position: refs/heads/master@{#597183}

I got a crash earlier today where WillProcessResponse was being called
on a non-preview page without response headers, so the DCHECK failed.

Moving up the early return makes the navigation throttle more robust
against this in the future.

Bug: 864635
Change-Id: Ief8e3b2b0ac9179d2ba16ff8f04c950b08f9564d
Reviewed-on: https://chromium-review.googlesource.com/c/1265059
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597182}

To speed up page loads from CCTs, data reduction proxy enabled check  is
removed from preconnect.

Bug: 850609
Change-Id: I111bc05c453a54c4c6d200186c04876faaec063e
TBR: lizeb@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1264075Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597181}

https://chromium.googlesource.com/angle/angle.git/+log/5476e805a321..8efa341839a6


git log 5476e805a321..8efa341839a6 --date=short --no-merges --format='%ad %ae %s'
2018-10-05 geofflang@chromium.org Suppress EXTBlendFuncExtendedDrawTestES3.FragmentArrayOutputLocationsAP on MacOS
2018-10-05 jmadill@chromium.org GL back-end error refactor.
2018-10-05 syoussefi@chromium.org Vulkan: Safer struct initialization


Created with:
  gclient setdep -r src/third_party/angle@8efa341839a6

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: Ia6926da32ec25e3a307c14617b00c7bdd36fc295
Reviewed-on: https://chromium-review.googlesource.com/c/1265015Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#597180}

https://skia.googlesource.com/skia.git/+log/032f2756df64..ba651682ae85


git log 032f2756df64..ba651682ae85 --date=short --no-merges --format='%ad %ae %s'
2018-10-05 brianosman@google.com Fix two bugs in GPU special image read-back
2018-10-05 fmalita@chromium.org [skottie] Remove temporary ResourceProvider::load() fallback
2018-10-05 reed@google.com isolate users of SkFindAndPlaceGlyph.h
2018-10-05 robertphillips@google.com Expose the SkYUVAIndex version of the SkImage factories
2018-10-05 brianosman@google.com Remove redundant test


Created with:
  gclient setdep -r src/third_party/skia@ba651682ae85

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=mtklein@chromium.org

Change-Id: I5cb0744e655d18db0a6eea6a421c54f5ba8ab6a6
Reviewed-on: https://chromium-review.googlesource.com/c/1264743Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#597179}

This CL replaces the placeholder setup page with the real page which
includes the logic for choosing a multi-device host phone.

As part of this CL, WizardController now decides whether or not to
show the setup flow based on whether setup is applicable and needed for
the GAIA account under question.

Bug: 884065
Change-Id: I8f3be643b77890fb249516369d76f5c392a568a9
Reviewed-on: https://chromium-review.googlesource.com/c/1255591
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597178}

Add support with remote connection for methods:
SetWindowRect(), SetWindowPosition(), MaximizeWindow(),
MinimizeWindow() and FullScreenWindow()

Bug: chromedriver:1855
Change-Id: I452cd54d2fea79763f87a30edb1d034851ed0eea
Reviewed-on: https://chromium-review.googlesource.com/c/1263567
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597177}

Group the command endpoints based on the sources that defined the
commands, to improve maintainability.

Change-Id: I0bdf68bc2bd56703fa87ca8486f1550ca6bb3c86
Reviewed-on: https://chromium-review.googlesource.com/c/1263875Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597176}

If any of sizes or purpose are missing in ImageResource,
provide default values for 'purpose' and 'sizes'.

Bug: 868875
Change-Id: I2e88144e1d098a18c740ffeaf9a2fb474db031a1
Reviewed-on: https://chromium-review.googlesource.com/c/1244176
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597175}

This fix has two parts.

First, call -[NSView addSubview:] in views::NativeViewHostMac, instead
of calling it in views::BridgedNativeWidgetHostImpl. This will set up
the browser-side NSView hierarchy, even when the browser-side NSViews
are not visible (because the app-side NSViews are).

Second, in BridgedNativeWidgetHostImpl::OnWindowGeometryChanged, update
the geometry of the browser-side doppelganger NSWindow to match the
geometry of the app-side true NSWindow. This ensures that the context
menu appears in the right place.

Both of these fixes are band-aids on the larger issue that we should
change the gfx::NativeView and gfx::NativeWindow types to be a wrapper
interface that will clearly delineate the where the native types
are actually manipulated, and where the native types are just plumbed
through.

Bug: 859152
Change-Id: I8428166dd889f45888432220be70de340574c385
Reviewed-on: https://chromium-review.googlesource.com/c/1263592Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597174}

These are needed in order to avoid unpleasant snake-casing around
numbers in, for example, 'webgl_2' caused by a subsequent change that
will will use NameStyleConverter more uniformly in bindings generation.

Change-Id: I58ac7ca03bf169fdca1c2918848c9f0e3450d422
Reviewed-on: https://chromium-review.googlesource.com/c/1261963
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597173}

This reverts commit 7d7cc8da.

Reason for revert: The new browser tests are very flaky and fail regularly, for example in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/29408:

[9182:775:1005/081300.634221:INFO:CONSOLE(4)] "Throttling navigation to prevent the browser from hanging. See https://crbug.com/882238 and chrome://flags/#disable-ipc-flooding-protection", source:  (4)
  ../../content/browser/navigation_browsertest.cc:1281: Failure
  Expected equality of these values:
    100
    count_replace_state
      Which is: 202

Original change's description:
> Prevent renderer process flooding the browser with IPC.
> 
> Some javascript function called in an infinite loop can cause the
> browser process to be flooded by IPC and become unresponsive.
> 
> Limit the number of IPC sent to 10 per second per frame.
> 
> This was already done for:
>  - history.pushState()
>  - history.replaceState()
> 
> This is extended to:
>  - history.back()
>  - history.forward()
>  - history.go()
>  - navigations...
> 
> 3 tests added.
> 
> Bug: 882238
> Change-Id: I821ff742307ab471ca52f27c6003d003ee978a46
> Reviewed-on: https://chromium-review.googlesource.com/c/1230067
> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
> Reviewed-by: Camille Lamy <clamy@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Chris Palmer <palmer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596715}

TBR=palmer@chromium.org,dcheng@chromium.org,clamy@chromium.org,arthursonzogni@chromium.org

Change-Id: I27843365fff5da639091524af85791af0af9ce6d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 882238
Reviewed-on: https://chromium-review.googlesource.com/c/1265060Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597172}

Bug: 876348
Change-Id: Ib932652af7814f421009be79a7e9a1e5413fffd7
Reviewed-on: https://chromium-review.googlesource.com/c/1228505
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597171}

Switching from enum to class enum removes the implicit conversions to
int.

This CL also switches DeliveryType members from SHOUTY_CASE to
kModernConstCase and de-virtualizes a few AppCacheJob methods with a
simple implementation. These changes are intended to improve the code's
readability.

Change-Id: I35f8e8007f7abce2371c3cc8200c9e756529ba1f
Reviewed-on: https://chromium-review.googlesource.com/c/1263890Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597170}

Flash player DRM videos are currently broken because the V2 sandbox
blocks access to the window server. This allows the access.

Bug: 891823
Change-Id: I06116f1de78480fe80b01465a6b9b097066b7278
Reviewed-on: https://chromium-review.googlesource.com/c/1263282Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597169}

Automates all the manual tests from https://crbug.com/887523, which all
relate to omnibox text entry and navigation while in the VR browser.

Bug: 887523
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0db4cc10def31779b8a59f63e2a1f227cf0a6e29
Reviewed-on: https://chromium-review.googlesource.com/c/1263433Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597168}

Change-Id: I9674404c054854d0653a0f2cd61a3b52a85707a8
Reviewed-on: https://chromium-review.googlesource.com/c/1265077Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597167}

Reland "If the caret is at the boundary of a misspelling, getting > > If the caret is at the boundary of a misspelling, getting suggestions via context menu should work

If a screen reader user tries to get spelling suggestions for a misspelled word, they usually first move to the beginning of the word using Ctrl+Left/Right and then invoke the context menu.
On Windows, Ctrl+Left/Right always moves to the start of the word. On other platforms, Ctrl or Cmd + Left moves to the start whilst Ctrl / Cmd + Right moves to the end of the word.
When any of the above keystrokes are pressed, the user hears the whole word.
It is not reasonable to expect the user to first press Ctrl+Left/Right to navigate through the line until they find the spelling mistake and then have to additionally press cursor right, (or cursor left when using Cmd-Right on Mac), so that the caret is within the word before invoking the context menu.
The result is that many screen reader users might have the mistaken believe that our spell checker is broken.
Tested: Manually, unit tests, layout tests
Bug: 790828

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I847419f299e1a56c4e32a7d00368f663f66072ff
Reviewed-on: https://chromium-review.googlesource.com/c/1252247Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597166}

Some of the tests make assetions on pref values, but they were doing so without
guarantees that the latest value were available. To solve the proble, I forced
the pending values to be written to the prefs and moved the assertion to the
callback that is invoked when this operation has finished.

Bug: 891573
Change-Id: I76411e6d93f061b12af2144cc88e9339531dd3a0
Reviewed-on: https://chromium-review.googlesource.com/c/1261995
Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597165}

Before this patch, WebController could not find the form data if that
form data was in an iframe. The logic that cleaned up the selector of
the element that was clicked on to pass to GetElementFormAndFieldData
didn't trigger, as the frame index reported in FindElementResult was 0.

This patch takes another approach: it always only pass the last selector
to GetElementFormAndFieldData, which should make sense, since we're in
the same context as the element that was clicked on.

With this patch, Autofill works even when forms are in an iframe.

Bug: 806868
Change-Id: Ic7deaf863373659e9143c38cf01a6ca1406e6521
Reviewed-on: https://chromium-review.googlesource.com/c/1264600
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597164}

Remove DelayRequestsOnMultiplexedConnections from field trial testing
config since the experiment is now default enabled in Chromium.

Bug: 836552
Change-Id: I9c0e0e233a47f9a92ea0562b77f6dcadea727e5b
Reviewed-on: https://chromium-review.googlesource.com/c/1259963Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597163}

Change-Id: I6dbc74bfa3e1cd27b9893c1d55c3e9277dc08d32
Reviewed-on: https://chromium-review.googlesource.com/c/1261968Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597162}

Bug: 888996
Change-Id: I00f30d4e2ea06be82d5f8872b2e31cf6a6bd1415
Reviewed-on: https://chromium-review.googlesource.com/c/1263556Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597161}