- 08 Jan, 2021 40 commits
-
-
Aleks Totic authored
nodesFromRect returned table elements in an incorrect order in legacy table code. Test was modified to expect elements in correct order. It now passes in TablesNG. Change-Id: Ibdd1aef2b0fe5636c2bf8d560a7590acc463818d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616945Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841682}
-
Simeon Vincent authored
Change-Id: I107736901fddf919bb7cd61c08488f4fd79003e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618579Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841681}
-
Jarryd authored
* Add a method that will take the set difference of the test case file and the ignored test file. * Add support for per-platform ignore files. Bug: 1145240 Change-Id: I9c28d6f1fb82a6b13fcd0c9fae738c9aff0bd630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599831 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#841680}
-
Lukasz Anforowicz authored
This CL adds an AbstractOriginTest test suite that covers both blink::SecurityOrigin and url::Origin. Having tests that are shared across Blink and //url will help 1) avoid code duplication and 2) ensure that Blink and //url behave in the same way (at least wrt things covered by the shared tests). Bug: 1164416 Change-Id: I1a4ecb32eba4d31ca07328a43f4392586588aca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606715 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#841679}
-
Michael Crouse authored
This change provides the file for the language detection model needed in the TranslateAgent. Bug: 1151422 Change-Id: I24870758adf8b00ee378ca7ccc55bd45edb164d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599580Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Trevor Perrier <perrier@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#841678}
-
Jeroen Dhollander authored
This is a reland of ccba8bc4 The problem was that the fixes for the review comments had caused us to call AudioDevices::SetAudioDevices() before the constructor of |AudioDevices| had finished initializing all variables. Unfortunately this only happened on real hardware, and I had not retested these review comment fixes on hardware. Original change's description: > Consolidate interactions with |CrasAudioHandler|. > > Previously 2 places in the code were interacting with |CrasAudioHandler|: > - |PlatformApiImpl| subscribes to device changes, and passes this > information to |AudioInputHost|. > - |AudioInputHost| posts the new hotword model to |CrasAudioHandler|. > > This made it hard/impossible to split |AudioInputHost| from > |PlatformApiImpl|, which is needed to handle audio input in the > Libassistant mojom service. > > To solve this I moved all interactions with |CrasAudioHandler| inside a > new class |AudioDevices|, of which an instance is owned by > |AudioInputHost|. > > This also allowed me to add a bunch of new unittests. > > deployed on real hardware. > > Bug: b/171748795 > Test: chromeos_unittests --gtest_filter="Assistant*:Audio*" and manually > Change-Id: I8ec9cec6672236f6365345b292efbe828518be69 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610953 > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841155} Bug: b/171748795 Change-Id: I9b8b970fbd1011ce911bf99961159805a4c0d2a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617568 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841677}
-
Michael Lippautz authored
Bug: 1056170 Change-Id: Ib9f1b70a8ccb2dd8a026981f4be6751b97cbd528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617922 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#841676}
-
Aya ElAttar authored
- Changed the return type of DragDropDelegate::OnDragUpdated to return a struct of DragOperation and DataTransferEndpoint. - The returned DataTransferEndpoint should be used in DragDropController for allowing/disallowing dropping the data according to the policy rules, See crrev.com/c/2595382. Bug: 1139886 Change-Id: Ic80f2d55bf1df350d24778f01a43c8cba0ff67cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595411 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#841675}
-
Josh Nohle authored
Previously, callbacks passed into SecureMessage delegate methods were being forwarded directly to the EasyUnlock dbus service, which the delegate does not own. So, these callbacks can still be invoked after the SecureMessage delegate object is destroyed. In this CL, we bind callbacks sent to the dbus client to weak pointers. This ensures that consumers of the SecureMessage delegate will not have their callbacks invoked after the delegate is destroyed. Manually tested CryptAuth Enrollment, DeviceSync, and SmartLock flows. Fixed: 1163335 Change-Id: I69b24c675808312d4310f37ac830c7326c971275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616944 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#841674}
-
Hui Yingst authored
This CL migrates `plugin_size_`, `plugin_dip_size_` and `plugin_offset_` in OutOfProcessInstance from using pp::Point/pp::Size to their gfx:: equivalents, so that they can be migrated into PdfViewPluginBase later. Bug: 1101101 Change-Id: I5c36d6fcb99f9f4f92edeeb044fd6f2f04287565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616488Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#841673}
-
Xinghui Lu authored
As we add more fields into the proto, we'd like to monitor the network usage of real time URL check. Metrics added: SafeBrowsing.RT.Request.Size Bug: 1161342 Change-Id: I3bafe5bf7c8a2724d3c75adb2af869702a2db4be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617575Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841672}
-
Joel Riley authored
AX-Relnotes: N/A Bug: 1163684 Change-Id: Ief0ce745ba348f6ad374d6ecf1ca088ffa59ef52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616520Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Joel Riley <joelriley@google.com> Cr-Commit-Position: refs/heads/master@{#841671}
-
Brandon Wylie authored
TBR=meiliang@chromium.org Bug: 11644850 Change-Id: Ie1965d1b608f179864430516a5c370e6ccd20204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618553 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841670}
-
David Black authored
Per UX request, restoring slight elevation to holding space tray icon previews to add depth and dilineation. This CL also makes a slight tweak to shrinking of white backgrounds that was done to prevent paint artifacts from showing behind images. Previously we shrunk backgrounds by twice as much as was necessary. Bug: 1163304 Change-Id: I1b65bb65de3e331f2e58c2993fe1634d5dabcb98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618560Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#841669}
-
Erik Chen authored
We have now qualified our first dogfood release, so it's safe to enable dogfood releases by default. Bug: 1164154 Change-Id: I248bb8f5d2ea6dce1e2754a959b421cb1704d879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618365 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#841668}
-
Zhaoyang Li authored
When reporting test results to ResultSink, this could reduce log spams stating post success for each test result. Bug: 1157537 Change-Id: Ibdb67d22e192c1967038a4ceaeef7d2d82f0edd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590647Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#841667}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/afc78f5e6ae9..61125414310a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Icceeabd8f76e7ea4b8cdf86a3e6453fe7fa74459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618288Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841666}
-
rbpotter authored
This CL hardcodes the CloudPrintWarningsSuppressed pref to true for all users. Bug: 1144931 Change-Id: Ia997ba7cb2082151c99b825e5abdb8f0cf100cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617569Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#841665}
-
Zhaoyang Li authored
This change will prevent "Uninteresting mock function call" GMock log spams, which could attribute to 1/3 of log lines in some unit test targets and is causing slowness in swarming infra processing logs at collecting tasks. Bug: 1157537 Change-Id: I1dd2780329ab8568a4582d6ef4e3a5a7d4a68016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587605Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#841664}
-
Marc Treib authored
This CL enables AutofillEnablePasswordInfoBarAccountIndicationFooter (in addition to the existing config), to match the actual config that we intend to launch. (This should've been part of the previous CL, https://crrev.com/c/2595742, but I missed it there) Bug: 1121258 Change-Id: Id9852a09b719e99aea517cb3a1db846f42e06dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617843 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#841663}
-
Shane Fitzpatrick authored
Fixed: 1164114 Change-Id: I6e121d62052bf14126cd6e3cc3056cd83e1bd5e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617361Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Shane Fitzpatrick <shanefitz@google.com> Cr-Commit-Position: refs/heads/master@{#841662}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a24bf6b63c40..e12745c2764b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dalecurtis@google.com,wjmaclean@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1139098,chromium:1150547,chromium:1150925,chromium:1150928,chromium:1161396,chromium:1163881 Tbr: dalecurtis@google.com,wjmaclean@google.com Change-Id: If14f431c599983601158d7c2bf5b963c5ea282f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616827Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841661}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2033aa92..6bb19707 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I206857a00d8546b9d58ecc0aaee30c9d8f0dfc1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618492Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841660}
-
Brandon Jones authored
This reverts commit 480f5952. Reason for revert: Wrong revision of patch landed. Original change's description: > GPUQueue.writeBuffer takes offset/size in elements with TypedArrays > > Previously dataOffset and size were always in bytes, which isn't > consistent with the WebGPU spec. > > Corresponding CTS test here: https://github.com/gpuweb/cts/pull/431 > > Bug: 1163667 > Change-Id: I5360cfbd66542c044dcf909b8673d3ed3f5e6724 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615520 > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Brandon Jones <bajones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841617} TBR=bajones@chromium.org,cwallez@chromium.org,kainino@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I385bb20542bb12e609d40087a2458e8775499438 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1163667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618376Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#841659}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/942976eacacf..644164c9c4b3 2021-01-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 82fccc55..211a9ad8 (841356:841507) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I606359377720741feb57b761147087bba38a03d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618286 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841658}
-
Henrique Ferreiro authored
speech_monitor.{cc/h} were being included in both "browser_tests" and "test_support" targets in //chrome/test. Given that the tests depend on test_support, this CL removes the files there and relies on the build dependency. Change-Id: Ia6f4d993ffd0e156c5f665f18377e34f51e3a9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617844Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#841657}
-
Owen Min authored
KeyedServiceFactory crash when passing in a null pointer. Hence check the pointer ahead of time and return NO early like other code in the same function. Bug: chromium:1161109 Change-Id: I3addf01456f27f42e97dcb3810cf367731279921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618201Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841656}
-
Yusuke Sato authored
This CL removes the unused argument and changes the return type to void. BUG=None TEST=try Change-Id: I91926f78b02879f0e217f32e8bb210d2960f6e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618090Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#841655}
-
Jonah Ryan-Davis authored
The more specific test suite should be used to ensure we don't miss testing on any of ANGLE's backends. In this case, the generic test suite was being used for webgl and webgl2, which defaulted to passthrough with ANGLE's GL backend. This CL specifies the validating decoder for webgl1 and passthrough for webgl2, removing the duplicate testing of webgl1 on the GL backend. Bug: chromium:982292 Change-Id: I221307922e7fae4f8baa5122abae969ce5d5d4fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615818 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#841654}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/0901a6f74c70..34315538364b 2021-01-08 apodtele@gmail.com [builds] Revert `FTMODULE_H' changes. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC thestig@google.com,bungeman@google.com,drott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: thestig@google.com,bungeman@google.com,drott@google.com Change-Id: I196f81e070360572ac50137bb2ee2abe46c0be5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618461Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#841653}
-
Stefan Zager authored
The UMA category was added by: https://chromium-review.googlesource.com/c/chromium/src/+/2593246 Bug: 1149692 Change-Id: I6016fb72cc62ead7d8f91210a690793cccd693a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613346 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#841652}
-
spdonghao authored
This transitionType set in willHandleLoadUrlWithPostDataFromStartSurface in ReturnToChromeExperimentsUtil was from "Experiment: Show the omnibox on the tab switcher."[1] and were supposed to be FROM_ADDRESS_BAR then. However this is not accurate anymore for now. It's not guaranteed to be from address bar. [1] https://crrev.com/c/1592791 Bug: 1134187 Change-Id: Iab1154fa8395cace3e5a28ca53efbceb11a646ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593770 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#841651}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6ddca3188e2e..59450acba8d5 2021-01-08 michael.liao@microsoft.com [Font Editor]: Changing font weight for section titles If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1163821 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id020b6d3f5145f60b38aa8783dcce1687cf88cf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616825Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841650}
-
Domenic Denicola authored
Origin policy is on hold, and instead of updating it to support the new name for origin isolation ("origin-keyed agent clusters"), it's better to just remove the integration. Bug: 751996, 1158853 Change-Id: I5450c72d93948675f467624142aad0fc6694c838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615999 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#841649}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/11e6cfe60a92..61125414310a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I53cb3d186a0f9b2ba10c38100cd97c52a20dab74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617467Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841648}
-
Jimmy Gong authored
If a device has no internal battery, it made no sense to use the phrase "While charging" as it implies that there is a battery to be charged. This change moves the idle power dropdown to the "When idle" section. Screenshot: https://screenshot.googleplex.com/4qDUBZaQWDFyRwj Fixed: 1096675 Test: browser_tests Change-Id: Ib7e8cd1331b92ac9bf420d32833f14486f07befd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616800Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#841647}
-
Hassan Talat authored
This CL sets up a mojo interface and impl for the Window Controls Overlay Javascript API and is hooked up to the local frame.The changes are behind the flag: "WebAppWindowControlsOverlay" Explainer: https://github.com/WICG/window-controls-overlay/blob/master/explainer.md Design Doc: https://docs.google.com/document/d/1k0YL_-VMLIfjYCgJ2v6cMvuUv2qMKg4BgLI2tJ4qtyo/edit?usp=sharing I2P: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/cper6nNLFRQ/hU91kfCWBQAJ Bug: 937121 Change-Id: If21fa244ce48383748212de840ed7f5f64ea2080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551285Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hassan Talat <hatalat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#841646}
-
Stephan Hartmann authored
GNU libstdc++ std::vector explicitely forbids creating an std::vector of const types. Remove const from type and return const_iterator instead. Bug: 957519 Change-Id: I6a56df65e8a864fa9f473884e2125db8f0469bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601487Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#841645}
-
Gavin Williams authored
Create a histogram to record the reason for a scan job not succeeding. Bug: 1059779 Change-Id: Ibdf6806b314292ae79b87eb20e6a892553525f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596253Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#841644}
-
Kyle Horimoto authored
This metric provides insight into the ways that Nearby Connections disconnect, including failures reasons. This will help us dig into potential failure reasons for connection stability. Bug: 1163979 Change-Id: I1e685ea6863cfe2bb12a7bbdd20decd9887337ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616478 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#841643}
-