GitLab

Please reply to the V8 sheriff svenpanne@chromium.org in case of problems.

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/409363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284917 0039d316-1c4b-4281-b951-d872f2087c98

Based on experimentation, it appears that calling setNeedsDisplay or
displayIfNeeded on a CAOpenGLLayer which has the isAsynchronous
property set, will result in the animation getting screwed up. In
particular, calls to canDrawInCGLContext stop occurring.

This was working in M35 and M36 because, entirely accidentally, we
were calling setAsynchronous:NO before most instances of
setNeedsDisplay and displayIfNeeded. In r272469, these calls were
removed, and resulting in the janky animation.

Add calls to setAsynchronous:NO before all instances of calling
displayIfNeeded, and almost all instances of calling setNeedsDisplay.

BUG=395827
TEST=manual, automated tests in progress

Review URL: https://codereview.chromium.org/408153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284916 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=344769

Review URL: https://codereview.chromium.org/410083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284915 0039d316-1c4b-4281-b951-d872f2087c98

Before, wifi_config_view directly set the shill::kEapCertIdProperty and shill::kEapKeyIdProperty. Since the system token is enabled in ChromeOS, these properties have to be of the format '<slot_id>:<key_id>' and not only '<key_id>'.

This change fixes this by reusing the client_cert::SetShillProperties function, which sets the properties in the correct format.

R=pastarmovj@chromium.org
TBR=stevenjb@chromium.org
BUG=358366, 396181

Review URL: https://codereview.chromium.org/415483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284914 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes an issue where combobox dropdowns would render in the wrong
place for tabs that were created in the background. This was happening
because the native view and clipping windows weren't being added in the
right order, causing the incorrect screen space coordinates to get
passed around.

BUG=394715

Review URL: https://codereview.chromium.org/399343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284913 0039d316-1c4b-4281-b951-d872f2087c98

Since these targets are not static libraries, hard_dependency has no
effect (confirmed by Mark Mentovai and Tony Chang).

Files found with the following command line:

$ for f in $(g ls-files | grep strings.gyp ); do grep hard_dependency $f; echo $f; done
$ for f in $(g ls-files | grep resources.gyp ); do grep hard_dependency $f; echo $f; done

BUG=None
TEST=None
R=jochen@chromium.org,yoz@chromium.org

Review URL: https://codereview.chromium.org/393123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284912 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn extensions/common
R=brettw@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/411783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284911 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds support for copying files which are on the same provided file
system. Note, that copying between file system instances will be done using
FileStreamWriter.

TEST=unit_tests, browser_tests: *FileSystemProvider*Copy*
BUG=391362

Review URL: https://codereview.chromium.org/384303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284910 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284909 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178709:178745&mode=html
TBR=pkasting@chromium.org,haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/411863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284908 0039d316-1c4b-4281-b951-d872f2087c98

> aura: Use PlatformWindow from WindowTreeHostWin.
> 
> With this patch, both Windows and Ozone implementations use PlatformWindow for
> interacting with the native windowing system. Eventually, the X11 implementations
> will also use this, and WindowTreeHost will have a single implementation on all
> platforms.
> 
> BUG=none
> R=ben@chromium.org
> 
> Review URL: https://codereview.chromium.org/400413002

TBR=sadrul@chromium.org

Review URL: https://codereview.chromium.org/410873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284905 0039d316-1c4b-4281-b951-d872f2087c98

The instance |ChildThread::service_worker_dispatcher_| is never used. Removing.

BUG=None

Review URL: https://codereview.chromium.org/408143013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284904 0039d316-1c4b-4281-b951-d872f2087c98

This patch migrates entries to external entries, as preparation for taking an advantage of external entries.

BUG=none
TEST=video player works
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/414623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284903 0039d316-1c4b-4281-b951-d872f2087c98

Previously the video player used old way to control a cast, but it's now deprecated and we need to migrate to new way.

BUG=305511
TEST=List of casts is shown
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/410043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284902 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162827

Review URL: https://codereview.chromium.org/411543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284901 0039d316-1c4b-4281-b951-d872f2087c98

BUG=223352
TBR=bruening@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/416463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284899 0039d316-1c4b-4281-b951-d872f2087c98

This make VideoRenderer consistent with the rest of the media pipeline.

BUG=349211
TEST=All existing tests pass.

Review URL: https://codereview.chromium.org/414583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284898 0039d316-1c4b-4281-b951-d872f2087c98

In case display width is less than content width,
UpdateCachedBoundsAndOffset() does not handle center-aligned text
properly when content width is reduced (e.g. by deleting some
characters) or display width is increased.

BUG=none

Review URL: https://codereview.chromium.org/384953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284897 0039d316-1c4b-4281-b951-d872f2087c98

Disable report rate throttling on test for faster test iteration

BUG=344769
TEST=unit_tests --gtest_filter='DriveBackendSyncTest.*'

Review URL: https://codereview.chromium.org/417443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284896 0039d316-1c4b-4281-b951-d872f2087c98

Remove the suppression of this test with LEAK_SANITIZER as it does not
leak any more.

BUG=317363
TEST=browser_tests + lsan

Review URL: https://codereview.chromium.org/404693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284891 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162827

Review URL: https://codereview.chromium.org/405993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284889 0039d316-1c4b-4281-b951-d872f2087c98

As written the argument ended up in the .ninja file as \\\$$ORIGIN/lib/
but we want \$$ORIGIN/lib/ to match gyp.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/409883009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284888 0039d316-1c4b-4281-b951-d872f2087c98

These functions are simplistic and doesn't depend on chrome's
feature, so there's no reason to be under chrome/browser.
Moving to components/ would help further componentization
task of autocomplete anad omnibox_field_trials.

BUG=371538
R=brettw@chromium.org, pkasting@chromium.org, blundell@chromium.org
TBR=tedchoc@chromium.org, jhawkins@chromium.org
TEST=build

Review URL: https://codereview.chromium.org/393173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284885 0039d316-1c4b-4281-b951-d872f2087c98

The example window currently doesn't activate itself properly because it
lacks an activation policy and a menubar.

This CL sets the activation policy, adds a menubar and defers window
creation until the applicationDidFinishLoading notification. Creating a
window before this can activate and receive key events, but the menubar
will not switch properly.

With this, views_examples_with_content_exe compiles and runs nicely on a
Mac build with `GYP_DEFINES=toolkit-views=1`. Note the `WebView` example
will crash for now because views::NativeViewHost is not yet implemented
for mac.

BUG=395507

Review URL: https://codereview.chromium.org/309483009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284883 0039d316-1c4b-4281-b951-d872f2087c98

This adds logic for representing page skips as values in Telemetry, in the
spirit of how failures are to be handled with regard to the linked bug. The
goal for this CL is just to add the logic, and then once it's safely in the
codebase, we can wire it up and make sure Buildbot is happy with it.

BUG=392901

Review URL: https://codereview.chromium.org/409023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284882 0039d316-1c4b-4281-b951-d872f2087c98

Icons from the webstore can be unusual sizes. Once installed,
ExtensionAppItem uses extension_misc::EXTENSION_ICON_MEDIUM (48) to load
it, so be consistent with that.

BUG=338253
TEST=(CrOS) Start installing a large app from the webstore (e.g. tank
riders). While it has a progress bar, drag it around the app launcher -
the icon should grow a little, not a lot (see bug for screenshots).

Review URL: https://codereview.chromium.org/400893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284879 0039d316-1c4b-4281-b951-d872f2087c98

UIThreadSearchTermsData is responsible to get the value instead.
Remove |start_margin| argument from GetInstantURL() as all users are passing kDisableStartMargin for it.
Add a new test TemplateURLTest.OmniboxStartmargin

BUG=388515
TEST=components_unittests

Review URL: https://codereview.chromium.org/396583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284878 0039d316-1c4b-4281-b951-d872f2087c98

Add SyncClient::WaitForUpdateTaskToComplete().
Use the new method from CoypOperation.

BUG=384213
TEST=unit_tests

Review URL: https://codereview.chromium.org/372713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284877 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284876 0039d316-1c4b-4281-b951-d872f2087c98

Changing gesture handling in Views textfields to be more consistent with
blink's textfields. The main changes are:
 - Dragging text scrolls the text in textfield;
 - Tap on selection activates touch editing;
 - Double-tap selects a word;
 - Triple-tap selects the entire text;
 - Long-press off selection selects a word;
 - Long-press on selection starts drag-drop (if drag-drop is enabled) or
   shows context menu (if drag-drop is disabled);
 - Long-tap shows context menu, if drag-drop started on the
   corresponding long-press was not exercised.

BUG=388862

Review URL: https://codereview.chromium.org/407993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284875 0039d316-1c4b-4281-b951-d872f2087c98

Fake entries are readonly and it is not useful for the save dialog.

BUG=396179
TEST=manually

Review URL: https://codereview.chromium.org/410843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284874 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds support for creating files via AsyncFileUtil::EnsureFileExists.
Note, that creating files from NaCL is not supported yet.

TEST=unit_tests, browser_tests: *FileSystemProvider*EnsureFile*,
     *FileSystemProvider*CreateFile*
BUG=391362

Review URL: https://codereview.chromium.org/389893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284873 0039d316-1c4b-4281-b951-d872f2087c98

This results in a significant speedup; tests run in <500ms instead of >2s because the lengthy browser_tests startup is avoided.

This clones some aspects of extension_function_test_utils into extensions/browser/api_test_utils.cc. Later CLs will clean up the redundancy.

BUG=388893

Review URL: https://codereview.chromium.org/394103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284872 0039d316-1c4b-4281-b951-d872f2087c98

This will allow us to be able to intelligently de-apply patches,
re-run the tests, and compare the results on the bot. A follow-on
patch will also enable uploading the results to
test-results.appspot.com

R=dtu@chromium.org
BUG=323212

Review URL: https://codereview.chromium.org/407243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284871 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378924

Review URL: https://codereview.chromium.org/392293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284870 0039d316-1c4b-4281-b951-d872f2087c98

This allows some videos with incorrectly set reserved bits to play.

BUG=393304

Review URL: https://codereview.chromium.org/412693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284869 0039d316-1c4b-4281-b951-d872f2087c98

Now, CleanUpAfterPage will also do the cleanup. (This is not a great
solution, but it will unblock the other patch without re-engineering
the whole resource cleanup mechanisms.)

In my other patch, the order of GC changes somehow (not sure yet why),
which caused SmoothnessUnitTest to fail since __del__ is not called
before the next test starts.

BUG=350841,348271

Review URL: https://codereview.chromium.org/409113006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284868 0039d316-1c4b-4281-b951-d872f2087c98

Glen and Alex suggested putting all of the "detail" strings for overridable errors into the following format:

This server could not prove that it is example.com; <INSERT SHORT REASON HERE>. This may be caused by a misconfiguration or an attacker intercepting your connection.

BUG=

Review URL: https://codereview.chromium.org/404923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284867 0039d316-1c4b-4281-b951-d872f2087c98

This is no longer necessary since crbug.com/123007 was fixed.

BUG=123007

Review URL: https://codereview.chromium.org/378193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284866 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394644

Review URL: https://codereview.chromium.org/409883007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284865 0039d316-1c4b-4281-b951-d872f2087c98