- 05 Sep, 2019 40 commits
-
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/captive_portal. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=mmenke@chromium.org Bug: 891670 Change-Id: I1125b34060d286987b18944e071148b8b7dacb84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787097 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#693711}
-
Rune Lillesveen authored
To support different color values for form controls in UA stylesheets based on color-scheme, we need a way to provide a way to specify that. This CL introduces a new color function only available in UA stylesheets to do that. Design document: https://docs.google.com/document/d/1RRyQSdohsl8S9kQIdC6rYwwVy6cY15gjkGMgyadTORg Bug: 939811 Change-Id: I9c68d0bf0dea1eb6c5bd6c3b07d677e57779b6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782158Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#693710}
-
Andrew Grieve authored
This reverts commit 0ad8ca81. Reason for reland: Removed @CheckDiscard and filed bug TBR=agrieve #reland Change-Id: I88779e45a49c1bad7fc6365c373d55ed9d800df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784962 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#693709}
-
Gabriel Charette authored
Backport some tests in /media/mojo/services/mojo_audio_input_stream_unittest.cc to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /media/mojo/services/mojo_audio_input_stream_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=henrika@chromium.org Bug: 891670 Change-Id: Ia3896fb8e3744e12405528a785479e08ab05d395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786677 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#693708}
-
Gabriel Charette authored
Backport some tests in /media/mojo/services/mojo_audio_output_stream_provider_unittest.cc to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /media/mojo/services/mojo_audio_output_stream_provider_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=olka@chromium.org Bug: 891670 Change-Id: I6db90bfd72373e3fef77b101d7c940b4b7de9ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786854 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#693707}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ca5ee4c937cc..2dc5f73698ee git log ca5ee4c937cc..2dc5f73698ee --date=short --no-merges --format='%ad %ae %s' 2019-09-05 treehugger-gerrit@google.com Merge "Show devices in target selection dropdown & improve error handling" 2019-09-05 hjd@google.com Merge "trace_processor: Parse async systrace events" Created with: gclient setdep -r src/third_party/perfetto@2dc5f73698ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I1f2ecadffa6ddd05b1ec56be38e44ca6da3728ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787839Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693706}
-
Nico Weber authored
Mac bundles violate this constraint, so this adds many whitelist entries. Fixing them seems not super easy, so I filed https://crbug.com/1000667 for it. Bug: 1000667, 912946 Change-Id: Ibc1704fe779c6ccc86871a1b651f52572db3f919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780883 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#693705}
-
Olga Sharonova authored
TBR=dmazzoni@chromium.org Bug: 1000965 Change-Id: I710ccc544142c26ede9497436f8a19ca37c1a97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787780Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Auto-Submit: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#693704}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5eeb3db1. With Chromium commits locally applied on WPT: e7387117 "[sms] Allow SMS Receiver for same origin iframes" 36b875c4 "[WPT/mixed-content] Regenerate test files warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 648 and retry the command." afac3266 "Set `Sec-Fetch-Mode` from the network service." 851ab8fb "[WPT/referrer-policy] Regenerate attr-referrer tests" 6facce4a "[WPT/referrer-policy] Regenerate img-tag meta-referrer tests" 9d98088f "[WPT/referrer-policy] Regenerate a-tag tests" bb9c94d9 "Simplify fetch-event-within-sw.https.html using async/await" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I34e5e3bed3c71ac40b9f8e70ab34ca38e6f240bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787242Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693703}
-
Carlos Caballero authored
Remove references in /media/audio MessageLoopForIO is going away soon. Use SingleThreadTaskExecutor for main functions and SingleThreadTaskEnvironment for tests instead. Both are no op changes. This CL was uploaded by git cl split. R=olka@chromium.org Bug: 891670 Change-Id: Iea502221ede3aec4f88c76f3ac7ccb744a365b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781151 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#693702}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/ozone/platform/drm. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=dnicoara@chromium.org Bug: 891670 Change-Id: I1a2cb17e769126e955b904a0625393bc095febd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786937 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#693701}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/browser/speech. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=olka@chromium.org Bug: 891670 Change-Id: Ia9f81a7ca8460bb6e4aba386fc5f0e72fd62fa05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787061 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#693700}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/display. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=dnicoara@chromium.org Bug: 891670 Change-Id: I3c182143dc21321d260af70e344f4dbe8c61704d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786955 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#693699}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/policy. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=pastarmovj@chromium.org Bug: 891670 Change-Id: I47db4c4af8e3eb339e6ed231f6c666a2c79d6a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786938 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#693698}
-
Robbie Gibson authored
The major changes are in appearance_customization. Before, we were in the middle of migration, so I didn't want to set the tintColor by default on all views. Now, migration is complete, so this is safer moving forward. The rest of the changes are deleting places where tintColor is set unnecessarily. Bug: 974255 Change-Id: I2700cdca98c30602e0025481a3da6800bd1f8388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787283Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#693697}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/browser. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=boliu@chromium.org Bug: 891670 Change-Id: I7950058b91b35637f160a179f66af7c3a8abff6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787208 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#693696}
-
Sami Kyostila authored
Now that everyone has been migrated to the renamed PostTask/CreateTaskRunner APIs, we can remove these temporary wrappers. TBR=gab@chromium.org (to apply side-effects of mechanical change in //base) Bug: 968047 Change-Id: I69c53abd899f37586f23ec295ffcc9bf12042c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752787Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#693695}
-
Miyoung Shin authored
This CL converts MediaStreamDispatcherHost{Ptr, Request} in content to the new Mojo types. Bug: 955171 Change-Id: If8ad94a4bdb96778186812973f4335ceb63c046f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782404 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#693694}
-
Andrew Grieve authored
Bug: 1000510 Change-Id: I6d26647c389b75bbc37dcc0fbafc18d25e84285b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785102 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#693693}
-
Gabriel Charette authored
Backport some tests in /content/browser/renderer_host/embedded_frame_sink_provider_impl_unittest.cc to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/browser/renderer_host/embedded_frame_sink_provider_impl_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=kylechar@chromium.org Bug: 891670 Change-Id: I31b489442139463f8f7a80705381c71bbf95da52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786805 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#693692}
-
Jan Scheffler authored
Added comparator to Application > Cache Storage for the Response-Type column introduced in #ce8a01b6. Bug: chromium:1000297 Change-Id: I0da66b2433ed70db23a9ef11ff98a724b93f9193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782808Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@google.com> Cr-Commit-Position: refs/heads/master@{#693691}
-
Michael Hablich authored
This is a roll-back to V8 7.8.279. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org Change-Id: I179ef83d727c8d1d35239a83235d22a9f306e40f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787778Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#693690}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/chrome_cleaner. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=proberge@chromium.org Bug: 891670 Change-Id: I5dbb5c262c0cce3f6a77959048b36b7bf2b90ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787069 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#693689}
-
Daniel Vogelheim authored
This adapts Trusted Types to recently proposed spec changes, where a regular error that occurs during default policy application will simply be passed on to the app, while a return value of null or undefined signals that the default policy does not wish to deal with that value (and hence default policy application failed, in the Trusted Types sense of 'failed'). Change-Id: I41fd23019137e640b1c1b2df7d02c0b8e69932a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778485 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#693688}
-
Gabriel Charette authored
Backport some tests in /components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=kolos@chromium.org Bug: 891670 Change-Id: I71ab175a4439b84cf6828701c5a7dd1c7c95110d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787071 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#693687}
-
Maksim Ivanov authored
Add the "BACK" button into the PIN keypad displayed on a user pod that use the challenge-response authentication (a.k.a. smart card login). Clicking this button allows to exit the PIN keypad and abort the challenge-response authentication. Before this CL, there was no way to abort the authentication besides waiting some internal timeout (e.g., a few minutes for D-Bus calls) is hit. Bug: 983103 Test: start existing challenge-response user sign-in, check that the PIN keypad with the BACK button is shown, click BACK, check that the PIN keypad disappears Change-Id: Ideb451820b40578f06e98db97fb259473118b047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784616 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#693686}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ecac2f8fe9bb..d0e56cc64289 git log ecac2f8fe9bb..d0e56cc64289 --date=short --no-merges --format='%ad %ae %s' 2019-09-05 lujc@google.com Add fallback to write GLenum as hex in capture 2019-09-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 56f61ccceffa..34953810a62c (1 commits) Created with: gclient setdep -r src/third_party/angle@d0e56cc64289 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: chromium:None Change-Id: I21f0104a7a9117813eacd66305cbeb5ac3fb2eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787838Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693685}
-
Elly Fong-Jones authored
This document describes how to use isolates and swarming to debug individual test failures. Bug: None Change-Id: I7afe6f79caf41dd06f01be01580f738d2a3f661c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778984 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#693684}
-
kylechar authored
Make sure that the context supports OOP-R before using it. Also ensure that browser main thread context on Chrome OS supports GrContext since HUD layer can be created by ash. Bug: none Change-Id: Ifeec20b3064f88c5c2b72d00d688efb30d75b3bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778643 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#693683}
-
Dave Tapuska authored
Remove a nested RequestContext that didn't do anything. Rename or reuse variable on stack for remaining shadowed errors. BUG=794619 Change-Id: I12f61d5528d62ee64d82104d190eecb6ccd65a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784973Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#693682}
-
David Staessens authored
This CL changes the video_decode_accelerator_(perf_)tests to not read data beyond the end of the test video file, by adding proper bounds checking. TEST=./video_decode_accelerator_tests \ vda_sanity-vp90_2_17_show_existing_frame_20190109.vp9 BUG=None Change-Id: I486eb6eb89fd13d9985ee518178b65dadf158e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775944Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#693681}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d29c5b184087..79401df82ffb Created with: gclient setdep -r src-internal@79401df82ffb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I062d39eaaf367b47886776eb0af4ebfe40aedb01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787520Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693680}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/24b945d60526..f3f61591146b git log 24b945d60526..f3f61591146b --date=short --no-merges --format='%ad %ae %s' 2019-09-05 saza@webrtc.org Rename VectorBuffer->SpectrumBuffer, MatrixBuffer->BlockBuffer, BlockBuffer->Aec2BlockBuffer 2019-09-05 jakobi@webrtc.org Make relative arrival delay mode default in NetEq delay manager. 2019-09-05 saza@webrtc.org Make VectorBuffer in AEC3 multi-channel 2019-09-05 danilchap@webrtc.org Delete deprecated rtc_event_log_factory_interface.h Created with: gclient setdep -r src/third_party/webrtc@f3f61591146b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Iae086e6532ba46cc65761a7913e0e76dc7b3b06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787837Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693679}
-
David Roger authored
These metrics were introduced for investigation of bug 876306. Enough data has been collected for the investigation, there is no point in collecting more data. This CL removes all the metrics except ListAccounts.NetErrorCodes because this metric can be used to monitor the health of the signin component and help diagnosing problems. Bug: 986524, 986518, 986513, 876306 Change-Id: I032e6fe181d91982a6a1811d91883bea6dce810e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784613 Commit-Queue: David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#693678}
-
Rayan Kanso authored
Record whether the fired sync events upon completion originated from a wakeup task. This metric can be used with the BackgroundSync.WakeupTaskFiredEvents metric to figure out how common it is to wake up the browser to fire events without actually completing them. To make the metrics accurate, delayed tasks are allowed to reschedule now. Bug: 991326 Change-Id: Icf3922995230b15e867574bb7b348e1627268ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781589 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#693677}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/component_updater. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=waffles@chromium.org Bug: 891670 Change-Id: I4f3806776673850e73bd3d6966d1ae50b0b5e43d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786752 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#693676}
-
Miyoung Shin authored
This CL converts WakeLockProviderPtr in chrome, chromeos, components, content, extensions and services and WakeLockProviderRequest in services to the new Mojo types. Bug: 955171 Change-Id: I5e95a88fc154fee57930e37871ca670d547c42d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768611 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#693675}
-
Gabriel Charette authored
Backport some tests in /ui/views/cocoa/bridged_native_widget_unittest.mm to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/views/cocoa/bridged_native_widget_unittest.mm. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=ellyjones@chromium.org Bug: 891670 Change-Id: I849eac5a74cdb4436db995a38d4be4133b0d6381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786745 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#693674}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ios/net. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=ellyjones@chromium.org Bug: 891670 Change-Id: I06b784de2f3374bcf57a1b0a39a9df200e67e953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786969 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#693673}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/99431375c8b5..ca5ee4c937cc git log 99431375c8b5..ca5ee4c937cc --date=short --no-merges --format='%ad %ae %s' 2019-09-05 lalitm@google.com Merge "trace_processor: expose gpu tables to SQLite" Created with: gclient setdep -r src/third_party/perfetto@ca5ee4c937cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I7ed59b33d6a4bb7bc075255c4307f30758e901aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787522Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693672}
-