- 13 Feb, 2020 40 commits
-
-
Yutaka Hirano authored
Have content and blink use net::structured_headers directly. Bug: 1049936 Change-Id: Id20cf975fbaf6710dc17d9e22a66131b44edce38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053465Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#741066}
-
sandromaggi authored
Before this change, we sent a "input.value = ''" command, then clicking into the field and starting to send keystrokes. The new approach selects the current value ("input.select()"), omits the click (as we already have focused the element by selecting its value) and starts sending the keystrokes. It seems this behaves better. This is based on empirical evidence, as there is no automated test that failed before but succeeds now. Bug: b/149004036 Bug: b/148874087 Change-Id: Idd13b4eb1b5f33799da008dc3d57f8230e5311f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043887 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#741065}
-
Robert Ma authored
external/wpt/infrastructure/server/wpt-server-http.sub.html crashes because of the lack of HTTP/2, so we have to disable it. wpt_internal/infrastructure/wpt-server-http.sub.html needs to explicitly setup single_test because of the recent change in single-page tests. Bug: 1048761, 1049703, 1050212 Change-Id: Ida65d4cf1eabcc39bc1078b84419d41091ac3c98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053844Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#741064}
-
Nazih Almalki authored
after M81 this metric is no longer valid Bug: 1037240 Change-Id: I608f2c22f04891f5c70da82488f897ffe1608da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048307 Commit-Queue: Nazih Almalki <nalmalki@google.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741063}
-
Gyuyoung Kim authored
This CL migrates the legacy InitiateCaptureDump IPC message to the new Mojo defined in WebTestClient interface. Bug: 1039247 Change-Id: I3d4ff94d9a0285f25020cdc86eccff6d80af29a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035829 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#741062}
-
Henrique Ferreiro authored
This CL ports calls to ConsoleMessage::Create() factory methods to MakeGarbageCollected<ConsoleMessage>(). While doing this, two constructors are merged providing a default value, and a DCHECK is added to comply with the constructor comment. Bug: 939691 Change-Id: Id4336d6db4921e16a55ff43ab9285e59b2ddf394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007689 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Alex Ilin authored
chrome.identity.launchWebAuthFlow() observes all navigations in the provider's auth flow. Chrome stops the auth flow if one of the navigations fails, assuming that the provider's auth URL cannot be load. This also includes navigations in sub-frames. Dropbox auth provider inserts <iframe>s with ReCAPTCHA challenges on their auth page. For some reason, this page decides to remove an iframe before it commits a navigation, making launchWebAuthFlow() abort the auth flow. This restriction looks unnecessary and prevents launchWebAuthFlow work with Dropbox auth provider. This CL stops launchWebAuthFlow() observing navigations in subframes. Bug: 1049565 Change-Id: I5b596466bc69410b12150221c456d1777106c0d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054226 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#741060}
-
Stephen McGruer authored
This reverts commit cb40a6b9. Reason for revert: Appears to cause consistent failures on linux-chromeos-chrome (https://crbug.com/1051949) Original change's description: > Desktop PWAs: Port various PWA mixed content tests with BMO > > The HostedAppPWAOnlyTestWithAutoupgradesDisabled tests > have been moved to > PWAMixedContentBrowserTestWithAutoupgradesDisabled > as they no longer depended on the extensions-based > implementation. > > Note that the HostedAppTestWithAutoupgradesDisabled and > HostedAppPWAOnlyTestWithAutoupgradesDisabled tests in > hosted_app_browsertest.cc have not been run recently, as > there was no INSTANTIATE_TEST_SUITE_P entry for these tests. > > Some mixed content now loads with warnings (due to security > changes that occurred while the tests were not enabled). > > Bug: 1026080 > Change-Id: I1edc65263be42bcdd7a23959bbf86081adfed9c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049407 > Commit-Queue: Eric Willigers <ericwilligers@chromium.org> > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741029} TBR=ericwilligers@chromium.org,alancutter@chromium.org,loyso@chromium.org Change-Id: I24a894a6eebecb55143376ca2aa2652d6397e7b2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026080 Bug: 1051949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053291Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#741059}
-
Daniel Cheng authored
Blink allows use of the //base histogram helpers, so switch away from the Blink-specific histogram helpers and standardize on //base. The long-term goal is to remove the Blink helpers, which differ from the //base ones in some interesting and surprising ways. Miscellaneous cleanup: - use the histogram functions where appropriate (i.e. for metrics that aren't recorded on performance-critical paths) - simplify recording percentages in histograms by using the base helper. Bug: 1047547 Change-Id: I2e5d9effe777d3ea44991069f8c523a89f3ee3a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053855 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#741058}
-
Stephen McGruer authored
This reverts commit 7466ee73. Reason for revert: Fails on win-asan; https://crbug.com/1051946 Original change's description: > [bfcache] Record NextPaintTime on bfcache restore > > Add "BackForwardCache.Restore.NextPaintTime" histogram to > record next paint time on restoring a page from > bfcache. > > Update RecordContentToVisibleTimeRequest to include parameter > |show_reason_bfcache_restore|. > > Bug: 1034353 > Change-Id: I0b4d63b787017efe40caed9af7f3742b11cb43f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968977 > Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741037} TBR=dcheng@chromium.org,vasilii@chromium.org,fdoray@chromium.org,alemate@chromium.org,clamy@chromium.org,alexmos@chromium.org,altimin@chromium.org,sreejakshetty@chromium.org Change-Id: I07dced04a67db52840140eaaba8b99bef5245ff1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1034353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053459Reviewed-by:
-
Gyuyoung Kim authored
This CL replaces .mojom.h includes with .mojom-forward.h in some sub-directories of chrome/browser to reduce the pre-processed size of header files and shorter build time. The sub-directories are following, - chrome/browser/net - chrome/browser/offline_pages This CL has no behavior changes. Bug: 1001360 Change-Id: I8d9bf3f1b8f1e52f184321452a62e801c3b1004e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050056 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#741056}
-
Mike Reed authored
Change-Id: Ibd13a6ebcbed46a0f1349425a66a56117c085b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053768 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#741055}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I29882c1f045ec7b988baa3fa41e7c02b1f7629c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053907 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#741054}
-
Fredrik Söderquist authored
Appears to run stable now. (Maybe some risk for timeout on certain debug bots.) Tbr: schenney@chromium.org Bug: 658305 Change-Id: Ib8f73e6470642339e27c96da3c192f1e952998ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053805Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#741053}
-
Sigurdur Asgeirsson authored
This enables extended crash reporting for all process types on Windows. Bug: 1044707 Change-Id: I04f523429e1003867a27e571faa60a76debfce0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047456 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#741052}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1b7303cae360..97e4a75e6348 git log 1b7303cae360..97e4a75e6348 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 aerotwist@chromium.org [e2e] Adds error reporting to runner 2020-02-13 tvanderlippe@chromium.org Migrate console_counters/ to import cross-module Created with: gclient setdep -r src/third_party/devtools-frontend/src@97e4a75e6348 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia111bc8d8975de41da2417e5d2a8c587b2c82d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054426Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741051}
-
Gyuyoung Kim authored
This CL migrates the legacy RegisterIsolatedFileSystem IPC message to the new Mojo defined in WebTestClient interface. Bug: 1039247 Change-Id: I273f16a02ce758a2d5c0321b5df0fb3d4a71346d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040636 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
-
Jose Lopes authored
This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I597ce00f2a8fd064eb972080a3e33e474624233b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054223Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Jose Lopes <jabolopes@google.com> Cr-Commit-Position: refs/heads/master@{#741049}
-
Marc Treib authored
All invalidations clients have migrated to the new infrastructure, so the old implementation is now unused and can be cleaned up. This is a followup to https://crrev.com/c/1989750 which deleted the equivalent desktop code. This includes the Java classes InvalidationService, InvalidationClientService and PendingInvalidation, and the corresponding JNI wiring. This reduces Android binary size by about 8kB: Normalized APK Size: -8108 bytes Bug: 1029481 Change-Id: I1dbddaa7b49b526dba62a0e6bff48fdc6139d2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050590 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#741048}
-
Colin Blundell authored
This class was originally built only for WebView, where there are only browser and renderer processes. However, it was componentized for sharing with WebLayer, where there are other types of processes. After this componentization these other types of processes are encountered when logging memory metrics. This CL switches MemoryMetricsLogger from NOTREACHED() to no-op on encountering these process types to avoid crashing in debug builds. Change-Id: I21c97000e0352cf645ad7f34b8a16513f40d29aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054206Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#741047}
-
henrika authored
Avoids usage of an invalid number of input channels (=0) on machines with a discrete multi channel input channel configuration. Without this change, the user can experience a loud (buzzing) distorted audio signal. Bug: 1051043, 1051900 Change-Id: I8ebaee33959ae0da50bf93f0756810bc7f524349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054089 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#741046}
-
Mike Reed authored
Skia is moving to simplify pixel configs, and make N32 just an alias for BGRA. This should only affect chrome-android, which was treating it as RGBA. To this end, we need to fix up some legacy handling of (very) old serialized imagebitmaps. Related (pending) skia CL https://skia-review.googlesource.com/c/skia/+/269905 Shows the need for the change to SerializedColorParams... https://chromium-review.googlesource.com/c/chromium/src/+/2051195 Bug: skia:9896 Change-Id: Iea04407e51b9cc967c43113fa9b60dad315b99a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050576 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741045}
-
Fabian Sommer authored
Same for ParentAccessWidget -> PinRequestWidget. This CL is renaming + minor cleanups only and is not expected to change behavior. Bug: 1001288 Change-Id: I39881349d7f3bbb58029ab392cb572d14f986d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051271 Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#741044}
-
Evan Stade authored
Create a separate WebView-w/o-WebLayer target, SystemWebViewNoWebLayer.apk, which is used to define the java strings which are held back from the language splits. This way, strings only used by WebLayer (e.g. //components/browser_ui/strings) and not WebView will be in language splits and the translations won't bloat MonochromePublic.apk. Bug: 1025256 Change-Id: I4f4f7c790b1d58738d8021a7972b77052a357303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047346 Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#741043}
-
Tim van der Lippe authored
Required for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2052169 TBR=aerotwist@chromium.org Bug: 1006759 Change-Id: I7f1ecfeb39baebb2fdb40286af3a445260157e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054246Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#741042}
-
Sigurd Schneider authored
In the future, DevTools wants to provide coverage numbers at certain points in time. This CL uses recently added machinery in V8 to trigger coverage updates from the back-end at certain lifecycle events. This allows us to get fairly accurate coverage numbers for lifecycle events. Previously, this was not possible, as coverage updates had to be triggered via CDP, and the delay until the front-end learned about a lifecycle event, plus the delay until the back-end actually took the coverage update, made the data inaccurate. Bug: chromium:1042927, chromium:1022031 Change-Id: I8c2115e9ef6876a4553bea8588ad8142818fc1ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022668 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#741041}
-
Brian Ho authored
In SharedImageRepresentationGLOzone, we create a GLES2 texture from an EGL image. However, we currently call SetLevelImage before SetLevelInfo, but SetLevelInfo immediately clears the image we just set [1]. This CL moves SetLevelImage to after SetLevelInfo so we can properly use the image stored at level 0 (e.g. for overlays [2]). [1] https://cs.chromium.org/chromium/src/gpu/command_buffer/service/texture_manager.cc?l=1359&rcl=a702473f065ae065bebfb20becd2d9e40ab2f5ad [2] https://cs.chromium.org/chromium/src/gpu/command_buffer/service/gles2_cmd_decoder.cc?l=13728&rcl=a702473f065ae065bebfb20becd2d9e40ab2f5ad Change-Id: I683091e2c0f4a7233868afa133674579625a70bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052488Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#741040}
-
David Roger authored
This is a speculative fix. This is a revert of https://chromium-review.googlesource.com/c/chromium/src/+/1831863 on Dice platforms. This won't fix the underlying bug in reconciliation, but should prevent the reconcilor from looping in this case. Bug: 1051864 Change-Id: Ica04d799cb5b159de99f06cab819bf53bef659b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054205Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#741039}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c83e88a57233..1b7303cae360 git log c83e88a57233..1b7303cae360 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 aerotwist@chromium.org [e2e] Fix failing console test Created with: gclient setdep -r src/third_party/devtools-frontend/src@1b7303cae360 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If82b8793862e49658464d69f319c160414634d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053862Reviewed-by:
-
sreejakshetty@chromium.org authored
Add "BackForwardCache.Restore.NextPaintTime" histogram to record next paint time on restoring a page from bfcache. Update RecordContentToVisibleTimeRequest to include parameter |show_reason_bfcache_restore|. Bug: 1034353 Change-Id: I0b4d63b787017efe40caed9af7f3742b11cb43f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968977 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#741037}
-
Alan Cutter authored
The NetworkContextConfigurationHttpsStrippingPacBrowserTest tests were removed in: https://chromium-review.googlesource.com/c/chromium/src/+/1567589 This CL removes the residue fixture and instantiation. This fixes the warning thrown by browser_tests: [test_launcher.cc(1498)] The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<NetworkContextConfigurationHttpsStrippingPacBrowserTest> Change-Id: I167dc60ebbfe788f0e3e2cc1202dfd744d1daabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053268 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#741036}
-
Gyuyoung Kim authored
This CL migrates the legacy GetWritableDirectory sync IPC messages to the new Mojo defined in WebTestClient interface. Additionally, this CL removes LocalFileToDataURL and ReadFileToString because nobody uses it. Bug: 1039247 Change-Id: Iecc34334d67e77b1a161da671a1a4f36d4113f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038912Reviewed-by:
-
Antonio Gomes authored
.. interface As for this old IPC to mojo migration, the CL had to: 1/ moved the dependency management of feature_policy_mojom_traits.cc out from the typemap file itself, into the respective GN target, otherwise compilation of non-component builds would fail with >> ld.lld: error: duplicate symbol: >> mojo::StructTraits< >> blink::mojom::ParsedFeaturePolicyDeclarationDataView, >> blink::ParsedFeaturePolicyDeclaration>::Read( >> blink::mojom::ParsedFeaturePolicyDeclarationDataView, >> blink::ParsedFeaturePolicyDeclaration*) Similar technique was used in [1]. [1] https://crrev.com/c/2016524 2/ Temporarily 'undef' STATIC_ASSERT_ENUM definition in feature_policy_mojom_traits.h, other otherwise it would fail to compile, since it duplicates the same define in wtf/assertions.h. BUG=1047273 R=dtapuska@chromium.org, haraken@chromium.org, kinuko@chromium.org Change-Id: I6d0ebb887056af84cddb825096df8cd706dd28d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050140 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 1375 1379 1383 1388 1392 1393 1394 1395 1396 1397 1402 1415 1416 1417 18 lines were removed and 7 lines were deflaked by consecutive results since 1370. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I2a73322784f432efbd50c419569352477d370847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049935Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#741033}
-
Sadrul Habib Chowdhury authored
Instead of carrying around a UkmManager through the various types of objects (e.g. FrameSequenceTracker, FrameSequenceMetrics), pass it on to ThroughputUkmReporter during creation. BUG=790761 Change-Id: Ic7990d0b0df43133096926ff851226c86500a89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053621 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#741032}
-
Rushan Suleymanov authored
Track entities in a separate class ProcessorEntityTracker. There is no behavioral changes. There are mostly mechanical changes to replace entities_ with ProcessorEntityTracker only. Bug: 947044 Change-Id: I655c3cb406cb9e685cd809d783c28544eeb55e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980579 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
arthursonzogni authored
Move the content of: content/common/content_security_policy/ into: services/network/public/cpp/content_security_policy See Unify CSP document: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao Previously, the classes used to represent a parsed Content-Security-Policy header were defined in both content/ and services/network/. They have been unified. All the IPCs using them have been mojoified. The CSP checker is now a set of pure function, but remained in content/common/content_security_policy/. This patch moves this directory into service/network/public/cpp/content_security_policy. Old file layout: ---------------- ├─content │ └─common │ └─content_security_policy/ │ ├─content_security_policy.cc │ ├─content_security_policy.h │ ├─content_security_policy_unittest.cc │ ├─csp_context.cc │ ├─csp_context.h │ ├─csp_context_unittest.cc │ ├─csp_source.cc │ ├─csp_source.h │ ├─csp_source_unittest.cc │ ├─csp_source_list.cc │ ├─csp_source_list.h │ └─csp_source_list_unittest.cc └─services/ └─network/ └─public/ ├─mojom/ │ └─content_security_policy.mojom └─cpp/ ├─content_security_policy.h ├─content_security_policy.cc └─content_security_policy_unittest.cc New file layout: ---------------- └─services/ └─network/ └─public/ ├─mojom/ │ └─content_security_policy.mojom └─cpp/content_security_policy/ ├─content_security_policy.cc ├─content_security_policy.h ├─content_security_policy_unittest.cc ├─csp_context.cc ├─csp_context.h ├─csp_context_unittest.cc ├─csp_source.cc ├─csp_source.h ├─csp_source_list.cc ├─csp_source_list.h ├─csp_source_list_unittest.cc └─csp_source_unittest.cc Previous CLs: - https://chromium-review.googlesource.com/c/1901041 - https://chromium-review.googlesource.com/c/1905689 - https://chromium-review.googlesource.com/c/1905987 - https://chromium-review.googlesource.com/c/1906668 - https://chromium-review.googlesource.com/c/1926141 - https://chromium-review.googlesource.com/c/1950519 - https://chromium-review.googlesource.com/c/1992322 - https://chromium-review.googlesource.com/c/1995263 - https://chromium-review.googlesource.com/c/2000025 - https://chromium-review.googlesource.com/c/2002570 - https://chromium-review.googlesource.com/c/2000640 - https://chromium-review.googlesource.com/c/2022673 - https://chromium-review.googlesource.com/c/2019448 - https://chromium-review.googlesource.com/c/2022948 - https://chromium-review.googlesource.com/c/2027339 - https://chromium-review.googlesource.com/c/2028128 - https://chromium-review.googlesource.com/c/2030963 - https://chromium-review.googlesource.com/c/2035891 - https://chromium-review.googlesource.com/c/2030958 - https://chromium-review.googlesource.com/c/2038651 - https://chromium-review.googlesource.com/c/2035971 Bug: 1021462 Change-Id: I41b15e8e8f2fe49f6d3f88c64acf2d8465d3efe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044154 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Eric Willigers authored
The HostedAppPWAOnlyTestWithAutoupgradesDisabled tests have been moved to PWAMixedContentBrowserTestWithAutoupgradesDisabled as they no longer depended on the extensions-based implementation. Note that the HostedAppTestWithAutoupgradesDisabled and HostedAppPWAOnlyTestWithAutoupgradesDisabled tests in hosted_app_browsertest.cc have not been run recently, as there was no INSTANTIATE_TEST_SUITE_P entry for these tests. Some mixed content now loads with warnings (due to security changes that occurred while the tests were not enabled). Bug: 1026080 Change-Id: I1edc65263be42bcdd7a23959bbf86081adfed9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049407 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#741029}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5499024e2831..d75b0a212447 Created with: gclient setdep -r src-internal@d75b0a212447 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I5170a276ee2d2a342847dfabb402e452b90e6fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053860Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741028}
-
Jan Wilken Dörrie authored
This change adds an abstract SavedPasswordsPresenter interface. This is supposed to be implemented by the existing PasswordManagerPresenter and allows the recently added CompromisedCredentialsProvider to obtain a complete list of saved passwords. Bug: 1047726 Change-Id: Ie9d583c1e92f7e782986a3ae39cc474b8b23a7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051277 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
