- 29 Mar, 2018 40 commits
-
-
Sonny Sasaka authored
MockObjectManager is currently not useful as the mocked methods are not virtual. BUG=chromium:812468 TEST=None Change-Id: I3fa533299cda839b4f3602de88f6e76dbac5b24c Reviewed-on: https://chromium-review.googlesource.com/982942Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#546746}
-
Yoshifumi Inoue authored
This patch moves caret bounds related functions - AbsoluteCaretBoundsOf() -AbsoluteCaretRectOfPosition() to "LocalCaretRect.cpp" from "VisubleUnits.cpp" to reduce size of "VisubleUnits.cpp" for ease of maintenance. Change-Id: Ie40d372bd78e7723feb7bf3e5ef73bcdb7d762df Reviewed-on: https://chromium-review.googlesource.com/984758Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546745}
-
Daniel Cheng authored
It's already used in a number of places in Blink. Blessing direct use of the standard UMA histogram macros will also make it simpler to make improvements to things like the macros for enumerations. Bug: 742517 Change-Id: Ic7b83312e77918170c0dbabc92c1536fed673abc Reviewed-on: https://chromium-review.googlesource.com/982946Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#546744}
-
Alan Cutter authored
This CL fixes a null pointer crash when uninstalling an extension from the app menu of a PWA window. The existing code expected the main UI toolbar to be present. Bug: 825554 Change-Id: I89353dd246168393747cca02f02444859b4457c6 Reviewed-on: https://chromium-review.googlesource.com/981839 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#546743}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4e367c2f4075..85a5ac7c6177 $ git log 4e367c2f4..85a5ac7c6 --date=short --no-merges --format='%ad %ae %s' 2018-03-28 ihf cbuildbot: mark caroline/kevin-arcnext important. 2018-03-26 jkop chromite: Increase VM Test timeout to 90 minutes. Created with: roll-dep src/third_party/chromite BUG=chromium:826755,chromium:818859 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8c9699eac4f21cb7c857f820d12011111218406d Reviewed-on: https://chromium-review.googlesource.com/985650Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#546742}
-
Bailey Berro authored
This change fixes a crash when Native Filesystem Providers call the Service::RequestMount() function via the providers_menu in the CrOS Files App. Bug: chromium:827023 Test: manually verified on eve Change-Id: I25ba6fb33fe9c9ae1a360368c0d8bb45728fc7a1 Reviewed-on: https://chromium-review.googlesource.com/972421Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#546741}
-
Yoichi Osato authored
This patch moves the target |Unknown| because there was a pushback in removal discussion: https://groups.google.com/a/chromium.org/d/topic/blink-dev/VllurNrBlL0/discussion Until we can gather collect usage counter, postpone it. Bug: 523952 Change-Id: I7844b37759b32120a2d542ce8ddb75e2c2230844 Reviewed-on: https://chromium-review.googlesource.com/983281Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#546740}
-
Xunran Ding authored
For AppCache, almost all of the 'origin' have been converted to url::Origin type. Convertion to GURL is still needed at quota api boundary. Bug: 598424 Change-Id: I6d0ae63127b497d475c01a7a3affbbc8759ad700 Reviewed-on: https://chromium-review.googlesource.com/981962 Commit-Queue: Xunran Ding <xunran.ding@samsung.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#546739}
-
Istiaque Ahmed authored
Following interesting stuff happens during OnExtensionLoad: - ContentVerifier adds ContentVerifierIOData on IO thread through PostTask. - SharedUserScriptMaster loads user scripts that might end up creating ContentVerifyJobs (VerifyContent function) from UserScriptLoader::StartLoad. There's no guarantee that VerifyContent will see the IO data added by ContentVerifier. This CL ensures that user scripts will always see IO data (if it was loaded) regardless of the timing: by hopping to UI thread (essentially by yielding to ContentVerifier::OnExtensionLoaded to PostTask IO data) and then going to IO thread to call VerifyContent. This CL also fixes and enables ContentVerifierTest.DotSlashPaths. The test used to fail because it loaded content scripts that was vulnerable to the bug. This CL also adds stricter expectations to the test through TestContentVerifyJobObserver. Bug: 826584, 825540 Change-Id: I95f3bfb934af6e82703113df973363543bfdbaea Reviewed-on: https://chromium-review.googlesource.com/982938 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546738}
-
tzik authored
This updates an inefficient usage of flat_set in base::IDMap::Clear(). It used to insert all of its keys into a flat_set, which is O(n) time for each and O(n^2) in total, and the new one inserts the keys in bulk, which is O(n log n) time. Change-Id: I8185823648682ecd7dcbc5427f1e39a43eeb3d37 Reviewed-on: https://chromium-review.googlesource.com/983275Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#546737}
-
Mohsen Izadi authored
When overscroll-behavior-x for the root element of a page is set to anything other than 'auto', gesture-nav should not start on the page. Similarly, when overscroll-behavior-y for the root element of a page is set to anything other than 'auto', pull-to-refresh should not start on the page. BUG=800074,742510 TEST=GestureNavSimpleTest.* in content_unittests Change-Id: I86cf2f50c5ceb6613dc293c1fd32ca2cfff4daa2 Reviewed-on: https://chromium-review.googlesource.com/981127Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#546736}
-
Nicholas Verne authored
CrostiniInstallerView downloads the cros-termina component, then uses CrostiniManager to start the concierge service and then a termina vm, then a container. If the above steps are successful, a new window running crosh connected to the container is opened. Bug: 813699 Change-Id: I459220b0481d46956b3f3ba5b5abdae063baa3bb Reviewed-on: https://chromium-review.googlesource.com/967961 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#546735}
-
Kristian H. Kristensen authored
This reverts commit 292706da. Reason for revert: breaks RK3399, where we don't have ARGB+AFBC support yet: https://bugs.chromium.org/p/chromium/issues/detail?id=826973 once https://chrome-internal-review.googlesource.com/c/chromeos/vendor/mali-ddk/+/597023 lands we can reland. Original change's description: > Reland "ozone/drm: Render primary framebuffers as RGBA" > > This is a reland of 48d1ecaf > > With CL:967415 and CL:964984, we've fixed the issues where RGBA > framebuffers slipped through to KMS on devices without RGBA support. > > Original change's description: > > ozone/drm: Render primary framebuffers as RGBA > > > > In preparation for hardware plane underlay support in ChromeOS, we > > need to allow for RGBA primary framebuffers. When using an underlay, > > we cut out a transparent rectangle in the primary framebuffer to allow > > the underlay to show through, while still allowing for RGBA content on > > top of the underlay (for example, video controls or annotations). > > When not using an underlay, the primary framebuffer will be displayed > > as RGBX (opaque) to avoid unnecessary blending in the display > > controller. > > > > Bug: 789288 > > Change-Id: I2fc94e524e250ec9b7e11cd6801e1c8308046a10 > > Reviewed-on: https://chromium-review.googlesource.com/801974 > > Reviewed-by: Alex Sakhartchouk <alexst@chromium.org> > > Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> > > Reviewed-by: David Reveman <reveman@chromium.org> > > Reviewed-by: danakj <danakj@chromium.org> > > Reviewed-by: Antoine Labour <piman@chromium.org> > > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > > Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#542877} > > TBR: piman > Bug: 789288 > Change-Id: Ie1032615d8970c6a74f354ad78c30679706e40ed > Reviewed-on: https://chromium-review.googlesource.com/975782 > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Alex Sakhartchouk <alexst@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: David Reveman <reveman@chromium.org> > Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545503} TBR=avi@chromium.org,marcheu@chromium.org,reveman@chromium.org,sky@chromium.org,danakj@chromium.org,alexst@chromium.org,dcastagna@chromium.org,piman@chromium.org,hoegsberg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 789288 Change-Id: I980fb2dda940cf0b9bdfbdb8b88c2c519f5e9f85 Reviewed-on: https://chromium-review.googlesource.com/985255Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#546734}
-
Matt Mueller authored
Also call EnsureNSSInit in CertVerifyProcNSS, shouldn't just assume something has already done it. Gets some NSS usage off of the IO thread. Bug: 59847 Change-Id: I08b77c5f641d1bb67de26a8c057372f4fef7037f Reviewed-on: https://chromium-review.googlesource.com/963616 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#546733}
-
https://chromium.googlesource.com/catapult.git/+log/b1c9ad5aa1d0..191fda7cc6ae $ git log b1c9ad5aa..191fda7cc --date=short --no-merges --format='%ad %ae %s' 2018-03-28 nednguyen Remove Page._collect_garbage_before_run param 2018-03-28 simonhatch Pinpoint - Add closing </p> tag to new-job-fab Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I46a644d72c955b71f08a692404ae9fc4d7f9064b Reviewed-on: https://chromium-review.googlesource.com/985634Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#546732}
-
Simeon Anfinrud authored
This provides a way to more concisely do asynchronous work using lambda syntax and also register asynchronous tasks as scopes watching Observables. For example: AsyncTaskRunner runner = new AsyncTaskRunner(); state.watch(value -> runner.doAsync( () -> { /* do work asynchronously */ }, result -> { /* handle response on UI thread */ })); The above code will run the asynchronous task whenever `state` activates, and cancel the asynchronous task automatically if `state` deactivates. No more null-checks and canceling existing tasks when a creating a new task! Refactored ExternalServiceDeviceLogcatProvider as an example. Bug: None Test: cast_shell_junit_tests Change-Id: Iaa277ff75cd398fb1e50fd1c25e2d6afdb4c5b31 Reviewed-on: https://chromium-review.googlesource.com/980671Reviewed-by:Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546731}
-
Kunihiko Sakamoto authored
Before this patch, SignedExchangeHeader fuzzer passed the entire input to the parser. But the seed corpus (htxg files) have 3-byte encoded length prefix and exchange body. After this patch, the fuzzer extracts the encoded header length, and create parser input based on it. This will increase the chance the CBOR parser gets valid input, so the fuzzer exercises more code. Bug: 803774 Change-Id: I7334017c4c3e56a95f5699d6c3750eed7e62bc81 Reviewed-on: https://chromium-review.googlesource.com/985336Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#546730}
-
Ovidio Henriquez authored
Implements the interfaces that FakeBluetoothChooser overrides. The mojom::FakeBluetoothChooser overrides are implemented by running |event_handler_| with the appropriate arguments. The BluetoothChooser overrides do nothing at the moment, since the base class is only meant to update the chooser user interface. This change also begins to partially convert a Bluetooth chooser test to test the interface and deletes the temporary tests that were created to test this API. This change reverts commit 42624492, which reverted the original change. The original change caused the new-scan-device-added.html test to fail because of a Mojo validation error resulting from not updating the third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js file needed by the test. Bug: 719827, 719826, 824704, 826787 Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527 Reviewed-on: https://chromium-review.googlesource.com/985195 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#546729}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6ceb34538985..a16b4ccd5521 $ git log 6ceb34538..a16b4ccd5 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I416a441792df5279b78b6b12f2303099fff7d4d1 Reviewed-on: https://chromium-review.googlesource.com/985123Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#546728}
-
https://chromium.googlesource.com/angle/angle.git/+log/8a02d3b57b30..a3b220f36f51 $ git log 8a02d3b57..a3b220f36 --date=short --no-merges --format='%ad %ae %s' 2018-03-06 tobine Vulkan: Adding null driver as device option Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I97ac9d33078565e83c4bb48c88fda7ce38ac1106 Reviewed-on: https://chromium-review.googlesource.com/985626Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#546727}
-
https://webrtc.googlesource.com/src.git/+log/467057ec7fe7..7abc9a07d774 $ git log 467057ec7..7abc9a07d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None,chromium:826720,chromium:826720,chromium:826655,chromium:None,chromium:b/77199993,chromium:none The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib24def67d5d129b206f2dc5b390e371701b028e3 Reviewed-on: https://chromium-review.googlesource.com/984728Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#546726}
-
Emircan Uysaler authored
GpuVideoAcceleratorFactoriesImpl calls BindToCurrentThread() on media task runner, so releasing the reference should also happen there to avoid race conditions. crrev.com/c/959432 introduced the regression, since we took care of initialization, but we didn't take care of destruction. Bug: 826539, 580386 Change-Id: I2fff505b445bca7ff38343f6f1e5d3035a06714e Reviewed-on: https://chromium-review.googlesource.com/984438Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#546725}
-
Wei Li authored
Use the same function to retrieve favicon for web contents for MacViews as on the other platforms, so the favicon can be displayed. BUG=792605 Change-Id: Ide93ddb52747f86e04d09f7741af6e881d5374d6 Reviewed-on: https://chromium-review.googlesource.com/979258 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#546724}
-
Fady Samuel authored
Most resize/synchronization related operations going from browser=> renderer happen through ViewMsg_Resize except auto-resize. In auto-resize mode three additional IPCs are used: ViewMsg_EnableAutoResize ViewMsg_DisableAutoResize ViewMsg_SetLocalSurfaceIdForAutoResize This introduces a lot of auto-resize specific complexity that should not exist. In this CL, all three auto-resize IPCs are removed and their operations are coalesced into ViewMsg_Resize. In the future, we'd like to allocate LocalSurfaceIds in both the parent and child. By de-special-casing auto-resize, this allows us to simplify the surface synchronization protocol. Change-Id: I6d0142353830e0740e67dc7b6075f5588a8e1230 Bug: 672962 Reviewed-on: https://chromium-review.googlesource.com/981394Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#546723}
-
Luciano Pacheco authored
Change the open button when it's displayed as a combobox to open the options list instead of opening the file when there are more options. Open button is only displayed as a combobox when there are more than one application for the selected file, otherwise it's displayed as a regular button. This change of behavior is to make the open button (as combobox) accessible via keyboard and screen reader (Chromevox). IMPORTANT: This is a change of behavior, but this seems more consistent since the UI displays the button as a combo, it's expected that enter key or click open the combo list, instead of triggering the "open" button which is open with default app. Users already have option to use enter key to open the file without the "open menu". Test: browser_test Bug: 793723 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8dab527805cb687103882e1b650b857fd5fb876c Reviewed-on: https://chromium-review.googlesource.com/970048Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#546722}
-
Andrey Kosyakov authored
Also added a test to detect the case when cookie CRUD protocol methods operate on different cookie storage with regards to the network layer. Bug: 721408 Change-Id: If81d4b2c1e13d69289e6dc006aabf9879fa80b11 Reviewed-on: https://chromium-review.googlesource.com/985246 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#546721}
-
Bruce Dawson authored
All unchecked code will contain errors and apparently, due to quirks of VC++ template compilation, emulated by clang-cl, the ThreadSpecific<T> destructor was never *really* compiled. It referenced two functions and one variable and only one of these three things actually existed. This was reported by Microsoft who use chromium as a compiler torture test. Bug: 825352 Change-Id: I5dd1868acda760ef33dde518d72e3d7694fad9a8 Reviewed-on: https://chromium-review.googlesource.com/978849 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#546720}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I622d8232e5511fb28f3a5976effe9e8d94347629 Reviewed-on: https://chromium-review.googlesource.com/985462Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#546719}
-
Kenneth Russell authored
Failing intermittently on Windows 10 / Quadro P400 / D3D9 / passthrough command decoder. Mark it flaky for both passthrough and non-passthrough. TBR=zmo@chromium.org, geofflang@chromium.org Bug: 825416 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ica54a091b5d447be3a3da71fd022a64f3b188b22 Reviewed-on: https://chromium-review.googlesource.com/979152 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#546718}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7a12b0f2..deec2b95 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If068d7ca90ac3559824c3cd15780bc3d68291622 Reviewed-on: https://chromium-review.googlesource.com/985457Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#546717}
-
Saman Sami authored
After resize once commit happens eventually a CompositorFrame will be submitted with the right size, so just ack the resize after commit instead of draw. Change-Id: I9ab712dc325ad77cd704123d93d94ba74eaf63d2 Reviewed-on: https://chromium-review.googlesource.com/984598Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#546716}
-
bsheedy authored
Ports all of the WebVR browser tests to have an additional WebXR version, plus adds several WebXR-only tests. As a result, removes vr_transition_utils and moves the code originally there into VR/XR test classes so that most WebVR and WebXR tests can share the same test implementation. Bug: 804043 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I62c4e1049e6999ff784c9e69ffedff50915e7b8e Reviewed-on: https://chromium-review.googlesource.com/974137Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#546715}
-
Alexandre Courbot authored
The V4L2 VDAs were still using the deprecated linked_ptr where unique_ptr ought to be used. This patch performs the conversion. BUG=792790 TEST=Checked that video_VDAPerf was still passing on hana (v4l2_vda) and kevin (v4l2_slice_vda) Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic3290d9ae5fa5fa2630cbcc5a35eda93e1cd03ca Reviewed-on: https://chromium-review.googlesource.com/983316 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#546714}
-
David Bokan authored
This method is a hodgepodge of legacy code inherited from the WebKit days. This CL cleans it up a bit, making it easier to read and: -Use one variable as the input to the next recursive call, renamed to absolute_rect_for_parent for clarity. -Remove use of IsDisallowedAutoscroll. There's no reason autoscroll should be special - we already handle the scrolling=no case for other types of scrolls. Added a test to ensure this. -Removed the special parent_box setter for selection autoscroll. Similarly to above, this doesn't need to be special and is already covered by tests: autoscroll-upwards-propagation.html TEST=fast/events/autoscroll-upwards-propagation.html, fast/events/autoscroll-iframe-no-scrolling.html Change-Id: I86cfd03c3ee9366bd01c086a63b379e7a98d46aa Reviewed-on: https://chromium-review.googlesource.com/978966 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#546713}
-
Robert Liao authored
http://crbug.com/773565 removed accelerators for textfields, breaking Cut, Copy, and Paste in the Chrome Menu. This fix forwards those calls to NSApp. BUG=788262 Change-Id: I70adfe270dd672961ca04bc0e4a9ab498e7f2944 Reviewed-on: https://chromium-review.googlesource.com/984346 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#546712}
-
Andrew Grieve authored
Shrinks ChromePublic.apk's classes.dex uncompressed by 110kb Release notes: https://www.guardsquare.com/en/blog/proguard-60-released Change-Id: I237dfb7fb35c33671766c217f838ff559d0a4baf Reviewed-on: https://chromium-review.googlesource.com/982011Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#546711}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3b299243038c..4e367c2f4075 $ git log 3b2992430..4e367c2f4 --date=short --no-merges --format='%ad %ae %s' 2018-03-27 achuith cros_vm: Fix crashes when board is not supplied. 2018-03-26 achuith cros_vm: Refactor argument parsing in cros_vm. Created with: roll-dep src/third_party/chromite BUG=chromium:782664,chromium:782664 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Icfad6a5106689e7989b59bb8801d5ba12fd69fb3 Reviewed-on: https://chromium-review.googlesource.com/985122Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#546710}
-
Joel Hockey authored
Bug: 825659 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6c4ba182597aa58f8f8d1a12d1112b4bce75e9aa Reviewed-on: https://chromium-review.googlesource.com/984753 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#546709}
-
tanvir.rizvi authored
FontSizeDelta command crashes if the element after text is a span element. This happens because ApplyStyleCommand tries to surround the text node with a style span, since the next node is a span element, code tries to wrap it in a single node as both being identical(span elements) making the other child of the first node and deleting. Hence the NodeTraversal::Next(*node) gives a NULL node. We should not DCHECK as this is possible and instead break out of the loop. Bug: 726992 Change-Id: I83537518e2080c051be10ed7a6be628d3260b1a7 Reviewed-on: https://chromium-review.googlesource.com/973103Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546708}
-
Peter Collingbourne authored
Otherwise, link against a new set of gn-built prebuilts. Bug: 749784 Change-Id: Id96666125226b3400bb92c31e5c97a7c2a64624d Reviewed-on: https://chromium-review.googlesource.com/947577 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#546707}
-