- 26 Sep, 2019 40 commits
-
-
Matthias Körber authored
This reverts commit 97111d78. Reason for revert: <INSERT REASONING HERE> Original change's description: > Removed unused methods from |ContentPasswordManagerDriver|. > > Change-Id: Ie4934e0944504674df6c0963b9004c4f4498a225 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823866 > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699743} TBR=dvadym@chromium.org,koerber@google.com Change-Id: I63b1c20ac9bf2027f7e80932c7af4d71d49bb8ef No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826477Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#700126}
-
Hiroki Nakagawa authored
This is a cleanup CL, and doesn't change existing behavior. Before this CL, these values were kept as members of WebEmbeddedWorkerImpl, and passed when a new service worker thread starts. After this CL, these are directly passed through WebEmbeddedWorkerImpl as function arguments. Keeping them as members was needed when asynchronous script fetch was done on the initiator thread. Now, script fetch is done on the worker thread, and operations on the initiator thread are synchronous. It's no longer necessary to keep them as members. Bug: n/a Change-Id: Ib401370630e5593702ca05c5dc928baf53e7049d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826304 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#700125}
-
Alexandre Courbot authored
Make use of the new polling capabilities of V4L2Device brought by V4L2DevicePoller to simplify the code. Bug: 1003223 Test: vdatests passing on Kevin. Change-Id: Ie44d7d57f5661840f94004f36ac42dae3ebe992f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799653 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#700124}
-
Dan Beam authored
Based on https://crrev.com/c/1816916 by Esmael Elmoslimany <aee@chromium.org> R=mahmadi@chromium.org Bug: 1002689 Change-Id: Ia6c95fd406c101efce44b2aed7f1b13b6f522bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824286 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#700123}
-
Alexandre Courbot authored
Each of the V4L2 decoder/encoder classes reimplement the same polling mechanism, where a dedicated thread is used to poll() an open V4L2 device and signal the decoder/encoder thread when a buffer or event is ready to be dequeued. This adds considerable amounts of code to each of these classes and complicates them. This CL replicates the polling feature into a dedicated class that is self-contained, properly documented, and easy to understand. This class is not intended to be used directly: instead, V4L2Device now has an EnablePolling() method that will invoke a callback on the client's sequence whenever an event or buffer is ready. This approach considerably simplifies the client's code, which on top of not having to reimplement the polling functionality, also doesn't need to guess when it should schedule polling: V4L2Device has all the information it needs to make this decision when queueing or dequeueing a buffer. Bug: 1003223 Test: vdatests passing on Kevin. Change-Id: I6b8619a89132c34c7424d83613c7681aedfc46ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799652 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#700122}
-
Hitoshi Yoshida authored
We used object() as a python value for empty dictionary literal "{}". But it doesn't work with (current) make_copy() well. This CL changes the value as dict() to work with make_copy() and describe its actual type better. Bug: 984949, 839389 Change-Id: I3f14319bae91ab3b7510636cca103ca25f6b6424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826067Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#700121}
-
Chih-Yu Huang authored
The GetDmabufId() method is getting an identifier of a Dma-buf VideoFrame. The method is used for all DmabufVideoFramePool implementations, not only PlatformVideoFramePool. This CL moves the method to DmabufVideoFramePool. BUG=b:136716638 TEST=media_unittests --gtest_filter=PlatformVideoFramePoolTest.* Change-Id: I6950c1cf5a5127778a3dba2bbf2475fd4779a679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824501 Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#700120}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/38b1a95c532f..1619d75c48d5 Created with: gclient setdep -r src-internal@1619d75c48d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ie8f35f721490a0c97df1de84417ffa30e011629a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826208Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700119}
-
Tsuyoshi Horo authored
This CL introduces base_url_override_for_bundled_exchanges field in CommitNavigationParams and WebNavigationParams. This field is set while loading an untrustable bundled exchanges file, and used when DocumentLoader::FinishNavigationCommit() is called. For example, while loading "file:///tmp/test.wbn" file which primary URL is "https://example.com/a.html", InterceptorForLocalFile returns a synthesized redirect response to "file:///tmp/test.wbn?https://example.com/a.html", and RenderFrameHostImpl::CommitNavigation() will set the field of CommitNavigationParams to "https://example.com/a.html". This field is passed to DocumentLoader and used call DocumentLoader::FinishNavigationCommit() as |overriding_url|. Currently this argument is used to set the base URL of the document encoded in the MHTML so relative URLs are resolved properly. This CL reuses this mechanism for bundled exchanges files. (This mechanism was introduced by ea73b35f.) Bug: 995177 Change-Id: I0198bb4a9afd8ee262e470e03c6fa6d2f2a53c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802902Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#700118}
-
Jay Harris authored
This reverts the (most obvious) new behavior added in https://crrev.com/692412 while making minimal changes (so as to ease merging). This is the result of some discussion at TPAC here: https://github.com/WICG/badging/issues/55 Changes that this will not revert: * Inheriting the badge of a parent app. Bug: 1006665 Change-Id: I845f56f166f00dd3c7cc76e323be27cb90881e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817999 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#700117}
-
Hiroki Nakagawa authored
Before this CL, WebEmbeddedWorkerImpl on the initiator thread determined whether this service worker is installed, and requested script loading and evaluation based on the decision. After this CL, the decision is made by ServiceWorkerGlobalScope on the worker thread. This enables to remove thread-hop and script evaluation code per service worker type (new or installed). Bug: 938219 Change-Id: I55c49cf18998c80075e75df53c5c9983fddcaf78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826301Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#700116}
-
Julie Jeongeun Kim authored
This CL converts HostStatusObserverPtr and HostStatusObserverRequest to new Mojo types using PendingRemote, Remote, RemoteSet, and ReceiverSet. It also update AddHostStatusObserver from multidevice_setup.mojom. Bug: 955171 Change-Id: Ifde21a3512beaf4d67f0bbd03a719ad148cd3ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824725 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#700115}
-
Matthias Körber authored
Bug: 1007974 Change-Id: Ie03062c74dcc6ca6f74b40199f6dfa02fb8a3e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824473 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#700114}
-
Ken MacKay authored
By receiving into a threadsafe IOBufferPool, we can avoid extra memory copies for things like audio streaming. Bug: internal b/127963522 Test: cast_net_unittests Change-Id: I86da6e7a5e07a7a3273d53485393468b4481ec94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822220 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#700113}
-
Julie Jeongeun Kim authored
This CL converts ConnectionDelegatePtr to new Mojo types using PendingRemote or Remote, PendingReceiver, ReceiverSet, and Receiver. It also updates ListenForConnectionFromDevice and InitiateConnectionToDevicefrom secure_channel.mojom. Bug: 955171 Change-Id: Ib0a2ea523450932bff1042fe469c5a45065c72e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820918Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#700112}
-
Yoshifumi Inoue authored
This patch gets rid of false |DCHECK_LE(start_offset, item->StartOffset())| from |ReusingTextShaper::CollectReusableShapeResults()| when inserted text starts with newline character as control character, e.g. white-space:pre, <pre>, etc. This DCHECK is wrong when adding newline chracter as control character, e.g. appending "\nX" to "n". In |ReusingTextShaper|, we have two items in |reusable_items_|. * reusable_items_[0] = kText 0-1 "n", shape_result=avaiable * reusable_items_[1] = kText 1-3 "\nX", shape_result=null Shaping items are * items[0] = kText 0-1 "n", shape_result=reused * items[1] = kControl 1-2 "\n", shape_result=n/a * items[2] = kText 2-3 "X", shape_result=new When |ReusingTextShaper| to shape for "X", |DCHECK| hits for handling |reusable_items_[1]|, because |start_offset| is 2 and |item->StartOffset()| is 1. Bug: 1003666 Change-Id: I800fae637ff7a39b0e65d07699c07b204051399e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824516 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#700111}
-
Miyoung Shin authored
This change converts KeyboardLockService mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I3e6e2e6cb1c50bd83d6f8ccea881c546150eae54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816073 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#700110}
-
Vlad Tsyrklevich authored
These new process sampling parameters are now in use to cut GWP-ASan's performance regression. Bug: 896019, 912286 Change-Id: Ic45921cf307036a3896536fead041097169cf65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816369 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#700109}
-
Hirokazu Honda authored
This specifies a surface usage hint in vaCreateSurfaces(). i965 driver doesn't change a behavior by this change. The alignment of a height of a created surface is changed to 64 to 1 with iHD driver. Thanks to this, the drivers' alignment rule is or equal to weaker than the minigbm alignment rule on encoding. Bug: 1006151 Test: VEA unittest, VDA unittest, JDA unittest Change-Id: I4b0d0bd58c7c7f39151bc91b164b1f5aaf7c63bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816479 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#700108}
-
Hiroki Nakagawa authored
This is a cleanup CL, and doesn't change existing behavior. The callers of the ServiceWorkerInstalledScriptsManager ctor don't have to spread WebServiceWorkerInstalledScriptsManagerParams. Instead, they should just pass the params struct to the ctor, and the ctor spreads it by itself. Bug: 938219 Change-Id: Ia00de8b16b28ba16cb9acfcddd19255642e3edc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824511 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#700107}
-
Yuzu Saijo authored
This CL blocklists shared worker from using BackForward Cache. Bug: 1003236 Change-Id: I31ec0109336ad71a8caf5cca01f2de667b9785b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810456 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#700106}
-
Gyuyoung Kim authored
As a step to remove all uses of WebLocalizedString::kFooBar, this CL replaces below ones with matched IDS_FOO. This CL replaces below ones, - kValidationValueMissingForCheckbox, - kValidationValueMissingForFile, - kValidationValueMissingForMultipleFile, - kValidationValueMissingForRadio, Bug: 995644 Change-Id: Ib25950a5f1127b5972bbd77a3d29e1f34497c8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824512Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#700105}
-
ssid authored
Adds process descriptor to traces. Currently only in privacy filtered mode. This will be fixed after JSON exporter handles multiple pids. Change-Id: Ie1db96d891aa3124e9704b61c546ebf5de5e48eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711085 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#700104}
-
Cathy Li authored
Also remove ExploreSites InitialCountries from fieldTrial testing config since it has been launched. Change-Id: Iac7dbe89591ebe7c091eace065b95b62c0291b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815843 Commit-Queue: Cathy Li <chili@chromium.org> Auto-Submit: Cathy Li <chili@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#700103}
-
Johannes Henkel authored
In flat mode, messages for child sessions are identified by their session ids in the top level of the message. To make this work I'm updating the devtools client implementation a bit. Bug: 991325 Change-Id: Icc1bf677ab5b797b5877f975fe0f7375107c11ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788621 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#700102}
-
Hirokazu Honda authored
This CL changes GpuArcVideoEncodeAccelerator to use GpumemoryBuffer based VideoFrame, not DMABUF based VideoFrame on VideoEncodeAccelerator::Encode(). Bug: 1001413 Test: Record video with Nexus 7 camera app on eve and kevin Change-Id: I42824f2a7bc77075ece399a31948bc49285d68db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809041Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#700101}
-
Fergal Daly authored
It's flaky. TBR=rbpotter@chromium.org Bug: 1008122 Change-Id: I56c7bbc113f0d23ddf01dd1b15e0b47bd578d358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826065Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#700100}
-
John Emau authored
The tests use dummy data simulating a performance run. Screenshot of details (aka summary) pane: https://i.imgur.com/hQXhjma.png Screenshot of bottom-up pane: https://i.imgur.com/RuUS3RM.png Screenshot of call tree pane: https://i.imgur.com/RaWp632.png Bug: 963183 Change-Id: Ie56bfe4a66bd791997d675c4013097890b61458e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733418 Commit-Queue: John Emau <johnemau@microsoft.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#700099}
-
Yun Liu authored
Bug: 1008224 Change-Id: Ia477b9a97a1b16edab554cba11ad804105354009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826032Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#700098}
-
Gyuyoung Kim authored
As a step to remove all uses of WebLocalizedString::kFooBar, this CL replaces all kAXMedia* with matched IDS_FOO. Bug: 995644 Change-Id: Icb1e2c9e73fcef443478f29f6088f28cbf20a0b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820657 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#700097}
-
Julie Jeongeun Kim authored
This CL converts ChannelBootstrapPtr and ChannelBootstrapRequest to new Mojo types. It uses PendingRemote, PendingReceiver, and FusePipes. Bug: 955171 Change-Id: Id60c4df6e780a7c40af4f88aab9af49200944294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824503Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#700096}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d64438c0787f..38b1a95c532f Created with: gclient setdep -r src-internal@38b1a95c532f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id26899f9e23803cc2e798531fdf8f4f4b870c57e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826320Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700095}
-
Hiroki Nakagawa authored
These tests are flaky: - external/wpt/service-workers/service-worker/claim-shared-worker-fetch.https.html - external/wpt/service-workers/service-worker/worker-interception-redirect.https.html Bug: 1008257 Change-Id: Iec53b29178a56a64c149e04c07a8cdf496f08ae0 Notry: true Tbr: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826303Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#700094}
-
Julie Jeongeun Kim authored
This CL converts AccountStatusChangeDelegatePtr and AccountStatusChangeDelegateRequest to new Mojo types using PendingRemote, Remote, and ReceiverSet. It also update SetAccountStatusChangeDelegate from multidevice_setup.mojom. Bug: 955171 Change-Id: I2493c44e041b53a76c6fe4e1f7870bd395cc69d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824724Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#700093}
-
Tsuyoshi Horo authored
To support loading bundled exchanges local files, this CL do the following changes: (1) Change ContentURLLoader::Start() and FileURLLoader::Start() to set mime_type to "application/webbundle" when BundledHTTPExchanges feature is enabled, and the extension of the file ".wbn". (2) Change NavigationRequest::OnStartChecksComplete() not to create a BundledExchangesHandle when the URL scheme is not "file:" (or "content:" on Android). This is because currently we don't support loading bundled exchanges from network. (3) Introduce |will_return_unsafe_redirect| parameter in NavigationLoaderInterceptor::MaybeCreateLoaderForResponse() which is set to true when the interceptor will return an unsafe redirect response. We need this to skip IsRedirectSafe() check in URLLoaderRequestController::OwnReceiveRedirect() while redirecting the original request to the URL which can indicate the URL in bundled exchanges file. (eg: From "content://org.example.FileProvider/wbn/test.wbn" to "content://org.example.FileProvider/wbn/test.wbn?https://example.com/") (4) Change::URLLoaderRequestController::MaybeCreateLoaderForResponse() not to early return when |default_loader_used_| is false if the response is likely to be a bundled exchanges file. This is because while loading file, |default_loader_used_| is false. But we need to call InterceptorForFile::MaybeCreateLoaderForResponse(). (5) Change BundledExchangesHandle to be able to handle bundled exchanges local files. InterceptorForFile will handle the navigation request to the bundled exchanges file. This interceptor returns a synthesized redirect to the URL which can indicate the URL in bundled exchanges file (eg: "file:///tmp/test.wbn?https://example.com/") in OnMetadataReady() and handles the redirected request in StartResponse(). InterceptorForTrustableFile will handle the navigation request to the trustable bundled exchanges file. This interceptor returns a synthesized redirect to the bundled's primary URL (eg: "https://example.com/") and handles the redirected request in CreateURLLoader(). Bug: 995177 Change-Id: I049336322bc503026699df2fe8ffd26a86309dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792220 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#700092}
-
Julie Jeongeun Kim authored
This CL converts SimpleTestDriverPtr and SimpleTestDriverRequest to new Mojo types using AssociatedRemote, AssociatedReceiver, and PendingAssociatedReceiver. It introduces AddAssociatedInterface and BindPendingAssociatedReceiver in ipc_channel.h. Bug: 955171 Change-Id: I2b75876cb27698364aff618b0c3be13dc92847e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824505Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#700091}
-
hyunjune authored
This patch fixes up a crash relied on line break with 'white-space'. Because After HandleOverflow is called, the current style is changed into |HandleOverflow|. So When |TextBreak|'s result is Overflow, this patch restores the current style as the old current style. Bug: 999863 Change-Id: I787d80abac66599671fd6cb19cb19eebb2110852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806616Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#700090}
-
Hirokazu Honda authored
This CL introduces a class that enables to pixel format conversion and scaling with VA-API. The interface of the class is ImageProcessor. Bug: 898423 Test: image_processor_tests on atlas Change-Id: I275b4dec50594ca6328743bb5a3532e0a8d25ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1367389Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#700089}
-
Alexey Baskakov authored
Support creation and deletion of apps as a part of single update. RegisterApp, UnregisterApp and UnregisterAll methods now can be expressed within one WebAppRegistryUpdate (one transaction). Report kWriteDataFailed in InstallFinalizer if commit fails. WebAppRegistryUpdate CreateApp/UpdateApp/DeleteApp is now the only writable database API (as in Database CRUD: Create/Update/Delete). Bug: 860583 Change-Id: Ia2e23a4d4a0d47e62b815abd55803616a204e813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824043Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#700088}
-
Istiaque Ahmed authored
IPCs to WorkerThreadDispatcher arrive initially on main thread via WorkerThreadDispatcher::OnControlMessageReceived() [1]. This IPC is forwarded to worker thread, via WorkerThreadDispatcher::OnMessageReceivedOnWorkerThread() [2]. If the worker destruction (Dispatcher::WillDestroyServiceWorkerContextOnWorkerThread) happens on worker thread between [1] and [2], IPC forwarding succeeds (b/c the worker is alive at [1]), but IPC handling doesn't (as worker data is already cleared while we run [2]). Fix this by checking worker data's existence while handling the IPC on worker thread and bailing out. Bug: 1008143 Test: Locally running ServiceWorkerTest.Update*Extension thousand times. Change-Id: Id5dd1b4c3d24995228aeb0f1fdd72edc1b77f747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825169Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#700087}
-