- 20 Nov, 2019 40 commits
-
-
David Jean authored
All three tests are flaky and have been tagged as so in eg2. TBR=stkhapugin@chromium.org Bug: 1026579 Change-Id: I08b9baed297b695b733ea020aaeed036b425a47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925064Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#716978}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7740980a8de4..cc2228033fb3 git log 7740980a8de4..cc2228033fb3 --date=short --no-merges --format='%ad %ae %s' 2019-11-19 tsepez@chromium.org Remove CPDFSDK_FormFillEnvironment::{Extract,Insert,Replace}Pages(). 2019-11-19 tsepez@chromium.org Add test for current malloc(0) behavior. 2019-11-19 thestig@chromium.org Correctly handle javascript_tests test cases with no test expectations. 2019-11-19 thestig@chromium.org Reduce includes in fx_memory.h. 2019-11-19 thestig@chromium.org Format testing/tools with git cl format --python. 2019-11-19 tsepez@chromium.org Remove CRYPT_aes_context::encrypt and decrypt members. 2019-11-19 tsepez@chromium.org Remove inline functions from fx_memory.h header. Created with: gclient setdep -r src/third_party/pdfium@cc2228033fb3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Iede1bee9ea7d58a83e244648b61479094f4cfc0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925612Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716977}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9e7d80fb55a7..9eccd137bea3 git log 9e7d80fb55a7..9eccd137bea3 --date=short --no-merges --format='%ad %ae %s' 2019-11-19 primiano@google.com Merge "Bazel: allow embedder to depend on intermediate proto targets" 2019-11-19 treehugger-gerrit@google.com Merge "TrackEvent: Rename track event context for readability" Created with: gclient setdep -r src/third_party/perfetto@9eccd137bea3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I2c0bb67ab5b5c5e509505e20b677b03d7877ebef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925807Reviewed-by:
-
sandromaggi authored
This test checks that a newly added credit card shows up in the list, testing the interaction between the PDM and the AA user data mask. Bug: b/143265578 Change-Id: Ib76ebdeaa6f3887b253f1162f2495b01d50cc270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924525 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#716975}
-
Fredrik Söderquist authored
This moves sandwiches for a target element from the SMILTimeContainer to an object (ElementSMILAnimations) stored on the target element. Additions and removals from this new object is managed by the subclasses of SVGAnimationElement. This means that SMILTimeContainer now only manages timed elements. Checking the validity of the target is thus separated from checking the validity of the animation. The former is (still) performed by HasValidTarget() while the latter is performed by a new HasValidAnimation() method on SVGAnimationElements. Handling of discarding effects are changed such that a "queue" of pending discard operations is kept, and <discard> elements queue themselves when their (first) interval starts, the actual discarding is then performed as part of the regular animation update step by the time container. Bug: 1017723 Change-Id: If19c30cb02e0c785ce777e0a88695e18f9e8746d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899868 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#716974}
-
Ramin Halavati authored
Just clean up. Bug: 1023759 Change-Id: I6e13a4fb072e1e4645c8d1626b90f5030921ce02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925065 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#716973}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4c9781e07607..55394ddc906c git log 4c9781e07607..55394ddc906c --date=short --no-merges --format='%ad %ae %s' 2019-11-20 crouleau@chromium.org [Pinpoint] Support WebLayer Telemetry benchmark runs. Created with: gclient setdep -r src/third_party/catapult@55394ddc906c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:1022823 Change-Id: I0c478422fcf1839d34d4b9ea293da3a21084edbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925655Reviewed-by:
-
Pavel Shmakov authored
Change-Id: I570b348817bab8ec780df0d1216f09dc1e1f6bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924249 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#716971}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /net/disk_cache This CL was uploaded by git cl split. R=jkarlin@chromium.org Bug: 1018667 Change-Id: Ia7c8995f1e86f4d87140a8c139b8f01aeedc85a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917366 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#716970}
-
Ramin Halavati authored
Incognito CCT intent handling is added. This is currently done using the only available off the record profile in Chrome. Therefore the profile is shared between browser and CCTs, and will leak data from one to other. Incognito CCT is now behind disabled kIncognitoCCT flag and will be enabled when implementation is completed create an isolated profile for each CCT. This CL is created based on crrev.com/c/1798663 that removed this functionality before. Bug: 1023759 Change-Id: Ib9830c3c6ee16e8a22163e87507295410a4575ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911796 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#716969}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/240befe55bb3..8d94b5e9339a git log 240befe55bb3..8d94b5e9339a --date=short --no-merges --format='%ad %ae %s' 2019-11-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src c2bd11586919..720c5deb0244 (11 commits) 2019-11-20 tobine@google.com Vulkan:Disable AtomicCounterBuffer tests on Vulkan 2019-11-19 flibitijibibo@gmail.com Headers: Add EGLAPI to SwapBuffersWithFrameTokenANGLE 2019-11-19 courtneygo@google.com Vulkan: Ensure consistent limits for texture & framebuffer 2019-11-19 mihu@microsoft.com EXT_multisampled_render_to_texture clean up and prep for 2DMultisampleArray. 2019-11-19 syoussefi@chromium.org Skip crashing KHR tests on Nvidia 2019-11-19 shrekshao@google.com Skip TextureNorm16Test on Nexus6P Created with: gclient setdep -r src/third_party/angle@8d94b5e9339a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=courtneygo@google.com Bug: chromium:None,chromium:1024387 Change-Id: Ib8046ab83905a0b895b25c98a6ab0f0bff174c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925878Reviewed-by:
-
Hiroki Sato authored
AccessibilityEvent of WINDOW_STATE_CHANGED is as a trigger of window transition in ARC. When the event is fired, accessibility focus should be moved to the first (top-left) node in the new window. This CL also adds **withoutRecovery methods in cursors/range/focus in ChromeVox. As some part of ARC++ a11y tree contents can be set ignored when a window content changes, range equality is required not to apply focus recovery strategy. The accessibility focus moves to the newly opened menu. Bug: b:130184534 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: Open PlayStore or Hangouts app and click 'open drawer' button. Change-Id: I19f026e162aee301cf759bc9f441ac1e6f0fe9e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888628Reviewed-by:David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#716967}
-
Alex Ilin authored
ppapi no longer uses the deprecated shared memory API. This CL removes all remaining references to base/memory/shared_memory.h and base/memory/shared_memory_handle.h Bug: 795291 Change-Id: I4db95d35b7276f2d4b7d5ebb39f6eda4845ab3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919158 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#716966}
-
Alex Danilo authored
The feedback panels can appear asynchronously during long running file operations. Add the aria role 'alert' to trigger screen readers to alert the user when panels appear. Bug: 1026501 Tests: browser_test --gtest_filter="*FilesDisplayPanel" Change-Id: I7b6efd544b78ee23744950eb39e0c787125b14b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925838 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#716965}
-
Alex Ilin authored
The UMA.ProfileSigninStatus metric reported incorrect results on ChromeOS due to missing "else" statement. Bug: 1022106 Change-Id: I2f0059a5cd032e54c1a71599ff49449d303e5cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924474 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#716964}
-
Jiawei Shao authored
This patch implements sending the adapter properties from GPU process to the renderer process in the call of adapter.RequestAdapter(). At the client side of WebGPU command buffer, before sending the request of RequestAdapter() to the server side, a callback is saved in a map whose key is the serial number of the request. After selecting the preferred adapter, the GPU process will send the id and properties of the adapter to the rendering process, the related callback will be called to create the GPUAdapter object in Blink with the information about this adapter from the GPU process. BUG=chromium:996713 Change-Id: I81e252559a7d256213f4bf93405d63cd0e6fa02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897475Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#716963}
-
Noel Gordon authored
The directory tree does not support horizontal scrolling (by design), but expanding sub-directories using the keyboard can reveal directory entries that are wider than the directory tree element and cause the tree element to gain a scrollLeft > 0 (the tree is scrolled left, in the horizontal). One fix is CSS overflow-x: clip, but chromium does not support it yet. Another way is to observe 'scroll' events and clamp the tree's scrollLeft to 0 if needed. And because browser 'scroll' event are very frequent, and we only need keep-up with the keyboard input rate, perform the clamp in a RAF to throttle the 'scroll' event processing rate. Bug: 1025581 Change-Id: I7c4b0a06fee9cf6356d914314b561feb0da8f7a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924341Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
TestWebUIController is used by tests to create WebUIControllers with specific CSPs and headers. Extract it into web_ui_browsertest_util.h so that it can be shared by all WebUI tests. Also rewrites tests to use the common TestWebUIController. Bug: 1012150 Change-Id: I009c26534a7da37698c9a17ae22f2756ba3a4717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921017 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#716961}
-
Raphael Kubo da Costa authored
A rough approximation of https://heycam.github.io/webidl/#es-union when trying to convert an ES value to an IDL sequence or frozen array is: 1. Call the GetMethod abstract ES operation to retrieve the @@iterator property. 2. If it is not undefined, invoke https://heycam.github.io/webidl/#create-sequence-from-iterable with the ES value and the method obtained above. So far, we were implementing it roughly like this: 1. Call the GetMethod abstract ES operation to retrieve the @@iterator property. 2. Invoke https://heycam.github.io/webidl/#es-sequence with the ES value, which disregards the method obtained in step 1 and goes through the whole process of calling GetMethod again and using that to create a sequence from an interable. This is obviously not compliant with the spec, and the multiple calls to the GetMethod abstract operation are user-visible, as can be seen in the test case attached to the bug 1024388. Properly fixing this requires changes to a few different classes and functions: * Make HasCallableIteratorSymbol(), which is called by the overload resolution algorithm implementation, be a small wrapper around GetEsIteratorMethod(). While HasCallableIteratorSymbol() precedes GetEsIteratorMethod(), the latter's implementation is more spec-compliant. * Add a move constructor to ScriptIterator, as well as a static method that can create a ScriptIterator out of an ES value by invoking GetEsIteratorMethod() and GetEsIteratorWithMethod() underneath. * Make NativeValueTraits<IDLSequence<T>>::ConvertSequenceSlow() take a ScriptIterator rather than a v8::Local<v8::Object>, which allows us to delegate getting an iterator out of an iterable object to the static ScriptIterator method mentioned above. This also helps reduce the size of the generated per-type NativeValueTraits<IDLSequence<T>> template code. * Analogously, invoke ScriptIterator::FromIterable() in the union conversion code, and invoke a new NativeValueTraits<IDLSequence<T>>::NativeValue() overload that takes a ScriptIterator, so that we do not access the @@iterator property multiple times in the union conversion code. Bug: 1024388 Change-Id: I47e6c0ca881e6e77f883ee78b5e1611138cdcc4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917169 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#716960}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6ee4df80..0f7802b0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I54690cbaf9a54ca17b86c3a8eacd7daf1bd35f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924729Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716959}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/17a3e344ef2a..9ec3f6e9cc73 git log 17a3e344ef2a..9ec3f6e9cc73 --date=short --no-merges --format='%ad %ae %s' 2019-11-20 changhaohan@chromium.org Updates Network Panel's Text in Network Log View. 2019-11-20 tvanderlippe@chromium.org Allow changes in the .gitignore for new third_party inclusions 2019-11-20 cjamcl@chromium.org Audits: Linkify source locations in report. 2019-11-19 vidorteg@microsoft.com Adding run_localization_check.py Created with: gclient setdep -r src/third_party/devtools-frontend/src@9ec3f6e9cc73 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:961389,chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I593c2e7fbca8d70dd84cb89a9560900a0d0b4f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925659Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for ProxyResolverRequestClient and ProxyResolverFactoryRequestClient replacing Binding with Receiver. Bug: 955171 Change-Id: Ibd42e2299f5fc02d14261e4e9306d64e483ee106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923776 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#716957}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5db923d9d322..e1fce40060ca Created with: gclient setdep -r src-internal@e1fce40060ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1012578,chromium:b/144121590,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:1022823,chromium:None,chromium:1026161,chromium:None,chromium:None,chromium:None Change-Id: I17ff29e84ea421f88761d4dd15204f633a481e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925175Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716956}
-
Alexander Timin authored
The number of cases where we can't cache the page due to related active contents turned out to be higher than expected. Record metrics to understand why this is happening. R=alexmos@chromium.org,arthursonzogni@chromium.org BUG=1026101 Change-Id: If4c291f0b6108edef4162b0abecbdb9f978c5805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923289 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#716955}
-
Clemens Arbesser authored
This CL changes the way autofill assistant a11y-announces chips. Previously, it would simply announce the text, followed by a generic 'double-tap to activate', e.g., 'Close. Double-tap to activate'. Now, chips are correctly announced as buttons, e.g., 'Close button. Double-tap to activate'. See linked bug for videos of before/after. Bug: b/144823053 Change-Id: Id9577f522317025cd4e552d4489a088946236164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924526Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#716954}
-
Bret Sepulveda authored
This patch adds a test that pins an extension and verifies it appears in the toolbar. In order to call IsActionVisibleOnToolbar, the visibility of ExtensionsContainer overrides on ExtensionsToolbarContainer are moved to public to match the superclass. This patch also changes ExtensionsMenuViewUnitTest from a BrowserWithTestWindowTest to a TestWithBrowserView. The pin button requires the bubble to have a Widget before it can be clicked on, and the most straightforward way to accomplish this is to have a BrowserView to wire everything up correctly. Bug: 984654 Change-Id: I5f81fd66567d09634a8c54a1cba26d9c963ec6d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917238 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#716953}
-
Olya Kalitova authored
Skips populating policy map with nullptrs if DecodeIntegerValue returns nullptr. Bug: 1015281 Change-Id: I13580caea4eb42893abca74abfdd9edb0e93ca35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924430Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#716952}
-
Dale Curtis authored
It's a tiny class which does nothing if no listeners are attached and having it for Windows fake audio device changes will be helpful. BUG=1020006 R=guidou Change-Id: I690c05edb55fcbdcef72ede68e759686243586e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925291Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#716951}
-
Caleb Raitto authored
I encountered trybot failures in https://crrev.com/c/1907147 -- I was able to fix them by including both atomic_string_hash.h and string_hash.h, but atomic_string_hash.h should IWYU. Change-Id: I2501300bdb85bd765b8af6e9605dea460c26adc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924981 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#716950}
-
Max Li authored
Previously we were reading the public key instead of the instance ID as a temporary stopgap since RemoteDevices did not have the instance ID available. Now we correctly read from the instance ID in EligibleHostDevicesProviderImpl. Bug: 923594 Change-Id: Icf9de35ce98e3bb5194e5d54e7b41e4d039acbb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923333Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Max Li <themaxli@chromium.org> Cr-Commit-Position: refs/heads/master@{#716949}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/d709b0d8926707f3143d8cf7c84350e49e56ec38..6ba98ff60144f60aba589b4d6121689528fbae76 Bug: none Change-Id: I50ad62fdc3dfe54fba398abfcba52ea52a6ac607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918314 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#716948}
-
Anastasiia Nikolaienko authored
Show Active Directory account in the "Accounts" list in Settings. Bug: 996206 Change-Id: I23fa5c51977c81466b3bff5f38e0772240acbd05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763691 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#716947}
-
Joel Hockey authored
GetTerminalId returns old terminal, or Terminal System App if feature is on. Launches System App when LaunchCrostiniApp is called with Terminal System App ID. Bug: 1019021 Change-Id: I2420e2f3ca5bcc423ee5ea991f4301b86d1b965d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925831Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#716946}
-
chrome://resources/js/assert.jsKuo Jen Wei authored
Currently, chrome resources domain is not accessible from packed crx CCA signed with dev key. This CL is a workaround by copying those used function to chrome_util.js. Bug: b/144748372 Test: Both CCA and CCA installed from packed crx function normally. Change-Id: I6329eaee53a1ba71fb3c9ea09c570b1437b2ebc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925841 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#716945}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/57b4cb40b21d..2ee9aaa288d9 git log 57b4cb40b21d..2ee9aaa288d9 --date=short --no-merges --format='%ad %ae %s' 2019-11-19 rharrison@google.com Initialize binary for use as guard later (#3058) 2019-11-19 stevenperron@google.com Handle OpPhi with no in operands in value numbering (#3056) 2019-11-19 stevenperron@google.com Kill the id-to-func map after wrap-opkill (#3055) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@2ee9aaa288d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,courtneygo@google.com Bug: None Change-Id: I9ae03531f594900093fb82d7438aae5a7bb3b3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925877Reviewed-by:
-
Per Åhgren authored
This CL activates audio multichannel processing when there is multi channel playout with content that is not upmixed mono. A killswitch (WebRTC-ApmExperimentalMultiChannelRenderKillSwitch) is available in the WebRTC audio processing code that can be used to deactivate the effect of this CL. As part of this CL, the flag kWebrtcMultiChannelApmDescription is redefined to control the activation of capture multichannel processing. Bug: b/141975053 Change-Id: I99d3cbba6ecc799985959978d10a6cff839f2f10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921976 Commit-Queue: Per Åhgren <peah@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#716943}
-
Renato Silva authored
This commit improves the reliability of the EULA browser test EulaTest.LoadOnline. This test was disabled due to its flakiness in the past and is now enabled again. Tested locally. Ran 100 tests under stress without failures. The test was failing randomly before. Bug: 865710 Change-Id: If5fd67cbc784d577af2fa5e90906db09dec24754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891314Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#716942}
-
Peter Kasting authored
This fixes a regression from http://crrev.com/716332 , which changed the enabled button foreground color from grey to blue. That was correct for pushbutton text, but incorrect for checkbox/radio icons (and, incidentally, download shelf button ink drops), which were using the same color ID. To fix this, introduce a distinct "unchecked button" color ID with the old (correct) color and change to using it. Bug: 1026176 Change-Id: I7c2b97431fd52fe85b4d560fe1737e8ff347888f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925340 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#716941}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7e11f46ddf8e..2377845dd216 git log 7e11f46ddf8e..2377845dd216 --date=short --no-merges --format='%ad %ae %s' 2019-11-20 bclayton@google.com Reactor: Move print apis out of core reactor header. 2019-11-20 bclayton@google.com Reactor: Remove the CallSupported capability. 2019-11-20 bclayton@google.com Reactor: Add ConstantData() and member function calling 2019-11-20 bclayton@google.com Reactor/Traits: Swap the naming of CToReactorPtr and CToReactorPtrT. 2019-11-20 bclayton@google.com Reactor/Traits: Fix brokenness with CToReactor::cast of pointers. Created with: gclient setdep -r src/third_party/swiftshader@2377845dd216 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/142132927,chromium:b/143479561,chromium:b/143479561,chromium:b/143479561 Change-Id: Ia1ccdbc8b7301752b1bc937acec787d4d8da60ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925879Reviewed-by:
-
Daniel Cheng authored
Disk cache is, by definition, persisted, so use base::PersistentHash(), which currently has the exact same behavior as base::Hash(), but is actually guaranteed not to change. Bug: 1025358 Change-Id: I43c53197d97c7781ef0fcfbacb89cdb214abc24e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924603Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#716939}
-
