GitLab

Section 5.1.5 of the specs clearly states that the resolved value
for grid-template-{columns|rows} must include every listed track, whether
explicitly or implicitly created. We were only listing the explicit grid
tracks.

Review URL: https://codereview.chromium.org/548263002

git-svn-id: svn://svn.chromium.org/blink/trunk@181579 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181567

BUG=405422
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/555503003

git-svn-id: svn://svn.chromium.org/blink/trunk@181576 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RenderSVGResourceClipper needs a couple bits of state to determine
whether mask or path clipping was used. (The clipper doesn't maintain
this state because it can be applied to multiple renderers.) This patch
converts the ClipperContext class into a simple enum which is now
scoped to RenderSVGResourceClipper.

No new tests as there is no change in behavior.

Review URL: https://codereview.chromium.org/547723003

git-svn-id: svn://svn.chromium.org/blink/trunk@181575 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In some situations, the channel count mode is updated just before the
audio rendering starts. During audio processing, the channel count
mode is used to set the number of channels for processing.  However,
for AudioBasicProcessor's, the number of kernels has not yet been
updated to the correct number of channels, so the incorrect number of
channels is accessed.

We delay the setting of the channel count mode until the pre or post
rendering phase of the audio thread where it is safe to change things
since the audio graph is not being pulled.

BUG=407489

Review URL: https://codereview.chromium.org/543073004

git-svn-id: svn://svn.chromium.org/blink/trunk@181573 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Extract common part of invalidateTreeIfNeeded() of
RenderLayerModelObject and RenderSVGModelObject.

This is preparation of letting setShouldDoFullPaintInvalidation() work
for RenderText (to avoid invalidatePaintForWholeRenderer from
DocumentMarkerController).

No functional change.

BUG=394133

Review URL: https://codereview.chromium.org/535633002

git-svn-id: svn://svn.chromium.org/blink/trunk@181571 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also, add isResourceLoadInProgress() for use in content shell, to determine
when to complete tests.

Exposing this information will allow content shell to better
evaluate when to end tests, hopefully eventually leading
blink being able to define load completion strictly as
the completion of the load event.

BUG=

Review URL: https://codereview.chromium.org/514603004

git-svn-id: svn://svn.chromium.org/blink/trunk@181570 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This interface temporarily subclasses WebFrameClient to ease the transition, and will be implemented by content::RenderFrameProxy. Add postMessageEvent(), to be properly plumbed in a followup patch.

This is step 1 of 3 on crubg.com/411066

BUG=411066

Review URL: https://codereview.chromium.org/539413002

git-svn-id: svn://svn.chromium.org/blink/trunk@181569 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=yurys@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/547413003

git-svn-id: svn://svn.chromium.org/blink/trunk@181568 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously we use IntRect to store focus ring rects during
addFocusRingRects(). This causes 1-pixel offset or size error when
the result is offsetted again (e.g. when the focused element contains
layers).

Use LayoutRect to avoid errors. Also avoid pixel-snapping when passing
additionalOffset.

BUG=405422
TEST=fast/sub-pixel/focus-ring-around-sub-pixel-layer.html

Review URL: https://codereview.chromium.org/492053002

git-svn-id: svn://svn.chromium.org/blink/trunk@181567 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Remove unnecessary RenderInline::setContinuation(). Push outline style
  in RenderInline::addChildIgnoringContinuation() along with original
  style propagation for 'position'.
- In updateStyleOfAnonymousBlockContinuations() create newBlockStyle
  only once. Fixed original issue when pushing 'position' by replacing
  createAnonymousStyleWithDisplay() with RenderStyle::clone().
  The issue caused just-set outline style to be lost because
  createAnonymousStyleWithDisplay() doesn't copy non-inherited styles.

BUG=405222
TEST=refactory only, no functional change

Review URL: https://codereview.chromium.org/538213002

git-svn-id: svn://svn.chromium.org/blink/trunk@181566 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Fix to keep the selection of the text field in input element after setSelectionRange is called by d… (patchset #7 id:160001 of https://codereview.chromium.org/507533002/)

Reason for revert:
Suspected cause of flaky failures of org.chromium.content.browser.input.ImeTest on Android bots - see http://crbug.com/411756

Original issue's description:
> Fix to keep the selection of the text field in input element after setSelectionRange is called by dom events related to mouse
> 
> The problem is that the selection is cleared when handling mouse release.
> The selection should be kept if the selection is set by setSelectionRange during handling mouse event.
> 
> BUG=32865
> R=yosin@chromium.org
> R=rbyers@chromium.org
> TEST=LayoutTests/fast/forms/setrangetext-within-events.html
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181490

TBR=yosin@chromium.org,yoichio@chromium.org,rbyers@chromium.org,kenjibaheux@chromium.org,myid.o.shin@gmail.com
NOTREECHECKS=true
NOTRY=true
BUG=32865

Review URL: https://codereview.chromium.org/548413002

git-svn-id: svn://svn.chromium.org/blink/trunk@181565 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Refactor AnimationPlayer::cancel() to enter idle state rather than nullifying m_source.

Original patch[1] by shans@chromium.org

[1] https://codereview.chromium.org/534193002
BUG=396366
TBR=shans@chromium.org

Review URL: https://codereview.chromium.org/548223002

git-svn-id: svn://svn.chromium.org/blink/trunk@181564 bbb929c8-8fbe-4397-9dbb-9b2b20218538

An unnecessary modification that was made in Blink r178392 was causing
a regression in the rendering of the inspector timeline.  Pulling it out

BUG=408080
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/540423002

git-svn-id: svn://svn.chromium.org/blink/trunk@181563 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DevTools code needs access to platform thread id in order to collect Worker thread ids and based on them differentiate worker threads in recorded trace events.

BUG=401895

Review URL: https://codereview.chromium.org/514193002

git-svn-id: svn://svn.chromium.org/blink/trunk@181562 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=160207
R=vsevik, yurys@chromium.org

Review URL: https://codereview.chromium.org/547603003

git-svn-id: svn://svn.chromium.org/blink/trunk@181561 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously, scientific notation (scinot) was only supported for SVG
presentation attributes through a special tokenizer quirk. Since scinot
has now been added to the CSS syntax spec [1][2][3] and is already
supported by Gecko [4] and IE(11).
To harmonize, the call to parseSVGNumber(...) is replaced with a call to
charactersToDouble(...). This results in a small behavioral change, since
the former would reject numbers that were too large. These will now parse
as "Infinity" [5].
Since this removes the last caller of isSVGNumberParsingEnabledForMode()
that function is removed as well.

[1] http://dev.w3.org/csswg/css-syntax/#number-token-diagram
[2] http://lists.w3.org/Archives/Public/www-style/2012Aug/0900.html
[3] http://lists.w3.org/Archives/Public/www-style/2013Apr/0428.html
[4] https://bugzilla.mozilla.org/show_bug.cgi?id=964529
[5] Tested browsers were not entirely consistent in their treatment of
    infinities (Gecko: Infinity, IE: FLT_MAX).

BUG=388161
BUG=344645

Review URL: https://codereview.chromium.org/545173003

git-svn-id: svn://svn.chromium.org/blink/trunk@181560 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Removes unnecessary code around ElementWrapperFactory.

BUG=235436

Review URL: https://codereview.chromium.org/552733002

git-svn-id: svn://svn.chromium.org/blink/trunk@181558 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before we know whether or not we can implement [1], let's find out how
hard it will hit the portions of the web for which we can gather UMA
data.

BUG=378566

Review URL: https://codereview.chromium.org/545923002

git-svn-id: svn://svn.chromium.org/blink/trunk@181557 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With the CL, https://codereview.chromium.org/456413002, we are migrating from embedding inline resources
inside blink towards using chromium's grd resource system. As part of this effort, most of the tests
would require to use the 'pak' files packaged as android application assets.

These assets need to be extracted to the application data directory during the startup of the test
application. The native libraries would be able to work with these 'pak' files only after the extraction
from the asset manager. Adding the required 'content_shell.pak' to the target webkit_unit_tests_apk.

BUG=312586

Review URL: https://codereview.chromium.org/549863002

git-svn-id: svn://svn.chromium.org/blink/trunk@181556 bbb929c8-8fbe-4397-9dbb-9b2b20218538

(rrev.com/528013002).

Fixes for review comments not handled in the original CL.

BUG=399580
R=haraken@chromium.org

Review URL: https://codereview.chromium.org/549533002

git-svn-id: svn://svn.chromium.org/blink/trunk@181554 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of [oilpan]: optimize the way we allocate persistent handles in wrappers. (patchset #6 id:100001 of https://codereview.chromium.org/525353002/)

Reason for revert:
Reverting due to browser test failures.

Original issue's description:
> [oilpan]: optimize the way we allocate persistent handles in wrappers.
> 
> The oilpan JS wrappers all have a persistent which is used to keep the wrapped object around while there is a javascript reference to it. Allocation of these wrapper persistents showed up in some of benchmarks. This change creates a new optimized WrapperPersistent which is allocated in blocks. This gives a speedup ranging between a few percent to 20% in some of the more wrapper intensive tests.
> 
> R=ager@chromium.org, haraken@chromium.org, oilpan-reviews@chromium.org, zerny@chromium.org
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181298

TBR=ager@chromium.org,haraken@chromium.org,oilpan-reviews@chromium.org,zerny@chromium.org,erik.corry@gmail.com,fdegans@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=411240

Review URL: https://codereview.chromium.org/553483004

git-svn-id: svn://svn.chromium.org/blink/trunk@181553 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch adds long click behavior to the "add new rule" button, which
opens a list of user stylesheets where you can add a new rule.

BUG=402461

Review URL: https://codereview.chromium.org/529553002

git-svn-id: svn://svn.chromium.org/blink/trunk@181552 bbb929c8-8fbe-4397-9dbb-9b2b20218538

30% performance improvement on DOM/textarea-edit on the oilpan build.
2% performance improvement on DOM/textarea-edit on the non-oilpan build.

R=yosin@chromium.org
BUG=388681

Review URL: https://codereview.chromium.org/544083002

git-svn-id: svn://svn.chromium.org/blink/trunk@181551 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Test do not run, because "return" is not allowed at top level
(syntax error).

BUG=

Review URL: https://codereview.chromium.org/540613004

git-svn-id: svn://svn.chromium.org/blink/trunk@181550 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We need to check this in DocumentThreadableLoader not to send CORS preflight requests to the ServiceWorker.

Chromium side is implemented in https://codereview.chromium.org/553603002/.


BUG=411151

Review URL: https://codereview.chromium.org/546263002

git-svn-id: svn://svn.chromium.org/blink/trunk@181549 bbb929c8-8fbe-4397-9dbb-9b2b20218538

generate_constructor_wrapper macro in bindings/templates/methods.cpp
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/bindings/templates/methods.cpp&q=%22macro%20generate_constructor_wrapper%22%20file:methods.cpp&sq=package:chromium&l=611
would like to reuse the existing wrapper object, and in that case,
it needs to associate the impl with the existing wrapper.
(Note that wrap method creates a new wrapper.)

This CL introduces ScriptWrappable::associateWithWrapper to allow it.
This method does not need to be virtual because it must be called from
only a) wrap method, or b) V8T::constructorCallback, where we already
know the right WrapperTypeInfo.

BUG=235436

Review URL: https://codereview.chromium.org/542113003

git-svn-id: svn://svn.chromium.org/blink/trunk@181548 bbb929c8-8fbe-4397-9dbb-9b2b20218538

AXRenderObject assumes that both of the ancestor element and the active
descendant element have their renderers.

BUG=123896

Review URL: https://codereview.chromium.org/550853002

git-svn-id: svn://svn.chromium.org/blink/trunk@181547 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As per css3-color[1], currentColor is not resolved at computed value
time. This means that we shouldn't fire a transition when a property is
set to currentColor, even if the used value changes. Note we still
transition between currentColor and actual colours, which is likely to
be fine by css4-color, which adds a blending primitive.

[1] http://www.w3.org/Style/2011/REC-css3-color-20110607-errata.html

BUG=394632

Review URL: https://codereview.chromium.org/552683002

git-svn-id: svn://svn.chromium.org/blink/trunk@181546 bbb929c8-8fbe-4397-9dbb-9b2b20218538

See:
https://codereview.chromium.org/526423002

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/553753002

git-svn-id: svn://svn.chromium.org/blink/trunk@181545 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews
BUG=367689
NOTRY=true

Review URL: https://codereview.chromium.org/547323002

git-svn-id: svn://svn.chromium.org/blink/trunk@181544 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Mixed Content: Move subframe checks into ResourceFetcher. (patchset #2 id:40001 of https://codereview.chromium.org/544573002/)

Reason for revert:
calls V8 from a non-V8 context

Original issue's description:
> Mixed Content: Move subframe checks into ResourceFetcher.
> 
> Currently we're checking for mixed content when loading the main
> resource of subframes in two places: DocumentLoader and ResourceFetcher.
> The former properly checks against the frame's parent frame, while the
> latter bypasses the checks entirely by virtue of the request's
> 'Resource::Type' being 'Main'.
> 
> This is both confusing and difficult to replicate when moving to the
> brave new world of request contexts and frame types that Fetch now
> defines.
> 
> This patch drops the DocumentLoader check, and moves the relevant
> logic into ResourceFetcher::canRequest and
> ResourceFetcher::checkInsecureContent.
> 
> BUG=400087
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181383

TBR=mkwst@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400087

Review URL: https://codereview.chromium.org/550083003

git-svn-id: svn://svn.chromium.org/blink/trunk@181543 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit f2e0beaedaeaf15c509a2abd2c4fe598c4094bbd.

TBR=arv@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/546973004

git-svn-id: svn://svn.chromium.org/blink/trunk@181542 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Those two files were split apart and redundantly copied
for non-Mac and Mac platforms. This is an attempt an unifying
them, as a preparation for removing the CoreText shaper.
We can merge the implementations in FontPlatformDataHarfBuzz.cpp
and FontPlatformData.cpp as a next step.

This is a reland after the original change 72f392cc147764ec75e4f
got reverted in bcfdb1312a26b0e611. Fix is to
change to the previous operator== implementation and add
m_isHashTableDeletedValue to the hash computation. 

I believe this addresses the observed crash issue as well.

BUG=334269, 411287
R=eae,arv

Review URL: https://codereview.chromium.org/542653002

git-svn-id: svn://svn.chromium.org/blink/trunk@181541 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
TBR=arv@chromium.org
BUG=411779

Review URL: https://codereview.chromium.org/546633008

git-svn-id: svn://svn.chromium.org/blink/trunk@181540 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I would like to add new time complexity test.
Unfortunately, current framework doesn't support async tests.

In this patch I wrap for and while operators, so they could
run asynchronously.

CL I'm going to write test to (fix n^2 HTML parsing):
https://codereview.chromium.org/494993002/

Here is the first async test:
https://codereview.chromium.org/500363002/

BUG=410790

Review URL: https://codereview.chromium.org/544453004

git-svn-id: svn://svn.chromium.org/blink/trunk@181539 bbb929c8-8fbe-4397-9dbb-9b2b20218538

While most color properties have an initial value of currentColor,
explicitly specifying currentColor behaves different internally to an
initial value. This patch makes currentColor no longer resolved in style
resolution for properties which are a single color and removes a flag
from RenderStyle indicating that currentColor was explicitly set.

Review URL: https://codereview.chromium.org/547273002

git-svn-id: svn://svn.chromium.org/blink/trunk@181538 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Do what the comment says, not what the code does :)

BUG=399775

Review URL: https://codereview.chromium.org/543273002

git-svn-id: svn://svn.chromium.org/blink/trunk@181537 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead, it should use synchronous ResourceRequest to obtain imported xsl-stylesheet.

TEST=fast/xsl/transform-xhr-doc.xhtml
BUG=367689

Review URL: https://codereview.chromium.org/507583002

git-svn-id: svn://svn.chromium.org/blink/trunk@181536 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently this test is expected to be timed out and should be skipped to reduce
the time to run tests.

BUG=398355
TBR=horo@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/546333002

git-svn-id: svn://svn.chromium.org/blink/trunk@181535 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These attributes are gone:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-container

Chromium: https://codereview.chromium.org/544023002/


BUG=404982
TEST=run_webkit_tests.py --debug http/tests/serviceworker/

Review URL: https://codereview.chromium.org/541943003

git-svn-id: svn://svn.chromium.org/blink/trunk@181534 bbb929c8-8fbe-4397-9dbb-9b2b20218538