GitLab

Couple minor visual tweaks to the Add Word row; see screenshots at
https://crbug.com/630982#17.

BUG=630982
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2525003006
Cr-Commit-Position: refs/heads/master@{#434827}

BUG=667779,667797

Review-Url: https://codereview.chromium.org/2539583002
Cr-Commit-Position: refs/heads/master@{#434826}

No change in functionality. Expectation lines adjusted to make
ownership clear.

TBR=chrishtr@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2535103002
Cr-Commit-Position: refs/heads/master@{#434825}

AMD drivers do not correctly handle the pattern of DX calls generated
by ANGLE for glTexStorage2DExt. We've worked around the known
problematic case in crrev.com/2507963003, so this change removes the
GPU raster blacklist.

It's possible that this issue is still hittable from Skia, and likely
from WebGL2, so it makes sense to try to work around this in ANGLE or
to blacklist glTexStorage2DExt.

Unfortunately, the ANGLE code in this area is quite complex, and a
workaround is a ways out. Additionally, there's no way to disable
glTexStorage2DExt without losing all of WebGL2, which seems non-ideal.

BUG=660897
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2521803002
Cr-Commit-Position: refs/heads/master@{#434824}

This adds the SHA-256 of the RSA key that we use to sign CRX packages on
Chrome.

BUG=630420

Review-Url: https://codereview.chromium.org/2509293003
Cr-Commit-Position: refs/heads/master@{#434823}

Follow-up to r433964 to change IndexedDBCallbacks to take its
IndexedDBDispatcherHost argument as a scoped_refptr as suggested by
dcheng@.

BUG=None

Review-Url: https://codereview.chromium.org/2521903004
Cr-Commit-Position: refs/heads/master@{#434822}

Removes DataGrid's hasChildren getter and setters and replaces them with
respective function calls for get and set.

R=dgozman
BUG=None

Review-Url: https://codereview.chromium.org/2536723003
Cr-Commit-Position: refs/heads/master@{#434821}

Reland of Post tasks for sensitive input visibility notifications (patchset #1 id:1 of https://codereview.chromium.org/2531683002/ )

Reason for revert:
Fixing SecuritySTateTabHelperTests

Original issue's description:
> Revert of Post tasks for sensitive input visibility notifications (patchset #5 id:80001 of https://codereview.chromium.org/2515373003/ )
>
> Reason for revert:
> Suspected for flaky failures on browser_tests for Mac 10.9 asan, Mac 10.10
>
> E.g.
> SecurityStateTabHelperTestWithPasswordCcSwitch/SecurityStateTabHelperTestWithPasswordCcSwitch.PasswordSecurityLevelDowngradedFromIframe/0
> SecurityStateTabHelperTest.PasswordSecurityLevelNotDowngradedWithoutSwitch
>
> https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/24682
> https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/9716
>
> Errors like
>
> ../../chrome/browser/ssl/security_state_tab_helper_browser_tests.cc:966: Failure
> Value of: security_info.security_level
>   Actual: 0
> Expected: security_state::HTTP_SHOW_WARNING
> Which is: 1
> ../../chrome/browser/ssl/security_state_tab_helper_browser_tests.cc:971: Failure
> Value of: entry->GetSSL().content_status & content::SSLStatus::DISPLAYED_PASSWORD_FIELD_ON_HTTP
>   Actual: false
> Expected: true
>
> Original issue's description:
> > Post tasks for sensitive input visibility notifications
> >
> > If password inputs are hidden and shown multiple times in the same task
> > (as apparently happens when processing a stylesheet), we don't want to
> > the omnibox warning to flicker in and out. Thus, this CL posts sensitive
> > input visibility notifications to the end of the task queue, so that the
> > omnibox warning updates get coalesced.
> >
> > BUG=664194
> > TEST=Visit http://http-password.badssl.com and observe that the omnibox
> > warning does not flicker in and out twice.
> >
> > Committed: https://crrev.com/7bdbe352cdbd7cc1dec2b71653e60b47688bd9e1
> > Cr-Commit-Position: refs/heads/master@{#434340}
>
> TBR=dcheng@chromium.org,haraken@chromium.org,estark@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=664194
>
> Committed: https://crrev.com/e0c7eb5a36b45db9a17c75715a99b3a547c45974
> Cr-Commit-Position: refs/heads/master@{#434400}

TBR=dcheng@chromium.org,haraken@chromium.org,tapted@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664194

Review-Url: https://codereview.chromium.org/2538473002
Cr-Commit-Position: refs/heads/master@{#434820}

Today, UISourceCodeFrame removes all messages from UISourceCode whenever
the working copy of UISourceCode gets changed. This is a "wag the dog"
situation.

This patch makes UISourceCode to decide on the lifetime on its messages.
This will help to implement the message merging logic.

Drive-by: converts UISourceCodeFrame._rawMessageBucket into Map.

BUG=649837

Review-Url: https://codereview.chromium.org/2514323008
Cr-Commit-Position: refs/heads/master@{#434819}

Previously TriView child views would be allocated their preferred size
during the TriView layout.  However, if a child view's preferred size
later changed it did not trigger a TriView layout and the child view
would not be allocated space based on its new preferred size.

This change fixes it so that a TriView's child will be reallocated space
if its preferred size changes. This will not cause the TriView
container views to be resized when a child views preferred size changes.

BUG=667955
TEST=ash_unittests --gtest_filter=TriViewTest.ChildViewsPreferredSizeChanged

Review-Url: https://codereview.chromium.org/2538513002
Cr-Commit-Position: refs/heads/master@{#434818}

FontFetcherMojoImplUnittest used to just create the impl object directly
and fire methods at it. In this change, we use the mojo services
framework for service binding and communication.

BUG=

Review-Url: https://codereview.chromium.org/2534033002
Cr-Commit-Position: refs/heads/master@{#434817}

BUG=615242
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2518763002
Cr-Commit-Position: refs/heads/master@{#434816}

d8b550c7 introduced a JNI wrapper for
base::UnguessableToken. This change uses the wrapper to send parcelled
tokens when fulfilling a ScopedSurfaceRequest, instead of two jlongs.

BUG=
TEST= verified we could still play HLS.

Review-Url: https://codereview.chromium.org/2535923003
Cr-Commit-Position: refs/heads/master@{#434815}

These tests frequently fail on various builders, so disabling them.

BUG=657331
TBR=paulmeyer@chromium.org

Review-Url: https://codereview.chromium.org/2539603002
Cr-Commit-Position: refs/heads/master@{#434814}

Review-Url: https://codereview.chromium.org/2537633003
Cr-Commit-Position: refs/heads/master@{#434813}

If there is no web contents to distill, stop trying to open the
Reader Mode panel.

BUG=666277

Review-Url: https://codereview.chromium.org/2510093004
Cr-Commit-Position: refs/heads/master@{#434812}

* Adding a test and fixing the issue

BUG=669126

Review-Url: https://codereview.chromium.org/2535023002
Cr-Commit-Position: refs/heads/master@{#434811}

We're derefferencing the unique_ptr after we've moved it which has
undefined behavior.  In this case, we get a segfault.

BUG=669266

Review-Url: https://codereview.chromium.org/2536933002
Cr-Commit-Position: refs/heads/master@{#434810}

Previously codec configuration was done in WebrtcTransport by string
substitutions. It worked properly only as long as rtp payload type
values do not change. Added SdpHelper that allows to implement this
logic more reliably, without dependency on payload type values.

BUG=669121

Review-Url: https://codereview.chromium.org/2536623003
Cr-Commit-Position: refs/heads/master@{#434809}

For the redirect chain A->B->C->D metric should track:
1. If initial URL (A) was on a Safe Browsing blacklist.
2. If any if middle urls (B, C) were on a Safe Browsing blacklist.
3. If committed URL (B) was on a Safe Browsing blacklist.

Another metric added is this CL tracks the length of the redirect chain.

BUG=653810

Review-Url: https://codereview.chromium.org/2415553002
Cr-Commit-Position: refs/heads/master@{#434808}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1e916c1c87c8..3950931a913d

$ git log 1e916c1c8..3950931a9 --date=short --no-merges --format='%ad %ae %s'
2016-11-28 charliea Add a timeout for acquiring cloud storage pseudo lock
2016-11-28 benjhayden Plumb label, benchmarkStartMs thru ChartJsonConverter.

BUG=669088

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2537643002
Cr-Commit-Position: refs/heads/master@{#434807}

This CL defines a base class for DisplayAndroid, and separates out an implementation for an Android Display backed DisplayAndroidImpl, and a VirtualDisplayAndroid (currently intended for use by Chrome's VRShell and WebVR). Unlike the DisplayAndroidImpl, VirtualDisplayAndroid is mutable to display clients.

The display ID for a DisplayAndroid can no longer be assumed to match that of an Android Display.

BUG=643480

Review-Url: https://codereview.chromium.org/2523273002
Cr-Commit-Position: refs/heads/master@{#434806}

Use the common class from base instead.

BUG=NONE
TEST=Automated
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2528623003
Cr-Commit-Position: refs/heads/master@{#434805}

When an inputmode is specified it overrides the default text input type.
inputmode is behind an experimental web platform flag but it allows
the author to configure what virtual keyboard is shown for the various
input and content editable fields.

BUG=642800
TBR=aelias@chromium.org

Review-Url: https://codereview.chromium.org/2523753003
Cr-Commit-Position: refs/heads/master@{#434804}

BUG=669227
TBR=tsergeant@chromium.org

Review-Url: https://codereview.chromium.org/2533103002
Cr-Commit-Position: refs/heads/master@{#434803}

This replaces the idiom "poor man's <???>" with "ad-hoc".

BUG=542537

Review-Url: https://codereview.chromium.org/2523973002
Cr-Commit-Position: refs/heads/master@{#434802}

BUG=664269

Review-Url: https://codereview.chromium.org/2530923002
Cr-Commit-Position: refs/heads/master@{#434801}

The window is supposed to instantly pop behind and in front of the main browser
window.

BUG=667511

Review-Url: https://codereview.chromium.org/2532233002
Cr-Commit-Position: refs/heads/master@{#434800}

To improve readability/maintenance.

BUG=666800

Review-Url: https://codereview.chromium.org/2532283002
Cr-Commit-Position: refs/heads/master@{#434799}

An ffmpeg roll seems to updated the handling of the pre-roll for the
aac test.  The difference between the new and old results is that the
new has the initial 2048 samples (of zero) removed.

BUG=669106
TEST=m4a-short-duration-44khz.html now passes

Review-Url: https://codereview.chromium.org/2536843002
Cr-Commit-Position: refs/heads/master@{#434798}

This is a partial revert of https://codereview.chromium.org/2524113002/
which is incomplete about SVG text coordinate flipping. We could make it
complete, but before we think everything clear, I'd like to revert the
part first. At least all existing and new text cases about vertical SVG
text pass with this CL.

(Putting aside that we reuse InlineBox/LayoutBlockFlow code for SVG
text, flipped writing-mode doesn't apply to SVG text because it doesn't
have multi-line block direction layout. Vertical-rl and vertical-lr are
actually equivalent for SVG text.)

BUG=666416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
R=pdr@chromium.org

Review URL: https://codereview.chromium.org/2533633002 .

Cr-Commit-Position: refs/heads/master@{#434797}

AutocompleteSyncBridge is the USS(unified sync and storage) equivalent of
 the AutocompleteSyncableService. The goal is for identical
functionality, but with reduced memory usage due to unifying the storage
 of sync metadata and autofill data.

R=pavely@chromium.org,isherman@chromium.org,pkasting@chromium.org

BUG=666406

Review-Url: https://codereview.chromium.org/2508263003
Cr-Commit-Position: refs/heads/master@{#434796}

Also use ScopedTestRoot instead of TestRootCerts::Add.

BUG=651965

Review-Url: https://codereview.chromium.org/2513543003
Cr-Commit-Position: refs/heads/master@{#434795}

BUG=669083
NOTRY=true

Review-Url: https://codereview.chromium.org/2537613002
Cr-Commit-Position: refs/heads/master@{#434794}

Expectations will be changed in https://codereview.chromium.org/2534013002/.

BUG=chromium:661497
TBR=dgozman@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2536923002
Cr-Commit-Position: refs/heads/master@{#434793}

BUG=668072
NOTRY=true

Review-Url: https://codereview.chromium.org/2540493002
Cr-Commit-Position: refs/heads/master@{#434792}

Touch calibration requires atleast 3 pairs of display and touch
points along with the total size of the display.

This change implements a struct to store the minimum touch
calibration associated data and an API for ManagedDisplayInfo
to store and retrieve this data when required.

Design Doc=go/cros-touch-calibration (Draft)

BUG=667921
COMPONENT=Display, Chrome OS, Managed Display Info

Review-Url: https://codereview.chromium.org/2521393002
Cr-Commit-Position: refs/heads/master@{#434791}

This patch ensures the FrameView paint properties are rebuilt when the window
resizes. This fixes a crash if you resized wikipedia.

BUG=667946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2524733005
Cr-Commit-Position: refs/heads/master@{#434790}

Review-Url: https://codereview.chromium.org/2535853003
Cr-Commit-Position: refs/heads/master@{#434789}

This will be used by a CL for the "breadcrumbs" project that needs
to convert from a raw-memory pointer used by a class that knows
nothing about persistent memory, back to a reference.

BUG=620813

Review-Url: https://codereview.chromium.org/2534643002
Cr-Commit-Position: refs/heads/master@{#434788}