- 05 Nov, 2018 40 commits
-
-
Andrew Grieve authored
Explicit registration is needed only when using the custom linker. Cast shell doesn't use the custom linker, so has no need to jump through the extra hoops involved with explicit registration. Change motivated by JNI refactorings, which are made simpler by having fewer targets use manual JNI registration. Bug: 898261 Change-Id: I88e92480d355fc0a19ffdd4c816efbf749dd9964 Reviewed-on: https://chromium-review.googlesource.com/c/1317340Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#605446}
-
Nico Weber authored
clang-cl supports #pragma hdrstop as of r341963. Bug: 505314,504657,750327,826743 Change-Id: Ic90b07114bbb886b7d8345a260863f45eef352b7 Reviewed-on: https://chromium-review.googlesource.com/c/1317607 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#605445}
-
Oksana Zhuravlova authored
This change splits the print statement in the imports vs deps check function into three separate ones, as well as prints the correct filename instead of the first one in the list. Change-Id: I81010efa46eeab37847d90df5574cdf34ff4b83f Reviewed-on: https://chromium-review.googlesource.com/c/1316727 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#605444}
-
liberato@chromium.org authored
This CL renames core => common, updates build deps to be a less tangled, renames a few classes, and updates imports. Change-Id: I011f9ec6d704681b50da5be759341e7e3b48d076 Bug: 897463 Reviewed-on: https://chromium-review.googlesource.com/c/1289688 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
Alexander Shah authored
Sends LayerTreeFrameSink the hit-test debug state from LayerTreeDebugState. R=riajiang@chromium.org Change-Id: Ie180735f7f61863ac4546516b9991ee529fa99bb Reviewed-on: https://chromium-review.googlesource.com/c/1314613 Commit-Queue: Alexander Shah <zandershah@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#605442}
-
Eric Orth authored
Allows network service clients to listen for when changes are detected to the system DNS configuration. Will be useful for the DnsProbeService usecase where the probe service needs to use config change as a signal to clear cached probe results. Only signals that changes have happenned, not what the changes were, and there is no current plan for the network service to support retrieving DNS config or details on changes. Recent work on DnsConfigOverrides has negated all known service-external usecases for such capabilities. Bug: 846423 Change-Id: Iee980205a2d3d0ddc80b39fb2a0a043a593db0a4 Reviewed-on: https://chromium-review.googlesource.com/c/1309334Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#605441}
-
Rayan Kanso authored
The histogram name in the xml file was different than the one used. Change-Id: Ibace41bb7d44a22b6cf81850689035f2bcf03f89 Reviewed-on: https://chromium-review.googlesource.com/c/1317631Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#605440}
-
Max Timkovich authored
Read extension policy settings from the `policy_path` as a fallback in the case where the data directory does not have any extension policy information. This allows setting extension policies through client-side autotests. Bug: 900238 Change-Id: I49204ae22df6633e65ec30bbba9b0e2e40216580 Reviewed-on: https://chromium-review.googlesource.com/c/1307450Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Max Timkovich <timkovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#605439}
-
Ted Choc authored
The bug manifested itself if you had the downloads page visible and was the first time you focused the omnibox. The problem was caused by two views using the ID toolbar in their XML. Then findViewById on the root was unpredictable and would return the first it finds, and when downloads is showing it would be the downloads toolbar. This just makes the downloads toolbar use a unique ID. BUG=901736 Change-Id: I4b67fb828909f1ac443569faa691b953c94e73a1 Reviewed-on: https://chromium-review.googlesource.com/c/1318370Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#605438}
-
mrefaat authored
This CL to prepare for removing -view method from Tab Bug: 899832 Change-Id: Iebe22114e1b478bb41e418e66c5ba5b85109166e Reviewed-on: https://chromium-review.googlesource.com/c/1318178Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#605437}
-
Emircan Uysaler authored
Following https://github.com/w3c/mediacapture-screen-share/pull/86 Bug: 326740 Change-Id: Ifb65a33a7f998563640d9f508d26d91ecb16c32f Reviewed-on: https://chromium-review.googlesource.com/c/1313188Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605436}
-
Jeremy Apthorp authored
This makes the app indicator API in libgtkui usable by non-Chrome apps (in particular, Electron). Change-Id: I39e547fc04595900d99806208955c632e4199be4 Reviewed-on: https://chromium-review.googlesource.com/c/1315840 Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#605435}
-
Dmitry Gozman authored
Worklets running in a separate thread do not have parent_devtools_token, and so we don't support debugging them. This should probably be fixed. Meanwhile, we should not also pause them on start - otherwise there is no way to unpause because nobody is actually debugging them. Bug: 901112 Change-Id: I63b59da95a1181ff03886f8fc233aa621726f1f8 Reviewed-on: https://chromium-review.googlesource.com/c/1313837Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605434}
-
Joey Arhar authored
Bug: 899128 Change-Id: I6275ce55fec18dcba45c8cbb085a1eea45b5fba6 Reviewed-on: https://chromium-review.googlesource.com/c/1310564 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605433}
-
W. James MacLean authored
Because of the unusual way that the TouchEmulator creates pinch events, it's possible for a GestureFlingStart (created by the GestureRecognizer) to terminate a pinch sequence. In that event a synthetic GestureScrollEnd is inserted. Prior to this CL, that GestureScrollEnd had a zero value for unique_touch_event_id, which in turn caused problems when it was sent to DispatchTouchscreenGestureEvent, along with a null target. Bug: 900496 Change-Id: I290757980def3f55a0111a2e31f8424ce06e96f1 Reviewed-on: https://chromium-review.googlesource.com/c/1312619 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#605432}
-
Ian Clelland authored
This fixes an error in the inherited policy calculation where a frame which was explicitly allowed to use a feature through the Feature-Policy header would be blocked if the "allow" attribute was also present on the iframe element. The behaviour now matches the spec algorithm at https://wicg.github.io/feature-policy/#define-inherited-policy-in-container Tests have been added to catch this case. Change-Id: I7a394202c615be3088fda738d7fc65f16bcadf34 Reviewed-on: https://chromium-review.googlesource.com/c/1293610Reviewed-by:
Luna Lu <loonybear@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#605431}
-
Henrique Grandinetti authored
Bug: 900823 Change-Id: I1115d5731f19cf4e5b1ef545741b0d75ea0da062 Reviewed-on: https://chromium-review.googlesource.com/c/1312908 Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#605430}
-
Zhongyi Shi authored
Bug: 901564 Change-Id: I5d9e5dcb34fbcb887e96652c5d27516139096a37 Reviewed-on: https://chromium-review.googlesource.com/c/1316838 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#605429}
-
Dmitry Titov authored
This reverts commit 08f4508d. Reason for revert: Broke ChromeOS build (deps check): https://logs.chromium.org/logs/chromium/bb/chromium.chrome/Google_Chrome_ChromeOS/58389/+/recipes/steps/generate_build_files/0/stdout Original change's description: > Add cast http apis for assistant services. > > Bug: b:118193766 > Test: Manual > Change-Id: I6da9d8458a59701ae7c9ed642d16094e2f36782b > Reviewed-on: https://chromium-review.googlesource.com/c/1304489 > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Yilei Li <yileili@google.com> > Cr-Commit-Position: refs/heads/master@{#605395} TBR=xiaohuic@chromium.org,yileili@google.com Change-Id: Iea76a7f0b26bac670898c11ab60862ca9631657c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:118193766 Reviewed-on: https://chromium-review.googlesource.com/c/1318439Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#605428}
-
Koji Ishii authored
Following bot results are included. 11381 11384 11392 11399 11408 11426 11431 11433 11434 11435 11437 11443 11445 11446 11452 11458 11461 11466 11467 11469 11473 7 lines were removed and 11 lines were deflaked by consecutive results since 11435. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I1767b1f2b084484ac3b3e88b70fc150d55effa65 Reviewed-on: https://chromium-review.googlesource.com/c/1314077 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#605427}
-
Shakti Sahu authored
This was broken due to introduction of location change. This has already been fixed in download home V2. Bug: 887728 Change-Id: I4041fea1681eb7cc179c2155a8fca7b96750db39 Reviewed-on: https://chromium-review.googlesource.com/c/1316089Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0e8346b53d7a..436c9f1a8887 git log 0e8346b53d7a..436c9f1a8887 --date=short --no-merges --format='%ad %ae %s' 2018-11-05 tsepez@chromium.org Make cfx_globalarray a move-only type. Created with: gclient setdep -r src/third_party/pdfium@436c9f1a8887 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5e4ce9794daee9489410404235cde3cafe279fb6 Reviewed-on: https://chromium-review.googlesource.com/c/1318330Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605425}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8b35379ae1f1..aa27a834ba5d git log 8b35379ae1f1..aa27a834ba5d --date=short --no-merges --format='%ad %ae %s' 2018-11-05 allanmac@google.com Minor HotSort updates 2018-11-05 halcanary@google.com Documentation: more updates to site/dev/testing/xsan.md 2018-11-05 reed@google.com use SkFontHinting from SkFontTypes.h 2018-11-05 fmalita@chromium.org Reland: [skjson] Unescape strings 2018-11-05 jvanverth@google.com Draw YUVA images with multitexture Created with: gclient setdep -r src/third_party/skia@aa27a834ba5d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: Ia1813dc7951e1df880e4992138976cc345cd1ec0 Reviewed-on: https://chromium-review.googlesource.com/c/1318311Reviewed-by:
-
Eugene But authored
Additional changes: - Removed NativeWebInterstitialDelegate class - Merged HtmlWebInterstitialDelegate to base class - Update test to only test WebInterstitial interface Bug: None Change-Id: Ic44f309edf8dd85f9a55e45ed731d7abde188039 Reviewed-on: https://chromium-review.googlesource.com/c/1316831 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#605423}
-
Koji Ishii authored
This patch fixes MarkLineBoxesDirty to mark correctly when: 1. The changed node has a parent inline box, and 2. is the first child of the parent, and 3. the parent has box fragment (not culled,) and 4. the parent wraps to multiple lines. e.g., <span id="parent" style="background: yellow"> <span id="changed"></span> <br> text </span> In this case, the old code marks the line box that contains the last fragment of #parent because #parent is "previous" of #changed in the pre-order DFS. The marked line box is the one after #changed, and thus we try to reuse changed line. This issue was found by a WIP to apply reusing line boxes in more cases. From the stack, this looks the same as crbug.com/900898. Bug: 636993, 900898 Change-Id: I43d1d8150bfff7e1d9a6572be5a235cbe937caac Reviewed-on: https://chromium-review.googlesource.com/c/1314086 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#605422}
-
danakj authored
TBR=cthomp@chromium.org, rsleevi Change-Id: Id59454fea00ef51fe6c4cf6aded5a2fd2c8a3b8e Bug: 890372 Reviewed-on: https://chromium-review.googlesource.com/c/1318379Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/688679325c64..4c7f72c9764e git log 688679325c64..4c7f72c9764e --date=short --no-merges --format='%ad %ae %s' 2018-11-05 lalitm@google.com Merge "Add sqlite percentile" 2018-11-05 lalitm@google.com Merge "Change TraceProcessor to an abstract class" 2018-11-05 fmayer@google.com Merge "profiling: Add heapprofd config." 2018-11-05 lalitm@google.com Merge "trace_processor: SpanOperatorTable -> SpanJoinOperatorTable" Created with: gclient setdep -r src/third_party/perfetto@4c7f72c9764e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7c8487e1bdf1fb7d974348dfa80e60be443a7cbe Reviewed-on: https://chromium-review.googlesource.com/c/1318151Reviewed-by:
-
Christian Biesinger authored
As well as inlining some NGPhysicalOffset functions. Change-Id: I005e74367e2817e9c0acd68207ea3a8c3c011d5f Reviewed-on: https://chromium-review.googlesource.com/c/1316357Reviewed-by:
-
Matt Reynolds authored
HidReportDescriptor tests for four console gamepads: * Dualshock 3 connected over USB * Dualshock 4 connected over USB * Xbox Wireless Controller connected over Bluetooth * Nintendo Switch Pro connected over USB BUG=890096 Change-Id: I47629f69eb0257f9c985e5e438f979b5b0497f7f Reviewed-on: https://chromium-review.googlesource.com/c/1258502 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#605418}
-
Antonio Gomes authored
CL makes sure that SetOnResponseStartedCallback and SetOnRedirectCallback can only be set prior to the request gets started. This is a follow up on a request made by mmenke@ in [1]. [1] https://crrev.com/c/1142350/14/services/network/public/cpp/simple_url_loader.cc#1226 TBR=pfeldman@chromium.org,peter@chromium.org BUG=773295 Change-Id: If937313c21df5139f1c6e21f982b228513501962 Reviewed-on: https://chromium-review.googlesource.com/c/1317949 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/aed3070ad40c..c22f551842df git log aed3070ad40c..c22f551842df --date=short --no-merges --format='%ad %ae %s' 2018-11-05 saza@webrtc.org Remove locks from AECM and move it into private_submodules_ 2018-11-05 nisse@webrtc.org Delete struct rtc::PacketTime. 2018-11-05 henrik.lundin@webrtc.org Removing ancient and unused test scripts and data files 2018-11-05 nisse@webrtc.org Set RtpRtcp config receive_only in voe::ChannelReceive Created with: gclient setdep -r src/third_party/webrtc@c22f551842df The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5851aa61a2b17417775bda952558f6f05b4d907c Reviewed-on: https://chromium-review.googlesource.com/c/1318309Reviewed-by:
-
Lukasz Anforowicz authored
not_site_per_process_browser_tests step has been removed by r581059 back in August - therefore the original reason for disabling SiteIsolationPolicyBrowserTest.NoPolicyNoTrialsFlags test is gone and the test can be re-enabled everywhere. Bug: 833423 Change-Id: If4d197202c18c277e80d6e37760c2e0bb6c4c622 Reviewed-on: https://chromium-review.googlesource.com/c/1315359Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#605415}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f64f594fd65..d256e043692f Created with: gclient setdep -r src-internal@d256e043692f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:448088 TBR=mmoss@chromium.org Change-Id: Idba3e5862f5edf974af6a01ecfe8a17cb4fff702 Reviewed-on: https://chromium-review.googlesource.com/c/1318310Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605414}
-
Jonathan Metzman authored
Don't create Environment outside of LLVMFuzzerTestOneInput. TBR=mmoroz@chromium.org Change-Id: I470016153ec30ed09805ef8dce8baa2b8103d8d1 Reviewed-on: https://chromium-review.googlesource.com/c/1318401 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605413}
-
Andres Calderon Jaramillo authored
This CL disables css3/blending/mix-blend-mode-isolated-group-1.html and css3/blending/mix-blend-mode-isolated-group-3.html on Mac. Bug: 900431 Change-Id: I4b21aadb11ff91182b495ffe0959e9c8f5a7184c Reviewed-on: https://chromium-review.googlesource.com/c/1312680Reviewed-by:
-
James Hawkins authored
R=nohle@chromium.org Bug: 899324 Test: none Change-Id: I6ef5f75f6f7c051a7174c8d04ff45f0788e21258 Reviewed-on: https://chromium-review.googlesource.com/c/1318074Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#605411}
-
John Abd-El-Malek authored
Change-Id: Ic4578cae0d6b1a0d7d4ccd3e81917ac2a2694e92 Reviewed-on: https://chromium-review.googlesource.com/c/1303153Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#605410}
-
Lukasz Anforowicz authored
This CL edits descriptions and comments related to the --disable-site-isolation-trials switch. The switch is implemented and used in a way that disables not only site isolation trials, but also opts out of the default site isolation mode (i.e. out of site-per-process mode that is the default on desktop since M67). The CL avoids editing the *name* of the switch to avoid backcompatibility problems around chrome://flags and/or test tools. There are no intended behavior changes except for different description texts for the enterprise policy and chrome://flags. Change-Id: Ia2076c4120d159f9d80e7d578ea0e673fdfda759 Bug: 901522 Reviewed-on: https://chromium-review.googlesource.com/c/1315535 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Danan S authored
Wrote unit test for DemoModeDetector, accounting for existing behavior, and also the new behavior introduced in this CL. R=michaelpg@chromium.org TEST=tested manually on dev chromebook, and with demo_mode_detector_unittest.cc Bug: 877655 Change-Id: Ibfd78ec1cf2d87c3acad71a8244e519f70601cec Reviewed-on: https://chromium-review.googlesource.com/c/1298417 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
-
sczs authored
There are some crashes on shutdown and they seem to be related to History not stopping its Coordinator before some services/observers are dealloc. This CL stops the History Coordinator before shutting the rest of the App. Bug: 896309 Change-Id: I7500706266157c4a841fefa21c8299c1d8627d17 Reviewed-on: https://chromium-review.googlesource.com/c/1313674Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#605407}
-
