- 04 Oct, 2017 40 commits
-
-
Elly Fong-Jones authored
When there is both a title and message, the padding isn't needed, since it is intended to visually take the place of the message. Bug: 771515 Change-Id: Ia29be37ae2f2049da254e4ea4874fb28f073961e Reviewed-on: https://chromium-review.googlesource.com/700400 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#506544}
-
Jonathan Metzman authored
Bug: 769582 Change-Id: I197d6ac177dd14e00faaa2ab0a54b72576197c9c Reviewed-on: https://chromium-review.googlesource.com/694641Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#506543}
-
Lucas Garron authored
Bug: 770292 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I1f3cb8d0d38503326b37adcebf3dee17856c82d4 Reviewed-on: https://chromium-review.googlesource.com/693376 Commit-Queue: Lucas Garron <lgarron@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#506542}
-
Lei Zhang authored
Also remove a redundant include. Change-Id: I2f8313263c5c8392d4d6fddb11889ba2bca9d389 Reviewed-on: https://chromium-review.googlesource.com/669685Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#506541}
-
bsheedy authored
Adds a new page for WebVR Telemetry tests meant for fill-rate testing. Also adds a new set of pages that is the same as xr.webvr.static, but with VSync alignment turned off and pages set to use a standardized render resolution across all devices. Also updates the WebVR samples repo hash to a more recent once since the standardized size option was not available in the previous version. Adds two tracing categories to the WebVR Telemetry tests that aren't used for metrics, but are useful for debugging regressions. Bug: Change-Id: Ife71aa419822a6b3d2859af2c7556749f1fa5b0b Reviewed-on: https://chromium-review.googlesource.com/692601Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#506540}
-
Emil A Eklund authored
This reverts r482803 (commit 6eddce94). Broke option hit testing when combining a select and flexbox sometimes. Bug: 771216 Original change's description: > Listbox SELECT: Do not force layout on OPTION element selection. > > Adjust scroll position in PaintLayerScrollableArea::UpdateAfterLayout(), instead of > Document::UpdateStyleAndLayoutIgnorePendingStylesheets() followed by scrolling. > > Bug: 556801, 620408 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I2bd014b2f7950f1a51dbfa5067638013736d62dc > Reviewed-on: https://chromium-review.googlesource.com/542059 > Reviewed-by: Steve Kobes <skobes@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#482803} TBR=skobes@chromium.org,tkent@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 556801, 620408 Change-Id: I6861c3ea1ab3aa4e7ee8365bc21e444a477608ca Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/699594 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#506539}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/22069a18..73d9476e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ibdfcc894e660d187b6ea53cd1f8e482415911d12 Reviewed-on: https://chromium-review.googlesource.com/700721Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#506538}
-
Yuwei Huang authored
Previously if a host list fetch is not triggered by the user (refresh control) and fails, then the app will simply pop up a toast complaining about unavailable network and show nothing else. Pull-to-refresh doesn't work. This CL fixes this by providing a dialog-like view to allow user to retry in that case. Screenshot: https://drive.google.com/file/d/0BytzIZKeM8nBMmN3b3A0bUhoMFU/view?usp=sharing Bug: 771532 Change-Id: I64cb4015acc066322c3c6127b79b87d13cb06652 Reviewed-on: https://chromium-review.googlesource.com/700316Reviewed-by:
Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#506537}
-
Michael Moss authored
R=dpranke@chromium.org, phajdan.jr@chromium.org Change-Id: I2b5e743a9983788d5fdd1b5414286e7d9e134184 Reviewed-on: https://chromium-review.googlesource.com/700859Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#506536}
-
Yuwei Huang authored
The anchor is the height anchor so the constant should be 2x the margin. Bug: 770906 Change-Id: Ia82073246d8224791478781efc4e73e9f69f43f0 Reviewed-on: https://chromium-review.googlesource.com/701399Reviewed-by:
-
Maks Orlovich authored
This is a reland of f9cc9601 Original change's description: > SimpleCache: Port (unsequenced) use of SequencedWorkerPool over to TaskScheduler > > This is what it does behind scenes in Chrome anyway, but always using the scheduler > in tests as well is helpful since it means a single TaskScheduler::FlushForTesting() call > rather than needing both TaskScheduler and SequencedWorkerPool versions of FlushForTesting() > as separate calls, which causes trouble when control jumps back and forth between the two. > > Bug: 766221 > Change-Id: Iab6a49cad86f1fd5a31c66c50d25e2962c538d53 > Reviewed-on: https://chromium-review.googlesource.com/697925 > Reviewed-by: Asanka Herath <asanka@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506395} Bug: 766221 Change-Id: I6f76f26780f129499fe9916b717362b7a11e944f Reviewed-on: https://chromium-review.googlesource.com/700858Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#506534}
-
Mark Pearson authored
Bug: Change-Id: I8c0c222c1b498ee1a5d312affa330b38a742d242 Reviewed-on: https://chromium-review.googlesource.com/700857Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#506533}
-
Michael Giuffrida authored
If an extension cannot normally be disabled due to policy, but must be disabled for some reason internal to Chrome (e.g., corruption), then ExtensionService should clean the disable_reasons before disabling the extension. ExtensionService now removes disallowed disable reasons (like user action) when forced to disable an extension. (It is unusual to call ExtensionService::DisableExtension with multiple reasons, but it may be possible in some scenarios, perhaps when applying synced changes.) Test: ExtensionServiceTest.ManagementPolicyProhibitsDisable Change-Id: Ief9250413201ced5c68bb015575709fa3c2c0f45 Reviewed-on: https://chromium-review.googlesource.com/688454Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#506532}
-
Aaron Gable authored
R=dpranke@chromium.org Change-Id: I7a4bbd3dff59c0e399b288bffca972c3693d2cad Reviewed-on: https://chromium-review.googlesource.com/700986Reviewed-by:
-
Christopher Cameron authored
This is not ready to be used. Bug: 771740 Change-Id: Ia54361b4985711729b693ab13dce959924298cdf Reviewed-on: https://chromium-review.googlesource.com/701395Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#506530}
-
Hector Carmona authored
Bug: 764125 Change-Id: Id90db21dd9333565bee94da935df90639be082c6 Reviewed-on: https://chromium-review.googlesource.com/699567 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#506529}
-
Peter Kotwicz authored
As a result of https://chromium-review.googlesource.com/c/chromium/src/+/670359 the values of SHOW_SEARCH_ENGINE_PAGE in FirstRunActivity#mFreProperties and FirstRunFlowSequencer#shouldShowSearchEnginePage() are guaranteed to be the same. Bug=755646 Change-Id: I8a0eef268f34319af3c1129aec8066bee214582d Reviewed-on: https://chromium-review.googlesource.com/700426 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#506528}
-
Fabio Tirelo authored
Bug: Change-Id: Ib77d051ef0813cd63eafd92b578919f46982d26b Reviewed-on: https://chromium-review.googlesource.com/700992Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#506527}
-
Peter Wen authored
Update README for errorprone and add owners. Use a single jar to make maintenance easier and to pave the way to updates in the future. BUG=383646 Change-Id: Ib9e2900141baab73515c957bb274b7568ef3102a Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/700856 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#506526}
-
Lei Zhang authored
ResourceBundle became ui::ResourceBundle in r72038 but many callers still refer to it without the namespace. Change-Id: Id63635507b65d3d6ffe1fa3a779e189969030b11 Reviewed-on: https://chromium-review.googlesource.com/696138Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#506525}
-
Sergey Shekyan authored
Introduce NavigatorAutomationInformation interface that indicates if navigator is controlled by automation. It is guarded by RuntimeEnabled and exists only if AutomationControlled feature is set. https://w3c.github.io/webdriver/webdriver-spec.html#dom-navigatorautomationinformation Bug: 723900 Change-Id: If54295456a24fe8c86958c037263939ba3e44cb7 Reviewed-on: https://chromium-review.googlesource.com/665978 Commit-Queue: Sergey Shekyan <shekyan@gmail.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#506524}
-
Doug Steedman authored
I only verified one setting of a compile time boolean, breaking the code when it had the other setting. R=servolk@chromium.org, xhwang@chromium.org Bug: 771166 Change-Id: Id22d6dcfaed6e2ffb247000afd2b968756c05b0f Reviewed-on: https://chromium-review.googlesource.com/699056Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Doug Steedman <dougsteed@chromium.org> Cr-Commit-Position: refs/heads/master@{#506523}
-
Stefan Zager authored
This is not a complete set of new baselines. It is based on pattern-matching text diffs from try bot results based on two heuristics: 1. For tests that dump the layer tree (i.e., those that output internal.layerTreeAsText(document)), there is an expected diff in the layer tree output of this format: "layers": [ { "name": "LayoutView #document", + "bounds": [800, 600], + "backgroundColor": "#FFFFFF" + }, + { + "name": "Scrolling Layer", + "bounds": [785, 600], + "drawsContent": false + }, + { + "name": "Scrolling Contents Layer", "bounds": [785, 2513], "contentsOpaque": true, "backgroundColor": "#FFFFFF", 2. For tests that scroll the top-level FrameView and then dump the layout tree (the default behavior), we expect the frame-level scroll to be reflected in the positions of all layers; for example: layer at (0,0) size 800x600 scrollX 1255.00 scrollY 1023.00 scrollWidth 2055 scrollHeight 2063 LayoutView at (0,0) size 800x600 -layer at (0,0) size 800x2063 backgroundClip at (0,0) size 800x600 clip at (0,0) size 800x600 +layer at (-1255,-1023) size 800x2063 backgroundClip at (0,0) size 800x600 clip at (0,0) size 800x600 LayoutBlockFlow {HTML} at (0,0) size 800x2063 LayoutBlockFlow {BODY} at (8,8) size 784x2047 LayoutBlockFlow {DIV} at (0,0) size 2047x2047 -layer at (8,8) size 784x0 +layer at (-1247,-1015) size 784x0 LayoutBlockFlow {DIV} at (0,0) size 784x0 scrolled to 1255,1023 Bug: 711468 Change-Id: I727759fdb626426af693b2bf29003ea7fba92f8b Reviewed-on: https://chromium-review.googlesource.com/699752 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by: -
Jeremy Roman authored
Memory allocated here is expected to leak. Bug: 770463 Change-Id: Iaa741c9753e018fe76d7e008d40d42a79e93c6fa Reviewed-on: https://chromium-review.googlesource.com/701416Reviewed-by:
-
Xiaohan Wang authored
Make it clear that Revoke() must be called after Consume(), which is what the current DCEHCK in dtor checks. If an extension does not need to be revoked, use ConsumePermanently(). BUG=510604 TEST=No functionality change Change-Id: Ifee995ffdfc608e4ccc40bbbb4096511c561237a Reviewed-on: https://chromium-review.googlesource.com/701274 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#506520}
-
Joy Ming authored
During the refactor to make downloads a foreground service on all versions of Android, a problem arose where Chrome crashes when canceling a file that is downloading. This CL fixes that issue. Bug: 771122,747563 Change-Id: Idaa2377ef06df1d30b6947e92b6743ad5e4b16c2 Reviewed-on: https://chromium-review.googlesource.com/700774Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Joy Ming <jming@chromium.org> Cr-Commit-Position: refs/heads/master@{#506519}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/d0b91b8f3a17..8894309be5ce $ git log d0b91b8f3..8894309be --date=short --no-merges --format='%ad %ae %s' 2017-10-03 wkorman Export external image element ids and urls. 2017-10-04 simonhatch Dashboard - Add support for tracing_perftests. 2017-10-04 wkorman Don't emit empty style tags. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I445f509d79b4d2f82ab922cb919f330b871c1852 Reviewed-on: https://chromium-review.googlesource.com/700979 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506518}
-
Yoland Yan authored
Command line flags are initiated by instrumentation tests' class runner. One should avoid calling CommandLine.init(null) manually in tests after native command line starts. Bug: 771205 Change-Id: I1e6d026a45c60eb81ce0860971fa2da44ab0285b Reviewed-on: https://chromium-review.googlesource.com/698351 Commit-Queue: Yoland Yan <yolandyan@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#506517}
-
Julian Pastarmov authored
This check is triggering on data types that are erroneusly written to the local sync db in the first place althoug they don't cause further processing errors. This is a fix for users with already messed dbs. Further fix will make sure commit-only entries are not serialized to the db at all. BUG=771598 Change-Id: Ifd7e5c5d07e5ab061cbb2cc1d7bbf54210568304 Reviewed-on: https://chromium-review.googlesource.com/701054 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#506516}
-
Mustafa Emre Acer authored
SSLErrorHandler ignores updates to SSL Error Assistant proto if the version_id of the new updated proto is not greater than the version_id of the current proto. The test helper was using INT_MAX for version_id of the updated proto. This meant that the proto was only being set once and subsequent updates were ignored. Also, the value of os_reports_captive_portal_for_testing_ wasn't reset properly in tests. Bug: 642993 Change-Id: I4b021e5973ae6d4e7d95e61d55d7b117e1c2824d Reviewed-on: https://chromium-review.googlesource.com/699425 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
-
Wei Li authored
Pdf compositor service is a utility service that uses skia to render and generate pdf document. Thus it needs to access local font system. On Linux, it needs 'uname' to get user agent. So, on Windows and Mac, it resembles ppapi process in term of sandbox policy. On Linux, it is closer to utility process's sandbox requirements. To make its requirements clear, we create a new service sandbox type for it, and apply appropriate policy on different platforms. TBR=jam@chromium.org BUG=455764 Change-Id: I7c7aeb40e5e0b09fe29887532c06d2abc04969d6 Reviewed-on: https://chromium-review.googlesource.com/695781 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#506514}
-
Mustafa Emre Acer authored
It was marked as flaky in 2011. Things have changed since then. Bug: 84729 Change-Id: I638f9c26e9636dff8f27903df5e64ff911d10a03 Reviewed-on: https://chromium-review.googlesource.com/700954Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#506513}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/fa8c08044989..0078e912718c $ git log fa8c08044..0078e9127 --date=short --no-merges --format='%ad %ae %s' 2017-10-04 angle-deps-roller Roll skia/third_party/externals/angle2/ a99ed554c..baf5d9458 (1 commit) 2017-10-04 csmartdalton Rename GrOpList::reset to endFlush 2017-10-03 benjaminwagner Add more detail to Swarming bot doc. Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I0516a7cca7bd2500a1425be30de1e82ebd15d74c Reviewed-on: https://chromium-review.googlesource.com/700755Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506512}
-
Marijn Kruisselbrink authored
This is a reland of 419b66b5 Original change's description: > Fix behavior around closed message ports. > > Connect a closed message port to a dangling message pipe to make sure > messages posted to the port end up getting lost, even after the message > port is transferred to a different process. > > Bug: 673526 > Change-Id: I95467bf5c3e1af316c8781bcca6dfdda29936fe8 > Reviewed-on: https://chromium-review.googlesource.com/690981 > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505760} Conflicts: TBR=jbroman@chromium.org Bug: 673526 Change-Id: Iafdcc3e8891e80c120d270f6f04bb79a55092067 Reviewed-on: https://chromium-review.googlesource.com/700323Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#506511}
-
Mikel Astiz authored
When updating icon->page URL mappings, the code has historically associated icons to both the original page URL as well as the fragment-stripped page URL (for page URLs that contain a fragment/ref). This can cause "orphan" entries in the favicon database, i.e. mappings that don't have a corresponding history entry (because the page URL without a fragment was never actually visited). This means the history expirer will never take care of cleaning them up, leaking until the user clears all history. The original logic was introduced to fix crbug.com/498618 which is no longer reproducible even after this patch. With recent improvements in client-side redirect handling (e.g. https://chromium-review.googlesource.com/569760 or https://chromium-review.googlesource.com/595977), it is conceivable that these historical heuristics are no longer needed. Since this is hard to prove, we put the new behavior behind a feature than can be experimented via Chrome variations. Bug: 746268 Change-Id: Ieefb0fdb175d8858f1055af2dcc54df2e6f00a9a Reviewed-on: https://chromium-review.googlesource.com/649691 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#506510}
-
Wenzhao Zang authored
This is a superficial fix by checking |this.webview_.contentWindow|, but it's unknown why it is null. Two different scenarios were observed: 1) |Authenticator.onContentLoad_| is called with a non-null contentWindow (expected). 2) |Authenticator.onContentLoad_| is called with a null contentWindow, and is immediately called a second time with a non-null contentWindow. However, the first call already results in a failure and the page fails to load. This patch will temporarily fix this case. It's never observed that |Authenticator.onContentLoad_| is called only once with a null contentWindow . If that case happens, then this CL will make the page load successfully but without a |postMessage| call, and create additional issues. Bug: 711486 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ieec4ac33673df9b393792ec82ea034546b165b0f Reviewed-on: https://chromium-review.googlesource.com/700034 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
-
James Cook authored
We have not shipped Windows Ash for years. There is a 1:1 mapping between "use_ash" and "chromeos", so consolidate them. TBR=oshima@chromium.org for theme_resources.grd Bug: 673826 Test: compiles, bots Change-Id: If76122c1089cde2ec2b7d8822a4ca0adde25e5f3 Reviewed-on: https://chromium-review.googlesource.com/699663Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#506508}
-
Walter Korman authored
Bug: 771620 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2dc798906f16528b4e56b9f7c6bb7869327afb54 Reviewed-on: https://chromium-review.googlesource.com/700734Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Walter Korman <wkorman@chromium.org> Cr-Commit-Position: refs/heads/master@{#506507}
-
Mike Reed authored
TBR= Bug: Change-Id: I2e837413ced0b2befa77e6c8cff4b548cc574198 Reviewed-on: https://chromium-review.googlesource.com/685586 Commit-Queue: Mike Reed <reed@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Reviewed-by:
-
Michael Thiessen authored
This CL adds a VrDisplayHost with bindings to the renderer to route requests for presentation through the browser. (The next CL will move the focus-checking code from VrShellDelegate into the new VRDisplayHost) Bug: 768923 Change-Id: I88ae9797ebe8cbf182b117c2cd07cf91d8d09361 Reviewed-on: https://chromium-review.googlesource.com/692505 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#506505}
-
