GitLab

There isn't much more we can learn from this histogram.

See current data in
https://docs.google.com/document/d/18uYnVwLly7C_ckGsDbqdNs-AgAAt3AmUmn7wYLkyBN0/edit#heading=h.ithbu3taphzc

Fixed: 1037320
Bug: 1037320
Change-Id: I11f68499b623e4c5c89eff3822de0f93cb80d0ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003394Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732529}

I would like to use this value for the newer version of intrinsic-size, which
will allow "none" and fixed values, so renaming this to None will make
more sense for that.

Bug: 991096
Change-Id: I61b827800c502c635cc6549ad83bcc705da12732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004395
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732528}

This reverts commit 3109a771.

Reason for revert: crbug/1040374

Original change's description:
> linux: enable crashpad
> 
> This change disables Breakpad and enables Crashpad for Chrome_Linux. It
> should not affect other embedders or Chrome_ChromeOS.
> 
> Change-Id: I7017f1c6530fe58235e7ce955051b5b469e75244
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958693
> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#724394}

TBR=rockot@google.com,jperaza@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I61e3e205b730527133e668b5aeaab6d99ad8fb86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005059Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#732527}

QRScannerLegacyCoordinator had explicit CommandDispatcher property.
This CL updates it to use the preferred init for coordinators, which
provides a Browser instance which includes those parameters.

Bug: 1029346
Change-Id: Ib91ad76843f6af2960e4965639c2d1739cbd4315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003173
Commit-Queue: Nazerke Kalidolda <nazerke@google.com>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732526}

This change introduces the ash::kDisplayChangeModal feature and flag
to toggle the use of the display configuration change modal rather than
the notification. In addition, this change parametrizes the tests in
ResolutionNotificationControllerTest so that they are run with the flag
in both positions.

Change-Id: I9c52b618be412b8f3f41afe5bc3e256ac313932d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979015
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732525}

Bug: 1009158
Change-Id: I975c196c1f92201c1cb98c646bdffb7e12986ad0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994053Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732524}

blink.mojom.RemoteFrame is the target interface.

BUG=1041066
R=avi@chromium.org, dcheng@chromium.org, dtapuska@chromium.org, haraken@chromium.org

Change-Id: I8fafb5afb425b15bac4d97598130cb9c2c5dc911
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004690Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#732523}

Testing with Windows Narrator scan mode on Wikipedia showed we were
spending an inordinate amount of time comparing text positions due to
the cost of creating ancestor positions. This CL avoids that cost by
comparing the order of the first uncommon ancestors for each node, when
it's possible to do so.

Testing on https://en.wikipedia.org/wiki/List_of_highest-grossing_films
with Narrator scan mode heading movement showed a reduction of about 87%
CPU usage on the browser main thread with this CL.

Bug: 1029867
Change-Id: I7efae50517a561319dad81668c49ec5f6ae900b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999083
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Jacques Newman <janewman@microsoft.com>
Reviewed-by: Adam Ettenberger <adettenb@microsoft.com>
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#732522}

When the iframes are loaded in parallel, the ordering of the alert()
calls is not deterministic. This converts the test to testharness,
and loads the iframes serially to ensure determinism. If any of the
iframes fails to generate a load event, the test will time out.

BUG=1004650
R=clamy@chromium.org

Change-Id: I4c4c2f2bca388f2a157907029b155366cf27b4da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986958
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732521}

Currently, Breakpad will silently truncate a crash key name with a
length above the limit of 40 characters. Unfortunately, trying to
retrieve the value of the key with crash_reporter::GetCrashKeyValue()
will fail, as the truncated name is not used for retrieval.

This CL adds a DCHECK for the crash key length, to avoid having
other people chasing the same problem as me when writing a test
for crash keys.

Change-Id: I6f08ddcb5df9589b7604f34fbeb2dbb6573b1b20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999220
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732520}

Update chromium protos to match internal ones.

Bug: 1025781
Change-Id: I6c7c39d21d574e2e5f42cf51026a11e876946309
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005188Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732519}

BUG=1026343

Change-Id: Ibb517db781ceffd26e7f4fa9e00d087d9b814af3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004053Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732518}

1. Add a two-up view flag inside DocumentLayout::Options. Modify
   layout_test.js accordingly and add matching unit tests.
2. Add backend support for handling message type "setTwoUpView",
   which will update viewport's layout options and apply the changes.
3. Add unit tests for PDFiumEngine::SetTwoUpView().

Bug: 51472
Change-Id: I212418b439e860feb9e6ed8761a5f722f2a14a9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976156Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Hui Yingst <nigi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732517}

On older versions of dpkg-shlibdeps, the line was omitted rather than
being "shlibs:Depends=\n".

BUG=1041360
TBR=thestig
CC=​​​wuwang
NOTRY=true

Change-Id: I66263774564ac3df9c083d3a79a3de54bd1bfea6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004955
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732516}

Finch experiment is already 100% on stable, so enabling the feature by
default for now.
Will remove the flag if no more bugs are reported.

BUG=971366

Change-Id: I2323f995dc6e0bca68f2028be0c3014d260b5d56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004068Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732515}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/872b953d1955..ba0d9547be17

git log 872b953d1955..ba0d9547be17 --date=short --first-parent --format='%ad %ae %s'
2020-01-16 jettrink@chromium.org flash_ap: add dedede command support
2020-01-16 ahassani@chromium.org auto_updater.py: Be more gracious on AppID mismatches
2020-01-16 mmortensen@google.com Update generated proto api for goma changes in sysroot and common.
2020-01-16 achuith@chromium.org cros flash: Fix cros flash for public builders.
2020-01-16 chrome-bot@chromium.org Update config settings by config-updater.
2020-01-15 mmortensen@google.com Support stats and counterz file in goma_lib.LogsArchiver.
2020-01-15 chrome-bot@chromium.org Update config settings by config-updater.
2020-01-15 chrome-bot@chromium.org Update config settings by config-updater.
2020-01-15 kinaba@google.com Drop gandof and veyron_tiger from android-nyc-pfq.
2020-01-14 saklein@chromium.org depgraph_common_inheritance: Add script to explore generated depgraphs
2020-01-14 chrome-bot@chromium.org Update config settings by config-updater.
2020-01-14 yueherngl@google.com servo: add 12768.B firmware branch builder
2020-01-14 chrome-bot@chromium.org Update config settings by config-updater.
2020-01-14 mmortensen@google.com query_build_logs: Improve checking of target string.

Created with:
  gclient setdep -r src/third_party/chromite@ba0d9547be17

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: If5aae7421e236fdf8d809840c6718f4d621ff0b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003620Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732514}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=sorin@chromium.org

Bug: 1041419
Change-Id: Ic82a4501826f479afc5e84ac855350bc6d4edf7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997716
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732513}

Collect basic information as to whether the Mac is joined to a domain,
or if it is controlled by MDM.

Fixes: 1040630
Change-Id: Ie8de61e83dc6a4174311970a59798b451335b14f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994122
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732512}

Test: none
Bug: 1006973
Change-Id: Id1d113a806bbe91dded98392076753f4c76e6398
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002000Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732511}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=ejcaruso@chromium.org

Bug: 1041419
Change-Id: I03455b79948c4206b30450bb7b7d0a35e8c04784
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997911
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732510}

Bug: 1042644
Change-Id: Ib7e935618641a13999bf045646ac6a94682f5b1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003858Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Cr-Commit-Position: refs/heads/master@{#732509}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/df0e683b5835..f53792645f06

git log df0e683b5835..f53792645f06 --date=short --first-parent --format='%ad %ae %s'
2020-01-15 rharrison@google.com Use the correct comparison when checking for not MSL (#960)
2020-01-15 dneto@google.com Support Vulkan 1.2 (#958)

Created with:
  gclient setdep -r src/third_party/shaderc/src@f53792645f06

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com
Change-Id: I350e0a47d5324cc8b24b5ab6ecc2b0f2efb8d7b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003756Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732508}

When coverage instrumentation is enabled the compiler generates extra
symbols that are irrelevant to resource whitelisting. These should be
ignored so that they are not passed to llvm-undname, which cannot parse
them.

Bug: 1041689
Change-Id: Ia54300cc3b65c40ab4c20caa7a76623822fa97c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004328Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Sajjad Mirza <sajjadm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732507}

https://dawn.googlesource.com/dawn.git/+log/631f4258a1ac..f70786126c8b

git log 631f4258a1ac..f70786126c8b --date=short --first-parent --format='%ad %ae %s'
2020-01-16 rharrison@chromium.org Rolling 4 dependencies for Vk1.2 support integration

Created with:
  gclient setdep -r src/third_party/dawn@f70786126c8b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I8c6631e74f135d53c66a8f97e8c417e7cd256d8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004371Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732506}

Currently installation of PluginVM DLC will block if dlcservice doesn't
support PluginVM DLC - this verfies that PluginVM DLC is enabled for
callers that go through PluginVM usage workflow.

Temporary fallback:
Rootfs resident PluginVM is alongside PluginVM DLC, allowing
dlcservice errors other than |dlcservice::kErrorInvalidDlc| to
passthrough until the case of pure PluginVM DLC.

Bug: chromium:145814572
Test: unit_tests --gtest_filter=PluginVm*
Change-Id: I0e024811e800f2aacdeed6514f62e0cc116d1ac2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001942
Commit-Queue: Jae Hoon Kim <kimjae@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Auto-Submit: Jae Hoon Kim <kimjae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732505}

Extend TextFragmentAnchor metrics until the end of 2020. These metrics
will continue to be useful through the launch of the feature and
subsequent changes.

Bug: 1037336
Change-Id: Ia920cf2b5a3bd7dabff703c263f6a45f27efa013
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001067Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732504}

https://webrtc.googlesource.com/src.git/+log/6ca908f48c88..4c1086a36ade

git log 6ca908f48c88..4c1086a36ade --date=short --first-parent --format='%ad %ae %s'
2020-01-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 374f209d..7356cb88 (732255:732376)
2020-01-16 kron@webrtc.org Add processing time to VideoFrame
2020-01-16 hbos@webrtc.org Improve DTLS logging.
2020-01-16 jonaso@webrtc.org Make it possible to inject IceTransport in pc quality test fixture
2020-01-16 danilchap@webrtc.org Remove higher_spatial_layers from RTPVideoHeader structure as unused.

Created with:
  gclient setdep -r src/third_party/webrtc@4c1086a36ade

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1011581,chromium:1024965
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I57f216814bbff3445e9c7d27a3930bc61696f425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004899Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732503}

This CL encapsulates the process of scanning a download and reporting the result to the download
UX. This will be shared between APP scanning and the new enterprise scanning.

Bug: 1020418
Change-Id: Iacb702e0829df8cf03228ede64bcea6a5726d585
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993627
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732502}

At low sample rates, errors due to float->integer rounding can be
significant when converting from frame count to microseconds. This CL
fixes the rounding to be more accurate.

Bug: internal b/147111664
Change-Id: I77f8eab4fa8a25ec50c7617b8910f51db47741f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003925Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732501}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d5722304fcfc..57a0ce4db871


Created with:
  gclient setdep -r src-internal@57a0ce4db871

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1024588
Tbr: jbudorick@google.com
Change-Id: I14c7a43f035158bae5865b5ff0d9ef79a7953c99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004373Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732500}

This target is broken with the latest Fuchsia SDK. Since we do
not currently run the tests it contains, and the compilation
will take some time to resolve, disable compile until it can
be fixed, and the tests re-enabled.

Bug: fuchsia:44191
Change-Id: Ia2325d6e0536bbf7599a06983a65d2833207cba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002822Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732499}

Bug: None
Change-Id: I9c7704b09d56adcd68de6da1587566148f505e4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975888
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732498}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=glider@chromium.org

Bug: 1041419
Change-Id: I1eb878817e27ccfb5811a4aacd9b68d374fbe10d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997002
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732497}

CL generated with:

$ git ls-files 'chrome/browser/ui/webui/*.js' | xargs grep -l -P ' [!=]= (?!null)' | xargs perl -p -i -e 's/ ([!=])= (?!null)/ \1== /g'
$ git ls-files 'chrome/browser/ui/webui/*.js' | xargs -I{} tools/web_dev_style/eslint.py --fix {}
$ git cl format --js

Bug: 720034
Change-Id: I7b0e24eaba3f8c87dbf6abcb22b34afb13e88106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003640
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732496}

- Gives shared access to the findDifference function.

Bug: 1015628
Change-Id: I25fe0954df1e3a6aa784cce9611f2f14086e1f89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004008Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732495}

This reverts commit 315f9a8f.

Reason for revert: The new plus button doesn't work as expected. http://crbug.com/1042606

Original change's description:
> Use NewTabButton for new tab variation in GTS
> 
> Bug: 1042015
> Change-Id: Ic1ad4c0902725bc0a096b72f05f5fab92ef9d4d0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001265
> Auto-Submit: Yue Zhang <yuezhanggg@chromium.org>
> Reviewed-by: Theresa  <twellington@chromium.org>
> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#731803}

TBR=twellington@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1042015
Change-Id: I7069b577daa0a0b5ab271e08b481599a422db253
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003621Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732494}

The crash happens when a tab updates after model switched. The updated
tab does not exist in the current TabModel, therefore a null is returned
when we try to locate the selected tab. The simple fix is to null check
before we access the tab.

This CL also hides the onUrlUpdated logic behind the
TabGroupsContinuation flag.

Change-Id: I81090666328158f8a5a5e37459c54e48d0ef6325
Bug: 1035301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996130
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732493}

In our PaintRenderingContext2D, there is a effective_zoom_ which
captures the device_scale_factor + browser zoom. The transform matrix
in the rendering context need to integrate the effective_zoom_ such
that when all the drawings could do the transformation correctly.
This is why currently the implementation of setTransform has
effective_zoom_ explicitly included.

The problem is resetTransform, where the base class version just
set the transform matrix to identity. This is wrong for PaintWorklet
because we need to account for the effective_zoom_.

Now we can not explicitly put the effective_zoom_ in the
resetTransform. This about the following JS call:
  resetTransform();
  setTransform(2, 0, 0, 2, 0, 0);
In this case, we will have resetTransform that integrates the
effective_zoom_ once, and setTransform integrates it again.

So the solution is remove the integration of effective_zoom_ in
the setTransform and put that integration in the resetTransform.
This is fine because setTransform in the base class calls the
resetTransform, and so this makes sure that the effective_zoom_
is integrated once only.

Bug: 1029360
Change-Id: I1a143884803b2e831e26af34386aa3f5532f2c5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999285Reviewed-by: Yi Gu <yigu@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732492}

In order to migrate java.net.URI to GURL the junit tests that rely on
java.net.URI need to be moved to a test apk that supports the native
library.

This change moves the ToolbarSecurityIconTestunittests from junit to
unit_tests (Android only). These tests should be just as fast as they
were as junit tests (and much faster than chrome_test_apk unit tests).

Bug: 783819
Change-Id: I9e397ff1260cce9fca375af212dbac9e360e31f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997640
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732491}

No obvious reason why it only fails on Win 10 and Mac.

TBR: fs@opera.com
Bug: 1042453
Change-Id: Ie983b8a1e8668bd8396640ff6fd35a7b413622e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004950Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732490}