- 14 Jun, 2018 40 commits
-
-
Xi Han authored
When ServiceManager starts, it needs to post sequence tasks. Therefore, we need to create a TaskScheduler and setup the MessageLoop for the main thread. Pariculaly for mac, the Mac registaration of NSApp now happens before EarlyInitialization. The registration has been moved from BrowserMainParts::PreMainMessageLoopStart() to ContentMainDelegate's subclasses which implement ContentMainDelegate::PreMainMessageLoopStart(). This is required by a follow up CL: https://chromium-review.googlesource.com/c/chromium/src/+/1058131/ Change-Id: Ic67dace05b82fc44d6ab6d480ba0fecffe58fbf8 Reviewed-on: https://chromium-review.googlesource.com/1072387Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#567244}
-
Myeongjin Cho authored
The maximum compressed size of each MSZIP block is 32k + 12 bytes. So that means the size can be 32k + 12 bytes. However, the assert checks as follows. assert compressed_size < chunk_size + 12 Reference : https://msdn.microsoft.com/en-us/library/ee178063(v=exchg.80).aspx Bug: None Change-Id: I0d991be2909f4447144fccad83155c5967382557 Reviewed-on: https://chromium-review.googlesource.com/1074768 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#567243}
-
Patrick Monette authored
This is a reland of 66d17ca7 Original change's description: > Make the ThirdPartyModulesBlocking feature work on all Windows versions > > Change-Id: I0118d26fe9b7f11f2608dd66c10418e210393733 > Reviewed-on: https://chromium-review.googlesource.com/1083842 > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566516} Change-Id: Ie4c6c3767af38efe50e42012aa5f65fb480fac56 Reviewed-on: https://chromium-review.googlesource.com/1099976Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#567242}
-
Sigurdur Asgeirsson authored
Change-Id: I9695d4c554ce45c339282dcd2c70adc1e83da557 Reviewed-on: https://chromium-review.googlesource.com/1099257 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#567241}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I847557277cd65eb48dd9d9ae5b5b27dc7e56d110 Reviewed-on: https://chromium-review.googlesource.com/1100898Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#567240}
-
Francois Doray authored
Sample failure: [ RUN ] ExtensionCrashRecoveryTest.ReloadIndependently ... ../../chrome/browser/extensions/extension_crash_recovery_browsertest.cc(92): error: Value of: extension Actual: false Expected: true Stack trace: Backtrace: StackTraceGetter::CurrentStackTrace [0x00007FF7EE199480+80] testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00007FF7EE1B2BAA+90] testing::internal::AssertHelper::operator= [0x00007FF7EE1B26AA+90] ExtensionCrashRecoveryTest::CheckExtensionConsistency [0x00007FF7EDDE8C20+304] ExtensionCrashRecoveryTest::LoadTestExtension [0x00007FF7EDDE8204+692] ExtensionCrashRecoveryTest_ReloadIndependently_Test::RunTestOnMainThread [0x00007FF7EDDE9D37+103] https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8943749196042516896%2F%2B%2Fsteps%2Finteractive_ui_tests__experimental__on_Windows-10-15063%2F0%2Fstdout TBR=karandeepb@chromium.org Bug: 846172 Change-Id: I56a0318d765f9a2b36a4a52e46f59e60ac9afd30 Reviewed-on: https://chromium-review.googlesource.com/1100352Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#567239}
-
Vadym Doroshenko authored
This CL implements filling based on WebForm and WebFormControlElement unique renderer ids instead of complicated heuristics that are used currently. This CL contains: 1.Adding renderer ids to PasswordForm and PasswordFormFillData classes 2.Adding MOJO for PasswordFormFillData 3.Setting renderer ids in FormParser 4.Setting renderer ids in password_form_fill_data.cc 5.Filling using renderer ids in PasswordAutofillAgent - extracting to separate methods common code between new and old filling - implementing finding username/password elements by renderer ids. Bug: 831123 Change-Id: Ie29964db51014b140e806a6e3f78c9c854a8df34 Reviewed-on: https://chromium-review.googlesource.com/1090729Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#567238}
-
Takuto Ikuta authored
Reduces the max shard duration of net_unittest on the asan/tsan builders by about 50%. https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/9077ec7efe5b..ce468a17c434 $ git log 9077ec7ef..ce468a17c --date=short --no-merges --format='%ad %ae %s' 2018-06-13 misterg Docs sync/internal 2018-06-13 misterg Doc sync/internal 2018-06-12 tikuta Reduce the number of strcmp calling while initialization 2018-06-11 misterg Sync with internal docs 2018-06-11 misterg Sync with internal docs Created with: roll-dep src/third_party/googletest/src R=dpranke@chromium.org,thakis@chromium.org BUG=794372 Change-Id: I704490e983697784fcc73c6fa7462bfb35a0694e Reviewed-on: https://chromium-review.googlesource.com/1100670 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b57a861f183b..f018b7d607a0 git log b57a861f183b..f018b7d607a0 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 brianosman@google.com SkColorSpaceXformSteps improvements and tests Created with: gclient setdep -r src/third_party/skia@f018b7d607a0 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I61f2b001fcce3b2d58ffd49d61400e2ba4185bf4 Reviewed-on: https://chromium-review.googlesource.com/1100699Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567236}
-
tzik authored
https://crrev.com/8f14a9d0b7c593e0 enabled opt-in [[nodiscard]] on STL on Windows build, however, it's unavailable on cl.exe in C++14 mode. https://ci.chromium.org/buildbot/chromium.fyi/WinMSVC64%20Goma%20Canary/7727 This CL disables it back on cl.exe. Bug: 852240 Change-Id: Ibfda257eadd6e188f7baa0472785bd3092e76600 Reviewed-on: https://chromium-review.googlesource.com/1100602Reviewed-by:
-
Stephen McGruer authored
Previously if the scroll source was not initially composited then the cc-side ScrollTimeline would never get a valid ElementId. This CL fixes that; we now update the cc side ScrollTimeline every time the scroll source changes compositing state. Bug: 776533 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0e8e37d867c4a4708fee6f4d0adf6e6e86ecfaff Reviewed-on: https://chromium-review.googlesource.com/1055881 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#567234}
-
Yuki Shiino authored
Files directly under platform/ (not in platform/*/) should find the right home. In case of decimal.h, the right home should be platform/wtf/. No-Presubmit: true Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I798c61809332b09bf428297d31b0a757177876be Reviewed-on: https://chromium-review.googlesource.com/1100730Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#567233}
-
Vaclav Brozek authored
The FormData -> PasswordForm password needs to distinguish three levels of interactability of fields: fields already interacted with, fields likely to be interacted with, and those which are unlikely. This is what the old parser in password_form_conversion_utils.cc called filtering levels. The interactability is useful when identifying whether an obtained result is potentially useful. Also, the structural analysis only should consider the fields with best interactability. This CL introduces the concept of interactability and restricts the structural analysis ("base heuristics") to fields with best interactability. The CL does not introduce interactability-based penalties yet, because the confidence rating is not implemented yet. (See details in the design doc linked from the bug description.) Bug: 845426 Change-Id: Ib0dd2f9837c537e4d64432a35b7ba2f5f8e72403 Reviewed-on: https://chromium-review.googlesource.com/1099060Reviewed-by:Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#567232}
-
Luke Bjerring authored
Bug: 851320 Change-Id: I562fe492be73b0ad8929d8ae8be158230103157f Reviewed-on: https://chromium-review.googlesource.com/1095640Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Luke Bj <lukebjerring@chromium.org> Cr-Commit-Position: refs/heads/master@{#567231}
-
vasilii authored
layoutSubviews is called continuously when scrolling is happening. We shouldn't set a scrolling position there. Bug: 843557 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I16891bfbcf4eb2f30c4b7f2ad86275a1cc2f7cb8 Reviewed-on: https://chromium-review.googlesource.com/1078871 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#567230}
-
Farah Charab authored
Describes the grammar of the v0 task queue manager fuzzer input using a protocol buffer. This grammar describes a test that can test the following interfaces: * Creating a task queue. * Posting a (delayed) task with a given duration. * Doing the above from within a task. Bug: 852076 Change-Id: Ie33637eff3d953c814a7c40185d709a6bfc1f791 Reviewed-on: https://chromium-review.googlesource.com/1097327Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Farah Charab <farahcharab@chromium.org> Cr-Commit-Position: refs/heads/master@{#567229}
-
Noel Gordon authored
Add coverage for Drive to the openQuickView<VolumeType> test group. Test: browser_test --gtest_filter="QuickView/FilesApp*" Bug: 836254 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibf081b03ebcb069274c83d00da1d2703649bb04d Reviewed-on: https://chromium-review.googlesource.com/1098913Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#567228}
-
Daniel Vogelheim authored
Change-Id: Id7b395474a612200ad83ace5a44ced22a8612087 Reviewed-on: https://chromium-review.googlesource.com/1086798Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Vadym Doroshenko authored
In order to support filling with using server-side predictions NewPasswordFormManager should wait for them. This CL introduces waiting for filling up to 500 ms, if for this time no server predictions received NewPasswordFormManager fills without server support. Bug: 831123 Change-Id: I7031ba03ab0229ed41de7869a1379a83ccd82259 Reviewed-on: https://chromium-review.googlesource.com/1091056 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Naoki Fukino authored
The gear menu option "Show hidden Play folders" doesn't make sense when the "Play Files" volume is not mounted. The option should be visible only when the corresponding volume is mounted. Bug: 851385 Test: Manually tested on Eve. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5f39a669890c455cbd9763a6d0d047854545acca Reviewed-on: https://chromium-review.googlesource.com/1100721 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Disabling the test as it very occasionally fails. Bug: 852690 Change-Id: I17164a945d1ae99b3af9245af743af695d6737dc TBR: primiano@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1100822Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#567224}
-
Findit authored
This reverts commit 326c044a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 567162 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzMyNmMwNDRhMzBjY2M1MzIyNmEwMDhhMjY1MDA3ODVkZmEwZDZlZjkM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/10407 Sample Failed Step: viz_content_browsertests Original change's description: > Display Cutout: Notify the browser process on fullscreen frame change > > Notify the browser process when the frame owning the current > fullscreen element is changed. > > Design: https://docs.google.com/document/d/1j3jqmGRXAHzpeKeS_tLlOo4C9DsrvPOf_-PMnFzTmeE/edit#heading=h.wozo6ynsdlp3 > > BUG=838400 > > Change-Id: I7771f7b58a8c1cdb7ec0b89b30db1de1fe708b32 > Reviewed-on: https://chromium-review.googlesource.com/1054441 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567162} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=838400 Change-Id: Ifd09d76dcd36d3fe257c8f1a1d6c9a573e86d5e8 Reviewed-on: https://chromium-review.googlesource.com/1100837 Cr-Commit-Position: refs/heads/master@{#567223}
-
Darren Shen authored
The occluded bounds is stored in the fullscreen container and retreived to ensure caret in work area. Also updated the places to notify the correct occluded bounds for the new container mode. Bug: 826617 Change-Id: Iafe3dcf291975b586dece39ee6e07bb3f7f49dba Reviewed-on: https://chromium-review.googlesource.com/1036867 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#567222}
-
Colin Blundell authored
This API allows test clients to populate an account from an email address with IdentityManager and its backing classes. It is conceptually similar to IdentityTestEnvironment::MakePrimaryAccountAvailable(). Bug: 798699 Change-Id: Iffaae9f989a37de3e406ccc10166ce44c7ed6bdb Reviewed-on: https://chromium-review.googlesource.com/1099057 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#567221}
-
Hajime Hoshi authored
This CL is a continuation of https://chromium-review.googlesource.com/c/chromium/src/+/1088356. This CL gives an event target to EventQueueImpl and use it instead of event->target() so that we can have EventQueueImpl and MediaElementEventQueue with the same structure. Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# Bug: 846618 Change-Id: I394e3b1c01df3a2af671bb6d72fe9d32ac9ea94e Reviewed-on: https://chromium-review.googlesource.com/1098736Reviewed-by:
-
stkhapugin@chromium.org authored
Adds a tint to the leading image view, and moves color- and font-related code from coordinator to view controller. Bug: 819235 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icd9c6f54d6d8b6e35eb9bc4803b42a3dbfd0bbf6 Reviewed-on: https://chromium-review.googlesource.com/1099380 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#567219}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7d4d6b816c28..b57a861f183b git log 7d4d6b816c28..b57a861f183b --date=short --no-merges --format='%ad %ae %s' 2018-06-14 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 4cc753e01054..d668be9ce66f (1 commits) Created with: gclient setdep -r src/third_party/skia@b57a861f183b The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I749d5e987c923bf960ff3ee33cf3da6cd587b372 Reviewed-on: https://chromium-review.googlesource.com/1100696Reviewed-by:
-
Yuichiro Hanada authored
This CL also removes obsolete entries: - bshe@ (no longer working on VK) - bryeung@ and kevers@ (no longer in Chrome team) - sadrul@ (already the owner of the parent directory) Bug: None Change-Id: Ia49203ff7fd65a22fe1fa9aff0b38e8bf5257337 Reviewed-on: https://chromium-review.googlesource.com/1098433 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#567217}
-
David Roger authored
Site isolation for Gaia is now launched at 100%, and we can remove the codepath that was used when site isolation was disabled. In particular, after https://chromium-review.googlesource.com/c/chromium/src/+/1096664 the GaiaOriginIsolatedCallback always returns true, and can be removed. TBR=blundell Change-Id: If41007a3fc0b94c58a56f8f58a35f034861ae015 Reviewed-on: https://chromium-review.googlesource.com/1100466 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#567216}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b4ddfe4f..d791a8f5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I40d2a424c71adcc34382fbf35ce543949f150a33 Reviewed-on: https://chromium-review.googlesource.com/1100681Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#567215}
-
Stefan Zager authored
Conversion between 'frame' and 'contents' coordinate spaces is now a no-op. This CL settles on 'frame' as the term d'art for the coordinate space of the frame, so ViewportToContents becomes ViewportToFrame, and vice versa. Also, this adds a couple of missing float overrides for still-useful conversion methods. Arbitrarily converting between LayoutUnit and float can be a source of bugs. BUG=823365 R=skobes@chromium.org,bokan@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id687f88988e6e27ea75027026377d9464bee3406 Reviewed-on: https://chromium-review.googlesource.com/1099996 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#567214}
-
Mikel Astiz authored
Prior to this patch, TabContentsSyncedTabDelegate was itself a tab helper (WebContentsUserData) that was created on all platforms, with the whole purpose to reuse a partial implementation of sync_sessions::SyncedTabDelegate. This was a bit weird because a) The life cycle diverges across platforms: created lazily on Android, early otherwise. b) On Android there was no real need to register a tab helper. c) On Android, it's weird to reason about two tab delegates coexisting, one of which is a proxy but also overrides some logic. Instead, let's make TabContentsSyncedTabDelegate a base class that is *NOT* a WebContentsUserData, and let platform-specific subclasses decide whether they want to register as WebContentsUserData, as well as which logic they need to override. This also removes code that is dead on some platforms, because the base class is abtract and doesn't implements all methods (as opposed to a proxy object which cannot be abstract). Bug: 851905 Change-Id: I305ad85e2392fdd2ce428c0464b7750ac599babf Reviewed-on: https://chromium-review.googlesource.com/1097405 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Tatiana Gornak authored
TBR=dtrainor@chromium.org Bug: 852073 Change-Id: I59017409e79bcddce615de5a820f1424f34eedbc Reviewed-on: https://chromium-review.googlesource.com/1098917Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#567212}
-
Sylvain Defresne authored
Those fields are never accessed after initialization (except for destruction). Remove the fields also track preferences that are unused on iOS (they are related to managed accounts which is not supported on iOS). Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I13f86b143d34fd0ba07d4372ff0e37133e0e2213 Reviewed-on: https://chromium-review.googlesource.com/1097334 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567211}
-
Findit authored
This reverts commit 6bc98f91. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 566961 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzZiYzk4ZjkxODRkYjQzZmFlYWE5N2YwODZhMTFlYmEyNGZkMWMxZjkM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27907 Sample Failed Step: unit_tests Original change's description: > Add server token revocation in AccountManager > > Bug: 820046 > Test: chromeos_unittests --gtest_filter="*AccountManager*" > Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*" > Change-Id: I017bb9e9f9ed789d77235336be8fa465fd4289b8 > Reviewed-on: https://chromium-review.googlesource.com/1087455 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Lutz Justen <ljusten@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: Kush Sinha <sinhak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566961} Change-Id: Ie71a2d159ed50aa3196bf43b488877747b1f88b8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820046 Reviewed-on: https://chromium-review.googlesource.com/1100515 Cr-Commit-Position: refs/heads/master@{#567210}
-
David Roger authored
The guard was present in the .h, but not in the .cc. This CL adds the misssing guard in the .cc. Change-Id: I8716cbad52dd2f578cf730b41118ebbb554fc480 Reviewed-on: https://chromium-review.googlesource.com/1100470Reviewed-by:
-
Kush Sinha authored
This reverts commit 94c42a4f. Reason for revert: To unblock https://chromium-review.googlesource.com/c/chromium/src/+/1100515 Original change's description: > Code Cleanup: Dedup usages of AccountManager's URL Context > > |InlineLoginHandlerChromeOS| and |ChromeOSOAuth2TokenServiceDelegate| > use the system URL context because they 'know' that AccountManager is > going to use the same. This is a leaky abstraction. > > Add a method in AccountManager that returns its URL Request Context. > This request context happens to be the system URL context for now. > > Bug: 820046 > Change-Id: I668769167893c995f73df63acc575eb410c0f986 > Reviewed-on: https://chromium-review.googlesource.com/1088617 > Commit-Queue: Kush Sinha <sinhak@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Lutz Justen <ljusten@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566998} TBR=xiyuan@chromium.org,ljusten@chromium.org,sinhak@chromium.org Change-Id: I57c56e1cde479c6544f93c42061cfc6eec08254e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820046 Reviewed-on: https://chromium-review.googlesource.com/1100775Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#567208}
-
Michael Lippautz authored
Bug: chromium:847679 Change-Id: I36061d52a69fb89ce3d4a224904be39c82c40d59 Reviewed-on: https://chromium-review.googlesource.com/1098746 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
This CL also marks WebThreadScheduler::DefaultTaskRunner main-thread only. Change-Id: Ia2b8d962c78a4cf426c1ecc1010d728b58c45e4a Reviewed-on: https://chromium-review.googlesource.com/1100603Reviewed-by:
-
Makoto Shimazu authored
Bug: 852202, 669772, 806658 Change-Id: Ife9c41fbe08c1f414bb5459cba29d98d7e1fb892 Reviewed-on: https://chromium-review.googlesource.com/1098650 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#567205}
-
