- 04 Aug, 2018 25 commits
- 
- 
Chromium WPT Sync authoredUsing wpt-import in Chromium 3671fec0. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22286 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dcheng@chromium.org, scottmg@chromium.org: external/wpt/domparsing eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer rijubrata.bhaumik@intel.com, mcasas@chromium.org: external/wpt/html-media-capture tdresser@chromium.org: external/wpt/hr-time external/wpt/navigation-timing TBR=foolip No-Export: true Change-Id: I5eb61e8b039845d861dd2339ffaf07f571d73c66 Reviewed-on: https://chromium-review.googlesource.com/1162965 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#580734} 
- 
Emircan Uysaler authoredThis is the first CL in adding getDisplayMedia() support in chromium. See the bug and linked design doc for the detailed plan. This CL adds getDisplayMedia() interface behind runtime enabled features flag "GetDisplayMedia". This call will use the same call stack as getUserMedia() but have different media request type and handling of constraints. - Adds WebUserMediaRequest enums to differentiate this call. - Adds specific handling of constraints in UserMediaRequest::Create(). As defined in the spec, this accepts empty constraints. - Currently ends up in a NotSupported error as chromium changes are landing. - Adds first set of Layout Tests to check these expectations. Intent To Implement: https://groups.google.com/a/chromium.org/forum/#!msg/Blink-dev/j7k2nI_9nng/OE6IvgJyAQAJ Bug: 326740 Change-Id: I03c54cab259a57db99449d9c4510c484f22c5b93 Reviewed-on: https://chromium-review.googlesource.com/1155942Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580733} 
- 
John Abd-El-Malek authoredchrome_rlz_tracker_delegate.cc depended on browser_process.h which had transitive dependencies on generated mojoms. But it didn't get the public_deps because the rlz target didn't depend on chrome/browser to avoid circular dependencies. Fold it into chrome/browser to fix this properly. This does mean that the one unit test in chrome_rlz_tracker_delegate_unittest.cc will not run on chromium-branded bots anymore. That seems better than having flaky dependencies, since untangling the build dependencies looks like a lot of work. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1161610 with official Google ChromeOS build fix. TBR=avi Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng Change-Id: If1cbab605ee0f14ec4c942d0c4b03b318e7d3c41 Reviewed-on: https://chromium-review.googlesource.com/1162922Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#580732} 
- 
Chromite Chromium Autoroll authoredhttps://chromium.googlesource.com/chromiumos/chromite.git/+log/3387250e88bc..4e706b495ebe git log 3387250e88bc..4e706b495ebe --date=short --no-merges --format='%ad %ae %s' 2018-08-03 xixuan@chromium.org chromeos_config: Move nyan_blaze-release to Skylab for testing. Created with: gclient setdep -r src/third_party/chromite@4e706b495ebe The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie7b6b591483e8a1d699fc8c64c16c0a4c6c90762 Reviewed-on: https://chromium-review.googlesource.com/1162808Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580731} 
- 
kristipark authored"ntp-ui-md" should no longer enable Material Design for Most Visited. "ntp-icons" should implicitly enable "ntp-ui-md". "ntp-custom-links" should implicitly enable "ntp-icons". Change-Id: I43f5b0fa564c955e58b28f949635009ab0b1db5c Reviewed-on: https://chromium-review.googlesource.com/1160786 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#580730} 
- 
Yuri Wiitala authoredMigrates all client-side mouse cursor rendering code to stop using the old content::CursorRenderer and instead use the new content::MouseCursorOverlayController+viz::FrameSinkVideoCaptureOverlay system. Testing: Tested mouse cursor rendering behavior on Win+Mac+CrOS+Linux for both tab capture and browser window capture, and also desktop capture on CrOS. Bug: 810133 Change-Id: Ibb0fd28a8e1ea99a9ca27d9940af3f46bd48d6ce Reviewed-on: https://chromium-review.googlesource.com/1162828Reviewed-by: Xiangjun Zhang <xjz@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#580729} 
- 
Sergey Ulanov authoredAfter https://crrev.com/580342 fuchsia runner scripts redirects system log to serial port and captures if from qemu stdout. It also closes the stdout stream after the system is booted. In some cases this causes qemu die later. With this change the stdout pipe is redirected to /dev/null instead of being closed. Change-Id: I37bcc744d4ca0cb72ac1dffd3d436c3675c951eb Reviewed-on: https://chromium-review.googlesource.com/1162864 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#580728} 
- 
skia-chromium-autoroll authoredhttps://skia.googlesource.com/skia.git/+log/b33f9ebe9057..607be37e3d4d git log b33f9ebe9057..607be37e3d4d --date=short --no-merges --format='%ad %ae %s' 2018-08-03 bsalomon@google.com GrGeometryProcessor derives from GrNonAtomicRef not GrProgramElement. 2018-08-03 benjaminwagner@google.com Update Skolo Win bots. 2018-08-03 ethannicholas@google.com improved SkSL lexer performance 2018-08-03 fmalita@chromium.org [skottie] Avoid redundant instantiation of image asset nodes 2018-08-03 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 81f891d043cb..b8430dd749b0 (2 commits) 2018-08-03 borenet@google.com [infra] Add new go_deps asset 2018-08-03 brianosman@google.com Fix GUI windows not appearing on first key in viewer 2018-08-03 bsalomon@google.com Blacklist glyph_pos_h_b on gltestpersistentcache config 2018-08-03 kjlubick@google.com Retrain Infra Expectations 2018-08-03 bsalomon@google.com Move GrGeometryProcessor's textures out of classes and into 2018-08-03 benjaminwagner@google.com Use XCode from CIPD. Include xSAN dylibs in Build task isolated output. 2018-08-03 robertphillips@google.com Update GrTextureStripAtlas for DDLs (take 2) 2018-08-03 robertphillips@google.com Recreate Android porter-duff blend modes 2018-08-03 kjlubick@google.com Add Debug version of PathKit 2018-08-03 brianosman@google.com Clean up code for custom slide GUIs 2018-08-03 robertphillips@google.com Make ColorTableEffect no longer use the texture strip atlas Created with: gclient setdep -r src/third_party/skia@607be37e3d4d The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Ibd252689d6d0196cce0060f7760032ea4042b2e7 Reviewed-on: https://chromium-review.googlesource.com/1162563Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580727} 
- 
Erik Luo authoredAll ObjectPropertiesSections call 'hideOverflow()', to avoid overflow in the OPS's title (to adress crbugs 571759,571767). However, hideOverflow does not hide overflow due to children, which causes horizontal scrolling in Console. This CL makes hide overflow in properties for all OPS except JSONView. Screenshot: https://imgur.com/a/x51xJNJ Bug: none Change-Id: Ie78f48cd873fd1d61b27c17e76683a4f7031aee8 Reviewed-on: https://chromium-review.googlesource.com/1162913Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#580726} 
- 
Philip Rogers authoredDue to https://crbug.com/870857, we cannot mark directly composited image layers as opaque. https://crrev.com/556288 started setting prevent_contents_opaque_changes_ for directly-composited image layers which exposed this bug. Bug: 868779 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9fb0fe4361bd8fd39529bbf698f7549edbc51faf Reviewed-on: https://chromium-review.googlesource.com/1162750 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#580725} 
- 
Ned Nguyen authoredBug:870692,757933 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ifc70a71cf4ddb2628038b45b51a57381a2a41c3a NOTRY=true # CQ flake Change-Id: Ifc70a71cf4ddb2628038b45b51a57381a2a41c3a Reviewed-on: https://chromium-review.googlesource.com/1162584 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: David Tu <dtu@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#580724} 
- 
Simeon Anfinrud authored* Behaviors specific to Controller are in a dedicated test. * Each operator on Observable gets its own test file. * Simplify ReactiveRecorder. * Rename entered() and exited() to opened() and closed(). * Only watch one Observable per ReactiveRecorder. * Add an unsubscribe() method to test that scopes close. * Improve documentation in reactive_java.md. * Add equals() method to Both so assertions are more useful. * Also added a hashCode() method for completeness. * Use ReactiveRecorder more heavily than ArrayLists. Bug: None Test: cast_base_junit_tests, cast_shell_junit_tests Change-Id: I2edd4627abe18523eb34482c648f8c15ffbfd89e Reviewed-on: https://chromium-review.googlesource.com/1161459Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#580723} 
- 
Chromite Chromium Autoroll authoredhttps://chromium.googlesource.com/chromiumos/chromite.git/+log/fb6f97363738..3387250e88bc git log fb6f97363738..3387250e88bc --date=short --no-merges --format='%ad %ae %s' 2018-08-03 dgarrett@chromium.org Revert "workspace: Use a reference repo if available." Created with: gclient setdep -r src/third_party/chromite@3387250e88bc The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8d5e41c1da651cdd296c1e5560a6fcdf09287f05 Reviewed-on: https://chromium-review.googlesource.com/1162804Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580722} 
- 
Scott Haseley authoredThe last few task types added to the blink::TaskType enum were not added to enums.xml causing the raw value to appear in histograms. Change-Id: I8e2e3b93d939ffd41a68fc3342ef8c390aaa16f6 Reviewed-on: https://chromium-review.googlesource.com/1162914Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Scott Haseley <shaseley@google.com> Cr-Commit-Position: refs/heads/master@{#580721} 
- 
Xiaohui Chen authoredBug: b:110418485 Test: build and run locally, see ring status change. Change-Id: Id0e6d6d2cd85b7774feb19cc4dba665eb5b358cc Reviewed-on: https://chromium-review.googlesource.com/1162829 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#580720} 
- 
James Cook authoredThe crash appears to be an accessibility change event triggered by an aura::Window visibility change in the middle of a views::Widget close. I have not been able to reproduce. AXRemoteHost owns the AXTreeSource and AXTreeSerializer in the remote app process. Change it to stop sending AX node tree updates to the browser process earlier in Widget close. Also add a defensive null check for a missing widget, explicit cleanup of the AXRemoteHost slightly earlier during remote process shutdown, and some DCHECKs. Bug: 869608 Test: added to views_mus_unittests Change-Id: I5a69557382f457258d619e61342ddeca8a57aaf0 Reviewed-on: https://chromium-review.googlesource.com/1162520Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#580719} 
- 
angle-chromium-autoroll authoredhttps://chromium.googlesource.com/angle/angle.git/+log/b8430dd749b0..a6d34af67286 git log b8430dd749b0..a6d34af67286 --date=short --no-merges --format='%ad %ae %s' 2018-08-03 geofflang@chromium.org StateManagerGL: Use arrays to store texture and sampler bindings. Created with: gclient setdep -r src/third_party/angle@a6d34af67286 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I5a87f48722aaeea6a19e3b68f364aef9e91d6a31 Reviewed-on: https://chromium-review.googlesource.com/1162389Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580718} 
- 
Yue Li authoredBug: None Test: Manual Test Change-Id: Ie0ba773afbbc38c19130f5d0fccf94558f087ac7 Reviewed-on: https://chromium-review.googlesource.com/1162937 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#580717} 
- 
Byoungkown authoredThe return value syntax in idl wasn't support by out WebIDL. But now, WebIDL support the syntax, so we need to fix them. It was modified according to xr spec[1],[2]. [1] https://immersive-web.github.io/webxr/#xr [2] https://immersive-web.github.io/webxr/#contextcompatibility Bug: None Change-Id: I62ef8896178704df4e60204613ab0e5b9e01f54f Reviewed-on: https://chromium-review.googlesource.com/1160834Reviewed-by: Brandon Jones <bajones@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#580716} 
- 
Erik Chen authoredWe currently front-load construction of the font cache [which takes 600ms] from test run time to compile time. This saves 600ms on each test shard which uses the font cache. The problem is that fontconfig cache construction is not intended to be deterministic. This CL sets some external state to ensure deterministic output. We have no way of guaranteeing that this produces correct results, or even has the intended effect. I personally think we should get rid of this step entirely. The time saved per test shard is not worth the developer time it takes to try to make fontconfig cache output deterministic. This CL makes two changes: * Pregenerates a fixed uuid in the test_fonts directory. * Sets the mtime of the test_fonts directory to a date far in the past. This CL also fixes the gn steps to correctly specify data outputs so the isolate will actually pick up all the output. Future rolls of fontconfig may break build determinism again. Hopefully https://bugs.chromium.org/p/chromium/issues/detail?id=870731 will be fixed by then so that this will be caught by the CQ/waterfall. Change-Id: I89180cd3645ced2f83513c796195977f865df42c Bug: 870622 Reviewed-on: https://chromium-review.googlesource.com/1161969 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#580715} 
- 
Ryan Tseng authoredBug: 790326, 790270, 790301, 790300, 790288 Change-Id: I4b13502698c574b9b7cb5c29f33ce37ea0e82a0f Reviewed-on: https://chromium-review.googlesource.com/1162918Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#580714} 
- 
Pavel Feldman authoredThese changes actually make it work in the hosted mode. Change-Id: If46c9b9206c4450da09e3a355298ce43ae057d8d Reviewed-on: https://chromium-review.googlesource.com/1159983Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#580713} 
- 
Chromium WPT Sync authoredUsing wpt-import in Chromium 99541e5c. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22285 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc TBR=foolip No-Export: true Change-Id: I964ddbdc14ef1544bd0cc408c5c93ce5d7a3b2e4 Reviewed-on: https://chromium-review.googlesource.com/1162717 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#580712} 
- 
webrtc-chromium-autoroll authoredhttps://webrtc.googlesource.com/src.git/+log/50eb4c44ad92..8bf477cb2a8d git log 50eb4c44ad92..8bf477cb2a8d --date=short --no-merges --format='%ad %ae %s' 2018-08-03 buildbot@webrtc.org Roll chromium_revision 62642dd6..d6a13562 (580526:580628) Created with: gclient setdep -r src/third_party/webrtc@8bf477cb2a8d The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I11a0baef79d6bf78eb80e79cb88d385538214102 Reviewed-on: https://chromium-review.googlesource.com/1162803Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580711} 
- 
Muyuan Li authoredBug: b/77916222 Test: chromeos_services_unittests --gtest_filter=AudioDeviceOwnerTest.BufferFillingFlow media_unittests --gtest_filter=AudioFifoTest.PushPartial Change-Id: I08430a60ce2b634afffa563d5eda46c4306abaa6 Reviewed-on: https://chromium-review.googlesource.com/1100308 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Oskar Sundbom <ossu@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#580710} 
 
- 
- 03 Aug, 2018 15 commits
- 
- 
Yuwei Huang authoredThis is part of the work to rewire the audio playback logic for iOS (and potentially also for Android). AudioJitterBuffer acts as a jitter buffer that queues up AudioPackets once they are received and before they are consumed by a native playback queue. This class is basically modified from AudioPlayerBuffer with a few changes: * Allow handling packets in different stream formats/sample rate and call a callback when the format is changed. * Move the underrun protection logic from AudioPlayerIos (the "PRIMING" state) into the jitter buffer. * Fix a bug where bytes_extracted_ is ignored when copying audio data. * Removed the AudioStreamConsumer inheritance, Stop() and other unused logic. Bug: 868088 Change-Id: Ibaee655df28de68f5303d735ef89cf15695ab2ff Reviewed-on: https://chromium-review.googlesource.com/1150936 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#580709} 
- 
Lucas Furukawa Gadani authoredChange-Id: Ia848a3607658a46eaadc1949cf59caf7b75f7528 Reviewed-on: https://chromium-review.googlesource.com/1161391 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#580708} 
- 
Bruno Kim Medeiros Cesar authored*** I plan to merge this into M69! *** We are currently storing that a transition happened on first login, which confuses ARC++. In reality, the profile was just not fully initialized at the time of the check. Bug: 869505 Change-Id: If040cea6f99136e024507f1649ae47f7dae4acff Reviewed-on: https://chromium-review.googlesource.com/1159181 Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#580707} 
- 
jonross authoredThe viz_fyi_android_gtest suite has stabilized. With the flakes seen being also seen on general android. This renames the config to viz_android_gtests and adds it to the general chromium_android_gtests group to expand coverage. TEST=viz_content_browsertests, surface_sync_content_browsertests Bug: 849746 Change-Id: I63087db31fd9d834a0b98c3a7053577a097b92b4 Reviewed-on: https://chromium-review.googlesource.com/1133303 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#580706} 
- 
depot-tools-chromium-autoroll authoredhttps://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/29b7b99e5d9f..82bb756217cd git log 29b7b99e5d9f..82bb756217cd --date=short --no-merges --format='%ad %ae %s' 2018-08-03 wangqing-hf@loongson.cn [cipd] Detect mips64le vs mips64. Created with: gclient setdep -r src/third_party/depot_tools@82bb756217cd The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:867819 TBR=agable@chromium.org Change-Id: I79597c067ff1691bc025b43a2d9c2499d5be98cb Reviewed-on: https://chromium-review.googlesource.com/1162801Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580705} 
- 
Shakti Sahu authored1 - Fixed a bug in partial rebind attempt 2 - Fixed a bug in custom view rebind where view already has a parent Bug: 870879 Change-Id: I006e2d0f92a038e3b7a44b01b3e7f0c3075ab9b3 Reviewed-on: https://chromium-review.googlesource.com/1162774Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#580704} 
- 
Dominic Mazzoni authoredIn two recent changes, we added some calls to AXTreeSerializer::DeleteClientSubtree. This is often a great way to ensure that portions of the tree are re-serialized. However, what can happen is that there can be reparenting within a subtree, and the client doesn't clear out the subtree first before unserializing it, leading to an unserialization error. This change introduces the concept of invalidating a subtree instead of deleting it. That ensures the correct nodes are re-serialized, while also allowing the code that checks for reparenting. Includes a regression test. Bug: 866293 Change-Id: I257f1a0360d73d2f42dff56fe84a52034941a63b Reviewed-on: https://chromium-review.googlesource.com/1152180 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#580703} 
- 
Nick Carter authoredEvalJs has the following improvements over ExecuteScript: - One function that works for every return type (no AndExtractBool etc variants) and every fancy option (isolated worlds, user gestures). - No out-params; no out-param variables. - |script| doesn't need to call domAutomationController explicitly to return a value. Instead, it has eval() semantics -- the statement completion value becomes the result. - The result of EvalJs can be used directly in EXPECT_EQ; e.g.:: EXPECT_EQ("about:blank", EvalJs(contents, "window.location.href")); - JS exceptions are reliably captured and will appear as C++ assertion failures. - JS stack traces arising from exceptions are annotated with the corresponding source code; this also appears in C++ assertion failures. - When a script doesn't produce a result, tests are much less likely to hang. - Doesn't get confused by crosstalk with other callers of domAutomationController.send(). - Lists, dicts, null values, etc. can be returned as base::Values. Limitations/warts: - The reliance on eval() currently means that a CSP script-src directive can interfere with the script runner. There is a workaround (use an isolated world), but this limitation currently prevents ExecJs from being a drop-in replacement for ExecuteScript. Fixing that will be a follow-on. Change-Id: I260595094f71e7734d29a78e9ffd90b409d74f37 Reviewed-on: https://chromium-review.googlesource.com/1125121 Commit-Queue: Nick Carter <nick@chromium.org> Reviewed-by:Ben Greenstein <bengr@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#580702} 
- 
Artur Khachatryan authoredTests SlowLoadingPageTest.testRefreshShouldBlockUntilPageLoads and ChromeDriverPageLoadTimeoutTest.testRefreshWithPageLoadTimeout are flaky on Linux build bot on Waterfall. Disabling these tests. Bug: chromedriver:2532 Change-Id: Id3ff0730b1b4601dcf238771f863a021dd5d4f95 Reviewed-on: https://chromium-review.googlesource.com/1162821Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580701} 
- 
Ted Choc authoredBUG=862404 Change-Id: I39a49e01d58fb4c83d8a78002e442f6245bf0ea4 Reviewed-on: https://chromium-review.googlesource.com/1162674Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#580700} 
- 
Weilun Shi authoredNow, changing the HideWebStoreIcon policy will affect the prepopulated_list when a new profile opens or reopen the browser. The policy doesn't affect current profile on the NTP. This is because the browser will cache the prepopulated list so that it can fetch the tiles quickly. Bug: 855603 Change-Id: I99ac05040fc44f64ac61151218dcbcc612465e72 Reviewed-on: https://chromium-review.googlesource.com/1137432Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#580699} 
- 
spqchan authoredRename "Trick to Bill" in the code to "Billing". This CL will change values such as: - SB_THREAT_TYPE_TRICK_TO_BILL to SB_THREAT_TYPE_BILLING - SB_REASON_TRICK_TO_BILL to SB_REASON_BILLING Bug: 867518 Change-Id: I0f1b5f9bb8c21d10053de74001b5af0d493e4363 Reviewed-on: https://chromium-review.googlesource.com/1159228Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#580698} 
- 
Anna Offenwanger authoredVRDisplayHost serves as the browser side implementation of the XRDevice mojo interface, so renaming it to make that explicit. Bug: 842025 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I24fc584f06cfcc50c942e2df8bc451badb67e20f Reviewed-on: https://chromium-review.googlesource.com/1162693Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#580697} 
- 
David Tseng authoredDuring touch, we want to either announce 'is editing' is a text field is focused, or 'double tap to start editing' when a text field is in ChromeVox range, but not focused. We want to do this only for touch because keyboard commands,e .g. search+right, will automatically try to focus the text field. Since ChromeVox preemptively reads the new element (and doesn't wait for the focus event on the text field), the output here would be incomplete until the focus event. Fortunately, we only really need this announcement for touch. Bug: 869880 Test: manual Change-Id: I0d25cb28ece2b1a95658108fb5d032a91b705064 Reviewed-on: https://chromium-review.googlesource.com/1162627 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#580696} 
- 
Min Qin authoredThis CL adds methods to get all DownloadEntry from InProgressCache, convert them, and adding them back to the DownloadDB. This migration step allows us to move from InProgressCache to DownloadDB. BUG=870502 Change-Id: Id56346886b1cea2df6fa25954c89cdfb4db167d4 Reviewed-on: https://chromium-review.googlesource.com/1161487 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#580695} 
 
-