GitLab

BUG=474451

Review URL: https://codereview.chromium.org/1063983002

Cr-Commit-Position: refs/heads/master@{#324029}

Fixes downstream gn bots affected by https://codereview.chromium.org/1063873002

TBR=brettw@chromium.org
BUG=474506

Review URL: https://codereview.chromium.org/1063063002

Cr-Commit-Position: refs/heads/master@{#324028}

These changes to RenderFrameHostManager make it so that during a
navigation a new SiteInstance won't be created for a URL if a previously
created one still exists for that same URL. This also follows more
closely how the current navigation implementation works.

BUG=376094
TEST=WebContentsImplTest.ActiveContentsCountChangeBrowsingInstance

Review URL: https://codereview.chromium.org/967383002

Cr-Commit-Position: refs/heads/master@{#324027}

BUG=455409

Review URL: https://codereview.chromium.org/1037793003

Cr-Commit-Position: refs/heads/master@{#324026}

BUG=371290
TBR=piman

Review URL: https://codereview.chromium.org/1067773002

Cr-Commit-Position: refs/heads/master@{#324025}

This CL notifies the hotwording extension of a microphone state change
by adding a hotwordPrivate.onMicrophoneStateChanged event which triggers
an update of the hotwording state.

It also moves the media device observation from HotwordServiceFactory to
HotwordService.

BUG=461787
TBR=estade@chromium.org

Review URL: https://codereview.chromium.org/1047973003

Cr-Commit-Position: refs/heads/master@{#324024}

This brings in a bugfix of checksum calculation that caused assertion
failure on debug builds.

BUG=464780

Review URL: https://codereview.chromium.org/1062093002

Cr-Commit-Position: refs/heads/master@{#324023}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/aeab2ed..44fc33d

TBR=falken@chromium.org

Review URL: https://codereview.chromium.org/1066563003

Cr-Commit-Position: refs/heads/master@{#324022}

Also added myself to AUTHORS

Review URL: https://codereview.chromium.org/1033283002

Cr-Commit-Position: refs/heads/master@{#324021}

Bookmark apps no longer toggle whether they support the location bar
via the browser features system, which didn't seem correct. Instead they
support the location bar feature always but change how the location
bar's height to bring it into and out of view.

This change also introduces a BookmarkAppBrowserController class to
encapsulate all the logic for bookmark apps to modify the browser UI.

BUG=463405

Review URL: https://codereview.chromium.org/1036173002

Cr-Commit-Position: refs/heads/master@{#324020}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/55028d3e..aeab2ed

TBR=jsbell@chromium.org,falken@chromium.org

Review URL: https://codereview.chromium.org/1057083003

Cr-Commit-Position: refs/heads/master@{#324019}

This CL adds a pref that tracks when the app list is last launched and
doesn't warm up the app list on Windows unless the app list has been
launched in the last 28 days.

BUG=440224

Review URL: https://codereview.chromium.org/1016503006

Cr-Commit-Position: refs/heads/master@{#324018}

* When we changed to OmniboxViewViews, we broke the behavior that the omnibox
could handle the escape key before it was processed as a "stop" accelerator.
Instead, Chrome trunk current processes escape as stop first (and exclusively),
then if/when there is no load to stop passes it through to the omnibox.  Restore
the other order, though not precisely with the old behavior.  Other than when
arrowing through the popup (in which cases escape just resets to the top entry):
** Escape when not editing (including when zerosuggest is open) will always both
reset the omnibox and stop any underlying load.
** Otherwise, escape will reset the omnibox but not stop any load.

* As part of the above fix, we now ensure that escape will always close any open
zerosuggest window regardless of which entry in it might be selected or what the
omnibox caret/selection currently is.

* When unfocusing the omnibox causes a zerosuggest popup to close, we also force
the omnibox to reset.  This ensures that, if zerosuggest caused us to
temporarily avoid displaying updates to the underlying page URL, they will now
be shown.  When combined with the changes above, this should mean that it's
impossible to leave zerosuggest mode but still be stuck seeing an out-of-date
URL.

* When copying the text of any item in the zerosuggest popup, including the
first one, and regardless of whether the visible URL is up-to-date, ensure that
the clipboard actually gets the correct text.  Previously, select-all + copy on
any zerosuggest item would copy whatever the current underlying URL of the page
was.

BUG=158913,423181,466565
TEST=See bugs

Review URL: https://codereview.chromium.org/1060613004

Cr-Commit-Position: refs/heads/master@{#324017}

Revert of Fix scoped_ptr free to use delete [] instead of delete. (patchset #1 id:1 of https://codereview.chromium.org/1055433003/)

Reason for revert:
It looks like this broke the following test on XP Tests (1):
sbox_unittests WinUtils.SameObject

Example output:
WinUtils.SameObject (run #1):
[ RUN      ] WinUtils.SameObject
c:\b\build\slave\win_builder\build\src\sandbox\win\src\win_utils_unittest.cc(78): error: Value of: SameObject(file.Get(), file_name_nt1.c_str())
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\sandbox\win\src\win_utils_unittest.cc(79): error: Value of: SameObject(file.Get(), file_name_nt2.c_str())
  Actual: false
Expected: true
[  FAILED  ] WinUtils.SameObject (16 ms)

Original issue's description:
> Fix scoped_ptr free to use delete [] instead of delete.
>
> BUG=101717
>
> Committed: https://crrev.com/7804b679be3af7e24578394af0a85ba1249344a9
> Cr-Commit-Position: refs/heads/master@{#324013}

TBR=cpu@chromium.org,wfh@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=101717

Review URL: https://codereview.chromium.org/1065833002

Cr-Commit-Position: refs/heads/master@{#324016}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/61c4468..55028d3e

TBR=jsbell@chromium.org,falken@chromium.org

Review URL: https://codereview.chromium.org/1068693002

Cr-Commit-Position: refs/heads/master@{#324015}

The icon appears at the right of the top row of icons.

BUG=469996

Review URL: https://codereview.chromium.org/1052073002

Cr-Commit-Position: refs/heads/master@{#324014}

BUG=101717

Review URL: https://codereview.chromium.org/1055433003

Cr-Commit-Position: refs/heads/master@{#324013}

When the root layer scroll offset delegate's scroll offset is bigger
than that of the outer viewport scroll layer, the root scroll offset is
distributed between inner and outer viewport scroll layer. However, the
layer that gets assigned a new scroll offset first will immediately
update the root layer delegate scroll offset without waiting for the
rest of the undistributed scrolls to be assigned to other layer. This
causes the associated bug 470360.

This CL simplified the logic around delegated scrolling by removing
LayerImpl::ScrollOffsetDelegate. LayerImpl will always have the most
recent and correct scroll offset.

LTHI and LTI still delegate the root layer scroll to an external source
(Android WebView).
There are 2 cases for a LayerImpl to change its scroll offset:
1. When the root layer scroll delegate scrolls, the new scroll offset will be
synchronously distributed to the inner and outer viewport scroll layer.
2. The LayerImpl scrolls by itself, like ScrollBy() or PushScrollOffset(). In
this case, root layer scroll delegate will be updated with the new scroll
offset.

BUG=470360

Review URL: https://codereview.chromium.org/1038173002

Cr-Commit-Position: refs/heads/master@{#324012}

TEST=Compiles and all current tests pass.
BUG=None

Review URL: https://codereview.chromium.org/1062853004

Cr-Commit-Position: refs/heads/master@{#324011}

BUG=440649

Review URL: https://codereview.chromium.org/1043373002

Cr-Commit-Position: refs/heads/master@{#324010}

Revert of C++ readability review (patchset #10 id:180001 of https://codereview.chromium.org/706993003/)

Reason for revert:
It looks like this broke tests the following tests on Linux Chromium OS:
AlarmTimerTest.OneShotTimerConcurrentResetAndTimerFired
AlarmTimerTest.RepeatingTimerConcurrentResetAndTimerFired

Example output:
AlarmTimerTest.OneShotTimerConcurrentResetAndTimerFired (run #1):
[ RUN      ] AlarmTimerTest.OneShotTimerConcurrentResetAndTimerFired
[11334:11334:0406/201742:404219967:INFO:alarm_timer_chromeos.cc(166)] CLOCK_REALTIME_ALARM not supported on this system: Invalid argument
[11334:11334:0406/201742:404230154:FATAL:timer.cc(116)] Check failed: !user_task_.is_null().

AlarmTimerTest.RepeatingTimerConcurrentResetAndTimerFired (run #1):
[ RUN      ] AlarmTimerTest.RepeatingTimerConcurrentResetAndTimerFired
[11382:11382:0406/201748:411022458:INFO:alarm_timer_chromeos.cc(166)] CLOCK_REALTIME_ALARM not supported on this system: Invalid argument
../../components/timers/alarm_timer_unittest.cc:469: Failure
Value of: did_run
  Actual: true
Expected: false

Example build:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/996

Original issue's description:
> C++ readability review
>
> BUG=b/18275087
>
> Committed: https://crrev.com/05e4d854dca737cfb43cd967cd72d024f6b1625b
> Cr-Commit-Position: refs/heads/master@{#324004}

TBR=derat@chromium.org,gromer@google.com,zea@chromium.org,chirantan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=b/18275087

Review URL: https://codereview.chromium.org/1058693003

Cr-Commit-Position: refs/heads/master@{#324009}

BUG=473561
TEST=none

Review URL: https://codereview.chromium.org/1061833002

Cr-Commit-Position: refs/heads/master@{#324008}

This reduces the complexity of the code needed to validate
internalformat and makes it easier to add new formats.

BUG=474280
TEST=gl_tests --gtest_filter=GpuMemoryBufferTests/GpuMemoryBufferTest.Lifecycle/*

Review URL: https://codereview.chromium.org/1068663002

Cr-Commit-Position: refs/heads/master@{#324007}

BUG=473471

Review URL: https://codereview.chromium.org/1060483002

Cr-Commit-Position: refs/heads/master@{#324006}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/efd7029..61c4468

TBR=jsbell@chromium.org,falken@chromium.org

Review URL: https://codereview.chromium.org/1060163003

Cr-Commit-Position: refs/heads/master@{#324005}

BUG=b/18275087

Review URL: https://codereview.chromium.org/706993003

Cr-Commit-Position: refs/heads/master@{#324004}

BUG=473370

Review URL: https://codereview.chromium.org/1058423002

Cr-Commit-Position: refs/heads/master@{#324003}

BUG=450641
Test=<TO_BE_FILLED_IN>

Review URL: https://codereview.chromium.org/1052343003

Cr-Commit-Position: refs/heads/master@{#324002}

This CL added a wrapper on top of quic_simple_server so that
Cronet tests can spin up a local quic server on the device.

BUG=411010

Review URL: https://codereview.chromium.org/1039693003

Cr-Commit-Position: refs/heads/master@{#324001}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/83c3890..efd7029

TBR=jsbell@chromium.org,falken@chromium.org

Review URL: https://codereview.chromium.org/1064683004

Cr-Commit-Position: refs/heads/master@{#324000}

Avoid calling the GetSystemMetrics API in the renderer process on Windows to get the scrollbar metrics.

It appears that this call takes a long time on certain Windows 8 configurations because the call triggers a load
of the uxtheme.dll which fails and retries every time. This is presumably due to the Win32K lockdown mode on Windows 8+.

Fix is to send the scrollbar metrics values we are interested in as part of the RendererPrefs structure. In the renderer
these are saved as static values in the WebThemeEngineImpl class.

1) Note that not all of the cache settings are currently used - SM_CYHSCROLL,
SM_CYVSCROLL, and SM_CXHSCROLL are cached for possible future usage.

2. These repeated attempts to load uxtheme.dll only occur in some (ill-defined)
situations, having to do with what theme is selected and other factors

BUG=472790

Review URL: https://codereview.chromium.org/1054243002

Cr-Commit-Position: refs/heads/master@{#323999}

base's MD5String() is a helper function that does exactly what this
piece of code in ReadData() is doing, so we can just call MD5String()
and simplify it instead.

BUG=None
R=mattm@chromium.org

Review URL: https://codereview.chromium.org/1054433004

Cr-Commit-Position: refs/heads/master@{#323998}

Revert of bluetooth: Move requestDevice() to UI thread. (patchset #2 id:20001 of https://codereview.chromium.org/1058373002/)

Reason for revert:
The layout test bluetooth/requestDevice.html became flaky after this patch landed.

Flakiness dashboard link:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=bluetooth%2FrequestDevice.html

Example failure link:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/builds/35097

Failure output:
This is a testharness.js-based test.
PASS window.testRunner is required for the following tests.
PASS Reject with NotFoundError.
FAIL Reject with SecurityError. assert_unreached: Mock was set to reject. Reached unreachable code
PASS Mock will resolve.
Harness: the test ran to completion.

Original issue's description:
> bluetooth: Move requestDevice() to UI thread.
>
> BluetoothAdapter is not thread safe, this change moves the requestDevice() call to it onto the UI thread.
>
> BUG=420284
>
> Committed: https://crrev.com/8a72921779123fbd7a7f756f9683f4df8944ea9d
> Cr-Commit-Position: refs/heads/master@{#323919}

TBR=scheib@chromium.org,ortuno@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=420284

Review URL: https://codereview.chromium.org/1048313003

Cr-Commit-Position: refs/heads/master@{#323997}

BUG=409094,295137

Review URL: https://codereview.chromium.org/1067743002

Cr-Commit-Position: refs/heads/master@{#323996}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ddd534f1..d073ccb0

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1060953003

Cr-Commit-Position: refs/heads/master@{#323995}

BUG=412078

Review URL: https://codereview.chromium.org/1065753002

Cr-Commit-Position: refs/heads/master@{#323994}

BUG=425672

Review URL: https://codereview.chromium.org/1059393002

Cr-Commit-Position: refs/heads/master@{#323993}

BUG=474299

Review URL: https://codereview.chromium.org/1059483004

Cr-Commit-Position: refs/heads/master@{#323992}

This custom polymer element is used to show issues related to casting. It is styled after the current cast extension's issue banner.

BUG=464222

Review URL: https://codereview.chromium.org/1023673008

Cr-Commit-Position: refs/heads/master@{#323991}

Add a histogram "Network.Shill.Wifi.UnreliableLinkSignalStrength"
for sampling WiFi signal strength when the WiFi network becomes
unreliable (experiencing multiple link failures in a short period
of time).

BUG=chromium:416631
TEST=pretty_print.py, validate_format.py

Review URL: https://codereview.chromium.org/1064693004

Cr-Commit-Position: refs/heads/master@{#323990}