- 01 Feb, 2018 40 commits
-
-
Scott Graham authored
After https://chromium-review.googlesource.com/c/chromium/src/+/876683. Bug: 644525 Change-Id: Ic8f71d5f4cababaa252fd4c9155ea8b34b29158b Reviewed-on: https://chromium-review.googlesource.com/896695Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#533749}
-
https://webrtc.googlesource.com/src.git/+log/10d9d59db164..28dbf9724281 $ git log 10d9d59db..28dbf9724 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3ae6f051431514c07e64b999ef3b76b9384dcf5d Reviewed-on: https://chromium-review.googlesource.com/897934 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533748}
-
Evan Stade authored
This code does not appear to be necessary any more. Bug: 578868 Change-Id: I1437f18f800fe6293bc01ac207f604da2c9afb6c Reviewed-on: https://chromium-review.googlesource.com/897042Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#533747}
-
Daniel Park authored
Reverts to method before setClipBounds was used. Removes canvas.save and restore as they weren't doing anything Removes check for clip bounds = 0 since it was never 0 Adds scrollX() to rectangle clip bounds for canvas Bug: 805479 Change-Id: I3d32f8dd9526ca7d5504d702283f8fcd2364d678 Reviewed-on: https://chromium-review.googlesource.com/896635Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#533746}
-
Dominick Ng authored
This is a reland of 58ab87ff. Original change's description: > Consolidate app banner testing. > > This CL removes several different app banner testing files, and replaces > them by calling the necessary JavaScript setup code in one test file. > For instance, all tests will no longer have the "appinstalled" title > overwriting, as that will only be active when the appropriate setup > JavaScript is run. > > This allows future tests to be more easily added, and reduces collisions > when manipulating the page title. > > BUG=806923 > > Change-Id: Ia28837b8675a2e1fe329cb1df1be4798ddb03d02 > Reviewed-on: https://chromium-review.googlesource.com/892182 > Commit-Queue: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532978} Bug: 806923 Change-Id: Ia85a5be0828ad0820a891f8cde9d9e492dc0b831 Reviewed-on: https://chromium-review.googlesource.com/896326Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#533745}
-
Ran Ji authored
We have limited number of jni local references, leaking jobjects inside loop may cause local reference table to overflow. Bug: 726426 Change-Id: I4b1ffc9fcb74d1a78d0415f9d9c79533facb7839 Reviewed-on: https://chromium-review.googlesource.com/895843 Commit-Queue: Ran Ji <ranj@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533744}
-
Marijn Kruisselbrink authored
Revoking right after navigating and/or loading script should not break the loading. Bug: 800901 Change-Id: I5b2fc378ae4681fb4d42e1e3742111f67a2d1a41 Reviewed-on: https://chromium-review.googlesource.com/894843 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#533743}
-
Gayane Petrosyan authored
When navigating to about:version/?show-variations-cmd an additional section will appear showing complete set of client's variations in the command line formatting that can be used to reproduce the same exact state of variations. The displayed info contains all the trials including not activated ones marked by '*' along with the corresponding group assignment. It will also contain enabled and disabled features where the ones that should use the default value will be marked with '*'(e.g. expired trials). Trials that are unforcable through command line will be shown but warning will be shown when processing the command line input with unforcable trial. This CL doesn't cover iOS. As the displayed text is huge I also changed the width of the text in the about:version page (not mobile) to be 60% of the page with a minimum of 800px as it used to be. Bug: 694675 TEST=unit test, manual testing 1. run chrome with --fake-variations-channel=beta 2. copying command line input from about:version/?show-variations-cmd 3. run chrome without channel but with command line input copied in step 2. 4. confirm about:version/?show-variations-cmd page shows the same info Change-Id: Ie73174bd5bd1a02baa75cd3294fd36cf63b3c923 Reviewed-on: https://chromium-review.googlesource.com/865286 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#533742}
-
Miguel Casas authored
Every git cl upload I get a bunch of presubmits like: Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018) So this CL does the transition: Bind --> BindOnce, Closure --> OnceClosure, Callback --> OnceCallback, use of Base::Passed(), in method signatures, we change const & to moving the argument, and instead Run()ning the Callback we use std::move(cb).Run(). Threw in a few consts where applicable. No new code otherwise, tests (and asan etc) should cover it all. Bug: 803975, 714018 Change-Id: I48338984a99627b5de34c5da45dadbdc7c0409e5 Reviewed-on: https://chromium-review.googlesource.com/893822Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#533741}
-
erikchen authored
Developers can still manually upload via chrome://memory-internals. Bug: 751321 Change-Id: If0f96419984c407cb073d5391f0042cdfaed1f04 Reviewed-on: https://chromium-review.googlesource.com/897744Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533740}
-
Joy Ming authored
This CL makes the DownloadsFilter enum into an IntDef. Change-Id: Idcec8f6ed8a818057e15be3825341da5f9336e9c Reviewed-on: https://chromium-review.googlesource.com/896122 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#533739}
-
Peter E Conn authored
Bug: 808015 Change-Id: Id4a83971a028caa7bfd6e5b00d7d5f16bdb49213 Reviewed-on: https://chromium-review.googlesource.com/897527Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#533738}
-
CrystalFaith authored
Extension relied on persistent background script. Updated background.js to use storage. Updated manifest background to non-persistent. Bug: none Change-Id: I1e6e54d9da2b1d880367bb4369253f5d5e6ca0cb Reviewed-on: https://chromium-review.googlesource.com/885263 Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533737}
-
Evan Stade authored
This hides all notification popups. Its only purpose is for making sure popups don't interfere with automated tests. Bug: 807101 Change-Id: I7776af1b0fbd795ed1899a78fa5a7aef1c7b6f9a Reviewed-on: https://chromium-review.googlesource.com/894152 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#533736}
-
Juan Antonio Navarro Perez authored
Bug: 807936 Change-Id: Iba1bf251aa822753251768deeea02e809cc93860 Reviewed-on: https://chromium-review.googlesource.com/897667Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#533735}
-
Samuel Huang authored
This CL adds ensemble patching (AKA Layer 3 patching) to Zucchini, where patches are generated and applied on "old" and "new" archives that contain uncompressed executable "elements", which need to be detected and matched first. - HeuristicEnsembleMatcher performs element detection and matching. - Resulting matched "elements" undergo architecture-specific patching (AKA Layer 2 patching), but on failure, raw patching (AKA Layer 1 patching) is used. - "Gaps" are contents in archives that are not elements. These use raw patching, and are computed separately from element patching to reduce peak memory (since these require suffix array of the entire "old" archive). - In the patch format, "gaps" are represented as "no-op" elements, i.e., raw patches without references. - This CL focuses on Zucchini-gen, since Zucchini-apply already supports Ensemble patch application. - After this CL, Zucchini will be equally usable as Courgette. Bug: 729154 Change-Id: Id828186cda74885ee6992b17f641e491efe79c40 Reviewed-on: https://chromium-review.googlesource.com/891489 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#533734}
-
https://pdfium.googlesource.com/pdfium.git/+log/1fc533150a27..71a7d377ff36 $ git log 1fc533150..71a7d377f --date=short --no-merges --format='%ad %ae %s' 2018-02-01 hnakashima Deprecate FPDFDest_GetPageIndex and create a fixed version. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5e5656b18e94dad049e11d8b6c6ad3446fd5a6e6 Reviewed-on: https://chromium-review.googlesource.com/897933 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533733}
-
Carlos IL authored
In preparation for an EV study, metrics from PageInfo actions need to be separate for SECURE sites and EV_SECURE sites. This CL deprecates the Security.PageInfo.Action.HttpsUrl.Valid histogram and creates Security.PageInfo.Action.HttpsUrl.ValidEV and Security.PageInfo.Action.HttpsUrl.ValidNonEV. Bug: 803530 Change-Id: I0e28b0ac7b53d3838cb74b61d10662d9d446fd18 Reviewed-on: https://chromium-review.googlesource.com/896184Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#533732}
-
erikchen authored
The heap dump v2 format requires that multiple heap dumps in the same trace share IDs for nodes and strings. Since the JSON exporter is stateless, and isn't aware of whether the dump will be part of a given trace, just give all nodes and strings a unique ID. Bug: 758739 Change-Id: I87002ce9a84c60ee7a41ac38d3702248a4aa6ae4 Reviewed-on: https://chromium-review.googlesource.com/895666Reviewed-by:
Dmitry Skiba <dskiba@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533731}
-
https://skia.googlesource.com/skia.git/+log/5f9ee7cc53d2..82a4c055d14f $ git log 5f9ee7cc5..82a4c055d --date=short --no-merges --format='%ad %ae %s' 2018-02-01 kjlubick Get better stacktraces for *SAN builds 2018-01-30 csmartdalton ccpr: Pack wind into existing varyings 2018-02-01 reed validate indices for vertices 2018-02-01 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 8efd1268e..c0db9adde (2 commits) 2018-02-01 halcanary SkQP: remove model slack, README 2018-02-01 egdaniel Fix GrBackendTextureImageGenerator to hold context lock till all proxies are gone 2018-02-01 kjlubick Check for nullptrs when fuzzing region_deserialize 2018-02-01 caryclark auto table generation 2018-02-01 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 1776fd08e..8efd1268e (1 commit) 2018-02-01 robertphillips Implement GPU/OpList DDLs Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Ideca9567f7475d7631405f9a9838e16794c4b494 Reviewed-on: https://chromium-review.googlesource.com/897931 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533730}
-
Nico Weber authored
clang will now warn on non-empty case and default blocks that don't end with a break statement. For cases where fallthrough is intentional, end the block with FALLTHROUGH; from base/compiler-specific Depends on these changes to DEPS rolling into chromium: https://pdfium-review.googlesource.com/#/c/pdfium/+/24790 https://chromium-review.googlesource.com/c/angle/angle/+/895728 https://chromium-review.googlesource.com/c/v8/v8/+/895704 https://chromium-review.googlesource.com/c/breakpad/breakpad/+/895705 https://github.com/google/cld3/pull/9 We'll enable this for more build configurations once they can build with the warning enabled. (Also change a single file that was needed to get the dcheck_always_on build to work, and another one that is built only in static builds.) Bug: 177475,808047 Change-Id: Ic6a3fbf78a9cb2b5e928ce7973e67e4a39629dfd Reviewed-on: https://chromium-review.googlesource.com/895726Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#533729}
-
Daniel Bratell authored
In jumbo builds many cc files compile in the same translation unit and then they all share the same anonymous namespace. If two or more variables have the same name, they will cause compilation errors and that happened with the three kDefaultPromoShowTimeInHour constants. As a preparatory patch to jumbo in chrome/browser this renames those by adding a relevant prefix to each of them. Bug: 746957 Change-Id: If17d8103a6916c14b493e203e445208bb1b1b2d6 Reviewed-on: https://chromium-review.googlesource.com/893273Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#533728}
-
Michael Thiessen authored
Allows VR to be entered without any tab (in which case you'll just see a page with a grey background, but can still interact with omnibox). This allows us to stay in VR when the renderer crashes and leaves us without a Tab. I had to special case overview mode and NTP so that we don't enter VR when those are visible as we don't support them yet. I also had to fix an issue where the progress bar would get re-shown transitioning from no tab to tab. Bug: 770380 Change-Id: Icd267aa0fa28b52cad03fac8f80c17091680b41f Reviewed-on: https://chromium-review.googlesource.com/896030Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#533727}
-
Steven Bennetts authored
These strings were not being loaded for the details dialog which also uses them. Bug: none Change-Id: I0ed1753b96461fc09e45e1df6ab665dae8bd3cb7 Reviewed-on: https://chromium-review.googlesource.com/897914Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#533726}
-
Tommy Steimel authored
This reverts commit 75edf20e. Reason for revert: inspector-protocol/heap-profiler/heap-snapshot-with-iframe.js is failing on Mac bots. Example: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.12/10410 diff from failure: https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=c317416b36978b21d32382d0c64469a05a334287&as=heap-snapshot-with-iframe-diff.txt Original change's description: > Capture all DOM nodes reachable from V8 in heap snapshot. > > This patch uses the new EmbedderGraph API to provide the heap snapshot > generator with all DOM nodes and references reachable from V8. > > Bug: 749490 > Change-Id: I26750a8b80dab4f88508e504b431d976a598c6c3 > Reviewed-on: https://chromium-review.googlesource.com/890260 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533664} TBR=dcheng@chromium.org,ulan@chromium.org,alph@chromium.org,haraken@chromium.org,mlippautz@chromium.org Change-Id: I8fc35e1c2638bb8ef77b3b19053a7bcbe74a347a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 749490 Reviewed-on: https://chromium-review.googlesource.com/896686Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#533725}
-
Weidong Guo authored
Changes: Add four animations to transit from the closed folder item icon to the opened folder view: 1. Background animation: This is a slide animation which transits from the rounded background of the folder item's icon to the folder's background when opening the folder. 2. Folder item title animation: This is a slide animtion which changes the opacity of the folder item's title. 3. Top icon animation: A group of layer animations to transit from the items within the folder item icon to the same items in the opened folder. 4. Contents container animation: A layer animation to transit from the bounds of the folder item icon to the opened folder's bounds and transit opacity from 0 to 1. Specs: https://drive.google.com/file/d/1-qeCz6YEzQPRUKWDAI1HXdL4bKag2Q_G/view 2500 ms duration video demo: https://drive.google.com/file/d/1Q-3s9dl1bT0xSzpzbENCX4vyD0Ud2eqG/view?usp=sharing 250 ms duration video demo: https://drive.google.com/file/d/1vXkOCaDKoQEvKpyLXnJO79OKAyo-E7m6/view?usp=sharing BUG: 796632 Change-Id: I00aa09dbb65f10c6611aad89194b2f8310b0ece7 Reviewed-on: https://chromium-review.googlesource.com/890019 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533724}
-
Xianzhu Wang authored
When a subframe initiates printing, all coordinates should be in the subframe's space, so we should not map anchors to the root frame. Bug: 808057 Change-Id: I8714cfaddc1bd5471da2561f69ef92994d57c559 Reviewed-on: https://chromium-review.googlesource.com/894464 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533723}
-
Sylvain Defresne authored
The target //ios/chrome/browser/upgrade:unit_tests was never added to ios_chrome_unittests and thus the test never ran. Fix this ommision. Bug: none Change-Id: Ib434fb73eb329dfd6ea6d7d3ccafc55b99416538 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/895765Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#533722}
-
https://chromium.googlesource.com/angle/angle.git/+log/8efd1268eb2e..c0db9addeaeb $ git log 8efd1268e..c0db9adde --date=short --no-merges --format='%ad %ae %s' 2018-01-29 lucferron Fix dEQP renderbuffer unspecified attachment test. 2018-01-29 lucferron Vulkan: Finish implementing caps limitations for ES 2.0 support Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ie0f74a39485f857652a47946caea4db0b3f5b616 Reviewed-on: https://chromium-review.googlesource.com/897905Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533721}
-
Mitsuru Oshima authored
Do not move the cursor if the cursor is invisible when display configuration is changed. This was to make sure that X11's cursor stays inside a display, as reconfiguring display can potentially move the cursor to outside of displays. I think this is no longer a concern, and I'll replace this with just a notification after merged to 65. This also fixes the test harness that assumes the cursor is visible by default but wasn't. BUG=773479 TEST=covered by unit test. also tested on device. Change-Id: I7debc957145318352f7ee3c858031091eb2a8e56 Reviewed-on: https://chromium-review.googlesource.com/890056 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#533720}
-
clamy authored
This CL introduces a mojo method to send renderer debug URLS to the renderer for handling, instead of using CommitNavigation. This allows not to create a NavigationRequest nor a NavigationHandle for these URLs, which do not represent actual navigations. Bug: 784904,803859 Change-Id: Ica9b17a071d2f9faa7f43eb428b0d73424a180e9 Reviewed-on: https://chromium-review.googlesource.com/817560Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533719}
-
Yutaka Hirano authored
Bug: 753658, 754918 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id9206b68b1b85b0db20919763e45aede88d565cc Reviewed-on: https://chromium-review.googlesource.com/892938Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#533718}
-
W. James MacLean authored
This CL removes the tooltip IPC code from BrowserPlugin and BrowserPluginGuest. This code is no longer in use since mouse events are directly routed to the guest, and no longer go through the embedder. Bug: 533069 Change-Id: I916b534d86faf81d64f855368d055f8faccaf440 Reviewed-on: https://chromium-review.googlesource.com/895192Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#533717}
-
Gabriel Charette authored
This will help identify the portion of our population that is still susceptible to a poor ticks clock (last update on this is in time_win.cc and dates to 2015, not clear which data source this was based on). R=asvitkine@chromium.org Bug: 807615 Change-Id: I76627355c1357f1ad6c80ba461798facd41718b0 Reviewed-on: https://chromium-review.googlesource.com/897606 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#533716}
-
Mounir Lamouri authored
As promised during review. Bug: None Change-Id: I8d028c7fa87469a94c858600e7acb297cb7b527d Reviewed-on: https://chromium-review.googlesource.com/897605Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Mounir Lamouri (slow) <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#533715}
-
Kouhei Ueno authored
This CL: - clarifies that the map keys are sorted according to https://tools.ietf.org/html/rfc7049 section 3.9 (with errata 4409), and - add support for "byte string" keys in map. We plan to use this to encode signed exchange "Canonical CBOR". Bug: 803774, 808022 Change-Id: I336a703efe6a3910f069034086b2c84e6a81a075 Reviewed-on: https://chromium-review.googlesource.com/895227 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533714}
-
Maria Khomenko authored
Bug: 807807 Change-Id: Ibaff48b7c5d998da98526c10d5996b5920b199c6 Reviewed-on: https://chromium-review.googlesource.com/896632Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#533713}
-
Fredrik Söderquist authored
A 'pathLength' attribute on a <path> referenced from <textPath> will affect the starting offset on the path as computed from 'startOffset' attribute. Refactor the PathPositionMapper setup a bit so that the start offset is computed together with all the other path related state. Bug: 803127 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id12c88580dd74db403598d2aa05ac9764ad68cdb Reviewed-on: https://chromium-review.googlesource.com/897626Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#533712}
-
Eugene Ostroukhov authored
Network panel will now preview all HTML responses. Bug: 785050 Change-Id: I79b3c22300a4f132bf1b3e4842c06f291249a09d Reviewed-on: https://chromium-review.googlesource.com/896367 Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533711}
-
arthursonzogni authored
With NavigationMojoResponse (or the NetworkService), the NavigationURLLoader implementation is no more the NavigationURLLoaderImpl but the NavigationURLLoaderNetworkService. Some NavigationURLLoader unittests needs to be rewritten. This CL removes: * NavigationURLLoaderTest.Basic * NavigationURLLoaderTest.RequestRedirected These two tests are not replaced. They are very basic and there are already a huge number of test doing navigation and redirects. Design doc: https://goo.gl/Rrrc7n (NavigationMojoResponse) Bug: 705744 Change-Id: I7e3926593f1ca2eafc3f8f15ed782f440cff037a Reviewed-on: https://chromium-review.googlesource.com/868212 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533710}
-