- 26 Aug, 2019 40 commits
-
-
Yuki Shiino authored
Implements CodeGeneratorInfo{,Mutable} as immutable and mutable information for bindings generators respectively. Bug: 839389 Change-Id: Ia872b2f5aa5fd2b80a122f006ced06dae0b596c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768480 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#690294}
-
Koji Ishii authored
r684910 (crrev.com/c/1742250) changed LayoutNG to include close tags after a forced break. This broke an assumption in |NGInlineNode::ComputeMinMaxSize| that there are no objects after a forced break. This patch fixes the min-content size for the situation by applying the same rule to |NGInlineNode::ComputeMinMaxSize|. The test hits DCHECK failure without the fix because the fast code path computes the different max-content from the slow code path. Bug: 991320 Change-Id: I3e9106fddc1fce5a2a7576fc4f75b77b5d4b8b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768486 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#690293}
-
Koji Ishii authored
This patch changes |NGTextFragmentPainter| and |NGTextPainter| to support |NGFragmentItem| in addition to |NGPaintFragment|. A few things, such as document marker or text decorations are not supported yet. Bug: 982194 Change-Id: I714aaa145558f26bf2d592f3a1772fd6e5d903e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758030Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d25be188882c..ba57aa2b4a60 git log d25be188882c..ba57aa2b4a60 --date=short --no-merges --format='%ad %ae %s' 2019-08-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-08-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 17f26865c8cc..3c6b2e1613c8 (17 commits) 2019-08-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src edb7520e..26bef937 (465 commits) Created with: gclient setdep -r src/third_party/skia@ba57aa2b4a60 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: chromium:None,chromium:None Change-Id: I562cab10879eaa90cc405d56d66d44131660fc74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771237Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690291}
-
Yuki Shiino authored
IdentifierIRMap is a bit long name, and it turned out that idenfiers don't play that important role. IRMap is a clear and short name. Also drops unused features of IRMap. Bug: 839389 Change-Id: I1d325e9dd2e8421f2662357ebdd4c3e579f069f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768843 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch moves ink-overflow data for |NGPhysicalTextFragment| to |NGInkOverflow|, and let |NGPhysicalTextFragment| to have a pointer. This saves memory, in addition to preparing to share code with |NGFragmentItem|. This data was once on the rare-data on |NGPhysicalTextFragment|, but then moved to inside of |NGPhysicalTextFragment| when the rare-data was removed and we assumed ink-overflow for text is more common than we thought. Here's a list of ratios where text runs have ink-overflow: Google home: 17% Google SRP: 38% youtube.com: 3% twitter.com: 43% facebook.com: 28% Because |NGInkOverflow| is 16 bytes (assuming FASTMALLOC has no alloc overheads), the consumed memory is on par at 75% on 32-bit systmes and at 50% on 64-bit systems. Bug: 982194 Change-Id: I657a742126d58b9204d3fb8a9ec919eca36f0577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768489Reviewed-by:
-
Hiroshige Hayashizaki authored
Previously, getRequestURLs(), PolicyDelivery/Subresouce object creation etc. were done once per test HTML file and reused among multiple subtests. This CL introduces invokeScenario() that does these things and calls invokeScenario() for each subtest, and thus calls getRequestURLs() for each subtest. This removes hacky modifications to `subresource.url` in 4K-referrer-length-related subtests to avoid cache hit. Also this makes subresource URLs unique for srcdoc-related subtests (previously the same image URL was used). Bug: 906850 Change-Id: I894a902338a90526678b70d01857103f46984189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723013 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#690288}
-
Rachel Wong authored
Bug: 959679 Change-Id: Ide0d6afe4181459e5ac0dd8259fcc0dc296823e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771105Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#690287}
-
Koji Ishii authored
This patch impelments copying layout data from |NGFragmentItem| to |LayoutObject|. Unfortunately we could not share the logic with the current code because the current code traverses |NGPhysicalFragment|, not |NGPaintFragment|. The logic is stable for a long time, this patch copies the logic and expects the current code to be gone when the transition is complete. Bug: 982194 Change-Id: Ied1d0da59f19aac75d4a025683934433f35c04b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757715 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d5163953610a..81a5ea6cf04a git log d5163953610a..81a5ea6cf04a --date=short --no-merges --format='%ad %ae %s' 2019-08-26 vapier@chromium.org replace itertools.i{map,zip} with six.moves.{map,zip} Created with: gclient setdep -r src/third_party/chromite@81a5ea6cf04a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I38f825a23c69a144a85847cb78916717f9def28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771236Reviewed-by:
-
Yuki Shiino authored
Cleans up web_idl.Includes and completes its implementation (by removing unused implementations). Bug: 839389 Change-Id: I44cb8f04d1fdc34c6b7ddbded25f8d55193bda55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768597Reviewed-by:
-
Yuki Shiino authored
Makes make_copy makes a copy with the same structure as the original object has. Like |deepcopy| uses |memo| argument, make_copy uses |memo| argument, too. ExtendedAttribute(s)'s __eq__ are replaced with |equals| class method so that __eq__ works on the object identity. This is necessary to make |memo| above work. Bug: 839389 Change-Id: I5896ef07787dd0086f510ae4102a5f538a9b5c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765098Reviewed-by:
-
Yuki Shiino authored
Removes web_idl.IdlMember which is practically unused. Bug: 839389 Change-Id: Ie06f7dd2f79aeb02d3fd74633a8fd866517fa58e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768598Reviewed-by:
-
Yuki Shiino authored
Super minor clean up without a change on code. Bug: 839389 Change-Id: I6be0c51f65507fadbb416975c3c772668d4d524e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768842Reviewed-by:
-
Hiroshige Hayashizaki authored
Because history.back() works asynchronously, there are races between history.back() and subsequent promise_test()s. For exmample: 1. The first 4K-length-referrer subtest finishes and history.back() is called. 2. The second subtest starts, and replaceState() is called. 3. The change to `location` caused by hisotory.back() in Step 1 comes into effect. 4. The second subtest finishes -- at this time, `location` is the original Document URL (not '.../AAAA....AAA' set by replaceState() in Step 2) and thus history.back() has no effects. This CL fixes the race by waiting for `popstate` events that should be fired at the end of async tasks of history.back(). This CL reverts the changes to `referrer-policy-test-case.sub.js` in https://github.com/web-platform-tests/wpt/pull/18401 https://github.com/web-platform-tests/wpt/commit/8b46cbf469fd282e56ea3ef883e8a8cb509d49d6 and waits for popstate instead, because single asyncResolve() isn't sufficient to fix the race condition described above. Bug: 906850 Change-Id: I21e7b8dd6001a13230fd8dca4d1693ae956958ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717268 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Leo Zhang authored
Prepare for dogfooding in the canary/dev channels. Bug: 888885 Change-Id: I757fd28d4d11d10f521a038fcdd2179a18311ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763647Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#690279}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic6d09438e01df565cf645aeb86fef8411f6628f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771133Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/27afcf5d12c0..d25be188882c git log 27afcf5d12c0..d25be188882c --date=short --no-merges --format='%ad %ae %s' 2019-08-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 115cfe7a1b32..d6dc4b7e4533 (1 commits) Created with: gclient setdep -r src/third_party/skia@d25be188882c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: chromium:None Change-Id: I0008e6de6f6c647774bd7a8442d7635dc9f4cb54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771132Reviewed-by:
-
Matt Falkenhagen authored
The thread ServiceWorkerContextCore lives on (the "core thread") will move from the IO thread to the UI thread when the ServiceWorkerOnUI feature is enabled. This CL makes code in content/browser/notifications aware of the core thread instead of assuming the IO thread. This makes the remaining "Push*" browser_tests pass when the feature is enabled. Bug: 824858 Change-Id: Ice834d2d4a69505b977cb469b516e0705c36202c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768602Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#690276}
-
Yutaka Hirano authored
Recently network::WebSocket started using mojo datapipe rather than ReadOnlyBuffer. Unlike usual mojo message, an error to write bytes to data pipe is detected synchronously. We called WebSocket::Reset which deletes the associated net::WebSocketChannel synchronously, but the net::WebSocketChannel didn't know it and keeped running after destruction. This CL makes the Reset call asynchronous. This doesn't lead to any races because we actually don't write bytes in such a case - it looks like the data pipe buffer becomes full, and Reset is called afterwards. Bug: 994000 Change-Id: I8b9213720b60314f1e638af9cd492e807cbab56d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767478 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#690275}
-
François Doray authored
Bug: 975071 Change-Id: I137c69d0dea42f720b4d0f2db8290d47896d7ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758783 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#690274}
-
Gyuyoung Kim authored
This CL converts implementations of media_device.mojom and related classes. Major changes are as below, - Change MediaDevicesListenerPtr with PendingRemote or Remote - Change BindingSet with ReceiverSet - Change Binding with Receiver Bug: 955171 Change-Id: I7b441d04659ace82ba10ab8b51e0d8039c467670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760835Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#690273}
-
Kenichi Ishibashi authored
This method was used legacy on-the-main-thread script fetch which was removed a while ago. Remove this leftover. Bug: 967272 Change-Id: Ia57e7ec143bf08a245bc9ae83ac5522604344081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771101Reviewed-by:
-
Alan Cutter authored
Because AppIds are derived from start_urls we can just do an ID check instead of scanning all installed apps for the start_url. This is a refactor with no changes in behaviour. Bug: 891172 Change-Id: I9d84a8ef1edffa91a2d2ab3740db483755544e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761876 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#690271}
-
Kentaro Hara authored
This reverts commit 78d78792. Reason for revert: This broke unit_tests (CrostiniManagerRestartTest.OsReleaseSetCorrectly ) on multiple bots. https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/14819 Original change's description: > CrostiniManager stores OsRelease protos reported from containers. > > The information can change dynamically during a container session since the > user could upgrade manually. > > Bug: 930901 > Change-Id: I93fd4b227a2f93b26924c0eae0e8f005aea4e562 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765088 > Auto-Submit: Nicholas Verne <nverne@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689746} TBR=timloh@chromium.org,joelhockey@chromium.org,nverne@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 930901 Change-Id: Ib55e556ff909ee3c39232c86c6303c9324be375a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768493Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#690270}
-
Takashi Sakamoto authored
This reverts commit 02536c57. Reason for revert: suspect Step('generate .isolate files') failure on Deterministic Linux(dbg) bot Sample build: https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux%20%28dbg%29/10441 (The 10441 contains only #690259) Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8904094727741717040/+/steps/generate_.isolate_files/0/stdout?format=raw --- /b/s/w/ir/cache/builder/src/buildtools/linux64/gn gen //out/Debug --runtime-deps-list-file=/b/s/w/ir/cache/builder/src/out/Debug/runtime_deps Done. Made 11992 targets from 2025 files in 6457ms error: gn `data` items may not list generated directories; list files in directory instead for: //out/Debug/../apprtc/out/app_engine/ //out/Debug/../apprtc/temp/google-cloud-sdk/ //out/Debug/../collider/ --- Original change's description: > mb: Make check for generated `data` directories work on Win and enable there. > > The line `os.path.normpath(self.PathJoin(build_dir, f))` had two problems > on Windows: > > 1. Since `build_dir` was something like `//out/Release`, on Windows normpath > wouldn't resolve '..' against it, so `//out/Release/../../net/data` > would become `\\out\Release\net\data` > > 2. The slash flipping for `path` made the `path.startswith(build_dir)` always > fail. > > Just remove `path` completely and check if `f` starts with '../../' to find > directories that are not in the build dir instead. > > Also mixing stderr and stdout on Windows produced strange output, so print > the error message to stdout instead. > > The Windows build doesn't have any additional violations, so no new > whitelist entries are needed. > > Bug: 912946 > Change-Id: I4db9850103751b4736e5990caddddc9dd223786d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769205 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690259} TBR=thakis@chromium.org,tikuta@chromium.org Change-Id: I4379320c19d3ce29b0a24ecd247a3a59b0a5c562 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771103Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#690269}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cee7bf091f42..edb35190808c Created with: gclient setdep -r src-internal@edb35190808c The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib7366ec65617bd9b4e843b4722d6fde259456fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770944Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690268}
-
Miyoung Shin authored
This CL converts ServiceWorkerRegistrationObjectAssociated{Ptr, PtrInfo, Request} and ServiceWorkerRegistrationObjectHostAssociated{Ptr, PtrInfo} in content and blink to the new Mojo types, and uses pending_associated_remote<ServiceWorkerRegistrationObjectHost> and pending_associated_receiver<ServiceWorkerRegistrationObject> in service_worker_registration.mojom. Bug: 955171, 978694 Change-Id: Ia1c88fe08c16a722b46bf9aaa012f874d0eeb5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767287 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Fergal Daly authored
Tweak space-before-function-paren rules to be comatible with clang-format. Change-Id: I686766972996f652a8ffe15f724227279117bbb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767284 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#690266}
-
Julie Jeongeun Kim authored
This CL converts RestrictedCookieManagerRequest to new Mojo types. It also updates GetRestrictedCookieManager from network_context.mojom and methods and members which implements it. Bug: 955171, 978694 Change-Id: I8dbe736773f5446863b8b3d3d092204d66ada749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767464 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#690265}
-
Julie Jeongeun Kim authored
This CL converts BlobRequest to new Mojo types. It updates Clone from blob.mojom and Register and GetBlobFromUUID from blob_registry.mojom and methods and members to implement them. It cleans up unnecessary BlobRequest declarations, as well. Bug: 955171, 978694 Change-Id: I4d2599341445a50af92e7c09245981b6939003ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757605 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#690264}
-
Adam Rice authored
WebSocketStream is a new API for the WebSocket protocol that uses streams to support backpressure. See the explainer for more justification: https://github.com/ricea/websocketstream-explainer/blob/master/README.md This CL implements WebSocketStream behind the experimental-web-platform-features flag. See the design doc at https://docs.google.com/document/d/1XuxEshh5VYBYm1qRVKordTamCOsR-uGQBCYFcHXP4L0/edit#heading=h.7nki9mck5t64 Bug: 983030 Change-Id: I3002fd52ab151acb579e96a24985988e3fd35053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735156Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#690263}
-
Steven Bennetts authored
This also removes setNetworkProperties_ (no longer needed) from internet_detail_dialog.js, and some no longer used code from cr_onc_types.js. Bug: 853953 Change-Id: I6638351e520cf76e253b93482d985f5b97aee540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762633 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#690262}
-
Wei-Yin Chen (陳威尹) authored
Bug: 987043 Change-Id: I695cc5d1b8a83b06481c6b487b43e22ad8d24109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770089 Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#690261}
-
Anand Mistry authored
This reverts commit 753f8707. Reason for revert: Test failing on multiple bots. https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/46160 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/81082 Original change's description: > PDF a11y: kTextDirection attribute support > > The text direction attribute is now properly set for text runs in PDF. > It is inferred by the position of the first and the last characters of > a text run. > > This change includes a pdf-template file (text-direction.in) with RTL > text representation used to generate our unit test PDF file. > > Bug: 985604 > Change-Id: If5d82296463331e95c4ded4e5244d65be3fbadfa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737019 > Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#690163} TBR=thestig@chromium.org,kbabbitt@microsoft.com,benjamin.beaudry@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 985604 Change-Id: Ic276193fbc4d1d60ae234a653b1decf2094036b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768606Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#690260}
-
Nico Weber authored
The line `os.path.normpath(self.PathJoin(build_dir, f))` had two problems on Windows: 1. Since `build_dir` was something like `//out/Release`, on Windows normpath wouldn't resolve '..' against it, so `//out/Release/../../net/data` would become `\\out\Release\net\data` 2. The slash flipping for `path` made the `path.startswith(build_dir)` always fail. Just remove `path` completely and check if `f` starts with '../../' to find directories that are not in the build dir instead. Also mixing stderr and stdout on Windows produced strange output, so print the error message to stdout instead. The Windows build doesn't have any additional violations, so no new whitelist entries are needed. Bug: 912946 Change-Id: I4db9850103751b4736e5990caddddc9dd223786d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769205Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#690259}
-
Leon Han authored
The java object NfcHost is for tracking the Activity for a given WebContents on behalf of NFCImpl (Impl of the NFC interface), previously it's created per-WebContentsImpl, due to navigations happening on the given WebContentsImpl it may end up in a state serving multiple NFCImpls because NFCImpl exists per-Document, which breaks the assumption that one NfcHost can only serve one client otherwise it can not work well with WindowEventObserverManager of the WebContentsImpl. This CL starts to create multiple NfcHosts for navigations on the same WebContentsImpl rather than reusing just one instance of it. BUG=520391 Change-Id: Ice15b70d5df705be0165620579586f1ff597af99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747859 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Leon Han <leon.han@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#690258}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d48c288c0553..d5163953610a git log d48c288c0553..d5163953610a --date=short --no-merges --format='%ad %ae %s' 2019-08-26 vapier@chromium.org boolparse_lib: drop unused lib 2019-08-26 vapier@chromium.org replace basestring/unicode with six string/text types 2019-08-26 vapier@chromium.org lint: fix protected-access warnings Created with: gclient setdep -r src/third_party/chromite@d5163953610a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ie341081f9006456626b128d0c04d2257e0965838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770942Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts CustomProxyConfigClientPtr and CustomProxyConfigClientRequest to new Mojo types. Bug: 955171, 978694 Change-Id: Id536279553dd930ee68ef5d1642c06d39712cf4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767291Reviewed-by:
-
Miyoung Shin authored
This CL converts WebLaunchServiceAssociatedPtr in chrome and WebLaunchServiceAssociatedRequest in blink to the new Mojo types. Bug: 955171, 978694 Change-Id: Ic73752fe3f3525c631d9665cbc7cb967ce8c39ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767446Reviewed-by:
Jay Harris <harrisjay@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#690255}
-
