GitLab

This patch allows a NGBlockLayoutAlgorithm to "shift" its content, in
order to perform vertical-alignment within table-cells.

Previously this was done by intrinsic-padding.

And the end of layout, we "finalize" for the table cell, shifting
the content to the desired alignment location.

Within the caching logic for the common case where we don't have an
alignment baseline (for the "measure" pass), then we do (for the
"layout" pass), we hit the cache if the alignment-baseline, and the
actual baseline are the same.

Bug: 958381
Change-Id: I4a9edd3dd8ecc6e8ec90f6b7042f7af644bd0be0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500981
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821784}

The parent widget returned by this method is captured at widget
construction and reparenting.

This CL intentionally does not expose the underlying
NativeWidget/NativeView hierarchy to the widget level, because that
hierarchy is platform dependent and not consistent in various ways.

For examples of NativeWidget inconsistency on Aura,
- Usually, the root aura::Window of a NativeWidget has a parent.
- Yet, NativeWidgetAura will override parent to nullptr when
  params.child is false. The parent-child relationship is instead
  managed by TransientWindowManager.
- DesktopNativeWidgetAura will not attach child to its parent widget.
  Yet, the actually os window (e.g. HWND) will keep the relationship.

Bug: None
Change-Id: Id8bf0d393af4132b30f712e3274a100bfa5e8a85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500461
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821783}

 - Add custom css vars that can be updated at different
   breakpoints to conform to the spec.
 - Align scan preview and dropdown section.
 - Update html markup to support panel layout.

Screenshot: http://shortn/_vmZWXoAuiQ

Bug: 1059779
Test: browser_tests --gtest_filter=ScanningUIBrowserTest.All
Change-Id: I36927a2c2b9e7370916aa8d1010083bf2f6d601e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504209
Commit-Queue: Michael Checo <michaelcheco@google.com>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821782}

Bug: 1099916
Change-Id: I1fc5b170dc879a191e96eea03366366a55234655
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505832
Auto-Submit: Haiyang Pan <hypan@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821781}

Specify in the histogram README and presubmit checks that the primary
owner of a histogram needs to be a Googler, not just someone with an
@chromium.org email address.

Bug: 1142896
Change-Id: I39e522430d6cacb44c39645efb31499394e8d218
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504631
Commit-Queue: Mario Bianucci <mabian@microsoft.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821780}

Sync down local-device, contact, and certificate data from the Nearby
server when the sending or receiving flow starts, making our best effort
at freshness. We do not wait for these calls to finish. The periodic
server requests will typically be sufficient, but we don't want the user
to be blocked for hours waiting for a periodic sync.

Manually verified that the download is performed once during a sending
flow and once during a receiving flow.

Fixed: b/168834197
Change-Id: Id35e097ce09cfe7c5a85f079074943788d2359b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505009
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821779}

When enabled, the holding space tray will have an icon representative of
the holding space model contents.

As holding space items are added to the model, the icon is updated to
include a new visual representation of the added item. As holding space
items are removed from the model, stale representations are removed.

The visual representations for items are rendered using ui::Layers added
to the holding space tray icon which only exist when visible in the
viewport. This is to limit the number of layers if the user happens to
have a large number of holding space items.

Note that this CL just roughs things in. Still TODO:
- Animate bounds changes.
- Animate icon visibility changes.
- Render ImakeSkia's for items to their layers.
- Handle side shelf.

Changes are guarded by a new FeatureParam and disabled by default.

Screenshot: https://screenshot.googleplex.com/6g64LPbEUNc8o8U

Bug: 1142572
Change-Id: I3eada919a6d28ccfb208d1b15b8990d4762f3dd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499882Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#821778}

To be used in MostVisitedSites and related services in components/

Change-Id: Icba6dbd470c4bf226726b808c671edba9838a7a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500521
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821777}

Android Appliance reuses the Android Things product
type instead of falling through to Android TV.

Bug: b/171569831
Test: local product build/manual test
Change-Id: I4161ba6555bb4471677a0a6da4c9eb3129c7f285
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496193
Auto-Submit: Brett Kilty <brettk@google.com>
Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821776}

This CL ensures that the colors used by the multipaste menu are
consistent with the specs. In detail, this CL does the following jobs:
(1) Correct the image border color.
(2) Modify the menu item highlight color.
(3) Change the menu text's style and color.

Bug: 1141694, 1131729
Change-Id: I5a55b66cbf9bc0abc97160b4fb7ca2cd030363e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493833
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#821775}

Changes "vield" to "field".

Bug: b:171722197
Change-Id: Ieb9bc10dcc090486e48afa560bb836c335e0c5ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498853
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821774}

This is a revert of the changes of DeskNameView at crrev.com/c/2486781.
Since Textfield::OnThemeChanged SetBackground, we should override it
at DeskNameView::OnThemeChanged to have our own background.

Bug: 1142692
Change-Id: I24b78bd730b010a60180782d646c9b88772123f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501066Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821773}

For the exception section shown in settings -> content settings ->
pop-ups, if there are exceptions set by the policy(AllowedPopupsForUrls)
when pop-ups is blocked, they shouldn't be editable. At the same time,
if there are some exceptional allowed popups set by the user, they
remain editable. If all allowed popups urls are set by the policy, then
the "edit" button on the top right of the page should be disabled.

The UI and behaviour of the exception section is the same with above if
DefaultPopupsSetting is set to "2" (block).

Bug: 1142620
Change-Id: I0948acccc3bdf78be277b818a8f01a119a51856a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500252Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821772}

https://skia.googlesource.com/skia.git/+log/270b5c04c234..71f12666647b

2020-10-28 mtklein@google.com Revert "SkPathView for ownerless (can live on stack) SkPaths"
2020-10-28 egdaniel@google.com Fix variable name in new uma macro.
2020-10-28 johnstiles@google.com Split the SkSL pool into small and large sections.
2020-10-28 fmalita@chromium.org [svg] Convert text-anchor to a presentation attribute
2020-10-28 tdenniston@google.com Add support for arc-length metric in variable width stroke sample

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1141332
Tbr: jcgregorio@google.com
Change-Id: Ibe8a16f0af07e493d5b2153fdce327b2b41b0439
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506009Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821771}

This patch unifies creates the constraint-space for table-cells. Before
we had two different code-paths leading to subtle differences in
construction causing various types of cache misses.

This unifies the code-paths ensuring that they can remain as similar as
possible.

Bug: 958381
Change-Id: I59d7252ba3db52c36b2118d9695cea106326a1e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498836
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821770}

This would be useful to understand if there is a strong correlation
between high memory usage and UTEs. And if there is then what is the
watermark.

Bug: 1103752
Change-Id: I6792ae6837f4912225d5908d56fd751d6ce51843
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500941
Auto-Submit: Eugene But <eugenebut@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821769}

Add the first set of unit tests for LorgnetteManagerClient. These
tests cover the ListScanners() and GetScannerCapabilities() methods, as
well as several failure cases for the kScanStatusChangedSignal. Still to
be done are tests for the StartScan method. Also do some minor cleanup
of lorgnette_manager_client.cc.

Bug: b:169573779
Change-Id: I64ff7f31430db62fe21e7632db3bd2bb7be8547e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495514Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Paul Moy <pmoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821768}

Bug: 1087263
Change-Id: I6ca16d0a3037262ea03169bb582f3f67f4c62e22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505829Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821767}

Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010280700_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/bvq8h_3qcpwsdxTwUG4X0xotu2aez7gKp0cfE2xFsewC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/162704716,b/170681582,b/171154696,b/171154801,b/171773997
Tbr: media-app@grotations.appspotmail.com
Change-Id: I3fa47328d64a264bf51e71052d79a9d06de40c85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505592Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821766}

- Add overview of how perf builders, testers, and processors work
- Add tip on how to debug tests

Bug: chromium:1143048
Change-Id: Iebb8c72b47a5ef1dbc5c9171e3fa7148ebb202b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503652
Commit-Queue: Ryan Heise <heiserya@google.com>
Auto-Submit: Ryan Heise <heiserya@google.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821765}

Bug: 1015841
Change-Id: Ib301161e8011a60e8edd2be90933dae22ab0a43e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504316Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821764}

Extend HardwareDisplayControllerTest to make sure every assigned
prop has been correctly committed at modeset/disable for crtc, connector and plane.

BUG=1082882,1136610
TEST=HardwareDisplayControllerTest.{CrtcPropsAfterModeset,
ConnectorPropsAfterModeset, PlanePropsAfterModeset,
CheckDisableResetProps}

Change-Id: Ifc9a00c5d5991f0d5dea5190865aaeccdd0f5537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488363
Commit-Queue: Mark Yacoub <markyacoub@google.com>
Reviewed-by: Gil Dekel <gildekel@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821763}

Change Log:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/4b915e7092..962b067540
Full diff:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/4b915e7092..962b067540

Bug: None
Change-Id: Ib9b244cd3642c1a839febd591fc84f95cdf7bc81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504235
Commit-Queue: Danil Chapovalov <danilchap@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Auto-Submit: Danil Chapovalov <danilchap@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821762}

There's one more refactoring that I'm doing to color and css-var swatches
in DevTools frontend that require one more web test to be disable in order
to land.

Once landed, I'll write a new E2E test in devtools-frontend to cover
what this test was doing instead of just re-enabling it.

Bug: 1137438
Change-Id: I44f8ca212ab7f230c73665befff7c8334d7b91b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505619Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#821761}

The compiler needs additional flags `-isystem ...` and `-iframework ...`
to point to the iOS support headers and libraries to build iOS apps with
the macOS SDK (which is how "catalyst" builds work).

The app build for "catalyst" environment have the same bundle structure
as a regular macOS app, so the linker flag for `-rpath ...` needs to be
adjusted to work in that environment.

Bug: 1138425
Change-Id: I4cb8126d111a825408d5a63f248e56cfca99de8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498546
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821760}

It was not possible to change the login screen profile's default
bluetooth preference through settingsPrivate. This cl enables that
behavior.

Bug: b:161902990
Change-Id: Ib0f0f798994182a19ee01562d7d5899667b58525
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500445Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Billy Zhao <billyzhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821759}

The variable ios_sdk_platform_abs_path is always set to the value
of ios_sdk_platform_path. There is no need for two variables with
the same value, remove the less used one.

Bug: 1015730
Change-Id: Ie4903ff9e857be8032770c9732db105fe49829c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505812
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821758}

their default value in a machine readable way.

Add presubmit check to ensure new policies that should have defaults
specify their defaults.

Added the new default field to one of each of the types that should
have defaults to ensure the validation code works.

Default were added to:
 MaxConnectionsPerProxy
 AbusiveExperienceInterventionEnforce
 AssistantOnboardingMode
 CACertificateManagementAllowed

Bug: 1139046
Change-Id: I456d45bb98e6ffeb5447d03117f429df8936f8a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476585Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821757}

This addresses a performance regression where histograms
presubmits were taking > 2 minutes after:
https://chromium-review.googlesource.com/c/chromium/src/+/2450734

This CL adds memoization to dirmd invocations because only a few
distinct OWNERS files are specified as owners of histograms, so
we can reduce the amount of subprocess invocations significantly.

On my machine, ./tools/metrics/histograms/validate_format.py
goes from 2m8s to 25s with this change with Python 2.

Bug: 1142714
Change-Id: I1f60c60b7e6014008244c214ec7302f40e58517a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505593Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821756}

URIs of AppSocket printers saved in version <=R85 contain
incorrect path component. As a result, the do not work in
versions >=R86. This patch solves the problem by correcting
printers URIs loaded from the user profile.

BUG=chromium:1139589
TEST=tested on atlas by loading an AppSocket printer saved in the version R85

Change-Id: I664e263c36d78209e0bc1f3d291d1d3403a3c0d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490660
Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821755}

Bug: 772945
Change-Id: I0e4f7eeb0621288165b5f92eecabf6f0f742b92a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504050
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821754}

Handler takes requests from the Scanning UI to open the select dialog.

Bug: 1059779
Change-Id: Id98cdf013a4e020b3055061aac7c9dd945fe9b83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497423Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821753}

Update the mojo CSP parser:
---------------------------

Ignore directives that aren't working in report-only mode.

1) CSP:sandbox is now ignored in report-only mode. This unblocks:
   https://chromium-review.googlesource.com/c/chromium/src/+/2450093

2) CSP:treat-as-public-address is now ignored in report-only mode.
   This fixed item (B) from https://crbug.com/1142517

3) CSP:upgrade-insecure-requests is now ignored in report-only mode.
   This has not effect, because the value used was (for now) derived
   from blink.

Update the blink CSP parser:
---------------------------

1) Take into account CSP:treat-as-public-address. This was previously
   displaying annoying message:
   ```
   Unrecognized Content-Security-Policy directive
   'treat-as-public-address
   ```
   This fixed item (A) from https://crbug.com/1142517

2) Sort enum values in the modified switch statements.

Fixed: 1142517
Bug: 1041376, 1142517
Change-Id: I18bbc7220c81eeffdc17e44b21a01d2be7bd0eb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498605Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821752}

The extensions build for Chrome on iOS uses features that are not
supported in "catalyst" environment, so disable them when the app
is build for that environment.

Bug: 1138425
Change-Id: I160ad6b0288f27601d696f8b09fdfe3a3b8e68ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497453
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821751}

The change https://crrev.com/c/2368484 introduced bitmap limits while
deserializing the bitmap data in mojom transfer. This regressed large
bitmap transfers b/n the processes which used to work before
(Ex: Navigator.clipboard.write)

The limits were chosen arbitrarily to validate that the image isn't
incredibly large due to any programming error, but 32k is not a fair
limit. Increase the limit to 64k which can accommodate images from the
largest possible canvas(64k is the canvas max possible dimension)

Bug: 1142852
Change-Id: I7c6b32d8ac8549b9053178d477e7c7610add3f3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504012Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Akhila Veerapuraju <dhveerap@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#821750}

Adds trace events to HTMLPortalElement::activate,
RFHI::OnPortalActivated and PortalHost::OnPortalActivate.
In order to correlate the flow events, a trace id
is plumbed through activation flow.

Bug: 1137916
Change-Id: I8841dff33bfeaf91adc58722311672db8aa59210
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439016
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821749}

This change is part of a larger cleanup effort to make the bare
CanonicalCookie constructor private. The factory method, FromStorage,
is used for loading cookies that have already entered the user agent's
storage model into a CanonicalCookie.

Bug: 1102874
Change-Id: Iaef8b2773e596c72073dc8bce61f6fd8253d0a66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504089Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/master@{#821748}

The contact and certificate download period is 12 hours. Change the
download period of full name and icon URL from 1 hour to 12 hours.
There was no good reason why this was 1 hour. In a separate CL, all
relevant data will also be downloaded from the Nearby server when
Nearby Share is actively in use to ensure freshness.

Change-Id: I3772f5c8f88d0129a5d41367fd1222197a0ca938
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505590
Auto-Submit: Josh Nohle <nohle@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#821747}

This CL does the following:
- Focus the profile name on navigation to the profile creation flow.
- Validate the profile name input once the focus from the input field is
lost ex: click away, tab, shift + tab.

Other fixes:
- Ensure the back button is clickable and is on top of the illustartion.
- The profile theme info should be two-way binding between the profile
picker app and the local profile creation. Any changes in the color
should be reflected in the sign in promo.
- There is no need to call native to get the profile theme color on
every click on the 'Add' button in the profile picker main view. This CL
changes the behaviour to only get the color on the first click.
- Wrap the username in the remove warning message if it is too long.

Bug: 1115056
Change-Id: Iea0247ea9c73965f76bd0bdccddfcc127cb11fdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494811
Commit-Queue: Monica Basta <msalama@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821746}

Consumed block-size includes the size taken up in the fragmentainer.
When a node is overflowed, we may still generate fragments past the
block-end, to hold any overflowing content that spills into subsequent
fragmentainers, but using consumed block-size for anything but legacy
*positioning* (in the flow thread coordinate space) will produce
incorrect results. Since such fragments past the block-end of the node
end have no size, we don't have to update the logical height of the
LayoutBox at all.

Bug: 829028
Change-Id: I7f0a9cde9d9a10b37bd19219705b6b0c8556beba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505141Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821745}