- 07 Nov, 2018 40 commits
-
-
Giovanni Ortuño Urquidi authored
Changes UnifiedBluetoothDetailedViewController to update the device list every 500ms while a scan is active. Also adds a new observer method specifically for when Bluetooth State changes and changes UnifiedBluetoothDetailedViewController to use this method to update the list of devices as well. Bug: 882346 Change-Id: I13ef2555e6c4c451213afb5d405f707d5f4f19a7 Reviewed-on: https://chromium-review.googlesource.com/c/1314069Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#605951}
-
Danan S authored
The previous (now reverted) version of this CL failed to build in debug mode (and therefore broke the continuous build), because apparently static constexpr class members, which must be initialized in the class definition, are then not available at link time when is_debug=true. I didn't catch this before landing the CL because I was building with is_debug=false. The fix involved declaring the members as static const (not constexpr), and defining them in demo_mode_detector.cc. Revert "Revert "Disable Demo app launch when device is in Dev mode"" This reverts commit 225590d4. Bug: 877655 Change-Id: Id8c15012e4bfa33230feda38ec8a94ea5c809741 Reviewed-on: https://chromium-review.googlesource.com/c/1318741 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#605950}
-
Anand K. Mistry authored
BUG=900749 Change-Id: Id2da44c92c3e53aa08c60e7ae7de6eac6cd32b44 Reviewed-on: https://chromium-review.googlesource.com/c/1322169Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#605949}
-
mark a. foltz authored
This replaces custom origin formatting code with the standard formatting routine for permissions dialogs (geolocation, usb, etc.) Bug: 830177 Change-Id: I9bee4636a3095b561a1041d0228f9dc87e4504da Reviewed-on: https://chromium-review.googlesource.com/c/1321049Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#605948}
-
Emircan Uysaler authored
Some delegates called from this method may try accessing |current_frame_| which can cause deadlocks. Therefore perform these checks right after |current_frame_| is set and lock is released. Bug: 901744 Change-Id: I56605cca8bad81a498a177ff8230598abfdd03fd Reviewed-on: https://chromium-review.googlesource.com/c/1321092Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605947}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 20c48bd4. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." d2f6756a "Window onerror is not triggered bug fix" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: emircan@chromium.org: external/wpt/screen-capture guidou@chromium.org: external/wpt/mediacapture-streams hbos@chromium.org, hta@chromium.org: external/wpt/webrtc mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: If22c34613b3639294eb69c38e7a78c8564f853ad Reviewed-on: https://chromium-review.googlesource.com/c/1321857 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605946}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0e50a38dcaee..5c8d3e17aba1 git log 0e50a38dcaee..5c8d3e17aba1 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 mtklein@google.com clean up SK_LEGACY_OP_COLOR_AS_BYTES 2018-11-07 mtklein@google.com make SkColorShader RP-only 2018-11-06 mtklein@google.com remove Gauss option from SkGaussFilter Created with: gclient setdep -r src/third_party/skia@5c8d3e17aba1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I66a88c39325369eae6a6b8ffeb563816239d3733 Reviewed-on: https://chromium-review.googlesource.com/c/1321950Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605945}
-
Noel Gordon authored
The Chrome OS ASAN bots now have longer test time-outs limits and maybe enough to run the zip file tests to completion. Let's see. Bug: 867738 Change-Id: Ibda0a13ccb13095d14504c19d48d619cee5d5cd8 Reviewed-on: https://chromium-review.googlesource.com/c/1321653Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#605944}
-
BUG=762641 TBR=stevenjb@chromium.org Change-Id: Ie029f7e41a1add755c6f87f7db24ecc36b00346f Reviewed-on: https://chromium-review.googlesource.com/c/1322049Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605943}
-
Bryce Thomas authored
This CL factors CPU profiling code out of chrome/ and into content/ to support CPU profiling Headless Chromium. headless_content_main_delegate.cc has been modified to honor CPU profiling flags à la chrome_main_delegate.cc. Bug: 890456 Change-Id: I76842c5936de82d6bd42354c461aff9e0d273248 Reviewed-on: https://chromium-review.googlesource.com/c/1312157 Commit-Queue: Bryce Thomas <bryct@amazon.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#605942}
-
Anand K. Mistry authored
2.6.0 has broken AES encryption support. Also, add a unit test to ensure this keeps working. BUG=902586 Change-Id: I3554150e6eb4b5597a473df332d043f6294eb1b3 Reviewed-on: https://chromium-review.googlesource.com/c/1321651Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#605941}
-
Richard Townsend authored
This fixes a problem when using run_web_tests.py with --copy-baselines when the original test expectation does not exist for some reason. Change-Id: I43fafb982936173639d213a0fa560ef976e13fe8 Reviewed-on: https://chromium-review.googlesource.com/c/1311929 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605940}
-
Jonathan Metzman authored
https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/a305a5eb85ed..2a53098584c4 $ git log a305a5eb8..2a5309858 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 metzman [fuzzer] Read files as binary 2018-11-06 kamil Follow Windows' approach for NetBSD in AlarmCallback() 2018-11-02 phosek [compiler-rt][Fuzzer] Fix the fuzzer test build 2018-10-31 phosek [compiler-rt][Fuzzer] Use the new C++ ABI namespace CMake support 2018-10-14 metzman [libfuzzer][Windows] Silence linker warning in unittest 2018-10-10 george.karpenkov [libFuzzer] Generalize the code for getting the previous offset for different architectures 2018-10-02 phosek [lib/fuzzer] Fix logging for Fuchsia Created with: roll-dep src/third_party/libFuzzer/src Bug: 902460 Change-Id: I82ef4e6e9b35371bb82d7b5d7ae3ae7080553965 Reviewed-on: https://chromium-review.googlesource.com/c/1321583Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605939}
-
Alexei Filippov authored
BUG=901165 Change-Id: Ib29619563845f9f4002d8a01269f74b56ec478c2 Reviewed-on: https://chromium-review.googlesource.com/c/1315993 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605938}
-
Hao Zhang authored
Bug: 899057 Change-Id: I622240f7ca81f2d6227f15121509aca66256a68c Reviewed-on: https://chromium-review.googlesource.com/c/1309298 Commit-Queue: Hao Zhang <hozhng@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#605937}
-
Erik Luo authored
Fixes 2 stick to bottom cases - Prompt has text, but is scrolled out of view. User presses 'Enter'. Browsers usually scroll an field into view on input events, but Console preventsDefault to avoid adding a newline. Now, we will emulate the scroll. - Page logs a ton of messages, Console opened for the first time. CodeMirror asynchronously resized prompt height on load, which broke stick to bottom. This CL changes layout so that prompt height does not grow on editor load. Bug: 863664 Change-Id: Ia25a71100d9a895d4c8c710b36ba1d8b76d76990 Reviewed-on: https://chromium-review.googlesource.com/c/1321575Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#605936}
-
Christopher Cameron authored
Simplify BrowserCompositorMac::TransitionToState, now that we no longer have a "detached" state. The new version has 3 steps - detect no-op changes and early-out - detach from the current compositor, if there is one - attach to the new compositor, if there is one This allows the code the common code between the "parent ui layer" compositor and the "has attached compositor" state. Update the comments about the states to reflect the simpler reality. Fix a bug wherein transitioning between HasOwnCompositor and UseParentLayerCompositor would briefly hide the DelegatedFrameHost and allow the frame to be inappropriately evicted. Bug: 897156 Change-Id: If6d772a8d605568c3cdab9be0843919ded5ac5e3 Reviewed-on: https://chromium-review.googlesource.com/c/1317147 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#605935}
-
David Benjamin authored
This is "health check" histogram without a particular expiration. It's so we notice if the Android system trust store isn't accessible for some reason. (It only is recorded once on startup so it's hopefully not particularly expensive.) While I'm here, give it a better enum name. Bug: none Change-Id: I7303d7f8f1f4309d92b91ca4eaee4fa8d8cde8ea Reviewed-on: https://chromium-review.googlesource.com/c/1320649Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#605934}
-
bsheedy authored
Updates the golden image for a VR JS dialog test that was failing due to the image mismatch and re-enables the test. TBR=mthiesse@chromium.org Bug: 902319 Change-Id: I039935b788dde5b52cdf750e005fe57f9520f745 Reviewed-on: https://chromium-review.googlesource.com/c/1321794Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#605933}
-
Luciano Pacheco authored
Bug: 873539 Change-Id: Ieb7e53fac5dc0386c552148d43fb36c48a0586ac Reviewed-on: https://chromium-review.googlesource.com/c/1322010Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#605932}
-
Shu Chen authored
1. Reset the rulebased engine correctly when processing keys like Enter, ArrowLeft, etc. 2. Determine invalid match when the match start position is in the middle of (ambi + ch) for history state. Bug: 859432 Change-Id: I5b48490443c0d9ba4ee7528d7e155c816f376c09 Reviewed-on: https://chromium-review.googlesource.com/c/1319227 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#605931}
-
Shakti Sahu authored
This CL fixes the issue of long backstack for download home filters. With this fix, we would always exit download home when back pressed. While we are on download home, selecting filters will only update the current navigation entry instead of creating a new entry. Bug: 899938 Change-Id: Ia532d1441ff096a78fdc4cb509b4a99ee413ee3f Reviewed-on: https://chromium-review.googlesource.com/c/1309428 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#605930}
-
Alexey Baskakov authored
Use UpdateWebAppInfoFromManifest to merge the manifest into info. In next CLs: 1) Add scope and theme_color into WebApp. 2) Download icons and write them to disk. Bug: 901226 Change-Id: I3439983ef06c8c1bed5223ba2127a8620f1e4b55 Reviewed-on: https://chromium-review.googlesource.com/c/1319391 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#605929}
-
Adrienne Walker authored
Instead of storing and hashing the color space on every DrawImage, instead store the color space on the image decode cache itself. Bug: 902022 Change-Id: Icac6e4702f21c2bd276e8941a15ba5d96a890f04 Reviewed-on: https://chromium-review.googlesource.com/c/1318734 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#605928}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ab40518b6d4..48e9f6ccddbf Created with: gclient setdep -r src-internal@48e9f6ccddbf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id3e2d68c26216e0b0a03f6e34cc4ecc8e78ea2b0 Reviewed-on: https://chromium-review.googlesource.com/c/1321177Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605927}
-
Hiroshi Ichikawa authored
Change-Id: Ie761770f99a66885afce13c662d8a84dfc85e83c Reviewed-on: https://chromium-review.googlesource.com/c/1319210Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#605926}
-
Regan Hsu authored
Add metrics for host status during MultiDevice Setup. Bug: 870138 Change-Id: Iee0ff8ed4a1408ccb2db3ef2a9902476acd9db72 Reviewed-on: https://chromium-review.googlesource.com/c/1313338Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605925}
-
Evan Stade authored
Bug: 902171 Change-Id: I13860617a1531a98f87a5af1d342bd69ef781976 Reviewed-on: https://chromium-review.googlesource.com/c/1318841 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#605924}
-
Sami Kyostila authored
In order to speed up performance waterfall iteration time, instead of always running for 5 seconds in the SequenceManagerPerfTests, measure the wall time cost of posting 100k tasks in various configurations. We also only measure task queue scaling efficiency with specific types of sequence manager configurations. Bug: 897751 Change-Id: Iafd1d809bf5116912298b7cad10e00551939e601 Reviewed-on: https://chromium-review.googlesource.com/c/1315887Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#605923}
-
Sami Kyostila authored
In order to reduce cycle time on the performance waterfall, drop the perf test measurement period from 30s to 5s. Bug: 897751, 848499 Change-Id: I3cd921b327044f02767bc8a43a6e99e5a8a6f48f Reviewed-on: https://chromium-review.googlesource.com/c/1315967Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#605922}
-
Jun Mukai authored
Currently GestureRecognizerImplMus recceives the last touch point location through ui::EventObserver (which is supplied through ObserveEventTypes() mojo call). However, during window move, this can be late since the OnObservedInputEvent will be called after processing other event handlings in the window server. As is written in the bug, if the client observes through OnBoundsChanged(), this bounds change happens in the client before OnObservedInputEvent. This results with GetLastTouchPointForTarget returning 1-frame older location. This isn't quite observable on normal user operation but has significant differences on test scenario. Instead of observing the input, it can simply remember the offset of the touch location when the window move starts. BUG=901540 TEST=see the filter update Change-Id: I84bf19d9b705ec582b5359383a914b19c506adf9 Reviewed-on: https://chromium-review.googlesource.com/c/1321257Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#605921}
-
Luciano Pacheco authored
This reverts commit 518057ec. Reason for revert: crrev.com/c/1321649 should fix the flakiness, so let's re-enable these tests. Original change's description: > Disable tests on MSAN and ASAN > > These 2 tests are flaky on MSAN and ASAN, disabling it them until they > get fixed. > > Bug: 899664 > Change-Id: I0ee7b0fd58731f47b03637f21a55f27254ae576b > Reviewed-on: https://chromium-review.googlesource.com/c/1317210 > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605238} TBR=noel@chromium.org,lucmult@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 899664 Change-Id: Iee08e4d5bf05c09aee00023717f1351b880585b6 Reviewed-on: https://chromium-review.googlesource.com/c/1322009Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#605920}
-
John Z Wu authored
Change-Id: Id020aaffb2a2175763b37e9b72414ae06a20dcf8 Reviewed-on: https://chromium-review.googlesource.com/c/1319407Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#605919}
-
Chase Phillips authored
TL;DR IDBValue.bits was type string which worked until we added a Mojo Blink variant that introduced a new conversion requirement. IDBValue.bits is actually a sequence of octets, so use array<uint8>, instead. More details: Chrome's IndexedDB implementation uses a Mojo definition that specifies the IDBValue struct contains a field |bits|. The field is used to represent the data that's written to and read off of disk by IndexedDB's LevelDB instance. Previously, the |bits| field was of type string and there were only content variants of the Mojo C++ bindings for IndexedDB. This led to the field only ever being translated to/from std::string. std::string can contain these raw byte sequences since there are no constraints placed on the string holding data following any particular format or validation. As part of bug 717812 and https://crrev.com/1265900, a new Blink variant for the IndexedDB Mojo interfaces was added. The Blink variant relies on WTF::String instead of std::string, and so the IDBValue.bits field was translated for that variant to/from WTF::String. Mojo's WTF::String traits uses WTF::String::FromUTF8(). As part of FromUTF8()'s implementation, if the given set of characters contains invalid UTF-8 data, FromUTF8() will return a null String instance. The IDBValue.bits field is not restricted just to UTF-8 characters, and so it always ended up being set to the null String in the traits. The net result of this bug was that our carriage format changed: - Chrome with https://crrev.com/1265900 could not read Chrome stable's IDB instances - Chrome without https://crrev.com/1265900 could not read Chrome with http://crrev.com/1265900's IDB instances More about the impact of that bug can be read at https://crbug.com/899446. We must observe FromUTF8()'s requirement that we pass only UTF-8 valid data in string types. We also need to observe that we are in fact passing raw byte data in the IDBValue.bits field instead of what both variants would consider as valid strings. The fix is to change IDBValue.bits from a string type to a type of array<uint8>. LevelDB's API requires strings, so in content to/from the LevelDB instance we must pass in and receive strings. In Blink, the data is represented as a WebData instance, which also takes raw character data. To support both sides, I've added in-place conversions to/from std::string and to/from WebData. Bug: 717812 Change-Id: Iadfbd21be52fc50abc60a2695b95691bc07028e4 Reviewed-on: https://chromium-review.googlesource.com/c/1316444 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#605918}
-
Evan Stade authored
Works after 127968d6 Bug: 879308 Change-Id: Ic49eb7e0a1af70cf0701930631c6956069d4e709 Reviewed-on: https://chromium-review.googlesource.com/c/1321572Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#605917}
-
Jorge Gil authored
Launch bug: https://crbug.com/850610 Bug: b/32781610 Change-Id: I0982bf19511e1ff16543998e3845e119af3b46ea Reviewed-on: https://chromium-review.googlesource.com/c/1157279Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#605916}
-
Christian Biesinger authored
(This inverts the meaning) It is hard to understand what HasOrthogonalFlow means; this new name should be much easier to understand. Change-Id: Id6ac0d6053a7bef43a5d175d274d28c8e66c771f Reviewed-on: https://chromium-review.googlesource.com/c/1320932Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#605915}
-
Lin Sun authored
Remove following suppressions for Intel on Linux: conformance/rendering/clipping-wide-points.html BUG=642822 Change-Id: I020f57ddb4155fa7aa3d8c7ab21e86e4cb1a0868 Reviewed-on: https://chromium-review.googlesource.com/c/1309299Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Lin Sun <lin.sun@intel.com> Cr-Commit-Position: refs/heads/master@{#605914}
-
Ben Pastene authored
All of these were either renamed, or removed a while ago. R=martiniss, jbudorick Bug: 902468 Change-Id: I8f880c8b63fbbffca985eeef2ed273a75dff5d2a Reviewed-on: https://chromium-review.googlesource.com/c/1321732Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#605913}
-
Dmitry Gozman authored
Bug: 775132 Change-Id: I95a91e28bd67343c1b26c719edd0aaffc9fe9179 Reviewed-on: https://chromium-review.googlesource.com/c/1321089 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#605912}
-